mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-05-10 17:12:41 +02:00
0c5684f7ff
In1d03944a9cfailures from pushing notes were ignored entirely due to the command failing sporadically. Looking at the original commit message this was almost certainly due to the fact that multiple runs of the workflow could happend simulaneously if PRs were merged in quick succession: 1. PR 1 gets merged. 2. Workflow run 1 gets triggered for newly pushed `master` commit from PR 1 and fetches notes ref at `aaaaaaa`. 3. PR 2 gets merged. 4. Workflow run 2 gets triggered for newly pushed `master` commit from PR 2 and fetches notes ref at `aaaaaaa` as well. 5. Workflow run 1 finishes its work and pushes `bbbbbbb` to the notes ref. 6. Workflow run 2 finishes as well, tries to push `ccccccc` to the notes ref, but gets rejected. This is because its changes are based on `aaaaaaa` and cannot be fast-forwarded due to workflow run 1 having pushed different notes in the meantime. This sequence of events could also be observed afterbbad346addgot merged, which caused the first couple workflow runs after to be very slow as they were processing a large backlog of missing notes. Instead of silencing the error when it happens and relying on the fact that the next run will correct it, let's just prevent the conflict from happening in the first place by disallowing parallel runs of the workflow. This avoids unnecessary workflow runs and allows detection of other, unexpected errors happening when pushing.
28 lines
671 B
YAML
28 lines
671 B
YAML
name: Push notes
|
|
on:
|
|
push:
|
|
branches:
|
|
- master
|
|
permissions:
|
|
contents: write
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}
|
|
|
|
jobs:
|
|
build:
|
|
if: github.repository == 'LadybirdBrowser/ladybird'
|
|
runs-on: blacksmith-2vcpu-ubuntu-2404
|
|
steps:
|
|
- uses: actions/checkout@v6.0.2
|
|
with:
|
|
fetch-depth: 0
|
|
- uses: fregante/setup-git-user@v2
|
|
- run: |
|
|
git fetch origin "refs/notes/*:refs/notes/*"
|
|
curl -fsSLO https://github.com/gh-tui-tools/git-gloss/raw/refs/heads/main/git-gloss
|
|
bash ./git-gloss
|
|
git push origin "refs/notes/*"
|
|
env:
|
|
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|