mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-05-03 04:52:06 +02:00
f405d71657
81b6a11 regressed correctness by always bypassing the `next()` method
resolution for built-in iterators, causing incorrect behavior when
`next()` was redefined on built-in prototypes. This change fixes the
issue by storing a flag on built-in prototypes indicating whether
`next()` has ever been redefined.
48 lines
1.1 KiB
C++
48 lines
1.1 KiB
C++
/*
|
|
* Copyright (c) 2021, Idan Horowitz <idan.horowitz@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibJS/Runtime/Iterator.h>
|
|
#include <LibJS/Runtime/Object.h>
|
|
#include <LibJS/Runtime/Set.h>
|
|
|
|
namespace JS {
|
|
|
|
class SetIterator final : public Object
|
|
, public BuiltinIterator {
|
|
JS_OBJECT(SetIterator, Object);
|
|
GC_DECLARE_ALLOCATOR(SetIterator);
|
|
|
|
public:
|
|
static GC::Ref<SetIterator> create(Realm&, Set& set, Object::PropertyKind iteration_kind);
|
|
|
|
virtual ~SetIterator() override = default;
|
|
|
|
BuiltinIterator* as_builtin_iterator_if_next_is_not_redefined() override
|
|
{
|
|
if (m_next_method_was_redefined)
|
|
return nullptr;
|
|
return this;
|
|
}
|
|
|
|
ThrowCompletionOr<void> next(VM&, bool& done, Value& value) override;
|
|
|
|
private:
|
|
friend class SetIteratorPrototype;
|
|
|
|
explicit SetIterator(Set& set, Object::PropertyKind iteration_kind, Object& prototype);
|
|
|
|
virtual void visit_edges(Cell::Visitor&) override;
|
|
|
|
GC::Ref<Set> m_set;
|
|
bool m_done { false };
|
|
Object::PropertyKind m_iteration_kind;
|
|
Map::ConstIterator m_iterator;
|
|
};
|
|
|
|
}
|