mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-04-26 17:55:07 +02:00
5510867d58
Connected gamepads are stored on the Navigator, which means that when we navigate to a new test, they stick around, including the virtual ones we create for testing purposes. This caused issues such as the one fixed in #7329 where failing to manually disconnect a virtual gamepad meant that it would interfere with subsequent tests. We don't want to rely on tests cleaning things up correctly, so this commit introduces an automatic clean-up of these virtual gamepads. InternalGamepad objects are now tracked in Internals, and all disconnected in `Internals::perform_per_test_cleanup()`. It's named generically as I'm expecting other systems (eg, localStorage or cookies) to want similar cleanup between tests, but implementing those is left as an exercise for a future person. This method is called from signal_test_is_done(). This method is always called in the case where the test completes. A test that crashes means the WebContent isn't reused. A test that times out should also not have its WebContent process reused, though it's not clear to me what we currently do there. Verified by commenting-out the `gamepad.disconnect()` line from the Text/input/GamepadAPI/gamepad-is-available-in-new-navigables.html test and then running: ```bash for run in {1..20}; do Meta/ladybird.py run test-web -s -j1 -f GamepadAPI; done ```
100 lines
3.0 KiB
C++
100 lines
3.0 KiB
C++
/*
|
|
* Copyright (c) 2023, Andreas Kling <andreas@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibWeb/Export.h>
|
|
#include <LibWeb/Internals/InternalAnimationTimeline.h>
|
|
#include <LibWeb/Internals/InternalsBase.h>
|
|
#include <LibWeb/UIEvents/MouseButton.h>
|
|
#include <LibWeb/WebIDL/Types.h>
|
|
|
|
namespace Web::Internals {
|
|
|
|
class WEB_API Internals final : public InternalsBase {
|
|
WEB_PLATFORM_OBJECT(Internals, InternalsBase);
|
|
GC_DECLARE_ALLOCATOR(Internals);
|
|
|
|
public:
|
|
virtual ~Internals() override;
|
|
|
|
void signal_test_is_done(String const& text);
|
|
void set_test_timeout(double milliseconds);
|
|
WebIDL::ExceptionOr<void> load_reference_test_metadata();
|
|
WebIDL::ExceptionOr<void> load_test_variants();
|
|
|
|
WebIDL::ExceptionOr<String> set_time_zone(StringView time_zone);
|
|
|
|
void gc();
|
|
JS::Object* hit_test(double x, double y);
|
|
|
|
void send_text(HTML::HTMLElement&, String const&, WebIDL::UnsignedShort modifiers);
|
|
void send_key(HTML::HTMLElement&, String const&, WebIDL::UnsignedShort modifiers);
|
|
void paste(HTML::HTMLElement& target, Utf16String const& text);
|
|
void commit_text();
|
|
|
|
void click(double x, double y);
|
|
void doubleclick(double x, double y);
|
|
void middle_click(double x, double y);
|
|
void mouse_down(double x, double y);
|
|
void move_pointer_to(double x, double y);
|
|
void wheel(double x, double y, double delta_x, double delta_y);
|
|
void pinch(double x, double y, double scale_delta);
|
|
|
|
String current_cursor();
|
|
|
|
WebIDL::ExceptionOr<bool> dispatch_user_activated_event(DOM::EventTarget&, DOM::Event& event);
|
|
|
|
void spoof_current_url(String const& url);
|
|
|
|
GC::Ref<InternalAnimationTimeline> create_internal_animation_timeline();
|
|
|
|
void simulate_drag_start(double x, double y, String const& name, String const& contents);
|
|
void simulate_drag_move(double x, double y);
|
|
void simulate_drop(double x, double y);
|
|
|
|
void enable_cookies_on_file_domains();
|
|
void expire_cookies_with_time_offset(WebIDL::LongLong seconds);
|
|
|
|
bool set_http_memory_cache_enabled(bool enabled);
|
|
|
|
String get_computed_role(DOM::Element& element);
|
|
String get_computed_label(DOM::Element& element);
|
|
String get_computed_aria_level(DOM::Element& element);
|
|
|
|
static u16 get_echo_server_port();
|
|
static void set_echo_server_port(u16 port);
|
|
|
|
void set_browser_zoom(double factor);
|
|
|
|
bool headless();
|
|
|
|
String dump_display_list();
|
|
String dump_gc_graph();
|
|
|
|
GC::Ptr<DOM::ShadowRoot> get_shadow_root(GC::Ref<DOM::Element>);
|
|
|
|
void handle_sdl_input_events();
|
|
|
|
GC::Ref<InternalGamepad> connect_virtual_gamepad();
|
|
void disconnect_virtual_gamepad(GC::Ref<InternalGamepad>);
|
|
|
|
void perform_per_test_cleanup();
|
|
|
|
private:
|
|
explicit Internals(JS::Realm&);
|
|
|
|
virtual void initialize(JS::Realm&) override;
|
|
virtual void visit_edges(Visitor&) override;
|
|
|
|
void click(double x, double y, UIEvents::MouseButton);
|
|
void mouse_down(double x, double y, UIEvents::MouseButton);
|
|
|
|
Vector<GC::Ref<InternalGamepad>> m_gamepads;
|
|
};
|
|
|
|
}
|