mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-04-27 02:05:07 +02:00
d91c646788
When an element creates a stacking context (e.g. via position: relative with z-index), its text fragments were not being hit tested. This was because PaintableBox::hit_test() returns early when it has a stacking context, and StackingContext::hit_test() only iterated child paintables, not the stacking context root's own fragments. Fix this by extracting fragment hit testing into a new method hit_test_fragments() on PaintableWithLines, and calling it from StackingContext::hit_test() when the stacking context root is a PaintableWithLines.
65 lines
2.2 KiB
C++
65 lines
2.2 KiB
C++
/*
|
|
* Copyright (c) 2022-2025, Andreas Kling <andreas@ladybird.org>
|
|
* Copyright (c) 2024-2025, Aliaksandr Kalenik <kalenik.aliaksandr@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <LibGfx/Forward.h>
|
|
#include <LibWeb/Painting/PaintableBox.h>
|
|
#include <LibWeb/Painting/PaintableFragment.h>
|
|
|
|
namespace Web::Painting {
|
|
|
|
class PaintableWithLines : public PaintableBox {
|
|
GC_CELL(PaintableWithLines, PaintableBox);
|
|
GC_DECLARE_ALLOCATOR(PaintableWithLines);
|
|
|
|
public:
|
|
static GC::Ref<PaintableWithLines> create(Layout::BlockContainer const&);
|
|
static GC::Ref<PaintableWithLines> create(Layout::InlineNode const&, size_t line_index);
|
|
virtual ~PaintableWithLines() override;
|
|
|
|
virtual void reset_for_relayout() override;
|
|
|
|
Vector<PaintableFragment> const& fragments() const { return m_fragments; }
|
|
Vector<PaintableFragment>& fragments() { return m_fragments; }
|
|
|
|
void add_fragment(Layout::LineBoxFragment const& fragment)
|
|
{
|
|
m_fragments.append(PaintableFragment { fragment });
|
|
}
|
|
|
|
virtual void paint(DisplayListRecordingContext&, PaintPhase) const override;
|
|
static void paint_text_fragment_debug_highlight(DisplayListRecordingContext&, PaintableFragment const&);
|
|
|
|
[[nodiscard]] virtual TraversalDecision hit_test(CSSPixelPoint position, HitTestType type, Function<TraversalDecision(HitTestResult)> const& callback) const override;
|
|
[[nodiscard]] TraversalDecision hit_test_fragments(CSSPixelPoint position, CSSPixelPoint local_position, HitTestType type, Function<TraversalDecision(HitTestResult)> const& callback) const;
|
|
|
|
virtual void visit_edges(Cell::Visitor& visitor) override
|
|
{
|
|
Base::visit_edges(visitor);
|
|
for (auto& fragment : m_fragments)
|
|
visitor.visit(GC::Ref { fragment.layout_node() });
|
|
}
|
|
|
|
virtual void resolve_paint_properties() override;
|
|
|
|
size_t line_index() const { return m_line_index; }
|
|
|
|
protected:
|
|
PaintableWithLines(Layout::BlockContainer const&);
|
|
PaintableWithLines(Layout::InlineNode const&, size_t line_index);
|
|
|
|
private:
|
|
[[nodiscard]] virtual bool is_paintable_with_lines() const final { return true; }
|
|
|
|
Vector<PaintableFragment> m_fragments;
|
|
|
|
size_t m_line_index { 0 };
|
|
};
|
|
|
|
}
|