Files
ladybird/Libraries/LibMedia/Sinks/DisplayingVideoSink.cpp
Zaggy1024 17726f76e5 LibMedia: Skip DisplayingVideoSink::update() if the provider is null
We could hit a VERIFY in RefPtr if there was a seek in flight while the
PlaybackManager was being destroyed, since finishing a seek would run
DisplayingVideoSink::resume_updates() which would then check if there
is a new frame to display.
2026-01-30 16:58:38 +01:00

108 lines
2.9 KiB
C++

/*
* Copyright (c) 2025, Gregory Bertilson <gregory@ladybird.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibMedia/Demuxer.h>
#include <LibMedia/Providers/MediaTimeProvider.h>
#include <LibMedia/Providers/VideoDataProvider.h>
#include "DisplayingVideoSink.h"
namespace Media {
ErrorOr<NonnullRefPtr<DisplayingVideoSink>> DisplayingVideoSink::try_create(NonnullRefPtr<MediaTimeProvider> const& time_provider)
{
return TRY(try_make_ref_counted<DisplayingVideoSink>(time_provider));
}
DisplayingVideoSink::DisplayingVideoSink(NonnullRefPtr<MediaTimeProvider> const& time_provider)
: m_time_provider(time_provider)
{
}
DisplayingVideoSink::~DisplayingVideoSink() = default;
void DisplayingVideoSink::verify_track(Track const& track) const
{
if (m_provider == nullptr)
return;
VERIFY(m_track.has_value());
VERIFY(m_track.value() == track);
}
void DisplayingVideoSink::set_provider(Track const& track, RefPtr<VideoDataProvider> const& provider)
{
verify_track(track);
m_track = track;
m_provider = provider;
if (provider != nullptr)
provider->start();
}
RefPtr<VideoDataProvider> DisplayingVideoSink::provider(Track const& track) const
{
verify_track(track);
return m_provider;
}
DisplayingVideoSinkUpdateResult DisplayingVideoSink::update()
{
if (m_provider == nullptr)
return DisplayingVideoSinkUpdateResult::NoChange;
if (m_pause_updates)
return DisplayingVideoSinkUpdateResult::NoChange;
auto current_time = m_time_provider->current_time();
auto result = DisplayingVideoSinkUpdateResult::NoChange;
if (m_has_new_current_frame) {
result = DisplayingVideoSinkUpdateResult::NewFrameAvailable;
m_has_new_current_frame = false;
}
while (true) {
if (!m_next_frame.is_valid()) {
m_next_frame = m_provider->retrieve_frame();
if (!m_next_frame.is_valid()) {
if (m_provider->is_blocked() && m_on_start_buffering)
m_on_start_buffering();
break;
}
}
if (m_next_frame.timestamp() > current_time)
break;
m_current_frame = m_next_frame.release_image();
result = DisplayingVideoSinkUpdateResult::NewFrameAvailable;
}
return result;
}
void DisplayingVideoSink::prepare_current_frame_for_next_update()
{
auto update_result = update();
if (update_result == DisplayingVideoSinkUpdateResult::NewFrameAvailable)
m_has_new_current_frame = true;
}
RefPtr<Gfx::ImmutableBitmap> DisplayingVideoSink::current_frame()
{
return m_current_frame;
}
void DisplayingVideoSink::pause_updates()
{
m_pause_updates = true;
}
void DisplayingVideoSink::resume_updates()
{
m_next_frame.clear();
m_current_frame = nullptr;
m_pause_updates = false;
m_has_new_current_frame = true;
prepare_current_frame_for_next_update();
}
}