eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
640ec0b64ea97239aca8d4c2921ec4d6e056dc93
ladybird/Libraries/LibWeb/Layout
History
Andreas Kling 640ec0b64e LibWeb: Fix percentage height resolution in quirks mode 
The quirks mode percentage height calculation quirk was incorrectly
applied to anonymous boxes (like the internal flex wrapper inside
buttons), causing buttons to collapse to zero height.

Per the quirks spec, the percentage height quirk:
- Only applies to DOM elements, not anonymous boxes
- Does not apply to flex/grid items (they resolve against their
  container)
- Does not apply to table-related display types

This patch:
1. Excludes anonymous boxes and flex/grid items from the quirk in
   should_treat_height_as_auto()
2. Adds quirks mode percentage height walk-up in
   calculate_inner_height() for inline-level boxes
3. Removes the incorrect flex/grid container exclusion from
   BlockFormattingContext (the quirk applies to containers, not items)
2026-01-26 16:48:21 +01:00
..
AudioBox.cpp
LibWeb: Delete AudioPaintable::layout_box()
2025-10-10 09:03:39 +02:00
AudioBox.h
LibWeb: Delete AudioPaintable::layout_box()
2025-10-10 09:03:39 +02:00
AvailableSpace.cpp
…
AvailableSpace.h
…
BlockContainer.cpp
LibWeb: Add missing type-isolating GC allocators for some types
2026-01-18 10:10:04 +01:00
BlockContainer.h
LibWeb: Add missing type-isolating GC allocators for some types
2026-01-18 10:10:04 +01:00
BlockFormattingContext.cpp
LibWeb: Fix percentage height resolution in quirks mode
2026-01-26 16:48:21 +01:00
BlockFormattingContext.h
LibWeb: Implement CSS-Multicol's 'Pseudo-Algorithm'
2025-12-15 09:45:48 +00:00
Box.cpp
LibGC: Enforce that a Cell type must declare the allocator to use
2026-01-20 12:00:11 +01:00
Box.h
LibGC: Enforce that a Cell type must declare the allocator to use
2026-01-20 12:00:11 +01:00
BreakNode.cpp
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
BreakNode.h
Everywhere: Change west consts caught by clang-format-21 to east consts
2025-08-29 18:18:55 +01:00
CanvasBox.cpp
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
CanvasBox.h
LibWeb: Allow Layout::ImageBox to be anonymous
2025-07-28 22:46:27 +02:00
CheckBox.cpp
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
CheckBox.h
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
FieldSetBox.cpp
Meta: Disallow links to single-page HTML spec
2025-02-05 16:04:50 -07:00
FieldSetBox.h
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
FlexFormattingContext.cpp
LibWeb: Resolve percentage max-width when calculating intrinsic height
2026-01-19 12:53:13 +01:00
FlexFormattingContext.h
LibWeb: Mark flex item main size definite if resolved from aspect-ratio
2025-11-07 16:42:32 +01:00
FormAssociatedLabelableNode.h
LibWeb: Replace usages of dynamic_cast with as and as_if
2025-08-22 20:26:09 +02:00
FormattingContext.cpp
LibWeb: Fix percentage height resolution in quirks mode
2026-01-26 16:48:21 +01:00
FormattingContext.h
LibWeb: Add debug tracing for FormattingContext::run() calls
2026-01-09 08:12:21 +01:00
GridFormattingContext.cpp
LibWeb: Add debug tracing for FormattingContext::run() calls
2026-01-09 08:12:21 +01:00
GridFormattingContext.h
LibWeb: Make LengthBox hold LengthPercentageOrAuto
2025-09-04 13:31:24 +01:00
ImageBox.cpp
LibWeb: Don't assume ImageBox's image provider is the DOM node
2025-09-25 22:38:05 +01:00
ImageBox.h
LibWeb: Allow Layout::ImageBox to be anonymous
2025-07-28 22:46:27 +02:00
ImageProvider.cpp
Everywhere: Avoid large rebuilds when editing (Immutable)Bitmap headers
2025-11-28 18:32:48 +01:00
ImageProvider.h
LibWeb: Add ImageProvider virtual to access the DecodedImageData
2025-11-05 09:11:49 +01:00
InlineFormattingContext.cpp
LibWeb: Add debug tracing for FormattingContext::run() calls
2026-01-09 08:12:21 +01:00
InlineFormattingContext.h
…
InlineLevelIterator.cpp
LibWeb: Pre-generate items in InlineLevelIterator
2026-01-11 11:10:19 +01:00
InlineLevelIterator.h
LibWeb: Pre-generate items in InlineLevelIterator
2026-01-11 11:10:19 +01:00
InlineNode.cpp
LibWeb: Split PaintableWithLines from PaintableBox
2026-01-12 11:00:14 +00:00
InlineNode.h
LibWeb: Add fast_is<T> optimization for Layout::InlineNode
2025-09-22 15:00:50 +02:00
Label.cpp
AK+Everywhere: Rename verify_cast to as
2025-01-21 11:34:06 -05:00
Label.h
Everywhere: Change west consts caught by clang-format-21 to east consts
2025-08-29 18:18:55 +01:00
LabelableNode.cpp
…
LabelableNode.h
LibWeb: Allow Layout::ImageBox to be anonymous
2025-07-28 22:46:27 +02:00
LayoutState.cpp
LibWeb: Simplify paintable caching
2026-01-21 11:30:06 +01:00
LayoutState.h
LibWeb: Simplify UsedValues::static_position()
2025-08-28 13:45:37 +02:00
LegendBox.cpp
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
LegendBox.h
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
LineBox.cpp
LibWeb: Store correct text offsets in PaintableFragment
2025-09-12 15:34:09 -04:00
LineBox.h
LibWeb: Make fragment start/length size_t instead of int
2025-06-13 15:08:26 +02:00
LineBoxFragment.cpp
LibWeb: Store correct text offsets in PaintableFragment
2025-09-12 15:34:09 -04:00
LineBoxFragment.h
LibWeb: Store correct text offsets in PaintableFragment
2025-09-12 15:34:09 -04:00
LineBuilder.cpp
LibWeb/Layout: Honor hanging and each-line in text-indent
2025-11-20 16:02:40 +01:00
LineBuilder.h
LibWeb/Layout: Honor hanging and each-line in text-indent
2025-11-20 16:02:40 +01:00
ListItemBox.cpp
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
ListItemBox.h
Meta: Enforce newlines around namespaces
2025-05-14 02:01:59 -06:00
ListItemMarkerBox.cpp
AK+LibWeb/CSS: Add lower-greek counter style
2025-07-21 15:18:17 +01:00
ListItemMarkerBox.h
LibWeb: Improve graphical list item marker positioning
2025-07-17 09:35:09 +01:00
NavigableContainerViewport.cpp
LibWeb: Avoid including Navigable.h in headers
2025-10-20 10:16:55 +01:00
NavigableContainerViewport.h
LibWeb: Allow Layout::ImageBox to be anonymous
2025-07-28 22:46:27 +02:00
Node.cpp
LibWeb: Correctly parse logical border-*-*-radius shorthands
2026-01-25 10:22:10 +01:00
Node.h
LibWeb: Support inline elements as abspos containing blocks
2026-01-19 17:34:46 +01:00
RadioButton.cpp
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
RadioButton.h
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
ReplacedBox.cpp
LibWeb: Allow Layout::ImageBox to be anonymous
2025-07-28 22:46:27 +02:00
ReplacedBox.h
LibWeb: Allow Layout::ImageBox to be anonymous
2025-07-28 22:46:27 +02:00
SVGBox.cpp
LibGC: Enforce that a Cell type must declare the allocator to use
2026-01-20 12:00:11 +01:00
SVGBox.h
LibGC: Enforce that a Cell type must declare the allocator to use
2026-01-20 12:00:11 +01:00
SVGClipBox.cpp
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
SVGClipBox.h
LibWeb: Add fast_is<T> for hotly dynamic_cast'ed things on imdb.com
2025-09-25 21:42:52 +02:00
SVGForeignObjectBox.cpp
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
SVGForeignObjectBox.h
LibWeb: Make SVG foreignObject establish a new stacking context
2025-07-09 14:36:08 +02:00
SVGFormattingContext.cpp
LibWeb: Fix SVG viewport_size compounding in nested clips
2026-01-23 16:23:06 +01:00
SVGFormattingContext.h
LibWeb: Improve support for SVG text positioning attributes
2025-11-20 23:15:24 +01:00
SVGGeometryBox.cpp
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
SVGGeometryBox.h
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
SVGGraphicsBox.cpp
LibGC: Enforce that a Cell type must declare the allocator to use
2026-01-20 12:00:11 +01:00
SVGGraphicsBox.h
LibGC: Enforce that a Cell type must declare the allocator to use
2026-01-20 12:00:11 +01:00
SVGImageBox.cpp
LibGC: Enforce that a Cell type must declare the allocator to use
2026-01-20 12:00:11 +01:00
SVGImageBox.h
LibGC: Enforce that a Cell type must declare the allocator to use
2026-01-20 12:00:11 +01:00
SVGMaskBox.cpp
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
SVGMaskBox.h
AK+Everywhere: Rename verify_cast to as
2025-01-21 11:34:06 -05:00
SVGSVGBox.cpp
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
SVGSVGBox.h
LibWeb: Allow Layout::ImageBox to be anonymous
2025-07-28 22:46:27 +02:00
SVGTextBox.cpp
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
SVGTextBox.h
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
SVGTextPathBox.cpp
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
SVGTextPathBox.h
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
TableFormattingContext.cpp
LibWeb: Align anonymous table-cell flex/grid wrappers to top
2026-01-21 23:44:23 +01:00
TableFormattingContext.h
Everywhere: Change west consts caught by clang-format-21 to east consts
2025-08-29 18:18:55 +01:00
TableGrid.cpp
LibWeb/Layout: Spec-comment Table "algorithm for processing rows"
2025-11-30 11:48:14 +01:00
TableGrid.h
LibWeb: Avoid having the same code in two files
2025-12-24 14:10:27 +01:00
TableWrapper.cpp
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
TableWrapper.h
LibWeb: Make CSS::ComputedProperties GC-allocated
2024-12-22 10:12:49 +01:00
TextNode.cpp
LibWeb: Add ASCII fast path for bidi class lookups in text layout
2026-01-11 11:10:19 +01:00
TextNode.h
LibWeb: Prefer non-emoji font when deciding width of space between words
2025-11-06 23:42:01 +01:00
TreeBuilder.cpp
LibWeb: Do not generate marker boxes for list-style-type: none
2026-01-26 16:41:42 +01:00
TreeBuilder.h
LibWeb/Layout: Replace existing ::backdrop layout nodes when necessary
2026-01-22 13:52:31 +00:00
VideoBox.cpp
LibWeb: Allow Layout::ImageBox to be anonymous
2025-07-28 22:46:27 +02:00
VideoBox.h
LibGC: Only call finalize() on types that override finalize()
2026-01-07 20:51:17 +01:00
Viewport.cpp
LibWeb: Rename is_generated to is_generated_for_pseudo_element
2025-09-24 12:33:17 +01:00
Viewport.h
Everywhere: Change west consts caught by clang-format-21 to east consts
2025-08-29 18:18:55 +01:00