mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-04-25 17:25:08 +02:00
4ad800b594
When we request the HTTP cookie for a SWR request, we were providing the cookie to the standard request corresponding to the SWR request's ID. This had two effects: 1. The SWR request would never finish. 2. If the corresponding standard request happened to be a connect-only request, this would result in a crash as we were expecting it to have gone through the normal fetch process. This was seen on some articles on news.google.com.
99 lines
4.2 KiB
C++
99 lines
4.2 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <andreas@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/Badge.h>
|
|
#include <AK/HashMap.h>
|
|
#include <LibHTTP/Cache/CacheMode.h>
|
|
#include <LibHTTP/Cache/DiskCacheSettings.h>
|
|
#include <LibHTTP/Forward.h>
|
|
#include <LibIPC/ConnectionFromClient.h>
|
|
#include <LibWebSocket/WebSocket.h>
|
|
#include <RequestServer/Forward.h>
|
|
#include <RequestServer/RequestClientEndpoint.h>
|
|
#include <RequestServer/RequestServerEndpoint.h>
|
|
|
|
namespace RequestServer {
|
|
|
|
class ConnectionFromClient final
|
|
: public IPC::ConnectionFromClient<RequestClientEndpoint, RequestServerEndpoint> {
|
|
C_OBJECT(ConnectionFromClient);
|
|
|
|
public:
|
|
enum class IsPrimaryConnection {
|
|
No,
|
|
Yes,
|
|
};
|
|
|
|
using ConnectionMap = HashMap<int, NonnullRefPtr<ConnectionFromClient>>;
|
|
|
|
~ConnectionFromClient() override;
|
|
|
|
virtual void die() override;
|
|
|
|
static Optional<ConnectionFromClient&> primary_connection();
|
|
|
|
void start_revalidation_request(Badge<Request>, ByteString method, URL::URL, NonnullRefPtr<HTTP::HeaderList> request_headers, ByteBuffer request_body, HTTP::Cookie::IncludeCredentials, Core::ProxyData proxy_data);
|
|
void request_complete(Badge<Request>, Request const&);
|
|
|
|
private:
|
|
ConnectionFromClient(NonnullOwnPtr<IPC::Transport>, IsPrimaryConnection, ConnectionMap&, Optional<HTTP::DiskCache&>);
|
|
|
|
virtual Messages::RequestServer::InitTransportResponse init_transport(int peer_pid) override;
|
|
virtual Messages::RequestServer::ConnectNewClientResponse connect_new_client() override;
|
|
virtual Messages::RequestServer::ConnectNewClientsResponse connect_new_clients(size_t count) override;
|
|
|
|
virtual void set_disk_cache_settings(HTTP::DiskCacheSettings) override;
|
|
|
|
virtual Messages::RequestServer::IsSupportedProtocolResponse is_supported_protocol(ByteString) override;
|
|
virtual void set_dns_server(ByteString host_or_address, u16 port, bool use_tls, bool validate_dnssec_locally) override;
|
|
virtual void set_use_system_dns() override;
|
|
virtual void start_request(u64 request_id, ByteString, URL::URL, Vector<HTTP::Header>, ByteBuffer, HTTP::CacheMode, HTTP::Cookie::IncludeCredentials, Core::ProxyData) override;
|
|
virtual Messages::RequestServer::StopRequestResponse stop_request(u64 request_id) override;
|
|
virtual Messages::RequestServer::SetCertificateResponse set_certificate(u64 request_id, ByteString, ByteString) override;
|
|
virtual void ensure_connection(u64 request_id, URL::URL url, ::RequestServer::CacheLevel cache_level) override;
|
|
|
|
virtual void retrieved_http_cookie(int client_id, u64 request_id, RequestServer::RequestType request_type, String cookie) override;
|
|
|
|
virtual void estimate_cache_size_accessed_since(u64 cache_size_estimation_id, UnixDateTime since) override;
|
|
virtual void remove_cache_entries_accessed_since(UnixDateTime since) override;
|
|
|
|
virtual void websocket_connect(u64 websocket_id, URL::URL, ByteString, Vector<ByteString>, Vector<ByteString>, Vector<HTTP::Header>) override;
|
|
virtual void websocket_send(u64 websocket_id, bool, ByteBuffer) override;
|
|
virtual void websocket_close(u64 websocket_id, u16, ByteString) override;
|
|
virtual Messages::RequestServer::WebsocketSetCertificateResponse websocket_set_certificate(u64, ByteString, ByteString) override;
|
|
|
|
static int on_socket_callback(void*, int sockfd, int what, void* user_data, void*);
|
|
static int on_timeout_callback(void*, long timeout_ms, void* user_data);
|
|
void check_active_requests();
|
|
|
|
ErrorOr<IPC::TransportHandle> create_client_socket();
|
|
|
|
ConnectionMap& m_connections;
|
|
Optional<HTTP::DiskCache&> m_disk_cache;
|
|
|
|
void* m_curl_multi { nullptr };
|
|
|
|
HashMap<u64, NonnullOwnPtr<Request>> m_active_requests;
|
|
HashMap<u64, NonnullOwnPtr<Request>> m_active_revalidation_requests;
|
|
HashTable<u64> m_pending_websockets;
|
|
HashMap<u64, RefPtr<WebSocket::WebSocket>> m_websockets;
|
|
|
|
RefPtr<Core::Timer> m_timer;
|
|
HashMap<int, NonnullRefPtr<Core::Notifier>> m_read_notifiers;
|
|
HashMap<int, NonnullRefPtr<Core::Notifier>> m_write_notifiers;
|
|
|
|
NonnullRefPtr<Resolver> m_resolver;
|
|
ByteString m_alt_svc_cache_path;
|
|
|
|
u64 m_next_revalidation_request_id { 0 };
|
|
};
|
|
|
|
constexpr inline uintptr_t websocket_private_tag = 0x1;
|
|
|
|
}
|