mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-04-26 01:35:08 +02:00
18c40a1328
Fix two bugs in the Rust bytecode codegen:
1. has_parameter_expressions incorrectly treated any destructuring
parameter as a "parameter expression", when it should only do so
for patterns that contain expressions (defaults or computed keys).
This caused an unnecessary CreateLexicalEnvironment for simple
destructuring like `function f({a, b}) {}`. The same bug existed
in both codegen.rs and lib.rs (SFD metadata computation).
2. emit_set_variable used is_local_lexically_declared(index) for
argument locals, but that function indexes into the local_variables
array using the argument's index, checking the wrong variable.
This caused spurious ThrowIfTDZ instructions when assigning to
function arguments that happened to share an index with an
uninitialized let/const variable.
11 lines
369 B
JavaScript
11 lines
369 B
JavaScript
// Test that simple destructuring parameters (without default values or
|
|
// nested expressions) do NOT create a separate parameter environment.
|
|
// The non-local binding should use CreateVariable directly in the
|
|
// function environment, not in a new CreateLexicalEnvironment.
|
|
|
|
function f({ captured, local }) {
|
|
return () => captured;
|
|
}
|
|
|
|
f({ captured: 1, local: 2 });
|