mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-04-26 01:35:08 +02:00
9e8e568b43
Replace per-element OrderedHashMap storage for custom properties with a RefCounted chain (CustomPropertyData) that enables structural sharing. Each chain node stores only the properties declared directly on its element, with a parent pointer to the inherited chain. Elements that don't override any custom properties share the parent's data directly (just a RefPtr copy). During cascade, only entries that actually differ from the parent are stored in own_values - the rest are inherited through the chain. During var() resolution, resolved values are compared against the parent's and matching entries are dropped, enabling further sharing. The chain uses a depth limit (max 32) with flattening, plus absorption of small parent nodes (threshold 8) to keep lookups fast. This reduces custom property memory from ~79 MB to ~5.7 MB on cloudflare.com.
72 lines
2.5 KiB
C++
72 lines
2.5 KiB
C++
/*
|
|
* Copyright (c) 2025, Sam Atkins <sam@ladybird.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/OwnPtr.h>
|
|
#include <LibGC/CellAllocator.h>
|
|
#include <LibJS/Heap/Cell.h>
|
|
#include <LibWeb/CSS/CascadedProperties.h>
|
|
#include <LibWeb/CSS/CustomPropertyData.h>
|
|
#include <LibWeb/Export.h>
|
|
#include <LibWeb/Forward.h>
|
|
#include <LibWeb/PixelUnits.h>
|
|
#include <LibWeb/TreeNode.h>
|
|
|
|
namespace Web::DOM {
|
|
|
|
class WEB_API PseudoElement : public JS::Cell {
|
|
GC_CELL(PseudoElement, JS::Cell);
|
|
GC_DECLARE_ALLOCATOR(PseudoElement);
|
|
|
|
GC::Ptr<Layout::NodeWithStyle> layout_node() const { return m_layout_node; }
|
|
void set_layout_node(GC::Ptr<Layout::NodeWithStyle> value) { m_layout_node = value; }
|
|
|
|
GC::Ptr<CSS::CascadedProperties> cascaded_properties() const { return m_cascaded_properties; }
|
|
void set_cascaded_properties(GC::Ptr<CSS::CascadedProperties> value) { m_cascaded_properties = value; }
|
|
|
|
GC::Ptr<CSS::ComputedProperties> computed_properties() const { return m_computed_properties; }
|
|
void set_computed_properties(GC::Ptr<CSS::ComputedProperties> value) { m_computed_properties = value; }
|
|
|
|
RefPtr<CSS::CustomPropertyData const> custom_property_data() const { return m_custom_property_data; }
|
|
void set_custom_property_data(RefPtr<CSS::CustomPropertyData const> value) { m_custom_property_data = move(value); }
|
|
|
|
bool has_non_empty_counters_set() const { return m_counters_set; }
|
|
Optional<CSS::CountersSet const&> counters_set() const;
|
|
CSS::CountersSet& ensure_counters_set();
|
|
void set_counters_set(OwnPtr<CSS::CountersSet>&&);
|
|
|
|
CSSPixelPoint scroll_offset() const { return m_scroll_offset; }
|
|
void set_scroll_offset(CSSPixelPoint value) { m_scroll_offset = value; }
|
|
|
|
virtual void visit_edges(JS::Cell::Visitor&) override;
|
|
|
|
private:
|
|
GC::Ptr<Layout::NodeWithStyle> m_layout_node;
|
|
GC::Ptr<CSS::CascadedProperties> m_cascaded_properties;
|
|
GC::Ptr<CSS::ComputedProperties> m_computed_properties;
|
|
RefPtr<CSS::CustomPropertyData const> m_custom_property_data;
|
|
OwnPtr<CSS::CountersSet> m_counters_set;
|
|
CSSPixelPoint m_scroll_offset {};
|
|
};
|
|
|
|
// https://drafts.csswg.org/css-view-transitions/#pseudo-element-tree
|
|
class PseudoElementTreeNode
|
|
: public PseudoElement
|
|
, public TreeNode<PseudoElementTreeNode> {
|
|
GC_CELL(PseudoElementTreeNode, PseudoElement);
|
|
GC_DECLARE_ALLOCATOR(PseudoElementTreeNode);
|
|
|
|
protected:
|
|
virtual void visit_edges(JS::Cell::Visitor& visitor) override
|
|
{
|
|
Base::visit_edges(visitor);
|
|
TreeNode::visit_edges(visitor);
|
|
}
|
|
};
|
|
|
|
}
|