Files
ladybird/Libraries/LibWeb/HTML/HTMLTableRowElement.h
Tim Ledbetter d1fc4b4234 LibWeb: Route presentational hints through the CSS cascade
Previously, presentational hints bypassed the regular cascade pipeline
and wrote directly into `CascadedProperties` under
`CascadeOrigin::Author`. That meant `var()` substitution and the
invalid-at-computed-value-time fallback had to be duplicated in a
separate per-element pass, which in practice missed the IACVT step and
could leave a `GuaranteedInvalidStyleValue` in the cascaded
properties. This caused a crash in downstream code that assumed the
value had been resolved.

This introduces an `AuthorPresentationalHint` cascade origin and feeds
them through the cascade as normal declarations. This means that
`var()` resolution now happens in only one place.
2026-04-30 19:50:28 +01:00

52 lines
1.4 KiB
C++

/*
* Copyright (c) 2020, Andreas Kling <andreas@ladybird.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <LibWeb/ARIA/Roles.h>
#include <LibWeb/HTML/HTMLElement.h>
namespace Web::HTML {
class HTMLTableRowElement final : public HTMLElement {
WEB_PLATFORM_OBJECT(HTMLTableRowElement, HTMLElement);
GC_DECLARE_ALLOCATOR(HTMLTableRowElement);
public:
virtual ~HTMLTableRowElement() override;
GC::Ref<DOM::HTMLCollection> cells() const;
int row_index() const;
int section_row_index() const;
WebIDL::ExceptionOr<GC::Ref<HTMLTableCellElement>> insert_cell(i32 index);
WebIDL::ExceptionOr<void> delete_cell(i32 index);
// https://www.w3.org/TR/html-aria/#el-tr
virtual Optional<ARIA::Role> default_role() const override { return ARIA::Role::row; }
private:
HTMLTableRowElement(DOM::Document&, DOM::QualifiedName);
virtual bool is_html_table_row_element() const override { return true; }
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
virtual bool is_presentational_hint(FlyString const&) const override;
virtual void apply_presentational_hints(Vector<CSS::StyleProperty>&) const override;
GC::Ptr<DOM::HTMLCollection> mutable m_cells;
};
}
namespace Web::DOM {
template<>
inline bool Node::fast_is<HTML::HTMLTableRowElement>() const { return is_html_table_row_element(); }
}