mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-04-27 18:17:22 +02:00
f1253c7139
This patch fixes an issue where grid items using `grid-area: <name>` with no matching named grid area or lines would be incorrectly placed at position 0. According to https://www.w3.org/TR/css-grid-1/#line-placement: 1. When a `<custom-ident>` doesn't match any named line, placement should fall back to the first implicit grid line 2. When the same `<custom-ident>` is given for both `grid-*-start` and `grid-*-end` (which happens with `grid-area: name`), and both fall back to the same implicit line, the resulting span is 1 Previously, the fallback values were hardcoded to 0 and 1, which placed items in track 0. The fix changes the fallback to use `m_explicit_line_count` (the first implicit line index) for both start and end identifiers. When both reference the same line (start == end), the existing "both positioned" logic now handles this by setting span=1 and adjusting end accordingly.
15 lines
917 B
Plaintext
15 lines
917 B
Plaintext
Viewport <#document> at [0,0] [0+0+0 800 0+0+0] [0+0+0 600 0+0+0] [BFC] children: not-inline
|
|
BlockContainer <html> at [0,0] [0+0+0 800 0+0+0] [0+0+0 116 0+0+0] [BFC] children: not-inline
|
|
BlockContainer <body> at [8,8] [8+0+0 784 0+0+8] [8+0+0 100 0+0+8] children: not-inline
|
|
Box <div.grid> at [8,8] [0+0+0 100 0+0+684] [0+0+0 100 0+0+0] [GFC] children: not-inline
|
|
BlockContainer <div.item> at [8,8] [0+0+0 100 0+0+0] [0+0+0 100 0+0+0] [BFC] children: not-inline
|
|
|
|
ViewportPaintable (Viewport<#document>) [0,0 800x600]
|
|
PaintableWithLines (BlockContainer<HTML>) [0,0 800x116]
|
|
PaintableWithLines (BlockContainer<BODY>) [8,8 784x100]
|
|
PaintableBox (Box<DIV>.grid) [8,8 100x100]
|
|
PaintableWithLines (BlockContainer<DIV>.item) [8,8 100x100]
|
|
|
|
SC for Viewport<#document> [0,0 800x600] [children: 1] (z-index: auto)
|
|
SC for BlockContainer<HTML> [0,0 800x116] [children: 0] (z-index: auto)
|