eliott/libsignal
1
0
Fork 0
mirror of https://github.com/signalapp/libsignal.git synced 2026-04-26 01:35:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use separate error types for chat connect vs. send (#1431)

Browse Source
This commit is contained in:
Alex Bakon
2025-03-10 15:42:42 -04:00
committed by GitHub
parent 848f0f28b8
commit 24d2870b60
25 changed files with 386 additions and 336 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
node/ts/test/NetTest.ts
View File

@@ -49,18 +49,15 @@ describe('Net class', () => {
});
describe('chat service api', () => {
it('converts errors to native', () => {
it('converts connect errors to native', () => {
const cases: Array<[string, ErrorCode | object]> = [
['AppExpired', ErrorCode.AppExpired],
['DeviceDeregistered', ErrorCode.DeviceDelinked],
['Disconnected', ErrorCode.ChatServiceInactive],
['WebSocket', ErrorCode.IoError],
['UnexpectedFrameReceived', ErrorCode.IoError],
['ServerRequestMissingId', ErrorCode.IoError],
['IncomingDataInvalid', ErrorCode.IoError],
['RequestSendTimedOut', ErrorCode.IoError],
['TimeoutEstablishingConnection', ErrorCode.IoError],
['WebSocketConnectionFailed', ErrorCode.IoError],
['Timeout', ErrorCode.IoError],
['AllAttemptsFailed', ErrorCode.IoError],
['InvalidConnectionConfiguration', ErrorCode.IoError],
[
'RetryAfter42Seconds',
{
@@ -68,12 +65,30 @@ describe('chat service api', () => {
retryAfterSecs: 42,
},
],
];
cases.forEach((testCase) => {
const [name, expectation] = testCase;
expect(() => Native.TESTING_ChatConnectErrorConvert(name))
.throws(LibSignalErrorBase)
.to.include(
expectation instanceof Object ? expectation : { code: expectation }
);
});
});
it('converts send errors to native', () => {
const cases: Array<[string, ErrorCode | object]> = [
['Disconnected', ErrorCode.ChatServiceInactive],
['WebSocketConnectionReset', ErrorCode.IoError],
['IncomingDataInvalid', ErrorCode.IoError],
['RequestTimedOut', ErrorCode.IoError],
['RequestHasInvalidHeader', ErrorCode.IoError],
];
cases.forEach((testCase) => {
const [name, expectation] = testCase;
expect(() => Native.TESTING_ChatServiceErrorConvert(name))
expect(() => Native.TESTING_ChatSendErrorConvert(name))
.throws(LibSignalErrorBase)
.to.include(
expectation instanceof Object ? expectation : { code: expectation }