eliott/libsignal
1
0
Fork 0
mirror of https://github.com/signalapp/libsignal.git synced 2026-04-26 01:35:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

node: Replace the NPM 'uuid' package with a Rust-backed implementation

Browse Source
This commit is contained in:
Jordan Rose
2026-03-31 10:48:06 -07:00
parent c077c48393
commit f645178020
17 changed files with 115 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
node/ts/test/protocol/AddressTest.ts
View File

@@ -8,9 +8,8 @@ import * as util from '../util.js';
import { assert, use } from 'chai';
import chaiAsPromised from 'chai-as-promised';
import * as uuid from 'uuid';
import { Buffer } from 'node:buffer';
import { parseUuid } from '../../uuid.js';
import * as uuid from '../../uuid.js';
use(chaiAsPromised);
util.initLogger();
@@ -23,8 +22,8 @@ describe('ProtocolAddress', () => {
});
it('can round-trip ServiceIds', () => {
const newUuid = uuid.v4();
const aci = SignalClient.Aci.fromUuid(newUuid);
const pni = SignalClient.Pni.fromUuid(newUuid);
const aci = SignalClient.Aci.fromUuidBytes(newUuid);
const pni = SignalClient.Pni.fromUuidBytes(newUuid);
const aciAddr = SignalClient.ProtocolAddress.new(aci, 1);
const pniAddr = SignalClient.ProtocolAddress.new(pni, 1);
@@ -48,14 +47,14 @@ describe('ServiceId', () => {
const aci = SignalClient.Aci.fromUuid(testingUuid);
assert.instanceOf(aci, SignalClient.Aci);
assert.isTrue(
aci.isEqual(SignalClient.Aci.fromUuidBytes(parseUuid(testingUuid)))
aci.isEqual(SignalClient.Aci.fromUuidBytes(uuid.parse(testingUuid)))
);
assert.isFalse(aci.isEqual(SignalClient.Pni.fromUuid(testingUuid)));
assert.deepEqual(testingUuid, aci.getRawUuid());
assert.deepEqual(parseUuid(testingUuid), aci.getRawUuidBytes());
assert.deepEqual(uuid.parse(testingUuid), aci.getRawUuidBytes());
assert.deepEqual(testingUuid, aci.getServiceIdString());
assert.deepEqual(parseUuid(testingUuid), aci.getServiceIdBinary());
assert.deepEqual(uuid.parse(testingUuid), aci.getServiceIdBinary());
assert.deepEqual(`<ACI:${testingUuid}>`, `${aci}`);
{
@@ -86,12 +85,12 @@ describe('ServiceId', () => {
const pni = SignalClient.Pni.fromUuid(testingUuid);
assert.instanceOf(pni, SignalClient.Pni);
assert.isTrue(
pni.isEqual(SignalClient.Pni.fromUuidBytes(parseUuid(testingUuid)))
pni.isEqual(SignalClient.Pni.fromUuidBytes(uuid.parse(testingUuid)))
);
assert.isFalse(pni.isEqual(SignalClient.Aci.fromUuid(testingUuid)));
assert.deepEqual(testingUuid, pni.getRawUuid());
assert.deepEqual(parseUuid(testingUuid), pni.getRawUuidBytes());
assert.deepEqual(uuid.parse(testingUuid), pni.getRawUuidBytes());
assert.deepEqual(`PNI:${testingUuid}`, pni.getServiceIdString());
assert.deepEqual(
Buffer.concat([Buffer.of(0x01), pni.getRawUuidBytes()]),