Commit Graph

15 Commits

Author SHA1 Message Date
alexanderhassler
fbe0e69889 CODING_GUIDELINES.md: fix spelling of "maintenance"
Typo fix in CODING_GUIDELINES.md. No functional change.

- Before: "our own maintainence"
- After: "our own maintenance"
2026-03-13 15:16:00 -07:00
Jordan Rose
40955292f9 Update CODING_GUIDELINES (no major changes) 2026-01-21 11:39:46 -08:00
Jordan Rose
ec420b3102 bridge: Add #[bridge_callbacks] for bridging traits
This first commit only supports the C bridge, and only callback
functions that don't return anything at that. But that's sufficient to
fully cover ChatListener and ProvisioningListener.
2026-01-07 12:41:23 -08:00
Jordan Rose
26f46d3d68 android: Bump minSdkVersion to 23 2025-11-06 15:51:06 -08:00
Jordan Rose
9647f9a61a Coding Guidelines: update and elaborate on our approach to MSRV 2025-09-24 13:08:12 -07:00
Jordan Rose
cc983ef337 Document policy for error-level logs 2025-08-28 16:16:57 -07:00
Jordan Rose
67acb36a55 Bump iOS min deployment target to 15
(This is what the iOS app has been at for quite a while by now.)
2025-05-05 13:49:29 -07:00
Jordan Rose
e2b453fb18 swift: Initial audit for Sendable
- All public Swift-defined structs except CdsiLookupResponse,
  which wraps LookupResponseEntryList, which can *probably* be made
  Sendable but I didn't spend time on it.

- All public Swift-defined enums except those being used purely as
  namespaces.

- All zkgroup types, since they are immutable and can be serialized
  and deserialized to send them anyway

- ServiceId and its subclasses, an immutable class hierarchy

- ProtocolAddress, PinHash, SenderCertificate and ServerCertificate,
  and all public and private Key types, immutable wrappers around
  immutable Rust objects

More of our wrapper types could be made Sendable as well if there's a
need to. See CODING_GUIDELINES for more info.
2024-10-23 13:10:16 -07:00
Jordan Rose
f5a6e6f4a8 Remove no-longer-needed polyval_armv8 cfg, and explain aes_armv8 2024-10-08 10:43:15 -07:00
Jordan Rose
96e3fd9d37 Guidelines: avoid cargo add 2024-05-01 09:19:04 -07:00
Jordan Rose
937a89f687 Coding guideline: keep logs minimal by default 2024-04-26 16:08:52 -07:00
Alex Konradi
23764a50e8 Use @CalledFromNative to prevent stripping
Add an annotation, CalledFromNative, and directives in the proguard file that 
recognize it and prevent items it's attached to from being stripped during code 
minification. Use it in place of some existing rules, and add it to methods 
that were already being called from native code.
2024-03-21 14:10:23 -04:00
Alex Konradi
ac538311e9 Use failOnError instead of try! in Swift
Replace existing usages of try! with the failOnError helper. Add guidance to 
the coding guidelines doc.
2024-02-16 14:31:34 -05:00
Jordan Rose
b8ba4f1077 Add user-data-logging rules to CODING_GUIDELINES 2024-02-02 09:06:00 -08:00
Jordan Rose
88e87da8e6 Add a CODING_GUIDELINES doc 2024-01-19 11:06:38 -08:00