eliott/paperclip
1
0
Fork 0
mirror of https://github.com/paperclipai/paperclip synced 2026-04-25 17:25:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address Greptile navigation review

Browse Source
This commit is contained in:
Dotta
2026-04-12 21:30:50 -05:00
parent 0cb42f49ea
commit 6844226572
3 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ui/src/components/IssueLinkQuicklook.tsx
View File

@@ -5,7 +5,12 @@ import type { Issue } from "@paperclipai/shared";
import { useQuery, useQueryClient } from "@tanstack/react-query";
import { timeAgo } from "@/lib/timeAgo";
import { createIssueDetailPath, withIssueDetailHeaderSeed } from "@/lib/issueDetailBreadcrumb";
import { fetchIssueDetail, getCachedIssueDetail, prefetchIssueDetail } from "@/lib/issueDetailCache";
import {
fetchIssueDetail,
getCachedIssueDetail,
ISSUE_DETAIL_STALE_TIME_MS,
prefetchIssueDetail,
} from "@/lib/issueDetailCache";
import { queryKeys } from "@/lib/queryKeys";
import { cn } from "@/lib/utils";
import { Popover, PopoverContent, PopoverTrigger } from "@/components/ui/popover";
@@ -99,7 +104,7 @@ export const IssueLinkQuicklook = React.forwardRef<
queryFn: () => fetchIssueDetail(queryClient, issuePathId),
enabled: open,
initialData: () => cachedIssue,
staleTime: 60_000,
staleTime: ISSUE_DETAIL_STALE_TIME_MS,
});
const detailPath = createIssueDetailPath(issuePathId);

2
ui/src/lib/issueDetailCache.ts
View File

@@ -4,7 +4,7 @@ import { issuesApi } from "@/api/issues";
import { queryKeys } from "@/lib/queryKeys";
const ISSUE_DETAIL_QUERY_PREFIX = ["issues", "detail"] as const;
const ISSUE_DETAIL_STALE_TIME_MS = 60_000;
export const ISSUE_DETAIL_STALE_TIME_MS = 60_000;
function isNonEmptyString(value: unknown): value is string {
return typeof value === "string" && value.length > 0;

4
ui/src/lib/router.tsx
View File

@@ -57,9 +57,7 @@ export const Link = React.forwardRef<HTMLAnchorElement, CompanyLinkProps>(
function CompanyLink({ to, disableIssueQuicklook = false, issuePrefetch = null, ...props }, ref) {
const companyPrefix = useActiveCompanyPrefix();
const resolvedTo = resolveTo(to, companyPrefix);
const issuePathId = disableIssueQuicklook
? parseIssuePathIdFromPath(typeof resolvedTo === "string" ? resolvedTo : resolvedTo.pathname)
: parseIssuePathIdFromPath(typeof resolvedTo === "string" ? resolvedTo : resolvedTo.pathname);
const issuePathId = parseIssuePathIdFromPath(typeof resolvedTo === "string" ? resolvedTo : resolvedTo.pathname);
if (issuePathId) {
return (