mirror of
https://github.com/paperclipai/paperclip
synced 2026-05-11 09:26:42 +02:00
29401b231b
## Thinking Path > - Paperclip is a control plane for autonomous agent companies, so its release automation is part of the core operator trust boundary. > - The affected subsystem is npm/GitHub Actions release publishing for the public monorepo packages. > - The concrete failure was that a newly added package reached `master`, the canary workflow attempted its first publish, and npm trusted publishing was not yet bootstrapped for that package. > - That means the problem is not just one broken run; it is a missing pre-merge guard that lets release-ineligible packages land and only fail once `publish_canary` runs. > - This pull request makes release enrollment explicit, validates that enrollment in CI, and adds a PR-time bootstrap check against npm for changed release-enabled package manifests. > - The result is that we keep trusted publishing, avoid teaching CI to `npm adduser`, and move this class of failure from post-merge canary time to pre-merge review time. ## What Changed - Added `scripts/release-package-manifest.json` so release-managed public packages are explicitly enrolled instead of being inferred from every non-private workspace package. - Hardened `scripts/release-package-map.mjs` to validate the manifest before release workflows rewrite versions or assemble publish payloads. - Added `scripts/check-release-package-bootstrap.mjs` and wired it into `.github/workflows/pr.yml` so PRs that change a release-enabled package manifest fail if that package does not already exist on npm. - Added release-package manifest coverage tests to `scripts/release-package-map.test.mjs` and included them in `pnpm run test:release-registry`. - Wired manifest validation into `.github/workflows/release.yml` and documented the first-publish bootstrap policy in `doc/PUBLISHING.md` and `doc/RELEASE-AUTOMATION-SETUP.md`. ## Verification - `pnpm run test:release-registry` - `./scripts/release.sh canary --skip-verify --dry-run` - Confirmed the committed diff contains no obvious PII/secrets via targeted pattern scan before pushing. ## Risks - Low risk overall: this is CI/release-policy code, not product runtime logic. - The new PR bootstrap check depends on npm metadata availability, so a transient npm outage could block a PR that changes a release-enabled package manifest. - The manifest introduces a new source of truth that must stay aligned with public package additions, but that is intentional and now enforced. ## Model Used - OpenAI Codex via the `codex_local` Paperclip adapter; GPT-5-based coding agent with tool use, terminal execution, git, and GitHub CLI. Exact served model ID/context window are not exposed by the local runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge
55 lines
1.5 KiB
JavaScript
55 lines
1.5 KiB
JavaScript
import assert from "node:assert/strict";
|
|
import test from "node:test";
|
|
|
|
import { parseArgs, resolveTargetPackage } from "./bootstrap-npm-package.mjs";
|
|
|
|
test("parseArgs recognizes publish and skip-build flags", () => {
|
|
assert.deepEqual(parseArgs(["@paperclipai/adapter-acpx-local", "--publish", "--skip-build"]), {
|
|
help: false,
|
|
selector: "@paperclipai/adapter-acpx-local",
|
|
publish: true,
|
|
skipBuild: true,
|
|
otp: null,
|
|
});
|
|
});
|
|
|
|
test("parseArgs accepts an explicit otp value", () => {
|
|
assert.deepEqual(parseArgs(["packages/adapters/acpx-local", "--publish", "--otp", "123456"]), {
|
|
help: false,
|
|
selector: "packages/adapters/acpx-local",
|
|
publish: true,
|
|
skipBuild: false,
|
|
otp: "123456",
|
|
});
|
|
});
|
|
|
|
test("parseArgs leaves otp null when omitted", () => {
|
|
assert.deepEqual(parseArgs(["packages/adapters/acpx-local", "--publish"]), {
|
|
help: false,
|
|
selector: "packages/adapters/acpx-local",
|
|
publish: true,
|
|
skipBuild: false,
|
|
otp: null,
|
|
});
|
|
});
|
|
|
|
test("parseArgs returns help mode", () => {
|
|
assert.deepEqual(parseArgs(["--help"]), {
|
|
help: true,
|
|
selector: null,
|
|
publish: false,
|
|
skipBuild: false,
|
|
otp: null,
|
|
});
|
|
});
|
|
|
|
test("resolveTargetPackage matches by package name or dir", () => {
|
|
const packages = [
|
|
{ dir: "packages/a", name: "@paperclipai/a", pkg: {} },
|
|
{ dir: "packages/b", name: "@paperclipai/b", pkg: {} },
|
|
];
|
|
|
|
assert.equal(resolveTargetPackage("@paperclipai/a", packages).dir, "packages/a");
|
|
assert.equal(resolveTargetPackage("./packages/b", packages).name, "@paperclipai/b");
|
|
});
|