mirror of
https://github.com/paperclipai/paperclip
synced 2026-04-25 17:25:15 +02:00
4fdbbeced3
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Task references are a core part of how operators understand issue relationships across the UI > - Those references appear both in markdown bodies and in sidebar relationship panels > - The rendering had drifted between surfaces, and inline markdown pills were reading awkwardly inside prose and lists > - This pull request unifies the underlying issue-reference treatment, routes issue descriptions through `MarkdownBody`, and switches inline markdown references to a cleaner text-link presentation > - The benefit is more consistent issue-reference UX with better readability in markdown-heavy views ## What Changed - unified sidebar and markdown issue-reference rendering around the shared issue-reference components - routed resting issue descriptions through `MarkdownBody` so description previews inherit the richer issue-reference treatment - replaced inline markdown pill chrome with a cleaner inline reference presentation for prose contexts - added and updated UI tests for `MarkdownBody` and `InlineEditor` ## Verification - `pnpm exec vitest run --project @paperclipai/ui ui/src/components/MarkdownBody.test.tsx ui/src/components/InlineEditor.test.tsx` ## Risks - Moderate UI risk: issue-reference rendering now differs intentionally between inline markdown and relationship sidebars, so regressions would show up as styling or hover-preview mismatches > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex GPT-5-based coding agent with tool use and code execution in the Codex CLI environment ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [ ] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
62 lines
2.5 KiB
TypeScript
62 lines
2.5 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { parseIssuePathIdFromPath, parseIssueReferenceFromHref } from "./issue-reference";
|
|
|
|
describe("issue-reference", () => {
|
|
it("extracts issue ids from company-scoped issue paths", () => {
|
|
expect(parseIssuePathIdFromPath("/PAP/issues/PAP-1271")).toBe("PAP-1271");
|
|
expect(parseIssuePathIdFromPath("/PAP/issues/pap-1272")).toBe("PAP-1272");
|
|
expect(parseIssuePathIdFromPath("/issues/PAP-1179")).toBe("PAP-1179");
|
|
expect(parseIssuePathIdFromPath("/issues/:id")).toBeNull();
|
|
});
|
|
|
|
it("extracts issue ids from full issue URLs", () => {
|
|
expect(parseIssuePathIdFromPath("http://localhost:3100/PAP/issues/PAP-1179")).toBe("PAP-1179");
|
|
});
|
|
|
|
it("does not treat GitHub issue URLs as internal Paperclip issue links", () => {
|
|
expect(parseIssuePathIdFromPath("https://github.com/paperclipai/paperclip/issues/1778")).toBeNull();
|
|
expect(parseIssueReferenceFromHref("https://github.com/paperclipai/paperclip/issues/1778")).toBeNull();
|
|
});
|
|
|
|
it("ignores placeholder issue paths", () => {
|
|
expect(parseIssuePathIdFromPath("/issues/:id")).toBeNull();
|
|
expect(parseIssuePathIdFromPath("http://localhost:3100/issues/:id")).toBeNull();
|
|
expect(parseIssueReferenceFromHref("/issues/:id")).toBeNull();
|
|
});
|
|
|
|
it("normalizes bare identifiers, issue URLs, and issue scheme links into internal links", () => {
|
|
expect(parseIssueReferenceFromHref("pap-1271")).toEqual({
|
|
issuePathId: "PAP-1271",
|
|
href: "/issues/PAP-1271",
|
|
});
|
|
expect(parseIssueReferenceFromHref("http://localhost:3100/PAP/issues/PAP-1179")).toEqual({
|
|
issuePathId: "PAP-1179",
|
|
href: "/issues/PAP-1179",
|
|
});
|
|
expect(parseIssueReferenceFromHref("/PAP/issues/pap-1180")).toEqual({
|
|
issuePathId: "PAP-1180",
|
|
href: "/issues/PAP-1180",
|
|
});
|
|
expect(parseIssueReferenceFromHref("issue://PAP-1310")).toEqual({
|
|
issuePathId: "PAP-1310",
|
|
href: "/issues/PAP-1310",
|
|
});
|
|
expect(parseIssueReferenceFromHref("issue://:PAP-1311")).toEqual({
|
|
issuePathId: "PAP-1311",
|
|
href: "/issues/PAP-1311",
|
|
});
|
|
});
|
|
|
|
it("normalizes exact inline-code-like issue identifiers", () => {
|
|
expect(parseIssueReferenceFromHref("PAP-1271")).toEqual({
|
|
issuePathId: "PAP-1271",
|
|
href: "/issues/PAP-1271",
|
|
});
|
|
});
|
|
|
|
it("ignores literal route placeholder paths", () => {
|
|
expect(parseIssueReferenceFromHref("/issues/:id")).toBeNull();
|
|
expect(parseIssueReferenceFromHref("http://localhost:3100/api/issues/:id")).toBeNull();
|
|
});
|
|
});
|