mirror of
https://github.com/paperclipai/paperclip
synced 2026-04-25 17:25:15 +02:00
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - A fast-moving control plane needs stable local tests and repeatable local maintenance tools so contributors can safely split and review work > - Several route suites needed stronger isolation, Codex manual model selection needed a faster-mode option, and local browser cleanup missed Playwright's headless shell binary > - Storybook static output also needed to be preserved as a generated review artifact from the working branch > - This pull request groups the test/local-dev maintenance pieces so they can be reviewed separately from product runtime changes > - The benefit is more predictable contributor verification and cleaner local maintenance without mixing these changes into feature PRs ## What Changed - Added stable Vitest runner support and serialized route/authz test isolation. - Fixed workspace runtime authz route mocks and stabilized Claude/company-import related assertions. - Allowed Codex fast mode for manually selected models. - Broadened the agent browser cleanup script to detect `chrome-headless-shell` as well as Chrome for Testing. - Preserved generated Storybook static output from the source branch. ## Verification - `pnpm exec vitest run src/__tests__/workspace-runtime-routes-authz.test.ts src/__tests__/claude-local-execute.test.ts --config vitest.config.ts` from `server/` passed: 2 files, 19 tests. - `pnpm exec vitest run src/server/codex-args.test.ts --config vitest.config.ts` from `packages/adapters/codex-local/` passed: 1 file, 3 tests. - `bash -n scripts/kill-agent-browsers.sh && scripts/kill-agent-browsers.sh --dry` passed; dry-run detected `chrome-headless-shell` processes without killing them. - `test -f ui/storybook-static/index.html && test -f ui/storybook-static/assets/forms-editors.stories-Dry7qwx2.js` passed. - `git diff --check public-gh/master..pap-2228-test-local-maintenance -- . ':(exclude)ui/storybook-static'` passed. - `pnpm exec vitest run cli/src/__tests__/company-import-export-e2e.test.ts --config cli/vitest.config.ts` did not complete in the isolated split worktree because `paperclipai run` exited during build prep with `TS2688: Cannot find type definition file for 'react'`; this appears to be caused by the worktree dependency symlink setup, not the code under test. - Confirmed this PR does not include `pnpm-lock.yaml`. ## Risks - Medium risk: the stable Vitest runner changes how route/authz tests are scheduled. - Generated `ui/storybook-static` files are large and contain minified third-party output; `git diff --check` reports whitespace inside those generated assets, so reviewers may choose to drop or regenerate that artifact before merge. - No database migrations. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex coding agent based on GPT-5, with shell, git, Paperclip API, and GitHub CLI tool use in the local Paperclip workspace. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge Note: screenshot checklist item is not applicable to source UI behavior; the included Storybook static output is generated artifact preservation from the source branch. --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
165 lines
3.7 KiB
TypeScript
165 lines
3.7 KiB
TypeScript
import express from "express";
|
|
import request from "supertest";
|
|
import { describe, expect, it } from "vitest";
|
|
import { errorHandler } from "../middleware/index.js";
|
|
import { authRoutes } from "../routes/auth.js";
|
|
|
|
function createSelectChain(rows: unknown[]) {
|
|
return {
|
|
from() {
|
|
return {
|
|
where() {
|
|
return Promise.resolve(rows);
|
|
},
|
|
};
|
|
},
|
|
};
|
|
}
|
|
|
|
function createUpdateChain(row: unknown) {
|
|
return {
|
|
set(values: unknown) {
|
|
return {
|
|
where() {
|
|
return {
|
|
returning() {
|
|
return Promise.resolve([{ ...(row as Record<string, unknown>), ...(values as Record<string, unknown>) }]);
|
|
},
|
|
};
|
|
},
|
|
};
|
|
},
|
|
};
|
|
}
|
|
|
|
function createDb(row: Record<string, unknown>) {
|
|
return {
|
|
select: () => createSelectChain([row]),
|
|
update: () => createUpdateChain(row),
|
|
} as any;
|
|
}
|
|
|
|
function createApp(actor: Express.Request["actor"], row: Record<string, unknown>) {
|
|
const app = express();
|
|
app.use(express.json());
|
|
app.use((req, _res, next) => {
|
|
req.actor = actor;
|
|
next();
|
|
});
|
|
app.use("/api/auth", authRoutes(createDb(row)));
|
|
app.use(errorHandler);
|
|
return app;
|
|
}
|
|
|
|
describe.sequential("auth routes", () => {
|
|
const baseUser = {
|
|
id: "user-1",
|
|
name: "Jane Example",
|
|
email: "jane@example.com",
|
|
image: "https://example.com/jane.png",
|
|
};
|
|
|
|
it("returns the persisted user profile in the session payload", async () => {
|
|
const app = await createApp(
|
|
{
|
|
type: "board",
|
|
userId: "user-1",
|
|
source: "session",
|
|
},
|
|
baseUser,
|
|
);
|
|
|
|
const res = await request(app).get("/api/auth/get-session");
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body).toEqual({
|
|
session: {
|
|
id: "paperclip:session:user-1",
|
|
userId: "user-1",
|
|
},
|
|
user: baseUser,
|
|
});
|
|
});
|
|
|
|
it("updates the signed-in profile", async () => {
|
|
const app = await createApp(
|
|
{
|
|
type: "board",
|
|
userId: "user-1",
|
|
source: "local_implicit",
|
|
},
|
|
baseUser,
|
|
);
|
|
|
|
const res = await request(app)
|
|
.patch("/api/auth/profile")
|
|
.send({ name: "Board Operator", image: "" });
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body).toMatchObject({
|
|
id: "user-1",
|
|
name: "Board Operator",
|
|
email: "jane@example.com",
|
|
image: null,
|
|
});
|
|
});
|
|
|
|
it("preserves the existing avatar when updating only the profile name", async () => {
|
|
const app = await createApp(
|
|
{
|
|
type: "board",
|
|
userId: "user-1",
|
|
source: "local_implicit",
|
|
},
|
|
baseUser,
|
|
);
|
|
|
|
const res = await request(app)
|
|
.patch("/api/auth/profile")
|
|
.send({ name: "Board Operator" });
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body).toMatchObject({
|
|
id: "user-1",
|
|
name: "Board Operator",
|
|
email: "jane@example.com",
|
|
image: "https://example.com/jane.png",
|
|
});
|
|
});
|
|
|
|
it("accepts Paperclip asset paths for avatars", async () => {
|
|
const app = await createApp(
|
|
{
|
|
type: "board",
|
|
userId: "user-1",
|
|
source: "session",
|
|
},
|
|
baseUser,
|
|
);
|
|
|
|
const res = await request(app)
|
|
.patch("/api/auth/profile")
|
|
.send({ name: "Jane Example", image: "/api/assets/asset-1/content" });
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.image).toBe("/api/assets/asset-1/content");
|
|
});
|
|
|
|
it("rejects invalid avatar image references", async () => {
|
|
const app = await createApp(
|
|
{
|
|
type: "board",
|
|
userId: "user-1",
|
|
source: "session",
|
|
},
|
|
baseUser,
|
|
);
|
|
|
|
const res = await request(app)
|
|
.patch("/api/auth/profile")
|
|
.send({ name: "Jane Example", image: "not-a-url" });
|
|
|
|
expect(res.status).toBe(400);
|
|
});
|
|
});
|