mirror of
https://github.com/paperclipai/paperclip
synced 2026-04-25 17:25:15 +02:00
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - Operators supervise that work through issues, comments, approvals, and the board UI. > - Some agent proposals need structured board/user decisions, not hidden markdown conventions or heavyweight governed approvals. > - Issue-thread interactions already provide a natural thread-native surface for proposed tasks and questions. > - This pull request extends that surface with request confirmations, richer interaction cards, and agent/plugin/MCP helpers. > - The benefit is that plan approvals and yes/no decisions become explicit, auditable, and resumable without losing the single-issue workflow. ## What Changed - Added persisted issue-thread interactions for suggested tasks, structured questions, and request confirmations. - Added board UI cards for interaction review, selection, question answers, and accept/reject confirmation flows. - Added MCP and plugin SDK helpers for creating interaction cards from agents/plugins. - Updated agent wake instructions, onboarding assets, Paperclip skill docs, and public docs to prefer structured confirmations for issue-scoped decisions. - Rebased the branch onto `public-gh/master` and renumbered branch migrations to `0063` and `0064`; the idempotency migration uses `ADD COLUMN IF NOT EXISTS` for old branch users. ## Verification - `git diff --check public-gh/master..HEAD` - `pnpm exec vitest run packages/adapter-utils/src/server-utils.test.ts packages/mcp-server/src/tools.test.ts packages/shared/src/issue-thread-interactions.test.ts ui/src/lib/issue-thread-interactions.test.ts ui/src/lib/issue-chat-messages.test.ts ui/src/components/IssueThreadInteractionCard.test.tsx ui/src/components/IssueChatThread.test.tsx server/src/__tests__/issue-thread-interaction-routes.test.ts server/src/__tests__/issue-thread-interactions-service.test.ts server/src/services/issue-thread-interactions.test.ts` -> 9 files / 79 tests passed - `pnpm -r typecheck` -> passed, including `packages/db` migration numbering check ## Risks - Medium: this adds a new issue-thread interaction model across db/shared/server/ui/plugin surfaces. - Migration risk is reduced by placing this branch after current master migrations (`0063`, `0064`) and making the idempotency column add idempotent for users who applied the old branch numbering. - UI interaction behavior is covered by component tests, but this PR does not include browser screenshots. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-class coding agent runtime. Exact model ID and context window are not exposed in this Paperclip run; tool use and local shell/code execution were enabled. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
279 lines
7.6 KiB
TypeScript
279 lines
7.6 KiB
TypeScript
import express from "express";
|
|
import request from "supertest";
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
const mockStorage = vi.hoisted(() => ({
|
|
headObject: vi.fn(),
|
|
}));
|
|
|
|
function registerModuleMocks() {
|
|
vi.doMock("../storage/index.js", () => ({
|
|
getStorageService: () => mockStorage,
|
|
}));
|
|
}
|
|
|
|
function createSelectChain(rows: unknown[]) {
|
|
const query = {
|
|
then(resolve: (value: unknown[]) => unknown) {
|
|
return Promise.resolve(rows).then(resolve);
|
|
},
|
|
leftJoin() {
|
|
return query;
|
|
},
|
|
orderBy() {
|
|
return query;
|
|
},
|
|
where() {
|
|
return query;
|
|
},
|
|
};
|
|
return {
|
|
from() {
|
|
return query;
|
|
},
|
|
};
|
|
}
|
|
|
|
function createDbStub(...selectResponses: unknown[][]) {
|
|
let selectCall = 0;
|
|
return {
|
|
select() {
|
|
const rows = selectResponses[selectCall] ?? [];
|
|
selectCall += 1;
|
|
return createSelectChain(rows);
|
|
},
|
|
};
|
|
}
|
|
|
|
async function createApp(
|
|
db: Record<string, unknown>,
|
|
actor: Record<string, unknown> = { type: "anon" },
|
|
) {
|
|
const [{ accessRoutes }, { errorHandler }] = await Promise.all([
|
|
vi.importActual<typeof import("../routes/access.js")>("../routes/access.js"),
|
|
vi.importActual<typeof import("../middleware/index.js")>("../middleware/index.js"),
|
|
]);
|
|
const app = express();
|
|
app.use((req, _res, next) => {
|
|
(req as any).actor = actor;
|
|
next();
|
|
});
|
|
app.use(
|
|
"/api",
|
|
accessRoutes(db as any, {
|
|
deploymentMode: "local_trusted",
|
|
deploymentExposure: "private",
|
|
bindHost: "127.0.0.1",
|
|
allowedHostnames: [],
|
|
}),
|
|
);
|
|
app.use(errorHandler);
|
|
return app;
|
|
}
|
|
|
|
describe("GET /invites/:token", () => {
|
|
beforeEach(() => {
|
|
vi.resetModules();
|
|
vi.doUnmock("../storage/index.js");
|
|
vi.doUnmock("../routes/access.js");
|
|
vi.doUnmock("../middleware/index.js");
|
|
registerModuleMocks();
|
|
mockStorage.headObject.mockReset();
|
|
mockStorage.headObject.mockResolvedValue({ exists: true, contentLength: 3, contentType: "image/png" });
|
|
});
|
|
|
|
it("returns company branding in the invite summary response", async () => {
|
|
const invite = {
|
|
id: "invite-1",
|
|
companyId: "company-1",
|
|
inviteType: "company_join",
|
|
allowedJoinTypes: "human",
|
|
tokenHash: "hash",
|
|
defaultsPayload: null,
|
|
expiresAt: new Date("2027-03-07T00:10:00.000Z"),
|
|
invitedByUserId: null,
|
|
revokedAt: null,
|
|
acceptedAt: null,
|
|
createdAt: new Date("2026-03-07T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-07T00:00:00.000Z"),
|
|
};
|
|
const app = await createApp(
|
|
createDbStub(
|
|
[invite],
|
|
[
|
|
{
|
|
name: "Acme Robotics",
|
|
brandColor: "#114488",
|
|
logoAssetId: "logo-1",
|
|
},
|
|
],
|
|
[
|
|
{
|
|
companyId: "company-1",
|
|
objectKey: "company-1/assets/companies/logo-1",
|
|
contentType: "image/png",
|
|
byteSize: 3,
|
|
originalFilename: "logo.png",
|
|
},
|
|
],
|
|
),
|
|
);
|
|
|
|
const res = await request(app).get("/api/invites/pcp_invite_test");
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.companyId).toBe("company-1");
|
|
expect(res.body.companyName).toBe("Acme Robotics");
|
|
expect(res.body.companyBrandColor).toBe("#114488");
|
|
expect(res.body.companyLogoUrl).toBe("/api/invites/pcp_invite_test/logo");
|
|
expect(res.body.inviteType).toBe("company_join");
|
|
});
|
|
|
|
it("omits companyLogoUrl when the stored logo object is missing", async () => {
|
|
mockStorage.headObject.mockResolvedValue({ exists: false });
|
|
|
|
const invite = {
|
|
id: "invite-1",
|
|
companyId: "company-1",
|
|
inviteType: "company_join",
|
|
allowedJoinTypes: "human",
|
|
tokenHash: "hash",
|
|
defaultsPayload: null,
|
|
expiresAt: new Date("2027-03-07T00:10:00.000Z"),
|
|
invitedByUserId: null,
|
|
revokedAt: null,
|
|
acceptedAt: null,
|
|
createdAt: new Date("2026-03-07T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-07T00:00:00.000Z"),
|
|
};
|
|
const app = await createApp(
|
|
createDbStub(
|
|
[invite],
|
|
[
|
|
{
|
|
name: "Acme Robotics",
|
|
brandColor: "#114488",
|
|
logoAssetId: "logo-1",
|
|
},
|
|
],
|
|
[
|
|
{
|
|
companyId: "company-1",
|
|
objectKey: "company-1/assets/companies/logo-1",
|
|
contentType: "image/png",
|
|
byteSize: 3,
|
|
originalFilename: "logo.png",
|
|
},
|
|
],
|
|
),
|
|
);
|
|
|
|
const res = await request(app).get("/api/invites/pcp_invite_test");
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.companyLogoUrl).toBeNull();
|
|
});
|
|
|
|
it("returns pending join-request status for an already-accepted invite", async () => {
|
|
const invite = {
|
|
id: "invite-1",
|
|
companyId: "company-1",
|
|
inviteType: "company_join",
|
|
allowedJoinTypes: "human",
|
|
tokenHash: "hash",
|
|
defaultsPayload: null,
|
|
expiresAt: new Date("2027-03-07T00:10:00.000Z"),
|
|
invitedByUserId: null,
|
|
revokedAt: null,
|
|
acceptedAt: new Date("2026-03-07T00:05:00.000Z"),
|
|
createdAt: new Date("2026-03-07T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-07T00:05:00.000Z"),
|
|
};
|
|
const app = await createApp(
|
|
createDbStub(
|
|
[invite],
|
|
[{ requestType: "human", status: "pending_approval" }],
|
|
[
|
|
{
|
|
name: "Acme Robotics",
|
|
brandColor: "#114488",
|
|
logoAssetId: "logo-1",
|
|
},
|
|
],
|
|
[
|
|
{
|
|
companyId: "company-1",
|
|
objectKey: "company-1/assets/companies/logo-1",
|
|
contentType: "image/png",
|
|
byteSize: 3,
|
|
originalFilename: "logo.png",
|
|
},
|
|
],
|
|
),
|
|
);
|
|
|
|
const res = await request(app).get("/api/invites/pcp_invite_test");
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.joinRequestStatus).toBe("pending_approval");
|
|
expect(res.body.joinRequestType).toBe("human");
|
|
expect(res.body.companyName).toBe("Acme Robotics");
|
|
});
|
|
|
|
it("falls back to a reusable human join request when the accepted invite reused an existing queue entry", async () => {
|
|
const invite = {
|
|
id: "invite-2",
|
|
companyId: "company-1",
|
|
inviteType: "company_join",
|
|
allowedJoinTypes: "human",
|
|
tokenHash: "hash",
|
|
defaultsPayload: null,
|
|
expiresAt: new Date("2027-03-07T00:10:00.000Z"),
|
|
invitedByUserId: null,
|
|
revokedAt: null,
|
|
acceptedAt: new Date("2026-03-07T00:05:00.000Z"),
|
|
createdAt: new Date("2026-03-07T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-07T00:05:00.000Z"),
|
|
};
|
|
const reusableJoinRequest = {
|
|
id: "join-1",
|
|
requestType: "human",
|
|
status: "pending_approval",
|
|
requestingUserId: "user-1",
|
|
requestEmailSnapshot: "jane@example.com",
|
|
};
|
|
const companyBranding = {
|
|
name: "Acme Robotics",
|
|
brandColor: "#114488",
|
|
logoAssetId: "logo-1",
|
|
};
|
|
const logoAsset = {
|
|
companyId: "company-1",
|
|
objectKey: "company-1/assets/companies/logo-1",
|
|
contentType: "image/png",
|
|
byteSize: 3,
|
|
originalFilename: "logo.png",
|
|
};
|
|
const app = await createApp(
|
|
createDbStub(
|
|
[invite],
|
|
[],
|
|
[{ email: "jane@example.com" }],
|
|
[reusableJoinRequest],
|
|
[reusableJoinRequest],
|
|
[companyBranding],
|
|
[companyBranding],
|
|
[logoAsset],
|
|
[logoAsset],
|
|
),
|
|
{ type: "board", userId: "user-1", source: "session" },
|
|
);
|
|
|
|
const res = await request(app).get("/api/invites/pcp_invite_test");
|
|
|
|
expect(res.status).toBe(200);
|
|
expect(res.body.joinRequestStatus).toBe("pending_approval");
|
|
expect(res.body.joinRequestType).toBe("human");
|
|
});
|
|
});
|