eliott/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2026-04-26 01:25:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibURL+LibWeb: Do not percent decode in password/username getters

Browse Source 
Doing it is not part of the spec. Whenever needed, the spec will
explicitly percent decode the username and password.

This fixes some URL WPT tests.

(cherry picked from commit f511c0b441a591bc85f409242229c7b295e118e4)
This commit is contained in:
Shannon Booth
2024-08-04 22:02:02 +12:00
committed by Nico Weber
parent b4d3a6016e
commit 1308cab372
14 changed files with 62 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/HTMLHyperlinkElementUtils.cpp
View File

@@ -97,7 +97,7 @@ String HTMLHyperlinkElementUtils::username() const
return String {};
// 3. Return this element's url's username.
return m_url->username().release_value();
return m_url->username();
}
// https://html.spec.whatwg.org/multipage/links.html#dom-hyperlink-username
@@ -134,7 +134,7 @@ String HTMLHyperlinkElementUtils::password() const
return String {};
// 4. Return url's password.
return url->password().release_value();
return url->password();
}
// https://html.spec.whatwg.org/multipage/links.html#dom-hyperlink-password