eliott/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2026-05-03 21:02:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Don't group radio buttons from different trees together

Browse Source 
Previously, we were searching for other radio buttons from the document
root, rather than the element root.

(cherry picked from commit 67981af276cf55d69d51a872ec83e5b59d793b6c)
This commit is contained in:
Tim Ledbetter
2024-09-10 23:51:24 +01:00
committed by Nico Weber
parent 15bec1d67f
commit 3d130ee6ef
3 changed files with 31 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View File

@@ -1476,8 +1476,9 @@ static bool is_in_same_radio_button_group(HTML::HTMLInputElement const& a, HTML:
// other input elements b that fulfill all of the following conditions:
return (
// - Both a and b are in the same tree.
&a.root() == &b.root()
// - The input element b's type attribute is in the Radio Button state.
a.type_state() == b.type_state()
&& a.type_state() == b.type_state()
&& b.type_state() == HTMLInputElement::TypeAttributeState::RadioButton
// - Either a and b have the same form owner, or they both have no form owner.
&& a.form() == b.form()
@@ -1500,7 +1501,7 @@ void HTMLInputElement::set_checked_within_group()
if (!name().has_value() || name()->is_empty())
return;
document().for_each_in_inclusive_subtree_of_type<HTML::HTMLInputElement>([&](auto& element) {
root().for_each_in_inclusive_subtree_of_type<HTML::HTMLInputElement>([&](auto& element) {
if (element.checked() && &element != this && is_in_same_radio_button_group(*this, element))
element.set_checked(false, ChangeSource::User);
return TraversalDecision::Continue;
@@ -1527,7 +1528,7 @@ void HTMLInputElement::legacy_pre_activation_behavior()
// has its checkedness set to true, if any, and then set this element's
// checkedness to true.
if (type_state() == TypeAttributeState::RadioButton) {
document().for_each_in_inclusive_subtree_of_type<HTML::HTMLInputElement>([&](auto& element) {
root().for_each_in_inclusive_subtree_of_type<HTML::HTMLInputElement>([&](auto& element) {
if (element.checked() && is_in_same_radio_button_group(*this, element)) {
m_legacy_pre_activation_behavior_checked_element_in_group = &element;
return TraversalDecision::Break;