eliott/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2026-04-26 01:25:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Actually perform "update the href steps"

Browse Source 
We completely missed this step, which made setters not actually do
anything!

Fixes 336 test failures on:

https://wpt.live/url/url-setters-a-area.window.html
(cherry picked from commit deff8df2c79af718f08f16bc47f5a22ac6add553)
This commit is contained in:
Shannon Booth
2024-08-08 22:26:59 +12:00
committed by Nico Weber
parent db01e39913
commit 51b710bce1
3 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Userland/Libraries/LibWeb/HTML/HTMLHyperlinkElementUtils.cpp
View File

@@ -451,6 +451,7 @@ WebIDL::ExceptionOr<void> HTMLHyperlinkElementUtils::set_href(String href)
void HTMLHyperlinkElementUtils::update_href()
{
// To update href, set the element's href content attribute's value to the element's url, serialized.
MUST(set_hyperlink_element_utils_href(MUST(String::from_byte_string(m_url->serialize()))));
}
bool HTMLHyperlinkElementUtils::cannot_navigate() const