eliott/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2026-05-03 21:02:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Cap HTML dimension values at 17895700 (same as Firefox)

Browse Source 
Instead of allowing arbitrarily large values (which could eventually
overflow an i32), let's just cap them at the same limit as Firefox does.

Found by Domato.

(cherry picked from commit 4e0edd42b95abf8ad707c64414dbe618313ce89e)
This commit is contained in:
Andreas Kling
2024-07-19 16:15:07 +02:00
committed by Nico Weber
parent e99c005c80
commit 7ddd8bac62
3 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Userland/Libraries/LibWeb/HTML/Parser/HTMLParser.cpp
View File

@@ -4691,13 +4691,16 @@ RefPtr<CSS::StyleValue> parse_dimension_value(StringView string)
number_string.append(*position);
++position;
}
auto integer_value = number_string.string_view().to_number<int>();
auto integer_value = number_string.string_view().to_number<double>();
// NOTE: This is apparently the largest value allowed by Firefox.
static float max_dimension_value = 17895700;
float value = min(*integer_value, max_dimension_value);
// 6. If position is past the end of input, then return value as a length.
if (position == input.end())
return CSS::LengthStyleValue::create(CSS::Length::make_px(*integer_value));
float value = *integer_value;
return CSS::LengthStyleValue::create(CSS::Length::make_px(CSSPixels(value)));
// 7. If the code point at position within input is U+002E (.), then:
if (*position == '.') {