eliott/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2026-04-26 01:25:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Rename Element::shadow_root_internal() to shadow_root()

Browse Source 
And let the old shadow_root(), which was only supposed to be used by
bindings, be called shadow_root_for_bindings() instead.

This makes it much easier to read DOM code, and we don't have to worry
about when to use shadow_root_internal() or why.

(cherry picked from commit f4bdf562127c12a7af18029777a88d4260af82d3)
This commit is contained in:
Andreas Kling
2024-06-25 11:28:58 +02:00
committed by Nico Weber
parent 1c5f0e8daf
commit c8206fa070
18 changed files with 27 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
View File

@@ -437,7 +437,7 @@ void HTMLSelectElement::computed_css_values_changed()
void HTMLSelectElement::create_shadow_tree_if_needed()
{
if (shadow_root_internal())
if (shadow_root())
return;
auto shadow_root = heap().allocate<DOM::ShadowRoot>(realm(), document(), *this, Bindings::ShadowRootMode::Closed);