eliott/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2026-05-12 18:06:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

AK+Kernel: Don't allow Vector::ensure_capacity() in the kernel

Browse Source 
This function doesn't propagate allocation failures.

Replace all current usages of this function by using
`try_ensure_capacity()` instead.
This commit is contained in:
Sönke Holz
2025-11-19 22:06:02 +01:00
committed by Sönke Holz
parent b089e9d0f6
commit d0e77ec377
10 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Kernel/Memory/MemoryManager.cpp
View File

@@ -256,7 +256,7 @@ UNMAP_AFTER_INIT void MemoryManager::parse_memory_map()
{
// Register used memory regions that we know of.
m_global_data.with([this](auto& global_data) {
global_data.used_memory_ranges.ensure_capacity(4);
global_data.used_memory_ranges.try_ensure_capacity(4).release_value_but_fixme_should_propagate_errors();
#if ARCH(X86_64)
// NOTE: We don't touch the first 1 MiB of RAM on x86-64 even if it's usable as indicated
// by a certain memory map. There are 2 reasons for this:
@@ -640,7 +640,7 @@ UNMAP_AFTER_INIT void MemoryManager::parse_memory_map_fdt(MemoryManager::GlobalD
VERIFY(state.address_cells);
VERIFY(state.size_cells);
state.reg.ensure_capacity(data.size() / ((state.address_cells + state.size_cells) * sizeof(u32)));
state.reg.try_ensure_capacity(data.size() / ((state.address_cells + state.size_cells) * sizeof(u32))).release_value_but_fixme_should_propagate_errors();
FixedMemoryStream reg_stream { data };