mirror of
https://github.com/SerenityOS/serenity
synced 2026-05-12 09:57:00 +02:00
decc664458
Parsing last as an IPV4 number was not returning true in "ends with a number" as the parsing of that part was overflowing. This means that the URL is not considered to be an IPv4 address, and is treated as a valid domain. Helpfully, the spec also points out in a note that this step is equivalent to simply checking that the last part ends with 0x followed by only hex digits - which doesn't suffer from any overflow problem! Arguably this is an editorial issue in the spec where this should be clarified a little bit. But for now, fixing this fixes 3 sub tests in WPT for: https://wpt.live/url/url-constructor.any.html (cherry picked from commit 6cac2981fb45498f7e5b84ded2669fb62111da17)
23 lines
589 B
HTML
23 lines
589 B
HTML
<script src="../include.js"></script>
|
|
<script>
|
|
test(() => {
|
|
const urls = [
|
|
{ input: 'file://xn--/p' },
|
|
{ input: 'http://0xffffffff1' },
|
|
];
|
|
|
|
for (url of urls) {
|
|
if (url.base === undefined)
|
|
println(`new URL('${url.input}', ${url.base})`);
|
|
else
|
|
println(`new URL('${url.input}', '${url.base}')`);
|
|
|
|
try {
|
|
new URL(url.input, url.base);
|
|
} catch (e) {
|
|
println(`error creating URL: '${e}'`);
|
|
}
|
|
}
|
|
});
|
|
</script>
|