mirror of
https://github.com/SerenityOS/serenity
synced 2026-04-25 17:15:42 +02:00
f6db24dba4
That functionality seems to be too much complicated. We shouldn't overengineer how the copy_mount syscall works, so instead of allowing replacement of the root filesystem, let's make the unshare file descriptor to be configured via a special ioctl call before we initialize a new VFSRootContext object. The special ioctl can either set a new root filesystem for the upcoming VFSRootContext object, or remove it (by passing fd of -1). If there's no specified root filesystem, a new RAMFS instance will be created automatically when invoking the unshare_create syscall. This also simplifies the code in the boot process, hence making it much more readable. It should be noted, that we assumed during pivot_root that the first mountpoint in a context is the root mountpoint, which is probably a fair assumption, but we don't assume this anywhere else in the VFSRootContext code. If this functionality ever comes back, we should ensure that we make some effort to not assume this again.
72 lines
2.2 KiB
C++
72 lines
2.2 KiB
C++
/*
|
|
* Copyright (c) 2024, Liav A. <liavalb@hotmail.co.il>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/NonnullOwnPtr.h>
|
|
#include <AK/Optional.h>
|
|
#include <AK/String.h>
|
|
#include <AK/StringView.h>
|
|
#include <AK/Types.h>
|
|
#include <AK/Vector.h>
|
|
#include <LibCore/System.h>
|
|
#include <unistd.h>
|
|
|
|
class VFSRootContextLayout {
|
|
public:
|
|
struct Mount {
|
|
enum class Type {
|
|
BindMount,
|
|
RegularMount,
|
|
};
|
|
Type type;
|
|
Optional<unsigned> source_vfs_root_context_id;
|
|
Optional<unsigned> source_fd;
|
|
String path;
|
|
String fstype;
|
|
};
|
|
|
|
static bool is_source_none(StringView source)
|
|
{
|
|
return source == "none"sv;
|
|
}
|
|
|
|
static ErrorOr<int> get_source_fd(StringView source)
|
|
{
|
|
if (is_source_none(source))
|
|
return -1;
|
|
auto fd_or_error = Core::System::open(source, O_RDWR);
|
|
if (fd_or_error.is_error())
|
|
fd_or_error = Core::System::open(source, O_RDONLY);
|
|
return fd_or_error;
|
|
}
|
|
|
|
ErrorOr<void> mount_new_filesystem(StringView fstype, StringView source, StringView target_path, int flags);
|
|
|
|
ErrorOr<void> chown(StringView path, uid_t uid, gid_t gid);
|
|
ErrorOr<void> chmod(StringView target_path, mode_t);
|
|
ErrorOr<void> symlink(StringView path, StringView target_path);
|
|
ErrorOr<void> copy_as_original(StringView source_path);
|
|
ErrorOr<void> copy_to_custom_location(StringView source_path, StringView target_path);
|
|
ErrorOr<void> mkdir(StringView target_path);
|
|
|
|
static ErrorOr<NonnullOwnPtr<VFSRootContextLayout>> create_with_root_mount_point(StringView preparation_environment_path);
|
|
ErrorOr<void> apply_mounts_on_vfs_root_context_id();
|
|
|
|
static ErrorOr<void> mount_root_filesystem(StringView path, StringView fstype, StringView source, int flags);
|
|
|
|
unsigned id() const { return m_target_vfs_root_context_id; }
|
|
|
|
private:
|
|
VFSRootContextLayout(String preparation_environment_path, unsigned target_vfs_root_context_id);
|
|
|
|
ErrorOr<String> generate_path_with_relation_to_preparation_environment_path(StringView target_path) const;
|
|
|
|
String m_preparation_environment_path;
|
|
unsigned const m_target_vfs_root_context_id { 0 };
|
|
Vector<Mount> m_mounts;
|
|
};
|