eliott/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure synced 2026-04-25 17:15:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix trade drawer header width regression (#1415)

Browse Source 
* Fix trade drawer header width regression

Wrap the trade header partial in a grow/min-w-0 container inside the custom dialog header row so overview disclosure rows stretch to available width instead of shrinking to content.

Confirmed via git blame that this layout behavior predates PR #1248 and is tied to the custom header flex layout introduced in commit 7ae9077.

* Overlay trade drawer close button to preserve content width

Render the close button absolutely in the custom header instead of as a flex sibling of the full trades header partial. This prevents the button column from shrinking the overview section width and leaving a persistent right-side gutter.
This commit is contained in:
Juan José Mata
2026-04-11 00:51:29 +02:00
committed by GitHub
parent e96fb0c23f
commit 257286431b
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/views/trades/show.html.erb
View File

@@ -1,8 +1,10 @@
<%= render DS::Dialog.new(frame: "drawer", responsive: true) do |dialog| %>
<% dialog.with_header(custom_header: true) do %>
<div class="flex items-start justify-between gap-4">
<div class="relative">
<div class="absolute right-0 top-0 z-10">
<%= dialog.close_button %>
</div>
<%= render "trades/header", entry: @entry %>
<%= dialog.close_button %>
</div>
<% end %>
<% trade = @entry.trade %>