* feat(simulation): MiroFish Phase 2 — theater-limited simulation runner
Adds the simulation execution layer that consumes simulation-package.json
and produces simulation-outcome.json for maritime chokepoint + energy/logistics
theaters, closing the WorldMonitor → MiroFish handoff loop.
Changes:
- scripts/seed-forecasts.mjs: 2-round LLM simulation runner (prompt builders,
JSON extractor, runTheaterSimulation, writeSimulationOutcome, task queue
with NX dedup lock, runSimulationWorker poll loop)
- scripts/process-simulation-tasks.mjs: standalone worker entry point
- proto: GetSimulationOutcome RPC + make generate
- server/worldmonitor/forecast/v1/get-simulation-outcome.ts: RPC handler
- server/gateway.ts: slow tier for get-simulation-outcome
- api/health.js: simulationOutcomeLatest in STANDALONE + ON_DEMAND keys
- tests: 14 new tests for simulation runner functions
* fix(simulation): address P1/P2 code review findings from PR #2220
Security (P1 #018):
- sanitizeForPrompt() applied to all entity/seed fields interpolated into
Round 1 prompt (entityId, class, stance, seedId, type, timing)
- sanitizeForPrompt() applied to actorId and entityIds in Round 2 prompt
- sanitizeForPrompt() + length caps applied to all LLM array fields written
to R2 (dominantReactions, stabilizers, invalidators, keyActors, timingMarkers)
Validation (P1 #019):
- Added validateRunId() regex guard
- Applied in enqueueSimulationTask() and processNextSimulationTask() loop
Type safety (P1 #020):
- Added isOutcomePointer() and isPackagePointer() type guards in TS handlers
- Replaced unsafe as-casts with runtime-validated guards in both handlers
Correctness (P2 #022):
- Log warning when pkgPointer.runId does not match task runId
Architecture (P2 #024):
- isMaritimeChokeEnergyCandidate() accepts both flat and nested topBucketId
- Call site simplified to pass theater directly
Performance (P2 #025):
- SIMULATION_ROUND1_MAX_TOKENS raised 1800 to 2200
- Added max 3 initialReactions instruction to Round 1 prompt
Maintainability (P2 #026):
- Simulation pointer keys exported from server/_shared/cache-keys.ts
- Both TS handlers import from shared location
Documentation (P2 #027):
- Strengthened runId no-op description in proto and OpenAPI spec
* fix(todos): add blank lines around lists in markdown todo files
* style(api): reformat openapi yaml to match linter output
* test(simulation): add flat-shape filter test + getSimulationOutcome handler coverage
Two tests identified as missing during PR #2220 review:
1. isMaritimeChokeEnergyCandidate flat-shape tests — covers the || candidate.topBucketId
normalization added in the P1/P2 review pass. The existing tests only used the nested
marketContext.topBucketId shape; this adds the flat root-field shape that arrives from
the simulation-package.json JSON (selectedTheaters entries have topBucketId at root).
2. getSimulationOutcome handler structural tests — verifies the isOutcomePointer guard,
found:false NOT_FOUND return, found:true success path, note population on runId mismatch,
and redis_unavailable error string. Follows the readSrc static-analysis pattern used
elsewhere in server-handlers.test.mjs (handler imports Redis so full integration test
would require a test Redis instance).
