mirror of https://github.com/koala73/worldmonitor.git synced 2026-04-25 17:14:57 +02:00

Files

Elie Habib 2fddee6b05 feat(simulation): add keyActorRoles to fix actor overlap bonus vocabulary mismatch (#2582 )

* feat(simulation): add keyActorRoles field to fix actor overlap bonus vocabulary mismatch

The +0.04 actor overlap bonus never reliably fired in production because
stateSummary.actors uses role-category strings ('Commodity traders',
'Policy officials') while simulation keyActors uses named geo-political
entities ('Iran', 'Houthi'). 53 production runs audited showed the bonus
fired once out of 53.

Fix: add keyActorRoles?: string[] to SimulationTopPath. The Round 2 prompt
now includes a CANDIDATE ACTOR ROLES section with theater-local role vocab
seeded from candidatePacket.stateSummary.actors. The LLM copies matching
roles into keyActorRoles. applySimulationMerge scores overlap against
keyActorRoles when actorSource=stateSummary, preserving the existing
keyActors entity-overlap path for the affectedAssets fallback.

- buildSimulationPackageFromDeepSnapshot: add actorRoles[] to each theater
  from candidate.stateSummary.actors (theater-scoped, no cross-theater noise)
- buildSimulationRound2SystemPrompt: inject CANDIDATE ACTOR ROLES section
  with exact-copy instruction and keyActorRoles in JSON template
- tryParseSimulationRoundPayload: extract keyActorRoles from round 2 output
- mergedPaths.map(): filter keyActorRoles against theater.actorRoles guardrail
- computeSimulationAdjustment: dual-path overlap — roleOverlapCount for
  stateSummary, keyActorsOverlapCount for affectedAssets (backwards compat)
- summarizeImpactPathScore: project roleOverlapCount + keyActorsOverlapCount
  into path-scorecards.json simDetail

New fields: roleOverlapCount, keyActorsOverlapCount in SimulationAdjustmentDetail
and ScorecardSimDetail. actorOverlapCount preserved as backwards-compat alias.

Tests: 308 pass (was 301 before). New tests T-P1/T-P2/T-P3 (prompt/parser),
T-RO1/T-RO2/T-RO3 (role overlap logic), T-PKG1 (pkg builder actorRoles),
plus fixture updates for T2/T-F/T-G/T-J/T-K/T-N2/T-SC-4.

🤖 Generated with Claude Sonnet 4.6 via Claude Code (https://claude.ai/claude-code) + Compound Engineering v2.49.0

Co-Authored-By: Claude Sonnet 4.6 (200K context) <noreply@anthropic.com>

* fix(simulation): address CE review findings from PR #2582

- Add SimulationPackageTheater interface to seed-forecasts.types.d.ts
  (actorRoles was untyped under @ts-check)
- Add keyActorRoles to uiTheaters Redis projection in writeSimulationOutcome
  (field was stripped from Redis snapshot; only visible in R2 artifact)
- Extract keyActorRoles IIFE to named sanitizeKeyActorRoles() function;
  hoist allowedRoles Set computation out of per-path loop
- Harden bonusOverlap ternary: explicit branch for actorSource='none'
  prevents silent fallthrough if new actorSource values are added
- Eliminate roleOverlap intermediate array in computeSimulationAdjustment
- Add U+2028/U+2029 Unicode line-separator stripping to sanitizeForPrompt
- Apply sanitizeForPrompt at tryParseSimulationRoundPayload parse boundary;
  add JSDoc to newly-exported function

All 308 tests pass, typecheck + typecheck:api clean.

* fix(sim): restore const sanitized in sanitizeKeyActorRoles after early-return guard

Prior edit added `if (!allowedRoles.length) return []` but accidentally removed
the `const sanitized = ...` line, leaving the filter on line below referencing an
undefined variable. Restores the full function body:

  if (!allowedRoles.length) return [];
  const sanitized = (Array.isArray(rawRoles) ? rawRoles : [])
    .map((s) => sanitizeForPrompt(String(s)).slice(0, 80));
  const allowedNorm = new Set(allowedRoles.map(normalizeActorName));
  return sanitized.filter((s) => allowedNorm.has(normalizeActorName(s))).slice(0, 8);

308/308 tests pass.

---------

Co-authored-by: Claude Sonnet 4.6 (200K context) <noreply@anthropic.com>

2026-04-01 08:53:13 +04:00

2.8 KiB

Raw Permalink Blame History

status, priority, issue_id, tags, dependencies

status

priority

issue_id

`SimulationPackageTheater` interface missing — `actorRoles` and pkg-theater shape untyped

Problem Statement

The theater objects built by buildSimulationPackageFromDeepSnapshot and consumed by buildSimulationRound2SystemPrompt and mergedPaths.map() have no named TypeScript interface in seed-forecasts.types.d.ts. The new actorRoles field added in PR #2582 is a critical path for the role-overlap bonus — but with @ts-check active on a .mjs file, a typo on theater.actorRoles or any caller passing the wrong shape will fail silently at runtime rather than being caught statically.

Findings

Two agents (kieran-typescript-reviewer, architecture-strategist) flagged this independently as the highest-priority gap from PR #2582
buildSimulationRound2SystemPrompt(theater, pkg, round1) receives theater typed as inferred plain object — @ts-check cannot validate theater.actorRoles
mergedPaths.map() IIFE accesses theater.actorRoles with a defensive Array.isArray guard but no type annotation
TheaterResult (the LLM output shape) is a separate interface — a SimulationPackageTheater for the pkg-artifact shape does not exist
PR #2582 already edits seed-forecasts.types.d.ts (adding keyActorRoles to SimulationTopPath) — the missing interface should have been added in the same PR

Proposed Solution

Add to scripts/seed-forecasts.types.d.ts:

/** One theater entry in SimulationPackage.selectedTheaters. Distinct from TheaterResult (LLM output shape). */
interface SimulationPackageTheater {
  theaterId: string;
  candidateStateId: string;
  label?: string;
  stateKind?: string;
  dominantRegion?: string;
  macroRegions?: string[];
  routeFacilityKey?: string;
  commodityKey?: string;
  topBucketId: string;
  topChannel: string;
  rankingScore?: number;
  criticalSignalTypes: string[];
  /** Role-category strings from candidate stateSummary.actors. Theater-scoped. Used in Round 2 prompt injection and keyActorRoles guardrail filter. */
  actorRoles: string[];
  theaterLabel?: string;
  theaterRegion?: string;
}

Then annotate theater param in buildSimulationRound2SystemPrompt JSDoc:

/**
 * @param {import('./seed-forecasts.types.d.ts').SimulationPackageTheater} theater
 */

Technical Details

Files: scripts/seed-forecasts.types.d.ts, scripts/seed-forecasts.mjs
Effort: Small | Risk: Low (type-only change, no runtime behavior)

Acceptance Criteria

SimulationPackageTheater interface exists in seed-forecasts.types.d.ts
buildSimulationRound2SystemPrompt parameter annotated with the interface
npm run typecheck passes

Work Log

2026-03-31: Identified by kieran-typescript-reviewer and architecture-strategist during PR #2582 review

2.8 KiB Raw Permalink Blame History

SimulationPackageTheater interface missing — actorRoles and pkg-theater shape untyped