mirror of https://github.com/koala73/worldmonitor.git synced 2026-04-25 17:14:57 +02:00

Files

Elie Habib 60e727679c feat(supply-chain): Sprint E — scenario visual completion + service parity (#2910 )

* feat(supply-chain): Sprint E — scenario visual completion + service parity

- E1: fetchSectorDependency exported from supply-chain service index
- E2: PRO gate + all-renderer dispatch in MapContainer.activateScenario
- E3: scenario summary banner in SupplyChainPanel (dismiss wired)
- E4: "Simulate Closure" trigger button in expanded chokepoint cards
- E5: affectedIso2s heat layer in DeckGLMap (GeoJsonLayer, red tint)
- E6: SVG renderer setScenarioState (best-effort iso2 fill)
- E7: Globe renderer scenario polygons via flushPolygons
- E8: integration tests for scenario run/status endpoints

* fix(supply-chain): address PR #2910 review findings (P1 + P2 + P3)

- Wire setOnScenarioActivate + setOnDismissScenario in panel-layout.ts (todo #155)
- Rename shadow variable t→tmpl in SCENARIO_TEMPLATES.find (todo #152)
- Add statusResp.ok guard in scenario polling loop (todo #153)
- Replace status.result! non-null assertion with shape guard (todo #154)
- Add AbortController to prevent concurrent polling races (todo #162)
- Add polygonStrokeColor scenario branch (transparent) in GlobeMap (todo #156)
- Re-export SCENARIO_TEMPLATES via src/config/scenario-templates.ts (todo #157)
- Cache affectedIso2Set in DeckGLMap.setScenarioState (todo #158)
- Add scenario paths to PREMIUM_RPC_PATHS for auth injection (todo #160)
- Show template name in scenario banner instead of raw ID (todo #163)

* fix(supply-chain): address PR #2910 review findings

- Add auth headers to scenario fetch calls in SupplyChainPanel
- Reset button state on scenario dismiss
- Poll status immediately on first iteration (no 2s delay)
- Pre-compute scenario polygons in GlobeMap.setScenarioState
- Use scenarioId for DeckGL updateTriggers precision

* fix(supply-chain): wire panel instance to MapContainer, stop button click propagation

- Call setSupplyChainPanel() in panel-layout.ts so scenario banner renders
- Add stopPropagation() to Simulate Closure button to prevent card collapse

2026-04-10 21:31:26 +04:00

1.7 KiB

Raw Permalink Blame History

status, priority, issue_id, tags, dependencies

status

priority

issue_id

`t` Parameter Shadows i18n `t` Import in `renderChokepoints`

Problem Statement

In SupplyChainPanel.ts:324, the arrow function parameter t inside SCENARIO_TEMPLATES.find(t => ...) shadows the module-level import { t } from '@/services/i18n' at line 12. Inside the callback, t refers to the template object, not the i18n function. Any translated string added inside this callback (or nearby refactor) will silently use the template object as a function, throwing at runtime.

Findings

File: src/components/SupplyChainPanel.ts:324
Code: const template = SCENARIO_TEMPLATES.find(t => t.affectedChokepointIds.includes(cp.id) && t.type !== 'tariff_shock');
Not a crash today — t(...) is not called inside the callback — but it is a maintenance trap
Biome may not catch this as an error (depends on shadow rules configured)

Proposed Solutions

Option A: Rename the arrow function parameter (Recommended)

const template = SCENARIO_TEMPLATES.find(tmpl =>
  tmpl.affectedChokepointIds.includes(cp.id) && tmpl.type !== 'tariff_shock'
);

Pros: One-line fix, obvious, eliminates shadow entirely Cons: None Effort: Small | Risk: None

Recommended Action

Apply Option A immediately — 1-line fix.

Technical Details

Affected files: src/components/SupplyChainPanel.ts
Line: 324

Acceptance Criteria

Arrow function parameter renamed from t to tmpl (or similar)
npm run lint passes with no shadow warnings
npm run typecheck passes

Work Log

2026-04-10: Identified by kieran-typescript-reviewer during PR #2910 review

Resources

PR: #2910

1.7 KiB Raw Permalink Blame History

t Parameter Shadows i18n t Import in renderChokepoints