mirror of
https://github.com/koala73/worldmonitor.git
synced 2026-04-25 17:14:57 +02:00
fe67111dc9
* feat: harness engineering P0 - linting, testing, architecture docs
Add foundational infrastructure for agent-first development:
- AGENTS.md: agent entry point with progressive disclosure to deeper docs
- ARCHITECTURE.md: 12-section system reference with source-file refs and ownership rule
- Biome 2.4.7 linter with project-tuned rules, CI workflow (lint-code.yml)
- Architectural boundary lint enforcing forward-only dependency direction (lint-boundaries.mjs)
- Unit test CI workflow (test.yml), all 1083 tests passing
- Fixed 9 pre-existing test failures (bootstrap sync, deploy-config headers, globe parity, redis mocks, geometry URL, import.meta.env null safety)
- Fixed 12 architectural boundary violations (types moved to proper layers)
- Added 3 missing cache tier entries in gateway.ts
- Synced cache-keys.ts with bootstrap.js
- Renamed docs/architecture.mdx to "Design Philosophy" with cross-references
- Deprecated legacy docs/Docs_To_Review/ARCHITECTURE.md
- Harness engineering roadmap tracking doc
* fix: address PR review feedback on harness-engineering-p0
- countries-geojson.test.mjs: skip gracefully when CDN unreachable
instead of failing CI on network issues
- country-geometry-overrides.test.mts: relax timing assertion
(250ms -> 2000ms) for constrained CI environments
- lint-boundaries.mjs: implement the documented api/ boundary check
(was documented but missing, causing false green)
* fix(lint): scan api/ .ts files in boundary check
The api/ boundary check only scanned .js/.mjs files, missing the 25
sebuf RPC .ts edge functions. Now scans .ts files with correct rules:
- Legacy .js: fully self-contained (no server/ or src/ imports)
- RPC .ts: may import server/ and src/generated/ (bundled at deploy),
but blocks imports from src/ application code
* fix(lint): detect import() type expressions in boundary lint
- Move AppContext back to app/app-context.ts (aggregate type that
references components/services/utils belongs at the top, not types/)
- Move HappyContentCategory and TechHQ to types/ (simple enums/interfaces)
- Boundary lint now catches import('@/layer') expressions, not just
from '@/layer' imports
- correlation-engine imports of AppContext marked boundary-ignore
(type-only imports of top-level aggregate)
68 lines
2.8 KiB
JavaScript
68 lines
2.8 KiB
JavaScript
import { describe, it } from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
|
|
const COUNTRY_GEOJSON_URL = 'https://maps.worldmonitor.app/countries.geojson';
|
|
|
|
let features;
|
|
let fetchError;
|
|
try {
|
|
const response = await fetch(COUNTRY_GEOJSON_URL, { signal: AbortSignal.timeout(5_000) });
|
|
if (!response.ok) throw new Error(`HTTP ${response.status}`);
|
|
const geojson = await response.json();
|
|
features = geojson.features;
|
|
} catch (err) {
|
|
fetchError = err;
|
|
}
|
|
|
|
describe('countries.geojson data integrity', { skip: fetchError ? `CDN unreachable: ${fetchError.message}` : undefined }, () => {
|
|
it('all feature names are unique', () => {
|
|
const names = features.map(f => f.properties.name);
|
|
const dupes = names.filter((n, i) => names.indexOf(n) !== i);
|
|
assert.deepStrictEqual(dupes, [], `Duplicate names found: ${dupes.join(', ')}`);
|
|
});
|
|
|
|
it('major countries have correct ISO codes', () => {
|
|
const expected = {
|
|
France: { a2: 'FR', a3: 'FRA' },
|
|
Norway: { a2: 'NO', a3: 'NOR' },
|
|
Kosovo: { a2: 'XK', a3: 'XKX' },
|
|
Germany: { a2: 'DE', a3: 'DEU' },
|
|
'United States of America': { a2: 'US', a3: 'USA' },
|
|
'United Kingdom': { a2: 'GB', a3: 'GBR' },
|
|
Japan: { a2: 'JP', a3: 'JPN' },
|
|
China: { a2: 'CN', a3: 'CHN' },
|
|
Brazil: { a2: 'BR', a3: 'BRA' },
|
|
India: { a2: 'IN', a3: 'IND' },
|
|
};
|
|
|
|
for (const [name, codes] of Object.entries(expected)) {
|
|
const feat = features.find(f => f.properties.name === name);
|
|
assert.ok(feat, `${name} not found in GeoJSON`);
|
|
assert.equal(feat.properties['ISO3166-1-Alpha-2'], codes.a2, `${name} Alpha-2 should be ${codes.a2}`);
|
|
assert.equal(feat.properties['ISO3166-1-Alpha-3'], codes.a3, `${name} Alpha-3 should be ${codes.a3}`);
|
|
}
|
|
});
|
|
|
|
it('no major country has -99 ISO code', () => {
|
|
const majorCountries = [
|
|
'France', 'Norway', 'Kosovo', 'Germany', 'United States of America',
|
|
'United Kingdom', 'Japan', 'China', 'Brazil', 'India', 'Canada',
|
|
'Australia', 'Russia', 'Italy', 'Spain', 'South Korea', 'Mexico',
|
|
'Turkey', 'Saudi Arabia', 'Israel', 'Ukraine', 'Poland', 'Iran',
|
|
];
|
|
|
|
for (const name of majorCountries) {
|
|
const feat = features.find(f => f.properties.name === name);
|
|
if (!feat) continue;
|
|
assert.notEqual(feat.properties['ISO3166-1-Alpha-2'], '-99', `${name} should not have -99 Alpha-2`);
|
|
assert.notEqual(feat.properties['ISO3166-1-Alpha-3'], '-99', `${name} should not have -99 Alpha-3`);
|
|
}
|
|
});
|
|
|
|
it('-99 count stays bounded (max 25)', () => {
|
|
const minus99 = features.filter(f => f.properties['ISO3166-1-Alpha-2'] === '-99');
|
|
assert.ok(minus99.length <= 25, `Expected <=25 features with -99, got ${minus99.length}: ${minus99.map(f => f.properties.name).join(', ')}`);
|
|
assert.ok(minus99.length > 0, 'Expected some -99 features for unrecognized territories');
|
|
});
|
|
});
|