f783bf2d2d
* fix(intelligence): include framework/systemAppend hash in cache keys (todos 041, 045, 051) * fix(intelligence): gate framework/systemAppend on server-side PRO check (todo 042) * fix(skills): exact hostname allowlist + redirect:manual to prevent SSRF (todos 043, 054) * fix(intelligence): sanitize systemAppend against prompt injection before LLM (todo 044) * fix(intelligence): use framework field in DeductionPanel, fix InsightsPanel double increment (todos 046, 047) * fix(intelligence): settings export, hot-path cache, country-brief debounce (todos 048, 049, 050) * fix(intelligence): i18n, FrameworkSelector note, stripThinkingTags dedup, UUID IDs (todos 052, 055, 056, 057) - i18n Analysis Frameworks settings section (en + fr locales, replace all hardcoded English strings with t() calls) - FrameworkSelector: replace panelId==='insights' hardcode with note? option; both InsightsPanel and DailyMarketBriefPanel pass note - stripThinkingTags: remove inline duplicate in summarize-article.ts, import from _shared/llm; add Strip unterminated comment so tests can locate the section - Replace Date.now() IDs for imported frameworks with crypto.randomUUID() - Drop 'not supported in phase 1' phrasing to 'not supported' - test: fix summarize-reasoning Fix 2 suite to read from llm.ts - test: add premium-check-stub and wire into redis-caching country intel brief importPatchedTsModule so test can resolve the new import * fix(security): address P1 review findings from PR #2386 - premium-check: require `required: true` from validateApiKey so trusted browser origins (worldmonitor.app, Vercel previews, localhost) are not treated as PRO callers; fixes free-user bypass of framework/systemAppend gate - llm: replace weak sanitizeSystemAppend with sanitizeForPrompt from llm-sanitize.js; all callLlm callers now get model-delimiter and control-char stripping, not just phrase blocklist - get-country-intel-brief: apply sanitizeForPrompt to contextSnapshot before injecting into user prompt; fixes unsanitized query-param injection Closes todos 060, 061, 062 (P1 — blocked merge of #2386). * chore(todos): mark P1 todos 060-062 complete * fix(agentskills): address Greptile P2 review comments - hoist ALLOWED_AGENTSKILLS_HOSTS Set to module scope (was reallocated per-request) - add res.type === 'opaqueredirect' check alongside the 3xx guard; Edge Runtime returns status=0 for opaque redirects so the status range check alone is dead code
2.1 KiB
status, priority, issue_id, tags, dependencies
| status | priority | issue_id | tags | dependencies | |||
|---|---|---|---|---|---|---|---|
| pending | p2 | 067 |
|
isCallerPremium called unconditionally even when framework/systemAppend is empty
Problem Statement
In all three handlers, isCallerPremium(ctx.request) is called at the top of every request before any field check. For the majority of requests where framework/systemAppend is absent or empty, the PRO check is wasted: the result is discarded because the field is empty anyway. For summarize-article.ts, the check runs even before the headlines validation guard at line 89.
On Vercel edge isolates, validateBearerToken triggers a lookupPlanFromClerk call that hits api.clerk.com when the JWT lacks a plan claim. The in-memory plan cache provides no protection across edge isolates (ephemeral per-region). At scale, empty-framework requests from standard session users generate unnecessary Clerk API calls and add 100-300ms serial latency before the LLM path on cold isolates. A Clerk 429 silently degrades PRO users to free (no error surfaced).
Proposed Solution
Gate isCallerPremium behind a non-empty field check in each handler:
summarize-article.ts:
const rawAppend = typeof req.systemAppend === 'string' ? req.systemAppend : '';
const isPremium = rawAppend ? await isCallerPremium(ctx.request) : false;
deduct-situation.ts and get-country-intel-brief.ts:
const frameworkRaw = typeof req.framework === 'string' ? req.framework.slice(0, 2000) : '';
const isPremium = frameworkRaw ? await isCallerPremium(ctx.request) : false;
Technical Details
- Files:
server/worldmonitor/news/v1/summarize-article.ts:42,server/worldmonitor/intelligence/v1/deduct-situation.ts:26,server/worldmonitor/intelligence/v1/get-country-intel-brief.ts - Effort: Small | Risk: Low
Acceptance Criteria
isCallerPremiumis not called when the relevant field is absent/empty- Requests without
framework/systemAppendhave identical behavior before and after
Work Log
- 2026-03-28: Identified by performance-oracle during PR #2386 review