Files
worldmonitor/tests/notification-relay-shadow-log.test.mjs
Elie Habib 14c1314629 fix(scoring): scope "critical" to geopolitical events, not domestic tragedies (#3221)
The weight rebalance (PR #3144) amplified a prompt gap: domestic mass
shootings (e.g. "8 children killed in Louisiana") scored 88 because the
LLM classified them as "critical" (mass-casualty 10+ killed) and the
55% severity weight pushed them into the critical gate. But WorldMonitor
is a geopolitical monitor — domestic tragedies are terrible but not
geopolitically destabilizing.

Prompt change (both ais-relay.cjs + classify-event.ts):
- "critical" now explicitly requires GEOPOLITICAL scope: "events that
  destabilize international order, threaten cross-border security, or
  disrupt global systems"
- Domestic mass-casualty events (mass shootings, industrial accidents)
  moved to "high" — still important, but not critical-sensitivity alerts
- Added counterexamples: "8 children killed in mass shooting in
  Louisiana → domestic mass-casualty → high" and "23 killed in fireworks
  factory explosion → industrial accident → high"
- Retained: "700 killed in Sudan drone strikes → geopolitical mass-
  casualty in active civil war → critical"

Classify cache: v2→v3 (bust stale entries that lack geopolitical scope).
Shadow-log: v4→v5 (clean dataset for recalibration under the scoped prompt).

🤖 Generated with Claude Opus 4.6 via Claude Code

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-20 08:40:29 +04:00

87 lines
3.3 KiB
JavaScript

/**
* Regression test: scripts/notification-relay.cjs must write to the shadow
* log exactly ONCE per rss_alert event. Before the fix, processEvent() called
* shadowLogScore() twice, producing ~50% near-duplicate pairs in
* shadow:score-log:v1 (docs/internal/scoringDiagnostic.md §4).
*
* The relay runs with live Convex + Upstash connections, so we test the
* contract by static analysis of the source rather than integration.
*
* Run: node --test tests/notification-relay-shadow-log.test.mjs
*/
import { describe, it } from 'node:test';
import assert from 'node:assert/strict';
import { readFileSync } from 'node:fs';
import { resolve, dirname } from 'node:path';
import { fileURLToPath } from 'node:url';
const __dirname = dirname(fileURLToPath(import.meta.url));
const relaySrc = readFileSync(
resolve(__dirname, '..', 'scripts', 'notification-relay.cjs'),
'utf-8',
);
function extractProcessEvent(src) {
const idx = src.indexOf('async function processEvent(');
assert.ok(idx !== -1, 'processEvent not found in notification-relay.cjs');
const openIdx = src.indexOf('{', idx);
let depth = 1;
let i = openIdx + 1;
while (i < src.length && depth > 0) {
if (src[i] === '{') depth++;
else if (src[i] === '}') depth--;
i++;
}
return src.slice(idx, i);
}
describe('notification-relay shadowLogScore discipline', () => {
const processEvent = extractProcessEvent(relaySrc);
it('calls shadowLogScore exactly once inside processEvent', () => {
const calls = processEvent.match(/shadowLogScore\s*\(/g) || [];
assert.equal(
calls.length, 1,
`processEvent must call shadowLogScore exactly once; found ${calls.length}`,
);
});
it('calls shadowLogScore before the score gate, not after', () => {
const shadowIdx = processEvent.indexOf('shadowLogScore');
const gateIdx = processEvent.indexOf('IMPORTANCE_SCORE_LIVE');
assert.ok(shadowIdx !== -1, 'shadowLogScore call not found');
assert.ok(gateIdx !== -1, 'IMPORTANCE_SCORE_LIVE gate not found');
assert.ok(
shadowIdx < gateIdx,
'shadowLogScore must fire before the live score gate so we measure what would have been dropped',
);
});
});
describe('shadow-log key version', () => {
it('uses the v4 JSON-member key (prompt upgrade clean dataset)', () => {
assert.match(
relaySrc,
/SHADOW_SCORE_LOG_KEY\s*=\s*['"]shadow:score-log:v5['"]/,
'notification-relay must write to shadow:score-log:v5 after the prompt upgrade',
);
assert.ok(
!/SHADOW_SCORE_LOG_KEY\s*=\s*['"]shadow:score-log:v[1234]['"]/.test(relaySrc),
'legacy v1/v2/v3/v4 keys must not be active',
);
});
it('shadowLogScore encodes a JSON record with severity + corroboration', () => {
const fnStart = relaySrc.indexOf('async function shadowLogScore');
assert.ok(fnStart !== -1, 'shadowLogScore not found');
const fnEnd = relaySrc.indexOf('\nasync function ', fnStart + 1);
const fn = relaySrc.slice(fnStart, fnEnd === -1 ? fnStart + 2000 : fnEnd);
assert.match(fn, /JSON\.stringify/, 'member must be JSON-encoded');
assert.match(fn, /severity:/, 'record must include severity');
assert.match(fn, /corroborationCount:/, 'record must include corroborationCount');
assert.match(fn, /variant:/, 'record must include variant');
assert.match(fn, /source:/, 'record must include source');
});
});