mirror of
https://github.com/koala73/worldmonitor.git
synced 2026-04-25 17:14:57 +02:00
fcbb8bc0a1
* feat(proto): generate unified worldmonitor.openapi.yaml bundle Adds a third protoc-gen-openapiv3 invocation that merges every service into a single docs/api/worldmonitor.openapi.yaml spanning all 68 RPCs, using the new bundle support shipped in sebuf 0.11.0 (SebastienMelki/sebuf#158). Per-service YAML/JSON files are untouched and continue to back the Mintlify docs in docs/docs.json. The bundle runs with strategy: all and bundle_only=true so only the aggregate file is emitted, avoiding duplicate-output conflicts with the existing per-service generator. Requires protoc-gen-openapiv3 >= v0.11.0 locally: go install github.com/SebastienMelki/sebuf/cmd/protoc-gen-openapiv3@v0.11.0 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(proto): bump sebuf to v0.11.0 and document unified OpenAPI bundle - Makefile: SEBUF_VERSION v0.7.0 → v0.11.0 (required for bundle support). - proto/buf.gen.yaml: point bundle_server at https://api.worldmonitor.app. - CONTRIBUTING.md: new "OpenAPI Output" section covering per-service specs vs the unified worldmonitor.openapi.yaml bundle, plus a note that all three sebuf plugins must be installed from the pinned version. - AGENTS.md: clarify that `make generate` also produces the unified spec and requires sebuf v0.11.0. - CHANGELOG.md: Unreleased entry announcing the bundle and version bump. Also regenerates the bundle with the updated server URL. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore(codegen): regenerate TS client/server with sebuf v0.11.0 Mechanical output of the bumped protoc-gen-ts-client and protoc-gen-ts-server. Two behavioral improvements roll in from sebuf: - Proto enum fields now use the proper `*_UNSPECIFIED` sentinel in default-value checks instead of the empty string, so generated query-string serializers correctly omit enum params only when they actually equal the proto default. - `repeated string` query params now serialize via `forEach(v => params.append(...))` instead of being coerced through `String(req.field)`, matching the existing `parseStringArray()` contract on the server side. All files also drop the `// @ts-nocheck` header that earlier sebuf versions emitted — 0.11.0 output type-checks cleanly under our tsconfig. No hand edits. Reproduce with `make install-plugins && make generate`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(proto): bump sebuf v0.11.0 → v0.11.1, realign tests with repeated-param wire format - Bump SEBUF_VERSION to v0.11.1, pulling in the OpenAPI fix for repeated scalar query params (SebastienMelki/sebuf#161). `repeated string` fields now emit `type: array` + `items.type: string` + `style: form` + `explode: true` instead of `type: string`, so SDK generators consuming the unified bundle produce correct array clients. - Regenerate all 12 OpenAPI specs (unified bundle + Aviation, Economic, Infrastructure, Market, Trade per-service). TS client/server codegen is byte-identical to v0.11.0 — only the OpenAPI emitter was out of sync. - Update three tests that asserted the pre-v0.11 comma-joined wire format (`symbols=AAPL,MSFT`) to match the current repeated-param form (`symbols=AAPL&symbols=MSFT`) produced by `params.append(...)`: - tests/market-service-symbol-casing.test.mjs (2 cases: getAll) - tests/stock-analysis-history.test.mts - tests/stock-backtest.test.mts Locally: test:data 6619/6619 pass, typecheck clean, lint exit 0. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Apply suggestions from code review Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
73 lines
2.4 KiB
Makefile
73 lines
2.4 KiB
Makefile
.PHONY: help lint generate breaking format check clean deps install install-buf install-plugins install-npm install-playwright
|
|
.DEFAULT_GOAL := help
|
|
|
|
# Variables
|
|
PROTO_DIR := proto
|
|
GEN_CLIENT_DIR := src/generated/client
|
|
GEN_SERVER_DIR := src/generated/server
|
|
DOCS_API_DIR := docs/api
|
|
|
|
# Go install settings
|
|
GO_PROXY := GOPROXY=direct
|
|
GO_PRIVATE := GOPRIVATE=github.com/SebastienMelki
|
|
GO_INSTALL := $(GO_PROXY) $(GO_PRIVATE) go install
|
|
|
|
# Required tool versions
|
|
BUF_VERSION := v1.64.0
|
|
SEBUF_VERSION := v0.11.1
|
|
|
|
help: ## Show this help message
|
|
@echo 'Usage: make [target]'
|
|
@echo ''
|
|
@echo 'Targets:'
|
|
@awk 'BEGIN {FS = ":.*?## "} /^[a-zA-Z_-]+:.*?## / {printf " %-20s %s\n", $$1, $$2}' $(MAKEFILE_LIST)
|
|
|
|
install: install-buf install-plugins install-npm install-playwright deps ## Install everything (buf, sebuf plugins, npm deps, proto deps, browsers)
|
|
|
|
install-buf: ## Install buf CLI
|
|
@if command -v buf >/dev/null 2>&1; then \
|
|
echo "buf already installed: $$(buf --version)"; \
|
|
else \
|
|
echo "Installing buf..."; \
|
|
$(GO_INSTALL) github.com/bufbuild/buf/cmd/buf@$(BUF_VERSION); \
|
|
echo "buf installed!"; \
|
|
fi
|
|
|
|
install-plugins: ## Install sebuf protoc plugins (requires Go)
|
|
@echo "Installing sebuf protoc plugins $(SEBUF_VERSION)..."
|
|
@$(GO_INSTALL) github.com/SebastienMelki/sebuf/cmd/protoc-gen-ts-client@$(SEBUF_VERSION)
|
|
@$(GO_INSTALL) github.com/SebastienMelki/sebuf/cmd/protoc-gen-ts-server@$(SEBUF_VERSION)
|
|
@$(GO_INSTALL) github.com/SebastienMelki/sebuf/cmd/protoc-gen-openapiv3@$(SEBUF_VERSION)
|
|
@echo "Plugins installed!"
|
|
|
|
install-npm: ## Install npm dependencies
|
|
npm install
|
|
|
|
install-playwright: ## Install Playwright browsers for e2e tests
|
|
npx playwright install chromium
|
|
|
|
deps: ## Install/update buf proto dependencies
|
|
cd $(PROTO_DIR) && buf dep update
|
|
|
|
lint: ## Lint protobuf files
|
|
cd $(PROTO_DIR) && buf lint
|
|
|
|
generate: clean ## Generate code from proto definitions
|
|
@mkdir -p $(GEN_CLIENT_DIR) $(GEN_SERVER_DIR) $(DOCS_API_DIR)
|
|
cd $(PROTO_DIR) && buf generate
|
|
@echo "Code generation complete!"
|
|
|
|
breaking: ## Check for breaking changes against main
|
|
cd $(PROTO_DIR) && buf breaking --against '.git#branch=main,subdir=proto'
|
|
|
|
format: ## Format protobuf files
|
|
cd $(PROTO_DIR) && buf format -w
|
|
|
|
check: lint generate ## Run all checks (lint + generate)
|
|
|
|
clean: ## Clean generated files
|
|
@rm -rf $(GEN_CLIENT_DIR)
|
|
@rm -rf $(GEN_SERVER_DIR)
|
|
@rm -rf $(DOCS_API_DIR)
|
|
@echo "Clean complete!"
|