eliott/aider
1
0
Fork 0
mirror of https://github.com/Aider-AI/aider synced 2026-04-25 17:15:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: handle symlink loops in safe_abs_path() (#4711)

Browse Source 
Path.resolve() raises RuntimeError on circular symlinks. Catch
RuntimeError and OSError, fall back to Path.absolute().

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
coder_3
2026-02-16 11:24:05 +13:00
committed by clayarnoldg2m
parent 4625ebb4b5
commit b2bec25c2c
2 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
aider/utils.py
View File

@@ -95,7 +95,10 @@ def is_image_file(file_name):
def safe_abs_path(res):
"Gives an abs path, which safely returns a full (not 8.3) windows path"
res = Path(res).resolve()
try:
res = Path(res).resolve()
except (RuntimeError, OSError):
res = Path(res).absolute()
return str(res)

15
tests/basic/test_utils.py Normal file
View File

@@ -0,0 +1,15 @@
import os
from aider.utils import safe_abs_path
def test_safe_abs_path_symlink_loop(tmp_path):
# Create circular symlink: a -> b -> a
link_a = tmp_path / "link_a"
link_b = tmp_path / "link_b"
link_a.symlink_to(link_b)
link_b.symlink_to(link_a)
# safe_abs_path must not raise, and must return an absolute path
result = safe_abs_path(str(link_a))
assert os.path.isabs(result)