🔖(minor) minor release to 1.1.0

Added:
- 🤡(demo) generate dummy documents on dev users
- ✨(frontend) create side modal component
- ✨(frontend) Doc grid actions (update / delete)
- ✨(frontend) Doc editor header information

Changed:
- ♻️(frontend) replace docs panel with docs grid
- ♻️(frontend) create a doc from a modal
- ♻️(frontend) manage members from the share modal

.github/workflows/deploy.yml

@@ -0,0 +1,52 @@
+name: Deploy
+
+on:
+  push:
+    tags:
+      - 'preprod'
+      - 'production'
+
+
+jobs:
+  notify-argocd:
+    runs-on: ubuntu-latest
+    steps:
+      -
+        uses: actions/create-github-app-token@v1
+        id: app-token
+        with:
+          app-id: ${{ secrets.APP_ID }}
+          private-key: ${{ secrets.PRIVATE_KEY }}
+          owner: ${{ github.repository_owner }}
+          repositories: "impress,secrets"
+      -
+        name: Checkout repository
+        uses: actions/checkout@v2
+        with:
+          submodules: recursive
+          token: ${{ steps.app-token.outputs.token }}
+      -
+        name: Load sops secrets
+        uses: rouja/actions-sops@main
+        with:
+          secret-file: secrets/numerique-gouv/impress/secrets.enc.env
+          age-key: ${{ secrets.SOPS_PRIVATE }}
+      -
+        name: Call argocd github webhook
+        run: |
+          data='{"ref": "'$GITHUB_REF'","repository": {"html_url":"'$GITHUB_SERVER_URL'/'$GITHUB_REPOSITORY'"}}'
+          sig=$(echo -n ${data} | openssl dgst -sha1 -hmac ''${ARGOCD_WEBHOOK_SECRET}'' | awk '{print "X-Hub-Signature: sha1="$2}')
+          curl -X POST -H 'X-GitHub-Event:push' -H "Content-Type: application/json" -H "${sig}" --data "${data}" $ARGOCD_WEBHOOK_URL
+          sig=$(echo -n ${data} | openssl dgst -sha1 -hmac ''${ARGOCD_PRODUCTION_WEBHOOK_SECRET}'' | awk '{print "X-Hub-Signature: sha1="$2}')
+          curl -X POST -H 'X-GitHub-Event:push' -H "Content-Type: application/json" -H "${sig}" --data "${data}" $ARGOCD_PRODUCTION_WEBHOOK_URL
+
+  start-test-on-preprod:
+    needs:
+      - notify-argocd
+    runs-on: ubuntu-latest
+    if: startsWith(github.event.ref, 'refs/tags/preprod')
+    steps:
+      -
+        name: Debug
+        run: |
+          echo "Start test when preprod is ready"

.github/workflows/docker-hub.yml

@@ -1,5 +1,4 @@
 name: Docker Hub Workflow
-run-name: Docker Hub Workflow
 
 on:
   workflow_dispatch:
@@ -49,16 +48,9 @@ jobs:
         name: Login to DockerHub
         if: github.event_name != 'pull_request'
         run: echo "$DOCKER_HUB_PASSWORD" | docker login -u "$DOCKER_HUB_USER" --password-stdin
-      -
-        name: Run trivy scan
-        uses: numerique-gouv/action-trivy-cache@main
-        with:
-          docker-build-args: '--target backend-production -f Dockerfile'
-          docker-image-name: 'docker.io/lasuite/impress-backend:${{ github.sha }}'
-        continue-on-error: true
       -
         name: Build and push
-        uses: docker/build-push-action@v6
+        uses: docker/build-push-action@v5
         with:
           context: .
           target: backend-production
@@ -100,16 +92,9 @@ jobs:
         name: Login to DockerHub
         if: github.event_name != 'pull_request'
         run: echo "$DOCKER_HUB_PASSWORD" | docker login -u "$DOCKER_HUB_USER" --password-stdin
-      -
-        name: Run trivy scan
-        uses: numerique-gouv/action-trivy-cache@main
-        with:
-          docker-build-args: '-f src/frontend/Dockerfile --target frontend-production'
-          docker-image-name: 'docker.io/lasuite/impress-frontend:${{ github.sha }}'
-        continue-on-error: true
       -
         name: Build and push
-        uses: docker/build-push-action@v6
+        uses: docker/build-push-action@v5
         with:
           context: .
           file: ./src/frontend/Dockerfile
@@ -119,7 +104,7 @@ jobs:
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
 
-  build-and-push-y-provider:
+  build-and-push-y-webrtc-signaling:
     runs-on: ubuntu-latest
     steps:
       -
@@ -147,25 +132,18 @@ jobs:
         id: meta
         uses: docker/metadata-action@v5
         with:
-          images: lasuite/impress-y-provider
+          images: lasuite/impress-y-webrtc-signaling
       -
         name: Login to DockerHub
         if: github.event_name != 'pull_request'
         run: echo "$DOCKER_HUB_PASSWORD" | docker login -u "$DOCKER_HUB_USER" --password-stdin
-      -
-        name: Run trivy scan
-        uses: numerique-gouv/action-trivy-cache@main
-        with:
-          docker-build-args: '-f src/frontend/servers/y-provider/Dockerfile --target y-provider'
-          docker-image-name: 'docker.io/lasuite/impress-frontend:${{ github.sha }}'
-        continue-on-error: true
       -
         name: Build and push
-        uses: docker/build-push-action@v6
+        uses: docker/build-push-action@v5
         with:
           context: .
-          file: ./src/frontend/servers/y-provider/Dockerfile
-          target: y-provider
+          file: ./src/frontend/Dockerfile
+          target: y-webrtc-signaling
           build-args: DOCKER_USER=${{ env.DOCKER_USER }}:-1000
           push: ${{ github.event_name != 'pull_request' }}
           tags: ${{ steps.meta.outputs.tags }}

.github/workflows/helmfile-linter.yaml

@@ -1,22 +0,0 @@
-name: Helmfile lint
-run-name: Helmfile lint
-
-on:
-  pull_request:
-    branches:
-      - 'main'
-
-jobs:
-  helmfile-lint:
-    runs-on: ubuntu-latest
-    container:
-      image: ghcr.io/helmfile/helmfile:latest
-    steps:
-      -
-        uses: numerique-gouv/action-helmfile-lint@main
-        with:
-          app-id: ${{ secrets.APP_ID }}
-          age-key: ${{ secrets.SOPS_PRIVATE }}
-          private-key: ${{ secrets.PRIVATE_KEY }}
-          helmfile-src: "src/helm"
-          repositories: "impress,secrets"

.github/workflows/impress-frontend.yml

@@ -19,7 +19,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: "20.x"
+          node-version: "18.x"
 
       - name: Restore the frontend cache
         uses: actions/cache@v4
@@ -39,17 +39,35 @@ jobs:
           path: "src/frontend/**/node_modules"
           key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }}
 
-  test-front:
+  build-front:
     runs-on: ubuntu-latest
     needs: install-front
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
 
-      - name: Setup Node.js
-        uses: actions/setup-node@v4
+      - name: Restore the frontend cache
+        uses: actions/cache@v4
+        id: front-node_modules
         with:
-          node-version: "20.x"
+          path: "src/frontend/**/node_modules"
+          key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }}
+
+      - name: Build CI App
+        run: cd src/frontend/ && yarn ci:build
+
+      - name: Cache build frontend
+        uses: actions/cache@v4
+        with:
+          path: src/frontend/apps/impress/out/
+          key: build-front-${{ github.run_id }}
+
+  test-front:
+    runs-on: ubuntu-latest
+    needs: install-front
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
 
       - name: Restore the frontend cache
         uses: actions/cache@v4
@@ -59,7 +77,7 @@ jobs:
           key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }}
 
       - name: Test App
-        run: cd src/frontend/ && yarn test
+        run: cd src/frontend/ && yarn app:test
 
   lint-front:
     runs-on: ubuntu-latest
@@ -78,13 +96,27 @@ jobs:
       - name: Check linting
         run: cd src/frontend/ && yarn lint
 
-  test-e2e-chromium:
+  test-e2e:
     runs-on: ubuntu-latest
-    timeout-minutes: 20
+    needs: build-front
+    timeout-minutes: 15
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
 
+      - name: Set services env variables
+        run: |
+          make data/media
+          make create-env-files
+          cat env.d/development/common.e2e.dist >> env.d/development/common
+
+      - name: Restore the mail templates
+        uses: actions/cache@v4
+        id: mail-templates
+        with:
+          path: "src/backend/core/templates/mail"
+          key: mail-templates-${{ hashFiles('src/mail/mjml') }}
+
       - name: Restore the frontend cache
         uses: actions/cache@v4
         id: front-node_modules
@@ -92,77 +124,48 @@ jobs:
           path: "src/frontend/**/node_modules"
           key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }}
 
-      - name: Set e2e env variables
-        run: cat env.d/development/common.e2e.dist >> env.d/development/common.dist
-
-      - name: Install Playwright Browsers
-        run: cd src/frontend/apps/e2e && yarn install --frozen-lockfile && yarn install-playwright chromium
-
-      - name: Start Docker services
-        run: make bootstrap FLUSH_ARGS='--no-input' cache=
-
-      # Tool to wait for a service to be ready
-      - name: Install Dockerize
-        run: |
-          curl -sSL https://github.com/jwilder/dockerize/releases/download/v0.8.0/dockerize-linux-amd64-v0.8.0.tar.gz | sudo tar -C /usr/local/bin -xzv
-
-      - name: Wait for services to be ready
-        run: |
-          printf "Minio check...\n"
-          dockerize -wait tcp://localhost:9000 -timeout 20s
-          printf "Keyclock check...\n"
-          dockerize -wait tcp://localhost:8080 -timeout 20s
-          printf "Server collaboration check...\n"
-          dockerize -wait tcp://localhost:4444 -timeout 20s
-          printf "Ngnix check...\n"
-          dockerize -wait tcp://localhost:8083 -timeout 20s
-          printf "DRF check...\n"
-          dockerize -wait tcp://localhost:8071 -timeout 20s
-          printf "Postgres Keyclock check...\n"
-          dockerize -wait tcp://localhost:5433 -timeout 20s
-          printf "Postgres back check...\n"
-          dockerize -wait tcp://localhost:15432 -timeout 20s
-
-      - name: Run e2e tests
-        run: cd src/frontend/ && yarn e2e:test --project='chromium'
-
-      - uses: actions/upload-artifact@v4
-        if: always()
-        with:
-          name: playwright-chromium-report
-          path: src/frontend/apps/e2e/report/
-          retention-days: 7
-
-  test-e2e-other-browser:
-    runs-on: ubuntu-latest
-    needs: test-e2e-chromium
-    timeout-minutes: 20
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
-      - name: Restore the frontend cache
+      - name: Restore the build cache
         uses: actions/cache@v4
-        id: front-node_modules
+        id: cache-build
         with:
-          path: "src/frontend/**/node_modules"
-          key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }}
+          path: src/frontend/apps/impress/out/
+          key: build-front-${{ github.run_id }}
 
-      - name: Set e2e env variables
-        run: cat env.d/development/common.e2e.dist >> env.d/development/common.dist
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
 
-      - name: Install Playwright Browsers
-        run: cd src/frontend/apps/e2e && yarn install --frozen-lockfile && yarn install-playwright firefox webkit chromium
+      - name: Build the Docker images
+        uses: docker/bake-action@v4
+        with:
+          targets: |
+            app-dev
+            y-webrtc-signaling
+          load: true
+          set: |
+            *.cache-from=type=gha,scope=cached-stage
+            *.cache-to=type=gha,scope=cached-stage,mode=max
 
       - name: Start Docker services
-        run: make bootstrap FLUSH_ARGS='--no-input' cache=
+        run: |
+          make run
+
+      - name: Apply DRF migrations
+        run: |
+          make migrate
+
+      - name: Add dummy data
+        run: |
+          make demo FLUSH_ARGS='--no-input'
+
+      - name: Install Playwright Browsers
+        run: cd src/frontend/apps/e2e && yarn install
 
       - name: Run e2e tests
-        run: cd src/frontend/ && yarn e2e:test --project=firefox --project=webkit
+        run: cd src/frontend/ && yarn e2e:test
 
-      - uses: actions/upload-artifact@v4
+      - uses: actions/upload-artifact@v3
         if: always()
         with:
-          name: playwright-other-report
+          name: playwright-report
           path: src/frontend/apps/e2e/report/
           retention-days: 7

.github/workflows/impress.yml

@@ -107,9 +107,7 @@ jobs:
       - name: Install Python
         uses: actions/setup-python@v3
         with:
-          python-version: "3.12.6"
-      - name: Upgrade pip and setuptools
-        run: pip install --upgrade pip setuptools
+          python-version: "3.10"
       - name: Install development dependencies
         run: pip install --user .[dev]
       - name: Check code formatting with ruff
@@ -170,7 +168,7 @@ jobs:
           path: "src/backend/core/templates/mail"
           key: mail-templates-${{ hashFiles('src/mail/mjml') }}
 
-      - name: Start MinIO
+      - name: Start Minio
         run: |
           docker pull minio/minio
           docker run -d --name minio \
@@ -180,15 +178,6 @@ jobs:
             -v /data/media:/data \
             minio/minio server --console-address :9001 /data
 
-      # Tool to wait for a service to be ready
-      - name: Install Dockerize
-        run: |
-          curl -sSL https://github.com/jwilder/dockerize/releases/download/v0.8.0/dockerize-linux-amd64-v0.8.0.tar.gz | sudo tar -C /usr/local/bin -xzv
-
-      - name: Wait for MinIO to be ready
-        run: |
-          dockerize -wait tcp://localhost:9000 -timeout 10s
-
       - name: Configure MinIO
         run: |
           MINIO=$(docker ps | grep minio/minio | sed -E 's/.*\s+([a-zA-Z0-9_-]+)$/\1/')
@@ -201,7 +190,7 @@ jobs:
       - name: Install Python
         uses: actions/setup-python@v3
         with:
-          python-version: "3.12.6"
+          python-version: "3.10"
 
       - name: Install development dependencies
         run: pip install --user .[dev]
@@ -209,10 +198,75 @@ jobs:
       - name: Install gettext (required to compile messages)
         run: |
           sudo apt-get update
-          sudo apt-get install -y gettext pandoc
+          sudo apt-get install -y gettext
 
       - name: Generate a MO file from strings extracted from the project
         run: python manage.py compilemessages
 
       - name: Run tests
         run: ~/.local/bin/pytest -n 2
+
+  i18n-crowdin:
+    runs-on: ubuntu-latest
+    steps:
+      -
+        uses: actions/create-github-app-token@v1
+        id: app-token
+        with:
+          app-id: ${{ secrets.APP_ID }}
+          private-key: ${{ secrets.PRIVATE_KEY }}
+          owner: ${{ github.repository_owner }}
+          repositories: "infrastructure,secrets"
+      -
+        name: Checkout repository
+        uses: actions/checkout@v2
+        with:
+          submodules: recursive
+          token: ${{ steps.app-token.outputs.token }}
+      -
+        name: Load sops secrets
+        uses: rouja/actions-sops@main
+        with:
+          secret-file: secrets/numerique-gouv/impress/secrets.enc.env
+          age-key: ${{ secrets.SOPS_PRIVATE }}
+
+      - name: Install gettext (required to make messages)
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y gettext
+
+      - name: Install Python
+        uses: actions/setup-python@v3
+        with:
+          python-version: "3.10"
+
+      - name: Install development dependencies
+        working-directory: src/backend
+        run: pip install --user .[dev]
+
+      - name: Generate the translation base file
+        run: ~/.local/bin/django-admin makemessages --keep-pot --all
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "18.x"
+          cache: "yarn"
+          cache-dependency-path: src/frontend/yarn.lock
+
+      - name: Install dependencies
+        run: cd src/frontend/ && yarn install --frozen-lockfile
+
+      - name: Extract the frontend translation
+        run: make frontend-i18n-extract
+
+      - name: Upload files to Crowdin
+        run: |
+          docker run \
+          --rm \
+          -e CROWDIN_API_TOKEN=$CROWDIN_API_TOKEN \
+          -e CROWDIN_PROJECT_ID=$CROWDIN_PROJECT_ID \
+          -e CROWDIN_BASE_PATH=$CROWDIN_BASE_PATH \
+          -v "${{ github.workspace }}:/app" \
+          crowdin/cli:3.16.0 \
+          crowdin upload sources -c /app/crowdin/config.yml

.github/workflows/release-helm-chart.yaml

@@ -1,36 +0,0 @@
-name: Release Chart
-run-name: Release Chart
-
-on:
-  push:
-
-jobs:
-  release:
-    # depending on default permission settings for your org (contents being read-only or read-write for workloads), you will have to add permissions
-    # see: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token
-    permissions:
-      contents: write
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-
-      - name: Cleanup
-        run: rm -rf ./src/helm/extra
-
-      - name: Install Helm
-        uses: azure/setup-helm@v4
-        env:
-          GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
-
-      - name: Run chart-releaser
-        uses: helm/chart-releaser-action@v1.6.0
-        with:
-          charts_dir: ./src/helm
-          skip_existing: True
-          mark_as_latest: False
-        env:
-          CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
-          CR_GIT_REPO: numerique-gouv/helm-repo

.gitignore

@@ -33,6 +33,7 @@ MANIFEST
 *.pot
 
 # Environments
+.env
 .venv
 env/
 venv/
@@ -49,6 +50,9 @@ node_modules
 # Mails
 src/backend/core/templates/mail/
 
+# Typescript client
+src/frontend/tsclient
+
 # Swagger
 **/swagger.json
 

.sops.yaml

@@ -6,5 +6,4 @@ creation_rules:
       - age16hnlml8yv4ynwy0seer57g8qww075crd0g7nsundz3pj4wk7m3vqftszg7 # github-repo
       - age1plkp8td6zzfcavjusmsfrlk54t9vn8jjxm8zaz7cmnr7kzl2nfnsd54hwg # Anthony Le-Courric
       - age12g6f5fse25tgrwweleh4jls3qs52hey2edh759smulwmk5lnzadslu2cp3 # Antoine Lebaud
-      - age1hnhuzj96ktkhpyygvmz0x9h8mfvssz7ss6emmukags644mdhf4msajk93r # Samuel Paccoud
 

CHANGELOG.md

@@ -6,262 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0),
 and this project adheres to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-
 ## [Unreleased]
 
-## Added
-
-🔧(helm) add option to disable default tls setting by @dominikkaminski #519
-
-
-## [1.10.0] - 2024-12-17
-
-## Added
-
-- ✨(backend) add server-to-server API endpoint to create documents #467
-- ✨(email) white brand email #412
-- ✨(y-provider) create a markdown converter endpoint #488
-
-## Changed
-
-- ⚡️(docker) improve y-provider image #422
-
-## Fixed
-
-- ⚡️(e2e) reduce flakiness on e2e tests #511
-
-
-## [1.9.0] - 2024-12-11
-
-## Added
-
-- ✨(backend) annotate number of accesses on documents in list view #429
-- ✨(backend) allow users to mark/unmark documents as favorite #429
-
-## Changed
-
-- 🔒️(collaboration) increase collaboration access security #472
-- 🔨(frontend) encapsulated title to its own component #474
-- ⚡️(backend) optimize number of queries on document list view #429
-- ♻️(frontend) stop to use provider with version #480
-- 🚚(collaboration) change the websocket key name #480
-
-## Fixed
-
-- 🐛(frontend) fix initial content with collaboration #484
-- 🐛(frontend) Fix hidden menu on Firefox #468
-- 🐛(backend) fix sanitize problem IA #490
-
-
-## [1.8.2] - 2024-11-28
-
-## Changed
-
-- ♻️(SW) change strategy html caching #460
-
-
-## [1.8.1] - 2024-11-27
-
-## Fixed
-
-- 🐛(frontend) link not clickable and flickering firefox #457
-
-
-## [1.8.0] - 2024-11-25
-
-## Added
-
-- 🌐(backend) add German translation #259
-- 🌐(frontend) add German translation #255
-- ✨(frontend) add a broadcast store #387
-- ✨(backend) whitelist pod's IP address #443
-- ✨(backend) config endpoint #425
-- ✨(frontend) config endpoint #424
-- ✨(frontend) add sentry #424
-- ✨(frontend) add crisp chatbot #450
-
-## Changed
-
-- 🚸(backend) improve users similarity search and sort results #391
-- ♻️(frontend) simplify stores #402
-- ✨(frontend) update $css Box props type to add styled components RuleSet #423
-- ✅(CI) trivy continue on error #453
-
-## Fixed
-
-- 🔧(backend) fix logging for docker and make it configurable by envar #427
-- 🦺(backend) add comma to sub regex #408
-- 🐛(editor) collaborative user tag hidden when read only #385
-- 🐛(frontend) users have view access when revoked #387
-- 🐛(frontend) fix placeholder editable when double clicks #454
-
-
-## [1.7.0] - 2024-10-24
-
-## Added
-
-- 📝Contributing.md #352
-- 🌐(frontend) add localization to editor #368
-- ✨Public and restricted doc editable #357
-- ✨(frontend) Add full name if available #380
-- ✨(backend) Add view accesses ability #376
-
-## Changed
-
-- ♻️(frontend) list accesses if user has abilities #376
-- ♻️(frontend) avoid documents indexing in search engine #372
-- 👔(backend) doc restricted by default #388
-
-## Fixed
-
-- 🐛(backend) require right to manage document accesses to see invitations #369
-- 🐛(i18n) same frontend and backend language using shared cookies #365
-- 🐛(frontend) add default toolbar buttons #355
-- 🐛(frontend) throttle error correctly display #378
-
-## Removed
-
-- 🔥(helm) remove infra related codes #366
-
-
-## [1.6.0] - 2024-10-17
-
-## Added
-
-- ✨AI to doc editor #250
-- ✨(backend) allow uploading more types of attachments #309
-- ✨(frontend) add buttons to copy document to clipboard as HTML/Markdown #318
-
-## Changed
-
-- ♻️(frontend) more multi theme friendly #325
-- ♻️ Bootstrap frontend #257
-- ♻️ Add username in email #314
-
-## Fixed
-
-- 🛂(backend) do not duplicate user when disabled
-- 🐛(frontend) invalidate queries after removing user #336
-- 🐛(backend) Fix dysfunctional permissions on document create #329
-- 🐛(backend) fix nginx docker container #340
-- 🐛(frontend) fix copy paste firefox #353
-
-
-## [1.5.1] - 2024-10-10
-
-## Fixed
-
-- 🐛(db) fix users duplicate #316
-
-## [1.5.0] - 2024-10-09
-
-## Added
-
-- ✨(backend) add name fields to the user synchronized with OIDC #301
-- ✨(ci) add security scan #291
-- ♻️(frontend) Add versions #277
-- ✨(frontend) one-click document creation #275
-- ✨(frontend) edit title inline #275
-- 📱(frontend) mobile responsive #304
-- 🌐(frontend) Update translation #308
-
-## Changed
-
-- 💄(frontend) error alert closeable on editor #284
-- ♻️(backend) Change email content #283
-- 🛂(frontend) viewers and editors can access share modal #302
-- ♻️(frontend) remove footer on doc editor #313
-
-## Fixed
-
-- 🛂(frontend) match email if no existing user matches the sub
-- 🐛(backend) gitlab oicd userinfo endpoint #232
-- 🛂(frontend) redirect to the OIDC when private doc and unauthentified #292
-- ♻️(backend) getting list of document versions available for a user #258
-- 🔧(backend) fix configuration to avoid different ssl warning #297
-- 🐛(frontend) fix editor break line not working #302
-
-
-## [1.4.0] - 2024-09-17
-
-## Added
-
-- ✨Add link public/authenticated/restricted access with read/editor roles #234
-- ✨(frontend) add copy link button #235
-- 🛂(frontend) access public docs without being logged #235
-
-## Changed
-
-- ♻️(backend) Allow null titles on documents for easier creation #234
-- 🛂(backend) stop to list public doc to everyone #234
-- 🚚(frontend) change visibility in share modal #235
-- ⚡️(frontend) Improve summary #244
-
-## Fixed
-
-- 🐛(backend) Fix forcing ID when creating a document via API endpoint #234
-- 🐛 Rebuild frontend dev container from makefile #248
-
-
-## [1.3.0] - 2024-09-05
-
-## Added
-
-- ✨Add image attachments with access control
-- ✨(frontend) Upload image to a document #211
-- ✨(frontend) Summary #223
-- ✨(frontend) update meta title for docs page #231
-
-## Changed
-
-- 💄(frontend) code background darkened on editor #214
-- 🔥(frontend) hide markdown button if not text #213
-
-## Fixed
-
-- 🐛 Fix emoticon in pdf export #225
-- 🐛 Fix collaboration on document #226
-- 🐛 (docker) Fix compatibility with mac #230
-
-## Removed
-
-- 🔥(frontend) remove saving modal #213
-
-
-## [1.2.1] - 2024-08-23
-
-## Changed
-
-- ♻️ Change ordering docs datagrid #195
-- 🔥(helm) use scaleway email #194
-
-
-## [1.2.0] - 2024-08-22
-
-## Added
-
-- 🎨(frontend) better conversion editor to pdf #151
-- ✨Export docx (word) #161
-- 🌐Internationalize invitation email #167
-- ✨(frontend) White branding #164
-- ✨Email invitation when add user to doc #171
-- ✨Invitation management #174
-
-## Fixed
-
-- 🐛(y-webrtc) fix prob connection #147
-- ⚡️(frontend) improve select share stability #159
-- 🐛(backend) enable SSL when sending email #165
-
-## Changed
-
-- 🎨(frontend) stop limit layout height to screen size #158
-- ⚡️(CI) only e2e chrome mandatory #177
-
-## Removed
-- 🔥(helm) remove htaccess #181
-
-
 ## [1.1.0] - 2024-07-15
 
 ## Added
@@ -277,7 +23,6 @@ and this project adheres to
 - ♻️(frontend) create a doc from a modal #132
 - ♻️(frontend) manage members from the share modal #140
 
-
 ## [1.0.0] - 2024-07-02
 
 ## Added
@@ -316,7 +61,6 @@ and this project adheres to
 - 💚(CI) Remove trigger workflow on push tags on CI (#68)
 - 🔥(frontend) Remove coming soon page (#121)
 
-
 ## [0.1.0] - 2024-05-24
 
 ## Added
@@ -325,20 +69,7 @@ and this project adheres to
 - 🚀 Impress, project to manage your documents easily and collaboratively.
 
 
-[unreleased]: https://github.com/numerique-gouv/impress/compare/v1.10.0...main
-[v1.10.0]: https://github.com/numerique-gouv/impress/releases/v1.10.0
-[v1.9.0]: https://github.com/numerique-gouv/impress/releases/v1.9.0
-[v1.8.2]: https://github.com/numerique-gouv/impress/releases/v1.8.2
-[v1.8.1]: https://github.com/numerique-gouv/impress/releases/v1.8.1
-[v1.8.0]: https://github.com/numerique-gouv/impress/releases/v1.8.0
-[v1.7.0]: https://github.com/numerique-gouv/impress/releases/v1.7.0
-[v1.6.0]: https://github.com/numerique-gouv/impress/releases/v1.6.0
-[1.5.1]: https://github.com/numerique-gouv/impress/releases/v1.5.1
-[1.5.0]: https://github.com/numerique-gouv/impress/releases/v1.5.0
-[1.4.0]: https://github.com/numerique-gouv/impress/releases/v1.4.0
-[1.3.0]: https://github.com/numerique-gouv/impress/releases/v1.3.0
-[1.2.1]: https://github.com/numerique-gouv/impress/releases/v1.2.1
-[1.2.0]: https://github.com/numerique-gouv/impress/releases/v1.2.0
+[unreleased]: https://github.com/numerique-gouv/impress/compare/v1.1.0...main
 [1.1.0]: https://github.com/numerique-gouv/impress/releases/v1.1.0
 [1.0.0]: https://github.com/numerique-gouv/impress/releases/v1.0.0
-[0.1.0]: https://github.com/numerique-gouv/impress/releases/v0.1.0
+[0.1.0]: https://github.com/numerique-gouv/impress/releases/v0.1.0

CONTRIBUTING.md

@@ -1,79 +0,0 @@
-# Contributing to the Project
-
-Thank you for taking the time to contribute! Please follow these guidelines to ensure a smooth and productive workflow. 🚀🚀🚀
-
-To get started with the project, please refer to the [README.md](https://github.com/numerique-gouv/impress/blob/main/README.md) for detailed instructions.
-
-## Creating an Issue
-
-When creating an issue, please provide the following details:
-
-1.  **Title**: A concise and descriptive title for the issue.
-2.  **Description**: A detailed explanation of the issue, including relevant context or screenshots if applicable.
-3.  **Steps to Reproduce**: If the issue is a bug, include the steps needed to reproduce the problem.
-4.  **Expected vs. Actual Behavior**: Describe what you expected to happen and what actually happened.
-5.  **Labels**: Add appropriate labels to categorize the issue (e.g., bug, feature request, documentation).
-
-## Selecting an issue
-
-We use a [GitHub Project](https://github.com/orgs/numerique-gouv/projects/13) in order to prioritize our workload. 
-
-Please check in priority the issues that are in the **todo** column and have a higher priority (P0 -> P2). 
-
-## Commit Message Format
-
-All commit messages must adhere to the following format:
-
-`<gitmoji>(type) title description`
-
-*   <**gitmoji**>: Use a gitmoji to represent the purpose of the commit. For example, ✨ for adding a new feature or 🔥 for removing something, see the list here: <https://gitmoji.dev/>.
-*   **(type)**: Describe the type of change. Common types include `backend`, `frontend`, `CI`, `docker` etc...
-*   **title**: A short, descriptive title for the change, starting with a lowercase character.
-*   **description**: Include additional details about what was changed and why.
-
-### Example Commit Message
-
-```
-✨(frontend) add user authentication logic 
-
-Implemented login and signup features, and integrated OAuth2 for social login.
-```
-
-## Changelog Update
-
-Please add a line to the changelog describing your development. The changelog entry should include a brief summary of the changes, this helps in tracking changes effectively and keeping everyone informed. We usually include the title of the pull request, followed by the pull request ID to finish the log entry. The changelog line should be less than 80 characters in total.
-
-### Example Changelog Message
-```
-## [Unreleased]
-
-## Added
-
-- ✨(frontend) add AI to the project #321
-```
-
-## Pull Requests
-
-It is nice to add information about the purpose of the pull request to help reviewers understand the context and intent of the changes. If you can, add some pictures or a small video to show the changes.
-
-### Don't forget to: 
-- check your commits
-- check the linting: `make lint && make frontend-lint`
-- check the tests: `make test`
-- add a changelog entry
-
-Once all the required tests have passed, you can request a review from the project maintainers.
-
-## Code Style
-
-Please maintain consistency in code style. Run any linting tools available to make sure the code is clean and follows the project's conventions.
-
-## Tests
-
-Make sure that all new features or fixes have corresponding tests. Run the test suite before pushing your changes to ensure that nothing is broken.
-
-## Asking for Help
-
-If you need any help while contributing, feel free to open a discussion or ask for guidance in the issue tracker. We are more than happy to assist!
-
-Thank you for your contributions! 👍

Dockerfile

@@ -1,17 +1,18 @@
 # Django impress
 
 # ---- base image to inherit from ----
-FROM python:3.12.6-alpine3.20 AS base
+FROM python:3.10-slim-bullseye as base
 
 # Upgrade pip to its latest release to speed up dependencies installation
-RUN python -m pip install --upgrade pip setuptools
+RUN python -m pip install --upgrade pip
 
 # Upgrade system packages to install security updates
-RUN apk update && \
-  apk upgrade
+RUN apt-get update && \
+  apt-get -y upgrade && \
+  rm -rf /var/lib/apt/lists/*
 
 # ---- Back-end builder image ----
-FROM base AS back-builder
+FROM base as back-builder
 
 WORKDIR /builder
 
@@ -23,7 +24,7 @@ RUN mkdir /install && \
 
 
 # ---- mails ----
-FROM node:20 AS mail-builder
+FROM node:20 as mail-builder
 
 COPY ./src/mail /mail/app
 
@@ -34,13 +35,15 @@ RUN yarn install --frozen-lockfile && \
 
 
 # ---- static link collector ----
-FROM base AS link-collector
+FROM base as link-collector
 ARG IMPRESS_STATIC_ROOT=/data/static
 
-# Install pango & rdfind
-RUN apk add \
-  pango \
-  rdfind
+# Install libpangocairo & rdfind
+RUN apt-get update && \
+    apt-get install -y \
+      libpangocairo-1.0-0 \
+      rdfind && \
+    rm -rf /var/lib/apt/lists/*
 
 # Copy installed python dependencies
 COPY --from=back-builder /install /usr/local
@@ -59,22 +62,21 @@ RUN DJANGO_CONFIGURATION=Build DJANGO_JWT_PRIVATE_SIGNING_KEY=Dummy \
 RUN rdfind -makesymlinks true -followsymlinks true -makeresultsfile false ${IMPRESS_STATIC_ROOT}
 
 # ---- Core application image ----
-FROM base AS core
+FROM base as core
 
 ENV PYTHONUNBUFFERED=1
 
 # Install required system libs
-RUN apk add \
-  cairo \
-  file \
-  font-noto \
-  font-noto-emoji \
-  gettext \
-  gdk-pixbuf \
-  libffi-dev \
-  pandoc \
-  pango \
-  shared-mime-info
+RUN apt-get update && \
+    apt-get install -y \
+      gettext \
+      libcairo2 \
+      libffi-dev \
+      libgdk-pixbuf2.0-0 \
+      libpango-1.0-0 \
+      libpangocairo-1.0-0 \
+      shared-mime-info && \
+  rm -rf /var/lib/apt/lists/*
 
 # Copy entrypoint
 COPY ./docker/files/usr/local/bin/entrypoint /usr/local/bin/entrypoint
@@ -98,13 +100,15 @@ WORKDIR /app
 ENTRYPOINT [ "/usr/local/bin/entrypoint" ]
 
 # ---- Development image ----
-FROM core AS backend-development
+FROM core as backend-development
 
 # Switch back to the root user to install development dependencies
 USER root:root
 
 # Install psql
-RUN apk add postgresql-client
+RUN apt-get update && \
+    apt-get install -y postgresql-client && \
+    rm -rf /var/lib/apt/lists/*
 
 # Uninstall impress and re-install it in editable mode along with development
 # dependencies
@@ -124,7 +128,7 @@ ENV DB_HOST=postgresql \
 CMD ["python", "manage.py", "runserver", "0.0.0.0:8000"]
 
 # ---- Production image ----
-FROM core AS backend-production
+FROM core as backend-production
 
 ARG IMPRESS_STATIC_ROOT=/data/static
 

Makefile

@@ -49,6 +49,7 @@ WAIT_DB             = @$(COMPOSE_RUN) dockerize -wait tcp://$(DB_HOST):$(DB_PORT
 # -- Backend
 MANAGE              = $(COMPOSE_RUN_APP) python manage.py
 MAIL_YARN           = $(COMPOSE_RUN) -w /app/src/mail node yarn
+TSCLIENT_YARN       = $(COMPOSE_RUN) -w /app/src/tsclient node yarn
 
 # -- Frontend
 PATH_FRONT          = ./src/frontend
@@ -81,7 +82,7 @@ bootstrap: \
 	data/static \
 	create-env-files \
 	build \
-	run-with-frontend \
+	run-frontend-dev \
 	migrate \
 	demo \
 	back-i18n-compile \
@@ -90,28 +91,10 @@ bootstrap: \
 .PHONY: bootstrap
 
 # -- Docker/compose
-build: cache ?= --no-cache
-build: ## build the project containers
-	@$(MAKE) build-backend cache=$(cache)
-	@$(MAKE) build-yjs-provider cache=$(cache)
-	@$(MAKE) build-frontend cache=$(cache)
+build: ## build the app-dev container
+	@$(COMPOSE) build app-dev --no-cache
 .PHONY: build
 
-build-backend: cache ?=
-build-backend: ## build the app-dev container
-	@$(COMPOSE) build app-dev $(cache)
-.PHONY: build-backend
-
-build-yjs-provider: cache ?=
-build-yjs-provider: ## build the y-provider container
-	@$(COMPOSE) build y-provider $(cache)
-.PHONY: build-yjs-provider
-
-build-frontend: cache ?=
-build-frontend: ## build the frontend container
-	@$(COMPOSE) build frontend-dev $(cache)
-.PHONY: build-frontend
-
 down: ## stop and remove containers, networks, images, and volumes
 	@$(COMPOSE) down
 .PHONY: down
@@ -122,17 +105,11 @@ logs: ## display app-dev logs (follow mode)
 
 run: ## start the wsgi (production) and development server
 	@$(COMPOSE) up --force-recreate -d celery-dev
-	@$(COMPOSE) up --force-recreate -d y-provider
-	@$(COMPOSE) up --force-recreate -d nginx
+	@$(COMPOSE) up --force-recreate -d y-webrtc-signaling
 	@echo "Wait for postgresql to be up..."
 	@$(WAIT_DB)
 .PHONY: run
 
-run-with-frontend: ## Start all the containers needed (backend to frontend)
-	@$(MAKE) run
-	@$(COMPOSE) up --force-recreate -d frontend-dev
-.PHONY: run-with-frontend
-
 status: ## an alias for "docker compose ps"
 	@$(COMPOSE) ps
 .PHONY: status
@@ -209,7 +186,7 @@ back-i18n-compile: ## compile the gettext files
 .PHONY: back-i18n-compile
 
 back-i18n-generate: ## create the .pot files used for i18n
-	@$(MANAGE) makemessages -a --keep-pot --all
+	@$(MANAGE) makemessages -a --keep-pot
 .PHONY: back-i18n-generate
 
 shell: ## connect to database shell
@@ -298,6 +275,16 @@ mails-install: ## install the mail generator
 	@$(MAIL_YARN) install
 .PHONY: mails-install
 
+# -- TS client generator
+
+tsclient-install: ## Install the Typescript API client generator
+	@$(TSCLIENT_YARN) install
+.PHONY: tsclient-install
+
+tsclient: tsclient-install ## Generate a Typescript API client
+	@$(TSCLIENT_YARN) generate:api:client:local ../frontend/tsclient
+.PHONY: tsclient-install
+
 # -- Misc
 clean: ## restore repository state as it was freshly cloned
 	git clean -idx
@@ -309,19 +296,10 @@ help:
 	@grep -E '^[a-zA-Z0-9_-]+:.*?## .*$$' $(firstword $(MAKEFILE_LIST)) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "$(GREEN)%-30s$(RESET) %s\n", $$1, $$2}'
 .PHONY: help
 
-# Front
-frontend-install: ## install the frontend locally
-	cd $(PATH_FRONT_IMPRESS) && yarn
-.PHONY: frontend-install
-
-frontend-lint: ## run the frontend linter
-	cd $(PATH_FRONT) && yarn lint
-.PHONY: frontend-lint
-
-run-frontend-development: ## Run the frontend in development mode
-	@$(COMPOSE) stop frontend-dev
-	cd $(PATH_FRONT_IMPRESS) && yarn dev
-.PHONY: run-frontend-development
+# Front 
+run-frontend-dev: ## Install and run the frontend dev  
+	@$(COMPOSE) up --force-recreate -d frontend-dev
+.PHONY: run-frontend-dev
 
 frontend-i18n-extract: ## Extract the frontend translation inside a json to be used for crowdin
 	cd $(PATH_FRONT) && yarn i18n:extract
@@ -346,13 +324,3 @@ start-tilt: ## start the kubernetes cluster using kind
 	tilt up -f ./bin/Tiltfile
 .PHONY: build-k8s-cluster
 
-bump-packages-version: VERSION_TYPE ?= minor
-bump-packages-version: ## bump the version of the project - VERSION_TYPE can be "major", "minor", "patch"
-	cd ./src/mail && yarn version --no-git-tag-version --$(VERSION_TYPE)
-	cd ./src/frontend/ && yarn version --no-git-tag-version --$(VERSION_TYPE)
-	cd ./src/frontend/apps/e2e/ && yarn version --no-git-tag-version --$(VERSION_TYPE)
-	cd ./src/frontend/apps/impress/ && yarn version --no-git-tag-version --$(VERSION_TYPE)
-	cd ./src/frontend/servers/y-provider/ && yarn version --no-git-tag-version --$(VERSION_TYPE)
-	cd ./src/frontend/packages/eslint-config-impress/ && yarn version --no-git-tag-version --$(VERSION_TYPE)
-	cd ./src/frontend/packages/i18n/ && yarn version --no-git-tag-version --$(VERSION_TYPE)
-.PHONY: bump-packages-version

README.md

@@ -1,15 +1,9 @@
 # Impress
 
-Impress is a web application for real-time collaborative text editing with user and role based access rights.
-Features include : 
-- User authentication through OIDC
-- BlocNote.js text editing experience (markdown support, dynamic conversion, block structure, slash commands for block creation) 
-- Document export to pdf and docx from predefined templates
-- Granular document permissions
-- Public link sharing
-- Offline mode
+Impress prints your markdown to pdf from predefined templates with user and role based access rights.
 
-Impress is built on top of [Django Rest Framework](https://www.django-rest-framework.org/), [Next.js](https://nextjs.org/) and [BlocNote.js](https://www.blocknotejs.org/)
+Impress is built on top of [Django Rest
+Framework](https://www.django-rest-framework.org/) and [Next.js](https://nextjs.org/).
 
 ## Getting started
 
@@ -37,6 +31,14 @@ The easiest way to start working on the project is to use GNU Make:
 $ make bootstrap FLUSH_ARGS='--no-input'
 ```
 
+Then you can access to the project in development mode by going to http://localhost:3000.
+You will be prompted to log in, the default credentials are:
+```bash
+username: impress
+password: impress
+```
+---
+
 This command builds the `app` container, installs dependencies, performs
 database migrations and compile translations. It's a good idea to use this
 command each time you are pulling code from the project repository to avoid
@@ -44,41 +46,12 @@ dependency-releated or migration-releated issues.
 
 Your Docker services should now be up and running 🎉
 
-You can access to the project by going to http://localhost:3000.
-You will be prompted to log in, the default credentials are:
-```bash
-username: impress
-password: impress
-```
-
-📝 Note that if you need to run them afterwards, you can use the eponym Make rule:
+Note that if you need to run them afterwards, you can use the eponym Make rule:
 
 ```bash
-$ make run-with-frontend
+$ make run-frontend-dev
 ```
 
----
-
-⚠️ For the frontend developper, it is often better to run the frontend in development mode locally. 
-To do so, install the frontend dependencies with the following command:
-
-```bash
-$ make frontend-install
-```
-And run the frontend locally in development mode with the following command:
-
-```bash
-$ make run-frontend-development
-```
-
-To start all the services, except the frontend container, you can use the following command:
-
-```bash
-$ make run
-```
-
----
-
 ### Adding content
 
 You can create a basic demo site by running:

bin/Tiltfile

@@ -18,13 +18,13 @@ docker_build(
 )
 
 docker_build(
-    'localhost:5001/impress-y-provider:latest',
+    'localhost:5001/impress-y-webrtc-signaling:latest',
     context='..',
-    dockerfile='../src/frontend/servers/y-provider/Dockerfile',
+    dockerfile='../src/frontend/Dockerfile',
     only=['./src/frontend/', './docker/', './.dockerignore'],
-    target = 'y-provider',
+    target = 'y-webrtc-signaling',
     live_update=[
-        sync('../src/frontend/servers/y-provider/src', '/home/frontend/servers/y-provider/src'),
+        sync('../src/frontend/apps/y-webrtc-signaling/src', '/home/frontend/apps/y-webrtc-signaling/src'),
     ]
 )
 

bin/start-kind.sh

@@ -1,3 +1,103 @@
 #!/bin/sh
+set -o errexit
 
-curl https://raw.githubusercontent.com/numerique-gouv/tools/refs/heads/main/kind/create_cluster.sh | bash -s -- impress
+CURRENT_DIR=$(pwd)
+
+echo "0. Create ca"
+# 0. Create ca
+mkcert -install
+cd /tmp
+mkcert "127.0.0.1.nip.io" "*.127.0.0.1.nip.io"
+cd $CURRENT_DIR
+
+echo "1. Create registry container unless it already exists"
+# 1. Create registry container unless it already exists
+reg_name='kind-registry'
+reg_port='5001'
+if [ "$(docker inspect -f '{{.State.Running}}' "${reg_name}" 2>/dev/null || true)" != 'true' ]; then
+	docker run \
+		-d --restart=always -p "127.0.0.1:${reg_port}:5000" --network bridge --name "${reg_name}" \
+		registry:2
+fi
+
+echo "2. Create kind cluster with containerd registry config dir enabled"
+# 2. Create kind cluster with containerd registry config dir enabled
+# TODO: kind will eventually enable this by default and this patch will
+# be unnecessary.
+#
+# See:
+# https://github.com/kubernetes-sigs/kind/issues/2875
+# https://github.com/containerd/containerd/blob/main/docs/cri/config.md#registry-configuration
+# See: https://github.com/containerd/containerd/blob/main/docs/hosts.md
+cat <<EOF | kind create cluster --config=-
+kind: Cluster
+apiVersion: kind.x-k8s.io/v1alpha4
+containerdConfigPatches:
+- |-
+  [plugins."io.containerd.grpc.v1.cri".registry]
+    config_path = "/etc/containerd/certs.d"
+nodes:
+- role: control-plane
+  image: kindest/node:v1.27.3
+  kubeadmConfigPatches:
+  - |
+    kind: InitConfiguration
+    nodeRegistration:
+      kubeletExtraArgs:
+        node-labels: "ingress-ready=true"
+  extraPortMappings:
+  - containerPort: 80
+    hostPort: 80
+    protocol: TCP
+  - containerPort: 443
+    hostPort: 443
+    protocol: TCP
+- role: worker
+  image: kindest/node:v1.27.3
+- role: worker
+  image: kindest/node:v1.27.3
+EOF
+
+echo "3. Add the registry config to the nodes"
+# 3. Add the registry config to the nodes
+#
+# This is necessary because localhost resolves to loopback addresses that are
+# network-namespace local.
+# In other words: localhost in the container is not localhost on the host.
+#
+# We want a consistent name that works from both ends, so we tell containerd to
+# alias localhost:${reg_port} to the registry container when pulling images
+REGISTRY_DIR="/etc/containerd/certs.d/localhost:${reg_port}"
+for node in $(kind get nodes); do
+	docker exec "${node}" mkdir -p "${REGISTRY_DIR}"
+	cat <<EOF | docker exec -i "${node}" cp /dev/stdin "${REGISTRY_DIR}/hosts.toml"
+[host."http://${reg_name}:5000"]
+EOF
+done
+
+echo "4. Connect the registry to the cluster network if not already connected"
+# 4. Connect the registry to the cluster network if not already connected
+# This allows kind to bootstrap the network but ensures they're on the same network
+if [ "$(docker inspect -f='{{json .NetworkSettings.Networks.kind}}' "${reg_name}")" = 'null' ]; then
+	docker network connect "kind" "${reg_name}"
+fi
+
+echo "5. Document the local registry"
+# 5. Document the local registry
+# https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/generic/1755-communicating-a-local-registry
+cat <<EOF | kubectl apply -f -
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: local-registry-hosting
+  namespace: kube-public
+data:
+  localRegistryHosting.v1: |
+    host: "localhost:${reg_port}"
+    help: "https://kind.sigs.k8s.io/docs/user/local-registry/"
+EOF
+
+echo "6. Install ingress-nginx"
+kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/main/deploy/static/provider/kind/deploy.yaml
+kubectl -n ingress-nginx create secret tls mkcert --key /tmp/127.0.0.1.nip.io+1-key.pem --cert /tmp/127.0.0.1.nip.io+1.pem
+kubectl -n ingress-nginx patch deployments.apps ingress-nginx-controller --type 'json' -p '[{"op": "add", "path": "/spec/template/spec/containers/0/args/-", "value":"--default-ssl-certificate=ingress-nginx/mkcert"}]'

docker-compose.yml

@@ -1,3 +1,5 @@
+version: '3.8'
+
 services:
   postgresql:
     image: postgres:16
@@ -63,6 +65,7 @@ services:
         - mailcatcher
         - redis
         - createbuckets
+        - nginx
   
   celery-dev:
     user: ${DOCKER_USER:-1000}
@@ -117,23 +120,6 @@ services:
       - ./docker/files/etc/nginx/conf.d:/etc/nginx/conf.d:ro
     depends_on:
       - keycloak
-      - app-dev
-      - y-provider
-
-  frontend-dev:
-    user: "${DOCKER_USER:-1000}"
-    build: 
-      context: .
-      dockerfile: ./src/frontend/Dockerfile
-      target: frontend-production
-      args:
-        API_ORIGIN: "http://localhost:8071"
-        Y_PROVIDER_URL: "ws://localhost:4444"
-        MEDIA_URL: "http://localhost:8083"
-        SW_DEACTIVATED: "true"
-    image: impress:frontend-development
-    ports:
-      - "3000:3000"
 
   dockerize:
     image: jwilder/dockerize
@@ -155,20 +141,38 @@ services:
     volumes:
       - ".:/app"
 
-  y-provider:
+  y-webrtc-signaling:
     user: ${DOCKER_USER:-1000}
     build: 
       context: .
-      dockerfile: ./src/frontend/servers/y-provider/Dockerfile
-      target: y-provider
+      dockerfile: ./src/frontend/Dockerfile
+      target: y-webrtc-signaling
     restart: unless-stopped
-    env_file:
-      - env.d/development/common
     ports:
       - "4444:4444"
+    volumes:
+      - ./src/frontend/apps/y-webrtc-signaling:/home/frontend/apps/y-webrtc-signaling
+      - /home/frontend/apps/y-webrtc-signaling/node_modules/
+      - /home/frontend/apps/y-webrtc-signaling/dist/
+
+  frontend-dev:
+    user: "${DOCKER_USER:-1000}"
+    build: 
+      context: .
+      dockerfile: ./src/frontend/Dockerfile
+      target: impress-dev
+    ports:
+      - "3000:3000"
+    volumes:
+      - ./src/frontend/apps/impress:/home/frontend/apps/impress
+      - /home/frontend/node_modules/
+    depends_on:
+      - y-webrtc-signaling
+      - celery-dev
 
   kc_postgresql:
     image: postgres:14.3
+    platform: linux/amd64
     ports:
       - "5433:5432"
     env_file:

docker/files/etc/nginx/conf.d/default.conf

@@ -4,85 +4,6 @@ server {
     server_name localhost;
     charset utf-8;
 
-    # Proxy auth for collaboration server
-    location /collaboration/ws/ {
-        # Collaboration Auth request configuration
-        auth_request /collaboration-auth;
-        auth_request_set $authHeader $upstream_http_authorization;
-        auth_request_set $canEdit $upstream_http_x_can_edit;
-        auth_request_set $userId $upstream_http_x_user_id;
-
-        # Pass specific headers from the auth response
-        proxy_set_header Authorization $authHeader;
-        proxy_set_header X-Can-Edit $canEdit;
-        proxy_set_header X-User-Id $userId;
-
-        # Ensure WebSocket upgrade
-        proxy_http_version 1.1;
-        proxy_set_header Upgrade $http_upgrade;
-        proxy_set_header Connection "Upgrade";
-
-        # Collaboration server
-        proxy_pass http://y-provider:4444;
-
-        # Set appropriate timeout for WebSocket
-        proxy_read_timeout 86400;
-        proxy_send_timeout 86400;
-
-        # Preserve original host and additional headers
-        proxy_set_header Host $host;
-    }
-
-    location /collaboration-auth {
-        proxy_pass http://app-dev:8000/api/v1.0/documents/collaboration-auth/;
-        proxy_set_header Host $host;
-        proxy_set_header X-Real-IP $remote_addr;
-        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
-        proxy_set_header X-Original-URL $request_uri;
-        
-        # Prevent the body from being passed
-        proxy_pass_request_body off;
-        proxy_set_header Content-Length "";
-        proxy_set_header X-Original-Method $request_method;
-    }
-
-    location  /collaboration/api/ {
-        # Collaboration server
-        proxy_pass http://y-provider:4444;
-        proxy_set_header Host $host;
-    }
-
-    # Proxy auth for media
-    location /media/ {
-        # Auth request configuration
-        auth_request /media-auth;
-        auth_request_set $authHeader $upstream_http_authorization;
-        auth_request_set $authDate $upstream_http_x_amz_date;
-        auth_request_set $authContentSha256 $upstream_http_x_amz_content_sha256;
-
-        # Pass specific headers from the auth response
-        proxy_set_header Authorization $authHeader;
-        proxy_set_header X-Amz-Date $authDate;
-        proxy_set_header X-Amz-Content-SHA256 $authContentSha256;
-
-        # Get resource from Minio
-        proxy_pass http://minio:9000/impress-media-storage/;
-        proxy_set_header Host minio:9000;
-    }
-
-    location /media-auth {
-        proxy_pass http://app-dev:8000/api/v1.0/documents/media-auth/;
-        proxy_set_header Host $host;
-        proxy_set_header X-Real-IP $remote_addr;
-        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
-        proxy_set_header X-Original-URL $request_uri;
-        
-        # Prevent the body from being passed
-        proxy_pass_request_body off;
-        proxy_set_header Content-Length "";
-        proxy_set_header X-Original-Method $request_method;
-    }
-
     location / {
         proxy_pass http://keycloak:8080;
         proxy_set_header Host $host;

docs/examples/impress.values.yaml

@@ -1,156 +0,0 @@
-image:
-  repository: lasuite/impress-backend
-  pullPolicy: Always
-  tag: "latest"
-
-backend:
-  replicas: 1
-  envVars:
-    COLLABORATION_API_URL: https://impress.127.0.0.1.nip.io/collaboration/api/
-    COLLABORATION_SERVER_SECRET: my-secret
-    DJANGO_CSRF_TRUSTED_ORIGINS: https://impress.127.0.0.1.nip.io
-    DJANGO_CONFIGURATION: Feature
-    DJANGO_ALLOWED_HOSTS: impress.127.0.0.1.nip.io
-    DJANGO_SERVER_TO_SERVER_API_TOKENS: secret-api-key
-    DJANGO_SECRET_KEY: AgoodOrAbadKey
-    DJANGO_SETTINGS_MODULE: impress.settings
-    DJANGO_SUPERUSER_PASSWORD: admin
-    DJANGO_EMAIL_BRAND_NAME: "La Suite Numérique"
-    DJANGO_EMAIL_HOST: "mailcatcher"
-    DJANGO_EMAIL_LOGO_IMG: https://impress.127.0.0.1.nip.io/assets/logo-suite-numerique.png
-    DJANGO_EMAIL_PORT: 1025
-    DJANGO_EMAIL_USE_SSL: False
-    LOGGING_LEVEL_HANDLERS_CONSOLE: ERROR
-    LOGGING_LEVEL_LOGGERS_ROOT: INFO
-    LOGGING_LEVEL_LOGGERS_APP: INFO
-    OIDC_OP_JWKS_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/certs
-    OIDC_OP_AUTHORIZATION_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/auth
-    OIDC_OP_TOKEN_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/token
-    OIDC_OP_USER_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/userinfo
-    OIDC_OP_LOGOUT_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/session/end
-    OIDC_RP_CLIENT_ID: impress
-    OIDC_RP_CLIENT_SECRET: ThisIsAnExampleKeyForDevPurposeOnly
-    OIDC_RP_SIGN_ALGO: RS256
-    OIDC_RP_SCOPES: "openid email"
-    OIDC_VERIFY_SSL: False
-    USER_OIDC_FIELD_TO_SHORTNAME: "given_name"
-    USER_OIDC_FIELDS_TO_FULLNAME: "given_name,usual_name"
-    OIDC_REDIRECT_ALLOWED_HOSTS: https://impress.127.0.0.1.nip.io
-    OIDC_AUTH_REQUEST_EXTRA_PARAMS: "{'acr_values': 'eidas1'}"
-    LOGIN_REDIRECT_URL: https://impress.127.0.0.1.nip.io
-    LOGIN_REDIRECT_URL_FAILURE: https://impress.127.0.0.1.nip.io
-    LOGOUT_REDIRECT_URL: https://impress.127.0.0.1.nip.io
-    DB_HOST: postgresql
-    DB_NAME: impress
-    DB_USER: dinum
-    DB_PASSWORD: pass
-    DB_PORT: 5432
-    POSTGRES_DB: impress
-    POSTGRES_USER: dinum
-    POSTGRES_PASSWORD: pass
-    REDIS_URL: redis://default:pass@redis-master:6379/1
-    AWS_S3_ENDPOINT_URL: http://minio.impress.svc.cluster.local:9000
-    AWS_S3_ACCESS_KEY_ID: root
-    AWS_S3_SECRET_ACCESS_KEY: password
-    AWS_STORAGE_BUCKET_NAME: impress-media-storage
-    STORAGES_STATICFILES_BACKEND: django.contrib.staticfiles.storage.StaticFilesStorage
-    Y_PROVIDER_API_BASE_URL: http://impress-y-provider:443/api/
-    Y_PROVIDER_API_KEY: my-secret
-
-  migrate:
-    command:
-      - "/bin/sh"
-      - "-c"
-      - |
-        python manage.py migrate --no-input &&
-        python manage.py create_demo --force
-    restartPolicy: Never
-
-  command:
-    - "gunicorn"
-    - "-c"
-    - "/usr/local/etc/gunicorn/impress.py"
-    - "impress.wsgi:application"
-    - "--reload"
-
-  createsuperuser:
-    command:
-      - "/bin/sh"
-      - "-c"
-      - |
-        python manage.py createsuperuser --email admin@example.com --password admin
-    restartPolicy: Never
-
-  # Exra volume to manage our local custom CA and avoid to set ssl_verify: false
-  extraVolumeMounts:
-    - name: certs
-      mountPath: /usr/local/lib/python3.12/site-packages/certifi/cacert.pem
-      subPath: cacert.pem
-
-  # Exra volume to manage our local custom CA and avoid to set ssl_verify: false
-  extraVolumes:
-    - name: certs
-      configMap:
-        name: certifi
-        items:
-        - key: cacert.pem
-          path: cacert.pem
-frontend:
-  envVars:
-    PORT: 8080
-    NEXT_PUBLIC_API_ORIGIN: https://impress.127.0.0.1.nip.io
-
-  replicas: 1
-
-  image:
-    repository: lasuite/impress-frontend
-    pullPolicy: Always
-    tag: "latest"
-
-yProvider:
-  replicas: 1
-
-  image:
-    repository: lasuite/impress-y-provider
-    pullPolicy: Always
-    tag: "latest"
-
-  envVars:
-    COLLABORATION_LOGGING: true
-    COLLABORATION_SERVER_ORIGIN: https://impress.127.0.0.1.nip.io
-    COLLABORATION_SERVER_SECRET: my-secret
-    Y_PROVIDER_API_KEY: my-secret
-
-ingress:
-  enabled: true
-  host: impress.127.0.0.1.nip.io
-
-ingressCollaborationWS:
-  enabled: true
-  host: impress.127.0.0.1.nip.io
-  
-  annotations:
-    nginx.ingress.kubernetes.io/auth-url: https://impress.127.0.0.1.nip.io/api/v1.0/documents/collaboration-auth/
-
-ingressCollaborationApi:
-  enabled: true
-  host: impress.127.0.0.1.nip.io
-
-ingressAdmin:
-  enabled: true
-  host: impress.127.0.0.1.nip.io
-
-ingressMedia:
-  enabled: true
-  host: impress.127.0.0.1.nip.io
-
-  annotations:
-    nginx.ingress.kubernetes.io/auth-url: https://impress.127.0.0.1.nip.io/api/v1.0/documents/media-auth/
-    nginx.ingress.kubernetes.io/auth-response-headers: "Authorization, X-Amz-Date, X-Amz-Content-SHA256"
-    nginx.ingress.kubernetes.io/upstream-vhost: minio.impress.svc.cluster.local:9000
-    nginx.ingress.kubernetes.io/rewrite-target: /impress-media-storage/$1
-
-serviceMedia:
-  host: minio.impress.svc.cluster.local
-  port: 9000
-

docs/examples/minio.values.yaml

@@ -1,8 +0,0 @@
-auth:
-  rootUser: root
-  rootPassword: password
-provisioning:
-  enabled: true
-  buckets:
-    - name: impress-media-storage
-      versioning: true

docs/examples/postgresql.values.yaml

@@ -1,7 +0,0 @@
-auth:
-  username: dinum
-  password: pass
-  database: impress
-tls:
-  enabled: true
-  autoGenerated: true

docs/examples/redis.values.yaml

@@ -1,4 +0,0 @@
-auth:
-  password: pass
-architecture: standalone
-

docs/installation.md

@@ -1,231 +0,0 @@
-# Installation on a k8s cluster
-
-This document is a step-by-step guide that describes how to install Docs on a k8s cluster without AI features.
-
-
-## Prerequisites
-
-- k8s cluster with an nginx-ingress controller
-- an OIDC provider (if you don't have one, we will provide an example)
-- a PostgreSQL server (if you don't have one, we will provide an example)
-- a Memcached server (if you don't have one, we will provide an example)
-- a S3 bucket (if you don't have one, we will provide an example)
-
-### Test cluster
-
-If you do not have a test cluster, you can install everything on a local kind cluster. In this case, the simplest way is to use our script **bin/start-kind.sh**.
-
-To be able to use the script, you will need to install:
-
-- Docker (https://docs.docker.com/desktop/)
-- Kind (https://kind.sigs.k8s.io/docs/user/quick-start/#installation)
-- Mkcert (https://github.com/FiloSottile/mkcert#installation)
-- Helm (https://helm.sh/docs/intro/quickstart/#install-helm)
-
-```
-./bin/start-kind.sh 
-  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
-                                 Dload  Upload   Total   Spent    Left  Speed
-100  4700  100  4700    0     0  92867      0 --:--:-- --:--:-- --:--:-- 94000
-0. Create ca
-The local CA is already installed in the system trust store! 👍
-The local CA is already installed in the Firefox and/or Chrome/Chromium trust store! 👍
-
-
-Created a new certificate valid for the following names 📜
- - "127.0.0.1.nip.io"
- - "*.127.0.0.1.nip.io"
-
-Reminder: X.509 wildcards only go one level deep, so this won't match a.b.127.0.0.1.nip.io ℹ️
-
-The certificate is at "./127.0.0.1.nip.io+1.pem" and the key at "./127.0.0.1.nip.io+1-key.pem" ✅
-
-It will expire on 24 March 2027 🗓
-
-1. Create registry container unless it already exists
-2. Create kind cluster with containerd registry config dir enabled
-Creating cluster "suite" ...
- ✓ Ensuring node image (kindest/node:v1.27.3) 🖼
- ✓ Preparing nodes 📦  
- ✓ Writing configuration 📜 
- ✓ Starting control-plane 🕹️ 
- ✓ Installing CNI 🔌 
- ✓ Installing StorageClass 💾 
-Set kubectl context to "kind-suite"
-You can now use your cluster with:
-
-kubectl cluster-info --context kind-suite
-
-Thanks for using kind! 😊
-3. Add the registry config to the nodes
-4. Connect the registry to the cluster network if not already connected
-5. Document the local registry
-configmap/local-registry-hosting created
-Warning: resource configmaps/coredns is missing the kubectl.kubernetes.io/last-applied-configuration annotation which is required by kubectl apply. kubectl apply should only be used on resources created declaratively by either kubectl create --save-config or kubectl apply. The missing annotation will be patched automatically.
-configmap/coredns configured
-deployment.apps/coredns restarted
-6. Install ingress-nginx
-namespace/ingress-nginx created
-serviceaccount/ingress-nginx created
-serviceaccount/ingress-nginx-admission created
-role.rbac.authorization.k8s.io/ingress-nginx created
-role.rbac.authorization.k8s.io/ingress-nginx-admission created
-clusterrole.rbac.authorization.k8s.io/ingress-nginx created
-clusterrole.rbac.authorization.k8s.io/ingress-nginx-admission created
-rolebinding.rbac.authorization.k8s.io/ingress-nginx created
-rolebinding.rbac.authorization.k8s.io/ingress-nginx-admission created
-clusterrolebinding.rbac.authorization.k8s.io/ingress-nginx created
-clusterrolebinding.rbac.authorization.k8s.io/ingress-nginx-admission created
-configmap/ingress-nginx-controller created
-service/ingress-nginx-controller created
-service/ingress-nginx-controller-admission created
-deployment.apps/ingress-nginx-controller created
-job.batch/ingress-nginx-admission-create created
-job.batch/ingress-nginx-admission-patch created
-ingressclass.networking.k8s.io/nginx created
-validatingwebhookconfiguration.admissionregistration.k8s.io/ingress-nginx-admission created
-secret/mkcert created
-deployment.apps/ingress-nginx-controller patched
-7. Setup namespace
-namespace/impress created
-Context "kind-suite" modified.
-secret/mkcert created
-$ kubectl -n ingress-nginx get po
-NAME                                        READY   STATUS      RESTARTS   AGE
-ingress-nginx-admission-create-t55ph        0/1     Completed   0          2m56s
-ingress-nginx-admission-patch-94dvt         0/1     Completed   1          2m56s
-ingress-nginx-controller-57c548c4cd-2rx47   1/1     Running     0          2m56s
-```
-When your k8s cluster is ready (the ingress nginx controller is up), you can start the deployment. This cluster is special because it uses the *.127.0.0.1.nip.io domain and mkcert certificates to have full HTTPS support and easy domain name management.
-
-Please remember that *.127.0.0.1.nip.io will always resolve to 127.0.0.1, except in the k8s cluster where we configure CoreDNS to answer with the ingress-nginx service IP.
-
-## Preparation
-
-### What will you use to authenticate your users ?
-
-Docs uses OIDC, so if you already have an OIDC provider, obtain the necessary information to use it. In the next step, we will see how to configure Django (and thus Docs) to use it. If you do not have a provider, we will show you how to deploy a local Keycloak instance (this is not a production deployment, just a demo).
-
-```
-$ kubectl create namespace impress
-$ kubectl config set-context --current --namespace=impress
-$ helm install keycloak oci://registry-1.docker.io/bitnamicharts/keycloak -f examples/keycloak.values.yaml
-$ #wait until
-$ kubectl get po
-NAME                    READY   STATUS    RESTARTS   AGE
-keycloak-0              1/1     Running   0          6m48s
-keycloak-postgresql-0   1/1     Running   0          6m48s
-```
-
-From here the important informations you will need are :
-
-```
-OIDC_OP_JWKS_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/certs
-OIDC_OP_AUTHORIZATION_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/auth
-OIDC_OP_TOKEN_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/token
-OIDC_OP_USER_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/userinfo
-OIDC_OP_LOGOUT_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/session/end
-OIDC_RP_CLIENT_ID: impress
-OIDC_RP_CLIENT_SECRET: ThisIsAnExampleKeyForDevPurposeOnly
-OIDC_RP_SIGN_ALGO: RS256
-OIDC_RP_SCOPES: "openid email"
-```
-
-You can find these values in **examples/keycloak.values.yaml**
-
-### Find redis server connexion values
-
-Impress need a redis so we will start by deploying a redis :
-
-```
-$ helm install redis oci://registry-1.docker.io/bitnamicharts/redis -f examples/redis.values.yaml
-$ kubectl get po
-NAME                    READY   STATUS    RESTARTS   AGE
-keycloak-0              1/1     Running   0          26m
-keycloak-postgresql-0   1/1     Running   0          26m
-redis-master-0          1/1     Running   0          35s
-```
-
-### Find postgresql connexion values
-
-Impress uses a postgresql db as backend so if you have a provider, obtain the necessary information to use it. If you do not have, you can install a postgresql testing environment as follow:
-
-```
-$ helm install postgresql oci://registry-1.docker.io/bitnamicharts/postgresql -f examples/postgresql.values.yaml
-$ kubectl get po
-NAME                    READY   STATUS    RESTARTS   AGE
-keycloak-0              1/1     Running   0          28m
-keycloak-postgresql-0   1/1     Running   0          28m
-postgresql-0            1/1     Running   0          14m
-redis-master-0          1/1     Running   0          42s
-```
-
-From here important informations you will need are :
-
-```
-DB_HOST: postgres-postgresql
-DB_NAME: impress
-DB_USER: dinum
-DB_PASSWORD: pass
-DB_PORT: 5432
-POSTGRES_DB: impress
-POSTGRES_USER: dinum
-POSTGRES_PASSWORD: pass
-```
-
-### Find s3 bucket connexion values
-
-Impress uses a s3 bucket to store documents so if you have a provider obtain the necessary information to use it. If you do not have, you can install a local minio testing environment as follow:
-
-```
-$ helm install minio oci://registry-1.docker.io/bitnamicharts/minio -f examples/minio.values.yaml
-$ kubectl get po
-NAME                       READY   STATUS      RESTARTS   AGE
-keycloak-0                 1/1     Running     0          38m
-keycloak-postgresql-0      1/1     Running     0          38m
-minio-84f5c66895-bbhsk     1/1     Running     0          42s
-minio-provisioning-2b5sq   0/1     Completed   0          42s
-postgresql-0               1/1     Running     0          24m
-redis-master-0             1/1     Running     0          10m
-```
-
-## Deployment
-
-Now you are ready to deploy Impress without AI. AI requiered more dependancies (openai API). To deploy impress you need to provide all previous informations to the helm chart.
-
-```
-$ helm repo add impress https://numerique-gouv.github.io/impress/
-$ helm repo update
-$ helm install impress impress/docs -f examples/impress.values.yaml
-$ kubectl get po
-NAME                                         READY   STATUS      RESTARTS   AGE
-impress-docs-backend-96558758d-xtkbp         0/1     Running     0          79s
-impress-docs-backend-createsuperuser-r7ltc   0/1     Completed   0          79s
-impress-docs-backend-migrate-c949s           0/1     Completed   0          79s
-impress-docs-frontend-6749f644f7-p5s42       1/1     Running     0          79s
-impress-docs-y-provider-6947fd8f54-78f2l     1/1     Running     0          79s
-keycloak-0                                   1/1     Running     0          48m
-keycloak-postgresql-0                        1/1     Running     0          48m
-minio-84f5c66895-bbhsk                       1/1     Running     0          10m
-minio-provisioning-2b5sq                     0/1     Completed   0          10m
-postgresql-0                                 1/1     Running     0          34m
-redis-master-0                               1/1     Running     0          20m
-```
-
-## Test your deployment
-
-In order to test your deployment you have to login to your instance. If you use exclusively our examples you can do :
-
-```
-$ kubectl get ingress
-NAME                             CLASS    HOSTS                       ADDRESS     PORTS     AGE
-impress-docs                     <none>   impress.127.0.0.1.nip.io    localhost   80, 443   114s
-impress-docs-admin               <none>   impress.127.0.0.1.nip.io    localhost   80, 443   114s
-impress-docs-collaboration-api   <none>   impress.127.0.0.1.nip.io    localhost   80, 443   114s
-impress-docs-media               <none>   impress.127.0.0.1.nip.io    localhost   80, 443   114s
-impress-docs-ws                  <none>   impress.127.0.0.1.nip.io    localhost   80, 443   114s
-keycloak                         <none>   keycloak.127.0.0.1.nip.io   localhost   80        49m
-```
-
-You can use impress on https://impress.127.0.0.1.nip.io. The provisionning user in keycloak is impress/impress.
-

docs/release.md

@@ -1,72 +0,0 @@
-# Releasing a new version
-
-Whenever we are cooking a new release (e.g. `4.18.1`) we should follow a standard procedure described below:
-
-1.  Create a new branch named: `release/4.18.1`.
-   2.  Bump the release number for backend project, frontend projects, and Helm files:
-
-       - for backend, update the version number by hand in `pyproject.toml`,
-       - for each projects (`src/frontend`, `src/frontend/apps/*`, `src/frontend/packages/*`, `src/mail`), run `yarn version --new-version --no-git-tag-version 4.18.1` in their directory. This will update their `package.json` for you,
-       - for Helm, update Docker image tag in files located at `src/helm/env.d` for both `preprod` and `production` environments:
-
-         ```yaml
-         image:
-           repository: lasuite/impress-backend
-           pullPolicy: Always
-           tag: "v4.18.1" # Replace with your new version number, without forgetting the "v" prefix
-      
-         ...
-      
-         frontend:
-           image:
-             repository: lasuite/impress-frontend
-             pullPolicy: Always
-             tag: "v4.18.1" 
-
-          y-provider:
-            image:
-              repository: lasuite/impress-y-provider
-              pullPolicy: Always
-              tag: "v4.18.1" 
-         ```
-
-         The new images don't exist _yet_: they will be created automatically later in the process.
-
-3.  Update the project's `Changelog` following the [keepachangelog](https://keepachangelog.com/en/0.3.0/) recommendations
-
-4.  Commit your changes with the following format: the 🔖 release emoji, the type of release (patch/minor/patch) and the release version:
-
-    ```text
-    🔖(minor) bump release to 4.18.0
-    ```
-
-5.  Open a pull request, wait for an approval from your peers and merge it.
-6.  Checkout and pull changes from the `main` branch to ensure you have the latest updates.
-7.  Tag and push your commit:
-
-    ```bash
-    git tag v4.18.1 && git push origin tag v4.18.1
-    ```
-
-    Doing this triggers the CI and tells it to build the new Docker image versions that you targeted earlier in the Helm files.
-
-8.  Ensure the new [backend](https://hub.docker.com/r/lasuite/impress-frontend/tags) and [frontend](https://hub.docker.com/r/lasuite/impress-frontend/tags) image tags are on Docker Hub.
-9.  The release is now done!
-
-# Deploying
-
-> [!TIP]
-> The `staging` platform is deployed automatically with every update of the `main` branch.
-
-Making a new release doesn't publish it automatically in production.
-
-Deployment is done by ArgoCD. ArgoCD checks for the `production` tag and automatically deploys the production platform with the targeted commit.
-
-To publish, we mark the commit we want with the `production` tag. ArgoCD is then notified that the tag has changed. It then deploys the Docker image tags specified in the Helm files of the targeted commit.
-
-To publish the release you just made:
-
-```bash
-git tag --force production v4.18.1
-git push --force origin production
-```

docs/tsclient.md

@@ -0,0 +1,25 @@
+# Api client TypeScript
+
+The backend application can automatically create a TypeScript client to be used in frontend
+applications. It is used in the impress front application itself.
+
+This client is made with [openapi-typescript-codegen](https://github.com/ferdikoomen/openapi-typescript-codegen)
+and impress's backend OpenAPI schema (available [here](http://localhost:8071/v1.0/swagger/) if you have the backend running).
+
+## Requirements
+
+We'll need the online OpenAPI schema generated by swagger. Therefore you will first need to
+install the backend application.
+
+## Install openApiClientJs
+
+```sh
+$ cd src/tsclient
+$ yarn install
+```
+
+## Generate the client
+
+```sh
+yarn generate:api:client:local <output_path_for_generated_client>
+```

env.d/development/common.dist

@@ -4,21 +4,13 @@ DJANGO_SECRET_KEY=ThisIsAnExampleKeyForDevPurposeOnly
 DJANGO_SETTINGS_MODULE=impress.settings
 DJANGO_SUPERUSER_PASSWORD=admin
 
-# Logging
-# Set to DEBUG level for dev only
-LOGGING_LEVEL_HANDLERS_CONSOLE=INFO
-LOGGING_LEVEL_LOGGERS_ROOT=INFO
-LOGGING_LEVEL_LOGGERS_APP=INFO
-
 # Python
 PYTHONPATH=/app
 
 # impress settings
 
 # Mail
-DJANGO_EMAIL_BRAND_NAME="La Suite Numérique"
 DJANGO_EMAIL_HOST="mailcatcher"
-DJANGO_EMAIL_LOGO_IMG="http://localhost:3000/assets/logo-suite-numerique.png"
 DJANGO_EMAIL_PORT=1025
 
 # Backend url
@@ -29,7 +21,6 @@ STORAGES_STATICFILES_BACKEND=django.contrib.staticfiles.storage.StaticFilesStora
 AWS_S3_ENDPOINT_URL=http://minio:9000
 AWS_S3_ACCESS_KEY_ID=impress
 AWS_S3_SECRET_ACCESS_KEY=password
-MEDIA_BASE_URL=http://localhost:8083
 
 # OIDC
 OIDC_OP_JWKS_ENDPOINT=http://nginx:8083/realms/impress/protocol/openid-connect/certs
@@ -48,17 +39,3 @@ LOGOUT_REDIRECT_URL=http://localhost:3000
 
 OIDC_REDIRECT_ALLOWED_HOSTS=["http://localhost:8083", "http://localhost:3000"]
 OIDC_AUTH_REQUEST_EXTRA_PARAMS={"acr_values": "eidas1"}
-
-# AI
-AI_BASE_URL=https://openaiendpoint.com
-AI_API_KEY=password
-AI_MODEL=llama
-
-# Collaboration
-COLLABORATION_API_URL=http://nginx:8083/collaboration/api/
-COLLABORATION_SERVER_ORIGIN=http://localhost:3000
-COLLABORATION_SERVER_SECRET=my-secret
-COLLABORATION_WS_URL=ws://localhost:8083/collaboration/ws/
-
-# Frontend
-FRONTEND_THEME=dsfr

env.d/development/common.e2e.dist

@@ -1,6 +1,3 @@
 # For the CI job test-e2e
 SUSTAINED_THROTTLE_RATES="200/hour"
 BURST_THROTTLE_RATES="200/minute"
-DJANGO_SERVER_TO_SERVER_API_TOKENS=test-e2e
-Y_PROVIDER_API_KEY=yprovider-api-key
-Y_PROVIDER_API_BASE_URL=http://y-provider:4444/api/

renovate.json

@@ -17,8 +17,8 @@
         "fetch-mock",
         "node",
         "node-fetch",
-        "eslint",
-        "workbox-webpack-plugin"
+        "i18next-parser",
+        "eslint"
       ]
     }
   ]

scripts/updatekeys.sh

@@ -0,0 +1,3 @@
+#!/bin/bash
+
+find . -name "*.enc.*" -exec sops updatekeys -y {} \;

src/backend/.pylintrc

@@ -447,10 +447,10 @@ max-bool-expr=5
 max-branches=12
 
 # Maximum number of locals for function / method body
-max-locals=20
+max-locals=15
 
 # Maximum number of parents for a class (see R0901).
-max-parents=10
+max-parents=7
 
 # Maximum number of public methods for a class (see R0904).
 max-public-methods=20

src/backend/core/admin.py

@@ -1,5 +1,4 @@
 """Admin classes and registrations for core app."""
-
 from django.contrib import admin
 from django.contrib.auth import admin as auth_admin
 from django.utils.translation import gettext_lazy as _
@@ -29,19 +28,7 @@ class UserAdmin(auth_admin.UserAdmin):
                 )
             },
         ),
-        (
-            _("Personal info"),
-            {
-                "fields": (
-                    "sub",
-                    "email",
-                    "full_name",
-                    "short_name",
-                    "language",
-                    "timezone",
-                )
-            },
-        ),
+        (_("Personal info"), {"fields": ("sub", "email", "language", "timezone")}),
         (
             _("Permissions"),
             {
@@ -70,7 +57,6 @@ class UserAdmin(auth_admin.UserAdmin):
     list_display = (
         "id",
         "sub",
-        "full_name",
         "admin_email",
         "email",
         "is_active",
@@ -81,24 +67,9 @@ class UserAdmin(auth_admin.UserAdmin):
         "updated_at",
     )
     list_filter = ("is_staff", "is_superuser", "is_device", "is_active")
-    ordering = (
-        "is_active",
-        "-is_superuser",
-        "-is_staff",
-        "-is_device",
-        "-updated_at",
-        "full_name",
-    )
-    readonly_fields = (
-        "id",
-        "sub",
-        "email",
-        "full_name",
-        "short_name",
-        "created_at",
-        "updated_at",
-    )
-    search_fields = ("id", "sub", "admin_email", "email", "full_name")
+    ordering = ("is_active", "-is_superuser", "-is_staff", "-is_device", "-updated_at")
+    readonly_fields = ("id", "sub", "email", "created_at", "updated_at")
+    search_fields = ("id", "sub", "admin_email", "email")
 
 
 @admin.register(models.Template)
@@ -120,14 +91,6 @@ class DocumentAdmin(admin.ModelAdmin):
     """Document admin interface declaration."""
 
     inlines = (DocumentAccessInline,)
-    list_display = (
-        "id",
-        "title",
-        "link_reach",
-        "link_role",
-        "created_at",
-        "updated_at",
-    )
 
 
 @admin.register(models.Invitation)

src/backend/core/api/__init__.py

@@ -1,5 +1,4 @@
 """Impress core API endpoints"""
-
 from django.conf import settings
 from django.core.exceptions import ValidationError
 
@@ -17,9 +16,9 @@ def exception_handler(exc, context):
     https://gist.github.com/twidi/9d55486c36b6a51bdcb05ce3a763e79f
     """
     if isinstance(exc, ValidationError):
-        detail = exc.message_dict
-
-        if hasattr(exc, "message"):
+        if hasattr(exc, "message_dict"):
+            detail = exc.message_dict
+        elif hasattr(exc, "message"):
             detail = exc.message
         elif hasattr(exc, "messages"):
             detail = exc.messages

src/backend/core/api/fields.py

@@ -1,5 +1,4 @@
 """A JSONField for DRF to handle serialization/deserialization."""
-
 import json
 
 from rest_framework import serializers

src/backend/core/api/filters.py

@@ -1,69 +0,0 @@
-"""API filters for Impress' core application."""
-
-from django.utils.translation import gettext_lazy as _
-
-import django_filters
-
-from core import models
-
-
-class DocumentFilter(django_filters.FilterSet):
-    """
-    Custom filter for filtering documents.
-    """
-
-    is_creator_me = django_filters.BooleanFilter(
-        method="filter_is_creator_me", label=_("Creator is me")
-    )
-    is_favorite = django_filters.BooleanFilter(
-        method="filter_is_favorite", label=_("Favorite")
-    )
-    title = django_filters.CharFilter(
-        field_name="title", lookup_expr="icontains", label=_("Title")
-    )
-
-    class Meta:
-        model = models.Document
-        fields = ["is_creator_me", "is_favorite", "link_reach", "title"]
-
-    # pylint: disable=unused-argument
-    def filter_is_creator_me(self, queryset, name, value):
-        """
-        Filter documents based on the `creator` being the current user.
-
-        Example:
-            - /api/v1.0/documents/?is_creator_me=true
-                → Filters documents created by the logged-in user
-            - /api/v1.0/documents/?is_creator_me=false
-                → Filters documents created by other users
-        """
-        user = self.request.user
-
-        if not user.is_authenticated:
-            return queryset
-
-        if value:
-            return queryset.filter(creator=user)
-
-        return queryset.exclude(creator=user)
-
-    # pylint: disable=unused-argument
-    def filter_is_favorite(self, queryset, name, value):
-        """
-        Filter documents based on whether they are marked as favorite by the current user.
-
-        Example:
-            - /api/v1.0/documents/?is_favorite=true
-                → Filters documents marked as favorite by the logged-in user
-            - /api/v1.0/documents/?is_favorite=false
-                → Filters documents not marked as favorite by the logged-in user
-        """
-        user = self.request.user
-
-        if not user.is_authenticated:
-            return queryset
-
-        if value:
-            return queryset.filter(favorited_by_users__user=user)
-
-        return queryset.exclude(favorited_by_users__user=user)

src/backend/core/api/permissions.py

@@ -1,12 +1,8 @@
 """Permission handlers for the impress core app."""
-
 from django.core import exceptions
-from django.db.models import Q
 
 from rest_framework import permissions
 
-from core.models import DocumentAccess, RoleChoices
-
 ACTION_FOR_METHOD_TO_PERMISSION = {
     "versions_detail": {"DELETE": "versions_destroy", "GET": "versions_retrieve"}
 }
@@ -62,44 +58,9 @@ class IsOwnedOrPublic(IsAuthenticated):
             return False
 
 
-class CanCreateInvitationPermission(permissions.BasePermission):
-    """
-    Custom permission class to handle permission checks for managing invitations.
-    """
-
-    def has_permission(self, request, view):
-        user = request.user
-
-        # Ensure the user is authenticated
-        if not (bool(request.auth) or request.user.is_authenticated):
-            return False
-
-        # Apply permission checks only for creation (POST requests)
-        if view.action != "create":
-            return True
-
-        # Check if resource_id is passed in the context
-        try:
-            document_id = view.kwargs["resource_id"]
-        except KeyError as exc:
-            raise exceptions.ValidationError(
-                "You must set a document ID in kwargs to manage document invitations."
-            ) from exc
-
-        # Check if the user has access to manage invitations (Owner/Admin roles)
-        return DocumentAccess.objects.filter(
-            Q(user=user) | Q(team__in=user.teams),
-            document=document_id,
-            role__in=[RoleChoices.OWNER, RoleChoices.ADMIN],
-        ).exists()
-
-
 class AccessPermission(permissions.BasePermission):
     """Permission class for access objects."""
 
-    def has_permission(self, request, view):
-        return request.user.is_authenticated or view.action != "create"
-
     def has_object_permission(self, request, view, obj):
         """Check permission for a given object."""
         abilities = obj.get_abilities(request.user)

src/backend/core/api/serializers.py

@@ -1,21 +1,10 @@
 """Client serializers for the impress core app."""
-
-import mimetypes
-
-from django.conf import settings
 from django.db.models import Q
-from django.utils.functional import lazy
 from django.utils.translation import gettext_lazy as _
 
-import magic
 from rest_framework import exceptions, serializers
 
-from core import enums, models
-from core.services.ai_services import AI_ACTIONS
-from core.services.converter_services import (
-    ConversionError,
-    YdocConverter,
-)
+from core import models
 
 
 class UserSerializer(serializers.ModelSerializer):
@@ -23,8 +12,8 @@ class UserSerializer(serializers.ModelSerializer):
 
     class Meta:
         model = models.User
-        fields = ["id", "email", "full_name", "short_name"]
-        read_only_fields = ["id", "email", "full_name", "short_name"]
+        fields = ["id", "email"]
+        read_only_fields = ["id", "email"]
 
 
 class BaseAccessSerializer(serializers.ModelSerializer):
@@ -73,10 +62,10 @@ class BaseAccessSerializer(serializers.ModelSerializer):
                     "You must set a resource ID in kwargs to create a new access."
                 ) from exc
 
+            teams = user.get_teams()
             if not self.Meta.model.objects.filter(  # pylint: disable=no-member
-                Q(user=user) | Q(team__in=user.teams),
+                Q(user=user) | Q(team__in=teams),
                 role__in=[models.RoleChoices.OWNER, models.RoleChoices.ADMIN],
-                **{self.Meta.resource_field_name: resource_id},  # pylint: disable=no-member
             ).exists():
                 raise exceptions.PermissionDenied(
                     "You are not allowed to manage accesses for this resource."
@@ -85,7 +74,7 @@ class BaseAccessSerializer(serializers.ModelSerializer):
             if (
                 role == models.RoleChoices.OWNER
                 and not self.Meta.model.objects.filter(  # pylint: disable=no-member
-                    Q(user=user) | Q(team__in=user.teams),
+                    Q(user=user) | Q(team__in=teams),
                     role=models.RoleChoices.OWNER,
                     **{self.Meta.resource_field_name: resource_id},  # pylint: disable=no-member
                 ).exists()
@@ -142,252 +131,25 @@ class BaseResourceSerializer(serializers.ModelSerializer):
         return {}
 
 
-class ListDocumentSerializer(BaseResourceSerializer):
-    """Serialize documents with limited fields for display in lists."""
-
-    is_favorite = serializers.BooleanField(read_only=True)
-    nb_accesses = serializers.IntegerField(read_only=True)
-
-    class Meta:
-        model = models.Document
-        fields = [
-            "id",
-            "abilities",
-            "content",
-            "created_at",
-            "creator",
-            "is_favorite",
-            "link_role",
-            "link_reach",
-            "nb_accesses",
-            "title",
-            "updated_at",
-        ]
-        read_only_fields = [
-            "id",
-            "abilities",
-            "created_at",
-            "creator",
-            "is_favorite",
-            "link_role",
-            "link_reach",
-            "nb_accesses",
-            "updated_at",
-        ]
-
-
-class DocumentSerializer(ListDocumentSerializer):
-    """Serialize documents with all fields for display in detail views."""
+class DocumentSerializer(BaseResourceSerializer):
+    """Serialize documents."""
 
     content = serializers.CharField(required=False)
+    accesses = DocumentAccessSerializer(many=True, read_only=True)
 
     class Meta:
         model = models.Document
         fields = [
             "id",
-            "abilities",
             "content",
-            "created_at",
-            "creator",
-            "is_favorite",
-            "link_role",
-            "link_reach",
-            "nb_accesses",
             "title",
-            "updated_at",
-        ]
-        read_only_fields = [
-            "id",
+            "accesses",
             "abilities",
+            "is_public",
             "created_at",
-            "creator",
-            "is_avorite",
-            "link_role",
-            "link_reach",
-            "nb_accesses",
             "updated_at",
         ]
-
-    def get_fields(self):
-        """Dynamically make `id` read-only on PUT requests but writable on POST requests."""
-        fields = super().get_fields()
-
-        request = self.context.get("request")
-        if request and request.method == "POST":
-            fields["id"].read_only = False
-
-        return fields
-
-    def validate_id(self, value):
-        """Ensure the provided ID does not already exist when creating a new document."""
-        request = self.context.get("request")
-
-        # Only check this on POST (creation)
-        if request and request.method == "POST":
-            if models.Document.objects.filter(id=value).exists():
-                raise serializers.ValidationError(
-                    "A document with this ID already exists. You cannot override it."
-                )
-
-        return value
-
-
-class ServerCreateDocumentSerializer(serializers.Serializer):
-    """
-    Serializer for creating a document from a server-to-server request.
-
-    Expects 'content' as a markdown string, which is converted to our internal format
-    via a Node.js microservice. The conversion is handled automatically, so third parties
-    only need to provide markdown.
-
-    Both "sub" and "email" are required because the external app calling doesn't know
-    if the user will pre-exist in Docs database. If the user pre-exist, we will ignore the
-    submitted "email" field and use the email address set on the user account in our database
-    """
-
-    # Document
-    title = serializers.CharField(required=True)
-    content = serializers.CharField(required=True)
-    # User
-    sub = serializers.CharField(
-        required=True, validators=[models.User.sub_validator], max_length=255
-    )
-    email = serializers.EmailField(required=True)
-    language = serializers.ChoiceField(
-        required=False, choices=lazy(lambda: settings.LANGUAGES, tuple)()
-    )
-    # Invitation
-    message = serializers.CharField(required=False)
-    subject = serializers.CharField(required=False)
-
-    def create(self, validated_data):
-        """Create the document and associate it with the user or send an invitation."""
-        language = validated_data.get("language", settings.LANGUAGE_CODE)
-
-        # Get the user based on the sub (unique identifier)
-        try:
-            user = models.User.objects.get(sub=validated_data["sub"])
-        except (models.User.DoesNotExist, KeyError):
-            user = None
-            email = validated_data["email"]
-        else:
-            email = user.email
-            language = user.language or language
-
-        try:
-            document_content = YdocConverter().convert_markdown(
-                validated_data["content"]
-            )
-        except ConversionError as err:
-            raise exceptions.APIException(detail="could not convert content") from err
-
-        document = models.Document.objects.create(
-            title=validated_data["title"],
-            content=document_content,
-            creator=user,
-        )
-
-        if user:
-            # Associate the document with the pre-existing user
-            models.DocumentAccess.objects.create(
-                document=document,
-                role=models.RoleChoices.OWNER,
-                user=user,
-            )
-        else:
-            # The user doesn't exist in our database: we need to invite him/her
-            models.Invitation.objects.create(
-                document=document,
-                email=email,
-                role=models.RoleChoices.OWNER,
-            )
-
-        # Notify the user about the newly created document
-        subject = validated_data.get("subject") or _(
-            "A new document was created on your behalf!"
-        )
-        context = {
-            "message": validated_data.get("message")
-            or _("You have been granted ownership of a new document:"),
-            "title": subject,
-        }
-        document.send_email(subject, [email], context, language)
-
-        return document
-
-    def update(self, instance, validated_data):
-        """
-        This serializer does not support updates.
-        """
-        raise NotImplementedError("Update is not supported for this serializer.")
-
-
-class LinkDocumentSerializer(BaseResourceSerializer):
-    """
-    Serialize link configuration for documents.
-    We expose it separately from document in order to simplify and secure access control.
-    """
-
-    class Meta:
-        model = models.Document
-        fields = [
-            "link_role",
-            "link_reach",
-        ]
-
-
-# Suppress the warning about not implementing `create` and `update` methods
-# since we don't use a model and only rely on the serializer for validation
-# pylint: disable=abstract-method
-class FileUploadSerializer(serializers.Serializer):
-    """Receive file upload requests."""
-
-    file = serializers.FileField()
-
-    def validate_file(self, file):
-        """Add file size and type constraints as defined in settings."""
-        # Validate file size
-        if file.size > settings.DOCUMENT_IMAGE_MAX_SIZE:
-            max_size = settings.DOCUMENT_IMAGE_MAX_SIZE // (1024 * 1024)
-            raise serializers.ValidationError(
-                f"File size exceeds the maximum limit of {max_size:d} MB."
-            )
-
-        extension = file.name.rpartition(".")[-1] if "." in file.name else None
-
-        # Read the first few bytes to determine the MIME type accurately
-        mime = magic.Magic(mime=True)
-        magic_mime_type = mime.from_buffer(file.read(1024))
-        file.seek(0)  # Reset file pointer to the beginning after reading
-
-        self.context["is_unsafe"] = (
-            magic_mime_type in settings.DOCUMENT_UNSAFE_MIME_TYPES
-        )
-
-        extension_mime_type, _ = mimetypes.guess_type(file.name)
-
-        # Try guessing a coherent extension from the mimetype
-        if extension_mime_type != magic_mime_type:
-            self.context["is_unsafe"] = True
-
-        guessed_ext = mimetypes.guess_extension(magic_mime_type)
-        # Missing extensions or extensions longer than 5 characters (it's as long as an extension
-        # can be) are replaced by the extension we eventually guessed from mimetype.
-        if (extension is None or len(extension) > 5) and guessed_ext:
-            extension = guessed_ext[1:]
-
-        if extension is None:
-            raise serializers.ValidationError("Could not determine file extension.")
-
-        self.context["expected_extension"] = extension
-
-        return file
-
-    def validate(self, attrs):
-        """Override validate to add the computed extension to validated_data."""
-        attrs["expected_extension"] = self.context["expected_extension"]
-        attrs["is_unsafe"] = self.context["is_unsafe"]
-        return attrs
+        read_only_fields = ["id", "accesses", "abilities", "created_at", "updated_at"]
 
 
 class TemplateSerializer(BaseResourceSerializer):
@@ -418,12 +180,6 @@ class DocumentGenerationSerializer(serializers.Serializer):
         required=False,
         default="html",
     )
-    format = serializers.ChoiceField(
-        choices=["pdf", "docx"],
-        label=_("Format"),
-        required=False,
-        default="pdf",
-    )
 
 
 class InvitationSerializer(serializers.ModelSerializer):
@@ -460,72 +216,46 @@ class InvitationSerializer(serializers.ModelSerializer):
         return {}
 
     def validate(self, attrs):
-        """Validate invitation data."""
+        """Validate and restrict invitation to new user based on email."""
+
         request = self.context.get("request")
         user = getattr(request, "user", None)
+        role = attrs.get("role")
 
-        attrs["document_id"] = self.context["resource_id"]
+        try:
+            document_id = self.context["resource_id"]
+        except KeyError as exc:
+            raise exceptions.ValidationError(
+                "You must set a document ID in kwargs to create a new document invitation."
+            ) from exc
 
-        # Only set the issuer if the instance is being created
-        if self.instance is None:
-            attrs["issuer"] = user
+        if not user and user.is_authenticated:
+            raise exceptions.PermissionDenied(
+                "Anonymous users are not allowed to create invitations."
+            )
 
-        return attrs
+        teams = user.get_teams()
+        if not models.DocumentAccess.objects.filter(
+            Q(user=user) | Q(team__in=teams),
+            document=document_id,
+            role__in=[models.RoleChoices.OWNER, models.RoleChoices.ADMIN],
+        ).exists():
+            raise exceptions.PermissionDenied(
+                "You are not allowed to manage invitations for this document."
+            )
 
-    def validate_role(self, role):
-        """Custom validation for the role field."""
-        request = self.context.get("request")
-        user = getattr(request, "user", None)
-        document_id = self.context["resource_id"]
-
-        # If the role is OWNER, check if the user has OWNER access
-        if role == models.RoleChoices.OWNER:
-            if not models.DocumentAccess.objects.filter(
-                Q(user=user) | Q(team__in=user.teams),
+        if (
+            role == models.RoleChoices.OWNER
+            and not models.DocumentAccess.objects.filter(
+                Q(user=user) | Q(team__in=teams),
                 document=document_id,
                 role=models.RoleChoices.OWNER,
-            ).exists():
-                raise serializers.ValidationError(
-                    "Only owners of a document can invite other users as owners."
-                )
+            ).exists()
+        ):
+            raise exceptions.PermissionDenied(
+                "Only owners of a document can invite other users as owners."
+            )
 
-        return role
-
-
-class VersionFilterSerializer(serializers.Serializer):
-    """Validate version filters applied to the list endpoint."""
-
-    version_id = serializers.CharField(required=False, allow_blank=True)
-    page_size = serializers.IntegerField(
-        required=False, min_value=1, max_value=50, default=20
-    )
-
-
-class AITransformSerializer(serializers.Serializer):
-    """Serializer for AI transform requests."""
-
-    action = serializers.ChoiceField(choices=AI_ACTIONS, required=True)
-    text = serializers.CharField(required=True)
-
-    def validate_text(self, value):
-        """Ensure the text field is not empty."""
-
-        if len(value.strip()) == 0:
-            raise serializers.ValidationError("Text field cannot be empty.")
-        return value
-
-
-class AITranslateSerializer(serializers.Serializer):
-    """Serializer for AI translate requests."""
-
-    language = serializers.ChoiceField(
-        choices=tuple(enums.ALL_LANGUAGES.items()), required=True
-    )
-    text = serializers.CharField(required=True)
-
-    def validate_text(self, value):
-        """Ensure the text field is not empty."""
-
-        if len(value.strip()) == 0:
-            raise serializers.ValidationError("Text field cannot be empty.")
-        return value
+        attrs["document_id"] = document_id
+        attrs["issuer"] = user
+        return attrs

src/backend/core/api/utils.py

@@ -1,129 +0,0 @@
-"""Util to generate S3 authorization headers for object storage access control"""
-
-import time
-from abc import ABC, abstractmethod
-
-from django.conf import settings
-from django.core.cache import cache
-from django.core.files.storage import default_storage
-
-import botocore
-from rest_framework.throttling import BaseThrottle
-
-
-def generate_s3_authorization_headers(key):
-    """
-    Generate authorization headers for an s3 object.
-    These headers can be used as an alternative to signed urls with many benefits:
-    - the urls of our files never expire and can be stored in our documents' content
-    - we don't leak authorized urls that could be shared (file access can only be done
-      with cookies)
-    - access control is truly realtime
-    - the object storage service does not need to be exposed on internet
-    """
-    url = default_storage.unsigned_connection.meta.client.generate_presigned_url(
-        "get_object",
-        ExpiresIn=0,
-        Params={"Bucket": default_storage.bucket_name, "Key": key},
-    )
-    request = botocore.awsrequest.AWSRequest(method="get", url=url)
-
-    s3_client = default_storage.connection.meta.client
-    # pylint: disable=protected-access
-    credentials = s3_client._request_signer._credentials  # noqa: SLF001
-    frozen_credentials = credentials.get_frozen_credentials()
-    region = s3_client.meta.region_name
-    auth = botocore.auth.S3SigV4Auth(frozen_credentials, "s3", region)
-    auth.add_auth(request)
-
-    return request
-
-
-class AIBaseRateThrottle(BaseThrottle, ABC):
-    """Base throttle class for AI-related rate limiting with backoff."""
-
-    def __init__(self, rates):
-        """Initialize instance attributes with configurable rates."""
-        super().__init__()
-        self.rates = rates
-        self.cache_key = None
-        self.recent_requests_minute = 0
-        self.recent_requests_hour = 0
-        self.recent_requests_day = 0
-
-    @abstractmethod
-    def get_cache_key(self, request, view):
-        """Abstract method to generate cache key for throttling."""
-
-    def allow_request(self, request, view):
-        """Check if the request is allowed based on rate limits."""
-        self.cache_key = self.get_cache_key(request, view)
-        if not self.cache_key:
-            return True  # Allow if no cache key is generated
-
-        now = time.time()
-        history = cache.get(self.cache_key, [])
-        # Keep requests within the last 24 hours
-        history = [req for req in history if req > now - 86400]
-
-        # Calculate recent requests
-        self.recent_requests_minute = len([req for req in history if req > now - 60])
-        self.recent_requests_hour = len([req for req in history if req > now - 3600])
-        self.recent_requests_day = len(history)
-
-        # Check rate limits
-        if self.recent_requests_minute >= self.rates["minute"]:
-            return False
-        if self.recent_requests_hour >= self.rates["hour"]:
-            return False
-        if self.recent_requests_day >= self.rates["day"]:
-            return False
-
-        # Log the request
-        history.append(now)
-        cache.set(self.cache_key, history, timeout=86400)
-        return True
-
-    def wait(self):
-        """Implement a backoff strategy by increasing wait time based on limits hit."""
-        if self.recent_requests_day >= self.rates["day"]:
-            return 86400
-        if self.recent_requests_hour >= self.rates["hour"]:
-            return 3600
-        if self.recent_requests_minute >= self.rates["minute"]:
-            return 60
-        return None
-
-
-class AIDocumentRateThrottle(AIBaseRateThrottle):
-    """Throttle for limiting AI requests per document with backoff."""
-
-    def __init__(self, *args, **kwargs):
-        super().__init__(settings.AI_DOCUMENT_RATE_THROTTLE_RATES)
-
-    def get_cache_key(self, request, view):
-        """Include document ID in the cache key."""
-        document_id = view.kwargs["pk"]
-        return f"document_{document_id}_throttle_ai"
-
-
-class AIUserRateThrottle(AIBaseRateThrottle):
-    """Throttle that limits requests per user or IP with backoff and rate limits."""
-
-    def __init__(self, *args, **kwargs):
-        super().__init__(settings.AI_USER_RATE_THROTTLE_RATES)
-
-    def get_cache_key(self, request, view=None):
-        """Generate a cache key based on the user ID or IP for anonymous users."""
-        if request.user.is_authenticated:
-            return f"user_{request.user.id!s}_throttle_ai"
-        return f"anonymous_{self.get_ident(request)}_throttle_ai"
-
-    def get_ident(self, request):
-        """Return the request IP address."""
-        x_forwarded_for = request.META.get("HTTP_X_FORWARDED_FOR")
-        return (
-            x_forwarded_for.split(",")[0]
-            if x_forwarded_for
-            else request.META.get("REMOTE_ADDR")
-        )

src/backend/core/authentication/__init__.py

@@ -1,52 +0,0 @@
-"""Custom authentication classes for the Impress core app"""
-
-from django.conf import settings
-
-from rest_framework.authentication import BaseAuthentication
-from rest_framework.exceptions import AuthenticationFailed
-
-
-class ServerToServerAuthentication(BaseAuthentication):
-    """
-    Custom authentication class for server-to-server requests.
-    Validates the presence and correctness of the Authorization header.
-    """
-
-    AUTH_HEADER = "Authorization"
-    TOKEN_TYPE = "Bearer"  # noqa S105
-
-    def authenticate(self, request):
-        """
-        Authenticate the server-to-server request by validating the Authorization header.
-
-        This method checks if the Authorization header is present in the request, ensures it
-        contains a valid token with the correct format, and verifies the token against the
-        list of allowed server-to-server tokens. If the header is missing, improperly formatted,
-        or contains an invalid token, an AuthenticationFailed exception is raised.
-
-        Returns:
-            None: If authentication is successful
-                  (no user is authenticated for server-to-server requests).
-
-        Raises:
-            AuthenticationFailed: If the Authorization header is missing, malformed,
-            or contains an invalid token.
-        """
-        auth_header = request.headers.get(self.AUTH_HEADER)
-        if not auth_header:
-            raise AuthenticationFailed("Authorization header is missing.")
-
-        # Validate token format and existence
-        auth_parts = auth_header.split(" ")
-        if len(auth_parts) != 2 or auth_parts[0] != self.TOKEN_TYPE:
-            raise AuthenticationFailed("Invalid authorization header.")
-
-        token = auth_parts[1]
-        if token not in settings.SERVER_TO_SERVER_API_TOKENS:
-            raise AuthenticationFailed("Invalid server-to-server token.")
-
-        # Authentication is successful, but no user is authenticated
-
-    def authenticate_header(self, request):
-        """Return the WWW-Authenticate header value."""
-        return f"{self.TOKEN_TYPE} realm='Create document server to server'"

src/backend/core/authentication/backends.py

@@ -1,6 +1,5 @@
 """Authentication Backends for the Impress core app."""
 
-from django.conf import settings
 from django.core.exceptions import SuspiciousOperation
 from django.utils.translation import gettext_lazy as _
 
@@ -46,77 +45,56 @@ class OIDCAuthenticationBackend(MozillaOIDCAuthenticationBackend):
             proxies=self.get_settings("OIDC_PROXY", None),
         )
         user_response.raise_for_status()
-
-        try:
-            userinfo = user_response.json()
-        except ValueError:
-            try:
-                userinfo = self.verify_token(user_response.text)
-            except Exception as e:
-                raise SuspiciousOperation(
-                    _("Invalid response format or token verification failed")
-                ) from e
-
+        userinfo = self.verify_token(user_response.text)
         return userinfo
 
     def get_or_create_user(self, access_token, id_token, payload):
-        """Return a User based on userinfo. Create a new user if no match is found."""
+        """Return a User based on userinfo. Get or create a new user if no user matches the Sub.
+
+        Parameters:
+        - access_token (str): The access token.
+        - id_token (str): The ID token.
+        - payload (dict): The user payload.
+
+        Returns:
+        - User: An existing or newly created User instance.
+
+        Raises:
+        - Exception: Raised when user creation is not allowed and no existing user is found.
+        """
 
         user_info = self.get_userinfo(access_token, id_token, payload)
-        email = user_info.get("email")
-
-        # Get user's full name from OIDC fields defined in settings
-        full_name = self.compute_full_name(user_info)
-        short_name = user_info.get(settings.USER_OIDC_FIELD_TO_SHORTNAME)
-
-        claims = {
-            "email": email,
-            "full_name": full_name,
-            "short_name": short_name,
-        }
-
         sub = user_info.get("sub")
-        if not sub:
+
+        if sub is None:
             raise SuspiciousOperation(
                 _("User info contained no recognizable user identification")
             )
 
-        user = self.get_existing_user(sub, email)
-
-        if user:
-            if not user.is_active:
-                raise SuspiciousOperation(_("User account is disabled"))
-            self.update_user_if_needed(user, claims)
-        elif self.get_settings("OIDC_CREATE_USER", True):
-            user = User.objects.create(sub=sub, password="!", **claims)  # noqa: S106
+        try:
+            user = User.objects.get(sub=sub)
+        except User.DoesNotExist:
+            if self.get_settings("OIDC_CREATE_USER", True):
+                user = self.create_user(user_info)
+            else:
+                user = None
 
         return user
 
-    def compute_full_name(self, user_info):
-        """Compute user's full name based on OIDC fields in settings."""
-        name_fields = settings.USER_OIDC_FIELDS_TO_FULLNAME
-        full_name = " ".join(
-            user_info[field] for field in name_fields if user_info.get(field)
-        )
-        return full_name or None
+    def create_user(self, claims):
+        """Return a newly created User instance."""
 
-    def get_existing_user(self, sub, email):
-        """Fetch existing user by sub or email."""
-        try:
-            return User.objects.get(sub=sub)
-        except User.DoesNotExist:
-            if email and settings.OIDC_FALLBACK_TO_EMAIL_FOR_IDENTIFICATION:
-                try:
-                    return User.objects.get(email=email)
-                except User.DoesNotExist:
-                    pass
-        return None
+        sub = claims.get("sub")
 
-    def update_user_if_needed(self, user, claims):
-        """Update user claims if they have changed."""
-        has_changed = any(
-            value and value != getattr(user, key) for key, value in claims.items()
+        if sub is None:
+            raise SuspiciousOperation(
+                _("Claims contained no recognizable user identification")
+            )
+
+        user = User.objects.create(
+            sub=sub,
+            email=claims.get("email"),
+            password="!",  # noqa: S106
         )
-        if has_changed:
-            updated_claims = {key: value for key, value in claims.items() if value}
-            self.UserModel.objects.filter(sub=user.sub).update(**updated_claims)
+
+        return user

src/backend/core/enums.py

@@ -1,12 +1,15 @@
 """
 Core application enums declaration
 """
-
-from django.conf import global_settings
+from django.conf import global_settings, settings
 from django.utils.translation import gettext_lazy as _
 
-# In Django's code base, `LANGUAGES` is set by default with all supported languages.
-# We can use it for the choice of languages which should not be limited to the few languages
-# active in the app.
+# Django sets `LANGUAGES` by default with all supported languages. We can use it for
+# the choice of languages which should not be limited to the few languages active in
+# the app.
 # pylint: disable=no-member
-ALL_LANGUAGES = {language: _(name) for language, name in global_settings.LANGUAGES}
+ALL_LANGUAGES = getattr(
+    settings,
+    "ALL_LANGUAGES",
+    [(language, _(name)) for language, name in global_settings.LANGUAGES],
+)

src/backend/core/factories.py

@@ -2,7 +2,6 @@
 """
 Core application factories
 """
-
 from django.conf import settings
 from django.contrib.auth.hashers import make_password
 
@@ -22,29 +21,9 @@ class UserFactory(factory.django.DjangoModelFactory):
 
     sub = factory.Sequence(lambda n: f"user{n!s}")
     email = factory.Faker("email")
-    full_name = factory.Faker("name")
-    short_name = factory.Faker("first_name")
     language = factory.fuzzy.FuzzyChoice([lang[0] for lang in settings.LANGUAGES])
     password = make_password("password")
 
-    @factory.post_generation
-    def with_owned_document(self, create, extracted, **kwargs):
-        """
-        Create a document for which the user is owner to check
-        that there is no interference
-        """
-        if create and (extracted is True):
-            UserDocumentAccessFactory(user=self, role="owner")
-
-    @factory.post_generation
-    def with_owned_template(self, create, extracted, **kwargs):
-        """
-        Create a template for which the user is owner to check
-        that there is no interference
-        """
-        if create and (extracted is True):
-            UserTemplateAccessFactory(user=self, role="owner")
-
 
 class DocumentFactory(factory.django.DjangoModelFactory):
     """A factory to create documents"""
@@ -55,14 +34,8 @@ class DocumentFactory(factory.django.DjangoModelFactory):
         skip_postgeneration_save = True
 
     title = factory.Sequence(lambda n: f"document{n}")
+    is_public = factory.Faker("boolean")
     content = factory.Sequence(lambda n: f"content{n}")
-    creator = factory.SubFactory(UserFactory)
-    link_reach = factory.fuzzy.FuzzyChoice(
-        [a[0] for a in models.LinkReachChoices.choices]
-    )
-    link_role = factory.fuzzy.FuzzyChoice(
-        [r[0] for r in models.LinkRoleChoices.choices]
-    )
 
     @factory.post_generation
     def users(self, create, extracted, **kwargs):
@@ -74,20 +47,6 @@ class DocumentFactory(factory.django.DjangoModelFactory):
                 else:
                     UserDocumentAccessFactory(document=self, user=item[0], role=item[1])
 
-    @factory.post_generation
-    def link_traces(self, create, extracted, **kwargs):
-        """Add link traces to document from a given list of users."""
-        if create and extracted:
-            for item in extracted:
-                models.LinkTrace.objects.create(document=self, user=item)
-
-    @factory.post_generation
-    def favorited_by(self, create, extracted, **kwargs):
-        """Mark document as favorited by a list of users."""
-        if create and extracted:
-            for item in extracted:
-                models.DocumentFavorite.objects.create(document=self, user=item)
-
 
 class UserDocumentAccessFactory(factory.django.DjangoModelFactory):
     """Create fake document user accesses for testing."""

src/backend/core/migrations/0003_document_link_reach_document_link_role_and_more.py

@@ -1,52 +0,0 @@
-# Generated by Django 5.1 on 2024-09-08 16:55
-
-import django.db.models.deletion
-import uuid
-from django.conf import settings
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0002_create_pg_trgm_extension'),
-    ]
-
-    operations = [
-        migrations.AddField(
-            model_name='document',
-            name='link_reach',
-            field=models.CharField(choices=[('restricted', 'Restricted'), ('authenticated', 'Authenticated'), ('public', 'Public')], default='authenticated', max_length=20),
-        ),
-        migrations.AddField(
-            model_name='document',
-            name='link_role',
-            field=models.CharField(choices=[('reader', 'Reader'), ('editor', 'Editor')], default='reader', max_length=20),
-        ),
-        migrations.AlterField(
-            model_name='document',
-            name='is_public',
-            field=models.BooleanField(null=True),
-        ),
-        migrations.AlterField(
-            model_name='user',
-            name='language',
-            field=models.CharField(choices="(('en-us', 'English'), ('fr-fr', 'French'))", default='en-us', help_text='The language in which the user wants to see the interface.', max_length=10, verbose_name='language'),
-        ),
-        migrations.CreateModel(
-            name='LinkTrace',
-            fields=[
-                ('id', models.UUIDField(default=uuid.uuid4, editable=False, help_text='primary key for the record as UUID', primary_key=True, serialize=False, verbose_name='id')),
-                ('created_at', models.DateTimeField(auto_now_add=True, help_text='date and time at which a record was created', verbose_name='created on')),
-                ('updated_at', models.DateTimeField(auto_now=True, help_text='date and time at which a record was last updated', verbose_name='updated on')),
-                ('document', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='link_traces', to='core.document')),
-                ('user', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='link_traces', to=settings.AUTH_USER_MODEL)),
-            ],
-            options={
-                'verbose_name': 'Document/user link trace',
-                'verbose_name_plural': 'Document/user link traces',
-                'db_table': 'impress_link_trace',
-                'constraints': [models.UniqueConstraint(fields=('user', 'document'), name='unique_link_trace_document_user', violation_error_message='A link trace already exists for this document/user.')],
-            },
-        ),
-    ]

src/backend/core/migrations/0004_migrate_is_public_to_link_reach.py

@@ -1,35 +0,0 @@
-# Generated by Django 5.1 on 2024-09-08 17:04
-from django.db import migrations
-
-def migrate_is_public_to_link_reach(apps, schema_editor):
-    """
-    Forward migration: Migrate 'is_public' to 'link_reach'.
-    If is_public == True, set link_reach to 'public'
-    """
-    Document = apps.get_model('core', 'Document')
-    Document.objects.filter(is_public=True).update(link_reach='public')
-
-
-def reverse_migrate_link_reach_to_is_public(apps, schema_editor):
-    """
-    Reverse migration: Migrate 'link_reach' back to 'is_public'.
-    - If link_reach == 'public', set is_public to True
-    - Else set is_public to False
-    """
-    Document = apps.get_model('core', 'Document')
-    Document.objects.filter(link_reach='public').update(is_public=True)
-    Document.objects.filter(link_reach__in=['restricted', "authenticated"]).update(is_public=False)
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0003_document_link_reach_document_link_role_and_more'),
-    ]
-
-    operations = [
-        migrations.RunPython(
-            migrate_is_public_to_link_reach, 
-            reverse_migrate_link_reach_to_is_public
-        ),
-    ]

src/backend/core/migrations/0005_remove_document_is_public_alter_document_link_reach_and_more.py

@@ -1,18 +0,0 @@
-# Generated by Django 5.1 on 2024-09-09 17:49
-
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0004_migrate_is_public_to_link_reach'),
-    ]
-
-    operations = [
-        migrations.AlterField(
-            model_name='document',
-            name='title',
-            field=models.CharField(blank=True, max_length=255, null=True, verbose_name='title'),
-        ),
-    ]

src/backend/core/migrations/0006_add_user_full_name_and_short_name.py

@@ -1,28 +0,0 @@
-# Generated by Django 5.1.1 on 2024-09-29 03:47
-
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0005_remove_document_is_public_alter_document_link_reach_and_more'),
-    ]
-
-    operations = [
-        migrations.AddField(
-            model_name='user',
-            name='full_name',
-            field=models.CharField(blank=True, max_length=100, null=True, verbose_name='full name'),
-        ),
-        migrations.AddField(
-            model_name='user',
-            name='short_name',
-            field=models.CharField(blank=True, max_length=20, null=True, verbose_name='short name'),
-        ),
-        migrations.AlterField(
-            model_name='user',
-            name='language',
-            field=models.CharField(choices="(('en-us', 'English'), ('fr-fr', 'French'))", default='en-us', help_text='The language in which the user wants to see the interface.', max_length=10, verbose_name='language'),
-        ),
-    ]

src/backend/core/migrations/0007_fix_users_duplicate.py

@@ -1,128 +0,0 @@
-# Generated by Django 5.1.1 on 2024-10-10 11:45
-
-from django.db import migrations
-
-procedure = """
-DO $$
-DECLARE
-    user_email TEXT;
-BEGIN
-    -- Step 1: Create a temporary table (without the unique constraint)
-    -- impress_document_access
-    DROP TABLE IF EXISTS impress_document_access_tmp;
-    CREATE TEMP TABLE impress_document_access_tmp AS
-    SELECT * FROM impress_document_access;
-    
-    -- impress_link_trace
-    DROP TABLE IF EXISTS impress_link_trace_tmp;
-    CREATE TEMP TABLE impress_link_trace_tmp AS
-    SELECT * FROM impress_link_trace;
-
-    -- Step 2: Loop through each email that appears more than once
-    FOR user_email IN
-      SELECT email
-      FROM impress_user
-      GROUP BY email
-      HAVING COUNT(email) > 1
-    LOOP
-      -- Step 3: Update user_id in the temporary table based on email
-      -- For impress_document_access
-      UPDATE impress_document_access_tmp
-      SET user_id = (
-        SELECT id
-        FROM impress_user
-        WHERE email = user_email
-        LIMIT 1
-      )
-      WHERE user_id IN (
-        SELECT id
-        FROM impress_user
-        WHERE email = user_email
-      );
-
-      -- For impress_link_trace
-      UPDATE impress_link_trace_tmp
-      SET user_id = (
-        SELECT id
-        FROM impress_user
-        WHERE email = user_email
-        LIMIT 1
-      )
-      WHERE user_id IN (
-        SELECT id
-        FROM impress_user
-        WHERE email = user_email
-      );
-      
-      -- update impress_invitation
-      UPDATE impress_invitation
-      SET issuer_id = (
-        SELECT id
-        FROM impress_user
-        WHERE email = user_email
-        LIMIT 1
-      )
-      WHERE issuer_id IN (
-        SELECT id
-        FROM impress_user
-        WHERE email = user_email
-      );
-      
-      DELETE FROM impress_user
-      WHERE id IN (
-        SELECT id
-        FROM impress_user
-        WHERE email = user_email
-      )
-      AND id != (
-        SELECT id
-        FROM impress_user
-        WHERE email = user_email
-        LIMIT 1
-      );
-
-      RAISE NOTICE 'Processed updates for email: %', user_email;
-    END LOOP;
-		
-    -- Step 4: Remove duplicate rows from the temporary table, keeping only one row per (document_id, user_id)
-    -- For impress_document_access
-    DELETE FROM impress_document_access_tmp a
-    USING impress_document_access_tmp b
-    WHERE a.ctid < b.ctid  -- Keep one row
-    AND a.document_id = b.document_id
-    AND a.user_id = b.user_id;
-
-    -- Step 5: Replace the original table with the cleaned-up temporary table
-    TRUNCATE TABLE impress_document_access;
-
-    -- Insert cleaned-up data back into the original table
-    INSERT INTO impress_document_access
-    SELECT * FROM impress_document_access_tmp;
-    
-    -- For impress_link_trace
-    DELETE FROM impress_link_trace_tmp a
-    USING impress_link_trace_tmp b
-    WHERE a.ctid < b.ctid  -- Keep one row
-    AND a.document_id = b.document_id
-    AND a.user_id = b.user_id;
-
-    -- Step 5: Replace the original table with the cleaned-up temporary table
-    TRUNCATE TABLE impress_link_trace;
-
-    -- Insert cleaned-up data back into the original table
-    INSERT INTO impress_link_trace
-    SELECT * FROM impress_link_trace_tmp;
-		
-    RAISE NOTICE 'Update and deduplication process completed.';
-END $$;
-"""
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0006_add_user_full_name_and_short_name'),
-    ]
-
-    operations = [
-        migrations.RunSQL(procedure),
-    ]

src/backend/core/migrations/0008_alter_document_link_reach.py

@@ -1,18 +0,0 @@
-# Generated by Django 5.1.2 on 2024-10-25 11:41
-
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0007_fix_users_duplicate'),
-    ]
-
-    operations = [
-        migrations.AlterField(
-            model_name='document',
-            name='link_reach',
-            field=models.CharField(choices=[('restricted', 'Restricted'), ('authenticated', 'Authenticated'), ('public', 'Public')], default='restricted', max_length=20),
-        ),
-    ]

src/backend/core/migrations/0009_add_document_favorite.py

@@ -1,37 +0,0 @@
-# Generated by Django 5.1.2 on 2024-11-08 07:59
-
-import django.db.models.deletion
-import uuid
-from django.conf import settings
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0008_alter_document_link_reach'),
-    ]
-
-    operations = [
-        migrations.AlterField(
-            model_name='user',
-            name='language',
-            field=models.CharField(choices="(('en-us', 'English'), ('fr-fr', 'French'), ('de-de', 'German'))", default='en-us', help_text='The language in which the user wants to see the interface.', max_length=10, verbose_name='language'),
-        ),
-        migrations.CreateModel(
-            name='DocumentFavorite',
-            fields=[
-                ('id', models.UUIDField(default=uuid.uuid4, editable=False, help_text='primary key for the record as UUID', primary_key=True, serialize=False, verbose_name='id')),
-                ('created_at', models.DateTimeField(auto_now_add=True, help_text='date and time at which a record was created', verbose_name='created on')),
-                ('updated_at', models.DateTimeField(auto_now=True, help_text='date and time at which a record was last updated', verbose_name='updated on')),
-                ('document', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='favorited_by_users', to='core.document')),
-                ('user', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='favorite_documents', to=settings.AUTH_USER_MODEL)),
-            ],
-            options={
-                'verbose_name': 'Document favorite',
-                'verbose_name_plural': 'Document favorites',
-                'db_table': 'impress_document_favorite',
-                'constraints': [models.UniqueConstraint(fields=('user', 'document'), name='unique_document_favorite_user', violation_error_message='This document is already targeted by a favorite relation instance for the same user.')],
-            },
-        ),
-    ]

src/backend/core/migrations/0010_add_field_creator_to_document.py

@@ -1,31 +0,0 @@
-# Generated by Django 5.1.2 on 2024-11-09 11:36
-
-import django.core.validators
-import django.db.models.deletion
-from django.conf import settings
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0009_add_document_favorite'),
-    ]
-
-    operations = [
-        migrations.AddField(
-            model_name='document',
-            name='creator',
-            field=models.ForeignKey(null=True, on_delete=django.db.models.deletion.RESTRICT, related_name='documents_created', to=settings.AUTH_USER_MODEL),
-        ),
-        migrations.AlterField(
-            model_name='user',
-            name='language',
-            field=models.CharField(choices="(('en-us', 'English'), ('fr-fr', 'French'), ('de-de', 'German'))", default='en-us', help_text='The language in which the user wants to see the interface.', max_length=10, verbose_name='language'),
-        ),
-        migrations.AlterField(
-            model_name='user',
-            name='sub',
-            field=models.CharField(blank=True, help_text='Required. 255 characters or fewer. Letters, numbers, and @/./+/-/_/: characters only.', max_length=255, null=True, unique=True, validators=[django.core.validators.RegexValidator(message='Enter a valid sub. This value may contain only letters, numbers, and @/./+/-/_/: characters.', regex='^[\\w.@+-:]+\\Z')], verbose_name='sub'),
-        ),
-    ]

src/backend/core/migrations/0011_populate_creator_field_and_make_it_required.py

@@ -1,52 +0,0 @@
-# Generated by Django 5.1.2 on 2024-11-09 11:48
-
-import django.db.models.deletion
-from django.conf import settings
-from django.db import migrations
-from django.db.models import F, ForeignKey, Subquery, OuterRef, Q
-
-
-def set_creator_from_document_access(apps, schema_editor):
-    """
-    Populate the `creator` field for existing Document records.
-
-    This function assigns the `creator` field using the existing
-    DocumentAccess entries. We can be sure that all documents have at
-    least one user with "owner" role. If the document has several roles,
-    it should take the entry with the oldest date of creation.
-
-    The update is performed using efficient bulk queries with Django's
-    Subquery and OuterRef to minimize database hits and ensure performance.
-
-    Note: After running this migration, we quickly modify the schema to make
-    the `creator` field required.
-    """
-    Document = apps.get_model("core", "Document")
-    DocumentAccess = apps.get_model("core", "DocumentAccess")
-
-    # Update `creator` using the "owner" role
-    owner_subquery = DocumentAccess.objects.filter(
-        document=OuterRef('pk'),
-        user__isnull=False,
-        role='owner',
-    ).order_by('created_at').values('user_id')[:1]
-
-    Document.objects.filter(
-        creator__isnull=True
-    ).update(creator=Subquery(owner_subquery))
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0010_add_field_creator_to_document'),
-    ]
-
-    operations = [
-        migrations.RunPython(set_creator_from_document_access, reverse_code=migrations.RunPython.noop),
-        migrations.AlterField(
-            model_name='document',
-            name='creator',
-            field=ForeignKey(on_delete=django.db.models.deletion.RESTRICT, related_name='documents_created', to=settings.AUTH_USER_MODEL),
-        ),
-    ]

src/backend/core/migrations/0012_make_document_creator_and_invitation_issuer_optional.py

@@ -1,30 +0,0 @@
-# Generated by Django 5.1.2 on 2024-11-30 22:23
-
-import django.db.models.deletion
-from django.conf import settings
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0011_populate_creator_field_and_make_it_required'),
-    ]
-
-    operations = [
-        migrations.AlterField(
-            model_name='document',
-            name='creator',
-            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.RESTRICT, related_name='documents_created', to=settings.AUTH_USER_MODEL),
-        ),
-        migrations.AlterField(
-            model_name='invitation',
-            name='issuer',
-            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='invitations', to=settings.AUTH_USER_MODEL),
-        ),
-        migrations.AlterField(
-            model_name='user',
-            name='language',
-            field=models.CharField(choices="(('en-us', 'English'), ('fr-fr', 'French'), ('de-de', 'German'))", default='en-us', help_text='The language in which the user wants to see the interface.', max_length=10, verbose_name='language'),
-        ),
-    ]

src/backend/core/models.py

@@ -1,14 +1,11 @@
 """
 Declare and configure the models for the impress core application
 """
-
 import hashlib
 import smtplib
-import tempfile
 import textwrap
 import uuid
 from datetime import timedelta
-from io import BytesIO
 from logging import getLogger
 
 from django.conf import settings
@@ -18,53 +15,44 @@ from django.contrib.sites.models import Site
 from django.core import exceptions, mail, validators
 from django.core.files.base import ContentFile
 from django.core.files.storage import default_storage
-from django.core.mail import send_mail
 from django.db import models
-from django.http import FileResponse
 from django.template.base import Template as DjangoTemplate
 from django.template.context import Context
 from django.template.loader import render_to_string
 from django.utils import html, timezone
-from django.utils.functional import cached_property, lazy
-from django.utils.translation import get_language, override
+from django.utils.functional import lazy
 from django.utils.translation import gettext_lazy as _
+from django.utils.translation import override
 
 import frontmatter
 import markdown
-import pypandoc
-import weasyprint
 from botocore.exceptions import ClientError
 from timezone_field import TimeZoneField
+from weasyprint import CSS, HTML
+from weasyprint.text.fonts import FontConfiguration
 
 logger = getLogger(__name__)
 
 
 def get_resource_roles(resource, user):
     """Compute the roles a user has on a resource."""
-    if not user.is_authenticated:
-        return []
-
-    try:
-        roles = resource.user_roles or []
-    except AttributeError:
+    roles = []
+    if user.is_authenticated:
         try:
-            roles = resource.accesses.filter(
-                models.Q(user=user) | models.Q(team__in=user.teams),
-            ).values_list("role", flat=True)
-        except (models.ObjectDoesNotExist, IndexError):
-            roles = []
+            roles = resource.user_roles or []
+        except AttributeError:
+            teams = user.get_teams()
+            try:
+                roles = resource.accesses.filter(
+                    models.Q(user=user) | models.Q(team__in=teams),
+                ).values_list("role", flat=True)
+            except (models.ObjectDoesNotExist, IndexError):
+                roles = []
     return roles
 
 
-class LinkRoleChoices(models.TextChoices):
-    """Defines the possible roles a link can offer on a document."""
-
-    READER = "reader", _("Reader")  # Can read
-    EDITOR = "editor", _("Editor")  # Can read and edit
-
-
 class RoleChoices(models.TextChoices):
-    """Defines the possible roles a user can have in a resource."""
+    """Defines the possible roles a user can have in a template."""
 
     READER = "reader", _("Reader")  # Can read
     EDITOR = "editor", _("Editor")  # Can read and edit
@@ -72,23 +60,6 @@ class RoleChoices(models.TextChoices):
     OWNER = "owner", _("Owner")
 
 
-PRIVILEGED_ROLES = [RoleChoices.ADMIN, RoleChoices.OWNER]
-
-
-class LinkReachChoices(models.TextChoices):
-    """Defines types of access for links"""
-
-    RESTRICTED = (
-        "restricted",
-        _("Restricted"),
-    )  # Only users with a specific access can read/edit the document
-    AUTHENTICATED = (
-        "authenticated",
-        _("Authenticated"),
-    )  # Any authenticated user can access the document
-    PUBLIC = "public", _("Public")  # Even anonymous users can access the document
-
-
 class BaseModel(models.Model):
     """
     Serves as an abstract base model for other models, ensuring that records are validated
@@ -130,17 +101,17 @@ class User(AbstractBaseUser, BaseModel, auth_models.PermissionsMixin):
     """User model to work with OIDC only authentication."""
 
     sub_validator = validators.RegexValidator(
-        regex=r"^[\w.@+-:]+\Z",
+        regex=r"^[\w.@+-]+\Z",
         message=_(
             "Enter a valid sub. This value may contain only letters, "
-            "numbers, and @/./+/-/_/: characters."
+            "numbers, and @/./+/-/_ characters."
         ),
     )
 
     sub = models.CharField(
         _("sub"),
         help_text=_(
-            "Required. 255 characters or fewer. Letters, numbers, and @/./+/-/_/: characters only."
+            "Required. 255 characters or fewer. Letters, numbers, and @/./+/-/_ characters only."
         ),
         max_length=255,
         unique=True,
@@ -148,10 +119,6 @@ class User(AbstractBaseUser, BaseModel, auth_models.PermissionsMixin):
         blank=True,
         null=True,
     )
-
-    full_name = models.CharField(_("full name"), max_length=100, null=True, blank=True)
-    short_name = models.CharField(_("short name"), max_length=20, null=True, blank=True)
-
     email = models.EmailField(_("identity email address"), blank=True, null=True)
 
     # Unlike the "email" field which stores the email coming from the OIDC token, this field
@@ -239,13 +206,6 @@ class User(AbstractBaseUser, BaseModel, auth_models.PermissionsMixin):
                 for invitation in valid_invitations
             ]
         )
-
-        # Set creator of documents if not yet set (e.g. documents created via server-to-server API)
-        document_ids = [invitation.document_id for invitation in valid_invitations]
-        Document.objects.filter(id__in=document_ids, creator__isnull=True).update(
-            creator=self
-        )
-
         valid_invitations.delete()
 
     def email_user(self, subject, message, from_email=None, **kwargs):
@@ -254,8 +214,7 @@ class User(AbstractBaseUser, BaseModel, auth_models.PermissionsMixin):
             raise ValueError("User has no email address.")
         mail.send_mail(subject, message, from_email, [self.email], **kwargs)
 
-    @cached_property
-    def teams(self):
+    def get_teams(self):
         """
         Get list of teams in which the user is, as a list of strings.
         Must be cached if retrieved remotely.
@@ -287,7 +246,7 @@ class BaseAccess(BaseModel):
         """
         roles = []
         if user.is_authenticated:
-            teams = user.teams
+            teams = user.get_teams()
             try:
                 roles = self.user_roles or []
             except AttributeError:
@@ -339,21 +298,11 @@ class BaseAccess(BaseModel):
 class Document(BaseModel):
     """Pad document carrying the content."""
 
-    title = models.CharField(_("title"), max_length=255, null=True, blank=True)
-    link_reach = models.CharField(
-        max_length=20,
-        choices=LinkReachChoices.choices,
-        default=LinkReachChoices.RESTRICTED,
-    )
-    link_role = models.CharField(
-        max_length=20, choices=LinkRoleChoices.choices, default=LinkRoleChoices.READER
-    )
-    creator = models.ForeignKey(
-        User,
-        on_delete=models.RESTRICT,
-        related_name="documents_created",
-        blank=True,
-        null=True,
+    title = models.CharField(_("title"), max_length=255)
+    is_public = models.BooleanField(
+        _("public"),
+        default=False,
+        help_text=_("Whether this document is public for anyone to use."),
     )
 
     _content = None
@@ -365,37 +314,7 @@ class Document(BaseModel):
         verbose_name_plural = _("Documents")
 
     def __str__(self):
-        return str(self.title) if self.title else str(_("Untitled Document"))
-
-    def save(self, *args, **kwargs):
-        """Write content to object storage only if _content has changed."""
-        super().save(*args, **kwargs)
-
-        if self._content:
-            file_key = self.file_key
-            bytes_content = self._content.encode("utf-8")
-
-            # Attempt to directly check if the object exists using the storage client.
-            try:
-                response = default_storage.connection.meta.client.head_object(
-                    Bucket=default_storage.bucket_name, Key=file_key
-                )
-            except ClientError as excpt:
-                # If the error is a 404, the object doesn't exist, so we should create it.
-                if excpt.response["Error"]["Code"] == "404":
-                    has_changed = True
-                else:
-                    raise
-            else:
-                # Compare the existing ETag with the MD5 hash of the new content.
-                has_changed = (
-                    response["ETag"].strip('"')
-                    != hashlib.md5(bytes_content).hexdigest()  # noqa: S324
-                )
-
-            if has_changed:
-                content_file = ContentFile(bytes_content)
-                default_storage.save(file_key, content_file)
+        return self.title
 
     @property
     def key_base(self):
@@ -437,62 +356,95 @@ class Document(BaseModel):
             Bucket=default_storage.bucket_name, Key=self.file_key, VersionId=version_id
         )
 
-    def get_versions_slice(self, from_version_id="", min_datetime=None, page_size=None):
+    def save(self, *args, **kwargs):
+        """Write content to object storage only if _content has changed."""
+        super().save(*args, **kwargs)
+
+        if self._content:
+            file_key = self.file_key
+            bytes_content = self._content.encode("utf-8")
+
+            if default_storage.exists(file_key):
+                response = default_storage.connection.meta.client.head_object(
+                    Bucket=default_storage.bucket_name, Key=file_key
+                )
+                has_changed = (
+                    response["ETag"].strip('"')
+                    != hashlib.md5(bytes_content).hexdigest()  # noqa
+                )
+            else:
+                has_changed = True
+            if has_changed:
+                content_file = ContentFile(bytes_content)
+                default_storage.save(file_key, content_file)
+
+    def get_versions_slice(
+        self, from_version_id="", from_datetime=None, page_size=None
+    ):
         """Get document versions from object storage with pagination and starting conditions"""
         # /!\ Trick here /!\
         # The "KeyMarker" and "VersionIdMarker" fields must either be both set or both not set.
         # The error we get otherwise is not helpful at all.
-        markers = {}
+        token = {}
         if from_version_id:
-            markers.update(
+            token.update(
                 {"KeyMarker": self.file_key, "VersionIdMarker": from_version_id}
             )
 
-        real_page_size = (
-            min(page_size, settings.DOCUMENT_VERSIONS_PAGE_SIZE)
-            if page_size
-            else settings.DOCUMENT_VERSIONS_PAGE_SIZE
-        )
+        if from_datetime:
+            response = default_storage.connection.meta.client.list_object_versions(
+                Bucket=default_storage.bucket_name,
+                Prefix=self.file_key,
+                MaxKeys=settings.S3_VERSIONS_PAGE_SIZE,
+                **token,
+            )
+
+            # Find the first version after the given datetime
+            version = None
+            for version in response.get("Versions", []):
+                if version["LastModified"] >= from_datetime:
+                    token = {
+                        "KeyMarker": self.file_key,
+                        "VersionIdMarker": version["VersionId"],
+                    }
+                    break
+            else:
+                if version is None or version["LastModified"] < from_datetime:
+                    if response["NextVersionIdMarker"]:
+                        return self.get_versions_slice(
+                            from_version_id=response["NextVersionIdMarker"],
+                            page_size=settings.S3_VERSIONS_PAGE_SIZE,
+                            from_datetime=from_datetime,
+                        )
+                    return {
+                        "next_version_id_marker": "",
+                        "is_truncated": False,
+                        "versions": [],
+                    }
 
         response = default_storage.connection.meta.client.list_object_versions(
             Bucket=default_storage.bucket_name,
             Prefix=self.file_key,
-            # compensate the latest version that we exclude below and get one more to
-            # know if there are more pages
-            MaxKeys=real_page_size + 2,
-            **markers,
+            MaxKeys=min(page_size, settings.S3_VERSIONS_PAGE_SIZE)
+            if page_size
+            else settings.S3_VERSIONS_PAGE_SIZE,
+            **token,
         )
-
-        min_last_modified = min_datetime or self.created_at
-        versions = [
-            {
-                key_snake: version[key_camel]
-                for key_snake, key_camel in [
-                    ("etag", "ETag"),
-                    ("is_latest", "IsLatest"),
-                    ("last_modified", "LastModified"),
-                    ("version_id", "VersionId"),
-                ]
-            }
-            for version in response.get("Versions", [])
-            if version["LastModified"] >= min_last_modified
-            and version["IsLatest"] is False
-        ]
-        results = versions[:real_page_size]
-
-        count = len(results)
-        if count == len(versions):
-            is_truncated = False
-            next_version_id_marker = ""
-        else:
-            is_truncated = True
-            next_version_id_marker = versions[count - 1]["version_id"]
-
         return {
-            "next_version_id_marker": next_version_id_marker,
-            "is_truncated": is_truncated,
-            "versions": results,
-            "count": count,
+            "next_version_id_marker": response["NextVersionIdMarker"],
+            "is_truncated": response["IsTruncated"],
+            "versions": [
+                {
+                    key_snake: version[key_camel]
+                    for key_camel, key_snake in [
+                        ("ETag", "etag"),
+                        ("IsLatest", "is_latest"),
+                        ("LastModified", "last_modified"),
+                        ("VersionId", "version_id"),
+                    ]
+                }
+                for version in response.get("Versions", [])
+            ],
         }
 
     def delete_version(self, version_id):
@@ -505,167 +457,25 @@ class Document(BaseModel):
         """
         Compute and return abilities for a given user on the document.
         """
-        roles = set(get_resource_roles(self, user))
-
-        # Compute version roles before adding link roles because we don't
-        # want anonymous users to access versions (we wouldn't know from
-        # which date to allow them anyway)
-        # Anonymous users should also not see document accesses
-        has_role = bool(roles)
-
-        # Add role provided by the document link
-        if self.link_reach == LinkReachChoices.PUBLIC or (
-            self.link_reach == LinkReachChoices.AUTHENTICATED and user.is_authenticated
-        ):
-            roles.add(self.link_role)
-
+        roles = get_resource_roles(self, user)
         is_owner_or_admin = bool(
-            roles.intersection({RoleChoices.OWNER, RoleChoices.ADMIN})
+            set(roles).intersection({RoleChoices.OWNER, RoleChoices.ADMIN})
         )
-        can_get = bool(roles)
-        can_update = is_owner_or_admin or RoleChoices.EDITOR in roles
+        is_editor = bool(RoleChoices.EDITOR in roles)
+        can_get = self.is_public or bool(roles)
+        can_get_versions = bool(roles)
 
         return {
-            "accesses_manage": is_owner_or_admin,
-            "accesses_view": has_role,
-            "ai_transform": can_update,
-            "ai_translate": can_update,
-            "attachment_upload": can_update,
-            "collaboration_auth": can_get,
             "destroy": RoleChoices.OWNER in roles,
-            "favorite": can_get and user.is_authenticated,
-            "link_configuration": is_owner_or_admin,
-            "invite_owner": RoleChoices.OWNER in roles,
-            "partial_update": can_update,
-            "retrieve": can_get,
-            "media_auth": can_get,
-            "update": can_update,
             "versions_destroy": is_owner_or_admin,
-            "versions_list": has_role,
-            "versions_retrieve": has_role,
+            "versions_list": can_get_versions,
+            "versions_retrieve": can_get_versions,
+            "manage_accesses": is_owner_or_admin,
+            "update": is_owner_or_admin or is_editor,
+            "partial_update": is_owner_or_admin or is_editor,
+            "retrieve": can_get,
         }
 
-    def send_email(self, subject, emails, context=None, language=None):
-        """Generate and send email from a template."""
-        context = context or {}
-        domain = Site.objects.get_current().domain
-        language = language or get_language()
-        context.update(
-            {
-                "brandname": settings.EMAIL_BRAND_NAME,
-                "document": self,
-                "domain": domain,
-                "link": f"{domain}/docs/{self.id}/",
-                "logo_img": settings.EMAIL_LOGO_IMG,
-            }
-        )
-
-        with override(language):
-            msg_html = render_to_string("mail/html/invitation.html", context)
-            msg_plain = render_to_string("mail/text/invitation.txt", context)
-            subject = str(subject)  # Force translation
-
-            try:
-                send_mail(
-                    subject.capitalize(),
-                    msg_plain,
-                    settings.EMAIL_FROM,
-                    emails,
-                    html_message=msg_html,
-                    fail_silently=False,
-                )
-            except smtplib.SMTPException as exception:
-                logger.error("invitation to %s was not sent: %s", emails, exception)
-
-    def send_invitation_email(self, email, role, sender, language=None):
-        """Method allowing a user to send an email invitation to another user for a document."""
-        language = language or get_language()
-        role = RoleChoices(role).label
-        sender_name = sender.full_name or sender.email
-        sender_name_email = (
-            f"{sender.full_name:s} ({sender.email})"
-            if sender.full_name
-            else sender.email
-        )
-
-        with override(language):
-            context = {
-                "title": _("{name} shared a document with you!").format(
-                    name=sender_name
-                ),
-                "message": _(
-                    '{name} invited you with the role "{role}" on the following document:'
-                ).format(name=sender_name_email, role=role.lower()),
-            }
-            subject = _("{name} shared a document with you: {title}").format(
-                name=sender_name, title=self.title
-            )
-
-        self.send_email(subject, [email], context, language)
-
-
-class LinkTrace(BaseModel):
-    """
-    Relation model to trace accesses to a document via a link by a logged-in user.
-    This is necessary to show the document in the user's list of documents even
-    though the user does not have a role on the document.
-    """
-
-    document = models.ForeignKey(
-        Document,
-        on_delete=models.CASCADE,
-        related_name="link_traces",
-    )
-    user = models.ForeignKey(User, on_delete=models.CASCADE, related_name="link_traces")
-
-    class Meta:
-        db_table = "impress_link_trace"
-        verbose_name = _("Document/user link trace")
-        verbose_name_plural = _("Document/user link traces")
-        constraints = [
-            models.UniqueConstraint(
-                fields=["user", "document"],
-                name="unique_link_trace_document_user",
-                violation_error_message=_(
-                    "A link trace already exists for this document/user."
-                ),
-            ),
-        ]
-
-    def __str__(self):
-        return f"{self.user!s} trace on document {self.document!s}"
-
-
-class DocumentFavorite(BaseModel):
-    """Relation model to store a user's favorite documents."""
-
-    document = models.ForeignKey(
-        Document,
-        on_delete=models.CASCADE,
-        related_name="favorited_by_users",
-    )
-    user = models.ForeignKey(
-        User, on_delete=models.CASCADE, related_name="favorite_documents"
-    )
-
-    class Meta:
-        db_table = "impress_document_favorite"
-        verbose_name = _("Document favorite")
-        verbose_name_plural = _("Document favorites")
-        constraints = [
-            models.UniqueConstraint(
-                fields=["user", "document"],
-                name="unique_document_favorite_user",
-                violation_error_message=_(
-                    "This document is already targeted by a favorite relation instance "
-                    "for the same user."
-                ),
-            ),
-        ]
-
-    def __str__(self):
-        return f"{self.user!s} favorite on document {self.document!s}"
-
 
 class DocumentAccess(BaseAccess):
     """Relation model to give access to a document for a user or a team with a role."""
@@ -742,102 +552,22 @@ class Template(BaseModel):
         is_owner_or_admin = bool(
             set(roles).intersection({RoleChoices.OWNER, RoleChoices.ADMIN})
         )
+        is_editor = bool(RoleChoices.EDITOR in roles)
         can_get = self.is_public or bool(roles)
-        can_update = is_owner_or_admin or RoleChoices.EDITOR in roles
 
         return {
             "destroy": RoleChoices.OWNER in roles,
             "generate_document": can_get,
-            "accesses_manage": is_owner_or_admin,
-            "update": can_update,
-            "partial_update": can_update,
+            "manage_accesses": is_owner_or_admin,
+            "update": is_owner_or_admin or is_editor,
+            "partial_update": is_owner_or_admin or is_editor,
             "retrieve": can_get,
         }
 
-    def generate_pdf(self, body_html, metadata):
+    def generate_document(self, body, body_type):
         """
-        Generate and return a pdf document wrapped around the current template
-        """
-        document_html = weasyprint.HTML(
-            string=DjangoTemplate(self.code).render(
-                Context({"body": html.format_html(body_html), **metadata})
-            )
-        )
-        css = weasyprint.CSS(
-            string=self.css,
-            font_config=weasyprint.text.fonts.FontConfiguration(),
-        )
-
-        pdf_content = document_html.write_pdf(stylesheets=[css], zoom=1)
-        response = FileResponse(BytesIO(pdf_content), content_type="application/pdf")
-        response["Content-Disposition"] = f"attachment; filename={self.title}.pdf"
-
-        return response
-
-    def generate_word(self, body_html, metadata):
-        """
-        Generate and return a docx document wrapped around the current template
-        """
-        template_string = DjangoTemplate(self.code).render(
-            Context({"body": html.format_html(body_html), **metadata})
-        )
-
-        html_string = f"""
-        <!DOCTYPE html>
-        <html>
-        <head>
-            <style>
-                {self.css}
-            </style>
-        </head>
-        <body>
-            {template_string}
-        </body>
-        </html>
-        """
-
-        reference_docx = "core/static/reference.docx"
-        output = BytesIO()
-
-        # Convert the HTML to a temporary docx file
-        with tempfile.NamedTemporaryFile(suffix=".docx", prefix="docx_") as tmp_file:
-            output_path = tmp_file.name
-
-            pypandoc.convert_text(
-                html_string,
-                "docx",
-                format="html",
-                outputfile=output_path,
-                extra_args=["--reference-doc", reference_docx],
-            )
-
-            # Create a BytesIO object to store the output of the temporary docx file
-            with open(output_path, "rb") as f:
-                output = BytesIO(f.read())
-
-        # Ensure the pointer is at the beginning
-        output.seek(0)
-
-        response = FileResponse(
-            output,
-            content_type="application/vnd.openxmlformats-officedocument.wordprocessingml.document",
-        )
-        response["Content-Disposition"] = f"attachment; filename={self.title}.docx"
-
-        return response
-
-    def generate_document(self, body, body_type, export_format):
-        """
-        Generate and return a document for this template around the
+        Generate and return a PDF document for this template around the
         body passed as argument.
-
-        2 types of body are accepted:
-        - HTML: body_type = "html"
-        - Markdown: body_type = "markdown"
-
-        2 types of documents can be generated:
-        - PDF: export_format = "pdf"
-        - Docx: export_format = "docx"
         """
         document = frontmatter.loads(body)
         metadata = document.metadata
@@ -850,10 +580,16 @@ class Template(BaseModel):
                 markdown.markdown(textwrap.dedent(strip_body)) if strip_body else ""
             )
 
-        if export_format == "pdf":
-            return self.generate_pdf(body_html, metadata)
-
-        return self.generate_word(body_html, metadata)
+        document_html = HTML(
+            string=DjangoTemplate(self.code).render(
+                Context({"body": html.format_html(body_html), **metadata})
+            )
+        )
+        css = CSS(
+            string=self.css,
+            font_config=FontConfiguration(),
+        )
+        return document_html.write_pdf(stylesheets=[css], zoom=1)
 
 
 class TemplateAccess(BaseAccess):
@@ -917,8 +653,6 @@ class Invitation(BaseModel):
         User,
         on_delete=models.CASCADE,
         related_name="invitations",
-        blank=True,
-        null=True,
     )
 
     class Meta:
@@ -934,6 +668,14 @@ class Invitation(BaseModel):
     def __str__(self):
         return f"{self.email} invited to {self.document}"
 
+    def save(self, *args, **kwargs):
+        """Make invitations read-only."""
+        if self.created_at:
+            raise exceptions.PermissionDenied()
+
+        super().save(*args, **kwargs)
+        self.email_invitation()
+
     def clean(self):
         """Validate fields."""
         super().clean()
@@ -955,10 +697,11 @@ class Invitation(BaseModel):
 
     def get_abilities(self, user):
         """Compute and return abilities for a given user."""
+        can_delete = False
         roles = []
 
         if user.is_authenticated:
-            teams = user.teams
+            teams = user.get_teams()
             try:
                 roles = self.user_roles or []
             except AttributeError:
@@ -969,13 +712,33 @@ class Invitation(BaseModel):
                 except (self._meta.model.DoesNotExist, IndexError):
                     roles = []
 
-        is_admin_or_owner = bool(
-            set(roles).intersection({RoleChoices.OWNER, RoleChoices.ADMIN})
-        )
+            can_delete = bool(
+                set(roles).intersection({RoleChoices.OWNER, RoleChoices.ADMIN})
+            )
 
         return {
-            "destroy": is_admin_or_owner,
-            "update": is_admin_or_owner,
-            "partial_update": is_admin_or_owner,
-            "retrieve": is_admin_or_owner,
+            "destroy": can_delete,
+            "update": False,
+            "partial_update": False,
+            "retrieve": bool(roles),
         }
+
+    def email_invitation(self):
+        """Email invitation to the user."""
+        try:
+            with override(self.issuer.language):
+                title = _("Invitation to join Impress!")
+                template_vars = {"title": title, "site": Site.objects.get_current()}
+                msg_html = render_to_string("mail/html/invitation.html", template_vars)
+                msg_plain = render_to_string("mail/text/invitation.txt", template_vars)
+                mail.send_mail(
+                    title,
+                    msg_plain,
+                    settings.EMAIL_FROM,
+                    [self.email],
+                    html_message=msg_html,
+                    fail_silently=False,
+                )
+
+        except smtplib.SMTPException as exception:
+            logger.error("invitation to %s was not sent: %s", self.email, exception)

src/backend/core/services/ai_services.py

@@ -1,98 +0,0 @@
-"""AI services."""
-
-import json
-import re
-
-from django.conf import settings
-from django.core.exceptions import ImproperlyConfigured
-
-from openai import OpenAI
-
-from core import enums
-
-AI_ACTIONS = {
-    "prompt": (
-        "Answer the prompt in markdown format. Return JSON: "
-        '{"answer": "Your markdown answer"}. '
-        "Do not provide any other information."
-    ),
-    "correct": (
-        "Correct grammar and spelling of the markdown text, "
-        "preserving language and markdown formatting. "
-        'Return JSON: {"answer": "your corrected markdown text"}. '
-        "Do not provide any other information."
-    ),
-    "rephrase": (
-        "Rephrase the given markdown text, "
-        "preserving language and markdown formatting. "
-        'Return JSON: {"answer": "your rephrased markdown text"}. '
-        "Do not provide any other information."
-    ),
-    "summarize": (
-        "Summarize the markdown text, preserving language and markdown formatting. "
-        'Return JSON: {"answer": "your markdown summary"}. '
-        "Do not provide any other information."
-    ),
-}
-
-AI_TRANSLATE = (
-    "Translate the markdown text to {language:s}, preserving markdown formatting. "
-    'Return JSON: {{"answer": "your translated markdown text in {language:s}"}}. '
-    "Do not provide any other information."
-)
-
-
-class AIService:
-    """Service class for AI-related operations."""
-
-    def __init__(self):
-        """Ensure that the AI configuration is set properly."""
-        if (
-            settings.AI_BASE_URL is None
-            or settings.AI_API_KEY is None
-            or settings.AI_MODEL is None
-        ):
-            raise ImproperlyConfigured("AI configuration not set")
-        self.client = OpenAI(base_url=settings.AI_BASE_URL, api_key=settings.AI_API_KEY)
-
-    def call_ai_api(self, system_content, text):
-        """Helper method to call the OpenAI API and process the response."""
-        response = self.client.chat.completions.create(
-            model=settings.AI_MODEL,
-            response_format={"type": "json_object"},
-            messages=[
-                {"role": "system", "content": system_content},
-                {"role": "user", "content": json.dumps({"markdown_input": text})},
-            ],
-        )
-
-        content = response.choices[0].message.content
-
-        try:
-            sanitized_content = re.sub(r'\s*"answer"\s*:\s*', '"answer": ', content)
-            sanitized_content = re.sub(r"\s*\}", "}", sanitized_content)
-            sanitized_content = re.sub(r"(?<!\\)\n", "\\\\n", sanitized_content)
-            sanitized_content = re.sub(r"(?<!\\)\t", "\\\\t", sanitized_content)
-
-            json_response = json.loads(sanitized_content)
-        except (json.JSONDecodeError, IndexError):
-            try:
-                json_response = json.loads(content)
-            except json.JSONDecodeError as err:
-                raise RuntimeError("AI response is not valid JSON", content) from err
-
-        if "answer" not in json_response:
-            raise RuntimeError("AI response does not contain an answer")
-
-        return json_response
-
-    def transform(self, text, action):
-        """Transform text based on specified action."""
-        system_content = AI_ACTIONS[action]
-        return self.call_ai_api(system_content, text)
-
-    def translate(self, text, language):
-        """Translate text to a specified language."""
-        language_display = enums.ALL_LANGUAGES.get(language, language)
-        system_content = AI_TRANSLATE.format(language=language_display)
-        return self.call_ai_api(system_content, text)

src/backend/core/services/collaboration_services.py

@@ -1,43 +0,0 @@
-"""Collaboration services."""
-
-from django.conf import settings
-from django.core.exceptions import ImproperlyConfigured
-
-import requests
-
-
-class CollaborationService:
-    """Service class for Collaboration related operations."""
-
-    def __init__(self):
-        """Ensure that the collaboration configuration is set properly."""
-        if settings.COLLABORATION_API_URL is None:
-            raise ImproperlyConfigured("Collaboration configuration not set")
-
-    def reset_connections(self, room, user_id=None):
-        """
-        Reset connections of a room in the collaboration server.
-        Reseting a connection means that the user will be disconnected and will
-        have to reconnect to the collaboration server, with updated rights.
-        """
-        endpoint = "reset-connections"
-
-        # room is necessary as a parameter, it is easier to stick to the
-        # same pod thanks to a parameter
-        endpoint_url = f"{settings.COLLABORATION_API_URL}{endpoint}/?room={room}"
-
-        # Note: Collaboration microservice accepts only raw token, which is not recommended
-        headers = {"Authorization": settings.COLLABORATION_SERVER_SECRET}
-        if user_id:
-            headers["X-User-Id"] = user_id
-
-        try:
-            response = requests.post(endpoint_url, headers=headers, timeout=10)
-        except requests.RequestException as e:
-            raise requests.HTTPError("Failed to notify WebSocket server.") from e
-
-        if response.status_code != 200:
-            raise requests.HTTPError(
-                f"Failed to notify WebSocket server. Status code: {response.status_code}, "
-                f"Response: {response.text}"
-            )

src/backend/core/services/converter_services.py

@@ -1,78 +0,0 @@
-"""Converter services."""
-
-from django.conf import settings
-
-import requests
-
-
-class ConversionError(Exception):
-    """Base exception for conversion-related errors."""
-
-
-class ValidationError(ConversionError):
-    """Raised when the input validation fails."""
-
-
-class ServiceUnavailableError(ConversionError):
-    """Raised when the conversion service is unavailable."""
-
-
-class InvalidResponseError(ConversionError):
-    """Raised when the conversion service returns an invalid response."""
-
-
-class MissingContentError(ConversionError):
-    """Raised when the response is missing required content."""
-
-
-class YdocConverter:
-    """Service class for conversion-related operations."""
-
-    @property
-    def auth_header(self):
-        """Build microservice authentication header."""
-        # Note: Yprovider microservice accepts only raw token, which is not recommended
-        return settings.Y_PROVIDER_API_KEY
-
-    def convert_markdown(self, text):
-        """Convert a Markdown text into our internal format using an external microservice."""
-
-        if not text:
-            raise ValidationError("Input text cannot be empty")
-
-        try:
-            response = requests.post(
-                f"{settings.Y_PROVIDER_API_BASE_URL}{settings.CONVERSION_API_ENDPOINT}/",
-                json={
-                    "content": text,
-                },
-                headers={
-                    "Authorization": self.auth_header,
-                    "Content-Type": "application/json",
-                },
-                timeout=settings.CONVERSION_API_TIMEOUT,
-                verify=settings.CONVERSION_API_SECURE,
-            )
-            response.raise_for_status()
-            conversion_response = response.json()
-
-        except requests.RequestException as err:
-            raise ServiceUnavailableError(
-                "Failed to connect to conversion service",
-            ) from err
-
-        except ValueError as err:
-            raise InvalidResponseError(
-                "Could not parse conversion service response"
-            ) from err
-
-        try:
-            document_content = conversion_response[
-                settings.CONVERSION_API_CONTENT_FIELD
-            ]
-        except KeyError as err:
-            raise MissingContentError(
-                f"Response missing required field: {settings.CONVERSION_API_CONTENT_FIELD}"
-            ) from err
-
-        return document_content

src/backend/core/tests/authentication/test_backends.py

@@ -1,12 +1,8 @@
 """Unit tests for the Authentication Backends."""
 
-import re
-
 from django.core.exceptions import SuspiciousOperation
-from django.test.utils import override_settings
 
 import pytest
-import responses
 
 from core import models
 from core.authentication.backends import OIDCAuthenticationBackend
@@ -38,130 +34,6 @@ def test_authentication_getter_existing_user_no_email(
     assert user == db_user
 
 
-def test_authentication_getter_existing_user_via_email(
-    django_assert_num_queries, monkeypatch
-):
-    """
-    If an existing user doesn't match the sub but matches the email,
-    the user should be returned.
-    """
-
-    klass = OIDCAuthenticationBackend()
-    db_user = UserFactory()
-
-    def get_userinfo_mocked(*args):
-        return {"sub": "123", "email": db_user.email}
-
-    monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
-
-    with django_assert_num_queries(2):
-        user = klass.get_or_create_user(
-            access_token="test-token", id_token=None, payload=None
-        )
-
-    assert user == db_user
-
-
-def test_authentication_getter_existing_user_no_fallback_to_email(
-    settings, monkeypatch
-):
-    """
-    When the "OIDC_FALLBACK_TO_EMAIL_FOR_IDENTIFICATION" setting is set to False,
-    the system should not match users by email, even if the email matches.
-    """
-
-    klass = OIDCAuthenticationBackend()
-    db_user = UserFactory()
-
-    # Set the setting to False
-    settings.OIDC_FALLBACK_TO_EMAIL_FOR_IDENTIFICATION = False
-
-    def get_userinfo_mocked(*args):
-        return {"sub": "123", "email": db_user.email}
-
-    monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
-
-    user = klass.get_or_create_user(
-        access_token="test-token", id_token=None, payload=None
-    )
-
-    # Since the sub doesn't match, it should create a new user
-    assert models.User.objects.count() == 2
-    assert user != db_user
-    assert user.sub == "123"
-
-
-def test_authentication_getter_existing_user_with_email(
-    django_assert_num_queries, monkeypatch
-):
-    """
-    When the user's info contains an email and targets an existing user,
-    """
-    klass = OIDCAuthenticationBackend()
-    user = UserFactory(full_name="John Doe", short_name="John")
-
-    def get_userinfo_mocked(*args):
-        return {
-            "sub": user.sub,
-            "email": user.email,
-            "first_name": "John",
-            "last_name": "Doe",
-        }
-
-    monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
-
-    # Only 1 query because email and names have not changed
-    with django_assert_num_queries(1):
-        authenticated_user = klass.get_or_create_user(
-            access_token="test-token", id_token=None, payload=None
-        )
-
-    assert user == authenticated_user
-
-
-@pytest.mark.parametrize(
-    "first_name, last_name, email",
-    [
-        ("Jack", "Doe", "john.doe@example.com"),
-        ("John", "Duy", "john.doe@example.com"),
-        ("John", "Doe", "jack.duy@example.com"),
-        ("Jack", "Duy", "jack.duy@example.com"),
-    ],
-)
-def test_authentication_getter_existing_user_change_fields(
-    first_name, last_name, email, django_assert_num_queries, monkeypatch
-):
-    """
-    It should update the email or name fields on the user when they change.
-    """
-    klass = OIDCAuthenticationBackend()
-    user = UserFactory(
-        full_name="John Doe", short_name="John", email="john.doe@example.com"
-    )
-
-    def get_userinfo_mocked(*args):
-        return {
-            "sub": user.sub,
-            "email": email,
-            "first_name": first_name,
-            "last_name": last_name,
-        }
-
-    monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
-
-    # One and only one additional update query when a field has changed
-    with django_assert_num_queries(2):
-        authenticated_user = klass.get_or_create_user(
-            access_token="test-token", id_token=None, payload=None
-        )
-
-    assert user == authenticated_user
-    user.refresh_from_db()
-    assert user.email == email
-    assert user.full_name == f"{first_name:s} {last_name:s}"
-    assert user.short_name == first_name
-
-
 def test_authentication_getter_new_user_no_email(monkeypatch):
     """
     If no user matches the user's info sub, a user should be created.
@@ -180,8 +52,6 @@ def test_authentication_getter_new_user_no_email(monkeypatch):
 
     assert user.sub == "123"
     assert user.email is None
-    assert user.full_name is None
-    assert user.short_name is None
     assert user.password == "!"
     assert models.User.objects.count() == 1
 
@@ -207,13 +77,11 @@ def test_authentication_getter_new_user_with_email(monkeypatch):
 
     assert user.sub == "123"
     assert user.email == email
-    assert user.full_name == "John Doe"
-    assert user.short_name == "John"
     assert user.password == "!"
     assert models.User.objects.count() == 1
 
 
-def test_authentication_getter_invalid_token(django_assert_num_queries, monkeypatch):
+def test_models_oidc_user_getter_invalid_token(django_assert_num_queries, monkeypatch):
     """The user's info doesn't contain a sub."""
     klass = OIDCAuthenticationBackend()
 
@@ -224,144 +92,10 @@ def test_authentication_getter_invalid_token(django_assert_num_queries, monkeypa
 
     monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
 
-    with (
-        django_assert_num_queries(0),
-        pytest.raises(
-            SuspiciousOperation,
-            match="User info contained no recognizable user identification",
-        ),
+    with django_assert_num_queries(0), pytest.raises(
+        SuspiciousOperation,
+        match="User info contained no recognizable user identification",
     ):
         klass.get_or_create_user(access_token="test-token", id_token=None, payload=None)
 
     assert models.User.objects.exists() is False
-
-
-@override_settings(OIDC_OP_USER_ENDPOINT="http://oidc.endpoint.test/userinfo")
-@responses.activate
-def test_authentication_get_userinfo_json_response():
-    """Test get_userinfo method with a JSON response."""
-
-    responses.add(
-        responses.GET,
-        re.compile(r".*/userinfo"),
-        json={
-            "first_name": "John",
-            "last_name": "Doe",
-            "email": "john.doe@example.com",
-        },
-        status=200,
-    )
-
-    oidc_backend = OIDCAuthenticationBackend()
-    result = oidc_backend.get_userinfo("fake_access_token", None, None)
-
-    assert result["first_name"] == "John"
-    assert result["last_name"] == "Doe"
-    assert result["email"] == "john.doe@example.com"
-
-
-@override_settings(OIDC_OP_USER_ENDPOINT="http://oidc.endpoint.test/userinfo")
-@responses.activate
-def test_authentication_get_userinfo_token_response(monkeypatch):
-    """Test get_userinfo method with a token response."""
-
-    responses.add(
-        responses.GET, re.compile(r".*/userinfo"), body="fake.jwt.token", status=200
-    )
-
-    def mock_verify_token(self, token):  # pylint: disable=unused-argument
-        return {
-            "first_name": "Jane",
-            "last_name": "Doe",
-            "email": "jane.doe@example.com",
-        }
-
-    monkeypatch.setattr(OIDCAuthenticationBackend, "verify_token", mock_verify_token)
-
-    oidc_backend = OIDCAuthenticationBackend()
-    result = oidc_backend.get_userinfo("fake_access_token", None, None)
-
-    assert result["first_name"] == "Jane"
-    assert result["last_name"] == "Doe"
-    assert result["email"] == "jane.doe@example.com"
-
-
-@override_settings(OIDC_OP_USER_ENDPOINT="http://oidc.endpoint.test/userinfo")
-@responses.activate
-def test_authentication_get_userinfo_invalid_response():
-    """
-    Test get_userinfo method with an invalid JWT response that
-    causes verify_token to raise an error.
-    """
-
-    responses.add(
-        responses.GET, re.compile(r".*/userinfo"), body="fake.jwt.token", status=200
-    )
-
-    oidc_backend = OIDCAuthenticationBackend()
-
-    with pytest.raises(
-        SuspiciousOperation,
-        match="Invalid response format or token verification failed",
-    ):
-        oidc_backend.get_userinfo("fake_access_token", None, None)
-
-
-def test_authentication_getter_existing_disabled_user_via_sub(
-    django_assert_num_queries, monkeypatch
-):
-    """
-    If an existing user matches the sub but is disabled,
-    an error should be raised and a user should not be created.
-    """
-
-    klass = OIDCAuthenticationBackend()
-    db_user = UserFactory(is_active=False)
-
-    def get_userinfo_mocked(*args):
-        return {
-            "sub": db_user.sub,
-            "email": db_user.email,
-            "first_name": "John",
-            "last_name": "Doe",
-        }
-
-    monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
-
-    with (
-        django_assert_num_queries(1),
-        pytest.raises(SuspiciousOperation, match="User account is disabled"),
-    ):
-        klass.get_or_create_user(access_token="test-token", id_token=None, payload=None)
-
-    assert models.User.objects.count() == 1
-
-
-def test_authentication_getter_existing_disabled_user_via_email(
-    django_assert_num_queries, monkeypatch
-):
-    """
-    If an existing user does not matches the sub but matches the email and is disabled,
-    an error should be raised and a user should not be created.
-    """
-
-    klass = OIDCAuthenticationBackend()
-    db_user = UserFactory(is_active=False)
-
-    def get_userinfo_mocked(*args):
-        return {
-            "sub": "random",
-            "email": db_user.email,
-            "first_name": "John",
-            "last_name": "Doe",
-        }
-
-    monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
-
-    with (
-        django_assert_num_queries(2),
-        pytest.raises(SuspiciousOperation, match="User account is disabled"),
-    ):
-        klass.get_or_create_user(access_token="test-token", id_token=None, payload=None)
-
-    assert models.User.objects.count() == 1

src/backend/core/tests/conftest.py

@@ -1,5 +1,4 @@
 """Fixtures for tests in the impress core application"""
-
 from unittest import mock
 
 import pytest
@@ -10,9 +9,7 @@ VIA = [USER, TEAM]
 
 
 @pytest.fixture
-def mock_user_teams():
-    """Mock for the "teams" property on the User model."""
-    with mock.patch(
-        "core.models.User.teams", new_callable=mock.PropertyMock
-    ) as mock_teams:
-        yield mock_teams
+def mock_user_get_teams():
+    """Mock for the "get_teams" method on the User model."""
+    with mock.patch("core.models.User.get_teams") as mock_get_teams:
+        yield mock_get_teams

src/backend/core/tests/documents/test_api_document_accesses_create.py

@@ -1,237 +0,0 @@
-"""
-Test document accesses API endpoints for users in impress's core app.
-"""
-
-import random
-
-from django.core import mail
-
-import pytest
-from rest_framework.test import APIClient
-
-from core import factories, models
-from core.api import serializers
-from core.tests.conftest import TEAM, USER, VIA
-
-pytestmark = pytest.mark.django_db
-
-
-def test_api_document_accesses_create_anonymous():
-    """Anonymous users should not be allowed to create document accesses."""
-    document = factories.DocumentFactory()
-
-    other_user = factories.UserFactory()
-    response = APIClient().post(
-        f"/api/v1.0/documents/{document.id!s}/accesses/",
-        {
-            "user_id": str(other_user.id),
-            "document": str(document.id),
-            "role": random.choice(models.RoleChoices.choices)[0],
-        },
-        format="json",
-    )
-
-    assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
-    assert models.DocumentAccess.objects.exists() is False
-
-
-def test_api_document_accesses_create_authenticated_unrelated():
-    """
-    Authenticated users should not be allowed to create document accesses for a document to
-    which they are not related.
-    """
-    user = factories.UserFactory(with_owned_document=True)
-
-    client = APIClient()
-    client.force_login(user)
-
-    other_user = factories.UserFactory()
-    document = factories.DocumentFactory()
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/accesses/",
-        {
-            "user_id": str(other_user.id),
-        },
-        format="json",
-    )
-
-    assert response.status_code == 403
-    assert not models.DocumentAccess.objects.filter(user=other_user).exists()
-
-
-@pytest.mark.parametrize("role", ["reader", "editor"])
-@pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_create_authenticated_reader_or_editor(
-    via, role, mock_user_teams
-):
-    """Readers or editors of a document should not be allowed to create document accesses."""
-    user = factories.UserFactory(with_owned_document=True)
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory()
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role=role
-        )
-
-    other_user = factories.UserFactory()
-
-    for new_role in [role[0] for role in models.RoleChoices.choices]:
-        response = client.post(
-            f"/api/v1.0/documents/{document.id!s}/accesses/",
-            {
-                "user_id": str(other_user.id),
-                "role": new_role,
-            },
-            format="json",
-        )
-
-        assert response.status_code == 403
-
-    assert not models.DocumentAccess.objects.filter(user=other_user).exists()
-
-
-@pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_create_authenticated_administrator(via, mock_user_teams):
-    """
-    Administrators of a document should be able to create document accesses
-    except for the "owner" role.
-    An email should be sent to the accesses to notify them of the adding.
-    """
-    user = factories.UserFactory(with_owned_document=True)
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory()
-    if via == USER:
-        factories.UserDocumentAccessFactory(
-            document=document, user=user, role="administrator"
-        )
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role="administrator"
-        )
-
-    other_user = factories.UserFactory()
-
-    # It should not be allowed to create an owner access
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/accesses/",
-        {
-            "user_id": str(other_user.id),
-            "role": "owner",
-        },
-        format="json",
-    )
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "Only owners of a resource can assign other users as owners."
-    }
-
-    # It should be allowed to create a lower access
-    role = random.choice(
-        [role[0] for role in models.RoleChoices.choices if role[0] != "owner"]
-    )
-
-    assert len(mail.outbox) == 0
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/accesses/",
-        {
-            "user_id": str(other_user.id),
-            "role": role,
-        },
-        format="json",
-    )
-
-    assert response.status_code == 201
-    assert models.DocumentAccess.objects.filter(user=other_user).count() == 1
-    new_document_access = models.DocumentAccess.objects.filter(user=other_user).get()
-    other_user = serializers.UserSerializer(instance=other_user).data
-    assert response.json() == {
-        "abilities": new_document_access.get_abilities(user),
-        "id": str(new_document_access.id),
-        "team": "",
-        "role": role,
-        "user": other_user,
-    }
-    assert len(mail.outbox) == 1
-    email = mail.outbox[0]
-    assert email.to == [other_user["email"]]
-    email_content = " ".join(email.body.split())
-    assert f"{user.full_name} shared a document with you!" in email_content
-    assert (
-        f"{user.full_name} ({user.email}) invited you with the role "{role}" "
-        f"on the following document: {document.title}"
-    ) in email_content
-    assert "docs/" + str(document.id) + "/" in email_content
-
-
-@pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_create_authenticated_owner(via, mock_user_teams):
-    """
-    Owners of a document should be able to create document accesses whatever the role.
-    An email should be sent to the accesses to notify them of the adding.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory()
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user, role="owner")
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role="owner"
-        )
-
-    other_user = factories.UserFactory()
-
-    role = random.choice([role[0] for role in models.RoleChoices.choices])
-
-    assert len(mail.outbox) == 0
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/accesses/",
-        {
-            "user_id": str(other_user.id),
-            "role": role,
-        },
-        format="json",
-    )
-
-    assert response.status_code == 201
-    assert models.DocumentAccess.objects.filter(user=other_user).count() == 1
-    new_document_access = models.DocumentAccess.objects.filter(user=other_user).get()
-    other_user = serializers.UserSerializer(instance=other_user).data
-    assert response.json() == {
-        "id": str(new_document_access.id),
-        "user": other_user,
-        "team": "",
-        "role": role,
-        "abilities": new_document_access.get_abilities(user),
-    }
-    assert len(mail.outbox) == 1
-    email = mail.outbox[0]
-    assert email.to == [other_user["email"]]
-    email_content = " ".join(email.body.split())
-    assert f"{user.full_name} shared a document with you!" in email_content
-    assert (
-        f"{user.full_name} ({user.email}) invited you with the role "{role}" "
-        f"on the following document: {document.title}"
-    ) in email_content
-    assert "docs/" + str(document.id) + "/" in email_content

src/backend/core/tests/documents/test_api_document_invitations.py

@@ -1,857 +0,0 @@
-"""
-Unit tests for the Invitation model
-"""
-
-import random
-from datetime import timedelta
-from unittest import mock
-
-from django.core import mail
-from django.test import override_settings
-from django.utils import timezone
-
-import pytest
-from rest_framework.test import APIClient
-
-from core import factories, models
-from core.api import serializers
-from core.tests.conftest import TEAM, USER, VIA
-
-pytestmark = pytest.mark.django_db
-
-
-# List
-
-
-def test_api_document_invitations_list_anonymous_user():
-    """Anonymous users should not be able to list invitations."""
-    invitation = factories.InvitationFactory()
-    response = APIClient().get(
-        f"/api/v1.0/documents/{invitation.document.id!s}/invitations/"
-    )
-    assert response.status_code == 401
-
-
-@pytest.mark.parametrize("via", VIA)
-@pytest.mark.parametrize("role", ["owner", "administrator"])
-def test_api_document_invitations_list_authenticated_privileged(
-    role, via, mock_user_teams, django_assert_num_queries
-):
-    """
-    Authenticated users should be able to list invitations for documents to which they are
-    related with administrator or owner privilege, including invitations issued by other users.
-    """
-    user = factories.UserFactory()
-    other_user = factories.UserFactory()
-    document = factories.DocumentFactory()
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role=role
-        )
-
-    invitation = factories.InvitationFactory(document=document, issuer=user)
-    other_invitations = factories.InvitationFactory.create_batch(
-        2, document=document, issuer=other_user
-    )
-
-    # invitations from other documents should not be listed
-    other_document = factories.DocumentFactory()
-    factories.InvitationFactory.create_batch(2, document=other_document)
-
-    client = APIClient()
-    client.force_login(user)
-    with django_assert_num_queries(3):
-        response = client.get(
-            f"/api/v1.0/documents/{document.id!s}/invitations/",
-        )
-    assert response.status_code == 200
-    assert response.json()["count"] == 3
-    assert sorted(response.json()["results"], key=lambda x: x["created_at"]) == sorted(
-        [
-            {
-                "id": str(i.id),
-                "created_at": i.created_at.isoformat().replace("+00:00", "Z"),
-                "email": str(i.email),
-                "document": str(document.id),
-                "role": i.role,
-                "issuer": str(i.issuer.id),
-                "is_expired": False,
-                "abilities": {
-                    "destroy": role in ["administrator", "owner"],
-                    "update": role in ["administrator", "owner"],
-                    "partial_update": role in ["administrator", "owner"],
-                    "retrieve": True,
-                },
-            }
-            for i in [invitation, *other_invitations]
-        ],
-        key=lambda x: x["created_at"],
-    )
-
-
-@pytest.mark.parametrize("via", VIA)
-@pytest.mark.parametrize("role", ["reader", "editor"])
-def test_api_document_invitations_list_authenticated_unprivileged(
-    role, via, mock_user_teams, django_assert_num_queries
-):
-    """
-    Authenticated users should not be able to list invitations for documents to which they are
-    related with reader or editor role, including invitations issued by other users.
-    """
-    user = factories.UserFactory()
-    other_user = factories.UserFactory()
-    document = factories.DocumentFactory()
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role=role
-        )
-
-    factories.InvitationFactory(document=document, issuer=user)
-    factories.InvitationFactory.create_batch(2, document=document, issuer=other_user)
-
-    # invitations from other documents should not be listed
-    other_document = factories.DocumentFactory()
-    factories.InvitationFactory.create_batch(2, document=other_document)
-
-    client = APIClient()
-    client.force_login(user)
-    with django_assert_num_queries(2):
-        response = client.get(
-            f"/api/v1.0/documents/{document.id!s}/invitations/",
-        )
-    assert response.status_code == 200
-    assert response.json()["count"] == 0
-
-
-def test_api_document_invitations_list_expired_invitations_still_listed():
-    """
-    Expired invitations are still listed.
-    """
-    user = factories.UserFactory()
-    other_user = factories.UserFactory()
-
-    document = factories.DocumentFactory(
-        users=[(user, "administrator"), (other_user, "owner")]
-    )
-
-    expired_invitation = factories.InvitationFactory(
-        document=document,
-        role="reader",
-        issuer=user,
-    )
-
-    client = APIClient()
-    client.force_login(user)
-
-    # mock timezone.now to accelerate validation expiration
-    too_late = timezone.now() + timedelta(seconds=604800)  # 7 days
-    with mock.patch("django.utils.timezone.now", return_value=too_late):
-        assert expired_invitation.is_expired is True
-
-        response = client.get(
-            f"/api/v1.0/documents/{document.id!s}/invitations/",
-        )
-
-    assert response.status_code == 200
-    assert response.json()["count"] == 1
-    assert sorted(response.json()["results"], key=lambda x: x["created_at"]) == sorted(
-        [
-            {
-                "id": str(expired_invitation.id),
-                "created_at": expired_invitation.created_at.isoformat().replace(
-                    "+00:00", "Z"
-                ),
-                "email": str(expired_invitation.email),
-                "document": str(document.id),
-                "role": expired_invitation.role,
-                "issuer": str(expired_invitation.issuer.id),
-                "is_expired": True,
-                "abilities": {
-                    "destroy": True,
-                    "update": True,
-                    "partial_update": True,
-                    "retrieve": True,
-                },
-            },
-        ],
-        key=lambda x: x["created_at"],
-    )
-
-
-# Retrieve
-
-
-def test_api_document_invitations_retrieve_anonymous_user():
-    """
-    Anonymous users should not be able to retrieve invitations.
-    """
-
-    invitation = factories.InvitationFactory()
-    response = APIClient().get(
-        f"/api/v1.0/documents/{invitation.document.id!s}/invitations/{invitation.id!s}/",
-    )
-
-    assert response.status_code == 401
-
-
-def test_api_document_invitations_retrieve_unrelated_user():
-    """
-    Authenticated unrelated users should not be able to retrieve invitations.
-    """
-    user = factories.UserFactory()
-    invitation = factories.InvitationFactory()
-
-    client = APIClient()
-    client.force_login(user)
-    response = client.get(
-        f"/api/v1.0/documents/{invitation.document.id!s}/invitations/{invitation.id!s}/",
-    )
-
-    assert response.status_code == 403
-
-
-@pytest.mark.parametrize("via", VIA)
-@pytest.mark.parametrize("role", ["administrator", "owner"])
-def test_api_document_invitations_retrieve_document_privileged(
-    role, via, mock_user_teams
-):
-    """
-    Authenticated users related to the document should be able to retrieve invitations
-    provided they are administrators or owners of the document.
-    """
-    user = factories.UserFactory()
-    invitation = factories.InvitationFactory()
-
-    if via == USER:
-        factories.UserDocumentAccessFactory(
-            document=invitation.document, user=user, role=role
-        )
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=invitation.document, team="lasuite", role=role
-        )
-
-    client = APIClient()
-    client.force_login(user)
-
-    response = client.get(
-        f"/api/v1.0/documents/{invitation.document.id!s}/invitations/{invitation.id!s}/",
-    )
-
-    assert response.status_code == 200
-    assert response.json() == {
-        "id": str(invitation.id),
-        "created_at": invitation.created_at.isoformat().replace("+00:00", "Z"),
-        "email": invitation.email,
-        "document": str(invitation.document.id),
-        "role": str(invitation.role),
-        "issuer": str(invitation.issuer.id),
-        "is_expired": False,
-        "abilities": {
-            "destroy": True,
-            "update": True,
-            "partial_update": True,
-            "retrieve": True,
-        },
-    }
-
-
-@pytest.mark.parametrize("via", VIA)
-@pytest.mark.parametrize("role", ["reader", "editor"])
-def test_api_document_invitations_retrieve_document_unprivileged(
-    role, via, mock_user_teams
-):
-    """
-    Authenticated users related to the document should not be able to retrieve invitations
-    if they are simply reader or editor of the document.
-    """
-    user = factories.UserFactory()
-    invitation = factories.InvitationFactory()
-
-    if via == USER:
-        factories.UserDocumentAccessFactory(
-            document=invitation.document, user=user, role=role
-        )
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=invitation.document, team="lasuite", role=role
-        )
-
-    client = APIClient()
-    client.force_login(user)
-
-    response = client.get(
-        f"/api/v1.0/documents/{invitation.document.id!s}/invitations/{invitation.id!s}/",
-    )
-
-    assert response.status_code == 403
-    assert response.content
-
-
-# Create
-
-
-def test_api_document_invitations_create_anonymous():
-    """Anonymous users should not be able to create invitations."""
-    document = factories.DocumentFactory()
-    invitation_values = {
-        "email": "guest@example.com",
-        "role": random.choice(models.RoleChoices.choices)[0],
-    }
-
-    response = APIClient().post(
-        f"/api/v1.0/documents/{document.id!s}/invitations/",
-        invitation_values,
-        format="json",
-    )
-
-    assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
-
-
-def test_api_document_invitations_create_authenticated_outsider():
-    """Users outside of document should not be permitted to invite to document."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory()
-    invitation_values = {
-        "email": "guest@example.com",
-        "role": random.choice(models.RoleChoices.choices)[0],
-    }
-
-    client = APIClient()
-    client.force_login(user)
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/invitations/",
-        invitation_values,
-        format="json",
-    )
-
-    assert response.status_code == 403
-
-
-@override_settings(EMAIL_BRAND_NAME="My brand name", EMAIL_LOGO_IMG="my-img.jpg")
-@pytest.mark.parametrize(
-    "inviting,invited,response_code",
-    (
-        ["reader", "reader", 403],
-        ["reader", "editor", 403],
-        ["reader", "administrator", 403],
-        ["reader", "owner", 403],
-        ["editor", "reader", 403],
-        ["editor", "editor", 403],
-        ["editor", "administrator", 403],
-        ["editor", "owner", 403],
-        ["administrator", "reader", 201],
-        ["administrator", "editor", 201],
-        ["administrator", "administrator", 201],
-        ["administrator", "owner", 400],
-        ["owner", "reader", 201],
-        ["owner", "editor", 201],
-        ["owner", "administrator", 201],
-        ["owner", "owner", 201],
-    ),
-)
-@pytest.mark.parametrize("via", VIA)
-def test_api_document_invitations_create_privileged_members(
-    via, inviting, invited, response_code, mock_user_teams
-):
-    """
-    Only owners and administrators should be able to invite new users.
-    Only owners can invite owners.
-    """
-    user = factories.UserFactory()
-    document = factories.DocumentFactory()
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user, role=inviting)
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role=inviting
-        )
-
-    invitation_values = {
-        "email": "guest@example.com",
-        "role": invited,
-    }
-
-    assert len(mail.outbox) == 0
-
-    client = APIClient()
-    client.force_login(user)
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/invitations/",
-        invitation_values,
-        format="json",
-    )
-
-    assert response.status_code == response_code
-
-    if response_code == 201:
-        assert models.Invitation.objects.count() == 1
-
-        assert len(mail.outbox) == 1
-        email = mail.outbox[0]
-        assert email.to == ["guest@example.com"]
-        email_content = " ".join(email.body.split())
-        assert f"{user.full_name} shared a document with you!" in email_content
-        assert (
-            f"{user.full_name} ({user.email}) invited you with the role "{invited}" "
-            f"on the following document: {document.title}"
-        ) in email_content
-        assert "My brand name" in email_content
-        assert "my-img.jpg" in email_content
-    else:
-        assert models.Invitation.objects.exists() is False
-
-    if response_code == 400:
-        assert response.json() == {
-            "role": [
-                "Only owners of a document can invite other users as owners.",
-            ],
-        }
-
-
-def test_api_document_invitations_create_email_from_content_language():
-    """
-    The email generated is from the language set in the Content-Language header
-    """
-    user = factories.UserFactory()
-    document = factories.DocumentFactory()
-    factories.UserDocumentAccessFactory(document=document, user=user, role="owner")
-
-    invitation_values = {
-        "email": "guest@example.com",
-        "role": "reader",
-    }
-
-    assert len(mail.outbox) == 0
-
-    client = APIClient()
-    client.force_login(user)
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/invitations/",
-        invitation_values,
-        format="json",
-        headers={"Content-Language": "fr-fr"},
-    )
-
-    assert response.status_code == 201
-    assert response.json()["email"] == "guest@example.com"
-    assert models.Invitation.objects.count() == 1
-    assert len(mail.outbox) == 1
-
-    email = mail.outbox[0]
-
-    assert email.to == ["guest@example.com"]
-
-    email_content = " ".join(email.body.split())
-    assert f"{user.full_name} a partagé un document avec vous!" in email_content
-
-
-def test_api_document_invitations_create_email_from_content_language_not_supported():
-    """
-    If the language from the Content-Language is not supported
-    it will display the default language, English.
-    """
-    user = factories.UserFactory()
-    document = factories.DocumentFactory()
-    factories.UserDocumentAccessFactory(document=document, user=user, role="owner")
-
-    invitation_values = {
-        "email": "guest@example.com",
-        "role": "reader",
-    }
-
-    assert len(mail.outbox) == 0
-
-    client = APIClient()
-    client.force_login(user)
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/invitations/",
-        invitation_values,
-        format="json",
-        headers={"Content-Language": "not-supported"},
-    )
-
-    assert response.status_code == 201
-    assert response.json()["email"] == "guest@example.com"
-    assert models.Invitation.objects.count() == 1
-    assert len(mail.outbox) == 1
-
-    email = mail.outbox[0]
-
-    assert email.to == ["guest@example.com"]
-
-    email_content = " ".join(email.body.split())
-    assert f"{user.full_name} shared a document with you!" in email_content
-
-
-def test_api_document_invitations_create_email_full_name_empty():
-    """
-    If the full name of the user is empty, it will display the email address.
-    """
-    user = factories.UserFactory(full_name="")
-    document = factories.DocumentFactory()
-    factories.UserDocumentAccessFactory(document=document, user=user, role="owner")
-
-    invitation_values = {
-        "email": "guest@example.com",
-        "role": "reader",
-    }
-
-    assert len(mail.outbox) == 0
-
-    client = APIClient()
-    client.force_login(user)
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/invitations/",
-        invitation_values,
-        format="json",
-        headers={"Content-Language": "not-supported"},
-    )
-
-    assert response.status_code == 201
-    assert response.json()["email"] == "guest@example.com"
-    assert models.Invitation.objects.count() == 1
-    assert len(mail.outbox) == 1
-
-    email = mail.outbox[0]
-
-    assert email.to == ["guest@example.com"]
-
-    email_content = " ".join(email.body.split())
-    assert f"{user.email} shared a document with you!" in email_content
-    assert (
-        f"{user.email.capitalize()} invited you with the role "reader" on the "
-        f"following document: {document.title}" in email_content
-    )
-
-
-def test_api_document_invitations_create_issuer_and_document_override():
-    """It should not be possible to set the "document" and "issuer" fields."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(users=[(user, "owner")])
-    other_document = factories.DocumentFactory(users=[(user, "owner")])
-    invitation_values = {
-        "document": str(other_document.id),
-        "issuer": str(factories.UserFactory().id),
-        "email": "guest@example.com",
-        "role": random.choice(models.RoleChoices.choices)[0],
-    }
-
-    client = APIClient()
-    client.force_login(user)
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/invitations/",
-        invitation_values,
-        format="json",
-    )
-
-    assert response.status_code == 201
-    # document and issuer automatically set
-    assert response.json()["document"] == str(document.id)
-    assert response.json()["issuer"] == str(user.id)
-
-
-def test_api_document_invitations_create_cannot_duplicate_invitation():
-    """An email should not be invited multiple times to the same document."""
-    existing_invitation = factories.InvitationFactory()
-    document = existing_invitation.document
-
-    # Grant privileged role on the Document to the user
-    user = factories.UserFactory()
-    models.DocumentAccess.objects.create(
-        document=document, user=user, role="administrator"
-    )
-
-    # Create a new invitation to the same document with the exact same email address
-    invitation_values = {
-        "email": existing_invitation.email,
-        "role": random.choice(["administrator", "editor", "reader"]),
-    }
-
-    client = APIClient()
-    client.force_login(user)
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/invitations/",
-        invitation_values,
-        format="json",
-    )
-
-    assert response.status_code == 400
-    assert response.json() == [
-        "Document invitation with this Email address and Document already exists."
-    ]
-
-
-def test_api_document_invitations_create_cannot_invite_existing_users():
-    """
-    It should not be possible to invite already existing users.
-    """
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(users=[(user, "owner")])
-    existing_user = factories.UserFactory()
-
-    # Build an invitation to the email of an exising identity in the db
-    invitation_values = {
-        "email": existing_user.email,
-        "role": random.choice(models.RoleChoices.choices)[0],
-    }
-
-    client = APIClient()
-    client.force_login(user)
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/invitations/",
-        invitation_values,
-        format="json",
-    )
-
-    assert response.status_code == 400
-    assert response.json() == ["This email is already associated to a registered user."]
-
-
-# Update
-
-
-@pytest.mark.parametrize("via", VIA)
-@pytest.mark.parametrize("role", ["administrator", "owner"])
-def test_api_document_invitations_update_authenticated_privileged_any_field_except_role(
-    role, via, mock_user_teams
-):
-    """
-    Authenticated user can update invitations if they are administrator or owner of the document.
-    """
-    user = factories.UserFactory()
-    invitation = factories.InvitationFactory()
-
-    if via == USER:
-        factories.UserDocumentAccessFactory(
-            document=invitation.document, user=user, role=role
-        )
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=invitation.document, team="lasuite", role=role
-        )
-
-    old_invitation_values = serializers.InvitationSerializer(instance=invitation).data
-    new_invitation_values = serializers.InvitationSerializer(
-        instance=factories.InvitationFactory()
-    ).data
-    # The update of a role is tested in the next test
-    del new_invitation_values["role"]
-
-    client = APIClient()
-    client.force_login(user)
-
-    url = (
-        f"/api/v1.0/documents/{invitation.document.id!s}/invitations/{invitation.id!s}/"
-    )
-    response = client.put(url, new_invitation_values, format="json")
-
-    assert response.status_code == 200
-
-    invitation.refresh_from_db()
-    invitation_values = serializers.InvitationSerializer(instance=invitation).data
-
-    for key, value in invitation_values.items():
-        if key == "email":
-            assert value == new_invitation_values[key]
-        elif key == "updated_at":
-            assert value > old_invitation_values[key]
-        else:
-            assert value == old_invitation_values[key]
-
-
-@pytest.mark.parametrize("via", VIA)
-@pytest.mark.parametrize("role_set", models.RoleChoices.values)
-@pytest.mark.parametrize("role", ["administrator", "owner"])
-def test_api_document_invitations_update_authenticated_privileged_role(
-    role, role_set, via, mock_user_teams
-):
-    """
-    Authenticated user can update invitations if they are administrator or owner of the document,
-    but only owners can set the invitation role to the "owner" role.
-    """
-    user = factories.UserFactory()
-    invitation = factories.InvitationFactory()
-    old_role = invitation.role
-
-    if via == USER:
-        factories.UserDocumentAccessFactory(
-            document=invitation.document, user=user, role=role
-        )
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=invitation.document, team="lasuite", role=role
-        )
-
-    new_invitation_values = serializers.InvitationSerializer(instance=invitation).data
-    new_invitation_values["role"] = role_set
-
-    client = APIClient()
-    client.force_login(user)
-
-    url = (
-        f"/api/v1.0/documents/{invitation.document.id!s}/invitations/{invitation.id!s}/"
-    )
-    response = client.put(url, new_invitation_values, format="json")
-
-    invitation.refresh_from_db()
-
-    if role_set == "owner" and role != "owner":
-        assert response.status_code == 400
-        assert invitation.role == old_role
-        assert response.json() == {
-            "role": [
-                "Only owners of a document can invite other users as owners.",
-            ],
-        }
-    else:
-        assert response.status_code == 200
-        assert invitation.role == role_set
-
-
-@pytest.mark.parametrize("via", VIA)
-@pytest.mark.parametrize("role", ["reader", "editor"])
-def test_api_document_invitations_update_authenticated_unprivileged(
-    role, via, mock_user_teams
-):
-    """
-    Authenticated user should not be allowed to update invitations if they are
-    simple reader or editor of the document.
-    """
-    user = factories.UserFactory()
-    invitation = factories.InvitationFactory()
-
-    if via == USER:
-        factories.UserDocumentAccessFactory(
-            document=invitation.document, user=user, role=role
-        )
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=invitation.document, team="lasuite", role=role
-        )
-
-    old_invitation_values = serializers.InvitationSerializer(instance=invitation).data
-    new_invitation_values = serializers.InvitationSerializer(
-        instance=factories.InvitationFactory()
-    ).data
-
-    client = APIClient()
-    client.force_login(user)
-
-    url = (
-        f"/api/v1.0/documents/{invitation.document.id!s}/invitations/{invitation.id!s}/"
-    )
-    response = client.put(url, new_invitation_values, format="json")
-
-    assert response.status_code == 403
-
-    invitation.refresh_from_db()
-    invitation_values = serializers.InvitationSerializer(instance=invitation).data
-
-    for key, value in invitation_values.items():
-        assert value == old_invitation_values[key]
-
-
-# Delete
-
-
-def test_api_document_invitations_delete_anonymous():
-    """Anonymous user should not be able to delete invitations."""
-    invitation = factories.InvitationFactory()
-
-    response = APIClient().delete(
-        f"/api/v1.0/documents/{invitation.document.id!s}/invitations/{invitation.id!s}/",
-    )
-    assert response.status_code == 401
-
-
-def test_api_document_invitations_delete_authenticated_outsider():
-    """Members unrelated to a document should not be allowed to cancel invitations."""
-    user = factories.UserFactory(with_owned_document=True)
-
-    document = factories.DocumentFactory()
-    invitation = factories.InvitationFactory(document=document)
-
-    client = APIClient()
-    client.force_login(user)
-
-    response = client.delete(
-        f"/api/v1.0/documents/{document.id!s}/invitations/{invitation.id!s}/",
-    )
-    assert response.status_code == 403
-
-
-@pytest.mark.parametrize("via", VIA)
-@pytest.mark.parametrize("role", ["owner", "administrator"])
-def test_api_document_invitations_delete_privileged_members(role, via, mock_user_teams):
-    """Privileged member should be able to cancel invitation."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory()
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role=role
-        )
-
-    invitation = factories.InvitationFactory(document=document)
-
-    client = APIClient()
-    client.force_login(user)
-
-    response = client.delete(
-        f"/api/v1.0/documents/{document.id!s}/invitations/{invitation.id!s}/",
-    )
-    assert response.status_code == 204
-
-
-@pytest.mark.parametrize("role", ["reader", "editor"])
-@pytest.mark.parametrize("via", VIA)
-def test_api_document_invitations_delete_readers_or_editors(via, role, mock_user_teams):
-    """Readers or editors should not be able to cancel invitation."""
-    user = factories.UserFactory(with_owned_document=True)
-    document = factories.DocumentFactory()
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role=role
-        )
-
-    invitation = factories.InvitationFactory(document=document)
-
-    client = APIClient()
-    client.force_login(user)
-
-    response = client.delete(
-        f"/api/v1.0/documents/{document.id!s}/invitations/{invitation.id!s}/",
-    )
-    assert response.status_code == 403
-    assert (
-        response.json()["detail"]
-        == "You do not have permission to perform this action."
-    )

src/backend/core/tests/documents/test_api_documents_ai_transform.py

@@ -1,346 +0,0 @@
-"""
-Test AI transform API endpoint for users in impress's core app.
-"""
-
-from unittest.mock import MagicMock, patch
-
-from django.core.cache import cache
-from django.test import override_settings
-
-import pytest
-from rest_framework.test import APIClient
-
-from core import factories
-from core.tests.conftest import TEAM, USER, VIA
-
-pytestmark = pytest.mark.django_db
-
-
-@pytest.fixture(autouse=True)
-def clear_cache():
-    """Fixture to clear the cache before each test."""
-    cache.clear()
-
-
-@pytest.fixture
-def ai_settings():
-    """Fixture to set AI settings."""
-    with override_settings(
-        AI_BASE_URL="http://example.com", AI_API_KEY="test-key", AI_MODEL="llama"
-    ):
-        yield
-
-
-@pytest.mark.parametrize(
-    "reach, role",
-    [
-        ("restricted", "reader"),
-        ("restricted", "editor"),
-        ("authenticated", "reader"),
-        ("authenticated", "editor"),
-        ("public", "reader"),
-    ],
-)
-def test_api_documents_ai_transform_anonymous_forbidden(reach, role):
-    """
-    Anonymous users should not be able to request AI transform if the link reach
-    and role don't allow it.
-    """
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-transform/"
-    response = APIClient().post(url, {"text": "hello", "action": "prompt"})
-
-    assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
-
-
-@pytest.mark.usefixtures("ai_settings")
-@patch("openai.resources.chat.completions.Completions.create")
-def test_api_documents_ai_transform_anonymous_success(mock_create):
-    """
-    Anonymous users should be able to request AI transform to a document
-    if the link reach and role permit it.
-    """
-    document = factories.DocumentFactory(link_reach="public", link_role="editor")
-
-    answer = '{"answer": "Salut"}'
-    mock_create.return_value = MagicMock(
-        choices=[MagicMock(message=MagicMock(content=answer))]
-    )
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-transform/"
-    response = APIClient().post(url, {"text": "Hello", "action": "summarize"})
-
-    assert response.status_code == 200
-    assert response.json() == {"answer": "Salut"}
-    mock_create.assert_called_once_with(
-        model="llama",
-        response_format={"type": "json_object"},
-        messages=[
-            {
-                "role": "system",
-                "content": (
-                    "Summarize the markdown text, preserving language and markdown formatting. "
-                    'Return JSON: {"answer": "your markdown summary"}. Do not provide any other '
-                    "information."
-                ),
-            },
-            {"role": "user", "content": '{"markdown_input": "Hello"}'},
-        ],
-    )
-
-
-@pytest.mark.parametrize(
-    "reach, role",
-    [
-        ("restricted", "reader"),
-        ("restricted", "editor"),
-        ("authenticated", "reader"),
-        ("public", "reader"),
-    ],
-)
-def test_api_documents_ai_transform_authenticated_forbidden(reach, role):
-    """
-    Users who are not related to a document can't request AI transform if the
-    link reach and role don't allow it.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-transform/"
-    response = client.post(url, {"text": "Hello", "action": "prompt"})
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-
-@pytest.mark.parametrize(
-    "reach, role",
-    [
-        ("authenticated", "editor"),
-        ("public", "editor"),
-    ],
-)
-@pytest.mark.usefixtures("ai_settings")
-@patch("openai.resources.chat.completions.Completions.create")
-def test_api_documents_ai_transform_authenticated_success(mock_create, reach, role):
-    """
-    Autenticated who are not related to a document should be able to request AI transform
-    if the link reach and role permit it.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
-
-    answer = '{"answer": "Salut"}'
-    mock_create.return_value = MagicMock(
-        choices=[MagicMock(message=MagicMock(content=answer))]
-    )
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-transform/"
-    response = client.post(url, {"text": "Hello", "action": "prompt"})
-
-    assert response.status_code == 200
-    assert response.json() == {"answer": "Salut"}
-    mock_create.assert_called_once_with(
-        model="llama",
-        response_format={"type": "json_object"},
-        messages=[
-            {
-                "role": "system",
-                "content": (
-                    'Answer the prompt in markdown format. Return JSON: {"answer": '
-                    '"Your markdown answer"}. Do not provide any other information.'
-                ),
-            },
-            {"role": "user", "content": '{"markdown_input": "Hello"}'},
-        ],
-    )
-
-
-@pytest.mark.parametrize("via", VIA)
-def test_api_documents_ai_transform_reader(via, mock_user_teams):
-    """
-    Users who are simple readers on a document should not be allowed to request AI transform.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_role="reader")
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user, role="reader")
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role="reader"
-        )
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-transform/"
-    response = client.post(url, {"text": "Hello", "action": "prompt"})
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-
-@pytest.mark.parametrize("role", ["editor", "administrator", "owner"])
-@pytest.mark.parametrize("via", VIA)
-@pytest.mark.usefixtures("ai_settings")
-@patch("openai.resources.chat.completions.Completions.create")
-def test_api_documents_ai_transform_success(mock_create, via, role, mock_user_teams):
-    """
-    Editors, administrators and owners of a document should be able to request AI transform.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory()
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role=role
-        )
-
-    answer = '{"answer": "Salut"}'
-    mock_create.return_value = MagicMock(
-        choices=[MagicMock(message=MagicMock(content=answer))]
-    )
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-transform/"
-    response = client.post(url, {"text": "Hello", "action": "prompt"})
-
-    assert response.status_code == 200
-    assert response.json() == {"answer": "Salut"}
-    mock_create.assert_called_once_with(
-        model="llama",
-        response_format={"type": "json_object"},
-        messages=[
-            {
-                "role": "system",
-                "content": (
-                    'Answer the prompt in markdown format. Return JSON: {"answer": '
-                    '"Your markdown answer"}. Do not provide any other information.'
-                ),
-            },
-            {"role": "user", "content": '{"markdown_input": "Hello"}'},
-        ],
-    )
-
-
-def test_api_documents_ai_transform_empty_text():
-    """The text should not be empty when requesting AI transform."""
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach="public", link_role="editor")
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-transform/"
-    response = client.post(url, {"text": " ", "action": "prompt"})
-
-    assert response.status_code == 400
-    assert response.json() == {"text": ["This field may not be blank."]}
-
-
-def test_api_documents_ai_transform_invalid_action():
-    """The action should valid when requesting AI transform."""
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach="public", link_role="editor")
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-transform/"
-    response = client.post(url, {"text": "Hello", "action": "invalid"})
-
-    assert response.status_code == 400
-    assert response.json() == {"action": ['"invalid" is not a valid choice.']}
-
-
-@override_settings(AI_DOCUMENT_RATE_THROTTLE_RATES={"minute": 3, "hour": 6, "day": 10})
-@pytest.mark.usefixtures("ai_settings")
-@patch("openai.resources.chat.completions.Completions.create")
-def test_api_documents_ai_transform_throttling_document(mock_create):
-    """
-    Throttling per document should be triggered on the AI transform endpoint.
-    For full throttle class test see: `test_api_utils_ai_document_rate_throttles`
-    """
-    client = APIClient()
-    document = factories.DocumentFactory(link_reach="public", link_role="editor")
-
-    answer = '{"answer": "Salut"}'
-    mock_create.return_value = MagicMock(
-        choices=[MagicMock(message=MagicMock(content=answer))]
-    )
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-transform/"
-    for _ in range(3):
-        user = factories.UserFactory()
-        client.force_login(user)
-        response = client.post(url, {"text": "Hello", "action": "summarize"})
-        assert response.status_code == 200
-        assert response.json() == {"answer": "Salut"}
-
-    user = factories.UserFactory()
-    client.force_login(user)
-    response = client.post(url, {"text": "Hello", "action": "summarize"})
-
-    assert response.status_code == 429
-    assert response.json() == {
-        "detail": "Request was throttled. Expected available in 60 seconds."
-    }
-
-
-@override_settings(AI_USER_RATE_THROTTLE_RATES={"minute": 3, "hour": 6, "day": 10})
-@pytest.mark.usefixtures("ai_settings")
-@patch("openai.resources.chat.completions.Completions.create")
-def test_api_documents_ai_transform_throttling_user(mock_create):
-    """
-    Throttling per user should be triggered on the AI transform endpoint.
-    For full throttle class test see: `test_api_utils_ai_user_rate_throttles`
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    answer = '{"answer": "Salut"}'
-    mock_create.return_value = MagicMock(
-        choices=[MagicMock(message=MagicMock(content=answer))]
-    )
-
-    for _ in range(3):
-        document = factories.DocumentFactory(link_reach="public", link_role="editor")
-        url = f"/api/v1.0/documents/{document.id!s}/ai-transform/"
-        response = client.post(url, {"text": "Hello", "action": "summarize"})
-        assert response.status_code == 200
-        assert response.json() == {"answer": "Salut"}
-
-    document = factories.DocumentFactory(link_reach="public", link_role="editor")
-    url = f"/api/v1.0/documents/{document.id!s}/ai-transform/"
-    response = client.post(url, {"text": "Hello", "action": "summarize"})
-
-    assert response.status_code == 429
-    assert response.json() == {
-        "detail": "Request was throttled. Expected available in 60 seconds."
-    }

src/backend/core/tests/documents/test_api_documents_ai_translate.py

@@ -1,370 +0,0 @@
-"""
-Test AI translate API endpoint for users in impress's core app.
-"""
-
-from unittest.mock import MagicMock, patch
-
-from django.core.cache import cache
-from django.test import override_settings
-
-import pytest
-from rest_framework.test import APIClient
-
-from core import factories
-from core.tests.conftest import TEAM, USER, VIA
-
-pytestmark = pytest.mark.django_db
-
-
-@pytest.fixture(autouse=True)
-def clear_cache():
-    """Fixture to clear the cache before each test."""
-    cache.clear()
-
-
-@pytest.fixture
-def ai_settings():
-    """Fixture to set AI settings."""
-    with override_settings(
-        AI_BASE_URL="http://example.com", AI_API_KEY="test-key", AI_MODEL="llama"
-    ):
-        yield
-
-
-def test_api_documents_ai_translate_viewset_options_metadata():
-    """The documents endpoint should give us the list of available languages."""
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory(link_reach="public", link_role="editor")
-
-    response = APIClient().options("/api/v1.0/documents/")
-
-    assert response.status_code == 200
-    metadata = response.json()
-    assert metadata["name"] == "Document List"
-    assert metadata["actions"]["POST"]["language"]["choices"][0] == {
-        "value": "af",
-        "display_name": "Afrikaans",
-    }
-
-
-@pytest.mark.parametrize(
-    "reach, role",
-    [
-        ("restricted", "reader"),
-        ("restricted", "editor"),
-        ("authenticated", "reader"),
-        ("authenticated", "editor"),
-        ("public", "reader"),
-    ],
-)
-def test_api_documents_ai_translate_anonymous_forbidden(reach, role):
-    """
-    Anonymous users should not be able to request AI translate if the link reach
-    and role don't allow it.
-    """
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-translate/"
-    response = APIClient().post(url, {"text": "hello", "language": "es"})
-
-    assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
-
-
-@pytest.mark.usefixtures("ai_settings")
-@patch("openai.resources.chat.completions.Completions.create")
-def test_api_documents_ai_translate_anonymous_success(mock_create):
-    """
-    Anonymous users should be able to request AI translate to a document
-    if the link reach and role permit it.
-    """
-    document = factories.DocumentFactory(link_reach="public", link_role="editor")
-
-    answer = '{"answer": "Salut"}'
-    mock_create.return_value = MagicMock(
-        choices=[MagicMock(message=MagicMock(content=answer))]
-    )
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-translate/"
-    response = APIClient().post(url, {"text": "Hello", "language": "es"})
-
-    assert response.status_code == 200
-    assert response.json() == {"answer": "Salut"}
-    mock_create.assert_called_once_with(
-        model="llama",
-        response_format={"type": "json_object"},
-        messages=[
-            {
-                "role": "system",
-                "content": (
-                    "Translate the markdown text to Spanish, preserving markdown formatting. "
-                    'Return JSON: {"answer": "your translated markdown text in Spanish"}. '
-                    "Do not provide any other information."
-                ),
-            },
-            {"role": "user", "content": '{"markdown_input": "Hello"}'},
-        ],
-    )
-
-
-@pytest.mark.parametrize(
-    "reach, role",
-    [
-        ("restricted", "reader"),
-        ("restricted", "editor"),
-        ("authenticated", "reader"),
-        ("public", "reader"),
-    ],
-)
-def test_api_documents_ai_translate_authenticated_forbidden(reach, role):
-    """
-    Users who are not related to a document can't request AI translate if the
-    link reach and role don't allow it.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-translate/"
-    response = client.post(url, {"text": "Hello", "language": "es"})
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-
-@pytest.mark.parametrize(
-    "reach, role",
-    [
-        ("authenticated", "editor"),
-        ("public", "editor"),
-    ],
-)
-@pytest.mark.usefixtures("ai_settings")
-@patch("openai.resources.chat.completions.Completions.create")
-def test_api_documents_ai_translate_authenticated_success(mock_create, reach, role):
-    """
-    Autenticated who are not related to a document should be able to request AI translate
-    if the link reach and role permit it.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
-
-    answer = '{"answer": "Salut"}'
-    mock_create.return_value = MagicMock(
-        choices=[MagicMock(message=MagicMock(content=answer))]
-    )
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-translate/"
-    response = client.post(url, {"text": "Hello", "language": "es-co"})
-
-    assert response.status_code == 200
-    assert response.json() == {"answer": "Salut"}
-    mock_create.assert_called_once_with(
-        model="llama",
-        response_format={"type": "json_object"},
-        messages=[
-            {
-                "role": "system",
-                "content": (
-                    "Translate the markdown text to Colombian Spanish, "
-                    "preserving markdown formatting. Return JSON: "
-                    '{"answer": "your translated markdown text in Colombian Spanish"}. '
-                    "Do not provide any other information."
-                ),
-            },
-            {"role": "user", "content": '{"markdown_input": "Hello"}'},
-        ],
-    )
-
-
-@pytest.mark.parametrize("via", VIA)
-def test_api_documents_ai_translate_reader(via, mock_user_teams):
-    """
-    Users who are simple readers on a document should not be allowed to request AI translate.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_role="reader")
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user, role="reader")
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role="reader"
-        )
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-translate/"
-    response = client.post(url, {"text": "Hello", "language": "es"})
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-
-@pytest.mark.parametrize("role", ["editor", "administrator", "owner"])
-@pytest.mark.parametrize("via", VIA)
-@pytest.mark.usefixtures("ai_settings")
-@patch("openai.resources.chat.completions.Completions.create")
-def test_api_documents_ai_translate_success(mock_create, via, role, mock_user_teams):
-    """
-    Editors, administrators and owners of a document should be able to request AI translate.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory()
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role=role
-        )
-
-    answer = '{"answer": "Salut"}'
-    mock_create.return_value = MagicMock(
-        choices=[MagicMock(message=MagicMock(content=answer))]
-    )
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-translate/"
-    response = client.post(url, {"text": "Hello", "language": "es-co"})
-
-    assert response.status_code == 200
-    assert response.json() == {"answer": "Salut"}
-    mock_create.assert_called_once_with(
-        model="llama",
-        response_format={"type": "json_object"},
-        messages=[
-            {
-                "role": "system",
-                "content": (
-                    "Translate the markdown text to Colombian Spanish, "
-                    "preserving markdown formatting. Return JSON: "
-                    '{"answer": "your translated markdown text in Colombian Spanish"}. '
-                    "Do not provide any other information."
-                ),
-            },
-            {"role": "user", "content": '{"markdown_input": "Hello"}'},
-        ],
-    )
-
-
-def test_api_documents_ai_translate_empty_text():
-    """The text should not be empty when requesting AI translate."""
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach="public", link_role="editor")
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-translate/"
-    response = client.post(url, {"text": " ", "language": "es"})
-
-    assert response.status_code == 400
-    assert response.json() == {"text": ["This field may not be blank."]}
-
-
-def test_api_documents_ai_translate_invalid_action():
-    """The action should valid when requesting AI translate."""
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach="public", link_role="editor")
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-translate/"
-    response = client.post(url, {"text": "Hello", "language": "invalid"})
-
-    assert response.status_code == 400
-    assert response.json() == {"language": ['"invalid" is not a valid choice.']}
-
-
-@override_settings(AI_DOCUMENT_RATE_THROTTLE_RATES={"minute": 3, "hour": 6, "day": 10})
-@pytest.mark.usefixtures("ai_settings")
-@patch("openai.resources.chat.completions.Completions.create")
-def test_api_documents_ai_translate_throttling_document(mock_create):
-    """
-    Throttling per document should be triggered on the AI translate endpoint.
-    For full throttle class test see: `test_api_utils_ai_document_rate_throttles`
-    """
-    client = APIClient()
-    document = factories.DocumentFactory(link_reach="public", link_role="editor")
-
-    answer = '{"answer": "Salut"}'
-    mock_create.return_value = MagicMock(
-        choices=[MagicMock(message=MagicMock(content=answer))]
-    )
-
-    url = f"/api/v1.0/documents/{document.id!s}/ai-translate/"
-    for _ in range(3):
-        user = factories.UserFactory()
-        client.force_login(user)
-        response = client.post(url, {"text": "Hello", "language": "es"})
-        assert response.status_code == 200
-        assert response.json() == {"answer": "Salut"}
-
-    user = factories.UserFactory()
-    client.force_login(user)
-    response = client.post(url, {"text": "Hello", "language": "es"})
-
-    assert response.status_code == 429
-    assert response.json() == {
-        "detail": "Request was throttled. Expected available in 60 seconds."
-    }
-
-
-@override_settings(AI_USER_RATE_THROTTLE_RATES={"minute": 3, "hour": 6, "day": 10})
-@pytest.mark.usefixtures("ai_settings")
-@patch("openai.resources.chat.completions.Completions.create")
-def test_api_documents_ai_translate_throttling_user(mock_create):
-    """
-    Throttling per user should be triggered on the AI translate endpoint.
-    For full throttle class test see: `test_api_utils_ai_user_rate_throttles`
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    answer = '{"answer": "Salut"}'
-    mock_create.return_value = MagicMock(
-        choices=[MagicMock(message=MagicMock(content=answer))]
-    )
-
-    for _ in range(3):
-        document = factories.DocumentFactory(link_reach="public", link_role="editor")
-        url = f"/api/v1.0/documents/{document.id!s}/ai-translate/"
-        response = client.post(url, {"text": "Hello", "language": "es"})
-        assert response.status_code == 200
-        assert response.json() == {"answer": "Salut"}
-
-    document = factories.DocumentFactory(link_reach="public", link_role="editor")
-    url = f"/api/v1.0/documents/{document.id!s}/ai-translate/"
-    response = client.post(url, {"text": "Hello", "language": "es"})
-
-    assert response.status_code == 429
-    assert response.json() == {
-        "detail": "Request was throttled. Expected available in 60 seconds."
-    }

src/backend/core/tests/documents/test_api_documents_attachment_upload.py

@@ -1,337 +0,0 @@
-"""
-Test file uploads API endpoint for users in impress's core app.
-"""
-
-import re
-import uuid
-
-from django.core.files.storage import default_storage
-from django.core.files.uploadedfile import SimpleUploadedFile
-
-import pytest
-from rest_framework.test import APIClient
-
-from core import factories
-from core.tests.conftest import TEAM, USER, VIA
-
-pytestmark = pytest.mark.django_db
-
-PIXEL = (
-    b"\x89PNG\r\n\x1a\n\x00\x00\x00\rIHDR\x00\x00\x00\x01\x00\x00\x00\x01\x08\x06\x00"
-    b"\x00\x00\x1f\x15\xc4\x89\x00\x00\x00\nIDATx\x9cc\xf8\xff\xff?\x00\x05\xfe\x02\xfe"
-    b"\xa7V\xbd\xfa\x00\x00\x00\x00IEND\xaeB`\x82"
-)
-
-
-@pytest.mark.parametrize(
-    "reach, role",
-    [
-        ("restricted", "reader"),
-        ("restricted", "editor"),
-        ("authenticated", "reader"),
-        ("authenticated", "editor"),
-        ("public", "reader"),
-    ],
-)
-def test_api_documents_attachment_upload_anonymous_forbidden(reach, role):
-    """
-    Anonymous users should not be able to upload attachments if the link reach
-    and role don't allow it.
-    """
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
-    file = SimpleUploadedFile(name="test.png", content=PIXEL, content_type="image/png")
-
-    url = f"/api/v1.0/documents/{document.id!s}/attachment-upload/"
-    response = APIClient().post(url, {"file": file}, format="multipart")
-
-    assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
-
-
-def test_api_documents_attachment_upload_anonymous_success():
-    """
-    Anonymous users should be able to upload attachments to a document
-    if the link reach and role permit it.
-    """
-    document = factories.DocumentFactory(link_reach="public", link_role="editor")
-    file = SimpleUploadedFile(name="test.png", content=PIXEL, content_type="image/png")
-
-    url = f"/api/v1.0/documents/{document.id!s}/attachment-upload/"
-    response = APIClient().post(url, {"file": file}, format="multipart")
-
-    assert response.status_code == 201
-
-    pattern = re.compile(rf"^/media/{document.id!s}/attachments/(.*)\.png")
-    match = pattern.search(response.json()["file"])
-    file_id = match.group(1)
-
-    # Validate that file_id is a valid UUID
-    uuid.UUID(file_id)
-
-
-@pytest.mark.parametrize(
-    "reach, role",
-    [
-        ("restricted", "reader"),
-        ("restricted", "editor"),
-        ("authenticated", "reader"),
-        ("public", "reader"),
-    ],
-)
-def test_api_documents_attachment_upload_authenticated_forbidden(reach, role):
-    """
-    Users who are not related to a document can't upload attachments if the
-    link reach and role don't allow it.
-    """
-    user = factories.UserFactory(with_owned_document=True)
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
-    file = SimpleUploadedFile(name="test.png", content=PIXEL, content_type="image/png")
-
-    url = f"/api/v1.0/documents/{document.id!s}/attachment-upload/"
-    response = client.post(url, {"file": file}, format="multipart")
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-
-@pytest.mark.parametrize(
-    "reach, role",
-    [
-        ("authenticated", "editor"),
-        ("public", "editor"),
-    ],
-)
-def test_api_documents_attachment_upload_authenticated_success(reach, role):
-    """
-    Autenticated who are not related to a document should be able to upload a file
-    if the link reach and role permit it.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
-    file = SimpleUploadedFile(name="test.png", content=PIXEL, content_type="image/png")
-
-    url = f"/api/v1.0/documents/{document.id!s}/attachment-upload/"
-    response = client.post(url, {"file": file}, format="multipart")
-
-    assert response.status_code == 201
-
-    pattern = re.compile(rf"^/media/{document.id!s}/attachments/(.*)\.png")
-    match = pattern.search(response.json()["file"])
-    file_id = match.group(1)
-
-    # Validate that file_id is a valid UUID
-    uuid.UUID(file_id)
-
-
-@pytest.mark.parametrize("via", VIA)
-def test_api_documents_attachment_upload_reader(via, mock_user_teams):
-    """
-    Users who are simple readers on a document should not be allowed to upload an attachment.
-    """
-    user = factories.UserFactory(with_owned_document=True)
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_role="reader")
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user, role="reader")
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role="reader"
-        )
-
-    file = SimpleUploadedFile(name="test.png", content=PIXEL, content_type="image/png")
-
-    url = f"/api/v1.0/documents/{document.id!s}/attachment-upload/"
-    response = client.post(url, {"file": file}, format="multipart")
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-
-@pytest.mark.parametrize("role", ["editor", "administrator", "owner"])
-@pytest.mark.parametrize("via", VIA)
-def test_api_documents_attachment_upload_success(via, role, mock_user_teams):
-    """
-    Editors, administrators and owners of a document should be able to upload an attachment.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory()
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role=role
-        )
-
-    file = SimpleUploadedFile(name="test.png", content=PIXEL, content_type="image/png")
-
-    url = f"/api/v1.0/documents/{document.id!s}/attachment-upload/"
-    response = client.post(url, {"file": file}, format="multipart")
-
-    assert response.status_code == 201
-
-    file_path = response.json()["file"]
-    pattern = re.compile(rf"^/media/{document.id!s}/attachments/(.*)\.png")
-    match = pattern.search(file_path)
-    file_id = match.group(1)
-
-    # Validate that file_id is a valid UUID
-    uuid.UUID(file_id)
-
-    # Now, check the metadata of the uploaded file
-    key = file_path.replace("/media", "")
-    file_head = default_storage.connection.meta.client.head_object(
-        Bucket=default_storage.bucket_name, Key=key
-    )
-    assert file_head["Metadata"] == {"owner": str(user.id)}
-
-
-def test_api_documents_attachment_upload_invalid(client):
-    """Attempt to upload without a file should return an explicit error."""
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(users=[(user, "owner")])
-    url = f"/api/v1.0/documents/{document.id!s}/attachment-upload/"
-
-    response = client.post(url, {}, format="multipart")
-
-    assert response.status_code == 400
-    assert response.json() == {"file": ["No file was submitted."]}
-
-
-def test_api_documents_attachment_upload_size_limit_exceeded(settings):
-    """The uploaded file should not exceeed the maximum size in settings."""
-    settings.DOCUMENT_IMAGE_MAX_SIZE = 1048576  # 1 MB for test
-
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(users=[(user, "owner")])
-    url = f"/api/v1.0/documents/{document.id!s}/attachment-upload/"
-
-    # Create a temporary file larger than the allowed size
-    file = SimpleUploadedFile(
-        name="test.txt", content=b"a" * (1048576 + 1), content_type="text/plain"
-    )
-
-    response = client.post(url, {"file": file}, format="multipart")
-
-    assert response.status_code == 400
-    assert response.json() == {"file": ["File size exceeds the maximum limit of 1 MB."]}
-
-
-@pytest.mark.parametrize(
-    "name,content,extension",
-    [
-        ("test.exe", b"text", "exe"),
-        ("test", b"text", "txt"),
-        ("test.aaaaaa", b"test", "txt"),
-        ("test.txt", PIXEL, "txt"),
-        ("test.py", b"#!/usr/bin/python", "py"),
-    ],
-)
-def test_api_documents_attachment_upload_fix_extension(name, content, extension):
-    """
-    A file with no extension or a wrong extension is accepted and the extension
-    is corrected in storage.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(users=[(user, "owner")])
-    url = f"/api/v1.0/documents/{document.id!s}/attachment-upload/"
-
-    file = SimpleUploadedFile(name=name, content=content)
-    response = client.post(url, {"file": file}, format="multipart")
-
-    assert response.status_code == 201
-
-    file_path = response.json()["file"]
-    pattern = re.compile(rf"^/media/{document.id!s}/attachments/(.*)\.{extension:s}")
-    match = pattern.search(file_path)
-    file_id = match.group(1)
-
-    # Validate that file_id is a valid UUID
-    uuid.UUID(file_id)
-
-    # Now, check the metadata of the uploaded file
-    key = file_path.replace("/media", "")
-    file_head = default_storage.connection.meta.client.head_object(
-        Bucket=default_storage.bucket_name, Key=key
-    )
-    assert file_head["Metadata"] == {"owner": str(user.id), "is_unsafe": "true"}
-
-
-def test_api_documents_attachment_upload_empty_file():
-    """An empty file should be rejected."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(users=[(user, "owner")])
-    url = f"/api/v1.0/documents/{document.id!s}/attachment-upload/"
-
-    file = SimpleUploadedFile(name="test.png", content=b"")
-    response = client.post(url, {"file": file}, format="multipart")
-
-    assert response.status_code == 400
-    assert response.json() == {"file": ["The submitted file is empty."]}
-
-
-def test_api_documents_attachment_upload_unsafe():
-    """A file with an unsafe mime type should be tagged as such."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(users=[(user, "owner")])
-    url = f"/api/v1.0/documents/{document.id!s}/attachment-upload/"
-
-    file = SimpleUploadedFile(
-        name="script.exe", content=b"\x4d\x5a\x90\x00\x03\x00\x00\x00"
-    )
-    response = client.post(url, {"file": file}, format="multipart")
-
-    assert response.status_code == 201
-
-    file_path = response.json()["file"]
-    pattern = re.compile(rf"^/media/{document.id!s}/attachments/(.*)\.exe")
-    match = pattern.search(file_path)
-    file_id = match.group(1)
-
-    # Validate that file_id is a valid UUID
-    uuid.UUID(file_id)
-
-    # Now, check the metadata of the uploaded file
-    key = file_path.replace("/media", "")
-    file_head = default_storage.connection.meta.client.head_object(
-        Bucket=default_storage.bucket_name, Key=key
-    )
-    assert file_head["Metadata"] == {"owner": str(user.id), "is_unsafe": "true"}

src/backend/core/tests/documents/test_api_documents_create.py

@@ -1,8 +1,7 @@
 """
 Tests for Documents API endpoint in impress's core app: create
 """
-
-from uuid import uuid4
+import uuid
 
 import pytest
 from rest_framework.test import APIClient
@@ -26,7 +25,7 @@ def test_api_documents_create_anonymous():
     assert not Document.objects.exists()
 
 
-def test_api_documents_create_authenticated_success():
+def test_api_documents_create_authenticated():
     """
     Authenticated users should be able to create documents and should automatically be declared
     as the owner of the newly created document.
@@ -47,68 +46,27 @@ def test_api_documents_create_authenticated_success():
     assert response.status_code == 201
     document = Document.objects.get()
     assert document.title == "my document"
-    assert document.link_reach == "restricted"
     assert document.accesses.filter(role="owner", user=user).exists()
 
 
-def test_api_documents_create_authenticated_title_null():
-    """It should be possible to create several documents with a null title."""
+def test_api_documents_create_with_id_from_payload():
+    """
+    We should be able to create a document with an ID from the payload.
+    """
     user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
-    factories.DocumentFactory(title=None)
-
-    response = client.post("/api/v1.0/documents/", {}, format="json")
-
-    assert response.status_code == 201
-    assert Document.objects.filter(title__isnull=True).count() == 2
-
-
-def test_api_documents_create_force_id_success():
-    """It should be possible to force the document ID when creating a document."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    forced_id = uuid4()
-
+    doc_id = uuid.uuid4()
     response = client.post(
         "/api/v1.0/documents/",
-        {
-            "id": str(forced_id),
-            "title": "my document",
-        },
+        {"title": "my document", "id": str(doc_id)},
         format="json",
     )
 
     assert response.status_code == 201
-    documents = Document.objects.all()
-    assert len(documents) == 1
-    assert documents[0].id == forced_id
-
-
-def test_api_documents_create_force_id_existing():
-    """
-    It should not be possible to use the ID of an existing document when forcing ID on creation.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory()
-
-    response = client.post(
-        "/api/v1.0/documents/",
-        {
-            "id": str(document.id),
-            "title": "my document",
-        },
-        format="json",
-    )
-
-    assert response.status_code == 400
-    assert response.json() == {
-        "id": ["A document with this ID already exists. You cannot override it."]
-    }
+    document = Document.objects.get()
+    assert document.title == "my document"
+    assert document.id == doc_id
+    assert document.accesses.filter(role="owner", user=user).exists()

src/backend/core/tests/documents/test_api_documents_create_for_owner.py

@@ -1,364 +0,0 @@
-"""
-Tests for Documents API endpoint in impress's core app: create
-"""
-
-# pylint: disable=W0621
-
-from unittest.mock import patch
-
-from django.core import mail
-from django.test import override_settings
-
-import pytest
-from rest_framework.test import APIClient
-
-from core import factories
-from core.models import Document, Invitation, User
-from core.services.converter_services import ConversionError, YdocConverter
-
-pytestmark = pytest.mark.django_db
-
-
-@pytest.fixture
-def mock_convert_markdown():
-    """Mock YdocConverter.convert_markdown to return a converted content."""
-    with patch.object(
-        YdocConverter,
-        "convert_markdown",
-        return_value="Converted document content",
-    ) as mock:
-        yield mock
-
-
-def test_api_documents_create_for_owner_missing_token():
-    """Requests with no token should not be allowed to create documents for owner."""
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": "john.doe@example.com",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/", data, format="json"
-    )
-
-    assert response.status_code == 401
-    assert not Document.objects.exists()
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_invalid_token():
-    """Requests with an invalid token should not be allowed to create documents for owner."""
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": "john.doe@example.com",
-        "language": "fr",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer InvalidToken",
-    )
-
-    assert response.status_code == 401
-    assert not Document.objects.exists()
-
-
-def test_api_documents_create_for_owner_authenticated_forbidden():
-    """
-    Authenticated users should not be allowed to call create documents on behalf of other users.
-    This API endpoint is reserved for server-to-server calls.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": "john.doe@example.com",
-    }
-
-    response = client.post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-    )
-
-    assert response.status_code == 401
-    assert not Document.objects.exists()
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_missing_sub():
-    """Requests with no sub should not be allowed to create documents for owner."""
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "email": "john.doe@example.com",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 400
-    assert not Document.objects.exists()
-
-    assert response.json() == {"sub": ["This field is required."]}
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_missing_email():
-    """Requests with no email should not be allowed to create documents for owner."""
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 400
-    assert not Document.objects.exists()
-
-    assert response.json() == {"email": ["This field is required."]}
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_invalid_sub():
-    """Requests with an invalid sub should not be allowed to create documents for owner."""
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123!!",
-        "email": "john.doe@example.com",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 400
-    assert not Document.objects.exists()
-
-    assert response.json() == {
-        "sub": [
-            "Enter a valid sub. This value may contain only letters, "
-            "numbers, and @/./+/-/_/: characters."
-        ]
-    }
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_existing(mock_convert_markdown):
-    """It should be possible to create a document on behalf of a pre-existing user."""
-    user = factories.UserFactory(language="en-us")
-
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": str(user.sub),
-        "email": "irrelevant@example.com",  # Should be ignored since the user already exists
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 201
-
-    mock_convert_markdown.assert_called_once_with("Document content")
-
-    document = Document.objects.get()
-    assert response.json() == {"id": str(document.id)}
-
-    assert document.title == "My Document"
-    assert document.content == "Converted document content"
-    assert document.creator == user
-    assert document.accesses.filter(user=user, role="owner").exists()
-
-    assert Invitation.objects.exists() is False
-
-    assert len(mail.outbox) == 1
-    email = mail.outbox[0]
-    assert email.to == [user.email]
-    assert email.subject == "A new document was created on your behalf!"
-    email_content = " ".join(email.body.split())
-    assert "A new document was created on your behalf!" in email_content
-    assert (
-        "You have been granted ownership of a new document: My Document"
-    ) in email_content
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_new_user(mock_convert_markdown):
-    """
-    It should be possible to create a document on behalf of new users by
-    passing only their email address.
-    """
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": "john.doe@example.com",  # Should be used to create a new user
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 201
-
-    mock_convert_markdown.assert_called_once_with("Document content")
-
-    document = Document.objects.get()
-    assert response.json() == {"id": str(document.id)}
-
-    assert document.title == "My Document"
-    assert document.content == "Converted document content"
-    assert document.creator is None
-    assert document.accesses.exists() is False
-
-    invitation = Invitation.objects.get()
-    assert invitation.email == "john.doe@example.com"
-    assert invitation.role == "owner"
-
-    assert len(mail.outbox) == 1
-    email = mail.outbox[0]
-    assert email.to == ["john.doe@example.com"]
-    assert email.subject == "A new document was created on your behalf!"
-    email_content = " ".join(email.body.split())
-    assert "A new document was created on your behalf!" in email_content
-    assert (
-        "You have been granted ownership of a new document: My Document"
-    ) in email_content
-
-    # The creator field on the document should be set when the user is created
-    user = User.objects.create(email="john.doe@example.com", password="!")
-    document.refresh_from_db()
-    assert document.creator == user
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_with_custom_language(mock_convert_markdown):
-    """
-    Test creating a document with a specific language.
-    Useful if the remote server knows the user's language.
-    """
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": "john.doe@example.com",
-        "language": "fr-fr",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 201
-
-    mock_convert_markdown.assert_called_once_with("Document content")
-
-    assert len(mail.outbox) == 1
-    email = mail.outbox[0]
-    assert email.to == ["john.doe@example.com"]
-    assert email.subject == "Un nouveau document a été créé pour vous !"
-    email_content = " ".join(email.body.split())
-    assert "Un nouveau document a été créé pour vous !" in email_content
-    assert (
-        "Vous avez été déclaré propriétaire d'un nouveau document : My Document"
-    ) in email_content
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_with_custom_subject_and_message(
-    mock_convert_markdown,
-):
-    """It should be possible to customize the subject and message of the invitation email."""
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": "john.doe@example.com",
-        "message": "mon message spécial",
-        "subject": "mon sujet spécial !",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 201
-
-    mock_convert_markdown.assert_called_once_with("Document content")
-
-    assert len(mail.outbox) == 1
-    email = mail.outbox[0]
-    assert email.to == ["john.doe@example.com"]
-    assert email.subject == "Mon sujet spécial !"
-    email_content = " ".join(email.body.split())
-    assert "Mon sujet spécial !" in email_content
-    assert "Mon message spécial" in email_content
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_with_converter_exception(
-    mock_convert_markdown,
-):
-    """It should be possible to customize the subject and message of the invitation email."""
-
-    mock_convert_markdown.side_effect = ConversionError("Conversion failed")
-
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": "john.doe@example.com",
-        "message": "mon message spécial",
-        "subject": "mon sujet spécial !",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    mock_convert_markdown.assert_called_once_with("Document content")
-
-    assert response.status_code == 500
-    assert response.json() == {"detail": "could not convert content"}

src/backend/core/tests/documents/test_api_documents_delete.py

@@ -1,6 +1,7 @@
 """
 Tests for Documents API endpoint in impress's core app: delete
 """
+import random
 
 import pytest
 from rest_framework.test import APIClient
@@ -23,36 +24,35 @@ def test_api_documents_delete_anonymous():
     assert models.Document.objects.count() == 1
 
 
-@pytest.mark.parametrize("reach", models.LinkReachChoices.values)
-@pytest.mark.parametrize("role", models.LinkRoleChoices.values)
-def test_api_documents_delete_authenticated_unrelated(reach, role):
+def test_api_documents_delete_authenticated_unrelated():
     """
-    Authenticated users should not be allowed to delete a document to which
-    they are not related.
+    Authenticated users should not be allowed to delete a document to which they are not
+    related.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
+    is_public = random.choice([True, False])
+    document = factories.DocumentFactory(is_public=is_public)
 
     response = client.delete(
         f"/api/v1.0/documents/{document.id!s}/",
     )
 
-    assert response.status_code == 403
-    assert models.Document.objects.count() == 2
+    assert response.status_code == 403 if is_public else 404
+    assert models.Document.objects.count() == 1
 
 
 @pytest.mark.parametrize("role", ["reader", "editor", "administrator"])
 @pytest.mark.parametrize("via", VIA)
-def test_api_documents_delete_authenticated_not_owner(via, role, mock_user_teams):
+def test_api_documents_delete_authenticated_not_owner(via, role, mock_user_get_teams):
     """
     Authenticated users should not be allowed to delete a document for which they are
     only a reader, editor or administrator.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -61,7 +61,7 @@ def test_api_documents_delete_authenticated_not_owner(via, role, mock_user_teams
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user, role=role)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role=role
         )
@@ -74,11 +74,11 @@ def test_api_documents_delete_authenticated_not_owner(via, role, mock_user_teams
     assert response.json() == {
         "detail": "You do not have permission to perform this action."
     }
-    assert models.Document.objects.count() == 2
+    assert models.Document.objects.count() == 1
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_documents_delete_authenticated_owner(via, mock_user_teams):
+def test_api_documents_delete_authenticated_owner(via, mock_user_get_teams):
     """
     Authenticated users should be able to delete a document they own.
     """
@@ -91,7 +91,7 @@ def test_api_documents_delete_authenticated_owner(via, mock_user_teams):
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user, role="owner")
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role="owner"
         )

src/backend/core/tests/documents/test_api_documents_favorite.py

@@ -1,308 +0,0 @@
-"""Test favorite document API endpoint for users in impress's core app."""
-
-import pytest
-from rest_framework.test import APIClient
-
-from core import factories, models
-
-pytestmark = pytest.mark.django_db
-
-
-@pytest.mark.parametrize(
-    "reach",
-    [
-        "restricted",
-        "authenticated",
-        "public",
-    ],
-)
-@pytest.mark.parametrize("method", ["post", "delete"])
-def test_api_document_favorite_anonymous_user(method, reach):
-    """Anonymous users should not be able to mark/unmark documents as favorites."""
-    document = factories.DocumentFactory(link_reach=reach)
-
-    response = getattr(APIClient(), method)(
-        f"/api/v1.0/documents/{document.id!s}/favorite/"
-    )
-
-    assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
-
-    # Verify in database
-    assert models.DocumentFavorite.objects.exists() is False
-
-
-@pytest.mark.parametrize(
-    "reach, has_role",
-    [
-        ["restricted", True],
-        ["authenticated", False],
-        ["authenticated", True],
-        ["public", False],
-        ["public", True],
-    ],
-)
-def test_api_document_favorite_authenticated_post_allowed(reach, has_role):
-    """Authenticated users should be able to mark a document as favorite using POST."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach=reach)
-    client = APIClient()
-    client.force_login(user)
-
-    if has_role:
-        models.DocumentAccess.objects.create(document=document, user=user)
-
-    # Mark as favorite
-    response = client.post(f"/api/v1.0/documents/{document.id!s}/favorite/")
-
-    assert response.status_code == 201
-    assert response.json() == {"detail": "Document marked as favorite"}
-
-    # Verify in database
-    assert models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-
-    # Verify document format
-    response = client.get(f"/api/v1.0/documents/{document.id!s}/")
-    assert response.json()["is_favorite"] is True
-
-
-def test_api_document_favorite_authenticated_post_forbidden():
-    """Authenticated users should be able to mark a document as favorite using POST."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach="restricted")
-    client = APIClient()
-    client.force_login(user)
-
-    # Try marking as favorite
-    response = client.post(f"/api/v1.0/documents/{document.id!s}/favorite/")
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-    # Verify in database
-    assert (
-        models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-        is False
-    )
-
-
-@pytest.mark.parametrize(
-    "reach, has_role",
-    [
-        ["restricted", True],
-        ["authenticated", False],
-        ["authenticated", True],
-        ["public", False],
-        ["public", True],
-    ],
-)
-def test_api_document_favorite_authenticated_post_already_favorited_allowed(
-    reach, has_role
-):
-    """POST should not create duplicate favorites if already marked."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach=reach, favorited_by=[user])
-    client = APIClient()
-    client.force_login(user)
-
-    if has_role:
-        models.DocumentAccess.objects.create(document=document, user=user)
-
-    # Try to mark as favorite again
-    response = client.post(f"/api/v1.0/documents/{document.id!s}/favorite/")
-
-    assert response.status_code == 200
-    assert response.json() == {"detail": "Document already marked as favorite"}
-
-    # Verify in database
-    assert models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-
-    # Verify document format
-    response = client.get(f"/api/v1.0/documents/{document.id!s}/")
-    assert response.json()["is_favorite"] is True
-
-
-def test_api_document_favorite_authenticated_post_already_favorited_forbidden():
-    """POST should not create duplicate favorites if already marked."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach="restricted", favorited_by=[user])
-    client = APIClient()
-    client.force_login(user)
-
-    # Try to mark as favorite again
-    response = client.post(f"/api/v1.0/documents/{document.id!s}/favorite/")
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-    # Verify in database
-    assert models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-
-
-@pytest.mark.parametrize(
-    "reach, has_role",
-    [
-        ["restricted", True],
-        ["authenticated", False],
-        ["authenticated", True],
-        ["public", False],
-        ["public", True],
-    ],
-)
-def test_api_document_favorite_authenticated_delete_allowed(reach, has_role):
-    """Authenticated users should be able to unmark a document as favorite using DELETE."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach=reach, favorited_by=[user])
-    client = APIClient()
-    client.force_login(user)
-
-    if has_role:
-        models.DocumentAccess.objects.create(document=document, user=user)
-
-    # Unmark as favorite
-    response = client.delete(f"/api/v1.0/documents/{document.id!s}/favorite/")
-    assert response.status_code == 204
-
-    # Verify in database
-    assert (
-        models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-        is False
-    )
-
-    # Verify document format
-    response = client.get(f"/api/v1.0/documents/{document.id!s}/")
-    assert response.json()["is_favorite"] is False
-
-
-def test_api_document_favorite_authenticated_delete_forbidden():
-    """Authenticated users should be able to unmark a document as favorite using DELETE."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach="restricted", favorited_by=[user])
-    client = APIClient()
-    client.force_login(user)
-
-    # Unmark as favorite
-    response = client.delete(f"/api/v1.0/documents/{document.id!s}/favorite/")
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-    # Verify in database
-    assert (
-        models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-        is True
-    )
-
-
-@pytest.mark.parametrize(
-    "reach, has_role",
-    [
-        ["restricted", True],
-        ["authenticated", False],
-        ["authenticated", True],
-        ["public", False],
-        ["public", True],
-    ],
-)
-def test_api_document_favorite_authenticated_delete_not_favorited_allowed(
-    reach, has_role
-):
-    """DELETE should be idempotent if the document is not marked as favorite."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach=reach)
-    client = APIClient()
-    client.force_login(user)
-
-    if has_role:
-        models.DocumentAccess.objects.create(document=document, user=user)
-
-    # Try to unmark as favorite when no favorite entry exists
-    response = client.delete(f"/api/v1.0/documents/{document.id!s}/favorite/")
-
-    assert response.status_code == 200
-    assert response.json() == {"detail": "Document was already not marked as favorite"}
-
-    # Verify in database
-    assert (
-        models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-        is False
-    )
-
-    # Verify document format
-    response = client.get(f"/api/v1.0/documents/{document.id!s}/")
-    assert response.json()["is_favorite"] is False
-
-
-def test_api_document_favorite_authenticated_delete_not_favorited_forbidden():
-    """DELETE should be idempotent if the document is not marked as favorite."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach="restricted")
-    client = APIClient()
-    client.force_login(user)
-
-    # Try to unmark as favorite when no favorite entry exists
-    response = client.delete(f"/api/v1.0/documents/{document.id!s}/favorite/")
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-    # Verify in database
-    assert (
-        models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-        is False
-    )
-
-
-@pytest.mark.parametrize(
-    "reach, has_role",
-    [
-        ["restricted", True],
-        ["authenticated", False],
-        ["authenticated", True],
-        ["public", False],
-        ["public", True],
-    ],
-)
-def test_api_document_favorite_authenticated_post_unmark_then_mark_again_allowed(
-    reach, has_role
-):
-    """A user should be able to mark, unmark, and mark a document again as favorite."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach=reach)
-    client = APIClient()
-    client.force_login(user)
-
-    if has_role:
-        models.DocumentAccess.objects.create(document=document, user=user)
-
-    url = f"/api/v1.0/documents/{document.id!s}/favorite/"
-
-    # Mark as favorite
-    response = client.post(url)
-    assert response.status_code == 201
-
-    # Unmark as favorite
-    response = client.delete(url)
-    assert response.status_code == 204
-
-    # Mark as favorite again
-    response = client.post(url)
-    assert response.status_code == 201
-    assert response.json() == {"detail": "Document marked as favorite"}
-
-    # Verify in database
-    assert models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-
-    # Verify document format
-    response = client.get(f"/api/v1.0/documents/{document.id!s}/")
-    assert response.json()["is_favorite"] is True

src/backend/core/tests/documents/test_api_documents_link_configuration.py

@@ -1,160 +0,0 @@
-"""Tests for link configuration of documents on API endpoint"""
-
-import pytest
-from rest_framework.test import APIClient
-
-from core import factories, models
-from core.api import serializers
-from core.tests.conftest import TEAM, USER, VIA
-from core.tests.test_services_collaboration_services import (  # pylint: disable=unused-import
-    mock_reset_connections,
-)
-
-pytestmark = pytest.mark.django_db
-
-
-@pytest.mark.parametrize("role", models.LinkRoleChoices.values)
-@pytest.mark.parametrize("reach", models.LinkReachChoices.values)
-def test_api_documents_link_configuration_update_anonymous(reach, role):
-    """Anonymous users should not be allowed to update a link configuration."""
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
-    old_document_values = serializers.LinkDocumentSerializer(instance=document).data
-
-    new_document_values = serializers.LinkDocumentSerializer(
-        instance=factories.DocumentFactory()
-    ).data
-    response = APIClient().put(
-        f"/api/v1.0/documents/{document.id!s}/link-configuration/",
-        new_document_values,
-        format="json",
-    )
-    assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
-
-    document.refresh_from_db()
-    document_values = serializers.LinkDocumentSerializer(instance=document).data
-    assert document_values == old_document_values
-
-
-@pytest.mark.parametrize("role", models.LinkRoleChoices.values)
-@pytest.mark.parametrize("reach", models.LinkReachChoices.values)
-def test_api_documents_link_configuration_update_authenticated_unrelated(reach, role):
-    """
-    Authenticated users should not be allowed to update the link configuration for
-    a document to which they are not related.
-    """
-    user = factories.UserFactory(with_owned_document=True)
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
-    old_document_values = serializers.LinkDocumentSerializer(instance=document).data
-
-    new_document_values = serializers.LinkDocumentSerializer(
-        instance=factories.DocumentFactory()
-    ).data
-    response = client.put(
-        f"/api/v1.0/documents/{document.id!s}/link-configuration/",
-        new_document_values,
-        format="json",
-    )
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-    document.refresh_from_db()
-    document_values = serializers.LinkDocumentSerializer(instance=document).data
-    assert document_values == old_document_values
-
-
-@pytest.mark.parametrize("role", ["editor", "reader"])
-@pytest.mark.parametrize("via", VIA)
-def test_api_documents_link_configuration_update_authenticated_related_forbidden(
-    via, role, mock_user_teams
-):
-    """
-    Users who are readers or editors of a document should not be allowed to update
-    the link configuration.
-    """
-    user = factories.UserFactory(with_owned_document=True)
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory()
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role=role
-        )
-
-    old_document_values = serializers.LinkDocumentSerializer(instance=document).data
-
-    new_document_values = serializers.LinkDocumentSerializer(
-        instance=factories.DocumentFactory()
-    ).data
-    response = client.put(
-        f"/api/v1.0/documents/{document.id!s}/link-configuration/",
-        new_document_values,
-        format="json",
-    )
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-    document.refresh_from_db()
-    document_values = serializers.LinkDocumentSerializer(instance=document).data
-    assert document_values == old_document_values
-
-
-@pytest.mark.parametrize("role", ["administrator", "owner"])
-@pytest.mark.parametrize("via", VIA)
-def test_api_documents_link_configuration_update_authenticated_related_success(
-    via,
-    role,
-    mock_user_teams,
-    mock_reset_connections,  # pylint: disable=redefined-outer-name
-):
-    """
-    A user who is administrator or owner of a document should be allowed to update
-    the link configuration.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory()
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(
-            document=document, team="lasuite", role=role
-        )
-
-    new_document_values = serializers.LinkDocumentSerializer(
-        instance=factories.DocumentFactory()
-    ).data
-
-    with mock_reset_connections(document.id):
-        response = client.put(
-            f"/api/v1.0/documents/{document.id!s}/link-configuration/",
-            new_document_values,
-            format="json",
-        )
-        assert response.status_code == 200
-
-        document = models.Document.objects.get(pk=document.pk)
-        document_values = serializers.LinkDocumentSerializer(instance=document).data
-        for key, value in document_values.items():
-            assert value == new_document_values[key]

src/backend/core/tests/documents/test_api_documents_list.py

@@ -1,115 +1,68 @@
 """
 Tests for Documents API endpoint in impress's core app: list
 """
-
-import operator
-import random
 from unittest import mock
-from urllib.parse import urlencode
 
 import pytest
 from faker import Faker
 from rest_framework.pagination import PageNumberPagination
+from rest_framework.status import HTTP_200_OK
 from rest_framework.test import APIClient
 
-from core import factories, models
+from core import factories
 
 fake = Faker()
 pytestmark = pytest.mark.django_db
 
 
-@pytest.mark.parametrize("role", models.LinkRoleChoices.values)
-@pytest.mark.parametrize("reach", models.LinkReachChoices.values)
-def test_api_documents_list_anonymous(reach, role):
-    """
-    Anonymous users should not be allowed to list documents whatever the
-    link reach and the role
-    """
-    factories.DocumentFactory(link_reach=reach, link_role=role)
+def test_api_documents_list_anonymous():
+    """Anonymous users should only be able to list public documents."""
+    factories.DocumentFactory.create_batch(2, is_public=False)
+    documents = factories.DocumentFactory.create_batch(2, is_public=True)
+    expected_ids = {str(document.id) for document in documents}
 
     response = APIClient().get("/api/v1.0/documents/")
 
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 0
-
-
-def test_api_documents_list_format():
-    """Validate the format of documents as returned by the list view."""
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    other_users = factories.UserFactory.create_batch(3)
-    document = factories.DocumentFactory(
-        users=[user, *factories.UserFactory.create_batch(2)],
-        favorited_by=[user, *other_users],
-        link_traces=other_users,
-    )
-
-    response = client.get("/api/v1.0/documents/")
-
-    assert response.status_code == 200
-    content = response.json()
-    results = content.pop("results")
-    assert content == {
-        "count": 1,
-        "next": None,
-        "previous": None,
-    }
-    assert len(results) == 1
-    assert results[0] == {
-        "id": str(document.id),
-        "abilities": document.get_abilities(user),
-        "content": document.content,
-        "created_at": document.created_at.isoformat().replace("+00:00", "Z"),
-        "creator": str(document.creator.id),
-        "is_favorite": True,
-        "link_reach": document.link_reach,
-        "link_role": document.link_role,
-        "nb_accesses": 3,
-        "title": document.title,
-        "updated_at": document.updated_at.isoformat().replace("+00:00", "Z"),
-    }
-
-
-def test_api_documents_list_authenticated_direct(django_assert_num_queries):
-    """
-    Authenticated users should be able to list documents they are a direct
-    owner/administrator/member of or documents that have a link reach other
-    than restricted.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    documents = [
-        access.document
-        for access in factories.UserDocumentAccessFactory.create_batch(2, user=user)
-    ]
-
-    # Unrelated and untraced documents
-    for reach in models.LinkReachChoices:
-        for role in models.LinkRoleChoices:
-            factories.DocumentFactory(link_reach=reach, link_role=role)
-
-    expected_ids = {str(document.id) for document in documents}
-
-    with django_assert_num_queries(3):
-        response = client.get("/api/v1.0/documents/")
-
-    assert response.status_code == 200
+    assert response.status_code == HTTP_200_OK
     results = response.json()["results"]
     assert len(results) == 2
     results_id = {result["id"] for result in results}
     assert expected_ids == results_id
 
 
-def test_api_documents_list_authenticated_via_team(
-    django_assert_num_queries, mock_user_teams
-):
+def test_api_documents_list_authenticated_direct():
+    """
+    Authenticated users should be able to list documents they are a direct
+    owner/administrator/member of.
+    """
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    related_documents = [
+        access.document
+        for access in factories.UserDocumentAccessFactory.create_batch(5, user=user)
+    ]
+    public_documents = factories.DocumentFactory.create_batch(2, is_public=True)
+    factories.DocumentFactory.create_batch(2, is_public=False)
+
+    expected_ids = {
+        str(document.id) for document in related_documents + public_documents
+    }
+
+    response = client.get(
+        "/api/v1.0/documents/",
+    )
+
+    assert response.status_code == HTTP_200_OK
+    results = response.json()["results"]
+    assert len(results) == 7
+    results_id = {result["id"] for result in results}
+    assert expected_ids == results_id
+
+
+def test_api_documents_list_authenticated_via_team(mock_user_get_teams):
     """
     Authenticated users should be able to list documents they are a
     owner/administrator/member of via a team.
@@ -119,7 +72,7 @@ def test_api_documents_list_authenticated_via_team(
     client = APIClient()
     client.force_login(user)
 
-    mock_user_teams.return_value = ["team1", "team2", "unknown"]
+    mock_user_get_teams.return_value = ["team1", "team2", "unknown"]
 
     documents_team1 = [
         access.document
@@ -129,78 +82,19 @@ def test_api_documents_list_authenticated_via_team(
         access.document
         for access in factories.TeamDocumentAccessFactory.create_batch(3, team="team2")
     ]
+    public_documents = factories.DocumentFactory.create_batch(2, is_public=True)
+    factories.DocumentFactory.create_batch(2, is_public=False)
 
-    expected_ids = {str(document.id) for document in documents_team1 + documents_team2}
+    expected_ids = {
+        str(document.id)
+        for document in documents_team1 + documents_team2 + public_documents
+    }
 
-    with django_assert_num_queries(3):
-        response = client.get("/api/v1.0/documents/")
+    response = client.get("/api/v1.0/documents/")
 
-    assert response.status_code == 200
+    assert response.status_code == HTTP_200_OK
     results = response.json()["results"]
-    assert len(results) == 5
-    results_id = {result["id"] for result in results}
-    assert expected_ids == results_id
-
-
-def test_api_documents_list_authenticated_link_reach_restricted(
-    django_assert_num_queries,
-):
-    """
-    An authenticated user who has link traces to a document that is restricted should not
-    see it on the list view
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_traces=[user], link_reach="restricted")
-
-    # Link traces for other documents or other users should not interfere
-    models.LinkTrace.objects.create(document=document, user=factories.UserFactory())
-    other_document = factories.DocumentFactory(link_reach="public")
-    models.LinkTrace.objects.create(document=other_document, user=user)
-
-    with django_assert_num_queries(3):
-        response = client.get(
-            "/api/v1.0/documents/",
-        )
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    # Only the other document is returned but not the restricted document even though the user
-    # visited it earlier (probably b/c it previously had public or authenticated reach...)
-    assert len(results) == 1
-    assert results[0]["id"] == str(other_document.id)
-
-
-def test_api_documents_list_authenticated_link_reach_public_or_authenticated(
-    django_assert_num_queries,
-):
-    """
-    An authenticated user who has link traces to a document with public or authenticated
-    link reach should see it on the list view.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    documents = [
-        factories.DocumentFactory(link_traces=[user], link_reach=reach)
-        for reach in models.LinkReachChoices
-        if reach != "restricted"
-    ]
-    expected_ids = {str(document.id) for document in documents}
-
-    with django_assert_num_queries(3):
-        response = client.get(
-            "/api/v1.0/documents/",
-        )
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 2
+    assert len(results) == 7
     results_id = {result["id"] for result in results}
     assert expected_ids == results_id
 
@@ -225,7 +119,7 @@ def test_api_documents_list_pagination(
         "/api/v1.0/documents/",
     )
 
-    assert response.status_code == 200
+    assert response.status_code == HTTP_200_OK
     content = response.json()
 
     assert content["count"] == 3
@@ -241,7 +135,7 @@ def test_api_documents_list_pagination(
         "/api/v1.0/documents/?page=2",
     )
 
-    assert response.status_code == 200
+    assert response.status_code == HTTP_200_OK
     content = response.json()
 
     assert content["count"] == 3
@@ -262,413 +156,204 @@ def test_api_documents_list_authenticated_distinct():
 
     other_user = factories.UserFactory()
 
-    document = factories.DocumentFactory(users=[user, other_user])
+    document = factories.DocumentFactory(users=[user, other_user], is_public=True)
+
+    response = client.get(
+        "/api/v1.0/documents/",
+    )
+
+    assert response.status_code == HTTP_200_OK
+    content = response.json()
+    assert len(content["results"]) == 1
+    assert content["results"][0]["id"] == str(document.id)
+
+
+def test_api_documents_order_created_at_desc():
+    """
+    Test that the endpoint GET documents is sorted in 'created_at' descending order by default.
+    """
+    user = factories.UserFactory()
+    client = APIClient()
+    client.force_login(user)
+
+    documents_created = [
+        document.created_at.isoformat().replace("+00:00", "Z")
+        for document in factories.DocumentFactory.create_batch(5, is_public=True)
+    ]
+
+    documents_created.sort(reverse=True)
 
     response = client.get(
         "/api/v1.0/documents/",
     )
 
     assert response.status_code == 200
-    content = response.json()
-    assert len(content["results"]) == 1
-    assert content["results"][0]["id"] == str(document.id)
 
-
-def test_api_documents_list_favorites_no_extra_queries(django_assert_num_queries):
-    """
-    Ensure that marking documents as favorite does not generate additional queries
-    when fetching the document list.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    special_documents = factories.DocumentFactory.create_batch(3, users=[user])
-    factories.DocumentFactory.create_batch(2, users=[user])
-
-    url = "/api/v1.0/documents/"
-    with django_assert_num_queries(3):
-        response = client.get(url)
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 5
-
-    assert all(result["is_favorite"] is False for result in results)
-
-    # Mark documents as favorite and check results again
-    for document in special_documents:
-        models.DocumentFavorite.objects.create(document=document, user=user)
-
-    with django_assert_num_queries(3):
-        response = client.get(url)
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 5
-
-    # Check if the "is_favorite" annotation is correctly set for the favorited documents
-    favorited_ids = {str(doc.id) for doc in special_documents}
-    for result in results:
-        if result["id"] in favorited_ids:
-            assert result["is_favorite"] is True
-        else:
-            assert result["is_favorite"] is False
-
-
-def test_api_documents_list_filter_and_access_rights():
-    """Filtering on querystring parameters should respect access rights."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    other_user = factories.UserFactory()
-
-    def random_favorited_by():
-        return random.choice([[], [user], [other_user]])
-
-    # Documents that should be listed to this user
-    listed_documents = [
-        factories.DocumentFactory(
-            link_reach="public",
-            link_traces=[user],
-            favorited_by=random_favorited_by(),
-            creator=random.choice([user, other_user]),
-        ),
-        factories.DocumentFactory(
-            link_reach="authenticated",
-            link_traces=[user],
-            favorited_by=random_favorited_by(),
-            creator=random.choice([user, other_user]),
-        ),
-        factories.DocumentFactory(
-            link_reach="restricted",
-            users=[user],
-            favorited_by=random_favorited_by(),
-            creator=random.choice([user, other_user]),
-        ),
+    response_data = response.json()
+    response_document_created = [
+        document["created_at"] for document in response_data["results"]
     ]
-    listed_ids = [str(doc.id) for doc in listed_documents]
-    word_list = [word for doc in listed_documents for word in doc.title.split(" ")]
 
-    # Documents that should not be listed to this user
-    factories.DocumentFactory(
-        link_reach="public",
-        favorited_by=random_favorited_by(),
-        creator=random.choice([user, other_user]),
-    )
-    factories.DocumentFactory(
-        link_reach="authenticated",
-        favorited_by=random_favorited_by(),
-        creator=random.choice([user, other_user]),
-    )
-    factories.DocumentFactory(
-        link_reach="restricted",
-        favorited_by=random_favorited_by(),
-        creator=random.choice([user, other_user]),
-    )
-    factories.DocumentFactory(
-        link_reach="restricted",
-        link_traces=[user],
-        favorited_by=random_favorited_by(),
-        creator=random.choice([user, other_user]),
-    )
-
-    filters = {
-        "link_reach": random.choice([None, *models.LinkReachChoices.values]),
-        "title": random.choice([None, *word_list]),
-        "favorite": random.choice([None, True, False]),
-        "creator": random.choice([None, user, other_user]),
-        "ordering": random.choice(
-            [
-                None,
-                "created_at",
-                "-created_at",
-                "is_favorite",
-                "-is_favorite",
-                "nb_accesses",
-                "-nb_accesses",
-                "title",
-                "-title",
-                "updated_at",
-                "-updated_at",
-            ]
-        ),
-    }
-    query_params = {key: value for key, value in filters.items() if value is not None}
-    querystring = urlencode(query_params)
-
-    response = client.get(f"/api/v1.0/documents/?{querystring:s}")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-
-    # Ensure all documents in results respect expected access rights
-    for result in results:
-        assert result["id"] in listed_ids
+    assert (
+        response_document_created == documents_created
+    ), "created_at values are not sorted from newest to oldest"
 
 
-# Filters: ordering
-
-
-def test_api_documents_list_ordering_default():
-    """Documents should be ordered by descending "updated_at" by default"""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(5, users=[user])
-
-    response = client.get("/api/v1.0/documents/")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 5
-
-    # Check that results are sorted by descending "updated_at" as expected
-    for i in range(4):
-        assert operator.ge(results[i]["updated_at"], results[i + 1]["updated_at"])
-
-
-def test_api_documents_list_ordering_by_fields():
-    """It should be possible to order by several fields"""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(5, users=[user])
-
-    for parameter in [
-        "created_at",
-        "-created_at",
-        "is_favorite",
-        "-is_favorite",
-        "nb_accesses",
-        "-nb_accesses",
-        "title",
-        "-title",
-        "updated_at",
-        "-updated_at",
-    ]:
-        is_descending = parameter.startswith("-")
-        field = parameter.lstrip("-")
-        querystring = f"?ordering={parameter}"
-
-        response = client.get(f"/api/v1.0/documents/{querystring:s}")
-        assert response.status_code == 200
-        results = response.json()["results"]
-        assert len(results) == 5
-
-        # Check that results are sorted by the field in querystring as expected
-        compare = operator.ge if is_descending else operator.le
-        for i in range(4):
-            assert compare(results[i][field], results[i + 1][field])
-
-
-# Filters: is_creator_me
-
-
-def test_api_documents_list_filter_is_creator_me_true():
+def test_api_documents_order_created_at_asc():
     """
-    Authenticated users should be able to filter documents they created.
+    Test that the 'created_at' field is sorted in ascending order
+    when the 'ordering' query parameter is set.
     """
     user = factories.UserFactory()
     client = APIClient()
     client.force_login(user)
 
-    factories.DocumentFactory.create_batch(3, users=[user], creator=user)
-    factories.DocumentFactory.create_batch(2, users=[user])
-
-    response = client.get("/api/v1.0/documents/?is_creator_me=true")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 3
-
-    # Ensure all results are created by the current user
-    for result in results:
-        assert result["creator"] == str(user.id)
-
-
-def test_api_documents_list_filter_is_creator_me_false():
-    """
-    Authenticated users should be able to filter documents created by others.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(3, users=[user], creator=user)
-    factories.DocumentFactory.create_batch(2, users=[user])
-
-    response = client.get("/api/v1.0/documents/?is_creator_me=false")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 2
-
-    # Ensure all results are created by other users
-    for result in results:
-        assert result["creator"] != str(user.id)
-
-
-def test_api_documents_list_filter_is_creator_me_invalid():
-    """Filtering with an invalid `is_creator_me` value should do nothing."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(3, users=[user], creator=user)
-    factories.DocumentFactory.create_batch(2, users=[user])
-
-    response = client.get("/api/v1.0/documents/?is_creator_me=invalid")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 5
-
-
-# Filters: is_favorite
-
-
-def test_api_documents_list_filter_is_favorite_true():
-    """
-    Authenticated users should be able to filter documents they marked as favorite.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(3, users=[user], favorited_by=[user])
-    factories.DocumentFactory.create_batch(2, users=[user])
-
-    response = client.get("/api/v1.0/documents/?is_favorite=true")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 3
-
-    # Ensure all results are marked as favorite by the current user
-    for result in results:
-        assert result["is_favorite"] is True
-
-
-def test_api_documents_list_filter_is_favorite_false():
-    """
-    Authenticated users should be able to filter documents they didn't mark as favorite.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(3, users=[user], favorited_by=[user])
-    factories.DocumentFactory.create_batch(2, users=[user])
-
-    response = client.get("/api/v1.0/documents/?is_favorite=false")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 2
-
-    # Ensure all results are not marked as favorite by the current user
-    for result in results:
-        assert result["is_favorite"] is False
-
-
-def test_api_documents_list_filter_is_favorite_invalid():
-    """Filtering with an invalid `is_favorite` value should do nothing."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(3, users=[user], favorited_by=[user])
-    factories.DocumentFactory.create_batch(2, users=[user])
-
-    response = client.get("/api/v1.0/documents/?is_favorite=invalid")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 5
-
-
-# Filters: link_reach
-
-
-@pytest.mark.parametrize("reach", models.LinkReachChoices.values)
-def test_api_documents_list_filter_link_reach(reach):
-    """Authenticated users should be able to filter documents by link reach."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(5, users=[user])
-
-    response = client.get(f"/api/v1.0/documents/?link_reach={reach:s}")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-
-    # Ensure all results have the chosen link reach
-    for result in results:
-        assert result["link_reach"] == reach
-
-
-def test_api_documents_list_filter_link_reach_invalid():
-    """Filtering with an invalid `link_reach` value should raise an error."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(3, users=[user])
-
-    response = client.get("/api/v1.0/documents/?link_reach=invalid")
-
-    assert response.status_code == 400
-    assert response.json() == {
-        "link_reach": [
-            "Select a valid choice. invalid is not one of the available choices."
-        ]
-    }
-
-
-# Filters: title
-
-
-@pytest.mark.parametrize(
-    "query,nb_results",
-    [
-        ("Project Alpha", 1),  # Exact match
-        ("project", 2),  # Partial match (case-insensitive)
-        ("Guide", 1),  # Word match within a title
-        ("Special", 0),  # No match (nonexistent keyword)
-        ("2024", 2),  # Match by numeric keyword
-        ("", 5),  # Empty string
-    ],
-)
-def test_api_documents_list_filter_title(query, nb_results):
-    """Authenticated users should be able to search documents by their title."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    # Create documents with predefined titles
-    titles = [
-        "Project Alpha Documentation",
-        "Project Beta Overview",
-        "User Guide",
-        "Financial Report 2024",
-        "Annual Review 2024",
+    documents_created = [
+        document.created_at.isoformat().replace("+00:00", "Z")
+        for document in factories.DocumentFactory.create_batch(5, is_public=True)
     ]
-    for title in titles:
-        factories.DocumentFactory(title=title, users=[user])
 
-    # Perform the search query
-    response = client.get(f"/api/v1.0/documents/?title={query:s}")
+    documents_created.sort()
+
+    response = client.get(
+        "/api/v1.0/documents/?ordering=created_at",
+    )
 
     assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == nb_results
 
-    # Ensure all results contain the query in their title
-    for result in results:
-        assert query.lower().strip() in result["title"].lower()
+    response_data = response.json()
+    response_document_created = [
+        document["created_at"] for document in response_data["results"]
+    ]
+
+    assert (
+        response_document_created == documents_created
+    ), "created_at values are not sorted from oldest to newest"
+
+
+def test_api_documents_order_updated_at_desc():
+    """
+    Test that the 'updated_at' field is sorted in descending order
+    when the 'ordering' query parameter is set.
+    """
+    user = factories.UserFactory()
+    client = APIClient()
+    client.force_login(user)
+
+    documents_updated = [
+        document.updated_at.isoformat().replace("+00:00", "Z")
+        for document in factories.DocumentFactory.create_batch(5, is_public=True)
+    ]
+
+    documents_updated.sort(reverse=True)
+
+    response = APIClient().get(
+        "/api/v1.0/documents/?ordering=-updated_at",
+    )
+    assert response.status_code == 200
+
+    response_data = response.json()
+
+    response_document_updated = [
+        document["updated_at"] for document in response_data["results"]
+    ]
+
+    assert (
+        response_document_updated == documents_updated
+    ), "updated_at values are not sorted from newest to oldest"
+
+
+def test_api_documents_order_updated_at_asc():
+    """
+    Test that the 'updated_at' field is sorted in ascending order
+    when the 'ordering' query parameter is set.
+    """
+    user = factories.UserFactory()
+    client = APIClient()
+    client.force_login(user)
+
+    documents_updated = [
+        document.updated_at.isoformat().replace("+00:00", "Z")
+        for document in factories.DocumentFactory.create_batch(5, is_public=True)
+    ]
+
+    documents_updated.sort()
+
+    response = APIClient().get(
+        "/api/v1.0/documents/?ordering=updated_at",
+    )
+    assert response.status_code == 200
+
+    response_data = response.json()
+
+    response_document_updated = [
+        document["updated_at"] for document in response_data["results"]
+    ]
+
+    assert (
+        response_document_updated == documents_updated
+    ), "updated_at values are not sorted from oldest to newest"
+
+
+def test_api_documents_order_title_desc():
+    """
+    Test that the 'title' field is sorted in descending order
+    when the 'ordering' query parameter is set.
+    """
+    user = factories.UserFactory()
+    client = APIClient()
+    client.force_login(user)
+
+    documents_title = [
+        factories.DocumentFactory(is_public=True, title=fake.sentence(nb_words=4)).title
+        for _ in range(5)
+    ]
+
+    documents_title.sort(reverse=True)
+
+    response = APIClient().get(
+        "/api/v1.0/documents/?ordering=-title",
+    )
+    assert response.status_code == 200
+
+    response_data = response.json()
+
+    response_documents_title = [
+        document["title"] for document in response_data["results"]
+    ]
+
+    assert (
+        response_documents_title == documents_title
+    ), "title values are not sorted descending"
+
+
+def test_api_documents_order_title_asc():
+    """
+    Test that the 'title' field is sorted in ascending order
+    when the 'ordering' query parameter is set.
+    """
+    user = factories.UserFactory()
+    client = APIClient()
+    client.force_login(user)
+
+    documents_title = [
+        factories.DocumentFactory(is_public=True, title=fake.sentence(nb_words=4)).title
+        for _ in range(5)
+    ]
+
+    documents_title.sort()
+
+    response = APIClient().get(
+        "/api/v1.0/documents/?ordering=title",
+    )
+    assert response.status_code == 200
+
+    response_data = response.json()
+
+    response_documents_title = [
+        document["title"] for document in response_data["results"]
+    ]
+
+    assert (
+        response_documents_title == documents_title
+    ), "title values are not sorted ascending"

src/backend/core/tests/documents/test_api_documents_media_auth.py

@@ -1,214 +0,0 @@
-"""
-Test file uploads API endpoint for users in impress's core app.
-"""
-
-import uuid
-from io import BytesIO
-from urllib.parse import urlparse
-
-from django.conf import settings
-from django.core.files.storage import default_storage
-from django.utils import timezone
-
-import pytest
-import requests
-from rest_framework.test import APIClient
-
-from core import factories
-from core.tests.conftest import TEAM, USER, VIA
-
-pytestmark = pytest.mark.django_db
-
-
-def test_api_documents_media_auth_anonymous_public():
-    """Anonymous users should be able to retrieve attachments linked to a public document"""
-    document = factories.DocumentFactory(link_reach="public")
-
-    filename = f"{uuid.uuid4()!s}.jpg"
-    key = f"{document.pk!s}/attachments/{filename:s}"
-
-    default_storage.connection.meta.client.put_object(
-        Bucket=default_storage.bucket_name,
-        Key=key,
-        Body=BytesIO(b"my prose"),
-        ContentType="text/plain",
-    )
-
-    original_url = f"http://localhost/media/{key:s}"
-    response = APIClient().get(
-        "/api/v1.0/documents/media-auth/", HTTP_X_ORIGINAL_URL=original_url
-    )
-
-    assert response.status_code == 200
-
-    authorization = response["Authorization"]
-    assert "AWS4-HMAC-SHA256 Credential=" in authorization
-    assert (
-        "SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature="
-        in authorization
-    )
-    assert response["X-Amz-Date"] == timezone.now().strftime("%Y%m%dT%H%M%SZ")
-
-    s3_url = urlparse(settings.AWS_S3_ENDPOINT_URL)
-    file_url = f"{settings.AWS_S3_ENDPOINT_URL:s}/impress-media-storage/{key:s}"
-    response = requests.get(
-        file_url,
-        headers={
-            "authorization": authorization,
-            "x-amz-date": response["x-amz-date"],
-            "x-amz-content-sha256": response["x-amz-content-sha256"],
-            "Host": f"{s3_url.hostname:s}:{s3_url.port:d}",
-        },
-        timeout=1,
-    )
-    assert response.content.decode("utf-8") == "my prose"
-
-
-@pytest.mark.parametrize("reach", ["authenticated", "restricted"])
-def test_api_documents_media_auth_anonymous_authenticated_or_restricted(reach):
-    """
-    Anonymous users should not be allowed to retrieve attachments linked to a document
-    with link reach set to authenticated or restricted.
-    """
-    document = factories.DocumentFactory(link_reach=reach)
-
-    filename = f"{uuid.uuid4()!s}.jpg"
-    media_url = f"http://localhost/media/{document.pk!s}/attachments/{filename:s}"
-
-    response = APIClient().get(
-        "/api/v1.0/documents/media-auth/", HTTP_X_ORIGINAL_URL=media_url
-    )
-
-    assert response.status_code == 403
-    assert "Authorization" not in response
-
-
-@pytest.mark.parametrize("reach", ["public", "authenticated"])
-def test_api_documents_media_auth_authenticated_public_or_authenticated(reach):
-    """
-    Authenticated users who are not related to a document should be able to retrieve
-    attachments related to a document with public or authenticated link reach.
-    """
-    document = factories.DocumentFactory(link_reach=reach)
-
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    filename = f"{uuid.uuid4()!s}.jpg"
-    key = f"{document.pk!s}/attachments/{filename:s}"
-
-    default_storage.connection.meta.client.put_object(
-        Bucket=default_storage.bucket_name,
-        Key=key,
-        Body=BytesIO(b"my prose"),
-        ContentType="text/plain",
-    )
-
-    original_url = f"http://localhost/media/{key:s}"
-    response = client.get(
-        "/api/v1.0/documents/media-auth/", HTTP_X_ORIGINAL_URL=original_url
-    )
-
-    assert response.status_code == 200
-
-    authorization = response["Authorization"]
-    assert "AWS4-HMAC-SHA256 Credential=" in authorization
-    assert (
-        "SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature="
-        in authorization
-    )
-    assert response["X-Amz-Date"] == timezone.now().strftime("%Y%m%dT%H%M%SZ")
-
-    s3_url = urlparse(settings.AWS_S3_ENDPOINT_URL)
-    file_url = f"{settings.AWS_S3_ENDPOINT_URL:s}/impress-media-storage/{key:s}"
-    response = requests.get(
-        file_url,
-        headers={
-            "authorization": authorization,
-            "x-amz-date": response["x-amz-date"],
-            "x-amz-content-sha256": response["x-amz-content-sha256"],
-            "Host": f"{s3_url.hostname:s}:{s3_url.port:d}",
-        },
-        timeout=1,
-    )
-    assert response.content.decode("utf-8") == "my prose"
-
-
-def test_api_documents_media_auth_authenticated_restricted():
-    """
-    Authenticated users who are not related to a document should not be allowed to
-    retrieve attachments linked to a document that is restricted.
-    """
-    document = factories.DocumentFactory(link_reach="restricted")
-
-    user = factories.UserFactory(with_owned_document=True)
-    client = APIClient()
-    client.force_login(user)
-
-    filename = f"{uuid.uuid4()!s}.jpg"
-    media_url = f"http://localhost/media/{document.pk!s}/attachments/{filename:s}"
-
-    response = client.get(
-        "/api/v1.0/documents/media-auth/", HTTP_X_ORIGINAL_URL=media_url
-    )
-
-    assert response.status_code == 403
-    assert "Authorization" not in response
-
-
-@pytest.mark.parametrize("via", VIA)
-def test_api_documents_media_auth_related(via, mock_user_teams):
-    """
-    Users who have a specific access to a document, whatever the role, should be able to
-    retrieve related attachments.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory()
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=document, user=user)
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(document=document, team="lasuite")
-
-    filename = f"{uuid.uuid4()!s}.jpg"
-    key = f"{document.pk!s}/attachments/{filename:s}"
-
-    default_storage.connection.meta.client.put_object(
-        Bucket=default_storage.bucket_name,
-        Key=key,
-        Body=BytesIO(b"my prose"),
-        ContentType="text/plain",
-    )
-
-    original_url = f"http://localhost/media/{key:s}"
-    response = client.get(
-        "/api/v1.0/documents/media-auth/", HTTP_X_ORIGINAL_URL=original_url
-    )
-
-    assert response.status_code == 200
-
-    authorization = response["Authorization"]
-    assert "AWS4-HMAC-SHA256 Credential=" in authorization
-    assert (
-        "SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature="
-        in authorization
-    )
-    assert response["X-Amz-Date"] == timezone.now().strftime("%Y%m%dT%H%M%SZ")
-
-    s3_url = urlparse(settings.AWS_S3_ENDPOINT_URL)
-    file_url = f"{settings.AWS_S3_ENDPOINT_URL:s}/impress-media-storage/{key:s}"
-    response = requests.get(
-        file_url,
-        headers={
-            "authorization": authorization,
-            "x-amz-date": response["x-amz-date"],
-            "x-amz-content-sha256": response["x-amz-content-sha256"],
-            "Host": f"{s3_url.hostname:s}:{s3_url.port:d}",
-        },
-        timeout=1,
-    )
-    assert response.content.decode("utf-8") == "my prose"

src/backend/core/tests/documents/test_api_documents_retrieve.py

@@ -1,11 +1,10 @@
 """
 Tests for Documents API endpoint in impress's core app: retrieve
 """
-
 import pytest
 from rest_framework.test import APIClient
 
-from core import factories, models
+from core import factories
 from core.api import serializers
 
 pytestmark = pytest.mark.django_db
@@ -13,7 +12,7 @@ pytestmark = pytest.mark.django_db
 
 def test_api_documents_retrieve_anonymous_public():
     """Anonymous users should be allowed to retrieve public documents."""
-    document = factories.DocumentFactory(link_reach="public")
+    document = factories.DocumentFactory(is_public=True)
 
     response = APIClient().get(f"/api/v1.0/documents/{document.id!s}/")
 
@@ -21,52 +20,35 @@ def test_api_documents_retrieve_anonymous_public():
     assert response.json() == {
         "id": str(document.id),
         "abilities": {
-            "accesses_manage": False,
-            "accesses_view": False,
-            "ai_transform": document.link_role == "editor",
-            "ai_translate": document.link_role == "editor",
-            "attachment_upload": document.link_role == "editor",
-            "collaboration_auth": True,
             "destroy": False,
-            # Anonymous user can't favorite a document even with read access
-            "favorite": False,
-            "invite_owner": False,
-            "link_configuration": False,
-            "media_auth": True,
-            "partial_update": document.link_role == "editor",
+            "manage_accesses": False,
+            "partial_update": False,
             "retrieve": True,
-            "update": document.link_role == "editor",
+            "update": False,
             "versions_destroy": False,
             "versions_list": False,
             "versions_retrieve": False,
         },
+        "accesses": [],
+        "title": document.title,
+        "is_public": True,
         "content": document.content,
         "created_at": document.created_at.isoformat().replace("+00:00", "Z"),
-        "creator": str(document.creator.id),
-        "is_favorite": False,
-        "link_reach": "public",
-        "link_role": document.link_role,
-        "nb_accesses": 0,
-        "title": document.title,
         "updated_at": document.updated_at.isoformat().replace("+00:00", "Z"),
     }
 
 
-@pytest.mark.parametrize("reach", ["restricted", "authenticated"])
-def test_api_documents_retrieve_anonymous_restricted_or_authenticated(reach):
+def test_api_documents_retrieve_anonymous_not_public():
     """Anonymous users should not be able to retrieve a document that is not public."""
-    document = factories.DocumentFactory(link_reach=reach)
+    document = factories.DocumentFactory(is_public=False)
 
     response = APIClient().get(f"/api/v1.0/documents/{document.id!s}/")
 
-    assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
+    assert response.status_code == 404
+    assert response.json() == {"detail": "Not found."}
 
 
-@pytest.mark.parametrize("reach", ["public", "authenticated"])
-def test_api_documents_retrieve_authenticated_unrelated_public_or_authenticated(reach):
+def test_api_documents_retrieve_authenticated_unrelated_public():
     """
     Authenticated users should be able to retrieve a public document to which they are
     not related.
@@ -76,7 +58,7 @@ def test_api_documents_retrieve_authenticated_unrelated_public_or_authenticated(
     client = APIClient()
     client.force_login(user)
 
-    document = factories.DocumentFactory(link_reach=reach)
+    document = factories.DocumentFactory(is_public=True)
 
     response = client.get(
         f"/api/v1.0/documents/{document.id!s}/",
@@ -85,87 +67,41 @@ def test_api_documents_retrieve_authenticated_unrelated_public_or_authenticated(
     assert response.json() == {
         "id": str(document.id),
         "abilities": {
-            "accesses_manage": False,
-            "accesses_view": False,
-            "ai_transform": document.link_role == "editor",
-            "ai_translate": document.link_role == "editor",
-            "attachment_upload": document.link_role == "editor",
-            "collaboration_auth": True,
             "destroy": False,
-            "favorite": True,
-            "invite_owner": False,
-            "media_auth": True,
-            "link_configuration": False,
-            "partial_update": document.link_role == "editor",
+            "manage_accesses": False,
+            "partial_update": False,
             "retrieve": True,
-            "update": document.link_role == "editor",
+            "update": False,
             "versions_destroy": False,
             "versions_list": False,
             "versions_retrieve": False,
         },
+        "accesses": [],
+        "title": document.title,
+        "is_public": True,
         "content": document.content,
         "created_at": document.created_at.isoformat().replace("+00:00", "Z"),
-        "creator": str(document.creator.id),
-        "is_favorite": False,
-        "link_reach": reach,
-        "link_role": document.link_role,
-        "nb_accesses": 0,
-        "title": document.title,
         "updated_at": document.updated_at.isoformat().replace("+00:00", "Z"),
     }
-    assert (
-        models.LinkTrace.objects.filter(document=document, user=user).exists() is True
-    )
 
 
-@pytest.mark.parametrize("reach", ["public", "authenticated"])
-def test_api_documents_retrieve_authenticated_trace_twice(reach):
+def test_api_documents_retrieve_authenticated_unrelated_not_public():
     """
-    Accessing a document several times should not raise any error even though the
-    trace already exists for this document and user.
+    Authenticated users should not be allowed to retrieve a document that is not public and
+    to which they are not related.
     """
     user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
-    document = factories.DocumentFactory(link_reach=reach)
-    assert (
-        models.LinkTrace.objects.filter(document=document, user=user).exists() is False
-    )
-
-    client.get(
-        f"/api/v1.0/documents/{document.id!s}/",
-    )
-    assert (
-        models.LinkTrace.objects.filter(document=document, user=user).exists() is True
-    )
-
-    # A second visit should not raise any error
-    response = client.get(f"/api/v1.0/documents/{document.id!s}/")
-
-    assert response.status_code == 200
-
-
-def test_api_documents_retrieve_authenticated_unrelated_restricted():
-    """
-    Authenticated users should not be allowed to retrieve a document that is restricted and
-    to which they are not related.
-    """
-    user = factories.UserFactory(with_owned_document=True)
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach="restricted")
+    document = factories.DocumentFactory(is_public=False)
 
     response = client.get(
         f"/api/v1.0/documents/{document.id!s}/",
     )
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
+    assert response.status_code == 404
+    assert response.json() == {"detail": "Not found."}
 
 
 def test_api_documents_retrieve_authenticated_related_direct():
@@ -179,43 +115,59 @@ def test_api_documents_retrieve_authenticated_related_direct():
     client.force_login(user)
 
     document = factories.DocumentFactory()
-    factories.UserDocumentAccessFactory(document=document, user=user)
+    access1 = factories.UserDocumentAccessFactory(document=document, user=user)
     access2 = factories.UserDocumentAccessFactory(document=document)
-    serializers.UserSerializer(instance=user)
-    serializers.UserSerializer(instance=access2.user)
+    access1_user = serializers.UserSerializer(instance=user).data
+    access2_user = serializers.UserSerializer(instance=access2.user).data
 
     response = client.get(
         f"/api/v1.0/documents/{document.id!s}/",
     )
     assert response.status_code == 200
+    content = response.json()
+    assert sorted(content.pop("accesses"), key=lambda x: x["id"]) == sorted(
+        [
+            {
+                "id": str(access1.id),
+                "user": access1_user,
+                "team": "",
+                "role": access1.role,
+                "abilities": access1.get_abilities(user),
+            },
+            {
+                "id": str(access2.id),
+                "user": access2_user,
+                "team": "",
+                "role": access2.role,
+                "abilities": access2.get_abilities(user),
+            },
+        ],
+        key=lambda x: x["id"],
+    )
     assert response.json() == {
         "id": str(document.id),
-        "abilities": document.get_abilities(user),
-        "content": document.content,
-        "creator": str(document.creator.id),
-        "created_at": document.created_at.isoformat().replace("+00:00", "Z"),
-        "is_favorite": False,
-        "link_reach": document.link_reach,
-        "link_role": document.link_role,
-        "nb_accesses": 2,
         "title": document.title,
+        "content": document.content,
+        "abilities": document.get_abilities(user),
+        "is_public": document.is_public,
+        "created_at": document.created_at.isoformat().replace("+00:00", "Z"),
         "updated_at": document.updated_at.isoformat().replace("+00:00", "Z"),
     }
 
 
-def test_api_documents_retrieve_authenticated_related_team_none(mock_user_teams):
+def test_api_documents_retrieve_authenticated_related_team_none(mock_user_get_teams):
     """
-    Authenticated users should not be able to retrieve a restricted document related to
-    teams in which the user is not.
+    Authenticated users should not be able to retrieve a document related to teams in
+    which the user is not.
     """
-    mock_user_teams.return_value = []
+    mock_user_get_teams.return_value = []
 
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
-    document = factories.DocumentFactory(link_reach="restricted")
+    document = factories.DocumentFactory(is_public=False)
 
     factories.TeamDocumentAccessFactory(
         document=document, team="readers", role="reader"
@@ -231,10 +183,8 @@ def test_api_documents_retrieve_authenticated_related_team_none(mock_user_teams)
     factories.TeamDocumentAccessFactory()
 
     response = client.get(f"/api/v1.0/documents/{document.id!s}/")
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
+    assert response.status_code == 404
+    assert response.json() == {"detail": "Not found."}
 
 
 @pytest.mark.parametrize(
@@ -247,49 +197,93 @@ def test_api_documents_retrieve_authenticated_related_team_none(mock_user_teams)
     ],
 )
 def test_api_documents_retrieve_authenticated_related_team_members(
-    teams, mock_user_teams
+    teams, mock_user_get_teams
 ):
     """
     Authenticated users should be allowed to retrieve a document to which they
-    are related via a team whatever the role.
+    are related via a team whatever the role and see all its accesses.
     """
-    mock_user_teams.return_value = teams
+    mock_user_get_teams.return_value = teams
 
     user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
-    document = factories.DocumentFactory(link_reach="restricted")
+    document = factories.DocumentFactory(is_public=False)
 
-    factories.TeamDocumentAccessFactory(
+    access_reader = factories.TeamDocumentAccessFactory(
         document=document, team="readers", role="reader"
     )
-    factories.TeamDocumentAccessFactory(
+    access_editor = factories.TeamDocumentAccessFactory(
         document=document, team="editors", role="editor"
     )
-    factories.TeamDocumentAccessFactory(
+    access_administrator = factories.TeamDocumentAccessFactory(
         document=document, team="administrators", role="administrator"
     )
-    factories.TeamDocumentAccessFactory(document=document, team="owners", role="owner")
-    factories.TeamDocumentAccessFactory(document=document)
+    access_owner = factories.TeamDocumentAccessFactory(
+        document=document, team="owners", role="owner"
+    )
+    other_access = factories.TeamDocumentAccessFactory(document=document)
     factories.TeamDocumentAccessFactory()
 
     response = client.get(f"/api/v1.0/documents/{document.id!s}/")
-
-    # pylint: disable=R0801
     assert response.status_code == 200
+    content = response.json()
+    expected_abilities = {
+        "destroy": False,
+        "retrieve": True,
+        "set_role_to": [],
+        "update": False,
+        "partial_update": False,
+    }
+    assert sorted(content.pop("accesses"), key=lambda x: x["id"]) == sorted(
+        [
+            {
+                "id": str(access_reader.id),
+                "user": None,
+                "team": "readers",
+                "role": access_reader.role,
+                "abilities": expected_abilities,
+            },
+            {
+                "id": str(access_editor.id),
+                "user": None,
+                "team": "editors",
+                "role": access_editor.role,
+                "abilities": expected_abilities,
+            },
+            {
+                "id": str(access_administrator.id),
+                "user": None,
+                "team": "administrators",
+                "role": access_administrator.role,
+                "abilities": expected_abilities,
+            },
+            {
+                "id": str(access_owner.id),
+                "user": None,
+                "team": "owners",
+                "role": access_owner.role,
+                "abilities": expected_abilities,
+            },
+            {
+                "id": str(other_access.id),
+                "user": None,
+                "team": other_access.team,
+                "role": other_access.role,
+                "abilities": expected_abilities,
+            },
+        ],
+        key=lambda x: x["id"],
+    )
     assert response.json() == {
         "id": str(document.id),
-        "abilities": document.get_abilities(user),
-        "content": document.content,
-        "created_at": document.created_at.isoformat().replace("+00:00", "Z"),
-        "creator": str(document.creator.id),
-        "is_favorite": False,
-        "link_reach": "restricted",
-        "link_role": document.link_role,
-        "nb_accesses": 5,
         "title": document.title,
+        "content": document.content,
+        "abilities": document.get_abilities(user),
+        "is_public": False,
+        "created_at": document.created_at.isoformat().replace("+00:00", "Z"),
         "updated_at": document.updated_at.isoformat().replace("+00:00", "Z"),
     }
 
@@ -303,49 +297,112 @@ def test_api_documents_retrieve_authenticated_related_team_members(
     ],
 )
 def test_api_documents_retrieve_authenticated_related_team_administrators(
-    teams, mock_user_teams
+    teams, mock_user_get_teams
 ):
     """
     Authenticated users should be allowed to retrieve a document to which they
-    are related via a team whatever the role.
+    are related via a team whatever the role and see all its accesses.
     """
-    mock_user_teams.return_value = teams
+    mock_user_get_teams.return_value = teams
 
     user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
-    document = factories.DocumentFactory(link_reach="restricted")
+    document = factories.DocumentFactory(is_public=False)
 
-    factories.TeamDocumentAccessFactory(
+    access_reader = factories.TeamDocumentAccessFactory(
         document=document, team="readers", role="reader"
     )
-    factories.TeamDocumentAccessFactory(
+    access_editor = factories.TeamDocumentAccessFactory(
         document=document, team="editors", role="editor"
     )
-    factories.TeamDocumentAccessFactory(
+    access_administrator = factories.TeamDocumentAccessFactory(
         document=document, team="administrators", role="administrator"
     )
-    factories.TeamDocumentAccessFactory(document=document, team="owners", role="owner")
-    factories.TeamDocumentAccessFactory(document=document)
+    access_owner = factories.TeamDocumentAccessFactory(
+        document=document, team="owners", role="owner"
+    )
+    other_access = factories.TeamDocumentAccessFactory(document=document)
     factories.TeamDocumentAccessFactory()
 
     response = client.get(f"/api/v1.0/documents/{document.id!s}/")
 
     # pylint: disable=R0801
     assert response.status_code == 200
+    content = response.json()
+    assert sorted(content.pop("accesses"), key=lambda x: x["id"]) == sorted(
+        [
+            {
+                "id": str(access_reader.id),
+                "user": None,
+                "team": "readers",
+                "role": "reader",
+                "abilities": {
+                    "destroy": True,
+                    "retrieve": True,
+                    "set_role_to": ["administrator", "editor"],
+                    "update": True,
+                    "partial_update": True,
+                },
+            },
+            {
+                "id": str(access_editor.id),
+                "user": None,
+                "team": "editors",
+                "role": "editor",
+                "abilities": {
+                    "destroy": True,
+                    "retrieve": True,
+                    "set_role_to": ["administrator", "reader"],
+                    "update": True,
+                    "partial_update": True,
+                },
+            },
+            {
+                "id": str(access_administrator.id),
+                "user": None,
+                "team": "administrators",
+                "role": "administrator",
+                "abilities": {
+                    "destroy": True,
+                    "retrieve": True,
+                    "set_role_to": ["editor", "reader"],
+                    "update": True,
+                    "partial_update": True,
+                },
+            },
+            {
+                "id": str(access_owner.id),
+                "user": None,
+                "team": "owners",
+                "role": "owner",
+                "abilities": {
+                    "destroy": False,
+                    "retrieve": True,
+                    "set_role_to": [],
+                    "update": False,
+                    "partial_update": False,
+                },
+            },
+            {
+                "id": str(other_access.id),
+                "user": None,
+                "team": other_access.team,
+                "role": other_access.role,
+                "abilities": other_access.get_abilities(user),
+            },
+        ],
+        key=lambda x: x["id"],
+    )
     assert response.json() == {
         "id": str(document.id),
-        "abilities": document.get_abilities(user),
-        "content": document.content,
-        "created_at": document.created_at.isoformat().replace("+00:00", "Z"),
-        "creator": str(document.creator.id),
-        "is_favorite": False,
-        "link_reach": "restricted",
-        "link_role": document.link_role,
-        "nb_accesses": 5,
         "title": document.title,
+        "content": document.content,
+        "abilities": document.get_abilities(user),
+        "is_public": False,
+        "created_at": document.created_at.isoformat().replace("+00:00", "Z"),
         "updated_at": document.updated_at.isoformat().replace("+00:00", "Z"),
     }
 
@@ -360,48 +417,114 @@ def test_api_documents_retrieve_authenticated_related_team_administrators(
     ],
 )
 def test_api_documents_retrieve_authenticated_related_team_owners(
-    teams, mock_user_teams
+    teams, mock_user_get_teams
 ):
     """
-    Authenticated users should be allowed to retrieve a restricted document to which
-    they are related via a team whatever the role.
+    Authenticated users should be allowed to retrieve a document to which they
+    are related via a team whatever the role and see all its accesses.
     """
-    mock_user_teams.return_value = teams
+    mock_user_get_teams.return_value = teams
 
     user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
-    document = factories.DocumentFactory(link_reach="restricted")
+    document = factories.DocumentFactory(is_public=False)
 
-    factories.TeamDocumentAccessFactory(
+    access_reader = factories.TeamDocumentAccessFactory(
         document=document, team="readers", role="reader"
     )
-    factories.TeamDocumentAccessFactory(
+    access_editor = factories.TeamDocumentAccessFactory(
         document=document, team="editors", role="editor"
     )
-    factories.TeamDocumentAccessFactory(
+    access_administrator = factories.TeamDocumentAccessFactory(
         document=document, team="administrators", role="administrator"
     )
-    factories.TeamDocumentAccessFactory(document=document, team="owners", role="owner")
-    factories.TeamDocumentAccessFactory(document=document)
+    access_owner = factories.TeamDocumentAccessFactory(
+        document=document, team="owners", role="owner"
+    )
+    other_access = factories.TeamDocumentAccessFactory(document=document)
     factories.TeamDocumentAccessFactory()
 
     response = client.get(f"/api/v1.0/documents/{document.id!s}/")
 
     # pylint: disable=R0801
     assert response.status_code == 200
+    content = response.json()
+    assert sorted(content.pop("accesses"), key=lambda x: x["id"]) == sorted(
+        [
+            {
+                "id": str(access_reader.id),
+                "user": None,
+                "team": "readers",
+                "role": "reader",
+                "abilities": {
+                    "destroy": True,
+                    "retrieve": True,
+                    "set_role_to": ["owner", "administrator", "editor"],
+                    "update": True,
+                    "partial_update": True,
+                },
+            },
+            {
+                "id": str(access_editor.id),
+                "user": None,
+                "team": "editors",
+                "role": "editor",
+                "abilities": {
+                    "destroy": True,
+                    "retrieve": True,
+                    "set_role_to": ["owner", "administrator", "reader"],
+                    "update": True,
+                    "partial_update": True,
+                },
+            },
+            {
+                "id": str(access_administrator.id),
+                "user": None,
+                "team": "administrators",
+                "role": "administrator",
+                "abilities": {
+                    "destroy": True,
+                    "retrieve": True,
+                    "set_role_to": ["owner", "editor", "reader"],
+                    "update": True,
+                    "partial_update": True,
+                },
+            },
+            {
+                "id": str(access_owner.id),
+                "user": None,
+                "team": "owners",
+                "role": "owner",
+                "abilities": {
+                    # editable only if there is another owner role than the user's team...
+                    "destroy": other_access.role == "owner",
+                    "retrieve": True,
+                    "set_role_to": ["administrator", "editor", "reader"]
+                    if other_access.role == "owner"
+                    else [],
+                    "update": other_access.role == "owner",
+                    "partial_update": other_access.role == "owner",
+                },
+            },
+            {
+                "id": str(other_access.id),
+                "user": None,
+                "team": other_access.team,
+                "role": other_access.role,
+                "abilities": other_access.get_abilities(user),
+            },
+        ],
+        key=lambda x: x["id"],
+    )
     assert response.json() == {
         "id": str(document.id),
-        "abilities": document.get_abilities(user),
-        "content": document.content,
-        "created_at": document.created_at.isoformat().replace("+00:00", "Z"),
-        "creator": str(document.creator.id),
-        "is_favorite": False,
-        "link_reach": "restricted",
-        "link_role": document.link_role,
-        "nb_accesses": 5,
         "title": document.title,
+        "content": document.content,
+        "abilities": document.get_abilities(user),
+        "is_public": False,
+        "created_at": document.created_at.isoformat().replace("+00:00", "Z"),
         "updated_at": document.updated_at.isoformat().replace("+00:00", "Z"),
     }

src/backend/core/tests/documents/test_api_documents_update.py

@@ -1,11 +1,8 @@
 """
 Tests for Documents API endpoint in impress's core app: update
 """
-
 import random
 
-from django.contrib.auth.models import AnonymousUser
-
 import pytest
 from rest_framework.test import APIClient
 
@@ -16,22 +13,9 @@ from core.tests.conftest import TEAM, USER, VIA
 pytestmark = pytest.mark.django_db
 
 
-@pytest.mark.parametrize(
-    "reach, role",
-    [
-        ("restricted", "reader"),
-        ("restricted", "editor"),
-        ("authenticated", "reader"),
-        ("authenticated", "editor"),
-        ("public", "reader"),
-    ],
-)
-def test_api_documents_update_anonymous_forbidden(reach, role):
-    """
-    Anonymous users should not be allowed to update a document when link
-    configuration does not allow it.
-    """
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
+def test_api_documents_update_anonymous():
+    """Anonymous users should not be allowed to update a document."""
+    document = factories.DocumentFactory()
     old_document_values = serializers.DocumentSerializer(instance=document).data
 
     new_document_values = serializers.DocumentSerializer(
@@ -52,28 +36,18 @@ def test_api_documents_update_anonymous_forbidden(reach, role):
     assert document_values == old_document_values
 
 
-@pytest.mark.parametrize(
-    "reach,role",
-    [
-        ("public", "reader"),
-        ("authenticated", "reader"),
-        ("restricted", "reader"),
-        ("restricted", "editor"),
-    ],
-)
-def test_api_documents_update_authenticated_unrelated_forbidden(reach, role):
+def test_api_documents_update_authenticated_unrelated():
     """
-    Authenticated users should not be allowed to update a document to which
-    they are not related if the link configuration does not allow it.
+    Authenticated users should not be allowed to update a document to which they are not related.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
-
+    document = factories.DocumentFactory(is_public=False)
     old_document_values = serializers.DocumentSerializer(instance=document).data
+
     new_document_values = serializers.DocumentSerializer(
         instance=factories.DocumentFactory()
     ).data
@@ -83,86 +57,30 @@ def test_api_documents_update_authenticated_unrelated_forbidden(reach, role):
         format="json",
     )
 
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
+    assert response.status_code == 404
+    assert response.json() == {"detail": "Not found."}
 
     document.refresh_from_db()
     document_values = serializers.DocumentSerializer(instance=document).data
     assert document_values == old_document_values
 
 
-@pytest.mark.parametrize(
-    "is_authenticated,reach,role",
-    [
-        (False, "public", "editor"),
-        (True, "public", "editor"),
-        (True, "authenticated", "editor"),
-    ],
-)
-def test_api_documents_update_anonymous_or_authenticated_unrelated(
-    is_authenticated, reach, role
-):
-    """
-    Authenticated users should be able to update a document to which
-    they are not related if the link configuration allows it.
-    """
-    client = APIClient()
-
-    if is_authenticated:
-        user = factories.UserFactory(with_owned_document=True)
-        client.force_login(user)
-    else:
-        user = AnonymousUser()
-
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
-
-    old_document_values = serializers.DocumentSerializer(instance=document).data
-    new_document_values = serializers.DocumentSerializer(
-        instance=factories.DocumentFactory()
-    ).data
-    response = client.put(
-        f"/api/v1.0/documents/{document.id!s}/",
-        new_document_values,
-        format="json",
-    )
-    assert response.status_code == 200
-
-    document = models.Document.objects.get(pk=document.pk)
-    document_values = serializers.DocumentSerializer(instance=document).data
-    for key, value in document_values.items():
-        if key in [
-            "id",
-            "accesses",
-            "created_at",
-            "creator",
-            "link_reach",
-            "link_role",
-        ]:
-            assert value == old_document_values[key]
-        elif key == "updated_at":
-            assert value > old_document_values[key]
-        else:
-            assert value == new_document_values[key]
-
-
 @pytest.mark.parametrize("via", VIA)
-def test_api_documents_update_authenticated_reader(via, mock_user_teams):
+def test_api_documents_update_authenticated_reader(via, mock_user_get_teams):
     """
-    Users who are reader of a document but not administrators should
+    Users who are editors or reader of a document but not administrators should
     not be allowed to update it.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
-    document = factories.DocumentFactory(link_role="reader")
+    document = factories.DocumentFactory()
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user, role="reader")
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role="reader"
         )
@@ -191,10 +109,10 @@ def test_api_documents_update_authenticated_reader(via, mock_user_teams):
 @pytest.mark.parametrize("role", ["editor", "administrator", "owner"])
 @pytest.mark.parametrize("via", VIA)
 def test_api_documents_update_authenticated_editor_administrator_or_owner(
-    via, role, mock_user_teams
+    via, role, mock_user_get_teams
 ):
     """A user who is editor, administrator or owner of a document should be allowed to update it."""
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -203,7 +121,7 @@ def test_api_documents_update_authenticated_editor_administrator_or_owner(
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user, role=role)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role=role
         )
@@ -223,14 +141,7 @@ def test_api_documents_update_authenticated_editor_administrator_or_owner(
     document = models.Document.objects.get(pk=document.pk)
     document_values = serializers.DocumentSerializer(instance=document).data
     for key, value in document_values.items():
-        if key in [
-            "id",
-            "created_at",
-            "creator",
-            "link_reach",
-            "link_role",
-            "nb_accesses",
-        ]:
+        if key in ["id", "accesses", "created_at"]:
             assert value == old_document_values[key]
         elif key == "updated_at":
             assert value > old_document_values[key]
@@ -239,9 +150,9 @@ def test_api_documents_update_authenticated_editor_administrator_or_owner(
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_documents_update_authenticated_owners(via, mock_user_teams):
+def test_api_documents_update_authenticated_owners(via, mock_user_get_teams):
     """Administrators of a document should be allowed to update it."""
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -250,7 +161,7 @@ def test_api_documents_update_authenticated_owners(via, mock_user_teams):
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user, role="owner")
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role="owner"
         )
@@ -269,14 +180,7 @@ def test_api_documents_update_authenticated_owners(via, mock_user_teams):
     document = models.Document.objects.get(pk=document.pk)
     document_values = serializers.DocumentSerializer(instance=document).data
     for key, value in document_values.items():
-        if key in [
-            "id",
-            "created_at",
-            "creator",
-            "link_reach",
-            "link_role",
-            "nb_accesses",
-        ]:
+        if key in ["id", "accesses", "created_at"]:
             assert value == old_document_values[key]
         elif key == "updated_at":
             assert value > old_document_values[key]
@@ -285,12 +189,14 @@ def test_api_documents_update_authenticated_owners(via, mock_user_teams):
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_documents_update_administrator_or_owner_of_another(via, mock_user_teams):
+def test_api_documents_update_administrator_or_owner_of_another(
+    via, mock_user_get_teams
+):
     """
     Being administrator or owner of a document should not grant authorization to update
     another document.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -301,27 +207,28 @@ def test_api_documents_update_administrator_or_owner_of_another(via, mock_user_t
             document=document, user=user, role=random.choice(["administrator", "owner"])
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document,
             team="lasuite",
             role=random.choice(["administrator", "owner"]),
         )
 
-    other_document = factories.DocumentFactory(title="Old title", link_role="reader")
-    old_document_values = serializers.DocumentSerializer(instance=other_document).data
+    is_public = random.choice([True, False])
+    document = factories.DocumentFactory(title="Old title", is_public=is_public)
+    old_document_values = serializers.DocumentSerializer(instance=document).data
 
     new_document_values = serializers.DocumentSerializer(
         instance=factories.DocumentFactory()
     ).data
     response = client.put(
-        f"/api/v1.0/documents/{other_document.id!s}/",
+        f"/api/v1.0/documents/{document.id!s}/",
         new_document_values,
         format="json",
     )
 
-    assert response.status_code == 403
+    assert response.status_code == 403 if is_public else 404
 
-    other_document.refresh_from_db()
-    other_document_values = serializers.DocumentSerializer(instance=other_document).data
-    assert other_document_values == old_document_values
+    document.refresh_from_db()
+    document_values = serializers.DocumentSerializer(instance=document).data
+    assert document_values == old_document_values

src/backend/core/tests/swagger/test_openapi_schema.py

@@ -1,7 +1,6 @@
 """
 Test suite for generated openapi schema.
 """
-
 import json
 from io import StringIO
 

src/backend/core/tests/templates/test_api_template_accesses_create.py

@@ -1,206 +0,0 @@
-"""
-Test template accesses create API endpoint for users in impress's core app.
-"""
-
-import random
-
-import pytest
-from rest_framework.test import APIClient
-
-from core import factories, models
-from core.tests.conftest import TEAM, USER, VIA
-
-pytestmark = pytest.mark.django_db
-
-
-def test_api_template_accesses_create_anonymous():
-    """Anonymous users should not be allowed to create template accesses."""
-    template = factories.TemplateFactory()
-
-    other_user = factories.UserFactory()
-    response = APIClient().post(
-        f"/api/v1.0/templates/{template.id!s}/accesses/",
-        {
-            "user": str(other_user.id),
-            "template": str(template.id),
-            "role": random.choice(models.RoleChoices.choices)[0],
-        },
-        format="json",
-    )
-
-    assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
-    assert models.TemplateAccess.objects.exists() is False
-
-
-def test_api_template_accesses_create_authenticated_unrelated():
-    """
-    Authenticated users should not be allowed to create template accesses for a template to
-    which they are not related.
-    """
-    user = factories.UserFactory(with_owned_template=True)
-
-    client = APIClient()
-    client.force_login(user)
-
-    other_user = factories.UserFactory()
-    template = factories.TemplateFactory()
-
-    response = client.post(
-        f"/api/v1.0/templates/{template.id!s}/accesses/",
-        {
-            "user": str(other_user.id),
-        },
-        format="json",
-    )
-
-    assert response.status_code == 403
-    assert not models.TemplateAccess.objects.filter(user=other_user).exists()
-
-
-@pytest.mark.parametrize("role", ["reader", "editor"])
-@pytest.mark.parametrize("via", VIA)
-def test_api_template_accesses_create_authenticated_editor_or_reader(
-    via, role, mock_user_teams
-):
-    """Editors or readers of a template should not be allowed to create template accesses."""
-    user = factories.UserFactory(with_owned_template=True)
-
-    client = APIClient()
-    client.force_login(user)
-
-    template = factories.TemplateFactory()
-    if via == USER:
-        factories.UserTemplateAccessFactory(template=template, user=user, role=role)
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamTemplateAccessFactory(
-            template=template, team="lasuite", role=role
-        )
-
-    other_user = factories.UserFactory()
-
-    for new_role in [role[0] for role in models.RoleChoices.choices]:
-        response = client.post(
-            f"/api/v1.0/templates/{template.id!s}/accesses/",
-            {
-                "user": str(other_user.id),
-                "role": new_role,
-            },
-            format="json",
-        )
-
-        assert response.status_code == 403
-
-    assert not models.TemplateAccess.objects.filter(user=other_user).exists()
-
-
-@pytest.mark.parametrize("via", VIA)
-def test_api_template_accesses_create_authenticated_administrator(via, mock_user_teams):
-    """
-    Administrators of a template should be able to create template accesses
-    except for the "owner" role.
-    """
-    user = factories.UserFactory(with_owned_template=True)
-
-    client = APIClient()
-    client.force_login(user)
-
-    template = factories.TemplateFactory()
-    if via == USER:
-        factories.UserTemplateAccessFactory(
-            template=template, user=user, role="administrator"
-        )
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamTemplateAccessFactory(
-            template=template, team="lasuite", role="administrator"
-        )
-
-    other_user = factories.UserFactory()
-
-    # It should not be allowed to create an owner access
-    response = client.post(
-        f"/api/v1.0/templates/{template.id!s}/accesses/",
-        {
-            "user": str(other_user.id),
-            "role": "owner",
-        },
-        format="json",
-    )
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "Only owners of a resource can assign other users as owners."
-    }
-
-    # It should be allowed to create a lower access
-    role = random.choice(
-        [role[0] for role in models.RoleChoices.choices if role[0] != "owner"]
-    )
-
-    response = client.post(
-        f"/api/v1.0/templates/{template.id!s}/accesses/",
-        {
-            "user": str(other_user.id),
-            "role": role,
-        },
-        format="json",
-    )
-
-    assert response.status_code == 201
-    assert models.TemplateAccess.objects.filter(user=other_user).count() == 1
-    new_template_access = models.TemplateAccess.objects.filter(user=other_user).get()
-    assert response.json() == {
-        "abilities": new_template_access.get_abilities(user),
-        "id": str(new_template_access.id),
-        "team": "",
-        "role": role,
-        "user": str(other_user.id),
-    }
-
-
-@pytest.mark.parametrize("via", VIA)
-def test_api_template_accesses_create_authenticated_owner(via, mock_user_teams):
-    """
-    Owners of a template should be able to create template accesses whatever the role.
-    """
-    user = factories.UserFactory(with_owned_template=True)
-
-    client = APIClient()
-    client.force_login(user)
-
-    template = factories.TemplateFactory()
-    if via == USER:
-        factories.UserTemplateAccessFactory(template=template, user=user, role="owner")
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamTemplateAccessFactory(
-            template=template, team="lasuite", role="owner"
-        )
-
-    other_user = factories.UserFactory()
-
-    role = random.choice([role[0] for role in models.RoleChoices.choices])
-
-    response = client.post(
-        f"/api/v1.0/templates/{template.id!s}/accesses/",
-        {
-            "user": str(other_user.id),
-            "role": role,
-        },
-        format="json",
-    )
-
-    assert response.status_code == 201
-    assert models.TemplateAccess.objects.filter(user=other_user).count() == 1
-    new_template_access = models.TemplateAccess.objects.filter(user=other_user).get()
-    assert response.json() == {
-        "id": str(new_template_access.id),
-        "user": str(other_user.id),
-        "team": "",
-        "role": role,
-        "abilities": new_template_access.get_abilities(user),
-    }

src/backend/core/tests/templates/test_api_templates_create.py

@@ -1,7 +1,6 @@
 """
 Tests for Templates API endpoint in impress's core app: create
 """
-
 import pytest
 from rest_framework.test import APIClient
 

src/backend/core/tests/templates/test_api_templates_delete.py

@@ -1,7 +1,6 @@
 """
 Tests for Templates API endpoint in impress's core app: delete
 """
-
 import random
 
 import pytest
@@ -49,7 +48,7 @@ def test_api_templates_delete_authenticated_unrelated():
 @pytest.mark.parametrize("role", ["reader", "editor", "administrator"])
 @pytest.mark.parametrize("via", VIA)
 def test_api_templates_delete_authenticated_member_or_administrator(
-    via, role, mock_user_teams
+    via, role, mock_user_get_teams
 ):
     """
     Authenticated users should not be allowed to delete a template for which they are
@@ -64,7 +63,7 @@ def test_api_templates_delete_authenticated_member_or_administrator(
     if via == USER:
         factories.UserTemplateAccessFactory(template=template, user=user, role=role)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(
             template=template, team="lasuite", role=role
         )
@@ -81,7 +80,7 @@ def test_api_templates_delete_authenticated_member_or_administrator(
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_templates_delete_authenticated_owner(via, mock_user_teams):
+def test_api_templates_delete_authenticated_owner(via, mock_user_get_teams):
     """
     Authenticated users should be able to delete a template they own.
     """
@@ -94,7 +93,7 @@ def test_api_templates_delete_authenticated_owner(via, mock_user_teams):
     if via == USER:
         factories.UserTemplateAccessFactory(template=template, user=user, role="owner")
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(
             template=template, team="lasuite", role="owner"
         )

src/backend/core/tests/templates/test_api_templates_generate_document.py

@@ -1,7 +1,6 @@
 """
 Test users API endpoints in the impress core app.
 """
-
 import pytest
 from rest_framework.test import APIClient
 
@@ -44,10 +43,8 @@ def test_api_templates_generate_document_anonymous_not_public():
         format="json",
     )
 
-    assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
+    assert response.status_code == 404
+    assert response.json() == {"detail": "Not found."}
 
 
 def test_api_templates_generate_document_authenticated_public():
@@ -89,24 +86,22 @@ def test_api_templates_generate_document_authenticated_not_public():
         format="json",
     )
 
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
+    assert response.status_code == 404
+    assert response.json() == {"detail": "Not found."}
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_templates_generate_document_related(via, mock_user_teams):
+def test_api_templates_generate_document_related(via, mock_user_get_teams):
     """Users related to a template can generate pdf document."""
     user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
-    access = None
+
     if via == USER:
         access = factories.UserTemplateAccessFactory(user=user)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         access = factories.TeamTemplateAccessFactory(team="lasuite")
 
     data = {"body": "# Test markdown body"}
@@ -183,26 +178,3 @@ def test_api_templates_generate_document_type_unknown():
             '"unknown" is not a valid choice.',
         ]
     }
-
-
-def test_api_templates_generate_document_export_docx():
-    """Generate pdf document with the body type html."""
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    template = factories.TemplateFactory(is_public=True)
-    data = {"body": "<p>Test body</p>", "body_type": "html", "format": "docx"}
-
-    response = client.post(
-        f"/api/v1.0/templates/{template.id!s}/generate-document/",
-        data,
-        format="json",
-    )
-
-    assert response.status_code == 200
-    assert (
-        response.headers["content-type"]
-        == "application/vnd.openxmlformats-officedocument.wordprocessingml.document"
-    )

src/backend/core/tests/templates/test_api_templates_list.py

@@ -1,11 +1,11 @@
 """
 Tests for Templates API endpoint in impress's core app: list
 """
-
 from unittest import mock
 
 import pytest
 from rest_framework.pagination import PageNumberPagination
+from rest_framework.status import HTTP_200_OK
 from rest_framework.test import APIClient
 
 from core import factories
@@ -16,12 +16,12 @@ pytestmark = pytest.mark.django_db
 def test_api_templates_list_anonymous():
     """Anonymous users should only be able to list public templates."""
     factories.TemplateFactory.create_batch(2, is_public=False)
-    public_templates = factories.TemplateFactory.create_batch(2, is_public=True)
-    expected_ids = {str(template.id) for template in public_templates}
+    templates = factories.TemplateFactory.create_batch(2, is_public=True)
+    expected_ids = {str(template.id) for template in templates}
 
     response = APIClient().get("/api/v1.0/templates/")
 
-    assert response.status_code == 200
+    assert response.status_code == HTTP_200_OK
     results = response.json()["results"]
     assert len(results) == 2
     results_id = {result["id"] for result in results}
@@ -31,7 +31,7 @@ def test_api_templates_list_anonymous():
 def test_api_templates_list_authenticated_direct():
     """
     Authenticated users should be able to list templates they are a direct
-    owner/administrator/member of or that are public.
+    owner/administrator/member of.
     """
     user = factories.UserFactory()
 
@@ -53,24 +53,24 @@ def test_api_templates_list_authenticated_direct():
         "/api/v1.0/templates/",
     )
 
-    assert response.status_code == 200
+    assert response.status_code == HTTP_200_OK
     results = response.json()["results"]
     assert len(results) == 7
     results_id = {result["id"] for result in results}
     assert expected_ids == results_id
 
 
-def test_api_templates_list_authenticated_via_team(mock_user_teams):
+def test_api_templates_list_authenticated_via_team(mock_user_get_teams):
     """
     Authenticated users should be able to list templates they are a
-    owner/administrator/member of via a team or that are public.
+    owner/administrator/member of via a team.
     """
     user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
-    mock_user_teams.return_value = ["team1", "team2", "unknown"]
+    mock_user_get_teams.return_value = ["team1", "team2", "unknown"]
 
     templates_team1 = [
         access.template
@@ -90,7 +90,7 @@ def test_api_templates_list_authenticated_via_team(mock_user_teams):
 
     response = client.get("/api/v1.0/templates/")
 
-    assert response.status_code == 200
+    assert response.status_code == HTTP_200_OK
     results = response.json()["results"]
     assert len(results) == 7
     results_id = {result["id"] for result in results}
@@ -117,7 +117,7 @@ def test_api_templates_list_pagination(
         "/api/v1.0/templates/",
     )
 
-    assert response.status_code == 200
+    assert response.status_code == HTTP_200_OK
     content = response.json()
 
     assert content["count"] == 3
@@ -133,7 +133,7 @@ def test_api_templates_list_pagination(
         "/api/v1.0/templates/?page=2",
     )
 
-    assert response.status_code == 200
+    assert response.status_code == HTTP_200_OK
     content = response.json()
 
     assert content["count"] == 3
@@ -160,24 +160,26 @@ def test_api_templates_list_authenticated_distinct():
         "/api/v1.0/templates/",
     )
 
-    assert response.status_code == 200
+    assert response.status_code == HTTP_200_OK
     content = response.json()
     assert len(content["results"]) == 1
     assert content["results"][0]["id"] == str(template.id)
 
 
-def test_api_templates_list_order_default():
-    """The templates list should be sorted by 'created_at' in descending order by default."""
+def test_api_templates_order():
+    """
+    Test that the endpoint GET templates is sorted in 'created_at' descending order by default.
+    """
     user = factories.UserFactory()
     client = APIClient()
     client.force_login(user)
 
     template_ids = [
-        str(access.template.id)
-        for access in factories.UserTemplateAccessFactory.create_batch(5, user=user)
+        str(template.id)
+        for template in factories.TemplateFactory.create_batch(5, is_public=True)
     ]
 
-    response = client.get(
+    response = APIClient().get(
         "/api/v1.0/templates/",
     )
 
@@ -192,21 +194,21 @@ def test_api_templates_list_order_default():
     ), "created_at values are not sorted from newest to oldest"
 
 
-def test_api_templates_list_order_param():
+def test_api_templates_order_param():
     """
-    The templates list is sorted by 'created_at' in ascending order when setting
-    the "ordering" query parameter.
+    Test that the 'created_at' field is sorted in ascending order
+    when the 'ordering' query parameter is set.
     """
     user = factories.UserFactory()
     client = APIClient()
     client.force_login(user)
 
     templates_ids = [
-        str(access.template.id)
-        for access in factories.UserTemplateAccessFactory.create_batch(5, user=user)
+        str(template.id)
+        for template in factories.TemplateFactory.create_batch(5, is_public=True)
     ]
 
-    response = client.get(
+    response = APIClient().get(
         "/api/v1.0/templates/?ordering=created_at",
     )
     assert response.status_code == 200

src/backend/core/tests/templates/test_api_templates_retrieve.py

@@ -1,7 +1,6 @@
 """
 Tests for Templates API endpoint in impress's core app: retrieve
 """
-
 import pytest
 from rest_framework.test import APIClient
 
@@ -22,7 +21,7 @@ def test_api_templates_retrieve_anonymous_public():
         "abilities": {
             "destroy": False,
             "generate_document": True,
-            "accesses_manage": False,
+            "manage_accesses": False,
             "partial_update": False,
             "retrieve": True,
             "update": False,
@@ -41,10 +40,8 @@ def test_api_templates_retrieve_anonymous_not_public():
 
     response = APIClient().get(f"/api/v1.0/templates/{template.id!s}/")
 
-    assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
+    assert response.status_code == 404
+    assert response.json() == {"detail": "Not found."}
 
 
 def test_api_templates_retrieve_authenticated_unrelated_public():
@@ -68,7 +65,7 @@ def test_api_templates_retrieve_authenticated_unrelated_public():
         "abilities": {
             "destroy": False,
             "generate_document": True,
-            "accesses_manage": False,
+            "manage_accesses": False,
             "partial_update": False,
             "retrieve": True,
             "update": False,
@@ -96,10 +93,8 @@ def test_api_templates_retrieve_authenticated_unrelated_not_public():
     response = client.get(
         f"/api/v1.0/templates/{template.id!s}/",
     )
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
+    assert response.status_code == 404
+    assert response.json() == {"detail": "Not found."}
 
 
 def test_api_templates_retrieve_authenticated_related_direct():
@@ -150,12 +145,12 @@ def test_api_templates_retrieve_authenticated_related_direct():
     }
 
 
-def test_api_templates_retrieve_authenticated_related_team_none(mock_user_teams):
+def test_api_templates_retrieve_authenticated_related_team_none(mock_user_get_teams):
     """
     Authenticated users should not be able to retrieve a template related to teams in
     which the user is not.
     """
-    mock_user_teams.return_value = []
+    mock_user_get_teams.return_value = []
 
     user = factories.UserFactory()
 
@@ -178,10 +173,8 @@ def test_api_templates_retrieve_authenticated_related_team_none(mock_user_teams)
     factories.TeamTemplateAccessFactory()
 
     response = client.get(f"/api/v1.0/templates/{template.id!s}/")
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
+    assert response.status_code == 404
+    assert response.json() == {"detail": "Not found."}
 
 
 @pytest.mark.parametrize(
@@ -194,13 +187,13 @@ def test_api_templates_retrieve_authenticated_related_team_none(mock_user_teams)
     ],
 )
 def test_api_templates_retrieve_authenticated_related_team_readers_or_editors(
-    teams, mock_user_teams
+    teams, mock_user_get_teams
 ):
     """
     Authenticated users should be allowed to retrieve a template to which they
     are related via a team whatever the role and see all its accesses.
     """
-    mock_user_teams.return_value = teams
+    mock_user_get_teams.return_value = teams
 
     user = factories.UserFactory()
 
@@ -293,13 +286,13 @@ def test_api_templates_retrieve_authenticated_related_team_readers_or_editors(
     ],
 )
 def test_api_templates_retrieve_authenticated_related_team_administrators(
-    teams, mock_user_teams
+    teams, mock_user_get_teams
 ):
     """
     Authenticated users should be allowed to retrieve a template to which they
     are related via a team whatever the role and see all its accesses.
     """
-    mock_user_teams.return_value = teams
+    mock_user_get_teams.return_value = teams
 
     user = factories.UserFactory()
 
@@ -411,13 +404,13 @@ def test_api_templates_retrieve_authenticated_related_team_administrators(
     ],
 )
 def test_api_templates_retrieve_authenticated_related_team_owners(
-    teams, mock_user_teams
+    teams, mock_user_get_teams
 ):
     """
     Authenticated users should be allowed to retrieve a template to which they
     are related via a team whatever the role and see all its accesses.
     """
-    mock_user_teams.return_value = teams
+    mock_user_get_teams.return_value = teams
 
     user = factories.UserFactory()
 

src/backend/core/tests/templates/test_api_templates_update.py

@@ -1,7 +1,6 @@
 """
 Tests for Templates API endpoint in impress's core app: update
 """
-
 import random
 
 import pytest
@@ -58,10 +57,8 @@ def test_api_templates_update_authenticated_unrelated():
         format="json",
     )
 
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
+    assert response.status_code == 404
+    assert response.json() == {"detail": "Not found."}
 
     template.refresh_from_db()
     template_values = serializers.TemplateSerializer(instance=template).data
@@ -69,7 +66,7 @@ def test_api_templates_update_authenticated_unrelated():
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_templates_update_authenticated_readers(via, mock_user_teams):
+def test_api_templates_update_authenticated_readers(via, mock_user_get_teams):
     """
     Users who are readers of a template should not be allowed to update it.
     """
@@ -82,7 +79,7 @@ def test_api_templates_update_authenticated_readers(via, mock_user_teams):
     if via == USER:
         factories.UserTemplateAccessFactory(template=template, user=user, role="reader")
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(
             template=template, team="lasuite", role="reader"
         )
@@ -111,7 +108,7 @@ def test_api_templates_update_authenticated_readers(via, mock_user_teams):
 @pytest.mark.parametrize("role", ["editor", "administrator", "owner"])
 @pytest.mark.parametrize("via", VIA)
 def test_api_templates_update_authenticated_editor_or_administrator_or_owner(
-    via, role, mock_user_teams
+    via, role, mock_user_get_teams
 ):
     """Administrator or owner of a template should be allowed to update it."""
     user = factories.UserFactory()
@@ -123,7 +120,7 @@ def test_api_templates_update_authenticated_editor_or_administrator_or_owner(
     if via == USER:
         factories.UserTemplateAccessFactory(template=template, user=user, role=role)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(
             template=template, team="lasuite", role=role
         )
@@ -150,7 +147,7 @@ def test_api_templates_update_authenticated_editor_or_administrator_or_owner(
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_templates_update_authenticated_owners(via, mock_user_teams):
+def test_api_templates_update_authenticated_owners(via, mock_user_get_teams):
     """Administrators of a template should be allowed to update it."""
     user = factories.UserFactory()
 
@@ -161,7 +158,7 @@ def test_api_templates_update_authenticated_owners(via, mock_user_teams):
     if via == USER:
         factories.UserTemplateAccessFactory(template=template, user=user, role="owner")
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(
             template=template, team="lasuite", role="owner"
         )
@@ -187,7 +184,9 @@ def test_api_templates_update_authenticated_owners(via, mock_user_teams):
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_templates_update_administrator_or_owner_of_another(via, mock_user_teams):
+def test_api_templates_update_administrator_or_owner_of_another(
+    via, mock_user_get_teams
+):
     """
     Being administrator or owner of a template should not grant authorization to update
     another template.
@@ -203,7 +202,7 @@ def test_api_templates_update_administrator_or_owner_of_another(via, mock_user_t
             template=template, user=user, role=random.choice(["administrator", "owner"])
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(
             template=template,
             team="lasuite",

src/backend/core/tests/test_api_config.py

@@ -1,45 +0,0 @@
-"""
-Test config API endpoints in the Impress core app.
-"""
-
-from django.test import override_settings
-
-import pytest
-from rest_framework.status import (
-    HTTP_200_OK,
-)
-from rest_framework.test import APIClient
-
-from core import factories
-
-pytestmark = pytest.mark.django_db
-
-
-@override_settings(
-    COLLABORATION_WS_URL="http://testcollab/",
-    CRISP_WEBSITE_ID="123",
-    FRONTEND_THEME="test-theme",
-    MEDIA_BASE_URL="http://testserver/",
-    SENTRY_DSN="https://sentry.test/123",
-)
-@pytest.mark.parametrize("is_authenticated", [False, True])
-def test_api_config(is_authenticated):
-    """Anonymous users should be allowed to get the configuration."""
-    client = APIClient()
-
-    if is_authenticated:
-        user = factories.UserFactory()
-        client.force_login(user)
-
-    response = client.get("/api/v1.0/config/")
-    assert response.status_code == HTTP_200_OK
-    assert response.json() == {
-        "COLLABORATION_WS_URL": "http://testcollab/",
-        "CRISP_WEBSITE_ID": "123",
-        "ENVIRONMENT": "test",
-        "FRONTEND_THEME": "test-theme",
-        "LANGUAGES": [["en-us", "English"], ["fr-fr", "French"], ["de-de", "German"]],
-        "LANGUAGE_CODE": "en-us",
-        "MEDIA_BASE_URL": "http://testserver/",
-        "SENTRY_DSN": "https://sentry.test/123",
-    }

src/backend/core/tests/test_api_document_accesses.py

@@ -1,7 +1,6 @@
 """
 Test document accesses API endpoints for users in impress's core app.
 """
-
 import random
 from uuid import uuid4
 
@@ -11,9 +10,6 @@ from rest_framework.test import APIClient
 from core import factories, models
 from core.api import serializers
 from core.tests.conftest import TEAM, USER, VIA
-from core.tests.test_services_collaboration_services import (  # pylint: disable=unused-import
-    mock_reset_connections,
-)
 
 pytestmark = pytest.mark.django_db
 
@@ -60,7 +56,7 @@ def test_api_document_accesses_list_authenticated_unrelated():
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_list_authenticated_related(via, mock_user_teams):
+def test_api_document_accesses_list_authenticated_related(via, mock_user_get_teams):
     """
     Authenticated users should be able to list document accesses for a document
     to which they are directly related, whatever their role in the document.
@@ -71,7 +67,6 @@ def test_api_document_accesses_list_authenticated_related(via, mock_user_teams):
     client.force_login(user)
 
     document = factories.DocumentFactory()
-    user_access = None
     if via == USER:
         user_access = models.DocumentAccess.objects.create(
             document=document,
@@ -79,7 +74,7 @@ def test_api_document_accesses_list_authenticated_related(via, mock_user_teams):
             role=random.choice(models.RoleChoices.choices)[0],
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         user_access = models.DocumentAccess.objects.create(
             document=document,
             team="lasuite",
@@ -152,7 +147,7 @@ def test_api_document_accesses_retrieve_authenticated_unrelated():
     Authenticated users should not be allowed to retrieve a document access for
     a document to which they are not related.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -178,13 +173,11 @@ def test_api_document_accesses_retrieve_authenticated_unrelated():
         )
 
         assert response.status_code == 404
-        assert response.json() == {
-            "detail": "No DocumentAccess matches the given query."
-        }
+        assert response.json() == {"detail": "Not found."}
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_retrieve_authenticated_related(via, mock_user_teams):
+def test_api_document_accesses_retrieve_authenticated_related(via, mock_user_get_teams):
     """
     A user who is related to a document should be allowed to retrieve the
     associated document user accesses.
@@ -198,7 +191,7 @@ def test_api_document_accesses_retrieve_authenticated_related(via, mock_user_tea
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(document=document, team="lasuite")
 
     access = factories.UserDocumentAccessFactory(document=document)
@@ -219,6 +212,203 @@ def test_api_document_accesses_retrieve_authenticated_related(via, mock_user_tea
     }
 
 
+def test_api_document_accesses_create_anonymous():
+    """Anonymous users should not be allowed to create document accesses."""
+    user = factories.UserFactory()
+    document = factories.DocumentFactory()
+
+    response = APIClient().post(
+        f"/api/v1.0/documents/{document.id!s}/accesses/",
+        {
+            "user": str(user.id),
+            "document": str(document.id),
+            "role": random.choice(models.RoleChoices.choices)[0],
+        },
+        format="json",
+    )
+
+    assert response.status_code == 401
+    assert response.json() == {
+        "detail": "Authentication credentials were not provided."
+    }
+    assert models.DocumentAccess.objects.exists() is False
+
+
+def test_api_document_accesses_create_authenticated_unrelated():
+    """
+    Authenticated users should not be allowed to create document accesses for a document to
+    which they are not related.
+    """
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    other_user = factories.UserFactory()
+    document = factories.DocumentFactory()
+
+    response = client.post(
+        f"/api/v1.0/documents/{document.id!s}/accesses/",
+        {
+            "user": str(other_user.id),
+        },
+        format="json",
+    )
+
+    assert response.status_code == 403
+    assert not models.DocumentAccess.objects.filter(user=other_user).exists()
+
+
+@pytest.mark.parametrize("role", ["reader", "editor"])
+@pytest.mark.parametrize("via", VIA)
+def test_api_document_accesses_create_authenticated_reader_or_editor(
+    via, role, mock_user_get_teams
+):
+    """Readers or editors of a document should not be allowed to create document accesses."""
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    document = factories.DocumentFactory()
+    if via == USER:
+        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
+    elif via == TEAM:
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
+        factories.TeamDocumentAccessFactory(
+            document=document, team="lasuite", role=role
+        )
+
+    other_user = factories.UserFactory()
+
+    for new_role in [role[0] for role in models.RoleChoices.choices]:
+        response = client.post(
+            f"/api/v1.0/documents/{document.id!s}/accesses/",
+            {
+                "user": str(other_user.id),
+                "role": new_role,
+            },
+            format="json",
+        )
+
+        assert response.status_code == 403
+
+    assert not models.DocumentAccess.objects.filter(user=other_user).exists()
+
+
+@pytest.mark.parametrize("via", VIA)
+def test_api_document_accesses_create_authenticated_administrator(
+    via, mock_user_get_teams
+):
+    """
+    Administrators of a document should be able to create document accesses
+    except for the "owner" role.
+    """
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    document = factories.DocumentFactory()
+    if via == USER:
+        factories.UserDocumentAccessFactory(
+            document=document, user=user, role="administrator"
+        )
+    elif via == TEAM:
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
+        factories.TeamDocumentAccessFactory(
+            document=document, team="lasuite", role="administrator"
+        )
+
+    other_user = factories.UserFactory()
+
+    # It should not be allowed to create an owner access
+    response = client.post(
+        f"/api/v1.0/documents/{document.id!s}/accesses/",
+        {
+            "user": str(other_user.id),
+            "role": "owner",
+        },
+        format="json",
+    )
+
+    assert response.status_code == 403
+    assert response.json() == {
+        "detail": "Only owners of a resource can assign other users as owners."
+    }
+
+    # It should be allowed to create a lower access
+    role = random.choice(
+        [role[0] for role in models.RoleChoices.choices if role[0] != "owner"]
+    )
+
+    response = client.post(
+        f"/api/v1.0/documents/{document.id!s}/accesses/",
+        {
+            "user_id": str(other_user.id),
+            "role": role,
+        },
+        format="json",
+    )
+
+    assert response.status_code == 201
+    assert models.DocumentAccess.objects.filter(user=other_user).count() == 1
+    new_document_access = models.DocumentAccess.objects.filter(user=other_user).get()
+    other_user = serializers.UserSerializer(instance=other_user).data
+    assert response.json() == {
+        "abilities": new_document_access.get_abilities(user),
+        "id": str(new_document_access.id),
+        "team": "",
+        "role": role,
+        "user": other_user,
+    }
+
+
+@pytest.mark.parametrize("via", VIA)
+def test_api_document_accesses_create_authenticated_owner(via, mock_user_get_teams):
+    """
+    Owners of a document should be able to create document accesses whatever the role.
+    """
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    document = factories.DocumentFactory()
+    if via == USER:
+        factories.UserDocumentAccessFactory(document=document, user=user, role="owner")
+    elif via == TEAM:
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
+        factories.TeamDocumentAccessFactory(
+            document=document, team="lasuite", role="owner"
+        )
+
+    other_user = factories.UserFactory()
+
+    role = random.choice([role[0] for role in models.RoleChoices.choices])
+
+    response = client.post(
+        f"/api/v1.0/documents/{document.id!s}/accesses/",
+        {
+            "user_id": str(other_user.id),
+            "role": role,
+        },
+        format="json",
+    )
+
+    assert response.status_code == 201
+    assert models.DocumentAccess.objects.filter(user=other_user).count() == 1
+    new_document_access = models.DocumentAccess.objects.filter(user=other_user).get()
+    other_user = serializers.UserSerializer(instance=other_user).data
+    assert response.json() == {
+        "id": str(new_document_access.id),
+        "user": other_user,
+        "team": "",
+        "role": role,
+        "abilities": new_document_access.get_abilities(user),
+    }
+
+
 def test_api_document_accesses_update_anonymous():
     """Anonymous users should not be allowed to update a document access."""
     access = factories.UserDocumentAccessFactory()
@@ -249,7 +439,7 @@ def test_api_document_accesses_update_authenticated_unrelated():
     Authenticated users should not be allowed to update a document access for a document to which
     they are not related.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -279,10 +469,10 @@ def test_api_document_accesses_update_authenticated_unrelated():
 @pytest.mark.parametrize("role", ["reader", "editor"])
 @pytest.mark.parametrize("via", VIA)
 def test_api_document_accesses_update_authenticated_reader_or_editor(
-    via, role, mock_user_teams
+    via, role, mock_user_get_teams
 ):
     """Readers or editors of a document should not be allowed to update its accesses."""
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -291,7 +481,7 @@ def test_api_document_accesses_update_authenticated_reader_or_editor(
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user, role=role)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role=role
         )
@@ -320,15 +510,13 @@ def test_api_document_accesses_update_authenticated_reader_or_editor(
 
 @pytest.mark.parametrize("via", VIA)
 def test_api_document_accesses_update_administrator_except_owner(
-    via,
-    mock_user_teams,
-    mock_reset_connections,  # pylint: disable=redefined-outer-name
+    via, mock_user_get_teams
 ):
     """
     A user who is a direct administrator in a document should be allowed to update a user
     access for this document, as long as they don't try to set the role to owner.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -339,7 +527,7 @@ def test_api_document_accesses_update_administrator_except_owner(
             document=document, user=user, role="administrator"
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role="administrator"
         )
@@ -358,21 +546,18 @@ def test_api_document_accesses_update_administrator_except_owner(
 
     for field, value in new_values.items():
         new_data = {**old_values, field: value}
-        if new_data["role"] == old_values["role"]:
-            response = client.put(
-                f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-                data=new_data,
-                format="json",
-            )
+        response = client.put(
+            f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
+            data=new_data,
+            format="json",
+        )
+
+        if (
+            new_data["role"] == old_values["role"]
+        ):  # we are not really updating the role
             assert response.status_code == 403
         else:
-            with mock_reset_connections(document.id, str(access.user_id)):
-                response = client.put(
-                    f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-                    data=new_data,
-                    format="json",
-                )
-                assert response.status_code == 200
+            assert response.status_code == 200
 
         access.refresh_from_db()
         updated_values = serializers.DocumentAccessSerializer(instance=access).data
@@ -383,12 +568,14 @@ def test_api_document_accesses_update_administrator_except_owner(
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_update_administrator_from_owner(via, mock_user_teams):
+def test_api_document_accesses_update_administrator_from_owner(
+    via, mock_user_get_teams
+):
     """
     A user who is an administrator in a document, should not be allowed to update
     the user access of an "owner" for this document.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -399,7 +586,7 @@ def test_api_document_accesses_update_administrator_from_owner(via, mock_user_te
             document=document, user=user, role="administrator"
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role="administrator"
         )
@@ -430,16 +617,12 @@ def test_api_document_accesses_update_administrator_from_owner(via, mock_user_te
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_update_administrator_to_owner(
-    via,
-    mock_user_teams,
-    mock_reset_connections,  # pylint: disable=redefined-outer-name
-):
+def test_api_document_accesses_update_administrator_to_owner(via, mock_user_get_teams):
     """
     A user who is an administrator in a document, should not be allowed to update
     the user access of another user to grant document ownership.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -450,7 +633,7 @@ def test_api_document_accesses_update_administrator_to_owner(
             document=document, user=user, role="administrator"
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role="administrator"
         )
@@ -471,23 +654,16 @@ def test_api_document_accesses_update_administrator_to_owner(
 
     for field, value in new_values.items():
         new_data = {**old_values, field: value}
+        response = client.put(
+            f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
+            data=new_data,
+            format="json",
+        )
         # We are not allowed or not really updating the role
         if field == "role" or new_data["role"] == old_values["role"]:
-            response = client.put(
-                f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-                data=new_data,
-                format="json",
-            )
-
             assert response.status_code == 403
         else:
-            with mock_reset_connections(document.id, str(access.user_id)):
-                response = client.put(
-                    f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-                    data=new_data,
-                    format="json",
-                )
-                assert response.status_code == 200
+            assert response.status_code == 200
 
         access.refresh_from_db()
         updated_values = serializers.DocumentAccessSerializer(instance=access).data
@@ -495,16 +671,12 @@ def test_api_document_accesses_update_administrator_to_owner(
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_update_owner(
-    via,
-    mock_user_teams,
-    mock_reset_connections,  # pylint: disable=redefined-outer-name
-):
+def test_api_document_accesses_update_owner(via, mock_user_get_teams):
     """
     A user who is an owner in a document should be allowed to update
     a user access for this document whatever the role.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -513,7 +685,7 @@ def test_api_document_accesses_update_owner(
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user, role="owner")
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role="owner"
         )
@@ -532,24 +704,18 @@ def test_api_document_accesses_update_owner(
 
     for field, value in new_values.items():
         new_data = {**old_values, field: value}
+        response = client.put(
+            f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
+            data=new_data,
+            format="json",
+        )
+
         if (
             new_data["role"] == old_values["role"]
         ):  # we are not really updating the role
-            response = client.put(
-                f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-                data=new_data,
-                format="json",
-            )
             assert response.status_code == 403
         else:
-            with mock_reset_connections(document.id, str(access.user_id)):
-                response = client.put(
-                    f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-                    data=new_data,
-                    format="json",
-                )
-
-                assert response.status_code == 200
+            assert response.status_code == 200
 
         access.refresh_from_db()
         updated_values = serializers.DocumentAccessSerializer(instance=access).data
@@ -561,28 +727,23 @@ def test_api_document_accesses_update_owner(
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_update_owner_self(
-    via,
-    mock_user_teams,
-    mock_reset_connections,  # pylint: disable=redefined-outer-name
-):
+def test_api_document_accesses_update_owner_self(via, mock_user_get_teams):
     """
     A user who is owner of a document should be allowed to update
     their own user access provided there are other owners in the document.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
     document = factories.DocumentFactory()
-    access = None
     if via == USER:
         access = factories.UserDocumentAccessFactory(
             document=document, user=user, role="owner"
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         access = factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role="owner"
         )
@@ -603,23 +764,21 @@ def test_api_document_accesses_update_owner_self(
     # Add another owner and it should now work
     factories.UserDocumentAccessFactory(document=document, role="owner")
 
-    user_id = str(access.user_id) if via == USER else None
-    with mock_reset_connections(document.id, user_id):
-        response = client.put(
-            f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-            data={
-                **old_values,
-                "role": new_role,
-                "user_id": old_values.get("user", {}).get("id")
-                if old_values.get("user") is not None
-                else None,
-            },
-            format="json",
-        )
+    response = client.put(
+        f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
+        data={
+            **old_values,
+            "role": new_role,
+            "user_id": old_values.get("user", {}).get("id")
+            if old_values.get("user") is not None
+            else None,
+        },
+        format="json",
+    )
 
-        assert response.status_code == 200
-        access.refresh_from_db()
-        assert access.role == new_role
+    assert response.status_code == 200
+    access.refresh_from_db()
+    assert access.role == new_role
 
 
 # Delete
@@ -642,7 +801,7 @@ def test_api_document_accesses_delete_authenticated():
     Authenticated users should not be allowed to delete a document access for a
     document to which they are not related.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -654,17 +813,17 @@ def test_api_document_accesses_delete_authenticated():
     )
 
     assert response.status_code == 403
-    assert models.DocumentAccess.objects.count() == 2
+    assert models.DocumentAccess.objects.count() == 1
 
 
 @pytest.mark.parametrize("role", ["reader", "editor"])
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_delete_reader_or_editor(via, role, mock_user_teams):
+def test_api_document_accesses_delete_reader_or_editor(via, role, mock_user_get_teams):
     """
     Authenticated users should not be allowed to delete a document access for a
     document in which they are a simple reader or editor.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -673,14 +832,14 @@ def test_api_document_accesses_delete_reader_or_editor(via, role, mock_user_team
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user, role=role)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role=role
         )
 
     access = factories.UserDocumentAccessFactory(document=document)
 
-    assert models.DocumentAccess.objects.count() == 3
+    assert models.DocumentAccess.objects.count() == 2
     assert models.DocumentAccess.objects.filter(user=access.user).exists()
 
     response = client.delete(
@@ -688,14 +847,12 @@ def test_api_document_accesses_delete_reader_or_editor(via, role, mock_user_team
     )
 
     assert response.status_code == 403
-    assert models.DocumentAccess.objects.count() == 3
+    assert models.DocumentAccess.objects.count() == 2
 
 
 @pytest.mark.parametrize("via", VIA)
 def test_api_document_accesses_delete_administrators_except_owners(
-    via,
-    mock_user_teams,
-    mock_reset_connections,  # pylint: disable=redefined-outer-name
+    via, mock_user_get_teams
 ):
     """
     Users who are administrators in a document should be allowed to delete an access
@@ -712,7 +869,7 @@ def test_api_document_accesses_delete_administrators_except_owners(
             document=document, user=user, role="administrator"
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role="administrator"
         )
@@ -724,22 +881,21 @@ def test_api_document_accesses_delete_administrators_except_owners(
     assert models.DocumentAccess.objects.count() == 2
     assert models.DocumentAccess.objects.filter(user=access.user).exists()
 
-    with mock_reset_connections(document.id, str(access.user_id)):
-        response = client.delete(
-            f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-        )
+    response = client.delete(
+        f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
+    )
 
-        assert response.status_code == 204
-        assert models.DocumentAccess.objects.count() == 1
+    assert response.status_code == 204
+    assert models.DocumentAccess.objects.count() == 1
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_delete_administrator_on_owners(via, mock_user_teams):
+def test_api_document_accesses_delete_administrator_on_owners(via, mock_user_get_teams):
     """
     Users who are administrators in a document should not be allowed to delete an ownership
     access from the document.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -750,14 +906,14 @@ def test_api_document_accesses_delete_administrator_on_owners(via, mock_user_tea
             document=document, user=user, role="administrator"
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role="administrator"
         )
 
     access = factories.UserDocumentAccessFactory(document=document, role="owner")
 
-    assert models.DocumentAccess.objects.count() == 3
+    assert models.DocumentAccess.objects.count() == 2
     assert models.DocumentAccess.objects.filter(user=access.user).exists()
 
     response = client.delete(
@@ -765,15 +921,11 @@ def test_api_document_accesses_delete_administrator_on_owners(via, mock_user_tea
     )
 
     assert response.status_code == 403
-    assert models.DocumentAccess.objects.count() == 3
+    assert models.DocumentAccess.objects.count() == 2
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_delete_owners(
-    via,
-    mock_user_teams,
-    mock_reset_connections,  # pylint: disable=redefined-outer-name
-):
+def test_api_document_accesses_delete_owners(via, mock_user_get_teams):
     """
     Users should be able to delete the document access of another user
     for a document of which they are owner.
@@ -787,7 +939,7 @@ def test_api_document_accesses_delete_owners(
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user, role="owner")
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role="owner"
         )
@@ -797,41 +949,39 @@ def test_api_document_accesses_delete_owners(
     assert models.DocumentAccess.objects.count() == 2
     assert models.DocumentAccess.objects.filter(user=access.user).exists()
 
-    with mock_reset_connections(document.id, str(access.user_id)):
-        response = client.delete(
-            f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-        )
+    response = client.delete(
+        f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
+    )
 
-        assert response.status_code == 204
-        assert models.DocumentAccess.objects.count() == 1
+    assert response.status_code == 204
+    assert models.DocumentAccess.objects.count() == 1
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_delete_owners_last_owner(via, mock_user_teams):
+def test_api_document_accesses_delete_owners_last_owner(via, mock_user_get_teams):
     """
     It should not be possible to delete the last owner access from a document
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
     document = factories.DocumentFactory()
-    access = None
     if via == USER:
         access = factories.UserDocumentAccessFactory(
             document=document, user=user, role="owner"
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         access = factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role="owner"
         )
 
-    assert models.DocumentAccess.objects.count() == 2
+    assert models.DocumentAccess.objects.count() == 1
     response = client.delete(
         f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
     )
 
     assert response.status_code == 403
-    assert models.DocumentAccess.objects.count() == 2
+    assert models.DocumentAccess.objects.count() == 1

src/backend/core/tests/test_api_document_invitations.py

@@ -0,0 +1,504 @@
+"""
+Unit tests for the Invitation model
+"""
+import random
+import time
+
+import pytest
+from rest_framework import status
+from rest_framework.test import APIClient
+
+from core import factories, models
+from core.tests.conftest import TEAM, USER, VIA
+
+pytestmark = pytest.mark.django_db
+
+
+def test_api_document_invitations__create__anonymous():
+    """Anonymous users should not be able to create invitations."""
+    document = factories.DocumentFactory()
+    invitation_values = {
+        "email": "guest@example.com",
+        "role": random.choice(models.RoleChoices.choices)[0],
+    }
+
+    response = APIClient().post(
+        f"/api/v1.0/documents/{document.id}/invitations/",
+        invitation_values,
+        format="json",
+    )
+
+    assert response.status_code == status.HTTP_401_UNAUTHORIZED
+    assert response.json() == {
+        "detail": "Authentication credentials were not provided."
+    }
+
+
+def test_api_document_invitations__create__authenticated_outsider():
+    """Users outside of document should not be permitted to invite to document."""
+    user = factories.UserFactory()
+    document = factories.DocumentFactory()
+    invitation_values = {
+        "email": "guest@example.com",
+        "role": random.choice(models.RoleChoices.choices)[0],
+    }
+
+    client = APIClient()
+    client.force_login(user)
+    response = client.post(
+        f"/api/v1.0/documents/{document.id}/invitations/",
+        invitation_values,
+        format="json",
+    )
+
+    assert response.status_code == status.HTTP_403_FORBIDDEN
+
+
+@pytest.mark.parametrize(
+    "inviting,invited,is_allowed",
+    (
+        ["reader", "reader", False],
+        ["reader", "editor", False],
+        ["reader", "administrator", False],
+        ["reader", "owner", False],
+        ["editor", "reader", False],
+        ["editor", "editor", False],
+        ["editor", "administrator", False],
+        ["editor", "owner", False],
+        ["administrator", "reader", True],
+        ["administrator", "editor", True],
+        ["administrator", "administrator", True],
+        ["administrator", "owner", False],
+        ["owner", "reader", True],
+        ["owner", "editor", True],
+        ["owner", "administrator", True],
+        ["owner", "owner", True],
+    ),
+)
+@pytest.mark.parametrize("via", VIA)
+def test_api_document_invitations__create__privileged_members(
+    via, inviting, invited, is_allowed, mock_user_get_teams
+):
+    """
+    Only owners and administrators should be able to invite new users.
+    Only owners can invite owners.
+    """
+    user = factories.UserFactory()
+    document = factories.DocumentFactory()
+    if via == USER:
+        factories.UserDocumentAccessFactory(document=document, user=user, role=inviting)
+    elif via == TEAM:
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
+        factories.TeamDocumentAccessFactory(
+            document=document, team="lasuite", role=inviting
+        )
+
+    invitation_values = {
+        "email": "guest@example.com",
+        "role": invited,
+    }
+
+    client = APIClient()
+    client.force_login(user)
+    response = client.post(
+        f"/api/v1.0/documents/{document.id}/invitations/",
+        invitation_values,
+        format="json",
+    )
+    if is_allowed:
+        assert response.status_code == status.HTTP_201_CREATED
+        assert models.Invitation.objects.count() == 1
+    else:
+        assert response.status_code == status.HTTP_403_FORBIDDEN
+        assert models.Invitation.objects.exists() is False
+
+
+def test_api_document_invitations__create__issuer_and_document_override():
+    """It should not be possible to set the "document" and "issuer" fields."""
+    user = factories.UserFactory()
+    document = factories.DocumentFactory(users=[(user, "owner")])
+    other_document = factories.DocumentFactory(users=[(user, "owner")])
+    invitation_values = {
+        "document": str(other_document.id),
+        "issuer": str(factories.UserFactory().id),
+        "email": "guest@example.com",
+        "role": random.choice(models.RoleChoices.choices)[0],
+    }
+
+    client = APIClient()
+    client.force_login(user)
+    response = client.post(
+        f"/api/v1.0/documents/{document.id}/invitations/",
+        invitation_values,
+        format="json",
+    )
+
+    assert response.status_code == status.HTTP_201_CREATED
+    # document and issuer automatically set
+    assert response.json()["document"] == str(document.id)
+    assert response.json()["issuer"] == str(user.id)
+
+
+def test_api_document_invitations__create__cannot_duplicate_invitation():
+    """An email should not be invited multiple times to the same document."""
+    existing_invitation = factories.InvitationFactory()
+    document = existing_invitation.document
+
+    # Grant privileged role on the Document to the user
+    user = factories.UserFactory()
+    models.DocumentAccess.objects.create(
+        document=document, user=user, role="administrator"
+    )
+
+    # Create a new invitation to the same document with the exact same email address
+    invitation_values = {
+        "email": existing_invitation.email,
+        "role": random.choice(["administrator", "editor", "reader"]),
+    }
+
+    client = APIClient()
+    client.force_login(user)
+    response = client.post(
+        f"/api/v1.0/documents/{document.id}/invitations/",
+        invitation_values,
+        format="json",
+    )
+
+    assert response.status_code == status.HTTP_400_BAD_REQUEST
+    assert response.json()["__all__"] == [
+        "Document invitation with this Email address and Document already exists."
+    ]
+
+
+def test_api_document_invitations__create__cannot_invite_existing_users():
+    """
+    It should not be possible to invite already existing users.
+    """
+    user = factories.UserFactory()
+    document = factories.DocumentFactory(users=[(user, "owner")])
+    existing_user = factories.UserFactory()
+
+    # Build an invitation to the email of an exising identity in the db
+    invitation_values = {
+        "email": existing_user.email,
+        "role": random.choice(models.RoleChoices.choices)[0],
+    }
+
+    client = APIClient()
+    client.force_login(user)
+    response = client.post(
+        f"/api/v1.0/documents/{document.id}/invitations/",
+        invitation_values,
+        format="json",
+    )
+
+    assert response.status_code == status.HTTP_400_BAD_REQUEST
+    assert response.json()["email"] == [
+        "This email is already associated to a registered user."
+    ]
+
+
+def test_api_document_invitations__list__anonymous_user():
+    """Anonymous users should not be able to list invitations."""
+    document = factories.DocumentFactory()
+    response = APIClient().get(f"/api/v1.0/documents/{document.id}/invitations/")
+    assert response.status_code == status.HTTP_401_UNAUTHORIZED
+
+
+@pytest.mark.parametrize("via", VIA)
+def test_api_document_invitations__list__authenticated(
+    via, mock_user_get_teams, django_assert_num_queries
+):
+    """
+    Authenticated users should be able to list invitations for documents to which they are
+    related, whatever the role and including invitations issued by other users.
+    """
+    user = factories.UserFactory()
+    other_user = factories.UserFactory()
+    document = factories.DocumentFactory()
+    role = random.choice(models.RoleChoices.choices)[0]
+    if via == USER:
+        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
+    elif via == TEAM:
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
+        factories.TeamDocumentAccessFactory(
+            document=document, team="lasuite", role=role
+        )
+
+    invitation = factories.InvitationFactory(
+        document=document, role="administrator", issuer=user
+    )
+    other_invitations = factories.InvitationFactory.create_batch(
+        2, document=document, role="reader", issuer=other_user
+    )
+
+    # invitations from other documents should not be listed
+    other_document = factories.DocumentFactory()
+    factories.InvitationFactory.create_batch(2, document=other_document, role="reader")
+
+    client = APIClient()
+    client.force_login(user)
+    with django_assert_num_queries(3):
+        response = client.get(
+            f"/api/v1.0/documents/{document.id}/invitations/",
+        )
+    assert response.status_code == status.HTTP_200_OK
+    assert response.json()["count"] == 3
+    assert sorted(response.json()["results"], key=lambda x: x["created_at"]) == sorted(
+        [
+            {
+                "id": str(i.id),
+                "created_at": i.created_at.isoformat().replace("+00:00", "Z"),
+                "email": str(i.email),
+                "document": str(document.id),
+                "role": i.role,
+                "issuer": str(i.issuer.id),
+                "is_expired": False,
+                "abilities": {
+                    "destroy": role in ["administrator", "owner"],
+                    "update": False,
+                    "partial_update": False,
+                    "retrieve": True,
+                },
+            }
+            for i in [invitation, *other_invitations]
+        ],
+        key=lambda x: x["created_at"],
+    )
+
+
+def test_api_document_invitations__list__expired_invitations_still_listed(settings):
+    """
+    Expired invitations are still listed.
+    """
+    user = factories.UserFactory()
+    other_user = factories.UserFactory()
+
+    document = factories.DocumentFactory(
+        users=[(user, "administrator"), (other_user, "owner")]
+    )
+
+    # override settings to accelerate validation expiration
+    settings.INVITATION_VALIDITY_DURATION = 1  # second
+    expired_invitation = factories.InvitationFactory(
+        document=document,
+        role="reader",
+        issuer=user,
+    )
+    time.sleep(1)
+
+    client = APIClient()
+    client.force_login(user)
+    response = client.get(
+        f"/api/v1.0/documents/{document.id}/invitations/",
+    )
+    assert response.status_code == status.HTTP_200_OK
+    assert response.json()["count"] == 1
+    assert sorted(response.json()["results"], key=lambda x: x["created_at"]) == sorted(
+        [
+            {
+                "id": str(expired_invitation.id),
+                "created_at": expired_invitation.created_at.isoformat().replace(
+                    "+00:00", "Z"
+                ),
+                "email": str(expired_invitation.email),
+                "document": str(document.id),
+                "role": expired_invitation.role,
+                "issuer": str(expired_invitation.issuer.id),
+                "is_expired": True,
+                "abilities": {
+                    "destroy": True,
+                    "update": False,
+                    "partial_update": False,
+                    "retrieve": True,
+                },
+            },
+        ],
+        key=lambda x: x["created_at"],
+    )
+
+
+def test_api_document_invitations__retrieve__anonymous_user():
+    """
+    Anonymous users should not be able to retrieve invitations.
+    """
+
+    invitation = factories.InvitationFactory()
+    response = APIClient().get(
+        f"/api/v1.0/documents/{invitation.document.id}/invitations/{invitation.id}/",
+    )
+
+    assert response.status_code == status.HTTP_401_UNAUTHORIZED
+
+
+def test_api_document_invitations__retrieve__unrelated_user():
+    """
+    Authenticated unrelated users should not be able to retrieve invitations.
+    """
+    user = factories.UserFactory()
+    invitation = factories.InvitationFactory()
+
+    client = APIClient()
+    client.force_login(user)
+    response = client.get(
+        f"/api/v1.0/documents/{invitation.document.id!s}/invitations/{invitation.id!s}/",
+    )
+
+    assert response.status_code == status.HTTP_403_FORBIDDEN
+
+
+@pytest.mark.parametrize("via", VIA)
+def test_api_document_invitations__retrieve__document_member(via, mock_user_get_teams):
+    """
+    Authenticated users related to the document should be able to retrieve invitations
+    whatever their role in the document.
+    """
+    user = factories.UserFactory()
+    invitation = factories.InvitationFactory()
+    role = random.choice(models.RoleChoices.choices)[0]
+    if via == USER:
+        factories.UserDocumentAccessFactory(
+            document=invitation.document, user=user, role=role
+        )
+    elif via == TEAM:
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
+        factories.TeamDocumentAccessFactory(
+            document=invitation.document, team="lasuite", role=role
+        )
+
+    client = APIClient()
+    client.force_login(user)
+    response = client.get(
+        f"/api/v1.0/documents/{invitation.document.id}/invitations/{invitation.id}/",
+    )
+
+    assert response.status_code == status.HTTP_200_OK
+    assert response.json() == {
+        "id": str(invitation.id),
+        "created_at": invitation.created_at.isoformat().replace("+00:00", "Z"),
+        "email": invitation.email,
+        "document": str(invitation.document.id),
+        "role": str(invitation.role),
+        "issuer": str(invitation.issuer.id),
+        "is_expired": False,
+        "abilities": {
+            "destroy": role in ["administrator", "owner"],
+            "update": False,
+            "partial_update": False,
+            "retrieve": True,
+        },
+    }
+
+
+@pytest.mark.parametrize("via", VIA)
+@pytest.mark.parametrize(
+    "method",
+    ["put", "patch"],
+)
+def test_api_document_invitations__update__forbidden(method, via, mock_user_get_teams):
+    """
+    Update of invitations is currently forbidden.
+    """
+    user = factories.UserFactory()
+    invitation = factories.InvitationFactory()
+    if via == USER:
+        factories.UserDocumentAccessFactory(
+            document=invitation.document, user=user, role="owner"
+        )
+    elif via == TEAM:
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
+        factories.TeamDocumentAccessFactory(
+            document=invitation.document, team="lasuite", role="owner"
+        )
+
+    client = APIClient()
+    client.force_login(user)
+    url = f"/api/v1.0/documents/{invitation.document.id}/invitations/{invitation.id}/"
+    if method == "put":
+        response = client.put(url)
+    if method == "patch":
+        response = client.patch(url)
+
+    assert response.status_code == status.HTTP_405_METHOD_NOT_ALLOWED
+    assert response.json()["detail"] == f'Method "{method.upper()}" not allowed.'
+
+
+def test_api_document_invitations__delete__anonymous():
+    """Anonymous user should not be able to delete invitations."""
+    invitation = factories.InvitationFactory()
+
+    response = APIClient().delete(
+        f"/api/v1.0/documents/{invitation.document.id}/invitations/{invitation.id}/",
+    )
+    assert response.status_code == status.HTTP_401_UNAUTHORIZED
+
+
+def test_api_document_invitations__delete__authenticated_outsider():
+    """Members unrelated to a document should not be allowed to cancel invitations."""
+    user = factories.UserFactory()
+
+    document = factories.DocumentFactory()
+    invitation = factories.InvitationFactory(document=document)
+
+    client = APIClient()
+    client.force_login(user)
+    response = client.delete(
+        f"/api/v1.0/documents/{document.id}/invitations/{invitation.id}/",
+    )
+    assert response.status_code == status.HTTP_403_FORBIDDEN
+
+
+@pytest.mark.parametrize("via", VIA)
+@pytest.mark.parametrize("role", ["owner", "administrator"])
+def test_api_document_invitations__delete__privileged_members(
+    role, via, mock_user_get_teams
+):
+    """Privileged member should be able to cancel invitation."""
+    user = factories.UserFactory()
+    document = factories.DocumentFactory()
+    if via == USER:
+        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
+    elif via == TEAM:
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
+        factories.TeamDocumentAccessFactory(
+            document=document, team="lasuite", role=role
+        )
+
+    invitation = factories.InvitationFactory(document=document)
+
+    client = APIClient()
+    client.force_login(user)
+    response = client.delete(
+        f"/api/v1.0/documents/{document.id}/invitations/{invitation.id}/",
+    )
+    assert response.status_code == status.HTTP_204_NO_CONTENT
+
+
+@pytest.mark.parametrize("role", ["reader", "editor"])
+@pytest.mark.parametrize("via", VIA)
+def test_api_document_invitations_delete_readers_or_editors(
+    via, role, mock_user_get_teams
+):
+    """Readers or editors should not be able to cancel invitation."""
+    user = factories.UserFactory()
+    document = factories.DocumentFactory()
+    if via == USER:
+        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
+    elif via == TEAM:
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
+        factories.TeamDocumentAccessFactory(
+            document=document, team="lasuite", role=role
+        )
+
+    invitation = factories.InvitationFactory(document=document)
+
+    client = APIClient()
+    client.force_login(user)
+    response = client.delete(
+        f"/api/v1.0/documents/{document.id}/invitations/{invitation.id}/",
+    )
+    assert response.status_code == status.HTTP_403_FORBIDDEN
+    assert (
+        response.json()["detail"]
+        == "You do not have permission to perform this action."
+    )

src/backend/core/tests/test_api_document_versions.py

@@ -1,7 +1,6 @@
 """
 Test document versions API endpoints for users in impress's core app.
 """
-
 import random
 import time
 
@@ -14,37 +13,45 @@ from core.tests.conftest import TEAM, USER, VIA
 pytestmark = pytest.mark.django_db
 
 
-@pytest.mark.parametrize("reach", models.LinkReachChoices.values)
-@pytest.mark.parametrize("role", models.LinkRoleChoices.values)
-def test_api_document_versions_list_anonymous(role, reach):
+def test_api_document_versions_list_anonymous_public():
     """
-    Anonymous users should not be allowed to list document versions for a document
-    whatever the reach and role.
+    Anonymous users should not be allowed to list document versions for a public document.
     """
-    document = factories.DocumentFactory(link_role=role, link_reach=reach)
-
-    # Accesses and traces for other users should not interfere
-    factories.UserDocumentAccessFactory(document=document)
-    models.LinkTrace.objects.create(document=document, user=factories.UserFactory())
+    document = factories.DocumentFactory(is_public=True)
+    factories.UserDocumentAccessFactory.create_batch(2, document=document)
 
     response = APIClient().get(f"/api/v1.0/documents/{document.id!s}/versions/")
 
-    assert response.status_code == 403
-    assert response.json() == {"detail": "Authentication required."}
+    assert response.status_code == 401
+    assert response.json() == {
+        "detail": "Authentication credentials were not provided."
+    }
 
 
-@pytest.mark.parametrize("reach", models.LinkReachChoices.values)
-def test_api_document_versions_list_authenticated_unrelated(reach):
+def test_api_document_versions_list_anonymous_private():
     """
-    Authenticated users should not be allowed to list document versions for a document
+    Anonymous users should not be allowed to find document versions for a private document.
+    """
+    document = factories.DocumentFactory(is_public=False)
+    factories.UserDocumentAccessFactory.create_batch(2, document=document)
+
+    response = APIClient().get(f"/api/v1.0/documents/{document.id!s}/versions/")
+
+    assert response.status_code == 404
+    assert response.json() == {"detail": "Not found."}
+
+
+def test_api_document_versions_list_authenticated_unrelated_public():
+    """
+    Authenticated users should not be allowed to list document versions for a public document
     to which they are not related.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
-    document = factories.DocumentFactory(link_reach=reach)
+    document = factories.DocumentFactory(is_public=True)
     factories.UserDocumentAccessFactory.create_batch(3, document=document)
 
     # The versions of another document to which the user is related should not be listed either
@@ -59,8 +66,31 @@ def test_api_document_versions_list_authenticated_unrelated(reach):
     }
 
 
+def test_api_document_versions_list_authenticated_unrelated_private():
+    """
+    Authenticated users should not be allowed to find document versions for a private document
+    to which they are not related.
+    """
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    document = factories.DocumentFactory(is_public=False)
+    factories.UserDocumentAccessFactory.create_batch(3, document=document)
+
+    # The versions of another document to which the user is related should not be listed either
+    factories.UserDocumentAccessFactory(user=user)
+
+    response = client.get(
+        f"/api/v1.0/documents/{document.id!s}/versions/",
+    )
+    assert response.status_code == 404
+    assert response.json() == {"detail": "Not found."}
+
+
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_versions_list_authenticated_related_success(via, mock_user_teams):
+def test_api_document_versions_list_authenticated_related(via, mock_user_get_teams):
     """
     Authenticated users should be able to list document versions for a document
     to which they are directly related, whatever their role in the document.
@@ -78,7 +108,7 @@ def test_api_document_versions_list_authenticated_related_success(via, mock_user
             role=random.choice(models.RoleChoices.choices)[0],
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         models.DocumentAccess.objects.create(
             document=document,
             team="lasuite",
@@ -95,12 +125,11 @@ def test_api_document_versions_list_authenticated_related_success(via, mock_user
 
     assert response.status_code == 200
     content = response.json()
-    assert content["count"] == 0
+    assert len(content["versions"]) == 0
 
     # Add a new version to the document
-    for i in range(3):
-        document.content = f"new content {i:d}"
-        document.save()
+    document.content = "new content"
+    document.save()
 
     response = client.get(
         f"/api/v1.0/documents/{document.id!s}/versions/",
@@ -108,112 +137,16 @@ def test_api_document_versions_list_authenticated_related_success(via, mock_user
 
     assert response.status_code == 200
     content = response.json()
-    # The current version is not listed
-    assert content["count"] == 2
-
-
-@pytest.mark.parametrize("via", VIA)
-def test_api_document_versions_list_authenticated_related_pagination(
-    via, mock_user_teams
-):
-    """
-    The list of versions should be paginated and exclude versions that were created prior to the
-    user gaining access to the document.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory()
-    for i in range(3):
-        document.content = f"before {i:d}"
-        document.save()
-
-    if via == USER:
-        models.DocumentAccess.objects.create(
-            document=document,
-            user=user,
-            role=random.choice(models.RoleChoices.choices)[0],
-        )
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        models.DocumentAccess.objects.create(
-            document=document,
-            team="lasuite",
-            role=random.choice(models.RoleChoices.choices)[0],
-        )
-
-    for i in range(4):
-        document.content = f"after {i:d}"
-        document.save()
-
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/versions/",
-    )
-
-    content = response.json()
-    assert content["is_truncated"] is False
-    # The current version is not listed
-    assert content["count"] == 3
+    assert len(content["versions"]) == 1
     assert content["next_version_id_marker"] == ""
-    all_version_ids = [version["version_id"] for version in content["versions"]]
-
-    # - set page size
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/versions/?page_size=2",
-    )
-
-    content = response.json()
-    assert content["count"] == 2
-    assert content["is_truncated"] is True
-    marker = content["next_version_id_marker"]
-    assert marker == all_version_ids[1]
-    assert [
-        version["version_id"] for version in content["versions"]
-    ] == all_version_ids[:2]
-
-    # - get page 2
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/versions/?page_size=2&version_id={marker:s}",
-    )
-
-    content = response.json()
-    assert content["count"] == 1
     assert content["is_truncated"] is False
-    assert content["next_version_id_marker"] == ""
-    assert content["versions"][0]["version_id"] == all_version_ids[2]
 
 
-def test_api_document_versions_list_exceeds_max_page_size():
-    """Page size should not exceed the limit set on the serializer"""
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(users=[user])
-    document.content = "version 2"
-    document.save()
-
-    response = client.get(f"/api/v1.0/documents/{document.id!s}/versions/?page_size=51")
-
-    assert response.status_code == 400
-    assert response.json() == {
-        "page_size": ["Ensure this value is less than or equal to 50."]
-    }
-
-
-@pytest.mark.parametrize("reach", models.LinkReachChoices.values)
-def test_api_document_versions_retrieve_anonymous(reach):
+def test_api_document_versions_retrieve_anonymous_public():
     """
-    Anonymous users should not be allowed to find specific versions for a document with
-    restricted or authenticated link reach.
+    Anonymous users should not be allowed to retrieve specific versions for a public document.
     """
-    document = factories.DocumentFactory(link_reach=reach)
-    document.content = "new content"
-    document.save()
-
+    document = factories.DocumentFactory(is_public=True)
     version_id = document.get_versions_slice()["versions"][0]["version_id"]
 
     url = f"/api/v1.0/documents/{document.id!s}/versions/{version_id:s}/"
@@ -225,21 +158,31 @@ def test_api_document_versions_retrieve_anonymous(reach):
     }
 
 
-@pytest.mark.parametrize("reach", models.LinkReachChoices.values)
-def test_api_document_versions_retrieve_authenticated_unrelated(reach):
+def test_api_document_versions_retrieve_anonymous_private():
     """
-    Authenticated users should not be allowed to retrieve specific versions for a
+    Anonymous users should not be allowed to find specific versions for a private document.
+    """
+    document = factories.DocumentFactory(is_public=False)
+    version_id = document.get_versions_slice()["versions"][0]["version_id"]
+
+    url = f"/api/v1.0/documents/{document.id!s}/versions/{version_id:s}/"
+    response = APIClient().get(url)
+
+    assert response.status_code == 404
+    assert response.json() == {"detail": "Not found."}
+
+
+def test_api_document_versions_retrieve_authenticated_unrelated_public():
+    """
+    Authenticated users should not be allowed to retrieve specific versions for a public
     document to which they are not related.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
-    document = factories.DocumentFactory(link_reach=reach)
-    document.content = "new content"
-    document.save()
-
+    document = factories.DocumentFactory(is_public=True)
     version_id = document.get_versions_slice()["versions"][0]["version_id"]
 
     response = client.get(
@@ -251,11 +194,31 @@ def test_api_document_versions_retrieve_authenticated_unrelated(reach):
     }
 
 
+def test_api_document_versions_retrieve_authenticated_unrelated_private():
+    """
+    Authenticated users should not be allowed to find specific versions for a private document
+    to which they are not related.
+    """
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    document = factories.DocumentFactory(is_public=False)
+    version_id = document.get_versions_slice()["versions"][0]["version_id"]
+
+    response = client.get(
+        f"/api/v1.0/documents/{document.id!s}/versions/{version_id:s}/",
+    )
+    assert response.status_code == 404
+    assert response.json() == {"detail": "Not found."}
+
+
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_versions_retrieve_authenticated_related(via, mock_user_teams):
+def test_api_document_versions_retrieve_authenticated_related(via, mock_user_get_teams):
     """
     A user who is related to a document should be allowed to retrieve the
-    associated document versions.
+    associated document user accesses.
     """
     user = factories.UserFactory()
 
@@ -263,47 +226,26 @@ def test_api_document_versions_retrieve_authenticated_related(via, mock_user_tea
     client.force_login(user)
 
     document = factories.DocumentFactory()
-    document.content = "new content"
-    document.save()
-
-    assert len(document.get_versions_slice()["versions"]) == 1
     version_id = document.get_versions_slice()["versions"][0]["version_id"]
 
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(document=document, team="lasuite")
 
+    # Versions created before the document was shared should not be available to the user
+    response = client.get(
+        f"/api/v1.0/documents/{document.id!s}/versions/{version_id:s}/",
+    )
+
+    assert response.status_code == 404
+
+    # Create a new version should make it available to the user
     time.sleep(1)  # minio stores datetimes with the precision of a second
-
-    # Versions created before the document was shared should not be seen by the user
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/versions/{version_id:s}/",
-    )
-
-    assert response.status_code == 404
-
-    # Create a new version should not make it available to the user because
-    # only the current version is available to the user but it is excluded
-    # from the list
-    document.content = "new content 1"
+    document.content = "new content"
     document.save()
 
-    assert len(document.get_versions_slice()["versions"]) == 2
-    version_id = document.get_versions_slice()["versions"][0]["version_id"]
-
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/versions/{version_id:s}/",
-    )
-
-    assert response.status_code == 404
-
-    # Adding one more version should make the previous version available to the user
-    document.content = "new content 2"
-    document.save()
-
-    assert len(document.get_versions_slice()["versions"]) == 3
     version_id = document.get_versions_slice()["versions"][0]["version_id"]
 
     response = client.get(
@@ -311,7 +253,7 @@ def test_api_document_versions_retrieve_authenticated_related(via, mock_user_tea
     )
 
     assert response.status_code == 200
-    assert response.json()["content"] == "new content 1"
+    assert response.json()["content"] == "new content"
 
 
 def test_api_document_versions_create_anonymous():
@@ -324,8 +266,10 @@ def test_api_document_versions_create_anonymous():
         format="json",
     )
 
-    assert response.status_code == 405
-    assert response.json() == {"detail": 'Method "POST" not allowed.'}
+    assert response.status_code == 401
+    assert response.json() == {
+        "detail": "Authentication credentials were not provided."
+    }
 
 
 def test_api_document_versions_create_authenticated_unrelated():
@@ -350,7 +294,7 @@ def test_api_document_versions_create_authenticated_unrelated():
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_versions_create_authenticated_related(via, mock_user_teams):
+def test_api_document_versions_create_authenticated_related(via, mock_user_get_teams):
     """
     Authenticated users related to a document should not be allowed to create document versions
     whatever their role.
@@ -364,7 +308,7 @@ def test_api_document_versions_create_authenticated_related(via, mock_user_teams
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(document=document, team="lasuite")
 
     response = client.post(
@@ -379,19 +323,14 @@ def test_api_document_versions_create_authenticated_related(via, mock_user_teams
 def test_api_document_versions_update_anonymous():
     """Anonymous users should not be allowed to update a document version."""
     access = factories.UserDocumentAccessFactory()
-    document = access.document
-    document.content = "new content"
-    document.save()
-
-    assert len(document.get_versions_slice()["versions"]) == 1
-    version_id = document.get_versions_slice()["versions"][0]["version_id"]
+    version_id = access.document.get_versions_slice()["versions"][0]["version_id"]
 
     response = APIClient().put(
-        f"/api/v1.0/documents/{document.id!s}/versions/{version_id:s}/",
+        f"/api/v1.0/documents/{access.document_id!s}/versions/{version_id:s}/",
         {"foo": "bar"},
         format="json",
     )
-    assert response.status_code == 405
+    assert response.status_code == 401
 
 
 def test_api_document_versions_update_authenticated_unrelated():
@@ -405,12 +344,7 @@ def test_api_document_versions_update_authenticated_unrelated():
     client.force_login(user)
 
     access = factories.UserDocumentAccessFactory()
-    document = access.document
-    document.content = "new content"
-    document.save()
-
-    assert len(document.get_versions_slice()["versions"]) == 1
-    version_id = document.get_versions_slice()["versions"][0]["version_id"]
+    version_id = access.document.get_versions_slice()["versions"][0]["version_id"]
 
     response = client.put(
         f"/api/v1.0/documents/{access.document_id!s}/versions/{version_id:s}/",
@@ -421,7 +355,7 @@ def test_api_document_versions_update_authenticated_unrelated():
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_versions_update_authenticated_related(via, mock_user_teams):
+def test_api_document_versions_update_authenticated_related(via, mock_user_get_teams):
     """
     Authenticated users with access to a document should not be able to update its versions
     whatever their role.
@@ -432,21 +366,14 @@ def test_api_document_versions_update_authenticated_related(via, mock_user_teams
     client.force_login(user)
 
     document = factories.DocumentFactory()
+    version_id = document.get_versions_slice()["versions"][0]["version_id"]
 
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(document=document, team="lasuite")
 
-    time.sleep(1)  # minio stores datetimes with the precision of a second
-
-    document.content = "new content"
-    document.save()
-
-    assert len(document.get_versions_slice()["versions"]) == 1
-    version_id = document.get_versions_slice()["versions"][0]["version_id"]
-
     response = client.put(
         f"/api/v1.0/documents/{document.id!s}/versions/{version_id!s}/",
         {"foo": "bar"},
@@ -469,21 +396,17 @@ def test_api_document_versions_delete_anonymous():
     assert response.status_code == 401
 
 
-@pytest.mark.parametrize("reach", models.LinkReachChoices.values)
-def test_api_document_versions_delete_authenticated(reach):
+def test_api_document_versions_delete_authenticated_public():
     """
     Authenticated users should not be allowed to delete a document version for a
     public document to which they are not related.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
-    document = factories.DocumentFactory(link_reach=reach)
-    document.content = "new content"
-    document.save()
-
+    document = factories.DocumentFactory(is_public=True)
     version_id = document.get_versions_slice()["versions"][0]["version_id"]
 
     response = client.delete(
@@ -493,14 +416,35 @@ def test_api_document_versions_delete_authenticated(reach):
     assert response.status_code == 403
 
 
+def test_api_document_versions_delete_authenticated_private():
+    """
+    Authenticated users should not be allowed to find a document version to delete it
+    for a private document to which they are not related.
+    """
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    document = factories.DocumentFactory(is_public=False)
+    version_id = document.get_versions_slice()["versions"][0]["version_id"]
+
+    response = client.delete(
+        f"/api/v1.0/documents/{document.id!s}/versions/{version_id:s}/",
+    )
+
+    assert response.status_code == 404
+    assert response.json() == {"detail": "Not found."}
+
+
 @pytest.mark.parametrize("role", ["reader", "editor"])
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_versions_delete_reader_or_editor(via, role, mock_user_teams):
+def test_api_document_versions_delete_reader_or_editor(via, role, mock_user_get_teams):
     """
     Authenticated users should not be allowed to delete a document version for a
     document in which they are a simple reader or editor.
     """
-    user = factories.UserFactory(with_owned_document=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -509,7 +453,7 @@ def test_api_document_versions_delete_reader_or_editor(via, role, mock_user_team
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user, role=role)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role=role
         )
@@ -520,7 +464,13 @@ def test_api_document_versions_delete_reader_or_editor(via, role, mock_user_team
     document.save()
 
     versions = document.get_versions_slice()["versions"]
-    assert len(versions) == 1
+    assert len(versions) == 2
+
+    version_id = versions[1]["version_id"]
+    response = client.delete(
+        f"/api/v1.0/documents/{document.id!s}/versions/{version_id:s}/",
+    )
+    assert response.status_code == 403
 
     version_id = versions[0]["version_id"]
     response = client.delete(
@@ -529,11 +479,11 @@ def test_api_document_versions_delete_reader_or_editor(via, role, mock_user_team
     assert response.status_code == 403
 
     versions = document.get_versions_slice()["versions"]
-    assert len(versions) == 1
+    assert len(versions) == 2
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_versions_delete_administrator_or_owner(via, mock_user_teams):
+def test_api_document_versions_delete_administrator_or_owner(via, mock_user_get_teams):
     """
     Users who are administrator or owner of a document should be allowed to delete a version.
     """
@@ -547,32 +497,26 @@ def test_api_document_versions_delete_administrator_or_owner(via, mock_user_team
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user, role=role)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role=role
         )
 
     # Create a new version should make it available to the user
     time.sleep(1)  # minio stores datetimes with the precision of a second
-    document.content = "new content 1"
+    document.content = "new content"
     document.save()
 
     versions = document.get_versions_slice()["versions"]
-    assert len(versions) == 1
+    assert len(versions) == 2
 
-    version_id = versions[0]["version_id"]
+    version_id = versions[1]["version_id"]
     response = client.delete(
         f"/api/v1.0/documents/{document.id!s}/versions/{version_id:s}/",
     )
     # 404 because the version was created before the user was given access to the document
     assert response.status_code == 404
 
-    document.content = "new content 2"
-    document.save()
-
-    versions = document.get_versions_slice()["versions"]
-    assert len(versions) == 2
-
     version_id = versions[0]["version_id"]
     response = client.delete(
         f"/api/v1.0/documents/{document.id!s}/versions/{version_id:s}/",

src/backend/core/tests/test_api_template_accesses.py

@@ -1,7 +1,6 @@
 """
 Test template accesses API endpoints for users in impress's core app.
 """
-
 import random
 from uuid import uuid4
 
@@ -32,7 +31,7 @@ def test_api_template_accesses_list_authenticated_unrelated():
     Authenticated users should not be allowed to list template accesses for a template
     to which they are not related.
     """
-    user = factories.UserFactory(with_owned_template=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -57,18 +56,17 @@ def test_api_template_accesses_list_authenticated_unrelated():
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_template_accesses_list_authenticated_related(via, mock_user_teams):
+def test_api_template_accesses_list_authenticated_related(via, mock_user_get_teams):
     """
     Authenticated users should be able to list template accesses for a template
     to which they are directly related, whatever their role in the template.
     """
-    user = factories.UserFactory(with_owned_template=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
     template = factories.TemplateFactory()
-    user_access = None
     if via == USER:
         user_access = models.TemplateAccess.objects.create(
             template=template,
@@ -76,7 +74,7 @@ def test_api_template_accesses_list_authenticated_related(via, mock_user_teams):
             role=random.choice(models.RoleChoices.choices)[0],
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         user_access = models.TemplateAccess.objects.create(
             template=template,
             team="lasuite",
@@ -146,7 +144,7 @@ def test_api_template_accesses_retrieve_authenticated_unrelated():
     Authenticated users should not be allowed to retrieve a template access for
     a template to which they are not related.
     """
-    user = factories.UserFactory(with_owned_template=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -172,18 +170,16 @@ def test_api_template_accesses_retrieve_authenticated_unrelated():
         )
 
         assert response.status_code == 404
-        assert response.json() == {
-            "detail": "No TemplateAccess matches the given query."
-        }
+        assert response.json() == {"detail": "Not found."}
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_template_accesses_retrieve_authenticated_related(via, mock_user_teams):
+def test_api_template_accesses_retrieve_authenticated_related(via, mock_user_get_teams):
     """
     A user who is related to a template should be allowed to retrieve the
     associated template user accesses.
     """
-    user = factories.UserFactory(with_owned_template=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -192,7 +188,7 @@ def test_api_template_accesses_retrieve_authenticated_related(via, mock_user_tea
     if via == USER:
         factories.UserTemplateAccessFactory(template=template, user=user)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(template=template, team="lasuite")
 
     access = factories.UserTemplateAccessFactory(template=template)
@@ -211,6 +207,201 @@ def test_api_template_accesses_retrieve_authenticated_related(via, mock_user_tea
     }
 
 
+def test_api_template_accesses_create_anonymous():
+    """Anonymous users should not be allowed to create template accesses."""
+    user = factories.UserFactory()
+    template = factories.TemplateFactory()
+
+    response = APIClient().post(
+        f"/api/v1.0/templates/{template.id!s}/accesses/",
+        {
+            "user": str(user.id),
+            "template": str(template.id),
+            "role": random.choice(models.RoleChoices.choices)[0],
+        },
+        format="json",
+    )
+
+    assert response.status_code == 401
+    assert response.json() == {
+        "detail": "Authentication credentials were not provided."
+    }
+    assert models.TemplateAccess.objects.exists() is False
+
+
+def test_api_template_accesses_create_authenticated_unrelated():
+    """
+    Authenticated users should not be allowed to create template accesses for a template to
+    which they are not related.
+    """
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    other_user = factories.UserFactory()
+    template = factories.TemplateFactory()
+
+    response = client.post(
+        f"/api/v1.0/templates/{template.id!s}/accesses/",
+        {
+            "user": str(other_user.id),
+        },
+        format="json",
+    )
+
+    assert response.status_code == 403
+    assert not models.TemplateAccess.objects.filter(user=other_user).exists()
+
+
+@pytest.mark.parametrize("role", ["reader", "editor"])
+@pytest.mark.parametrize("via", VIA)
+def test_api_template_accesses_create_authenticated_editor_or_reader(
+    via, role, mock_user_get_teams
+):
+    """Editors or readers of a template should not be allowed to create template accesses."""
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    template = factories.TemplateFactory()
+    if via == USER:
+        factories.UserTemplateAccessFactory(template=template, user=user, role=role)
+    elif via == TEAM:
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
+        factories.TeamTemplateAccessFactory(
+            template=template, team="lasuite", role=role
+        )
+
+    other_user = factories.UserFactory()
+
+    for new_role in [role[0] for role in models.RoleChoices.choices]:
+        response = client.post(
+            f"/api/v1.0/templates/{template.id!s}/accesses/",
+            {
+                "user": str(other_user.id),
+                "role": new_role,
+            },
+            format="json",
+        )
+
+        assert response.status_code == 403
+
+    assert not models.TemplateAccess.objects.filter(user=other_user).exists()
+
+
+@pytest.mark.parametrize("via", VIA)
+def test_api_template_accesses_create_authenticated_administrator(
+    via, mock_user_get_teams
+):
+    """
+    Administrators of a template should be able to create template accesses
+    except for the "owner" role.
+    """
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    template = factories.TemplateFactory()
+    if via == USER:
+        factories.UserTemplateAccessFactory(
+            template=template, user=user, role="administrator"
+        )
+    elif via == TEAM:
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
+        factories.TeamTemplateAccessFactory(
+            template=template, team="lasuite", role="administrator"
+        )
+
+    other_user = factories.UserFactory()
+
+    # It should not be allowed to create an owner access
+    response = client.post(
+        f"/api/v1.0/templates/{template.id!s}/accesses/",
+        {
+            "user": str(other_user.id),
+            "role": "owner",
+        },
+        format="json",
+    )
+
+    assert response.status_code == 403
+    assert response.json() == {
+        "detail": "Only owners of a resource can assign other users as owners."
+    }
+
+    # It should be allowed to create a lower access
+    role = random.choice(
+        [role[0] for role in models.RoleChoices.choices if role[0] != "owner"]
+    )
+
+    response = client.post(
+        f"/api/v1.0/templates/{template.id!s}/accesses/",
+        {
+            "user": str(other_user.id),
+            "role": role,
+        },
+        format="json",
+    )
+
+    assert response.status_code == 201
+    assert models.TemplateAccess.objects.filter(user=other_user).count() == 1
+    new_template_access = models.TemplateAccess.objects.filter(user=other_user).get()
+    assert response.json() == {
+        "abilities": new_template_access.get_abilities(user),
+        "id": str(new_template_access.id),
+        "team": "",
+        "role": role,
+        "user": str(other_user.id),
+    }
+
+
+@pytest.mark.parametrize("via", VIA)
+def test_api_template_accesses_create_authenticated_owner(via, mock_user_get_teams):
+    """
+    Owners of a template should be able to create template accesses whatever the role.
+    """
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    template = factories.TemplateFactory()
+    if via == USER:
+        factories.UserTemplateAccessFactory(template=template, user=user, role="owner")
+    elif via == TEAM:
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
+        factories.TeamTemplateAccessFactory(
+            template=template, team="lasuite", role="owner"
+        )
+
+    other_user = factories.UserFactory()
+
+    role = random.choice([role[0] for role in models.RoleChoices.choices])
+
+    response = client.post(
+        f"/api/v1.0/templates/{template.id!s}/accesses/",
+        {
+            "user": str(other_user.id),
+            "role": role,
+        },
+        format="json",
+    )
+
+    assert response.status_code == 201
+    assert models.TemplateAccess.objects.filter(user=other_user).count() == 1
+    new_template_access = models.TemplateAccess.objects.filter(user=other_user).get()
+    assert response.json() == {
+        "id": str(new_template_access.id),
+        "user": str(other_user.id),
+        "team": "",
+        "role": role,
+        "abilities": new_template_access.get_abilities(user),
+    }
+
+
 def test_api_template_accesses_update_anonymous():
     """Anonymous users should not be allowed to update a template access."""
     access = factories.UserTemplateAccessFactory()
@@ -241,14 +432,14 @@ def test_api_template_accesses_update_authenticated_unrelated():
     Authenticated users should not be allowed to update a template access for a template to which
     they are not related.
     """
-    user = factories.UserFactory(with_owned_template=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
     access = factories.UserTemplateAccessFactory()
-
     old_values = serializers.TemplateAccessSerializer(instance=access).data
+
     new_values = {
         "id": uuid4(),
         "user": factories.UserFactory().id,
@@ -271,10 +462,10 @@ def test_api_template_accesses_update_authenticated_unrelated():
 @pytest.mark.parametrize("role", ["reader", "editor"])
 @pytest.mark.parametrize("via", VIA)
 def test_api_template_accesses_update_authenticated_editor_or_reader(
-    via, role, mock_user_teams
+    via, role, mock_user_get_teams
 ):
     """Editors or readers of a template should not be allowed to update its accesses."""
-    user = factories.UserFactory(with_owned_template=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -283,7 +474,7 @@ def test_api_template_accesses_update_authenticated_editor_or_reader(
     if via == USER:
         factories.UserTemplateAccessFactory(template=template, user=user, role=role)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(
             template=template, team="lasuite", role=role
         )
@@ -311,12 +502,14 @@ def test_api_template_accesses_update_authenticated_editor_or_reader(
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_template_accesses_update_administrator_except_owner(via, mock_user_teams):
+def test_api_template_accesses_update_administrator_except_owner(
+    via, mock_user_get_teams
+):
     """
     A user who is a direct administrator in a template should be allowed to update a user
     access for this template, as long as they don't try to set the role to owner.
     """
-    user = factories.UserFactory(with_owned_template=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -327,7 +520,7 @@ def test_api_template_accesses_update_administrator_except_owner(via, mock_user_
             template=template, user=user, role="administrator"
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(
             template=template, team="lasuite", role="administrator"
         )
@@ -336,8 +529,8 @@ def test_api_template_accesses_update_administrator_except_owner(via, mock_user_
         template=template,
         role=random.choice(["administrator", "editor", "reader"]),
     )
-
     old_values = serializers.TemplateAccessSerializer(instance=access).data
+
     new_values = {
         "id": uuid4(),
         "user_id": factories.UserFactory().id,
@@ -368,12 +561,14 @@ def test_api_template_accesses_update_administrator_except_owner(via, mock_user_
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_template_accesses_update_administrator_from_owner(via, mock_user_teams):
+def test_api_template_accesses_update_administrator_from_owner(
+    via, mock_user_get_teams
+):
     """
     A user who is an administrator in a template, should not be allowed to update
     the user access of an "owner" for this template.
     """
-    user = factories.UserFactory(with_owned_template=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -384,7 +579,7 @@ def test_api_template_accesses_update_administrator_from_owner(via, mock_user_te
             template=template, user=user, role="administrator"
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(
             template=template, team="lasuite", role="administrator"
         )
@@ -393,8 +588,8 @@ def test_api_template_accesses_update_administrator_from_owner(via, mock_user_te
     access = factories.UserTemplateAccessFactory(
         template=template, user=other_user, role="owner"
     )
-
     old_values = serializers.TemplateAccessSerializer(instance=access).data
+
     new_values = {
         "id": uuid4(),
         "user_id": factories.UserFactory().id,
@@ -415,12 +610,12 @@ def test_api_template_accesses_update_administrator_from_owner(via, mock_user_te
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_template_accesses_update_administrator_to_owner(via, mock_user_teams):
+def test_api_template_accesses_update_administrator_to_owner(via, mock_user_get_teams):
     """
     A user who is an administrator in a template, should not be allowed to update
     the user access of another user to grant template ownership.
     """
-    user = factories.UserFactory(with_owned_template=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -431,7 +626,7 @@ def test_api_template_accesses_update_administrator_to_owner(via, mock_user_team
             template=template, user=user, role="administrator"
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(
             template=template, team="lasuite", role="administrator"
         )
@@ -442,8 +637,8 @@ def test_api_template_accesses_update_administrator_to_owner(via, mock_user_team
         user=other_user,
         role=random.choice(["administrator", "editor", "reader"]),
     )
-
     old_values = serializers.TemplateAccessSerializer(instance=access).data
+
     new_values = {
         "id": uuid4(),
         "user_id": factories.UserFactory().id,
@@ -469,12 +664,12 @@ def test_api_template_accesses_update_administrator_to_owner(via, mock_user_team
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_template_accesses_update_owner(via, mock_user_teams):
+def test_api_template_accesses_update_owner(via, mock_user_get_teams):
     """
     A user who is an owner in a template should be allowed to update
     a user access for this template whatever the role.
     """
-    user = factories.UserFactory(with_owned_template=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -483,7 +678,7 @@ def test_api_template_accesses_update_owner(via, mock_user_teams):
     if via == USER:
         factories.UserTemplateAccessFactory(template=template, user=user, role="owner")
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(
             template=template, team="lasuite", role="owner"
         )
@@ -492,8 +687,8 @@ def test_api_template_accesses_update_owner(via, mock_user_teams):
     access = factories.UserTemplateAccessFactory(
         template=template,
     )
-
     old_values = serializers.TemplateAccessSerializer(instance=access).data
+
     new_values = {
         "id": uuid4(),
         "user_id": factories.UserFactory().id,
@@ -525,26 +720,26 @@ def test_api_template_accesses_update_owner(via, mock_user_teams):
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_template_accesses_update_owner_self(via, mock_user_teams):
+def test_api_template_accesses_update_owner_self(via, mock_user_get_teams):
     """
     A user who is owner of a template should be allowed to update
     their own user access provided there are other owners in the template.
     """
-    user = factories.UserFactory(with_owned_template=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
     template = factories.TemplateFactory()
-    if via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        access = factories.TeamTemplateAccessFactory(
-            template=template, team="lasuite", role="owner"
-        )
-    else:
+    if via == USER:
         access = factories.UserTemplateAccessFactory(
             template=template, user=user, role="owner"
         )
+    elif via == TEAM:
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
+        access = factories.TeamTemplateAccessFactory(
+            template=template, team="lasuite", role="owner"
+        )
 
     old_values = serializers.TemplateAccessSerializer(instance=access).data
     new_role = random.choice(["administrator", "editor", "reader"])
@@ -593,7 +788,7 @@ def test_api_template_accesses_delete_authenticated():
     Authenticated users should not be allowed to delete a template access for a
     template to which they are not related.
     """
-    user = factories.UserFactory(with_owned_template=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -605,17 +800,17 @@ def test_api_template_accesses_delete_authenticated():
     )
 
     assert response.status_code == 403
-    assert models.TemplateAccess.objects.count() == 2
+    assert models.TemplateAccess.objects.count() == 1
 
 
 @pytest.mark.parametrize("role", ["reader", "editor"])
 @pytest.mark.parametrize("via", VIA)
-def test_api_template_accesses_delete_editor_or_reader(via, role, mock_user_teams):
+def test_api_template_accesses_delete_editor_or_reader(via, role, mock_user_get_teams):
     """
     Authenticated users should not be allowed to delete a template access for a
     template in which they are a simple editor or reader.
     """
-    user = factories.UserFactory(with_owned_template=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -624,14 +819,14 @@ def test_api_template_accesses_delete_editor_or_reader(via, role, mock_user_team
     if via == USER:
         factories.UserTemplateAccessFactory(template=template, user=user, role=role)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(
             template=template, team="lasuite", role=role
         )
 
     access = factories.UserTemplateAccessFactory(template=template)
 
-    assert models.TemplateAccess.objects.count() == 3
+    assert models.TemplateAccess.objects.count() == 2
     assert models.TemplateAccess.objects.filter(user=access.user).exists()
 
     response = client.delete(
@@ -639,12 +834,12 @@ def test_api_template_accesses_delete_editor_or_reader(via, role, mock_user_team
     )
 
     assert response.status_code == 403
-    assert models.TemplateAccess.objects.count() == 3
+    assert models.TemplateAccess.objects.count() == 2
 
 
 @pytest.mark.parametrize("via", VIA)
 def test_api_template_accesses_delete_administrators_except_owners(
-    via, mock_user_teams
+    via, mock_user_get_teams
 ):
     """
     Users who are administrators in a template should be allowed to delete an access
@@ -661,7 +856,7 @@ def test_api_template_accesses_delete_administrators_except_owners(
             template=template, user=user, role="administrator"
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(
             template=template, team="lasuite", role="administrator"
         )
@@ -682,12 +877,12 @@ def test_api_template_accesses_delete_administrators_except_owners(
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_template_accesses_delete_administrator_on_owners(via, mock_user_teams):
+def test_api_template_accesses_delete_administrator_on_owners(via, mock_user_get_teams):
     """
     Users who are administrators in a template should not be allowed to delete an ownership
     access from the template.
     """
-    user = factories.UserFactory(with_owned_template=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
@@ -698,14 +893,14 @@ def test_api_template_accesses_delete_administrator_on_owners(via, mock_user_tea
             template=template, user=user, role="administrator"
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(
             template=template, team="lasuite", role="administrator"
         )
 
     access = factories.UserTemplateAccessFactory(template=template, role="owner")
 
-    assert models.TemplateAccess.objects.count() == 3
+    assert models.TemplateAccess.objects.count() == 2
     assert models.TemplateAccess.objects.filter(user=access.user).exists()
 
     response = client.delete(
@@ -713,11 +908,11 @@ def test_api_template_accesses_delete_administrator_on_owners(via, mock_user_tea
     )
 
     assert response.status_code == 403
-    assert models.TemplateAccess.objects.count() == 3
+    assert models.TemplateAccess.objects.count() == 2
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_template_accesses_delete_owners(via, mock_user_teams):
+def test_api_template_accesses_delete_owners(via, mock_user_get_teams):
     """
     Users should be able to delete the template access of another user
     for a template of which they are owner.
@@ -731,7 +926,7 @@ def test_api_template_accesses_delete_owners(via, mock_user_teams):
     if via == USER:
         factories.UserTemplateAccessFactory(template=template, user=user, role="owner")
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamTemplateAccessFactory(
             template=template, team="lasuite", role="owner"
         )
@@ -750,31 +945,30 @@ def test_api_template_accesses_delete_owners(via, mock_user_teams):
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_template_accesses_delete_owners_last_owner(via, mock_user_teams):
+def test_api_template_accesses_delete_owners_last_owner(via, mock_user_get_teams):
     """
     It should not be possible to delete the last owner access from a template
     """
-    user = factories.UserFactory(with_owned_template=True)
+    user = factories.UserFactory()
 
     client = APIClient()
     client.force_login(user)
 
     template = factories.TemplateFactory()
-    access = None
     if via == USER:
         access = factories.UserTemplateAccessFactory(
             template=template, user=user, role="owner"
         )
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         access = factories.TeamTemplateAccessFactory(
             template=template, team="lasuite", role="owner"
         )
 
-    assert models.TemplateAccess.objects.count() == 2
+    assert models.TemplateAccess.objects.count() == 1
     response = client.delete(
         f"/api/v1.0/templates/{template.id!s}/accesses/{access.id!s}/",
     )
 
     assert response.status_code == 403
-    assert models.TemplateAccess.objects.count() == 2
+    assert models.TemplateAccess.objects.count() == 1

src/backend/core/tests/test_api_users.py

@@ -1,7 +1,6 @@
 """
 Test users API endpoints in the impress core app.
 """
-
 import pytest
 from rest_framework.test import APIClient
 
@@ -69,48 +68,6 @@ def test_api_users_list_query_email():
     assert user_ids == [str(nicole.id), str(frank.id)]
 
 
-def test_api_users_list_query_email_matching():
-    """While filtering by email, results should be filtered and sorted by similarity"""
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    alice = factories.UserFactory(email="alice.johnson@example.gouv.fr")
-    factories.UserFactory(email="jane.smith@example.gouv.fr")
-    michael_wilson = factories.UserFactory(email="michael.wilson@example.gouv.fr")
-    factories.UserFactory(email="david.jones@example.gouv.fr")
-    michael_brown = factories.UserFactory(email="michael.brown@example.gouv.fr")
-    factories.UserFactory(email="sophia.taylor@example.gouv.fr")
-
-    response = client.get(
-        "/api/v1.0/users/?q=michael.johnson@example.gouv.f",
-    )
-    assert response.status_code == 200
-    user_ids = [user["id"] for user in response.json()["results"]]
-    assert user_ids == [str(michael_wilson.id)]
-
-    response = client.get("/api/v1.0/users/?q=michael.johnson@example.gouv.fr")
-
-    assert response.status_code == 200
-    user_ids = [user["id"] for user in response.json()["results"]]
-    assert user_ids == [str(michael_wilson.id), str(alice.id), str(michael_brown.id)]
-
-    response = client.get(
-        "/api/v1.0/users/?q=ajohnson@example.gouv.f",
-    )
-    assert response.status_code == 200
-    user_ids = [user["id"] for user in response.json()["results"]]
-    assert user_ids == [str(alice.id)]
-
-    response = client.get(
-        "/api/v1.0/users/?q=michael.wilson@example.gouv.f",
-    )
-    assert response.status_code == 200
-    user_ids = [user["id"] for user in response.json()["results"]]
-    assert user_ids == [str(michael_wilson.id)]
-
-
 def test_api_users_list_query_email_exclude_doc_user():
     """
     Authenticated users should be able to list users
@@ -162,8 +119,6 @@ def test_api_users_retrieve_me_authenticated():
     assert response.json() == {
         "id": str(user.id),
         "email": user.email,
-        "full_name": user.full_name,
-        "short_name": user.short_name,
     }
 
 

src/backend/core/tests/test_api_utils_ai_document_rate_throttles.py

@@ -1,127 +0,0 @@
-"""
-Test throttling on documents for the AI endpoint.
-"""
-
-from unittest.mock import patch
-
-from django.core.cache import cache
-from django.test import override_settings
-
-import pytest
-from rest_framework.response import Response
-from rest_framework.test import APIRequestFactory
-from rest_framework.views import APIView
-
-from core.api.utils import AIDocumentRateThrottle
-
-
-class DocumentAPIView(APIView):
-    """A simple view to test the throttle"""
-
-    throttle_classes = [AIDocumentRateThrottle]
-
-    def get(self, request, *args, **kwargs):
-        """Minimal get method for testing purposes."""
-        return Response({"message": "Success"})
-
-
-@pytest.fixture(autouse=True)
-def clear_cache():
-    """Fixture to clear the cache before each test."""
-    cache.clear()
-
-
-@override_settings(AI_DOCUMENT_RATE_THROTTLE_RATES={"minute": 3, "hour": 6, "day": 10})
-@patch("time.time")
-def test_api_utils_ai_document_rate_throttle_minute_limit(mock_time):
-    """Test that minute limit is enforced."""
-    api_rf = APIRequestFactory()
-    mock_time.return_value = 1000000
-
-    # Simulate requests to the document API
-    for _i in range(3):  # 3 first requests should be allowed
-        request = api_rf.get("/documents/1/")
-        response = DocumentAPIView.as_view()(request, pk=1)
-        assert response.status_code == 200
-
-    # Simulate passage of time
-    mock_time.return_value += 59
-
-    # 4th request should be throttled
-    request = api_rf.get("/documents/1/")
-    response = DocumentAPIView.as_view()(request, pk=1)
-    assert response.status_code == 429
-
-    # After the 60s backoff wait time has passed, we can make a request again
-    mock_time.return_value += 1
-
-    request = api_rf.get("/documents/1/")
-    response = DocumentAPIView.as_view()(request, pk=1)
-    assert response.status_code == 200
-
-
-@override_settings(
-    AI_DOCUMENT_RATE_THROTTLE_RATES={"minute": 100000, "hour": 6, "day": 10}
-)
-@patch("time.time")
-def test_ai_document_rate_throttle_hour_limit(mock_time):
-    """Test that the hour limit is enforced without hitting the minute limit."""
-    api_rf = APIRequestFactory()
-    mock_time.return_value = 1000000
-
-    # Make requests to the document API, one per 21 seconds to avoid hitting the minute limit
-    for _i in range(6):
-        request = api_rf.get("/documents/1/")
-        response = DocumentAPIView.as_view()(request, pk=1)
-        assert response.status_code == 200
-
-        # Simulate passage of time
-        mock_time.return_value += 21
-
-    # Simulate passage of time
-    mock_time.return_value += 3600 - 6 * 21 - 1
-
-    # 7th request should be throttled
-    request = api_rf.get("/documents/1/")
-    response = DocumentAPIView.as_view()(request, pk=1)
-    assert response.status_code == 429
-
-    # After the 1h backoff wait time has passed, we can make a request again
-    mock_time.return_value += 1
-
-    request = api_rf.get("/documents/1/")
-    response = DocumentAPIView.as_view()(request, pk=1)
-    assert response.status_code == 200
-
-
-@override_settings(AI_DOCUMENT_RATE_THROTTLE_RATES={"minute": 3, "hour": 6, "day": 10})
-@patch("time.time")
-def test_api_utils_ai_document_rate_throttle_day_limit(mock_time):
-    """Test that day limit is enforced."""
-    api_rf = APIRequestFactory()
-    mock_time.return_value = 1000000
-
-    # Make requests to the document API, one per 10 minutes to avoid hitting
-    # the minute and hour limits
-    for _i in range(10):  # 10 requests should be allowed
-        request = api_rf.get("/documents/1/")
-        response = DocumentAPIView.as_view()(request, pk=1)
-        assert response.status_code == 200
-
-        # Simulate passage of time
-        mock_time.return_value += 60 * 10
-
-    # Simulate passage of time
-    mock_time.return_value += 24 * 3600 - 10 * 60 * 10 - 1
-
-    # 11th request should be throttled
-    request = api_rf.get("/documents/1/")
-    response = DocumentAPIView.as_view()(request, pk=1)
-    assert response.status_code == 429
-
-    # After the 24h backoff wait time has passed we can make a request again
-    mock_time.return_value += 1
-
-    request = api_rf.get("/documents/1/")
-    response = DocumentAPIView.as_view()(request, pk=1)
-    assert response.status_code == 200

src/backend/core/tests/test_api_utils_ai_user_rate_throttles.py

@@ -1,146 +0,0 @@
-"""
-Test throttling on users for the AI endpoint.
-"""
-
-from unittest.mock import patch
-from uuid import uuid4
-
-from django.core.cache import cache
-from django.test import override_settings
-
-import pytest
-from rest_framework.response import Response
-from rest_framework.test import APIRequestFactory
-from rest_framework.views import APIView
-
-from core.api.utils import AIUserRateThrottle
-from core.factories import UserFactory
-
-pytestmark = pytest.mark.django_db
-
-
-class DocumentAPIView(APIView):
-    """A simple view to test the throttle"""
-
-    throttle_classes = [AIUserRateThrottle]
-
-    def get(self, request, *args, **kwargs):
-        """Minimal get method for testing purposes."""
-        return Response({"message": "Success"})
-
-
-@pytest.fixture(autouse=True)
-def clear_cache():
-    """Fixture to clear the cache before each test."""
-    cache.clear()
-
-
-@override_settings(AI_USER_RATE_THROTTLE_RATES={"minute": 3, "hour": 6, "day": 10})
-@patch("time.time")
-def test_api_utils_ai_user_rate_throttle_minute_limit(mock_time):
-    """Test that minute limit is enforced."""
-    user = UserFactory()
-    api_rf = APIRequestFactory()
-    mock_time.return_value = 1000000
-
-    # Simulate requests to the document API
-    for _i in range(3):  # 3 first requests should be allowed
-        document_id = str(uuid4())
-        request = api_rf.get(f"/documents/{document_id:s}/")
-        request.user = user
-        response = DocumentAPIView.as_view()(request, pk=document_id)
-        assert response.status_code == 200
-
-    # Simulate passage of time
-    mock_time.return_value += 59
-
-    # 4th request should be throttled
-    document_id = str(uuid4())
-    request = api_rf.get(f"/documents/{document_id:s}/")
-    request.user = user
-    response = DocumentAPIView.as_view()(request, pk=document_id)
-    assert response.status_code == 429
-
-    # After the 60s backoff wait time has passed, we can make a request again
-    mock_time.return_value += 1
-
-    document_id = str(uuid4())
-    request = api_rf.get(f"/documents/{document_id:s}/")
-    request.user = user
-    response = DocumentAPIView.as_view()(request, pk=document_id)
-    assert response.status_code == 200
-
-
-@override_settings(AI_USER_RATE_THROTTLE_RATES={"minute": 100000, "hour": 6, "day": 10})
-@patch("time.time")
-def test_ai_user_rate_throttle_hour_limit(mock_time):
-    """Test that the hour limit is enforced without hitting the minute limit."""
-    user = UserFactory()
-    api_rf = APIRequestFactory()
-    mock_time.return_value = 1000000
-
-    # Make requests to the document API, one per 21 seconds to avoid hitting the minute limit
-    for _i in range(6):
-        document_id = str(uuid4())
-        request = api_rf.get(f"/documents/{document_id:s}/")
-        request.user = user
-        response = DocumentAPIView.as_view()(request, pk=document_id)
-        assert response.status_code == 200
-
-        # Simulate passage of time
-        mock_time.return_value += 21
-
-    # Simulate passage of time
-    mock_time.return_value += 3600 - 6 * 21 - 1
-
-    # 7th request should be throttled
-    request = api_rf.get(f"/documents/{document_id:s}/")
-    request.user = user
-    response = DocumentAPIView.as_view()(request, pk=document_id)
-    assert response.status_code == 429
-
-    # After the 1h backoff wait time has passed, we can make a request again
-    mock_time.return_value += 1
-
-    request = api_rf.get(f"/documents/{document_id:s}/")
-    request.user = user
-    response = DocumentAPIView.as_view()(request, pk=document_id)
-    assert response.status_code == 200
-
-
-@override_settings(AI_USER_RATE_THROTTLE_RATES={"minute": 3, "hour": 6, "day": 10})
-@patch("time.time")
-def test_api_utils_ai_user_rate_throttle_day_limit(mock_time):
-    """Test that day limit is enforced."""
-    user = UserFactory()
-    api_rf = APIRequestFactory()
-    mock_time.return_value = 1000000
-
-    # Make requests to the document API, one per 10 minutes to avoid hitting
-    # the minute and hour limits
-    for _i in range(10):  # 10 requests should be allowed
-        document_id = str(uuid4())
-        request = api_rf.get(f"/documents/{document_id:s}/")
-        request.user = user
-        response = DocumentAPIView.as_view()(request, pk=document_id)
-        assert response.status_code == 200
-
-        # Simulate passage of time
-        mock_time.return_value += 60 * 10
-
-    # Simulate passage of time
-    mock_time.return_value += 24 * 3600 - 10 * 60 * 10 - 1
-
-    # 11th request should be throttled
-    request = api_rf.get(f"/documents/{document_id:s}/")
-    request.user = user
-    response = DocumentAPIView.as_view()(request, pk=document_id)
-    assert response.status_code == 429
-
-    # After the 24h backoff wait time has passed we can make a request again
-    mock_time.return_value += 1
-
-    request = api_rf.get(f"/documents/{document_id:s}/")
-    request.user = user
-    response = DocumentAPIView.as_view()(request, pk=document_id)
-    assert response.status_code == 200

src/backend/core/tests/test_models_document_accesses.py

@@ -1,7 +1,6 @@
 """
 Unit tests for the DocumentAccess model
 """
-
 from django.contrib.auth.models import AnonymousUser
 from django.core.exceptions import ValidationError
 
@@ -319,7 +318,7 @@ def test_models_document_access_get_abilities_for_editor_of_administrator():
 
 
 def test_models_document_access_get_abilities_for_editor_of_editor_user(
-    django_assert_num_queries,
+    django_assert_num_queries
 ):
     """Check abilities of editor access for the editor of a document."""
     access = factories.UserDocumentAccessFactory(role="editor")
@@ -378,7 +377,7 @@ def test_models_document_access_get_abilities_for_reader_of_administrator():
 
 
 def test_models_document_access_get_abilities_for_reader_of_reader_user(
-    django_assert_num_queries,
+    django_assert_num_queries
 ):
     """Check abilities of reader access for the reader of a document."""
     access = factories.UserDocumentAccessFactory(role="reader")

src/backend/core/tests/test_models_documents.py

@@ -1,16 +1,9 @@
 """
 Unit tests for the Document model
 """
-
-import smtplib
-from logging import Logger
-from unittest import mock
-
 from django.contrib.auth.models import AnonymousUser
-from django.core import mail
 from django.core.exceptions import ValidationError
 from django.core.files.storage import default_storage
-from django.utils import timezone
 
 import pytest
 
@@ -32,23 +25,16 @@ def test_models_documents_id_unique():
         factories.DocumentFactory(id=document.id)
 
 
-def test_models_documents_creator_required():
-    """No field should be required on the Document model."""
-    models.Document.objects.create()
-
-
 def test_models_documents_title_null():
-    """The "title" field can be null."""
-    document = models.Document.objects.create(
-        title=None, creator=factories.UserFactory()
-    )
-    assert document.title is None
+    """The "title" field should not be null."""
+    with pytest.raises(ValidationError, match="This field cannot be null."):
+        models.Document.objects.create(title=None)
 
 
 def test_models_documents_title_empty():
-    """The "title" field can be empty."""
-    document = models.Document.objects.create(title="", creator=factories.UserFactory())
-    assert document.title == ""
+    """The "title" field should not be empty."""
+    with pytest.raises(ValidationError, match="This field cannot be blank."):
+        models.Document.objects.create(title="")
 
 
 def test_models_documents_title_max_length():
@@ -70,114 +56,64 @@ def test_models_documents_file_key():
 # get_abilities
 
 
-@pytest.mark.parametrize(
-    "is_authenticated,reach,role",
-    [
-        (True, "restricted", "reader"),
-        (True, "restricted", "editor"),
-        (False, "restricted", "reader"),
-        (False, "restricted", "editor"),
-        (False, "authenticated", "reader"),
-        (False, "authenticated", "editor"),
-    ],
-)
-def test_models_documents_get_abilities_forbidden(is_authenticated, reach, role):
-    """
-    Check abilities returned for a document giving insufficient roles to link holders
-    i.e anonymous users or authenticated users who have no specific role on the document.
-    """
-    document = factories.DocumentFactory(link_reach=reach, link_role=role)
-    user = factories.UserFactory() if is_authenticated else AnonymousUser()
-    abilities = document.get_abilities(user)
+def test_models_documents_get_abilities_anonymous_public():
+    """Check abilities returned for an anonymous user if the document is public."""
+    document = factories.DocumentFactory(is_public=True)
+    abilities = document.get_abilities(AnonymousUser())
     assert abilities == {
-        "accesses_manage": False,
-        "accesses_view": False,
-        "ai_transform": False,
-        "ai_translate": False,
-        "attachment_upload": False,
-        "collaboration_auth": False,
         "destroy": False,
-        "favorite": False,
-        "invite_owner": False,
-        "media_auth": False,
-        "link_configuration": False,
+        "retrieve": True,
+        "update": False,
+        "manage_accesses": False,
         "partial_update": False,
+        "versions_destroy": False,
+        "versions_list": False,
+        "versions_retrieve": False,
+    }
+
+
+def test_models_documents_get_abilities_anonymous_not_public():
+    """Check abilities returned for an anonymous user if the document is private."""
+    document = factories.DocumentFactory(is_public=False)
+    abilities = document.get_abilities(AnonymousUser())
+    assert abilities == {
+        "destroy": False,
         "retrieve": False,
         "update": False,
+        "manage_accesses": False,
+        "partial_update": False,
         "versions_destroy": False,
         "versions_list": False,
         "versions_retrieve": False,
     }
 
 
-@pytest.mark.parametrize(
-    "is_authenticated,reach",
-    [
-        (True, "public"),
-        (False, "public"),
-        (True, "authenticated"),
-    ],
-)
-def test_models_documents_get_abilities_reader(is_authenticated, reach):
-    """
-    Check abilities returned for a document giving reader role to link holders
-    i.e anonymous users or authenticated users who have no specific role on the document.
-    """
-    document = factories.DocumentFactory(link_reach=reach, link_role="reader")
-    user = factories.UserFactory() if is_authenticated else AnonymousUser()
-    abilities = document.get_abilities(user)
+def test_models_documents_get_abilities_authenticated_unrelated_public():
+    """Check abilities returned for an authenticated user if the user is public."""
+    document = factories.DocumentFactory(is_public=True)
+    abilities = document.get_abilities(factories.UserFactory())
     assert abilities == {
-        "accesses_manage": False,
-        "accesses_view": False,
-        "ai_transform": False,
-        "ai_translate": False,
-        "attachment_upload": False,
-        "collaboration_auth": True,
         "destroy": False,
-        "favorite": is_authenticated,
-        "invite_owner": False,
-        "link_configuration": False,
-        "media_auth": True,
-        "partial_update": False,
         "retrieve": True,
         "update": False,
+        "manage_accesses": False,
+        "partial_update": False,
         "versions_destroy": False,
         "versions_list": False,
         "versions_retrieve": False,
     }
 
 
-@pytest.mark.parametrize(
-    "is_authenticated,reach",
-    [
-        (True, "public"),
-        (False, "public"),
-        (True, "authenticated"),
-    ],
-)
-def test_models_documents_get_abilities_editor(is_authenticated, reach):
-    """
-    Check abilities returned for a document giving editor role to link holders
-    i.e anonymous users or authenticated users who have no specific role on the document.
-    """
-    document = factories.DocumentFactory(link_reach=reach, link_role="editor")
-    user = factories.UserFactory() if is_authenticated else AnonymousUser()
-    abilities = document.get_abilities(user)
+def test_models_documents_get_abilities_authenticated_unrelated_not_public():
+    """Check abilities returned for an authenticated user if the document is private."""
+    document = factories.DocumentFactory(is_public=False)
+    abilities = document.get_abilities(factories.UserFactory())
     assert abilities == {
-        "accesses_manage": False,
-        "accesses_view": False,
-        "ai_transform": True,
-        "ai_translate": True,
-        "attachment_upload": True,
-        "collaboration_auth": True,
         "destroy": False,
-        "favorite": is_authenticated,
-        "invite_owner": False,
-        "link_configuration": False,
-        "media_auth": True,
-        "partial_update": True,
-        "retrieve": True,
-        "update": True,
+        "retrieve": False,
+        "update": False,
+        "manage_accesses": False,
+        "partial_update": False,
         "versions_destroy": False,
         "versions_list": False,
         "versions_retrieve": False,
@@ -190,20 +126,11 @@ def test_models_documents_get_abilities_owner():
     access = factories.UserDocumentAccessFactory(role="owner", user=user)
     abilities = access.document.get_abilities(access.user)
     assert abilities == {
-        "accesses_manage": True,
-        "accesses_view": True,
-        "ai_transform": True,
-        "ai_translate": True,
-        "attachment_upload": True,
-        "collaboration_auth": True,
         "destroy": True,
-        "favorite": True,
-        "invite_owner": True,
-        "link_configuration": True,
-        "media_auth": True,
-        "partial_update": True,
         "retrieve": True,
         "update": True,
+        "manage_accesses": True,
+        "partial_update": True,
         "versions_destroy": True,
         "versions_list": True,
         "versions_retrieve": True,
@@ -215,20 +142,11 @@ def test_models_documents_get_abilities_administrator():
     access = factories.UserDocumentAccessFactory(role="administrator")
     abilities = access.document.get_abilities(access.user)
     assert abilities == {
-        "accesses_manage": True,
-        "accesses_view": True,
-        "ai_transform": True,
-        "ai_translate": True,
-        "attachment_upload": True,
-        "collaboration_auth": True,
         "destroy": False,
-        "favorite": True,
-        "invite_owner": False,
-        "link_configuration": True,
-        "media_auth": True,
-        "partial_update": True,
         "retrieve": True,
         "update": True,
+        "manage_accesses": True,
+        "partial_update": True,
         "versions_destroy": True,
         "versions_list": True,
         "versions_retrieve": True,
@@ -243,20 +161,11 @@ def test_models_documents_get_abilities_editor_user(django_assert_num_queries):
         abilities = access.document.get_abilities(access.user)
 
     assert abilities == {
-        "accesses_manage": False,
-        "accesses_view": True,
-        "ai_transform": True,
-        "ai_translate": True,
-        "attachment_upload": True,
-        "collaboration_auth": True,
         "destroy": False,
-        "favorite": True,
-        "invite_owner": False,
-        "link_configuration": False,
-        "media_auth": True,
-        "partial_update": True,
         "retrieve": True,
         "update": True,
+        "manage_accesses": False,
+        "partial_update": True,
         "versions_destroy": False,
         "versions_list": True,
         "versions_retrieve": True,
@@ -265,28 +174,17 @@ def test_models_documents_get_abilities_editor_user(django_assert_num_queries):
 
 def test_models_documents_get_abilities_reader_user(django_assert_num_queries):
     """Check abilities returned for the reader of a document."""
-    access = factories.UserDocumentAccessFactory(
-        role="reader", document__link_role="reader"
-    )
+    access = factories.UserDocumentAccessFactory(role="reader")
 
     with django_assert_num_queries(1):
         abilities = access.document.get_abilities(access.user)
 
     assert abilities == {
-        "accesses_manage": False,
-        "accesses_view": True,
-        "ai_transform": False,
-        "ai_translate": False,
-        "attachment_upload": False,
-        "collaboration_auth": True,
         "destroy": False,
-        "favorite": True,
-        "invite_owner": False,
-        "link_configuration": False,
-        "media_auth": True,
-        "partial_update": False,
         "retrieve": True,
         "update": False,
+        "manage_accesses": False,
+        "partial_update": False,
         "versions_destroy": False,
         "versions_list": True,
         "versions_retrieve": True,
@@ -295,41 +193,30 @@ def test_models_documents_get_abilities_reader_user(django_assert_num_queries):
 
 def test_models_documents_get_abilities_preset_role(django_assert_num_queries):
     """No query is done if the role is preset e.g. with query annotation."""
-    access = factories.UserDocumentAccessFactory(
-        role="reader", document__link_role="reader"
-    )
+    access = factories.UserDocumentAccessFactory(role="reader")
     access.document.user_roles = ["reader"]
 
     with django_assert_num_queries(0):
         abilities = access.document.get_abilities(access.user)
 
     assert abilities == {
-        "accesses_manage": False,
-        "accesses_view": True,
-        "ai_transform": False,
-        "ai_translate": False,
-        "attachment_upload": False,
-        "collaboration_auth": True,
         "destroy": False,
-        "favorite": True,
-        "invite_owner": False,
-        "link_configuration": False,
-        "media_auth": True,
-        "partial_update": False,
         "retrieve": True,
         "update": False,
+        "manage_accesses": False,
+        "partial_update": False,
         "versions_destroy": False,
         "versions_list": True,
         "versions_retrieve": True,
     }
 
 
-def test_models_documents_get_versions_slice_pagination(settings):
+def test_models_documents_get_versions_slice(settings):
     """
     The "get_versions_slice" method should allow navigating all versions of
     the document with pagination.
     """
-    settings.DOCUMENT_VERSIONS_PAGE_SIZE = 4
+    settings.S3_VERSIONS_PAGE_SIZE = 4
 
     # Create a document with 7 versions
     document = factories.DocumentFactory()
@@ -337,7 +224,7 @@ def test_models_documents_get_versions_slice_pagination(settings):
         document.content = f"bar{i:d}"
         document.save()
 
-    # Add a document version not related to the first document
+    # Add a version not related to the first document
     factories.DocumentFactory()
 
     # - Get default max versions
@@ -355,7 +242,7 @@ def test_models_documents_get_versions_slice_pagination(settings):
         from_version_id=response["next_version_id_marker"]
     )
     assert response["is_truncated"] is False
-    assert len(response["versions"]) == 2
+    assert len(response["versions"]) == 3
     assert response["next_version_id_marker"] == ""
 
     # - Get custom max versions
@@ -365,30 +252,6 @@ def test_models_documents_get_versions_slice_pagination(settings):
     assert response["next_version_id_marker"] != ""
 
 
-def test_models_documents_get_versions_slice_min_datetime():
-    """
-    The "get_versions_slice" method should filter out versions anterior to
-    the from_datetime passed in argument and the current version.
-    """
-    document = factories.DocumentFactory()
-    from_dt = []
-    for i in range(6):
-        from_dt.append(timezone.now())
-        document.content = f"bar{i:d}"
-        document.save()
-
-    response = document.get_versions_slice(min_datetime=from_dt[2])
-
-    assert len(response["versions"]) == 3
-    for version in response["versions"]:
-        assert version["last_modified"] > from_dt[2]
-
-    response = document.get_versions_slice(min_datetime=from_dt[4])
-
-    assert len(response["versions"]) == 1
-    assert response["versions"][0]["last_modified"] > from_dt[4]
-
-
 def test_models_documents_version_duplicate():
     """A new version should be created in object storage only if the content has changed."""
     document = factories.DocumentFactory()
@@ -415,105 +278,3 @@ def test_models_documents_version_duplicate():
         Bucket=default_storage.bucket_name, Prefix=file_key
     )
     assert len(response["Versions"]) == 2
-
-
-def test_models_documents__email_invitation__success():
-    """
-    The email invitation is sent successfully.
-    """
-    document = factories.DocumentFactory()
-
-    # pylint: disable-next=no-member
-    assert len(mail.outbox) == 0
-
-    sender = factories.UserFactory(full_name="Test Sender", email="sender@example.com")
-    document.send_invitation_email(
-        "guest@example.com", models.RoleChoices.EDITOR, sender, "en"
-    )
-
-    # pylint: disable-next=no-member
-    assert len(mail.outbox) == 1
-
-    # pylint: disable-next=no-member
-    email = mail.outbox[0]
-
-    assert email.to == ["guest@example.com"]
-    email_content = " ".join(email.body.split())
-
-    assert (
-        f"Test Sender (sender@example.com) invited you with the role "editor" "
-        f"on the following document: {document.title}" in email_content
-    )
-    assert f"docs/{document.id}/" in email_content
-
-
-def test_models_documents__email_invitation__success_fr():
-    """
-    The email invitation is sent successfully in french.
-    """
-    document = factories.DocumentFactory()
-
-    # pylint: disable-next=no-member
-    assert len(mail.outbox) == 0
-
-    sender = factories.UserFactory(
-        full_name="Test Sender2", email="sender2@example.com"
-    )
-    document.send_invitation_email(
-        "guest2@example.com",
-        models.RoleChoices.OWNER,
-        sender,
-        "fr-fr",
-    )
-
-    # pylint: disable-next=no-member
-    assert len(mail.outbox) == 1
-
-    # pylint: disable-next=no-member
-    email = mail.outbox[0]
-
-    assert email.to == ["guest2@example.com"]
-    email_content = " ".join(email.body.split())
-
-    assert (
-        f"Test Sender2 (sender2@example.com) vous a invité avec le rôle "propriétaire" "
-        f"sur le document suivant: {document.title}" in email_content
-    )
-    assert f"docs/{document.id}/" in email_content
-
-
-@mock.patch(
-    "core.models.send_mail",
-    side_effect=smtplib.SMTPException("Error SMTPException"),
-)
-@mock.patch.object(Logger, "error")
-def test_models_documents__email_invitation__failed(mock_logger, _mock_send_mail):
-    """Check mail behavior when an SMTP error occurs when sent an email invitation."""
-    document = factories.DocumentFactory()
-
-    # pylint: disable-next=no-member
-    assert len(mail.outbox) == 0
-
-    sender = factories.UserFactory()
-    document.send_invitation_email(
-        "guest3@example.com",
-        models.RoleChoices.ADMIN,
-        sender,
-        "en",
-    )
-
-    # No email has been sent
-    # pylint: disable-next=no-member
-    assert len(mail.outbox) == 0
-
-    # Logger should be called
-    mock_logger.assert_called_once()
-
-    (
-        _,
-        emails,
-        exception,
-    ) = mock_logger.call_args.args
-
-    assert emails == ["guest3@example.com"]
-    assert isinstance(exception, smtplib.SMTPException)

src/backend/core/tests/test_models_invitations.py

@@ -2,12 +2,13 @@
 Unit tests for the Invitation model
 """
 
-from datetime import timedelta
+import smtplib
+import time
+from logging import Logger
 from unittest import mock
 
 from django.contrib.auth.models import AnonymousUser
-from django.core import exceptions
-from django.utils import timezone
+from django.core import exceptions, mail
 
 import pytest
 from faker import Faker
@@ -22,6 +23,13 @@ pytestmark = pytest.mark.django_db
 fake = Faker()
 
 
+def test_models_invitations_readonly_after_create():
+    """Existing invitations should be readonly."""
+    invitation = factories.InvitationFactory()
+    with pytest.raises(exceptions.PermissionDenied):
+        invitation.save()
+
+
 def test_models_invitations_email_no_empty_mail():
     """The "email" field should not be empty."""
     with pytest.raises(exceptions.ValidationError, match="This field cannot be blank"):
@@ -62,7 +70,7 @@ def test_models_invitations_role_among_choices():
         factories.InvitationFactory(role="boss")
 
 
-def test_models_invitations_is_expired():
+def test_models_invitations__is_expired(settings):
     """
     The 'is_expired' property should return False until validity duration
     is exceeded and True afterwards.
@@ -70,16 +78,13 @@ def test_models_invitations_is_expired():
     expired_invitation = factories.InvitationFactory()
     assert expired_invitation.is_expired is False
 
-    not_late = timezone.now() + timedelta(seconds=604799)
-    with mock.patch("django.utils.timezone.now", return_value=not_late):
-        assert expired_invitation.is_expired is False
+    settings.INVITATION_VALIDITY_DURATION = 1
+    time.sleep(1)
 
-    too_late = timezone.now() + timedelta(seconds=604800)  # 7 days
-    with mock.patch("django.utils.timezone.now", return_value=too_late):
-        assert expired_invitation.is_expired is True
+    assert expired_invitation.is_expired is True
 
 
-def test_models_invitationd_new_userd_convert_invitations_to_accesses():
+def test_models_invitation__new_user__convert_invitations_to_accesses():
     """
     Upon creating a new user, invitations linked to the email
     should be converted to accesses and then deleted.
@@ -114,7 +119,7 @@ def test_models_invitationd_new_userd_convert_invitations_to_accesses():
     ).exists()  # the other invitation remains
 
 
-def test_models_invitationd_new_user_filter_expired_invitations():
+def test_models_invitation__new_user__filter_expired_invitations():
     """
     Upon creating a new identity, valid invitations should be converted into accesses
     and expired invitations should remain unchanged.
@@ -144,8 +149,8 @@ def test_models_invitationd_new_user_filter_expired_invitations():
     ).exists()
 
 
-@pytest.mark.parametrize("num_invitations, num_queries", [(0, 3), (1, 7), (20, 7)])
-def test_models_invitationd_new_userd_user_creation_constant_num_queries(
+@pytest.mark.parametrize("num_invitations, num_queries", [(0, 3), (1, 6), (20, 6)])
+def test_models_invitation__new_user__user_creation_constant_num_queries(
     django_assert_num_queries, num_invitations, num_queries
 ):
     """
@@ -163,6 +168,67 @@ def test_models_invitationd_new_userd_user_creation_constant_num_queries(
         models.User.objects.create(email=user_email, password="!")
 
 
+def test_models_document_invitations_email():
+    """Check email invitation during invitation creation."""
+    member_access = factories.UserDocumentAccessFactory(role="reader")
+    document = member_access.document
+
+    # pylint: disable-next=no-member
+    assert len(mail.outbox) == 0
+
+    factories.UserDocumentAccessFactory(document=document)
+    invitation = factories.InvitationFactory(document=document, email="john@people.com")
+
+    # pylint: disable-next=no-member
+    assert len(mail.outbox) == 1
+
+    # pylint: disable-next=no-member
+    email = mail.outbox[0]
+
+    assert email.to == [invitation.email]
+    assert email.subject == "Invitation to join Impress!"
+
+    email_content = " ".join(email.body.split())
+    assert "Invitation to join Impress!" in email_content
+    assert "[//example.com]" in email_content
+
+
+@mock.patch(
+    "django.core.mail.send_mail",
+    side_effect=smtplib.SMTPException("Error SMTPException"),
+)
+@mock.patch.object(Logger, "error")
+def test_models_document_invitations_email_failed(mock_logger, _mock_send_mail):
+    """Check invitation behavior when an SMTP error occurs during invitation creation."""
+
+    member_access = factories.UserDocumentAccessFactory(role="reader")
+    document = member_access.document
+
+    # pylint: disable-next=no-member
+    assert len(mail.outbox) == 0
+
+    factories.UserDocumentAccessFactory(document=document)
+
+    # No error should be raised
+    invitation = factories.InvitationFactory(document=document, email="john@people.com")
+
+    # No email has been sent
+    # pylint: disable-next=no-member
+    assert len(mail.outbox) == 0
+
+    # Logger should be called
+    mock_logger.assert_called_once()
+
+    (
+        _,
+        email,
+        exception,
+    ) = mock_logger.call_args.args
+
+    assert email == invitation.email
+    assert isinstance(exception, smtplib.SMTPException)
+
+
 # get_abilities
 
 
@@ -194,7 +260,7 @@ def test_models_document_invitations_get_abilities_authenticated():
 @pytest.mark.parametrize("via", VIA)
 @pytest.mark.parametrize("role", ["administrator", "owner"])
 def test_models_document_invitations_get_abilities_privileged_member(
-    role, via, mock_user_teams
+    role, via, mock_user_get_teams
 ):
     """Check abilities for a document member with a privileged role."""
 
@@ -203,7 +269,7 @@ def test_models_document_invitations_get_abilities_privileged_member(
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user, role=role)
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role=role
         )
@@ -216,13 +282,13 @@ def test_models_document_invitations_get_abilities_privileged_member(
     assert abilities == {
         "destroy": True,
         "retrieve": True,
-        "partial_update": True,
-        "update": True,
+        "partial_update": False,
+        "update": False,
     }
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_models_document_invitations_get_abilities_reader(via, mock_user_teams):
+def test_models_document_invitations_get_abilities_reader(via, mock_user_get_teams):
     """Check abilities for a document reader with 'reader' role."""
 
     user = factories.UserFactory()
@@ -230,7 +296,7 @@ def test_models_document_invitations_get_abilities_reader(via, mock_user_teams):
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user, role="reader")
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role="reader"
         )
@@ -240,14 +306,14 @@ def test_models_document_invitations_get_abilities_reader(via, mock_user_teams):
 
     assert abilities == {
         "destroy": False,
-        "retrieve": False,
+        "retrieve": True,
         "partial_update": False,
         "update": False,
     }
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_models_document_invitations_get_abilities_editor(via, mock_user_teams):
+def test_models_document_invitations_get_abilities_editor(via, mock_user_get_teams):
     """Check abilities for a document editor with 'editor' role."""
 
     user = factories.UserFactory()
@@ -255,7 +321,7 @@ def test_models_document_invitations_get_abilities_editor(via, mock_user_teams):
     if via == USER:
         factories.UserDocumentAccessFactory(document=document, user=user, role="editor")
     elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
+        mock_user_get_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
             document=document, team="lasuite", role="editor"
         )
@@ -265,7 +331,7 @@ def test_models_document_invitations_get_abilities_editor(via, mock_user_teams):
 
     assert abilities == {
         "destroy": False,
-        "retrieve": False,
+        "retrieve": True,
         "partial_update": False,
         "update": False,
     }

src/backend/core/tests/test_models_template_accesses.py

@@ -1,7 +1,6 @@
 """
 Unit tests for the TemplateAccess model
 """
-
 from django.contrib.auth.models import AnonymousUser
 from django.core.exceptions import ValidationError
 
@@ -319,7 +318,7 @@ def test_models_template_access_get_abilities_for_editor_of_administrator():
 
 
 def test_models_template_access_get_abilities_for_editor_of_editor_user(
-    django_assert_num_queries,
+    django_assert_num_queries
 ):
     """Check abilities of editor access for the editor of a template."""
     access = factories.UserTemplateAccessFactory(role="editor")
@@ -378,7 +377,7 @@ def test_models_template_access_get_abilities_for_reader_of_administrator():
 
 
 def test_models_template_access_get_abilities_for_reader_of_reader_user(
-    django_assert_num_queries,
+    django_assert_num_queries
 ):
     """Check abilities of reader access for the reader of a template."""
     access = factories.UserTemplateAccessFactory(role="reader")

src/backend/core/tests/test_models_templates.py

@@ -1,11 +1,6 @@
 """
 Unit tests for the Template model
 """
-
-import os
-import time
-from unittest import mock
-
 from django.contrib.auth.models import AnonymousUser
 from django.core.exceptions import ValidationError
 
@@ -62,7 +57,7 @@ def test_models_templates_get_abilities_anonymous_public():
         "destroy": False,
         "retrieve": True,
         "update": False,
-        "accesses_manage": False,
+        "manage_accesses": False,
         "partial_update": False,
         "generate_document": True,
     }
@@ -76,7 +71,7 @@ def test_models_templates_get_abilities_anonymous_not_public():
         "destroy": False,
         "retrieve": False,
         "update": False,
-        "accesses_manage": False,
+        "manage_accesses": False,
         "partial_update": False,
         "generate_document": False,
     }
@@ -90,7 +85,7 @@ def test_models_templates_get_abilities_authenticated_public():
         "destroy": False,
         "retrieve": True,
         "update": False,
-        "accesses_manage": False,
+        "manage_accesses": False,
         "partial_update": False,
         "generate_document": True,
     }
@@ -104,7 +99,7 @@ def test_models_templates_get_abilities_authenticated_not_public():
         "destroy": False,
         "retrieve": False,
         "update": False,
-        "accesses_manage": False,
+        "manage_accesses": False,
         "partial_update": False,
         "generate_document": False,
     }
@@ -119,7 +114,7 @@ def test_models_templates_get_abilities_owner():
         "destroy": True,
         "retrieve": True,
         "update": True,
-        "accesses_manage": True,
+        "manage_accesses": True,
         "partial_update": True,
         "generate_document": True,
     }
@@ -133,7 +128,7 @@ def test_models_templates_get_abilities_administrator():
         "destroy": False,
         "retrieve": True,
         "update": True,
-        "accesses_manage": True,
+        "manage_accesses": True,
         "partial_update": True,
         "generate_document": True,
     }
@@ -150,7 +145,7 @@ def test_models_templates_get_abilities_editor_user(django_assert_num_queries):
         "destroy": False,
         "retrieve": True,
         "update": True,
-        "accesses_manage": False,
+        "manage_accesses": False,
         "partial_update": True,
         "generate_document": True,
     }
@@ -167,7 +162,7 @@ def test_models_templates_get_abilities_reader_user(django_assert_num_queries):
         "destroy": False,
         "retrieve": True,
         "update": False,
-        "accesses_manage": False,
+        "manage_accesses": False,
         "partial_update": False,
         "generate_document": True,
     }
@@ -185,35 +180,7 @@ def test_models_templates_get_abilities_preset_role(django_assert_num_queries):
         "destroy": False,
         "retrieve": True,
         "update": False,
-        "accesses_manage": False,
+        "manage_accesses": False,
         "partial_update": False,
         "generate_document": True,
     }
-
-
-def test_models_templates__generate_word():
-    """Generate word document and assert no tmp files are left in /tmp folder."""
-    template = factories.TemplateFactory()
-    response = template.generate_word("<p>Test body</p>", {})
-
-    assert response.status_code == 200
-    assert len([f for f in os.listdir("/tmp") if f.startswith("docx_")]) == 0
-
-
-@mock.patch(
-    "pypandoc.convert_text",
-    side_effect=RuntimeError("Conversion failed"),
-)
-def test_models_templates__generate_word__raise_error(_mock_pypandoc):
-    """
-    Generate word document and assert no tmp files are left in /tmp folder
-    even when the conversion fails.
-    """
-    template = factories.TemplateFactory()
-
-    try:
-        template.generate_word("<p>Test body</p>", {})
-    except RuntimeError as e:
-        assert str(e) == "Conversion failed"
-        time.sleep(0.5)
-        assert len([f for f in os.listdir("/tmp") if f.startswith("docx_")]) == 0