🔖(minor) release 1.7.0

Added:
- 📝Contributing.md
- 🌐(frontend) add localization to editor
- ✨Public and restricted doc editable
- ✨(frontend) Add full name if available

Changed:
- ♻️(frontend) avoid documents indexing in search engine

Fixed:
- 🐛(backend) require right to manage document
  accesses to see invitations
- 🐛(i18n) same frontend and backend language using
  shared cookies
- 🐛(frontend) add default toolbar buttons
- 🐛(frontend) throttle error correctly display

Removed:
- 🔥(helm) remove infra related codes

.github/workflows/crowdin_download.yml

@@ -1,76 +0,0 @@
-name: Download translations from Crowdin
-
-on:
-  workflow_dispatch:
-  push:
-    branches:
-      - 'release/**'
-
-jobs:
-  install-front:
-    uses: ./.github/workflows/front-dependencies-installation.yml
-    with:
-      node_version: '20.x'
-
-  synchronize-with-crowdin:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: write
-      pull-requests: write
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-      - name: Create empty source files
-        run: |
-          touch src/backend/locale/django.pot
-          mkdir -p src/frontend/packages/i18n/locales/impress/
-          touch src/frontend/packages/i18n/locales/impress/translations-crowdin.json
-      # crowdin workflow
-      - name: crowdin action
-        uses: crowdin/github-action@v2
-        with:
-          config: crowdin/config.yml
-          upload_sources: false
-          upload_translations: false
-          download_translations: true
-          create_pull_request: false
-          push_translations: false
-          push_sources: false
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          # A numeric ID, found at https://crowdin.com/project/<projectName>/tools/api
-          CROWDIN_PROJECT_ID: ${{ secrets.CROWDIN_PROJECT_ID }}
-
-          # Visit https://crowdin.com/settings#api-key to create this token
-          CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }}
-
-          CROWDIN_BASE_PATH: "../src/"
-      # frontend i18n
-      - name: Restore the frontend cache
-        uses: actions/cache@v4
-        with:
-          path: "src/frontend/**/node_modules"
-          key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }}
-          fail-on-cache-miss: true
-      - name: generate translations files
-        working-directory: src/frontend
-        run: yarn i18n:deploy
-      # Create a new PR
-      - name: Create a new Pull Request with new translated strings
-        uses: peter-evans/create-pull-request@v7
-        with:
-          commit-message: |
-            🌐(i18n) update translated strings
-
-            Update translated files with new translations
-          title: 🌐(i18n) update translated strings
-          body: |
-            ## Purpose
-
-            update translated strings
-
-            ## Proposal
-
-            - [x]  update translated strings
-          branch: i18n/update-translations
-          labels: i18n

.github/workflows/crowdin_upload.yml

@@ -1,67 +0,0 @@
-name: Update crowdin sources
-
-on:
-  workflow_dispatch:
-  push:
-    branches: 
-      - main
-
-jobs:
-  install-front:
-    uses: ./.github/workflows/front-dependencies-installation.yml
-    with:
-      node_version: '20.x'
-
-  synchronize-with-crowdin:
-    needs: install-front
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-      # Backend i18n
-      - name: Install Python
-        uses: actions/setup-python@v3
-        with:
-          python-version: "3.12.6"
-      - name: Upgrade pip and setuptools
-        run: pip install --upgrade pip setuptools
-      - name: Install development dependencies
-        run: pip install --user .
-        working-directory: src/backend
-      - name: Install gettext
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y gettext pandoc
-      - name: generate pot files
-        working-directory: src/backend
-        run: |
-          DJANGO_CONFIGURATION=Build python manage.py makemessages -a --keep-pot
-      # frontend i18n
-      - name: Restore the frontend cache
-        uses: actions/cache@v4
-        with:
-          path: "src/frontend/**/node_modules"
-          key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }}
-          fail-on-cache-miss: true
-      - name: generate source translation file
-        working-directory: src/frontend
-        run: yarn i18n:extract
-      # crowdin workflow
-      - name: crowdin action
-        uses: crowdin/github-action@v2
-        with:
-          config: crowdin/config.yml
-          upload_sources: true
-          upload_translations: false
-          download_translations: false
-          create_pull_request: false
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          # A numeric ID, found at https://crowdin.com/project/<projectName>/tools/api
-          CROWDIN_PROJECT_ID: ${{ secrets.CROWDIN_PROJECT_ID }}
-
-          # Visit https://crowdin.com/settings#api-key to create this token
-          CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }}
-
-          CROWDIN_BASE_PATH: "../src/"

.github/workflows/docker-hub.yml

@@ -8,9 +8,6 @@ on:
       - 'main'
     tags:
       - 'v*'
-  pull_request:
-    branches:
-      - 'main'
 
 env:
   DOCKER_USER: 1001:127
@@ -19,9 +16,26 @@ jobs:
   build-and-push-backend:
     runs-on: ubuntu-latest
     steps:
+      -
+        uses: actions/create-github-app-token@v1
+        id: app-token
+        with:
+          app-id: ${{ secrets.APP_ID }}
+          private-key: ${{ secrets.PRIVATE_KEY }}
+          owner: ${{ github.repository_owner }}
+          repositories: "impress,secrets"
       -
         name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v2
+        with:
+          submodules: recursive
+          token: ${{ steps.app-token.outputs.token }}
+      -
+        name: Load sops secrets
+        uses: rouja/actions-sops@main
+        with:
+          secret-file: secrets/numerique-gouv/impress/secrets.enc.env
+          age-key: ${{ secrets.SOPS_PRIVATE }}
       -
         name: Docker meta
         id: meta
@@ -31,14 +45,13 @@ jobs:
       -
         name: Login to DockerHub
         if: github.event_name != 'pull_request'
-        run: echo "${{ secrets.DOCKER_HUB_PASSWORD }}" | docker login -u "${{ secrets.DOCKER_HUB_USER }}" --password-stdin
+        run: echo "$DOCKER_HUB_PASSWORD" | docker login -u "$DOCKER_HUB_USER" --password-stdin
       -
         name: Run trivy scan
         uses: numerique-gouv/action-trivy-cache@main
         with:
           docker-build-args: '--target backend-production -f Dockerfile'
           docker-image-name: 'docker.io/lasuite/impress-backend:${{ github.sha }}'
-        continue-on-error: true
       -
         name: Build and push
         uses: docker/build-push-action@v6
@@ -53,9 +66,26 @@ jobs:
   build-and-push-frontend:
     runs-on: ubuntu-latest
     steps:
+      -
+        uses: actions/create-github-app-token@v1
+        id: app-token
+        with:
+          app-id: ${{ secrets.APP_ID }}
+          private-key: ${{ secrets.PRIVATE_KEY }}
+          owner: ${{ github.repository_owner }}
+          repositories: "impress,secrets"
       -
         name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v2
+        with:
+          submodules: recursive
+          token: ${{ steps.app-token.outputs.token }}
+      -
+        name: Load sops secrets
+        uses: rouja/actions-sops@main
+        with:
+          secret-file: secrets/numerique-gouv/impress/secrets.enc.env
+          age-key: ${{ secrets.SOPS_PRIVATE }}
       -
         name: Docker meta
         id: meta
@@ -65,14 +95,13 @@ jobs:
       -
         name: Login to DockerHub
         if: github.event_name != 'pull_request'
-        run: echo "${{ secrets.DOCKER_HUB_PASSWORD }}" | docker login -u "${{ secrets.DOCKER_HUB_USER }}" --password-stdin
+        run: echo "$DOCKER_HUB_PASSWORD" | docker login -u "$DOCKER_HUB_USER" --password-stdin
       -
         name: Run trivy scan
         uses: numerique-gouv/action-trivy-cache@main
         with:
           docker-build-args: '-f src/frontend/Dockerfile --target frontend-production'
           docker-image-name: 'docker.io/lasuite/impress-frontend:${{ github.sha }}'
-        continue-on-error: true
       -
         name: Build and push
         uses: docker/build-push-action@v6
@@ -88,9 +117,26 @@ jobs:
   build-and-push-y-provider:
     runs-on: ubuntu-latest
     steps:
+      -
+        uses: actions/create-github-app-token@v1
+        id: app-token
+        with:
+          app-id: ${{ secrets.APP_ID }}
+          private-key: ${{ secrets.PRIVATE_KEY }}
+          owner: ${{ github.repository_owner }}
+          repositories: "impress,secrets"
       -
         name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v2
+        with:
+          submodules: recursive
+          token: ${{ steps.app-token.outputs.token }}
+      -
+        name: Load sops secrets
+        uses: rouja/actions-sops@main
+        with:
+          secret-file: secrets/numerique-gouv/impress/secrets.enc.env
+          age-key: ${{ secrets.SOPS_PRIVATE }}
       -
         name: Docker meta
         id: meta
@@ -100,20 +146,19 @@ jobs:
       -
         name: Login to DockerHub
         if: github.event_name != 'pull_request'
-        run: echo "${{ secrets.DOCKER_HUB_PASSWORD }}" | docker login -u "${{ secrets.DOCKER_HUB_USER }}" --password-stdin
+        run: echo "$DOCKER_HUB_PASSWORD" | docker login -u "$DOCKER_HUB_USER" --password-stdin
       -
         name: Run trivy scan
         uses: numerique-gouv/action-trivy-cache@main
         with:
-          docker-build-args: '-f src/frontend/servers/y-provider/Dockerfile --target y-provider'
+          docker-build-args: '-f src/frontend/Dockerfile --target y-provider'
           docker-image-name: 'docker.io/lasuite/impress-frontend:${{ github.sha }}'
-        continue-on-error: true
       -
         name: Build and push
         uses: docker/build-push-action@v6
         with:
           context: .
-          file: ./src/frontend/servers/y-provider/Dockerfile
+          file: ./src/frontend/Dockerfile
           target: y-provider
           build-args: DOCKER_USER=${{ env.DOCKER_USER }}:-1000
           push: ${{ github.event_name != 'pull_request' }}
@@ -128,12 +173,29 @@ jobs:
     if: |
       github.event_name != 'pull_request'
     steps:
+      -
+        uses: actions/create-github-app-token@v1
+        id: app-token
+        with:
+          app-id: ${{ secrets.APP_ID }}
+          private-key: ${{ secrets.PRIVATE_KEY }}
+          owner: ${{ github.repository_owner }}
+          repositories: "impress,secrets"
       -
         name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v2
+        with:
+          submodules: recursive
+          token: ${{ steps.app-token.outputs.token }}
+      -
+        name: Load sops secrets
+        uses: rouja/actions-sops@main
+        with:
+          secret-file: secrets/numerique-gouv/impress/secrets.enc.env
+          age-key: ${{ secrets.SOPS_PRIVATE }}
       -
         name: Call argocd github webhook
         run: |
           data='{"ref": "'$GITHUB_REF'","repository": {"html_url":"'$GITHUB_SERVER_URL'/'$GITHUB_REPOSITORY'"}}'
-          sig=$(echo -n ${data} | openssl dgst -sha1 -hmac ''${{ secrets.ARGOCD_PREPROD_WEBHOOK_SECRET}}'' | awk '{print "X-Hub-Signature: sha1="$2}')
-          curl -X POST -H 'X-GitHub-Event:push' -H "Content-Type: application/json" -H "${sig}" --data "${data}" ${{ vars.ARGOCD_PREPROD_WEBHOOK_URL }}
+          sig=$(echo -n ${data} | openssl dgst -sha1 -hmac ''${ARGOCD_WEBHOOK_SECRET}'' | awk '{print "X-Hub-Signature: sha1="$2}')
+          curl -X POST -H 'X-GitHub-Event:push' -H "Content-Type: application/json" -H "${sig}" --data "${data}" $ARGOCD_WEBHOOK_URL

.github/workflows/front-dependencies-installation.yml

@@ -1,36 +0,0 @@
-name: Install frontend installation reusable workflow
-
-on:
-  workflow_call:
-    inputs:
-      node_version:
-        required: false
-        default: '20.x'
-        type: string
-
-jobs:
-  front-dependencies-installation:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-      - name: Restore the frontend cache
-        uses: actions/cache@v4
-        id: front-node_modules
-        with:
-          path: "src/frontend/**/node_modules"
-          key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }}
-      - name: Setup Node.js
-        if: steps.front-node_modules.outputs.cache-hit != 'true'
-        uses: actions/setup-node@v4
-        with:
-          node-version: ${{ inputs.node_version }}
-      - name: Install dependencies
-        if: steps.front-node_modules.outputs.cache-hit != 'true'
-        run: cd src/frontend/ && yarn install --frozen-lockfile
-      - name: Cache install frontend
-        if: steps.front-node_modules.outputs.cache-hit != 'true'
-        uses: actions/cache@v4
-        with:
-          path: "src/frontend/**/node_modules"
-          key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }}

.github/workflows/helmfile-linter.yaml

@@ -1,30 +0,0 @@
-name: Helmfile lint
-run-name: Helmfile lint
-
-on:
-  push:
-  pull_request:
-    branches:
-      - 'main'
-
-jobs:
-  helmfile-lint:
-    runs-on: ubuntu-latest
-    container:
-      image: ghcr.io/helmfile/helmfile:latest
-    steps:
-    -
-      name: Checkout repository
-      uses: actions/checkout@v4
-    -
-      name: Helmfile lint
-      shell: bash
-      run: |
-        set -e
-        HELMFILE=src/helm/helmfile.yaml
-        environments=$(awk '/environments:/ {flag=1; next} flag && NF {print} !NF {flag=0}' "$HELMFILE" | grep -E '^[[:space:]]{2}[a-zA-Z]+' | sed 's/^[[:space:]]*//;s/:.*//')
-        for env in $environments; do
-          echo "################### $env lint ###################"
-          helmfile -e $env -f $HELMFILE lint || exit 1
-          echo -e "\n"
-        done

.github/workflows/impress-frontend.yml

@@ -9,15 +9,9 @@ on:
       - "*"
 
 jobs:
-
   install-front:
-    uses: ./.github/workflows/front-dependencies-installation.yml
-    with:
-      node_version: '20.x'
-
-  test-front:
-    needs: install-front
     runs-on: ubuntu-latest
+
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -25,17 +19,42 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: "20.x"
+          node-version: "18.x"
 
       - name: Restore the frontend cache
+        uses: actions/cache@v4
+        id: front-node_modules
+        with:
+          path: "src/frontend/**/node_modules"
+          key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }}
+
+      - name: Install dependencies
+        if: steps.front-node_modules.outputs.cache-hit != 'true'
+        run: cd src/frontend/ && yarn install --frozen-lockfile
+
+      - name: Cache install frontend
+        if: steps.front-node_modules.outputs.cache-hit != 'true'
         uses: actions/cache@v4
         with:
           path: "src/frontend/**/node_modules"
           key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }}
-          fail-on-cache-miss: true
+
+  test-front:
+    runs-on: ubuntu-latest
+    needs: install-front
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Restore the frontend cache
+        uses: actions/cache@v4
+        id: front-node_modules
+        with:
+          path: "src/frontend/**/node_modules"
+          key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }}
 
       - name: Test App
-        run: cd src/frontend/ && yarn test
+        run: cd src/frontend/ && yarn app:test
 
   lint-front:
     runs-on: ubuntu-latest
@@ -44,75 +63,43 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v4
 
-      - name: Setup Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: "20.x"
       - name: Restore the frontend cache
         uses: actions/cache@v4
+        id: front-node_modules
         with:
           path: "src/frontend/**/node_modules"
           key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }}
-          fail-on-cache-miss: true
 
       - name: Check linting
         run: cd src/frontend/ && yarn lint
 
   test-e2e-chromium:
     runs-on: ubuntu-latest
-    needs: install-front
     timeout-minutes: 20
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
 
-      - name: Setup Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: "20.x"
-
       - name: Restore the frontend cache
         uses: actions/cache@v4
+        id: front-node_modules
         with:
           path: "src/frontend/**/node_modules"
           key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }}
-          fail-on-cache-miss: true
 
       - name: Set e2e env variables
         run: cat env.d/development/common.e2e.dist >> env.d/development/common.dist
 
-      - name: Install Playwright Browsers
-        run: cd src/frontend/apps/e2e && yarn install --frozen-lockfile && yarn install-playwright chromium
-
       - name: Start Docker services
         run: make bootstrap FLUSH_ARGS='--no-input' cache=
 
-      # Tool to wait for a service to be ready
-      - name: Install Dockerize
-        run: |
-          curl -sSL https://github.com/jwilder/dockerize/releases/download/v0.8.0/dockerize-linux-amd64-v0.8.0.tar.gz | sudo tar -C /usr/local/bin -xzv
-
-      - name: Wait for services to be ready
-        run: |
-          printf "Minio check...\n"
-          dockerize -wait tcp://localhost:9000 -timeout 20s
-          printf "Keyclock check...\n"
-          dockerize -wait tcp://localhost:8080 -timeout 20s
-          printf "Server collaboration check...\n"
-          dockerize -wait tcp://localhost:4444 -timeout 20s
-          printf "Ngnix check...\n"
-          dockerize -wait tcp://localhost:8083 -timeout 20s
-          printf "DRF check...\n"
-          dockerize -wait tcp://localhost:8071 -timeout 20s
-          printf "Postgres Keyclock check...\n"
-          dockerize -wait tcp://localhost:5433 -timeout 20s
-          printf "Postgres back check...\n"
-          dockerize -wait tcp://localhost:15432 -timeout 20s
+      - name: Install Playwright Browsers
+        run: cd src/frontend/apps/e2e && yarn install-playwright chromium
 
       - name: Run e2e tests
         run: cd src/frontend/ && yarn e2e:test --project='chromium'
 
-      - uses: actions/upload-artifact@v4
+      - uses: actions/upload-artifact@v3
         if: always()
         with:
           name: playwright-chromium-report
@@ -127,31 +114,26 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v4
 
-      - name: Setup Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: "20.x"
-
       - name: Restore the frontend cache
         uses: actions/cache@v4
+        id: front-node_modules
         with:
           path: "src/frontend/**/node_modules"
           key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }}
-          fail-on-cache-miss: true
 
       - name: Set e2e env variables
         run: cat env.d/development/common.e2e.dist >> env.d/development/common.dist
 
-      - name: Install Playwright Browsers
-        run: cd src/frontend/apps/e2e && yarn install --frozen-lockfile && yarn install-playwright firefox webkit chromium
-
       - name: Start Docker services
         run: make bootstrap FLUSH_ARGS='--no-input' cache=
 
+      - name: Install Playwright Browsers
+        run: cd src/frontend/apps/e2e && yarn install-playwright firefox webkit chromium
+
       - name: Run e2e tests
         run: cd src/frontend/ && yarn e2e:test --project=firefox --project=webkit
 
-      - uses: actions/upload-artifact@v4
+      - uses: actions/upload-artifact@v3
         if: always()
         with:
           name: playwright-other-report

.github/workflows/impress.yml

@@ -107,9 +107,7 @@ jobs:
       - name: Install Python
         uses: actions/setup-python@v3
         with:
-          python-version: "3.12.6"
-      - name: Upgrade pip and setuptools
-        run: pip install --upgrade pip setuptools
+          python-version: "3.10"
       - name: Install development dependencies
         run: pip install --user .[dev]
       - name: Check code formatting with ruff
@@ -201,16 +199,15 @@ jobs:
       - name: Install Python
         uses: actions/setup-python@v3
         with:
-          python-version: "3.12.6"
+          python-version: "3.10"
 
       - name: Install development dependencies
         run: pip install --user .[dev]
 
-      - name: Install gettext (required to compile messages) and MIME support
+      - name: Install gettext (required to compile messages)
         run: |
           sudo apt-get update
-          sudo apt-get install -y gettext pandoc shared-mime-info
-          sudo wget https://svn.apache.org/repos/asf/httpd/httpd/trunk/docs/conf/mime.types -O /etc/mime.types
+          sudo apt-get install -y gettext pandoc
 
       - name: Generate a MO file from strings extracted from the project
         run: python manage.py compilemessages

.github/workflows/release-helm-chart.yaml

@@ -1,34 +0,0 @@
-name: Release Chart
-run-name: Release Chart
-
-on:
-  push:
-    paths:
-      - src/helm/impress/**
-
-jobs:
-  release:
-    # depending on default permission settings for your org (contents being read-only or read-write for workloads), you will have to add permissions
-    # see: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token
-    permissions:
-      contents: write
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-
-      - name: Cleanup
-        run: rm -rf ./src/helm/extra
-
-      - name: Install Helm
-        uses: azure/setup-helm@v4
-        env:
-          GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
-
-      - name: Publish Helm charts
-        uses: numerique-gouv/helm-gh-pages@add-overwrite-option
-        with:
-          charts_dir: ./src/helm
-          token: ${{ secrets.GITHUB_TOKEN }}

.gitignore

@@ -30,7 +30,6 @@ MANIFEST
 .next/
 
 # Translations	# Translations
-*.mo
 *.pot
 
 # Environments

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "secrets"]
+	path = secrets
+	url = ../secrets

CHANGELOG.md

@@ -9,160 +9,6 @@ and this project adheres to
 
 ## [Unreleased]
 
-
-## [2.1.0] - 2025-01-29
-
-## Added
-
-- ✨(backend) add soft delete and restore API endpoints to documents #516
-- ✨(backend) allow organizing documents in a tree structure #516
-- ✨(backend) add "excerpt" field to document list serializer #516
-- ✨(backend) add github actions to manage Crowdin workflow #559 & #563
-- 📈Integrate Posthog #540
-- 🏷️(backend) add content-type to uploaded files #552
-- ✨(frontend) export pdf docx front side #537
-
-## Changed
-
-- 💄(frontend) add abilities on doc row #581
-- 💄(frontend) improve DocsGridItem responsive padding  #582
-- 🔧(backend) Bump maximum page size to 200 #516
-- 📝(doc) Improve Read me #558
-
-## Fixed
-
-- 🐛Fix invitations #575
-
-## Removed
-
-- 🔥(backend) remove "content" field from list serializer # 516
-
-
-## [2.0.1] - 2025-01-17
-
-## Fixed
-
--🐛(frontend) share modal is shown when you don't have the abilities #557
--🐛(frontend) title copy break app #564
-
-## [2.0.0] - 2025-01-13
-
-## Added
-
-- 🔧(backend) add option to configure list of essential OIDC claims #525 & #531
-- 🔧(helm) add option to disable default tls setting by @dominikkaminski #519
-- 💄(frontend) Add left panel #420
-- 💄(frontend) add filtering to left panel #475
-- ✨(frontend) new share modal ui #489
-- ✨(frontend) add favorite feature #515
-- 📝(documentation) Documentation about self-hosted installation #530
-- ✨(helm) helm versioning #530
-
-## Changed
-
-- 🏗️(yjs-server) organize yjs server #528
-- ♻️(frontend) better separation collaboration process #528
-- 💄(frontend) updating the header and leftpanel for responsive #421
-- 💄(frontend) update DocsGrid component #431
-- 💄(frontend) update DocsGridOptions component #432
-- 💄(frontend) update DocHeader ui #448
-- 💄(frontend) update doc versioning ui #463
-- 💄(frontend) update doc summary ui #473
-- 📝(doc) update readme.md to match V2 changes #558 & #572
-
-## Fixed
-
-- 🐛(backend) fix create document via s2s if sub unknown but email found #543
-- 🐛(frontend) hide search and create doc button if not authenticated #555
-- 🐛(backend) race condition creation issue #556
-
-## [1.10.0] - 2024-12-17
-
-## Added
-
-- ✨(backend) add server-to-server API endpoint to create documents #467
-- ✨(email) white brand email #412
-- ✨(y-provider) create a markdown converter endpoint #488
-
-## Changed
-
-- ⚡️(docker) improve y-provider image #422
-
-## Fixed
-
-- ⚡️(e2e) reduce flakiness on e2e tests #511
-
-
-## Fixed
-- 🐛(frontend) update doc editor height #481
-- 💄(frontend) add doc search #485
-
-
-## [1.9.0] - 2024-12-11
-
-## Added
-
-- ✨(backend) annotate number of accesses on documents in list view #429
-- ✨(backend) allow users to mark/unmark documents as favorite #429
-
-## Changed
-
-- 🔒️(collaboration) increase collaboration access security #472
-- 🔨(frontend) encapsulated title to its own component #474
-- ⚡️(backend) optimize number of queries on document list view #429
-- ♻️(frontend) stop to use provider with version #480
-- 🚚(collaboration) change the websocket key name #480
-
-## Fixed
-
-- 🐛(frontend) fix initial content with collaboration #484
-- 🐛(frontend) Fix hidden menu on Firefox #468
-- 🐛(backend) fix sanitize problem IA #490
-
-
-## [1.8.2] - 2024-11-28
-
-## Changed
-
-- ♻️(SW) change strategy html caching #460
-
-
-## [1.8.1] - 2024-11-27
-
-## Fixed
-
-- 🐛(frontend) link not clickable and flickering firefox #457
-
-
-## [1.8.0] - 2024-11-25
-
-## Added
-
-- 🌐(backend) add German translation #259
-- 🌐(frontend) add German translation #255
-- ✨(frontend) add a broadcast store #387
-- ✨(backend) whitelist pod's IP address #443
-- ✨(backend) config endpoint #425
-- ✨(frontend) config endpoint #424
-- ✨(frontend) add sentry #424
-- ✨(frontend) add crisp chatbot #450
-
-## Changed
-
-- 🚸(backend) improve users similarity search and sort results #391
-- ♻️(frontend) simplify stores #402
-- ✨(frontend) update $css Box props type to add styled components RuleSet #423
-- ✅(CI) trivy continue on error #453
-
-## Fixed
-
-- 🔧(backend) fix logging for docker and make it configurable by envar #427
-- 🦺(backend) add comma to sub regex #408
-- 🐛(editor) collaborative user tag hidden when read only #385
-- 🐛(frontend) users have view access when revoked #387
-- 🐛(frontend) fix placeholder editable when double clicks #454
-
-
 ## [1.7.0] - 2024-10-24
 
 ## Added
@@ -171,13 +17,10 @@ and this project adheres to
 - 🌐(frontend) add localization to editor #368
 - ✨Public and restricted doc editable #357
 - ✨(frontend) Add full name if available #380
-- ✨(backend) Add view accesses ability #376
 
 ## Changed
 
-- ♻️(frontend) list accesses if user has abilities #376
 - ♻️(frontend) avoid documents indexing in search engine #372
-- 👔(backend) doc restricted by default #388
 
 ## Fixed
 
@@ -392,15 +235,7 @@ and this project adheres to
 - 🚀 Impress, project to manage your documents easily and collaboratively.
 
 
-[unreleased]: https://github.com/numerique-gouv/impress/compare/v2.1.0...main
-[v2.1.0]: https://github.com/numerique-gouv/impress/releases/v2.1.0
-[v2.0.1]: https://github.com/numerique-gouv/impress/releases/v2.0.1
-[v2.0.0]: https://github.com/numerique-gouv/impress/releases/v2.0.0
-[v1.10.0]: https://github.com/numerique-gouv/impress/releases/v1.10.0
-[v1.9.0]: https://github.com/numerique-gouv/impress/releases/v1.9.0
-[v1.8.2]: https://github.com/numerique-gouv/impress/releases/v1.8.2
-[v1.8.1]: https://github.com/numerique-gouv/impress/releases/v1.8.1
-[v1.8.0]: https://github.com/numerique-gouv/impress/releases/v1.8.0
+[unreleased]: https://github.com/numerique-gouv/impress/compare/v1.7.0...main
 [v1.7.0]: https://github.com/numerique-gouv/impress/releases/v1.7.0
 [v1.6.0]: https://github.com/numerique-gouv/impress/releases/v1.6.0
 [1.5.1]: https://github.com/numerique-gouv/impress/releases/v1.5.1

CONTRIBUTING.md

@@ -2,14 +2,7 @@
 
 Thank you for taking the time to contribute! Please follow these guidelines to ensure a smooth and productive workflow. 🚀🚀🚀
 
-To get started with the project, please refer to the [README.md](https://github.com/suitenumerique/docs/blob/main/README.md) for detailed instructions.
-
-Please also check out our [dev handbook](https://suitenumerique.gitbook.io/handbook) to learn our best practices.
-
-## Help us with translations
-
-You can help us with translations on [Crowdin](https://crowdin.com/project/lasuite-docs).
-Your language is not there? Request it on our Crowdin page 😊.
+To get started with the project, please refer to the [README.md](https://github.com/numerique-gouv/impress/blob/main/README.md) for detailed instructions.
 
 ## Creating an Issue
 

Dockerfile

@@ -51,7 +51,7 @@ COPY ./src/backend /app/
 WORKDIR /app
 
 # collectstatic
-RUN DJANGO_CONFIGURATION=Build \
+RUN DJANGO_CONFIGURATION=Build DJANGO_JWT_PRIVATE_SIGNING_KEY=Dummy \
     python manage.py collectstatic --noinput
 
 # Replace duplicated file by a symlink to decrease the overall size of the
@@ -72,11 +72,10 @@ RUN apk add \
   gettext \
   gdk-pixbuf \
   libffi-dev \
+  pandoc \
   pango \
   shared-mime-info
 
-RUN wget https://svn.apache.org/repos/asf/httpd/httpd/trunk/docs/conf/mime.types -O /etc/mime.types
-
 # Copy entrypoint
 COPY ./docker/files/usr/local/bin/entrypoint /usr/local/bin/entrypoint
 
@@ -93,11 +92,6 @@ COPY ./src/backend /app/
 
 WORKDIR /app
 
-# Generate compiled translation messages
-RUN DJANGO_CONFIGURATION=Build \
-    python manage.py compilemessages
-
-
 # We wrap commands run in this container by the following entrypoint that
 # creates a user on-the-fly with the container user ID (see USER) and root group
 # ID.

Makefile

@@ -122,8 +122,8 @@ logs: ## display app-dev logs (follow mode)
 
 run: ## start the wsgi (production) and development server
 	@$(COMPOSE) up --force-recreate -d celery-dev
-	@$(COMPOSE) up --force-recreate -d y-provider
 	@$(COMPOSE) up --force-recreate -d nginx
+	@$(COMPOSE) up --force-recreate -d y-provider
 	@echo "Wait for postgresql to be up..."
 	@$(WAIT_DB)
 .PHONY: run

README.md

@@ -1,183 +1,113 @@
-<p align="center">
-  <a href="https://github.com/suitenumerique/docs">
-    <img alt="Docs" src="/docs/assets/docs-logo.png" width="300" />
-  </a>
-</p>
+# Impress
 
-<p align="center">
-Welcome to Docs! The open source document editor where your notes can become knowledge through live collaboration
-</p>
+Impress is a web application for real-time collaborative text editing with user and role based access rights.
+Features include : 
+- User authentication through OIDC
+- BlocNote.js text editing experience (markdown support, dynamic conversion, block structure, slash commands for block creation) 
+- Document export to pdf and docx from predefined templates
+- Granular document permissions
+- Public link sharing
+- Offline mode
 
-<p align="center">
-  <a href="https://matrix.to/#/#docs-official:matrix.org">
-    Chat on Matrix
-  </a> - <a href="/docs/">
-    Documentation
-  </a> - <a href="#getting-started">
-    Getting started
-  </a>
-</p>
+Impress is built on top of [Django Rest Framework](https://www.django-rest-framework.org/), [Next.js](https://nextjs.org/) and [BlocNote.js](https://www.blocknotejs.org/)
 
-<img src="/docs/assets/docs_live_collaboration_light.gif" width="100%" align="center"/>
+## Getting started
 
-## Why use Docs ❓
-Docs is a collaborative text editor designed to address common challenges in knowledge building and sharing.
+### Prerequisite
 
-### Write
-*   😌 Simple collaborative editing without the formatting complexity of markdown
-*   🔌 Offline? No problem, keep writing, your edits will get synced when back online
-*   💅 Create clean documents with limited but beautiful formatting options and focus on content
-*   🧱 Built for productivity (markdown support, many block types, slash commands, keyboard shortcuts).
-*   ✨ Save time thanks to our AI actions (generate, sum up, correct, translate)
+Make sure you have a recent version of Docker and [Docker
+Compose](https://docs.docker.com/compose/install) installed on your laptop:
 
-### Collaborate
-*   🤝 Collaborate in realtime with your team mates
-*   🔒 Granular access control to keep your information secure and shared with the right people
-*   📑 Professional document exports in multiple formats (.odt, .doc, .pdf) with customizable templates
-*   📚 Built-in wiki functionality to transform your team's collaborative work into organized knowledge `ETA 02/2025`
-
-### Self-host
-*   🚀 Easy to install, scalable and secure alternative to Notion, Outline or Confluence
-
-## Getting started 🔧
-### Test it
-Test Docs on your browser by logging in on this [environment](https://impress-preprod.beta.numerique.gouv.fr/docs/0aa856e9-da41-4d59-b73d-a61cb2c1245f/)
-```
-email: test.docs@yopmail.com
-password: I'd<3ToTestDocs
-```
-### Run it locally
-**Prerequisite**
-Make sure you have a recent version of Docker and [Docker Compose](https://docs.docker.com/compose/install) installed on your laptop:
-
-```shellscript
+```bash
 $ docker -v
-
-Docker version 20.10.2, build 2291f61
+  Docker version 20.10.2, build 2291f61
 
 $ docker compose -v
-
-docker compose version 1.27.4, build 40524192
+  docker compose version 1.27.4, build 40524192
 ```
 
-> ⚠️ You may need to run the following commands with sudo but this can be avoided by assigning your user to the `docker` group.
+> ⚠️ You may need to run the following commands with `sudo` but this can be
+> avoided by assigning your user to the `docker` group.
+
+### Project bootstrap
 
-**Project bootstrap**
 The easiest way to start working on the project is to use GNU Make:
 
-```shellscript
+```bash
 $ make bootstrap FLUSH_ARGS='--no-input'
 ```
 
-This command builds the `app` container, installs dependencies, performs database migrations and compile translations. It's a good idea to use this
-
-command each time you are pulling code from the project repository to avoid dependency-releated or migration-releated issues.
+This command builds the `app` container, installs dependencies, performs
+database migrations and compile translations. It's a good idea to use this
+command each time you are pulling code from the project repository to avoid
+dependency-releated or migration-releated issues.
 
 Your Docker services should now be up and running 🎉
 
-You can access to the project by going to <http://localhost:3000>.
-
+You can access to the project by going to http://localhost:3000.
 You will be prompted to log in, the default credentials are:
-
-```shellscript
+```bash
 username: impress
-
 password: impress
 ```
 
 📝 Note that if you need to run them afterwards, you can use the eponym Make rule:
 
-```shellscript
+```bash
 $ make run-with-frontend
 ```
 
-⚠️ For the frontend developer, it is often better to run the frontend in development mode locally.
+---
 
+⚠️ For the frontend developper, it is often better to run the frontend in development mode locally. 
 To do so, install the frontend dependencies with the following command:
 
-```shellscript
+```bash
 $ make frontend-install
 ```
-
 And run the frontend locally in development mode with the following command:
 
-```shellscript
+```bash
 $ make run-frontend-development
 ```
 
 To start all the services, except the frontend container, you can use the following command:
 
-```shellscript
+```bash
 $ make run
 ```
 
-**Adding content**
+---
+
+### Adding content
+
 You can create a basic demo site by running:
 
-```shellscript
-$ make demo
-```
+    $ make demo
 
 Finally, you can check all available Make rules using:
 
-```shellscript
+```bash
 $ make help
 ```
 
-**Django admin**
-You can access the Django admin site at
+### Django admin
 
-<http://localhost:8071/admin>.
+You can access the Django admin site at
+[http://localhost:8071/admin](http://localhost:8071/admin).
 
 You first need to create a superuser account:
 
-```shellscript
+```bash
 $ make superuser
 ```
 
-## Feedback 🙋‍♂️🙋‍♀️
-We'd love to hear your thoughts and hear about your experiments, so come and say hi on [Matrix](https://matrix.to/#/#docs-official:matrix.org).
+## Contributing
 
-## Roadmap
-Want to know where the project is headed? [🗺️ Checkout our roadmap](https://github.com/orgs/numerique-gouv/projects/13/views/11)
+This project is intended to be community-driven, so please, do not hesitate to
+get in touch if you have any question related to our implementation or design
+decisions.
 
-## Licence 📝
-This work is released under the MIT License (see [LICENSE](https://github.com/suitenumerique/docs/blob/main/LICENSE)).
+## License
 
-While Docs is a public driven initiative our licence choice is an invitation for private sector actors to use, sell and contribute to the project. 
-
-## Contributing 🙌
-This project is intended to be community-driven, so please, do not hesitate to [get in touch](https://matrix.to/#/#docs-official:matrix.org) if you have any question related to our implementation or design decisions.
-
-You can help us with translations on [Crowdin](https://crowdin.com/project/lasuite-docs).
-
-If you intend to make pull requests see [CONTRIBUTING](https://github.com/suitenumerique/docs/blob/main/CONTRIBUTING.md) for guidelines.
-
-Directory structure:
-
-```markdown
-docs
-├── bin - executable scripts or binaries that are used for various tasks, such as setup scripts, utility scripts, or custom commands.
-├── crowdin - for crowdin translations, a tool or service that helps manage translations for the project.
-├── docker - Dockerfiles and related configuration files used to build Docker images for the project. These images can be used for development, testing, or production environments.
-├── docs - documentation for the project, including user guides, API documentation, and other helpful resources.
-├── env.d/development - environment-specific configuration files for the development environment. These files might include environment variables, configuration settings, or other setup files needed for development.
-├── gitlint - configuration files for `gitlint`, a tool that enforces commit message guidelines to ensure consistency and quality in commit messages.
-├── playground - experimental or temporary code, where developers can test new features or ideas without affecting the main codebase.
-└── src - main source code directory, containing the core application code, libraries, and modules of the project.
-```
-
-## Credits ❤️
-### Stack
-Docs is built on top of [Django Rest Framework](https://www.django-rest-framework.org/), [Next.js](https://nextjs.org/), [MinIO](https://min.io/), [BlockNote.js](https://www.blocknotejs.org/), [HocusPocus](https://tiptap.dev/docs/hocuspocus/introduction) and [Yjs](https://yjs.dev/)
-
-### Gov ❤️ open source
-Docs is the result of a joint effort lead by the French 🇫🇷🥖 ([DINUM](https://www.numerique.gouv.fr/dinum/)) and German 🇩🇪🥨 governments ([ZenDiS](https://zendis.de/)). 
-
-We are proud sponsors of [BlockNotejs](https://www.blocknotejs.org/) and [Yjs](https://yjs.dev/).
-
-We are always looking for new public partners (we are currently onboarding the Netherlands 🇳🇱🧀), feel free to [reach out](https://matrix.to/#/#docs-official:matrix.org) if you are interested in using or contributing to Docs.
-
-<p align="center">
-  <img src="/docs/assets/europe_opensource.png" width="50%"/>
-</p>
+This work is released under the MIT License (see [LICENSE](./LICENSE)).

bin/Tiltfile

@@ -20,7 +20,7 @@ docker_build(
 docker_build(
     'localhost:5001/impress-y-provider:latest',
     context='..',
-    dockerfile='../src/frontend/servers/y-provider/Dockerfile',
+    dockerfile='../src/frontend/Dockerfile',
     only=['./src/frontend/', './docker/', './.dockerignore'],
     target = 'y-provider',
     live_update=[

bin/_config.sh

@@ -7,7 +7,7 @@ UNSET_USER=0
 
 TERRAFORM_DIRECTORY="./env.d/terraform"
 COMPOSE_FILE="${REPO_DIR}/docker-compose.yml"
-COMPOSE_PROJECT="docs"
+COMPOSE_PROJECT="impress"
 
 
 # _set_user: set (or unset) default user id used to run docker commands

bin/start-kind.sh

@@ -1,2 +1,103 @@
 #!/bin/sh
-curl https://raw.githubusercontent.com/numerique-gouv/tools/refs/heads/main/kind/create_cluster.sh | bash -s -- impress
+set -o errexit
+
+CURRENT_DIR=$(pwd)
+
+echo "0. Create ca"
+# 0. Create ca
+mkcert -install
+cd /tmp
+mkcert "127.0.0.1.nip.io" "*.127.0.0.1.nip.io"
+cd $CURRENT_DIR
+
+echo "1. Create registry container unless it already exists"
+# 1. Create registry container unless it already exists
+reg_name='kind-registry'
+reg_port='5001'
+if [ "$(docker inspect -f '{{.State.Running}}' "${reg_name}" 2>/dev/null || true)" != 'true' ]; then
+	docker run \
+		-d --restart=unless-stopped -p "127.0.0.1:${reg_port}:5000" --network bridge --name "${reg_name}" \
+		registry:2
+fi
+
+echo "2. Create kind cluster with containerd registry config dir enabled"
+# 2. Create kind cluster with containerd registry config dir enabled
+# TODO: kind will eventually enable this by default and this patch will
+# be unnecessary.
+#
+# See:
+# https://github.com/kubernetes-sigs/kind/issues/2875
+# https://github.com/containerd/containerd/blob/main/docs/cri/config.md#registry-configuration
+# See: https://github.com/containerd/containerd/blob/main/docs/hosts.md
+cat <<EOF | kind create cluster --config=-
+kind: Cluster
+apiVersion: kind.x-k8s.io/v1alpha4
+containerdConfigPatches:
+- |-
+  [plugins."io.containerd.grpc.v1.cri".registry]
+    config_path = "/etc/containerd/certs.d"
+nodes:
+- role: control-plane
+  image: kindest/node:v1.27.3
+  kubeadmConfigPatches:
+  - |
+    kind: InitConfiguration
+    nodeRegistration:
+      kubeletExtraArgs:
+        node-labels: "ingress-ready=true"
+  extraPortMappings:
+  - containerPort: 80
+    hostPort: 80
+    protocol: TCP
+  - containerPort: 443
+    hostPort: 443
+    protocol: TCP
+- role: worker
+  image: kindest/node:v1.27.3
+- role: worker
+  image: kindest/node:v1.27.3
+EOF
+
+echo "3. Add the registry config to the nodes"
+# 3. Add the registry config to the nodes
+#
+# This is necessary because localhost resolves to loopback addresses that are
+# network-namespace local.
+# In other words: localhost in the container is not localhost on the host.
+#
+# We want a consistent name that works from both ends, so we tell containerd to
+# alias localhost:${reg_port} to the registry container when pulling images
+REGISTRY_DIR="/etc/containerd/certs.d/localhost:${reg_port}"
+for node in $(kind get nodes); do
+	docker exec "${node}" mkdir -p "${REGISTRY_DIR}"
+	cat <<EOF | docker exec -i "${node}" cp /dev/stdin "${REGISTRY_DIR}/hosts.toml"
+[host."http://${reg_name}:5000"]
+EOF
+done
+
+echo "4. Connect the registry to the cluster network if not already connected"
+# 4. Connect the registry to the cluster network if not already connected
+# This allows kind to bootstrap the network but ensures they're on the same network
+if [ "$(docker inspect -f='{{json .NetworkSettings.Networks.kind}}' "${reg_name}")" = 'null' ]; then
+	docker network connect "kind" "${reg_name}"
+fi
+
+echo "5. Document the local registry"
+# 5. Document the local registry
+# https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/generic/1755-communicating-a-local-registry
+cat <<EOF | kubectl apply -f -
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: local-registry-hosting
+  namespace: kube-public
+data:
+  localRegistryHosting.v1: |
+    host: "localhost:${reg_port}"
+    help: "https://kind.sigs.k8s.io/docs/user/local-registry/"
+EOF
+
+echo "6. Install ingress-nginx"
+kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/main/deploy/static/provider/kind/deploy.yaml
+kubectl -n ingress-nginx create secret tls mkcert --key /tmp/127.0.0.1.nip.io+1-key.pem --cert /tmp/127.0.0.1.nip.io+1.pem
+kubectl -n ingress-nginx patch deployments.apps ingress-nginx-controller --type 'json' -p '[{"op": "add", "path": "/spec/template/spec/containers/0/args/-", "value":"--default-ssl-certificate=ingress-nginx/mkcert"}]'

crowdin/config.yml

@@ -1,7 +1,7 @@
 #
 # Your crowdin's credentials
 #
-api_token_env: CROWDIN_PERSONAL_TOKEN
+api_token_env: CROWDIN_API_TOKEN
 project_id_env: CROWDIN_PROJECT_ID
 base_path_env: CROWDIN_BASE_PATH
 
@@ -15,11 +15,11 @@ preserve_hierarchy: true
 # Files configuration
 #
 files: [
-  {
-    source : "/backend/locale/django.pot",
-    dest: "/backend-impress.pot",
-    translation : "/backend/locale/%locale_with_underscore%/LC_MESSAGES/django.po"
-  },
+ {
+  source : "/backend/locale/django.pot",
+  dest: "/backend-impress.pot",
+  translation : "/backend/locale/%locale_with_underscore%/LC_MESSAGES/django.po"
+ },
   {
     source: "/frontend/packages/i18n/locales/impress/translations-crowdin.json",
     dest: "/frontend-impress.json",

docker-compose.yml

@@ -118,7 +118,6 @@ services:
     depends_on:
       - keycloak
       - app-dev
-      - y-provider
 
   frontend-dev:
     user: "${DOCKER_USER:-1000}"
@@ -151,7 +150,7 @@ services:
     image: node:18
     user: "${DOCKER_USER:-1000}"
     environment:
-      HOME: /tmp 
+      HOME: /tmp
     volumes:
       - ".:/app"
 
@@ -159,13 +158,15 @@ services:
     user: ${DOCKER_USER:-1000}
     build: 
       context: .
-      dockerfile: ./src/frontend/servers/y-provider/Dockerfile
+      dockerfile: ./src/frontend/Dockerfile
       target: y-provider
     restart: unless-stopped
-    env_file:
-      - env.d/development/common
     ports:
       - "4444:4444"
+    volumes:
+      - ./src/frontend/servers/y-provider:/home/frontend/servers/y-provider
+      - /home/frontend/servers/y-provider/node_modules/
+      - /home/frontend/servers/y-provider/dist/
 
   kc_postgresql:
     image: postgres:14.3

docker/files/etc/nginx/conf.d/default.conf

@@ -4,58 +4,9 @@ server {
     server_name localhost;
     charset utf-8;
 
-    # Proxy auth for collaboration server
-    location /collaboration/ws/ {
-        # Collaboration Auth request configuration
-        auth_request /collaboration-auth;
-        auth_request_set $authHeader $upstream_http_authorization;
-        auth_request_set $canEdit $upstream_http_x_can_edit;
-        auth_request_set $userId $upstream_http_x_user_id;
-
-        # Pass specific headers from the auth response
-        proxy_set_header Authorization $authHeader;
-        proxy_set_header X-Can-Edit $canEdit;
-        proxy_set_header X-User-Id $userId;
-
-        # Ensure WebSocket upgrade
-        proxy_http_version 1.1;
-        proxy_set_header Upgrade $http_upgrade;
-        proxy_set_header Connection "Upgrade";
-
-        # Collaboration server
-        proxy_pass http://y-provider:4444;
-
-        # Set appropriate timeout for WebSocket
-        proxy_read_timeout 86400;
-        proxy_send_timeout 86400;
-
-        # Preserve original host and additional headers
-        proxy_set_header Host $host;
-    }
-
-    location /collaboration-auth {
-        proxy_pass http://app-dev:8000/api/v1.0/documents/collaboration-auth/;
-        proxy_set_header Host $host;
-        proxy_set_header X-Real-IP $remote_addr;
-        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
-        proxy_set_header X-Original-URL $request_uri;
-        
-        # Prevent the body from being passed
-        proxy_pass_request_body off;
-        proxy_set_header Content-Length "";
-        proxy_set_header X-Original-Method $request_method;
-    }
-
-    location  /collaboration/api/ {
-        # Collaboration server
-        proxy_pass http://y-provider:4444;
-        proxy_set_header Host $host;
-    }
-
-    # Proxy auth for media
     location /media/ {
         # Auth request configuration
-        auth_request /media-auth;
+        auth_request /auth;
         auth_request_set $authHeader $upstream_http_authorization;
         auth_request_set $authDate $upstream_http_x_amz_date;
         auth_request_set $authContentSha256 $upstream_http_x_amz_content_sha256;
@@ -70,8 +21,8 @@ server {
         proxy_set_header Host minio:9000;
     }
 
-    location /media-auth {
-        proxy_pass http://app-dev:8000/api/v1.0/documents/media-auth/;
+    location /auth {
+        proxy_pass http://app-dev:8000/api/v1.0/documents/retrieve-auth/;
         proxy_set_header Host $host;
         proxy_set_header X-Real-IP $remote_addr;
         proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;

docs/examples/impress.values.yaml

@@ -1,163 +0,0 @@
-image:
-  repository: lasuite/impress-backend
-  pullPolicy: Always
-  tag: "latest"
-
-backend:
-  replicas: 1
-  envVars:
-    COLLABORATION_API_URL: https://impress.127.0.0.1.nip.io/collaboration/api/
-    COLLABORATION_SERVER_SECRET: my-secret
-    DJANGO_CSRF_TRUSTED_ORIGINS: https://impress.127.0.0.1.nip.io
-    DJANGO_CONFIGURATION: Feature
-    DJANGO_ALLOWED_HOSTS: impress.127.0.0.1.nip.io
-    DJANGO_SERVER_TO_SERVER_API_TOKENS: secret-api-key
-    DJANGO_SECRET_KEY: AgoodOrAbadKey
-    DJANGO_SETTINGS_MODULE: impress.settings
-    DJANGO_SUPERUSER_PASSWORD: admin
-    DJANGO_EMAIL_BRAND_NAME: "La Suite Numérique"
-    DJANGO_EMAIL_HOST: "mailcatcher"
-    DJANGO_EMAIL_LOGO_IMG: https://impress.127.0.0.1.nip.io/assets/logo-suite-numerique.png
-    DJANGO_EMAIL_PORT: 1025
-    DJANGO_EMAIL_USE_SSL: False
-    LOGGING_LEVEL_HANDLERS_CONSOLE: ERROR
-    LOGGING_LEVEL_LOGGERS_ROOT: INFO
-    LOGGING_LEVEL_LOGGERS_APP: INFO
-    OIDC_OP_JWKS_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/certs
-    OIDC_OP_AUTHORIZATION_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/auth
-    OIDC_OP_TOKEN_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/token
-    OIDC_OP_USER_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/userinfo
-    OIDC_OP_LOGOUT_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/session/end
-    OIDC_RP_CLIENT_ID: impress
-    OIDC_RP_CLIENT_SECRET: ThisIsAnExampleKeyForDevPurposeOnly
-    OIDC_RP_SIGN_ALGO: RS256
-    OIDC_RP_SCOPES: "openid email"
-    OIDC_VERIFY_SSL: False
-    USER_OIDC_FIELD_TO_SHORTNAME: "given_name"
-    USER_OIDC_FIELDS_TO_FULLNAME: "given_name,usual_name"
-    OIDC_REDIRECT_ALLOWED_HOSTS: https://impress.127.0.0.1.nip.io
-    OIDC_AUTH_REQUEST_EXTRA_PARAMS: "{'acr_values': 'eidas1'}"
-    LOGIN_REDIRECT_URL: https://impress.127.0.0.1.nip.io
-    LOGIN_REDIRECT_URL_FAILURE: https://impress.127.0.0.1.nip.io
-    LOGOUT_REDIRECT_URL: https://impress.127.0.0.1.nip.io
-    POSTHOG_KEY: "{'id': 'posthog_key', 'host': 'https://product.impress.127.0.0.1.nip.io'}"
-    DB_HOST: postgresql
-    DB_NAME: impress
-    DB_USER: dinum
-    DB_PASSWORD: pass
-    DB_PORT: 5432
-    POSTGRES_DB: impress
-    POSTGRES_USER: dinum
-    POSTGRES_PASSWORD: pass
-    REDIS_URL: redis://default:pass@redis-master:6379/1
-    AWS_S3_ENDPOINT_URL: http://minio.impress.svc.cluster.local:9000
-    AWS_S3_ACCESS_KEY_ID: root
-    AWS_S3_SECRET_ACCESS_KEY: password
-    AWS_STORAGE_BUCKET_NAME: impress-media-storage
-    STORAGES_STATICFILES_BACKEND: django.contrib.staticfiles.storage.StaticFilesStorage
-    Y_PROVIDER_API_BASE_URL: http://impress-y-provider:443/api/
-    Y_PROVIDER_API_KEY: my-secret
-
-  migrate:
-    command:
-      - "/bin/sh"
-      - "-c"
-      - |
-        python manage.py migrate --no-input &&
-        python manage.py create_demo --force
-    restartPolicy: Never
-
-  command:
-    - "gunicorn"
-    - "-c"
-    - "/usr/local/etc/gunicorn/impress.py"
-    - "impress.wsgi:application"
-    - "--reload"
-
-  createsuperuser:
-    command:
-      - "/bin/sh"
-      - "-c"
-      - |
-        python manage.py createsuperuser --email admin@example.com --password admin
-    restartPolicy: Never
-
-  # Exra volume to manage our local custom CA and avoid to set ssl_verify: false
-  extraVolumeMounts:
-    - name: certs
-      mountPath: /usr/local/lib/python3.12/site-packages/certifi/cacert.pem
-      subPath: cacert.pem
-
-  # Exra volume to manage our local custom CA and avoid to set ssl_verify: false
-  extraVolumes:
-    - name: certs
-      configMap:
-        name: certifi
-        items:
-        - key: cacert.pem
-          path: cacert.pem
-frontend:
-  envVars:
-    PORT: 8080
-    NEXT_PUBLIC_API_ORIGIN: https://impress.127.0.0.1.nip.io
-
-  replicas: 1
-
-  image:
-    repository: lasuite/impress-frontend
-    pullPolicy: Always
-    tag: "latest"
-
-yProvider:
-  replicas: 1
-
-  image:
-    repository: lasuite/impress-y-provider
-    pullPolicy: Always
-    tag: "latest"
-
-  envVars:
-    COLLABORATION_LOGGING: true
-    COLLABORATION_SERVER_ORIGIN: https://impress.127.0.0.1.nip.io
-    COLLABORATION_SERVER_SECRET: my-secret
-    Y_PROVIDER_API_KEY: my-secret
-
-posthog:
-  ingress:
-    enabled: false
-  ingressAssets:
-    enabled: false
-
-ingress:
-  enabled: true
-  host: impress.127.0.0.1.nip.io
-
-ingressCollaborationWS:
-  enabled: true
-  host: impress.127.0.0.1.nip.io
-  
-  annotations:
-    nginx.ingress.kubernetes.io/auth-url: https://impress.127.0.0.1.nip.io/api/v1.0/documents/collaboration-auth/
-
-ingressCollaborationApi:
-  enabled: true
-  host: impress.127.0.0.1.nip.io
-
-ingressAdmin:
-  enabled: true
-  host: impress.127.0.0.1.nip.io
-
-ingressMedia:
-  enabled: true
-  host: impress.127.0.0.1.nip.io
-
-  annotations:
-    nginx.ingress.kubernetes.io/auth-url: https://impress.127.0.0.1.nip.io/api/v1.0/documents/media-auth/
-    nginx.ingress.kubernetes.io/auth-response-headers: "Authorization, X-Amz-Date, X-Amz-Content-SHA256"
-    nginx.ingress.kubernetes.io/upstream-vhost: minio.impress.svc.cluster.local:9000
-    nginx.ingress.kubernetes.io/rewrite-target: /impress-media-storage/$1
-
-serviceMedia:
-  host: minio.impress.svc.cluster.local
-  port: 9000
-

docs/examples/minio.values.yaml

@@ -1,8 +0,0 @@
-auth:
-  rootUser: root
-  rootPassword: password
-provisioning:
-  enabled: true
-  buckets:
-    - name: impress-media-storage
-      versioning: true

docs/examples/postgresql.values.yaml

@@ -1,7 +0,0 @@
-auth:
-  username: dinum
-  password: pass
-  database: impress
-tls:
-  enabled: true
-  autoGenerated: true

docs/examples/redis.values.yaml

@@ -1,4 +0,0 @@
-auth:
-  password: pass
-architecture: standalone
-

docs/installation.md

@@ -1,231 +0,0 @@
-# Installation on a k8s cluster
-
-This document is a step-by-step guide that describes how to install Docs on a k8s cluster without AI features. It's a teaching document to learn how it's work. It needs to be adapt for production environment.
-
-
-## Prerequisites
-
-- k8s cluster with an nginx-ingress controller
-- an OIDC provider (if you don't have one, we will provide an example)
-- a PostgreSQL server (if you don't have one, we will provide an example)
-- a Memcached server (if you don't have one, we will provide an example)
-- a S3 bucket (if you don't have one, we will provide an example)
-
-### Test cluster
-
-If you do not have a test cluster, you can install everything on a local kind cluster. In this case, the simplest way is to use our script **bin/start-kind.sh**.
-
-To be able to use the script, you will need to install:
-
-- Docker (https://docs.docker.com/desktop/)
-- Kind (https://kind.sigs.k8s.io/docs/user/quick-start/#installation)
-- Mkcert (https://github.com/FiloSottile/mkcert#installation)
-- Helm (https://helm.sh/docs/intro/quickstart/#install-helm)
-
-```
-./bin/start-kind.sh 
-  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
-                                 Dload  Upload   Total   Spent    Left  Speed
-100  4700  100  4700    0     0  92867      0 --:--:-- --:--:-- --:--:-- 94000
-0. Create ca
-The local CA is already installed in the system trust store! 👍
-The local CA is already installed in the Firefox and/or Chrome/Chromium trust store! 👍
-
-
-Created a new certificate valid for the following names 📜
- - "127.0.0.1.nip.io"
- - "*.127.0.0.1.nip.io"
-
-Reminder: X.509 wildcards only go one level deep, so this won't match a.b.127.0.0.1.nip.io ℹ️
-
-The certificate is at "./127.0.0.1.nip.io+1.pem" and the key at "./127.0.0.1.nip.io+1-key.pem" ✅
-
-It will expire on 24 March 2027 🗓
-
-1. Create registry container unless it already exists
-2. Create kind cluster with containerd registry config dir enabled
-Creating cluster "suite" ...
- ✓ Ensuring node image (kindest/node:v1.27.3) 🖼
- ✓ Preparing nodes 📦  
- ✓ Writing configuration 📜 
- ✓ Starting control-plane 🕹️ 
- ✓ Installing CNI 🔌 
- ✓ Installing StorageClass 💾 
-Set kubectl context to "kind-suite"
-You can now use your cluster with:
-
-kubectl cluster-info --context kind-suite
-
-Thanks for using kind! 😊
-3. Add the registry config to the nodes
-4. Connect the registry to the cluster network if not already connected
-5. Document the local registry
-configmap/local-registry-hosting created
-Warning: resource configmaps/coredns is missing the kubectl.kubernetes.io/last-applied-configuration annotation which is required by kubectl apply. kubectl apply should only be used on resources created declaratively by either kubectl create --save-config or kubectl apply. The missing annotation will be patched automatically.
-configmap/coredns configured
-deployment.apps/coredns restarted
-6. Install ingress-nginx
-namespace/ingress-nginx created
-serviceaccount/ingress-nginx created
-serviceaccount/ingress-nginx-admission created
-role.rbac.authorization.k8s.io/ingress-nginx created
-role.rbac.authorization.k8s.io/ingress-nginx-admission created
-clusterrole.rbac.authorization.k8s.io/ingress-nginx created
-clusterrole.rbac.authorization.k8s.io/ingress-nginx-admission created
-rolebinding.rbac.authorization.k8s.io/ingress-nginx created
-rolebinding.rbac.authorization.k8s.io/ingress-nginx-admission created
-clusterrolebinding.rbac.authorization.k8s.io/ingress-nginx created
-clusterrolebinding.rbac.authorization.k8s.io/ingress-nginx-admission created
-configmap/ingress-nginx-controller created
-service/ingress-nginx-controller created
-service/ingress-nginx-controller-admission created
-deployment.apps/ingress-nginx-controller created
-job.batch/ingress-nginx-admission-create created
-job.batch/ingress-nginx-admission-patch created
-ingressclass.networking.k8s.io/nginx created
-validatingwebhookconfiguration.admissionregistration.k8s.io/ingress-nginx-admission created
-secret/mkcert created
-deployment.apps/ingress-nginx-controller patched
-7. Setup namespace
-namespace/impress created
-Context "kind-suite" modified.
-secret/mkcert created
-$ kubectl -n ingress-nginx get po
-NAME                                        READY   STATUS      RESTARTS   AGE
-ingress-nginx-admission-create-t55ph        0/1     Completed   0          2m56s
-ingress-nginx-admission-patch-94dvt         0/1     Completed   1          2m56s
-ingress-nginx-controller-57c548c4cd-2rx47   1/1     Running     0          2m56s
-```
-When your k8s cluster is ready (the ingress nginx controller is up), you can start the deployment. This cluster is special because it uses the *.127.0.0.1.nip.io domain and mkcert certificates to have full HTTPS support and easy domain name management.
-
-Please remember that *.127.0.0.1.nip.io will always resolve to 127.0.0.1, except in the k8s cluster where we configure CoreDNS to answer with the ingress-nginx service IP.
-
-## Preparation
-
-### What will you use to authenticate your users ?
-
-Docs uses OIDC, so if you already have an OIDC provider, obtain the necessary information to use it. In the next step, we will see how to configure Django (and thus Docs) to use it. If you do not have a provider, we will show you how to deploy a local Keycloak instance (this is not a production deployment, just a demo).
-
-```
-$ kubectl create namespace impress
-$ kubectl config set-context --current --namespace=impress
-$ helm install keycloak oci://registry-1.docker.io/bitnamicharts/keycloak -f examples/keycloak.values.yaml
-$ #wait until
-$ kubectl get po
-NAME                    READY   STATUS    RESTARTS   AGE
-keycloak-0              1/1     Running   0          6m48s
-keycloak-postgresql-0   1/1     Running   0          6m48s
-```
-
-From here the important informations you will need are :
-
-```
-OIDC_OP_JWKS_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/certs
-OIDC_OP_AUTHORIZATION_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/auth
-OIDC_OP_TOKEN_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/token
-OIDC_OP_USER_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/userinfo
-OIDC_OP_LOGOUT_ENDPOINT: https://keycloak.127.0.0.1.nip.io/realms/impress/protocol/openid-connect/session/end
-OIDC_RP_CLIENT_ID: impress
-OIDC_RP_CLIENT_SECRET: ThisIsAnExampleKeyForDevPurposeOnly
-OIDC_RP_SIGN_ALGO: RS256
-OIDC_RP_SCOPES: "openid email"
-```
-
-You can find these values in **examples/keycloak.values.yaml**
-
-### Find redis server connexion values
-
-Impress need a redis so we will start by deploying a redis :
-
-```
-$ helm install redis oci://registry-1.docker.io/bitnamicharts/redis -f examples/redis.values.yaml
-$ kubectl get po
-NAME                    READY   STATUS    RESTARTS   AGE
-keycloak-0              1/1     Running   0          26m
-keycloak-postgresql-0   1/1     Running   0          26m
-redis-master-0          1/1     Running   0          35s
-```
-
-### Find postgresql connexion values
-
-Impress uses a postgresql db as backend so if you have a provider, obtain the necessary information to use it. If you do not have, you can install a postgresql testing environment as follow:
-
-```
-$ helm install postgresql oci://registry-1.docker.io/bitnamicharts/postgresql -f examples/postgresql.values.yaml
-$ kubectl get po
-NAME                    READY   STATUS    RESTARTS   AGE
-keycloak-0              1/1     Running   0          28m
-keycloak-postgresql-0   1/1     Running   0          28m
-postgresql-0            1/1     Running   0          14m
-redis-master-0          1/1     Running   0          42s
-```
-
-From here important informations you will need are :
-
-```
-DB_HOST: postgres-postgresql
-DB_NAME: impress
-DB_USER: dinum
-DB_PASSWORD: pass
-DB_PORT: 5432
-POSTGRES_DB: impress
-POSTGRES_USER: dinum
-POSTGRES_PASSWORD: pass
-```
-
-### Find s3 bucket connexion values
-
-Impress uses a s3 bucket to store documents so if you have a provider obtain the necessary information to use it. If you do not have, you can install a local minio testing environment as follow:
-
-```
-$ helm install minio oci://registry-1.docker.io/bitnamicharts/minio -f examples/minio.values.yaml
-$ kubectl get po
-NAME                       READY   STATUS      RESTARTS   AGE
-keycloak-0                 1/1     Running     0          38m
-keycloak-postgresql-0      1/1     Running     0          38m
-minio-84f5c66895-bbhsk     1/1     Running     0          42s
-minio-provisioning-2b5sq   0/1     Completed   0          42s
-postgresql-0               1/1     Running     0          24m
-redis-master-0             1/1     Running     0          10m
-```
-
-## Deployment
-
-Now you are ready to deploy Impress without AI. AI requiered more dependancies (openai API). To deploy impress you need to provide all previous informations to the helm chart.
-
-```
-$ helm repo add impress https://suitenumerique.github.io/docs/
-$ helm repo update
-$ helm install impress impress/docs -f examples/impress.values.yaml
-$ kubectl get po
-NAME                                         READY   STATUS      RESTARTS   AGE
-impress-docs-backend-96558758d-xtkbp         0/1     Running     0          79s
-impress-docs-backend-createsuperuser-r7ltc   0/1     Completed   0          79s
-impress-docs-backend-migrate-c949s           0/1     Completed   0          79s
-impress-docs-frontend-6749f644f7-p5s42       1/1     Running     0          79s
-impress-docs-y-provider-6947fd8f54-78f2l     1/1     Running     0          79s
-keycloak-0                                   1/1     Running     0          48m
-keycloak-postgresql-0                        1/1     Running     0          48m
-minio-84f5c66895-bbhsk                       1/1     Running     0          10m
-minio-provisioning-2b5sq                     0/1     Completed   0          10m
-postgresql-0                                 1/1     Running     0          34m
-redis-master-0                               1/1     Running     0          20m
-```
-
-## Test your deployment
-
-In order to test your deployment you have to login to your instance. If you use exclusively our examples you can do :
-
-```
-$ kubectl get ingress
-NAME                             CLASS    HOSTS                       ADDRESS     PORTS     AGE
-impress-docs                     <none>   impress.127.0.0.1.nip.io    localhost   80, 443   114s
-impress-docs-admin               <none>   impress.127.0.0.1.nip.io    localhost   80, 443   114s
-impress-docs-collaboration-api   <none>   impress.127.0.0.1.nip.io    localhost   80, 443   114s
-impress-docs-media               <none>   impress.127.0.0.1.nip.io    localhost   80, 443   114s
-impress-docs-ws                  <none>   impress.127.0.0.1.nip.io    localhost   80, 443   114s
-keycloak                         <none>   keycloak.127.0.0.1.nip.io   localhost   80        49m
-```
-
-You can use impress on https://impress.127.0.0.1.nip.io. The provisionning user in keycloak is impress/impress.
-

env.d/development/common.dist

@@ -4,21 +4,13 @@ DJANGO_SECRET_KEY=ThisIsAnExampleKeyForDevPurposeOnly
 DJANGO_SETTINGS_MODULE=impress.settings
 DJANGO_SUPERUSER_PASSWORD=admin
 
-# Logging
-# Set to DEBUG level for dev only
-LOGGING_LEVEL_HANDLERS_CONSOLE=INFO
-LOGGING_LEVEL_LOGGERS_ROOT=INFO
-LOGGING_LEVEL_LOGGERS_APP=INFO
-
 # Python
 PYTHONPATH=/app
 
 # impress settings
 
 # Mail
-DJANGO_EMAIL_BRAND_NAME="La Suite Numérique"
 DJANGO_EMAIL_HOST="mailcatcher"
-DJANGO_EMAIL_LOGO_IMG="http://localhost:3000/assets/logo-suite-numerique.png"
 DJANGO_EMAIL_PORT=1025
 
 # Backend url
@@ -29,7 +21,6 @@ STORAGES_STATICFILES_BACKEND=django.contrib.staticfiles.storage.StaticFilesStora
 AWS_S3_ENDPOINT_URL=http://minio:9000
 AWS_S3_ACCESS_KEY_ID=impress
 AWS_S3_SECRET_ACCESS_KEY=password
-MEDIA_BASE_URL=http://localhost:8083
 
 # OIDC
 OIDC_OP_JWKS_ENDPOINT=http://nginx:8083/realms/impress/protocol/openid-connect/certs
@@ -53,12 +44,3 @@ OIDC_AUTH_REQUEST_EXTRA_PARAMS={"acr_values": "eidas1"}
 AI_BASE_URL=https://openaiendpoint.com
 AI_API_KEY=password
 AI_MODEL=llama
-
-# Collaboration
-COLLABORATION_API_URL=http://nginx:8083/collaboration/api/
-COLLABORATION_SERVER_ORIGIN=http://localhost:3000
-COLLABORATION_SERVER_SECRET=my-secret
-COLLABORATION_WS_URL=ws://localhost:8083/collaboration/ws/
-
-# Frontend
-FRONTEND_THEME=dsfr

env.d/development/common.e2e.dist

@@ -1,6 +1,3 @@
 # For the CI job test-e2e
 SUSTAINED_THROTTLE_RATES="200/hour"
 BURST_THROTTLE_RATES="200/minute"
-DJANGO_SERVER_TO_SERVER_API_TOKENS=test-e2e
-Y_PROVIDER_API_KEY=yprovider-api-key
-Y_PROVIDER_API_BASE_URL=http://y-provider:4444/api/

env.d/development/crowdin.dist

@@ -1,3 +1,3 @@
-CROWDIN_PERSONAL_TOKEN=Your-Personal-Token
+CROWDIN_API_TOKEN=Your-Api-Token
 CROWDIN_PROJECT_ID=Your-Project-Id
 CROWDIN_BASE_PATH=/app/src

renovate.json

@@ -13,18 +13,7 @@
       "enabled": false,
       "groupName": "ignored js dependencies",
       "matchManagers": ["npm"],
-      "matchPackageNames": [
-        "@openfun/cunningham-react",
-        "@types/react",
-        "@types/react-dom",
-        "eslint",
-        "fetch-mock",
-        "node",
-        "node-fetch",
-        "react",
-        "react-dom",
-        "workbox-webpack-plugin"
-      ]
+      "matchPackageNames": ["fetch-mock", "node", "node-fetch", "eslint"]
     }
   ]
 }

src/backend/core/admin.py

@@ -4,16 +4,12 @@ from django.contrib import admin
 from django.contrib.auth import admin as auth_admin
 from django.utils.translation import gettext_lazy as _
 
-from treebeard.admin import TreeAdmin
-from treebeard.forms import movenodeform_factory
-
 from . import models
 
 
 class TemplateAccessInline(admin.TabularInline):
     """Inline admin class for template accesses."""
 
-    autocomplete_fields = ["user"]
     model = models.TemplateAccess
     extra = 0
 
@@ -115,47 +111,14 @@ class TemplateAdmin(admin.ModelAdmin):
 class DocumentAccessInline(admin.TabularInline):
     """Inline admin class for template accesses."""
 
-    autocomplete_fields = ["user"]
     model = models.DocumentAccess
     extra = 0
 
 
 @admin.register(models.Document)
-class DocumentAdmin(TreeAdmin):
+class DocumentAdmin(admin.ModelAdmin):
     """Document admin interface declaration."""
 
-    fieldsets = (
-        (
-            None,
-            {
-                "fields": (
-                    "id",
-                    "title",
-                )
-            },
-        ),
-        (
-            _("Permissions"),
-            {
-                "fields": (
-                    "creator",
-                    "link_reach",
-                    "link_role",
-                )
-            },
-        ),
-        (
-            _("Tree structure"),
-            {
-                "fields": (
-                    "path",
-                    "depth",
-                    "numchild",
-                )
-            },
-        ),
-    )
-    form = movenodeform_factory(models.Document)
     inlines = (DocumentAccessInline,)
     list_display = (
         "id",
@@ -165,14 +128,6 @@ class DocumentAdmin(TreeAdmin):
         "created_at",
         "updated_at",
     )
-    readonly_fields = (
-        "creator",
-        "depth",
-        "id",
-        "numchild",
-        "path",
-    )
-    search_fields = ("id", "title")
 
 
 @admin.register(models.Invitation)

src/backend/core/api/filters.py

@@ -1,66 +0,0 @@
-"""API filters for Impress' core application."""
-
-from django.utils.translation import gettext_lazy as _
-
-import django_filters
-
-from core import models
-
-
-class DocumentFilter(django_filters.FilterSet):
-    """
-    Custom filter for filtering documents.
-    """
-
-    is_creator_me = django_filters.BooleanFilter(
-        method="filter_is_creator_me", label=_("Creator is me")
-    )
-    is_favorite = django_filters.BooleanFilter(
-        method="filter_is_favorite", label=_("Favorite")
-    )
-    title = django_filters.CharFilter(
-        field_name="title", lookup_expr="icontains", label=_("Title")
-    )
-
-    class Meta:
-        model = models.Document
-        fields = ["is_creator_me", "is_favorite", "title"]
-
-    # pylint: disable=unused-argument
-    def filter_is_creator_me(self, queryset, name, value):
-        """
-        Filter documents based on the `creator` being the current user.
-
-        Example:
-            - /api/v1.0/documents/?is_creator_me=true
-                → Filters documents created by the logged-in user
-            - /api/v1.0/documents/?is_creator_me=false
-                → Filters documents created by other users
-        """
-        user = self.request.user
-
-        if not user.is_authenticated:
-            return queryset
-
-        if value:
-            return queryset.filter(creator=user)
-
-        return queryset.exclude(creator=user)
-
-    # pylint: disable=unused-argument
-    def filter_is_favorite(self, queryset, name, value):
-        """
-        Filter documents based on whether they are marked as favorite by the current user.
-
-        Example:
-            - /api/v1.0/documents/?is_favorite=true
-                → Filters documents marked as favorite by the logged-in user
-            - /api/v1.0/documents/?is_favorite=false
-                → Filters documents not marked as favorite by the logged-in user
-        """
-        user = self.request.user
-
-        if not user.is_authenticated:
-            return queryset
-
-        return queryset.filter(is_favorite=bool(value))

src/backend/core/api/permissions.py

@@ -2,15 +2,13 @@
 
 from django.core import exceptions
 from django.db.models import Q
-from django.http import Http404
 
 from rest_framework import permissions
 
-from core.models import DocumentAccess, RoleChoices, get_trashbin_cutoff
+from core.models import DocumentAccess, RoleChoices
 
 ACTION_FOR_METHOD_TO_PERMISSION = {
-    "versions_detail": {"DELETE": "versions_destroy", "GET": "versions_retrieve"},
-    "children": {"GET": "children_list", "POST": "children_create"},
+    "versions_detail": {"DELETE": "versions_destroy", "GET": "versions_retrieve"}
 }
 
 
@@ -111,26 +109,3 @@ class AccessPermission(permissions.BasePermission):
         except KeyError:
             pass
         return abilities.get(action, False)
-
-
-class DocumentAccessPermission(AccessPermission):
-    """Subclass to handle soft deletion specificities."""
-
-    def has_object_permission(self, request, view, obj):
-        """
-        Return a 404 on deleted documents
-        - for which the trashbin cutoff is past
-        - for which the current user is not owner of the document or one of its ancestors
-        """
-        if (
-            deleted_at := obj.ancestors_deleted_at
-        ) and deleted_at < get_trashbin_cutoff():
-            raise Http404
-
-        # Compute permission first to ensure the "user_roles" attribute is set
-        has_permission = super().has_object_permission(request, view, obj)
-
-        if obj.ancestors_deleted_at and not RoleChoices.OWNER in obj.user_roles:
-            raise Http404
-
-        return has_permission

src/backend/core/api/serializers.py

@@ -4,7 +4,6 @@ import mimetypes
 
 from django.conf import settings
 from django.db.models import Q
-from django.utils.functional import lazy
 from django.utils.translation import gettext_lazy as _
 
 import magic
@@ -12,10 +11,6 @@ from rest_framework import exceptions, serializers
 
 from core import enums, models
 from core.services.ai_services import AI_ACTIONS
-from core.services.converter_services import (
-    ConversionError,
-    YdocConverter,
-)
 
 
 class UserSerializer(serializers.ModelSerializer):
@@ -142,99 +137,33 @@ class BaseResourceSerializer(serializers.ModelSerializer):
         return {}
 
 
-class ListDocumentSerializer(BaseResourceSerializer):
-    """Serialize documents with limited fields for display in lists."""
-
-    is_favorite = serializers.BooleanField(read_only=True)
-    nb_accesses = serializers.IntegerField(read_only=True)
-    user_roles = serializers.SerializerMethodField(read_only=True)
-
-    class Meta:
-        model = models.Document
-        fields = [
-            "id",
-            "abilities",
-            "created_at",
-            "creator",
-            "depth",
-            "excerpt",
-            "is_favorite",
-            "link_role",
-            "link_reach",
-            "nb_accesses",
-            "numchild",
-            "path",
-            "title",
-            "updated_at",
-            "user_roles",
-        ]
-        read_only_fields = [
-            "id",
-            "abilities",
-            "created_at",
-            "creator",
-            "depth",
-            "excerpt",
-            "is_favorite",
-            "link_role",
-            "link_reach",
-            "nb_accesses",
-            "numchild",
-            "path",
-            "updated_at",
-            "user_roles",
-        ]
-
-    def get_user_roles(self, document):
-        """
-        Return roles of the logged-in user for the current document,
-        taking into account ancestors.
-        """
-        request = self.context.get("request")
-        if request:
-            return document.get_roles(request.user)
-        return []
-
-
-class DocumentSerializer(ListDocumentSerializer):
-    """Serialize documents with all fields for display in detail views."""
+class DocumentSerializer(BaseResourceSerializer):
+    """Serialize documents."""
 
     content = serializers.CharField(required=False)
+    accesses = DocumentAccessSerializer(many=True, read_only=True)
 
     class Meta:
         model = models.Document
         fields = [
             "id",
-            "abilities",
             "content",
-            "created_at",
-            "creator",
-            "depth",
-            "excerpt",
-            "is_favorite",
+            "title",
+            "accesses",
+            "abilities",
             "link_role",
             "link_reach",
-            "nb_accesses",
-            "numchild",
-            "path",
-            "title",
+            "created_at",
             "updated_at",
-            "user_roles",
         ]
         read_only_fields = [
             "id",
+            "accesses",
             "abilities",
-            "created_at",
-            "creator",
-            "depth",
-            "is_favorite",
             "link_role",
             "link_reach",
-            "nb_accesses",
-            "numchild",
-            "path",
+            "created_at",
             "updated_at",
-            "user_roles",
         ]
 
     def get_fields(self):
@@ -261,104 +190,6 @@ class DocumentSerializer(ListDocumentSerializer):
         return value
 
 
-class ServerCreateDocumentSerializer(serializers.Serializer):
-    """
-    Serializer for creating a document from a server-to-server request.
-
-    Expects 'content' as a markdown string, which is converted to our internal format
-    via a Node.js microservice. The conversion is handled automatically, so third parties
-    only need to provide markdown.
-
-    Both "sub" and "email" are required because the external app calling doesn't know
-    if the user will pre-exist in Docs database. If the user pre-exist, we will ignore the
-    submitted "email" field and use the email address set on the user account in our database
-    """
-
-    # Document
-    title = serializers.CharField(required=True)
-    content = serializers.CharField(required=True)
-    # User
-    sub = serializers.CharField(
-        required=True, validators=[models.User.sub_validator], max_length=255
-    )
-    email = serializers.EmailField(required=True)
-    language = serializers.ChoiceField(
-        required=False, choices=lazy(lambda: settings.LANGUAGES, tuple)()
-    )
-    # Invitation
-    message = serializers.CharField(required=False)
-    subject = serializers.CharField(required=False)
-
-    def create(self, validated_data):
-        """Create the document and associate it with the user or send an invitation."""
-        language = validated_data.get("language", settings.LANGUAGE_CODE)
-
-        # Get the user on its sub (unique identifier). Default on email if allowed in settings
-        email = validated_data["email"]
-
-        try:
-            user = models.User.objects.get_user_by_sub_or_email(
-                validated_data["sub"], email
-            )
-        except models.DuplicateEmailError as err:
-            raise serializers.ValidationError({"email": [err.message]}) from err
-
-        if user:
-            email = user.email
-            language = user.language or language
-
-        try:
-            document_content = YdocConverter().convert_markdown(
-                validated_data["content"]
-            )
-        except ConversionError as err:
-            raise serializers.ValidationError(
-                {"content": ["Could not convert content"]}
-            ) from err
-
-        document = models.Document.add_root(
-            title=validated_data["title"],
-            content=document_content,
-            creator=user,
-        )
-
-        if user:
-            # Associate the document with the pre-existing user
-            models.DocumentAccess.objects.create(
-                document=document,
-                role=models.RoleChoices.OWNER,
-                user=user,
-            )
-        else:
-            # The user doesn't exist in our database: we need to invite him/her
-            models.Invitation.objects.create(
-                document=document,
-                email=email,
-                role=models.RoleChoices.OWNER,
-            )
-
-        self._send_email_notification(document, validated_data, email, language)
-        return document
-
-    def _send_email_notification(self, document, validated_data, email, language):
-        """Notify the user about the newly created document."""
-        subject = validated_data.get("subject") or _(
-            "A new document was created on your behalf!"
-        )
-        context = {
-            "message": validated_data.get("message")
-            or _("You have been granted ownership of a new document:"),
-            "title": subject,
-        }
-        document.send_email(subject, [email], context, language)
-
-    def update(self, instance, validated_data):
-        """
-        This serializer does not support updates.
-        """
-        raise NotImplementedError("Update is not supported for this serializer.")
-
-
 class LinkDocumentSerializer(BaseResourceSerializer):
     """
     Serialize link configuration for documents.
@@ -417,7 +248,6 @@ class FileUploadSerializer(serializers.Serializer):
             raise serializers.ValidationError("Could not determine file extension.")
 
         self.context["expected_extension"] = extension
-        self.context["content_type"] = magic_mime_type
 
         return file
 
@@ -425,7 +255,6 @@ class FileUploadSerializer(serializers.Serializer):
         """Override validate to add the computed extension to validated_data."""
         attrs["expected_extension"] = self.context["expected_extension"]
         attrs["is_unsafe"] = self.context["is_unsafe"]
-        attrs["content_type"] = self.context["content_type"]
         return attrs
 
 
@@ -568,37 +397,3 @@ class AITranslateSerializer(serializers.Serializer):
         if len(value.strip()) == 0:
             raise serializers.ValidationError("Text field cannot be empty.")
         return value
-
-
-class MoveDocumentSerializer(serializers.Serializer):
-    """
-    Serializer for validating input data to move a document within the tree structure.
-
-    Fields:
-        - target_document_id (UUIDField): The ID of the target parent document where the
-            document should be moved. This field is required and must be a valid UUID.
-        - position (ChoiceField): Specifies the position of the document in relation to
-            the target parent's children.
-          Choices:
-            - "first-child": Place the document as the first child of the target parent.
-            - "last-child": Place the document as the last child of the target parent (default).
-            - "left": Place the document as the left sibling of the target parent.
-            - "right": Place the document as the right sibling of the target parent.
-
-    Example:
-        Input payload for moving a document:
-        {
-            "target_document_id": "123e4567-e89b-12d3-a456-426614174000",
-            "position": "first-child"
-        }
-
-    Notes:
-        - The `target_document_id` is mandatory.
-        - The `position` defaults to "last-child" if not provided.
-    """
-
-    target_document_id = serializers.UUIDField(required=True)
-    position = serializers.ChoiceField(
-        choices=enums.MoveNodePositionChoices.choices,
-        default=enums.MoveNodePositionChoices.LAST_CHILD,
-    )

src/backend/core/api/utils.py

@@ -11,29 +11,6 @@ import botocore
 from rest_framework.throttling import BaseThrottle
 
 
-def filter_root_paths(paths, skip_sorting=False):
-    """
-    Filters root paths from a list of paths representing a tree structure.
-    A root path is defined as a path that is not a prefix of any other path.
-
-    Args:
-        paths (list of str): The list of paths.
-
-    Returns:
-        list of str: The filtered list of root paths.
-    """
-    if not skip_sorting:
-        paths.sort()
-
-    root_paths = []
-    for path in paths:
-        # If the current path is not a prefix of the last added root path, add it
-        if not root_paths or not path.startswith(root_paths[-1]):
-            root_paths.append(path)
-
-    return root_paths
-
-
 def generate_s3_authorization_headers(key):
     """
     Generate authorization headers for an s3 object.

src/backend/core/authentication/__init__.py

@@ -1,52 +0,0 @@
-"""Custom authentication classes for the Impress core app"""
-
-from django.conf import settings
-
-from rest_framework.authentication import BaseAuthentication
-from rest_framework.exceptions import AuthenticationFailed
-
-
-class ServerToServerAuthentication(BaseAuthentication):
-    """
-    Custom authentication class for server-to-server requests.
-    Validates the presence and correctness of the Authorization header.
-    """
-
-    AUTH_HEADER = "Authorization"
-    TOKEN_TYPE = "Bearer"  # noqa S105
-
-    def authenticate(self, request):
-        """
-        Authenticate the server-to-server request by validating the Authorization header.
-
-        This method checks if the Authorization header is present in the request, ensures it
-        contains a valid token with the correct format, and verifies the token against the
-        list of allowed server-to-server tokens. If the header is missing, improperly formatted,
-        or contains an invalid token, an AuthenticationFailed exception is raised.
-
-        Returns:
-            None: If authentication is successful
-                  (no user is authenticated for server-to-server requests).
-
-        Raises:
-            AuthenticationFailed: If the Authorization header is missing, malformed,
-            or contains an invalid token.
-        """
-        auth_header = request.headers.get(self.AUTH_HEADER)
-        if not auth_header:
-            raise AuthenticationFailed("Authorization header is missing.")
-
-        # Validate token format and existence
-        auth_parts = auth_header.split(" ")
-        if len(auth_parts) != 2 or auth_parts[0] != self.TOKEN_TYPE:
-            raise AuthenticationFailed("Invalid authorization header.")
-
-        token = auth_parts[1]
-        if token not in settings.SERVER_TO_SERVER_API_TOKENS:
-            raise AuthenticationFailed("Invalid server-to-server token.")
-
-        # Authentication is successful, but no user is authenticated
-
-    def authenticate_header(self, request):
-        """Return the WWW-Authenticate header value."""
-        return f"{self.TOKEN_TYPE} realm='Create document server to server'"

src/backend/core/authentication/backends.py

@@ -1,7 +1,5 @@
 """Authentication Backends for the Impress core app."""
 
-import logging
-
 from django.conf import settings
 from django.core.exceptions import SuspiciousOperation
 from django.utils.translation import gettext_lazy as _
@@ -11,9 +9,7 @@ from mozilla_django_oidc.auth import (
     OIDCAuthenticationBackend as MozillaOIDCAuthenticationBackend,
 )
 
-from core.models import DuplicateEmailError, User
-
-logger = logging.getLogger(__name__)
+from core.models import User
 
 
 class OIDCAuthenticationBackend(MozillaOIDCAuthenticationBackend):
@@ -63,29 +59,10 @@ class OIDCAuthenticationBackend(MozillaOIDCAuthenticationBackend):
 
         return userinfo
 
-    def verify_claims(self, claims):
-        """
-        Verify the presence of essential claims and the "sub" (which is mandatory as defined
-        by the OIDC specification) to decide if authentication should be allowed.
-        """
-        essential_claims = settings.USER_OIDC_ESSENTIAL_CLAIMS
-        missing_claims = [claim for claim in essential_claims if claim not in claims]
-
-        if missing_claims:
-            logger.error("Missing essential claims: %s", missing_claims)
-            return False
-
-        return True
-
     def get_or_create_user(self, access_token, id_token, payload):
         """Return a User based on userinfo. Create a new user if no match is found."""
 
         user_info = self.get_userinfo(access_token, id_token, payload)
-
-        if not self.verify_claims(user_info):
-            raise SuspiciousOperation("Claims verification failed.")
-
-        sub = user_info["sub"]
         email = user_info.get("email")
 
         # Get user's full name from OIDC fields defined in settings
@@ -98,10 +75,13 @@ class OIDCAuthenticationBackend(MozillaOIDCAuthenticationBackend):
             "short_name": short_name,
         }
 
-        try:
-            user = User.objects.get_user_by_sub_or_email(sub, email)
-        except DuplicateEmailError as err:
-            raise SuspiciousOperation(err.message) from err
+        sub = user_info.get("sub")
+        if not sub:
+            raise SuspiciousOperation(
+                _("User info contained no recognizable user identification")
+            )
+
+        user = self.get_existing_user(sub, email)
 
         if user:
             if not user.is_active:
@@ -120,6 +100,18 @@ class OIDCAuthenticationBackend(MozillaOIDCAuthenticationBackend):
         )
         return full_name or None
 
+    def get_existing_user(self, sub, email):
+        """Fetch existing user by sub or email."""
+        try:
+            return User.objects.get(sub=sub)
+        except User.DoesNotExist:
+            if email and settings.OIDC_FALLBACK_TO_EMAIL_FOR_IDENTIFICATION:
+                try:
+                    return User.objects.get(email=email)
+                except User.DoesNotExist:
+                    pass
+        return None
+
     def update_user_if_needed(self, user, claims):
         """Update user claims if they have changed."""
         has_changed = any(
@@ -127,4 +119,4 @@ class OIDCAuthenticationBackend(MozillaOIDCAuthenticationBackend):
         )
         if has_changed:
             updated_claims = {key: value for key, value in claims.items() if value}
-            self.UserModel.objects.filter(id=user.id).update(**updated_claims)
+            self.UserModel.objects.filter(sub=user.sub).update(**updated_claims)

src/backend/core/enums.py

@@ -3,7 +3,6 @@ Core application enums declaration
 """
 
 from django.conf import global_settings
-from django.db import models
 from django.utils.translation import gettext_lazy as _
 
 # In Django's code base, `LANGUAGES` is set by default with all supported languages.
@@ -11,14 +10,3 @@ from django.utils.translation import gettext_lazy as _
 # active in the app.
 # pylint: disable=no-member
 ALL_LANGUAGES = {language: _(name) for language, name in global_settings.LANGUAGES}
-
-
-class MoveNodePositionChoices(models.TextChoices):
-    """Defines the possible positions when moving a django-treebeard node."""
-
-    FIRST_CHILD = "first-child", _("First child")
-    LAST_CHILD = "last-child", _("Last child")
-    FIRST_SIBLING = "first-sibling", _("First sibling")
-    LAST_SIBLING = "last-sibling", _("Last sibling")
-    LEFT = "left", _("Left")
-    RIGHT = "right", _("Right")

src/backend/core/factories.py

@@ -46,23 +46,6 @@ class UserFactory(factory.django.DjangoModelFactory):
             UserTemplateAccessFactory(user=self, role="owner")
 
 
-class ParentNodeFactory(factory.declarations.ParameteredAttribute):
-    """Custom factory attribute for setting the parent node."""
-
-    def generate(self, step, params):
-        """
-        Generate a parent node for the factory.
-
-        This method is invoked during the factory's build process to determine the parent
-        node of the current object being created. If `params` is provided, it uses the factory's
-        metadata to recursively create or fetch the parent node. Otherwise, it returns `None`.
-        """
-        if not params:
-            return None
-        subfactory = step.builder.factory_meta.factory
-        return step.recurse(subfactory, params)
-
-
 class DocumentFactory(factory.django.DjangoModelFactory):
     """A factory to create documents"""
 
@@ -71,13 +54,8 @@ class DocumentFactory(factory.django.DjangoModelFactory):
         django_get_or_create = ("title",)
         skip_postgeneration_save = True
 
-    parent = ParentNodeFactory()
-
     title = factory.Sequence(lambda n: f"document{n}")
-    excerpt = factory.Sequence(lambda n: f"excerpt{n}")
     content = factory.Sequence(lambda n: f"content{n}")
-    creator = factory.SubFactory(UserFactory)
-    deleted_at = None
     link_reach = factory.fuzzy.FuzzyChoice(
         [a[0] for a in models.LinkReachChoices.choices]
     )
@@ -85,29 +63,6 @@ class DocumentFactory(factory.django.DjangoModelFactory):
         [r[0] for r in models.LinkRoleChoices.choices]
     )
 
-    @classmethod
-    def _create(cls, model_class, *args, **kwargs):
-        """
-        Custom creation logic for the factory: creates a document as a child node if
-        a parent is provided; otherwise, creates it as a root node.
-        """
-        parent = kwargs.pop("parent", None)
-
-        if parent:
-            # Add as a child node
-            kwargs["ancestors_deleted_at"] = (
-                kwargs.get("ancestors_deleted_at") or parent.ancestors_deleted_at
-            )
-            return parent.add_child(instance=model_class(**kwargs))
-
-        # Add as a root node
-        return model_class.add_root(instance=model_class(**kwargs))
-
-    @factory.lazy_attribute
-    def ancestors_deleted_at(self):
-        """Should always be set when "deleted_at" is set."""
-        return self.deleted_at
-
     @factory.post_generation
     def users(self, create, extracted, **kwargs):
         """Add users to document from a given list of users with or without roles."""
@@ -118,16 +73,6 @@ class DocumentFactory(factory.django.DjangoModelFactory):
                 else:
                     UserDocumentAccessFactory(document=self, user=item[0], role=item[1])
 
-    @factory.post_generation
-    def teams(self, create, extracted, **kwargs):
-        """Add teams to document from a given list of teams with or without roles."""
-        if create and extracted:
-            for item in extracted:
-                if isinstance(item, str):
-                    TeamDocumentAccessFactory(document=self, team=item)
-                else:
-                    TeamDocumentAccessFactory(document=self, team=item[0], role=item[1])
-
     @factory.post_generation
     def link_traces(self, create, extracted, **kwargs):
         """Add link traces to document from a given list of users."""
@@ -135,13 +80,6 @@ class DocumentFactory(factory.django.DjangoModelFactory):
             for item in extracted:
                 models.LinkTrace.objects.create(document=self, user=item)
 
-    @factory.post_generation
-    def favorited_by(self, create, extracted, **kwargs):
-        """Mark document as favorited by a list of users."""
-        if create and extracted:
-            for item in extracted:
-                models.DocumentFavorite.objects.create(document=self, user=item)
-
 
 class UserDocumentAccessFactory(factory.django.DjangoModelFactory):
     """Create fake document user accesses for testing."""

src/backend/core/management/commands/update_files_content_type_metadata.py

@@ -1,95 +0,0 @@
-"""Management command updating the metadata for all the files in the MinIO bucket."""
-
-from django.core.files.storage import default_storage
-from django.core.management.base import BaseCommand
-
-import magic
-
-from core.models import Document
-
-# pylint: disable=too-many-locals, broad-exception-caught
-
-
-class Command(BaseCommand):
-    """Update the metadata for all the files in the MinIO bucket."""
-
-    help = __doc__
-
-    def handle(self, *args, **options):
-        """Execute management command."""
-        s3_client = default_storage.connection.meta.client
-        bucket_name = default_storage.bucket_name
-
-        mime_detector = magic.Magic(mime=True)
-
-        documents = Document.objects.all()
-        self.stdout.write(
-            f"[INFO] Found {documents.count()} documents. Starting ContentType fix..."
-        )
-
-        for doc in documents:
-            doc_id_str = str(doc.id)
-            prefix = f"{doc_id_str}/attachments/"
-            self.stdout.write(
-                f"[INFO] Processing attachments under prefix '{prefix}' ..."
-            )
-
-            continuation_token = None
-            total_updated = 0
-
-            while True:
-                list_kwargs = {"Bucket": bucket_name, "Prefix": prefix}
-                if continuation_token:
-                    list_kwargs["ContinuationToken"] = continuation_token
-
-                response = s3_client.list_objects_v2(**list_kwargs)
-
-                # If no objects found under this prefix, break out of the loop
-                if "Contents" not in response:
-                    break
-
-                for obj in response["Contents"]:
-                    key = obj["Key"]
-
-                    # Skip if it's a folder
-                    if key.endswith("/"):
-                        continue
-
-                    try:
-                        # Get existing metadata
-                        head_resp = s3_client.head_object(Bucket=bucket_name, Key=key)
-
-                        # Read first ~1KB for MIME detection
-                        partial_obj = s3_client.get_object(
-                            Bucket=bucket_name, Key=key, Range="bytes=0-1023"
-                        )
-                        partial_data = partial_obj["Body"].read()
-
-                        # Detect MIME type
-                        magic_mime_type = mime_detector.from_buffer(partial_data)
-
-                        # Update ContentType
-                        s3_client.copy_object(
-                            Bucket=bucket_name,
-                            CopySource={"Bucket": bucket_name, "Key": key},
-                            Key=key,
-                            ContentType=magic_mime_type,
-                            Metadata=head_resp.get("Metadata", {}),
-                            MetadataDirective="REPLACE",
-                        )
-                        total_updated += 1
-
-                    except Exception as exc:  # noqa
-                        self.stderr.write(
-                            f"[ERROR] Could not update ContentType for {key}: {exc}"
-                        )
-
-                if response.get("IsTruncated"):
-                    continuation_token = response.get("NextContinuationToken")
-                else:
-                    break
-
-            if total_updated > 0:
-                self.stdout.write(
-                    f"[INFO] -> Updated {total_updated} objects for Document {doc_id_str}."
-                )

src/backend/core/migrations/0008_alter_document_link_reach.py

@@ -1,18 +0,0 @@
-# Generated by Django 5.1.2 on 2024-10-25 11:41
-
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0007_fix_users_duplicate'),
-    ]
-
-    operations = [
-        migrations.AlterField(
-            model_name='document',
-            name='link_reach',
-            field=models.CharField(choices=[('restricted', 'Restricted'), ('authenticated', 'Authenticated'), ('public', 'Public')], default='restricted', max_length=20),
-        ),
-    ]

src/backend/core/migrations/0009_add_document_favorite.py

@@ -1,37 +0,0 @@
-# Generated by Django 5.1.2 on 2024-11-08 07:59
-
-import django.db.models.deletion
-import uuid
-from django.conf import settings
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0008_alter_document_link_reach'),
-    ]
-
-    operations = [
-        migrations.AlterField(
-            model_name='user',
-            name='language',
-            field=models.CharField(choices="(('en-us', 'English'), ('fr-fr', 'French'), ('de-de', 'German'))", default='en-us', help_text='The language in which the user wants to see the interface.', max_length=10, verbose_name='language'),
-        ),
-        migrations.CreateModel(
-            name='DocumentFavorite',
-            fields=[
-                ('id', models.UUIDField(default=uuid.uuid4, editable=False, help_text='primary key for the record as UUID', primary_key=True, serialize=False, verbose_name='id')),
-                ('created_at', models.DateTimeField(auto_now_add=True, help_text='date and time at which a record was created', verbose_name='created on')),
-                ('updated_at', models.DateTimeField(auto_now=True, help_text='date and time at which a record was last updated', verbose_name='updated on')),
-                ('document', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='favorited_by_users', to='core.document')),
-                ('user', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='favorite_documents', to=settings.AUTH_USER_MODEL)),
-            ],
-            options={
-                'verbose_name': 'Document favorite',
-                'verbose_name_plural': 'Document favorites',
-                'db_table': 'impress_document_favorite',
-                'constraints': [models.UniqueConstraint(fields=('user', 'document'), name='unique_document_favorite_user', violation_error_message='This document is already targeted by a favorite relation instance for the same user.')],
-            },
-        ),
-    ]

src/backend/core/migrations/0010_add_field_creator_to_document.py

@@ -1,31 +0,0 @@
-# Generated by Django 5.1.2 on 2024-11-09 11:36
-
-import django.core.validators
-import django.db.models.deletion
-from django.conf import settings
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0009_add_document_favorite'),
-    ]
-
-    operations = [
-        migrations.AddField(
-            model_name='document',
-            name='creator',
-            field=models.ForeignKey(null=True, on_delete=django.db.models.deletion.RESTRICT, related_name='documents_created', to=settings.AUTH_USER_MODEL),
-        ),
-        migrations.AlterField(
-            model_name='user',
-            name='language',
-            field=models.CharField(choices="(('en-us', 'English'), ('fr-fr', 'French'), ('de-de', 'German'))", default='en-us', help_text='The language in which the user wants to see the interface.', max_length=10, verbose_name='language'),
-        ),
-        migrations.AlterField(
-            model_name='user',
-            name='sub',
-            field=models.CharField(blank=True, help_text='Required. 255 characters or fewer. Letters, numbers, and @/./+/-/_/: characters only.', max_length=255, null=True, unique=True, validators=[django.core.validators.RegexValidator(message='Enter a valid sub. This value may contain only letters, numbers, and @/./+/-/_/: characters.', regex='^[\\w.@+-:]+\\Z')], verbose_name='sub'),
-        ),
-    ]

src/backend/core/migrations/0011_populate_creator_field_and_make_it_required.py

@@ -1,52 +0,0 @@
-# Generated by Django 5.1.2 on 2024-11-09 11:48
-
-import django.db.models.deletion
-from django.conf import settings
-from django.db import migrations
-from django.db.models import F, ForeignKey, Subquery, OuterRef, Q
-
-
-def set_creator_from_document_access(apps, schema_editor):
-    """
-    Populate the `creator` field for existing Document records.
-
-    This function assigns the `creator` field using the existing
-    DocumentAccess entries. We can be sure that all documents have at
-    least one user with "owner" role. If the document has several roles,
-    it should take the entry with the oldest date of creation.
-
-    The update is performed using efficient bulk queries with Django's
-    Subquery and OuterRef to minimize database hits and ensure performance.
-
-    Note: After running this migration, we quickly modify the schema to make
-    the `creator` field required.
-    """
-    Document = apps.get_model("core", "Document")
-    DocumentAccess = apps.get_model("core", "DocumentAccess")
-
-    # Update `creator` using the "owner" role
-    owner_subquery = DocumentAccess.objects.filter(
-        document=OuterRef('pk'),
-        user__isnull=False,
-        role='owner',
-    ).order_by('created_at').values('user_id')[:1]
-
-    Document.objects.filter(
-        creator__isnull=True
-    ).update(creator=Subquery(owner_subquery))
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0010_add_field_creator_to_document'),
-    ]
-
-    operations = [
-        migrations.RunPython(set_creator_from_document_access, reverse_code=migrations.RunPython.noop),
-        migrations.AlterField(
-            model_name='document',
-            name='creator',
-            field=ForeignKey(on_delete=django.db.models.deletion.RESTRICT, related_name='documents_created', to=settings.AUTH_USER_MODEL),
-        ),
-    ]

src/backend/core/migrations/0012_make_document_creator_and_invitation_issuer_optional.py

@@ -1,30 +0,0 @@
-# Generated by Django 5.1.2 on 2024-11-30 22:23
-
-import django.db.models.deletion
-from django.conf import settings
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0011_populate_creator_field_and_make_it_required'),
-    ]
-
-    operations = [
-        migrations.AlterField(
-            model_name='document',
-            name='creator',
-            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.RESTRICT, related_name='documents_created', to=settings.AUTH_USER_MODEL),
-        ),
-        migrations.AlterField(
-            model_name='invitation',
-            name='issuer',
-            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='invitations', to=settings.AUTH_USER_MODEL),
-        ),
-        migrations.AlterField(
-            model_name='user',
-            name='language',
-            field=models.CharField(choices="(('en-us', 'English'), ('fr-fr', 'French'), ('de-de', 'German'))", default='en-us', help_text='The language in which the user wants to see the interface.', max_length=10, verbose_name='language'),
-        ),
-    ]

src/backend/core/migrations/0013_activate_fuzzystrmatch_extension.py

@@ -1,16 +0,0 @@
-# Generated by Django 5.1.4 on 2025-01-25 08:38
-
-from django.db import migrations
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0012_make_document_creator_and_invitation_issuer_optional'),
-    ]
-
-    operations = [
-        migrations.RunSQL(
-            "CREATE EXTENSION IF NOT EXISTS fuzzystrmatch;",
-            reverse_sql="DROP EXTENSION IF EXISTS fuzzystrmatch;",
-        ),
-    ]

src/backend/core/migrations/0014_add_tree_structure_to_documents.py

@@ -1,31 +0,0 @@
-# Generated by Django 5.1.2 on 2024-12-07 09:43
-
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0013_activate_fuzzystrmatch_extension'),
-    ]
-
-    operations = [
-        migrations.AddField(
-            model_name='document',
-            name='depth',
-            field=models.PositiveIntegerField(default=0),
-            preserve_default=False,
-        ),
-        migrations.AddField(
-            model_name='document',
-            name='numchild',
-            field=models.PositiveIntegerField(default=0),
-        ),
-        migrations.AddField(
-            model_name='document',
-            name='path',
-            # Allow null values pending the next datamigration to populate the field
-            field=models.CharField(db_collation='C', max_length=252, null=True, unique=True),
-            preserve_default=False,
-        ),
-    ]

src/backend/core/migrations/0015_set_path_on_existing_documents.py

@@ -1,52 +0,0 @@
-# Generated by Django 5.1.2 on 2024-12-07 10:33
-
-from django.db import migrations, models
-
-from treebeard.numconv import NumConv
-
-ALPHABET = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"
-STEPLEN = 7
-
-def set_path_on_existing_documents(apps, schema_editor):
-    """
-    Updates the `path` and `depth` fields for all existing Document records 
-    to ensure valid materialized paths.
-
-    This function assigns a unique `path` to each Document as a root node
-
-    Note: After running this migration, we quickly modify the schema to make
-    the `path` field required as it should.
-    """
-    Document = apps.get_model("core", "Document")
-
-    # Iterate over all existing documents and make them root nodes
-    documents = Document.objects.order_by("created_at").values_list("id", flat=True)
-    numconv = NumConv(len(ALPHABET), ALPHABET)
-
-    updates = []
-    for i, pk in enumerate(documents):
-        key = numconv.int2str(i)
-        path = "{0}{1}".format(
-            ALPHABET[0] * (STEPLEN - len(key)),
-            key
-        )
-        updates.append(Document(pk=pk, path=path, depth=1))
-
-    # Bulk update using the prepared updates list
-    Document.objects.bulk_update(updates, ['depth', 'path'])
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0014_add_tree_structure_to_documents'),
-    ]
-
-    operations = [
-        migrations.RunPython(set_path_on_existing_documents, reverse_code=migrations.RunPython.noop),
-        migrations.AlterField(
-            model_name='document',
-            name='path',
-            field=models.CharField(db_collation='C', max_length=252, unique=True),
-        ),
-    ]

src/backend/core/migrations/0016_add_document_excerpt.py

@@ -1,23 +0,0 @@
-# Generated by Django 5.1.4 on 2024-12-18 08:56
-
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0015_set_path_on_existing_documents'),
-    ]
-
-    operations = [
-        migrations.AddField(
-            model_name='document',
-            name='excerpt',
-            field=models.TextField(blank=True, max_length=300, null=True, verbose_name='excerpt'),
-        ),
-        migrations.AlterField(
-            model_name='user',
-            name='language',
-            field=models.CharField(choices="(('en-us', 'English'), ('fr-fr', 'French'), ('de-de', 'German'))", default='en-us', help_text='The language in which the user wants to see the interface.', max_length=10, verbose_name='language'),
-        ),
-    ]

src/backend/core/migrations/0017_add_fields_for_soft_delete.py

@@ -1,36 +0,0 @@
-# Generated by Django 5.1.4 on 2025-01-12 14:27
-
-from django.db import migrations, models
-
-
-class Migration(migrations.Migration):
-
-    dependencies = [
-        ('core', '0016_add_document_excerpt'),
-    ]
-
-    operations = [
-        migrations.AlterModelOptions(
-            name='document',
-            options={'ordering': ('path',), 'verbose_name': 'Document', 'verbose_name_plural': 'Documents'},
-        ),
-        migrations.AddField(
-            model_name='document',
-            name='ancestors_deleted_at',
-            field=models.DateTimeField(blank=True, null=True),
-        ),
-        migrations.AddField(
-            model_name='document',
-            name='deleted_at',
-            field=models.DateTimeField(blank=True, null=True),
-        ),
-        migrations.AlterField(
-            model_name='user',
-            name='language',
-            field=models.CharField(choices="(('en-us', 'English'), ('fr-fr', 'French'), ('de-de', 'German'))", default='en-us', help_text='The language in which the user wants to see the interface.', max_length=10, verbose_name='language'),
-        ),
-        migrations.AddConstraint(
-            model_name='document',
-            constraint=models.CheckConstraint(condition=models.Q(('deleted_at__isnull', True), ('deleted_at', models.F('ancestors_deleted_at')), _connector='OR'), name='check_deleted_at_matches_ancestors_deleted_at_when_set'),
-        ),
-    ]

src/backend/core/models.py

@@ -1,51 +1,59 @@
 """
 Declare and configure the models for the impress core application
 """
-# pylint: disable=too-many-lines
 
 import hashlib
 import smtplib
+import tempfile
+import textwrap
 import uuid
 from datetime import timedelta
+from io import BytesIO
 from logging import getLogger
 
 from django.conf import settings
 from django.contrib.auth import models as auth_models
 from django.contrib.auth.base_user import AbstractBaseUser
 from django.contrib.sites.models import Site
-from django.core import mail, validators
-from django.core.cache import cache
+from django.core import exceptions, mail, validators
 from django.core.files.base import ContentFile
 from django.core.files.storage import default_storage
 from django.core.mail import send_mail
-from django.db import models, transaction
-from django.db.models.functions import Left, Length
+from django.db import models
+from django.http import FileResponse
+from django.template.base import Template as DjangoTemplate
+from django.template.context import Context
 from django.template.loader import render_to_string
-from django.utils import timezone
+from django.utils import html, timezone
 from django.utils.functional import cached_property, lazy
-from django.utils.translation import get_language, override
 from django.utils.translation import gettext_lazy as _
+from django.utils.translation import override
 
+import frontmatter
+import markdown
+import pypandoc
+import weasyprint
 from botocore.exceptions import ClientError
-from rest_framework.exceptions import ValidationError
 from timezone_field import TimeZoneField
-from treebeard.mp_tree import MP_Node
 
 logger = getLogger(__name__)
 
 
-def get_trashbin_cutoff():
-    """
-    Calculate the cutoff datetime for soft-deleted items based on the retention policy.
+def get_resource_roles(resource, user):
+    """Compute the roles a user has on a resource."""
+    if not user.is_authenticated:
+        return []
 
-    The function returns the current datetime minus the number of days specified in
-    the TRASHBIN_CUTOFF_DAYS setting, indicating the oldest date for items that can
-    remain in the trash bin.
-
-    Returns:
-        datetime: The cutoff datetime for soft-deleted items.
-    """
-    return timezone.now() - timedelta(days=settings.TRASHBIN_CUTOFF_DAYS)
+    try:
+        roles = resource.user_roles or []
+    except AttributeError:
+        try:
+            roles = resource.accesses.filter(
+                models.Q(user=user) | models.Q(team__in=user.teams),
+            ).values_list("role", flat=True)
+        except (models.ObjectDoesNotExist, IndexError):
+            roles = []
+    return roles
 
 
 class LinkRoleChoices(models.TextChoices):
@@ -81,16 +89,6 @@ class LinkReachChoices(models.TextChoices):
     PUBLIC = "public", _("Public")  # Even anonymous users can access the document
 
 
-class DuplicateEmailError(Exception):
-    """Raised when an email is already associated with a pre-existing user."""
-
-    def __init__(self, message=None, email=None):
-        """Set message and email to describe the exception."""
-        self.message = message
-        self.email = email
-        super().__init__(self.message)
-
-
 class BaseModel(models.Model):
     """
     Serves as an abstract base model for other models, ensuring that records are validated
@@ -128,50 +126,21 @@ class BaseModel(models.Model):
         super().save(*args, **kwargs)
 
 
-class UserManager(auth_models.UserManager):
-    """Custom manager for User model with additional methods."""
-
-    def get_user_by_sub_or_email(self, sub, email):
-        """Fetch existing user by sub or email."""
-        try:
-            return self.get(sub=sub)
-        except self.model.DoesNotExist as err:
-            if not email:
-                return None
-
-            if settings.OIDC_FALLBACK_TO_EMAIL_FOR_IDENTIFICATION:
-                try:
-                    return self.get(email=email)
-                except self.model.DoesNotExist:
-                    pass
-            elif (
-                self.filter(email=email).exists()
-                and not settings.OIDC_ALLOW_DUPLICATE_EMAILS
-            ):
-                raise DuplicateEmailError(
-                    _(
-                        "We couldn't find a user with this sub but the email is already "
-                        "associated with a registered user."
-                    )
-                ) from err
-        return None
-
-
 class User(AbstractBaseUser, BaseModel, auth_models.PermissionsMixin):
     """User model to work with OIDC only authentication."""
 
     sub_validator = validators.RegexValidator(
-        regex=r"^[\w.@+-:]+\Z",
+        regex=r"^[\w.@+-]+\Z",
         message=_(
             "Enter a valid sub. This value may contain only letters, "
-            "numbers, and @/./+/-/_/: characters."
+            "numbers, and @/./+/-/_ characters."
         ),
     )
 
     sub = models.CharField(
         _("sub"),
         help_text=_(
-            "Required. 255 characters or fewer. Letters, numbers, and @/./+/-/_/: characters only."
+            "Required. 255 characters or fewer. Letters, numbers, and @/./+/-/_ characters only."
         ),
         max_length=255,
         unique=True,
@@ -223,7 +192,7 @@ class User(AbstractBaseUser, BaseModel, auth_models.PermissionsMixin):
         ),
     )
 
-    objects = UserManager()
+    objects = auth_models.UserManager()
 
     USERNAME_FIELD = "admin_email"
     REQUIRED_FIELDS = []
@@ -270,13 +239,6 @@ class User(AbstractBaseUser, BaseModel, auth_models.PermissionsMixin):
                 for invitation in valid_invitations
             ]
         )
-
-        # Set creator of documents if not yet set (e.g. documents created via server-to-server API)
-        document_ids = [invitation.document_id for invitation in valid_invitations]
-        Document.objects.filter(id__in=document_ids, creator__isnull=True).update(
-            creator=self
-        )
-
         valid_invitations.delete()
 
     def email_user(self, subject, message, from_email=None, **kwargs):
@@ -367,52 +329,26 @@ class BaseAccess(BaseModel):
         }
 
 
-class Document(MP_Node, BaseModel):
+class Document(BaseModel):
     """Pad document carrying the content."""
 
     title = models.CharField(_("title"), max_length=255, null=True, blank=True)
-    excerpt = models.TextField(_("excerpt"), max_length=300, null=True, blank=True)
     link_reach = models.CharField(
         max_length=20,
         choices=LinkReachChoices.choices,
-        default=LinkReachChoices.RESTRICTED,
+        default=LinkReachChoices.AUTHENTICATED,
     )
     link_role = models.CharField(
         max_length=20, choices=LinkRoleChoices.choices, default=LinkRoleChoices.READER
     )
-    creator = models.ForeignKey(
-        User,
-        on_delete=models.RESTRICT,
-        related_name="documents_created",
-        blank=True,
-        null=True,
-    )
-    deleted_at = models.DateTimeField(null=True, blank=True)
-    ancestors_deleted_at = models.DateTimeField(null=True, blank=True)
 
     _content = None
 
-    # Tree structure
-    alphabet = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"
-    steplen = 7  # nb siblings max: 3,521,614,606,208
-    node_order_by = []  # Manual ordering
-
-    path = models.CharField(max_length=7 * 36, unique=True, db_collation="C")
-
     class Meta:
         db_table = "impress_document"
-        ordering = ("path",)
+        ordering = ("title",)
         verbose_name = _("Document")
         verbose_name_plural = _("Documents")
-        constraints = [
-            models.CheckConstraint(
-                check=(
-                    models.Q(deleted_at__isnull=True)
-                    | models.Q(deleted_at=models.F("ancestors_deleted_at"))
-                ),
-                name="check_deleted_at_matches_ancestors_deleted_at_when_set",
-            ),
-        ]
 
     def __str__(self):
         return str(self.title) if self.title else str(_("Untitled Document"))
@@ -551,254 +487,83 @@ class Document(MP_Node, BaseModel):
             Bucket=default_storage.bucket_name, Key=self.file_key, VersionId=version_id
         )
 
-    def get_nb_accesses_cache_key(self):
-        """Generate a unique cache key for each document."""
-        return f"document_{self.id!s}_nb_accesses"
-
-    @property
-    def nb_accesses(self):
-        """Calculate the number of accesses."""
-        cache_key = self.get_nb_accesses_cache_key()
-        nb_accesses = cache.get(cache_key)
-
-        if nb_accesses is None:
-            nb_accesses = DocumentAccess.objects.filter(
-                document__path=Left(models.Value(self.path), Length("document__path")),
-            ).count()
-            cache.set(cache_key, nb_accesses)
-
-        return nb_accesses
-
-    def invalidate_nb_accesses_cache(self):
-        """
-        Invalidate the cache for number of accesses, including on affected descendants.
-        """
-        for document in Document.objects.filter(path__startswith=self.path).only("id"):
-            cache_key = document.get_nb_accesses_cache_key()
-            cache.delete(cache_key)
-
-    def get_roles(self, user):
-        """Return the roles a user has on a document."""
-        if not user.is_authenticated:
-            return []
-
-        try:
-            roles = self.user_roles or []
-        except AttributeError:
-            try:
-                roles = DocumentAccess.objects.filter(
-                    models.Q(user=user) | models.Q(team__in=user.teams),
-                    document__path=Left(
-                        models.Value(self.path), Length("document__path")
-                    ),
-                ).values_list("role", flat=True)
-            except (models.ObjectDoesNotExist, IndexError):
-                roles = []
-        return roles
-
-    @cached_property
-    def links_definitions(self):
-        """Get links reach/role definitions for the current document and its ancestors."""
-        links_definitions = {self.link_reach: {self.link_role}}
-
-        # Ancestors links definitions are only interesting if the document is not the highest
-        # ancestor to which the current user has access. Look for the annotation:
-        if self.depth > 1 and not getattr(self, "is_highest_ancestor_for_user", False):
-            for ancestor in self.get_ancestors().values("link_reach", "link_role"):
-                links_definitions.setdefault(ancestor["link_reach"], set()).add(
-                    ancestor["link_role"]
-                )
-
-        return links_definitions
-
     def get_abilities(self, user):
         """
         Compute and return abilities for a given user on the document.
         """
-        roles = set(
-            self.get_roles(user)
-        )  # at this point only roles based on specific access
+        roles = set(get_resource_roles(self, user))
 
-        # Characteristics that are based only on specific access
-        is_owner = RoleChoices.OWNER in roles
-        is_deleted = self.ancestors_deleted_at and not is_owner
-        is_owner_or_admin = (is_owner or RoleChoices.ADMIN in roles) and not is_deleted
-
-        # Compute access roles before adding link roles because we don't
+        # Compute version roles before adding link roles because we don't
         # want anonymous users to access versions (we wouldn't know from
         # which date to allow them anyway)
-        # Anonymous users should also not see document accesses
-        has_access_role = bool(roles) and not is_deleted
+        can_get_versions = bool(roles)
 
-        # Add roles provided by the document link, taking into account its ancestors
+        # Add role provided by the document link
+        if self.link_reach == LinkReachChoices.PUBLIC or (
+            self.link_reach == LinkReachChoices.AUTHENTICATED and user.is_authenticated
+        ):
+            roles.add(self.link_role)
 
-        # Add roles provided by the document link
-        links_definitions = self.links_definitions
-        public_roles = links_definitions.get(LinkReachChoices.PUBLIC, set())
-        authenticated_roles = (
-            links_definitions.get(LinkReachChoices.AUTHENTICATED, set())
-            if user.is_authenticated
-            else set()
+        is_owner_or_admin = bool(
+            roles.intersection({RoleChoices.OWNER, RoleChoices.ADMIN})
         )
-        roles = roles | public_roles | authenticated_roles
-
-        can_get = bool(roles) and not is_deleted
-        can_update = (
-            is_owner_or_admin or RoleChoices.EDITOR in roles
-        ) and not is_deleted
+        is_editor = bool(RoleChoices.EDITOR in roles)
+        can_get = bool(roles)
 
         return {
-            "accesses_manage": is_owner_or_admin,
-            "accesses_view": has_access_role,
-            "ai_transform": can_update,
-            "ai_translate": can_update,
-            "attachment_upload": can_update,
-            "children_list": can_get,
-            "children_create": can_update and user.is_authenticated,
-            "collaboration_auth": can_get,
-            "destroy": is_owner,
-            "favorite": can_get and user.is_authenticated,
+            "ai_transform": is_owner_or_admin or is_editor,
+            "ai_translate": is_owner_or_admin or is_editor,
+            "attachment_upload": is_owner_or_admin or is_editor,
+            "destroy": RoleChoices.OWNER in roles,
             "link_configuration": is_owner_or_admin,
-            "invite_owner": is_owner,
-            "move": is_owner_or_admin and not self.ancestors_deleted_at,
-            "partial_update": can_update,
-            "restore": is_owner,
+            "manage_accesses": is_owner_or_admin,
+            "invite_owner": RoleChoices.OWNER in roles,
+            "partial_update": is_owner_or_admin or is_editor,
             "retrieve": can_get,
-            "media_auth": can_get,
-            "update": can_update,
+            "update": is_owner_or_admin or is_editor,
             "versions_destroy": is_owner_or_admin,
-            "versions_list": has_access_role,
-            "versions_retrieve": has_access_role,
+            "versions_list": can_get_versions,
+            "versions_retrieve": can_get_versions,
         }
 
-    def send_email(self, subject, emails, context=None, language=None):
-        """Generate and send email from a template."""
-        context = context or {}
+    def email_invitation(self, language, email, role, sender):
+        """Send email invitation."""
+
+        sender_name = sender.full_name or sender.email
         domain = Site.objects.get_current().domain
-        language = language or get_language()
-        context.update(
-            {
-                "brandname": settings.EMAIL_BRAND_NAME,
-                "document": self,
-                "domain": domain,
-                "link": f"{domain}/docs/{self.id}/",
-                "logo_img": settings.EMAIL_LOGO_IMG,
-            }
-        )
 
-        with override(language):
-            msg_html = render_to_string("mail/html/invitation.html", context)
-            msg_plain = render_to_string("mail/text/invitation.txt", context)
-            subject = str(subject)  # Force translation
-
-            try:
+        try:
+            with override(language):
+                title = _(
+                    "%(sender_name)s shared a document with you: %(document)s"
+                ) % {
+                    "sender_name": sender_name,
+                    "document": self.title,
+                }
+                template_vars = {
+                    "title": title,
+                    "domain": domain,
+                    "document": self,
+                    "link": f"{domain}/docs/{self.id}/",
+                    "sender_name": sender_name,
+                    "sender_name_email": f"{sender.full_name} ({sender.email})"
+                    if sender.full_name
+                    else sender.email,
+                    "role": RoleChoices(role).label.lower(),
+                }
+                msg_html = render_to_string("mail/html/invitation.html", template_vars)
+                msg_plain = render_to_string("mail/text/invitation.txt", template_vars)
                 send_mail(
-                    subject.capitalize(),
+                    title,
                     msg_plain,
                     settings.EMAIL_FROM,
-                    emails,
+                    [email],
                     html_message=msg_html,
                     fail_silently=False,
                 )
-            except smtplib.SMTPException as exception:
-                logger.error("invitation to %s was not sent: %s", emails, exception)
 
-    def send_invitation_email(self, email, role, sender, language=None):
-        """Method allowing a user to send an email invitation to another user for a document."""
-        language = language or get_language()
-        role = RoleChoices(role).label
-        sender_name = sender.full_name or sender.email
-        sender_name_email = (
-            f"{sender.full_name:s} ({sender.email})"
-            if sender.full_name
-            else sender.email
-        )
-
-        with override(language):
-            context = {
-                "title": _("{name} shared a document with you!").format(
-                    name=sender_name
-                ),
-                "message": _(
-                    '{name} invited you with the role "{role}" on the following document:'
-                ).format(name=sender_name_email, role=role.lower()),
-            }
-            subject = _("{name} shared a document with you: {title}").format(
-                name=sender_name, title=self.title
-            )
-
-        self.send_email(subject, [email], context, language)
-
-    @transaction.atomic
-    def soft_delete(self):
-        """
-        Soft delete the document, marking the deletion on descendants.
-        We still keep the .delete() method untouched for programmatic purposes.
-        """
-        if self.deleted_at or self.ancestors_deleted_at:
-            raise RuntimeError(
-                "This document is already deleted or has deleted ancestors."
-            )
-
-        # Check if any ancestors are deleted
-        if self.get_ancestors().filter(deleted_at__isnull=False).exists():
-            raise RuntimeError(
-                "Cannot delete this document because one or more ancestors are already deleted."
-            )
-
-        self.ancestors_deleted_at = self.deleted_at = timezone.now()
-        self.save()
-
-        # Mark all descendants as soft deleted
-        self.get_descendants().filter(ancestors_deleted_at__isnull=True).update(
-            ancestors_deleted_at=self.ancestors_deleted_at
-        )
-
-    @transaction.atomic
-    def restore(self):
-        """Cancelling a soft delete with checks."""
-        # This should not happen
-        if self.deleted_at is None:
-            raise ValidationError({"deleted_at": [_("This document is not deleted.")]})
-
-        if self.deleted_at < get_trashbin_cutoff():
-            raise ValidationError(
-                {
-                    "deleted_at": [
-                        _(
-                            "This document was permanently deleted and cannot be restored."
-                        )
-                    ]
-                }
-            )
-
-        # Restore the current document
-        self.deleted_at = None
-
-        # Calculate the minimum `deleted_at` among all ancestors
-        ancestors_deleted_at = (
-            self.get_ancestors()
-            .filter(deleted_at__isnull=False)
-            .values_list("deleted_at", flat=True)
-        )
-        self.ancestors_deleted_at = min(ancestors_deleted_at, default=None)
-        self.save()
-
-        # Update descendants excluding those who were deleted prior to the deletion of the
-        # current document (the ancestor_deleted_at date for those should already by good)
-        # The number of deleted descendants should not be too big so we can handcraft a union
-        # clause for them:
-        deleted_descendants_paths = (
-            self.get_descendants()
-            .filter(deleted_at__isnull=False)
-            .values_list("path", flat=True)
-        )
-        exclude_condition = models.Q(
-            *(models.Q(path__startswith=path) for path in deleted_descendants_paths)
-        )
-        self.get_descendants().exclude(exclude_condition).update(
-            ancestors_deleted_at=self.ancestors_deleted_at
-        )
+        except smtplib.SMTPException as exception:
+            logger.error("invitation to %s was not sent: %s", email, exception)
 
 
 class LinkTrace(BaseModel):
@@ -833,37 +598,6 @@ class LinkTrace(BaseModel):
         return f"{self.user!s} trace on document {self.document!s}"
 
 
-class DocumentFavorite(BaseModel):
-    """Relation model to store a user's favorite documents."""
-
-    document = models.ForeignKey(
-        Document,
-        on_delete=models.CASCADE,
-        related_name="favorited_by_users",
-    )
-    user = models.ForeignKey(
-        User, on_delete=models.CASCADE, related_name="favorite_documents"
-    )
-
-    class Meta:
-        db_table = "impress_document_favorite"
-        verbose_name = _("Document favorite")
-        verbose_name_plural = _("Document favorites")
-        constraints = [
-            models.UniqueConstraint(
-                fields=["user", "document"],
-                name="unique_document_favorite_user",
-                violation_error_message=_(
-                    "This document is already targeted by a favorite relation instance "
-                    "for the same user."
-                ),
-            ),
-        ]
-
-    def __str__(self):
-        return f"{self.user!s} favorite on document {self.document!s}"
-
-
 class DocumentAccess(BaseAccess):
     """Relation model to give access to a document for a user or a team with a role."""
 
@@ -902,16 +636,6 @@ class DocumentAccess(BaseAccess):
     def __str__(self):
         return f"{self.user!s} is {self.role:s} in document {self.document!s}"
 
-    def save(self, *args, **kwargs):
-        """Override save to clear the document's cache for number of accesses."""
-        super().save(*args, **kwargs)
-        self.document.invalidate_nb_accesses_cache()
-
-    def delete(self, *args, **kwargs):
-        """Override delete to clear the document's cache for number of accesses."""
-        super().delete(*args, **kwargs)
-        self.document.invalidate_nb_accesses_cache()
-
     def get_abilities(self, user):
         """
         Compute and return abilities for a given user on the document access.
@@ -941,42 +665,127 @@ class Template(BaseModel):
     def __str__(self):
         return self.title
 
-    def get_roles(self, user):
-        """Return the roles a user has on a resource as an iterable."""
-        if not user.is_authenticated:
-            return []
-
-        try:
-            roles = self.user_roles or []
-        except AttributeError:
-            try:
-                roles = self.accesses.filter(
-                    models.Q(user=user) | models.Q(team__in=user.teams),
-                ).values_list("role", flat=True)
-            except (models.ObjectDoesNotExist, IndexError):
-                roles = []
-        return roles
-
     def get_abilities(self, user):
         """
         Compute and return abilities for a given user on the template.
         """
-        roles = self.get_roles(user)
+        roles = get_resource_roles(self, user)
         is_owner_or_admin = bool(
             set(roles).intersection({RoleChoices.OWNER, RoleChoices.ADMIN})
         )
+        is_editor = bool(RoleChoices.EDITOR in roles)
         can_get = self.is_public or bool(roles)
-        can_update = is_owner_or_admin or RoleChoices.EDITOR in roles
 
         return {
             "destroy": RoleChoices.OWNER in roles,
             "generate_document": can_get,
-            "accesses_manage": is_owner_or_admin,
-            "update": can_update,
-            "partial_update": can_update,
+            "manage_accesses": is_owner_or_admin,
+            "update": is_owner_or_admin or is_editor,
+            "partial_update": is_owner_or_admin or is_editor,
             "retrieve": can_get,
         }
 
+    def generate_pdf(self, body_html, metadata):
+        """
+        Generate and return a pdf document wrapped around the current template
+        """
+        document_html = weasyprint.HTML(
+            string=DjangoTemplate(self.code).render(
+                Context({"body": html.format_html(body_html), **metadata})
+            )
+        )
+        css = weasyprint.CSS(
+            string=self.css,
+            font_config=weasyprint.text.fonts.FontConfiguration(),
+        )
+
+        pdf_content = document_html.write_pdf(stylesheets=[css], zoom=1)
+        response = FileResponse(BytesIO(pdf_content), content_type="application/pdf")
+        response["Content-Disposition"] = f"attachment; filename={self.title}.pdf"
+
+        return response
+
+    def generate_word(self, body_html, metadata):
+        """
+        Generate and return a docx document wrapped around the current template
+        """
+        template_string = DjangoTemplate(self.code).render(
+            Context({"body": html.format_html(body_html), **metadata})
+        )
+
+        html_string = f"""
+        <!DOCTYPE html>
+        <html>
+        <head>
+            <style>
+                {self.css}
+            </style>
+        </head>
+        <body>
+            {template_string}
+        </body>
+        </html>
+        """
+
+        reference_docx = "core/static/reference.docx"
+        output = BytesIO()
+
+        # Convert the HTML to a temporary docx file
+        with tempfile.NamedTemporaryFile(suffix=".docx", prefix="docx_") as tmp_file:
+            output_path = tmp_file.name
+
+            pypandoc.convert_text(
+                html_string,
+                "docx",
+                format="html",
+                outputfile=output_path,
+                extra_args=["--reference-doc", reference_docx],
+            )
+
+            # Create a BytesIO object to store the output of the temporary docx file
+            with open(output_path, "rb") as f:
+                output = BytesIO(f.read())
+
+        # Ensure the pointer is at the beginning
+        output.seek(0)
+
+        response = FileResponse(
+            output,
+            content_type="application/vnd.openxmlformats-officedocument.wordprocessingml.document",
+        )
+        response["Content-Disposition"] = f"attachment; filename={self.title}.docx"
+
+        return response
+
+    def generate_document(self, body, body_type, export_format):
+        """
+        Generate and return a document for this template around the
+        body passed as argument.
+
+        2 types of body are accepted:
+        - HTML: body_type = "html"
+        - Markdown: body_type = "markdown"
+
+        2 types of documents can be generated:
+        - PDF: export_format = "pdf"
+        - Docx: export_format = "docx"
+        """
+        document = frontmatter.loads(body)
+        metadata = document.metadata
+        strip_body = document.content.strip()
+
+        if body_type == "html":
+            body_html = strip_body
+        else:
+            body_html = (
+                markdown.markdown(textwrap.dedent(strip_body)) if strip_body else ""
+            )
+
+        if export_format == "pdf":
+            return self.generate_pdf(body_html, metadata)
+
+        return self.generate_word(body_html, metadata)
+
 
 class TemplateAccess(BaseAccess):
     """Relation model to give access to a template for a user or a team with a role."""
@@ -1039,8 +848,6 @@ class Invitation(BaseModel):
         User,
         on_delete=models.CASCADE,
         related_name="invitations",
-        blank=True,
-        null=True,
     )
 
     class Meta:
@@ -1061,12 +868,9 @@ class Invitation(BaseModel):
         super().clean()
 
         # Check if an identity already exists for the provided email
-        if (
-            User.objects.filter(email=self.email).exists()
-            and not settings.OIDC_ALLOW_DUPLICATE_EMAILS
-        ):
-            raise ValidationError(
-                {"email": [_("This email is already associated to a registered user.")]}
+        if User.objects.filter(email=self.email).exists():
+            raise exceptions.ValidationError(
+                {"email": _("This email is already associated to a registered user.")}
             )
 
     @property

src/backend/core/services/ai_services.py

@@ -67,19 +67,10 @@ class AIService:
         )
 
         content = response.choices[0].message.content
+        sanitized_content = re.sub(r"(?<!\\)\n", "\\\\n", content)
+        sanitized_content = re.sub(r"(?<!\\)\t", "\\\\t", sanitized_content)
 
-        try:
-            sanitized_content = re.sub(r'\s*"answer"\s*:\s*', '"answer": ', content)
-            sanitized_content = re.sub(r"\s*\}", "}", sanitized_content)
-            sanitized_content = re.sub(r"(?<!\\)\n", "\\\\n", sanitized_content)
-            sanitized_content = re.sub(r"(?<!\\)\t", "\\\\t", sanitized_content)
-
-            json_response = json.loads(sanitized_content)
-        except (json.JSONDecodeError, IndexError):
-            try:
-                json_response = json.loads(content)
-            except json.JSONDecodeError as err:
-                raise RuntimeError("AI response is not valid JSON", content) from err
+        json_response = json.loads(sanitized_content)
 
         if "answer" not in json_response:
             raise RuntimeError("AI response does not contain an answer")

src/backend/core/services/collaboration_services.py

@@ -1,43 +0,0 @@
-"""Collaboration services."""
-
-from django.conf import settings
-from django.core.exceptions import ImproperlyConfigured
-
-import requests
-
-
-class CollaborationService:
-    """Service class for Collaboration related operations."""
-
-    def __init__(self):
-        """Ensure that the collaboration configuration is set properly."""
-        if settings.COLLABORATION_API_URL is None:
-            raise ImproperlyConfigured("Collaboration configuration not set")
-
-    def reset_connections(self, room, user_id=None):
-        """
-        Reset connections of a room in the collaboration server.
-        Reseting a connection means that the user will be disconnected and will
-        have to reconnect to the collaboration server, with updated rights.
-        """
-        endpoint = "reset-connections"
-
-        # room is necessary as a parameter, it is easier to stick to the
-        # same pod thanks to a parameter
-        endpoint_url = f"{settings.COLLABORATION_API_URL}{endpoint}/?room={room}"
-
-        # Note: Collaboration microservice accepts only raw token, which is not recommended
-        headers = {"Authorization": settings.COLLABORATION_SERVER_SECRET}
-        if user_id:
-            headers["X-User-Id"] = user_id
-
-        try:
-            response = requests.post(endpoint_url, headers=headers, timeout=10)
-        except requests.RequestException as e:
-            raise requests.HTTPError("Failed to notify WebSocket server.") from e
-
-        if response.status_code != 200:
-            raise requests.HTTPError(
-                f"Failed to notify WebSocket server. Status code: {response.status_code}, "
-                f"Response: {response.text}"
-            )

src/backend/core/services/converter_services.py

@@ -1,78 +0,0 @@
-"""Converter services."""
-
-from django.conf import settings
-
-import requests
-
-
-class ConversionError(Exception):
-    """Base exception for conversion-related errors."""
-
-
-class ValidationError(ConversionError):
-    """Raised when the input validation fails."""
-
-
-class ServiceUnavailableError(ConversionError):
-    """Raised when the conversion service is unavailable."""
-
-
-class InvalidResponseError(ConversionError):
-    """Raised when the conversion service returns an invalid response."""
-
-
-class MissingContentError(ConversionError):
-    """Raised when the response is missing required content."""
-
-
-class YdocConverter:
-    """Service class for conversion-related operations."""
-
-    @property
-    def auth_header(self):
-        """Build microservice authentication header."""
-        # Note: Yprovider microservice accepts only raw token, which is not recommended
-        return settings.Y_PROVIDER_API_KEY
-
-    def convert_markdown(self, text):
-        """Convert a Markdown text into our internal format using an external microservice."""
-
-        if not text:
-            raise ValidationError("Input text cannot be empty")
-
-        try:
-            response = requests.post(
-                f"{settings.Y_PROVIDER_API_BASE_URL}{settings.CONVERSION_API_ENDPOINT}/",
-                json={
-                    "content": text,
-                },
-                headers={
-                    "Authorization": self.auth_header,
-                    "Content-Type": "application/json",
-                },
-                timeout=settings.CONVERSION_API_TIMEOUT,
-                verify=settings.CONVERSION_API_SECURE,
-            )
-            response.raise_for_status()
-            conversion_response = response.json()
-
-        except requests.RequestException as err:
-            raise ServiceUnavailableError(
-                "Failed to connect to conversion service",
-            ) from err
-
-        except ValueError as err:
-            raise InvalidResponseError(
-                "Could not parse conversion service response"
-            ) from err
-
-        try:
-            document_content = conversion_response[
-                settings.CONVERSION_API_CONTENT_FIELD
-            ]
-        except KeyError as err:
-            raise MissingContentError(
-                f"Response missing required field: {settings.CONVERSION_API_CONTENT_FIELD}"
-            ) from err
-
-        return document_content

src/backend/core/tests/authentication/test_backends.py

@@ -1,9 +1,6 @@
 """Unit tests for the Authentication Backends."""
 
-import random
 import re
-from logging import Logger
-from unittest import mock
 
 from django.core.exceptions import SuspiciousOperation
 from django.test.utils import override_settings
@@ -65,33 +62,7 @@ def test_authentication_getter_existing_user_via_email(
     assert user == db_user
 
 
-def test_authentication_getter_email_none(monkeypatch):
-    """
-    If no user is found with the sub and no email is provided, a new user should be created.
-    """
-
-    klass = OIDCAuthenticationBackend()
-    db_user = UserFactory(email=None)
-
-    def get_userinfo_mocked(*args):
-        user_info = {"sub": "123"}
-        if random.choice([True, False]):
-            user_info["email"] = None
-        return user_info
-
-    monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
-
-    user = klass.get_or_create_user(
-        access_token="test-token", id_token=None, payload=None
-    )
-
-    # Since the sub and email didn't match, it should create a new user
-    assert models.User.objects.count() == 2
-    assert user != db_user
-    assert user.sub == "123"
-
-
-def test_authentication_getter_existing_user_no_fallback_to_email_allow_duplicate(
+def test_authentication_getter_existing_user_no_fallback_to_email(
     settings, monkeypatch
 ):
     """
@@ -104,7 +75,6 @@ def test_authentication_getter_existing_user_no_fallback_to_email_allow_duplicat
 
     # Set the setting to False
     settings.OIDC_FALLBACK_TO_EMAIL_FOR_IDENTIFICATION = False
-    settings.OIDC_ALLOW_DUPLICATE_EMAILS = True
 
     def get_userinfo_mocked(*args):
         return {"sub": "123", "email": db_user.email}
@@ -121,39 +91,6 @@ def test_authentication_getter_existing_user_no_fallback_to_email_allow_duplicat
     assert user.sub == "123"
 
 
-def test_authentication_getter_existing_user_no_fallback_to_email_no_duplicate(
-    settings, monkeypatch
-):
-    """
-    When the "OIDC_FALLBACK_TO_EMAIL_FOR_IDENTIFICATION" setting is set to False,
-    the system should not match users by email, even if the email matches.
-    """
-
-    klass = OIDCAuthenticationBackend()
-    db_user = UserFactory()
-
-    # Set the setting to False
-    settings.OIDC_FALLBACK_TO_EMAIL_FOR_IDENTIFICATION = False
-    settings.OIDC_ALLOW_DUPLICATE_EMAILS = False
-
-    def get_userinfo_mocked(*args):
-        return {"sub": "123", "email": db_user.email}
-
-    monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
-
-    with pytest.raises(
-        SuspiciousOperation,
-        match=(
-            "We couldn't find a user with this sub but the email is already associated "
-            "with a registered user."
-        ),
-    ):
-        klass.get_or_create_user(access_token="test-token", id_token=None, payload=None)
-
-    # Since the sub doesn't match, it should not create a new user
-    assert models.User.objects.count() == 1
-
-
 def test_authentication_getter_existing_user_with_email(
     django_assert_num_queries, monkeypatch
 ):
@@ -191,12 +128,11 @@ def test_authentication_getter_existing_user_with_email(
         ("Jack", "Duy", "jack.duy@example.com"),
     ],
 )
-def test_authentication_getter_existing_user_change_fields_sub(
+def test_authentication_getter_existing_user_change_fields(
     first_name, last_name, email, django_assert_num_queries, monkeypatch
 ):
     """
-    It should update the email or name fields on the user when they change
-    and the user was identified by its "sub".
+    It should update the email or name fields on the user when they change.
     """
     klass = OIDCAuthenticationBackend()
     user = UserFactory(
@@ -226,48 +162,6 @@ def test_authentication_getter_existing_user_change_fields_sub(
     assert user.short_name == first_name
 
 
-@pytest.mark.parametrize(
-    "first_name, last_name, email",
-    [
-        ("Jack", "Doe", "john.doe@example.com"),
-        ("John", "Duy", "john.doe@example.com"),
-    ],
-)
-def test_authentication_getter_existing_user_change_fields_email(
-    first_name, last_name, email, django_assert_num_queries, monkeypatch
-):
-    """
-    It should update the name fields on the user when they change
-    and the user was identified by its "email" as fallback.
-    """
-    klass = OIDCAuthenticationBackend()
-    user = UserFactory(
-        full_name="John Doe", short_name="John", email="john.doe@example.com"
-    )
-
-    def get_userinfo_mocked(*args):
-        return {
-            "sub": "123",
-            "email": user.email,
-            "first_name": first_name,
-            "last_name": last_name,
-        }
-
-    monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
-
-    # One and only one additional update query when a field has changed
-    with django_assert_num_queries(3):
-        authenticated_user = klass.get_or_create_user(
-            access_token="test-token", id_token=None, payload=None
-        )
-
-    assert user == authenticated_user
-    user.refresh_from_db()
-    assert user.email == email
-    assert user.full_name == f"{first_name:s} {last_name:s}"
-    assert user.short_name == first_name
-
-
 def test_authentication_getter_new_user_no_email(monkeypatch):
     """
     If no user matches the user's info sub, a user should be created.
@@ -319,6 +213,29 @@ def test_authentication_getter_new_user_with_email(monkeypatch):
     assert models.User.objects.count() == 1
 
 
+def test_authentication_getter_invalid_token(django_assert_num_queries, monkeypatch):
+    """The user's info doesn't contain a sub."""
+    klass = OIDCAuthenticationBackend()
+
+    def get_userinfo_mocked(*args):
+        return {
+            "test": "123",
+        }
+
+    monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
+
+    with (
+        django_assert_num_queries(0),
+        pytest.raises(
+            SuspiciousOperation,
+            match="User info contained no recognizable user identification",
+        ),
+    ):
+        klass.get_or_create_user(access_token="test-token", id_token=None, payload=None)
+
+    assert models.User.objects.exists() is False
+
+
 @override_settings(OIDC_OP_USER_ENDPOINT="http://oidc.endpoint.test/userinfo")
 @responses.activate
 def test_authentication_get_userinfo_json_response():
@@ -424,7 +341,7 @@ def test_authentication_getter_existing_disabled_user_via_email(
     django_assert_num_queries, monkeypatch
 ):
     """
-    If an existing user does not match the sub but matches the email and is disabled,
+    If an existing user does not matches the sub but matches the email and is disabled,
     an error should be raised and a user should not be created.
     """
 
@@ -448,102 +365,3 @@ def test_authentication_getter_existing_disabled_user_via_email(
         klass.get_or_create_user(access_token="test-token", id_token=None, payload=None)
 
     assert models.User.objects.count() == 1
-
-
-# Essential claims
-
-
-def test_authentication_verify_claims_default(django_assert_num_queries, monkeypatch):
-    """The sub claim should be mandatory by default."""
-    klass = OIDCAuthenticationBackend()
-
-    def get_userinfo_mocked(*args):
-        return {
-            "test": "123",
-        }
-
-    monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
-
-    with (
-        django_assert_num_queries(0),
-        pytest.raises(
-            KeyError,
-            match="sub",
-        ),
-    ):
-        klass.get_or_create_user(access_token="test-token", id_token=None, payload=None)
-
-    assert models.User.objects.exists() is False
-
-
-@pytest.mark.parametrize(
-    "essential_claims, missing_claims",
-    [
-        (["email", "sub"], ["email"]),
-        (["Email", "sub"], ["Email"]),  # Case sensitivity
-    ],
-)
-@override_settings(OIDC_OP_USER_ENDPOINT="http://oidc.endpoint.test/userinfo")
-@mock.patch.object(Logger, "error")
-def test_authentication_verify_claims_essential_missing(
-    mock_logger,
-    essential_claims,
-    missing_claims,
-    django_assert_num_queries,
-    monkeypatch,
-):
-    """Ensure SuspiciousOperation is raised if essential claims are missing."""
-
-    klass = OIDCAuthenticationBackend()
-
-    def get_userinfo_mocked(*args):
-        return {
-            "sub": "123",
-            "last_name": "Doe",
-        }
-
-    monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
-
-    with (
-        django_assert_num_queries(0),
-        pytest.raises(
-            SuspiciousOperation,
-            match="Claims verification failed",
-        ),
-        override_settings(USER_OIDC_ESSENTIAL_CLAIMS=essential_claims),
-    ):
-        klass.get_or_create_user(access_token="test-token", id_token=None, payload=None)
-
-    assert models.User.objects.exists() is False
-    mock_logger.assert_called_once_with("Missing essential claims: %s", missing_claims)
-
-
-@override_settings(
-    OIDC_OP_USER_ENDPOINT="http://oidc.endpoint.test/userinfo",
-    USER_OIDC_ESSENTIAL_CLAIMS=["email", "last_name"],
-)
-def test_authentication_verify_claims_success(django_assert_num_queries, monkeypatch):
-    """Ensure user is authenticated when all essential claims are present."""
-
-    klass = OIDCAuthenticationBackend()
-
-    def get_userinfo_mocked(*args):
-        return {
-            "email": "john.doe@example.com",
-            "last_name": "Doe",
-            "sub": "123",
-        }
-
-    monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
-
-    with django_assert_num_queries(6):
-        user = klass.get_or_create_user(
-            access_token="test-token", id_token=None, payload=None
-        )
-
-    assert models.User.objects.filter(id=user.id).exists()
-
-    assert user.sub == "123"
-    assert user.full_name == "Doe"
-    assert user.short_name is None
-    assert user.email == "john.doe@example.com"

src/backend/core/tests/commands/test_update_files_content_type_metadata.py

@@ -1,50 +0,0 @@
-"""
-Unit test for `update_files_content_type_metadata` command.
-"""
-
-import uuid
-
-from django.core.files.storage import default_storage
-from django.core.management import call_command
-
-import pytest
-
-from core import factories
-
-
-@pytest.mark.django_db
-def test_update_files_content_type_metadata():
-    """
-    Test that the command `update_files_content_type_metadata`
-    fixes the ContentType of attachment in the storage.
-    """
-    s3_client = default_storage.connection.meta.client
-    bucket_name = default_storage.bucket_name
-
-    # Create files with a wrong ContentType
-    keys = []
-    for _ in range(10):
-        doc_id = uuid.uuid4()
-        factories.DocumentFactory(id=doc_id)
-        key = f"{doc_id}/attachments/testfile.png"
-        keys.append(key)
-        fake_png = b"\x89PNG\r\n\x1a\n\x00\x00\x00\rIHDR..."
-        s3_client.put_object(
-            Bucket=bucket_name,
-            Key=key,
-            Body=fake_png,
-            ContentType="text/plain",
-            Metadata={"owner": "None"},
-        )
-
-    # Call the command that fixes the ContentType
-    call_command("update_files_content_type_metadata")
-
-    for key in keys:
-        head_resp = s3_client.head_object(Bucket=bucket_name, Key=key)
-        assert head_resp["ContentType"] == "image/png", (
-            f"ContentType not fixed, got {head_resp['ContentType']!r}"
-        )
-
-        # Check that original metadata was preserved
-        assert head_resp["Metadata"].get("owner") == "None"

src/backend/core/tests/documents/test_api_document_accesses.py

@@ -11,9 +11,6 @@ from rest_framework.test import APIClient
 from core import factories, models
 from core.api import serializers
 from core.tests.conftest import TEAM, USER, VIA
-from core.tests.test_services_collaboration_services import (  # pylint: disable=unused-import
-    mock_reset_connections,
-)
 
 pytestmark = pytest.mark.django_db
 
@@ -76,14 +73,14 @@ def test_api_document_accesses_list_authenticated_related(via, mock_user_teams):
         user_access = models.DocumentAccess.objects.create(
             document=document,
             user=user,
-            role=random.choice(models.RoleChoices.values),
+            role=random.choice(models.RoleChoices.choices)[0],
         )
     elif via == TEAM:
         mock_user_teams.return_value = ["lasuite", "unknown"]
         user_access = models.DocumentAccess.objects.create(
             document=document,
             team="lasuite",
-            role=random.choice(models.RoleChoices.values),
+            role=random.choice(models.RoleChoices.choices)[0],
         )
 
     access1 = factories.TeamDocumentAccessFactory(document=document)
@@ -227,7 +224,7 @@ def test_api_document_accesses_update_anonymous():
     new_values = {
         "id": uuid4(),
         "user": factories.UserFactory().id,
-        "role": random.choice(models.RoleChoices.values),
+        "role": random.choice(models.RoleChoices.choices)[0],
     }
 
     api_client = APIClient()
@@ -260,7 +257,7 @@ def test_api_document_accesses_update_authenticated_unrelated():
     new_values = {
         "id": uuid4(),
         "user": factories.UserFactory().id,
-        "role": random.choice(models.RoleChoices.values),
+        "role": random.choice(models.RoleChoices.choices)[0],
     }
 
     for field, value in new_values.items():
@@ -302,7 +299,7 @@ def test_api_document_accesses_update_authenticated_reader_or_editor(
     new_values = {
         "id": uuid4(),
         "user": factories.UserFactory().id,
-        "role": random.choice(models.RoleChoices.values),
+        "role": random.choice(models.RoleChoices.choices)[0],
     }
 
     for field, value in new_values.items():
@@ -319,11 +316,7 @@ def test_api_document_accesses_update_authenticated_reader_or_editor(
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_update_administrator_except_owner(
-    via,
-    mock_user_teams,
-    mock_reset_connections,  # pylint: disable=redefined-outer-name
-):
+def test_api_document_accesses_update_administrator_except_owner(via, mock_user_teams):
     """
     A user who is a direct administrator in a document should be allowed to update a user
     access for this document, as long as they don't try to set the role to owner.
@@ -358,21 +351,18 @@ def test_api_document_accesses_update_administrator_except_owner(
 
     for field, value in new_values.items():
         new_data = {**old_values, field: value}
-        if new_data["role"] == old_values["role"]:
-            response = client.put(
-                f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-                data=new_data,
-                format="json",
-            )
+        response = client.put(
+            f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
+            data=new_data,
+            format="json",
+        )
+
+        if (
+            new_data["role"] == old_values["role"]
+        ):  # we are not really updating the role
             assert response.status_code == 403
         else:
-            with mock_reset_connections(document.id, str(access.user_id)):
-                response = client.put(
-                    f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-                    data=new_data,
-                    format="json",
-                )
-                assert response.status_code == 200
+            assert response.status_code == 200
 
         access.refresh_from_db()
         updated_values = serializers.DocumentAccessSerializer(instance=access).data
@@ -413,7 +403,7 @@ def test_api_document_accesses_update_administrator_from_owner(via, mock_user_te
     new_values = {
         "id": uuid4(),
         "user_id": factories.UserFactory().id,
-        "role": random.choice(models.RoleChoices.values),
+        "role": random.choice(models.RoleChoices.choices)[0],
     }
 
     for field, value in new_values.items():
@@ -430,11 +420,7 @@ def test_api_document_accesses_update_administrator_from_owner(via, mock_user_te
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_update_administrator_to_owner(
-    via,
-    mock_user_teams,
-    mock_reset_connections,  # pylint: disable=redefined-outer-name
-):
+def test_api_document_accesses_update_administrator_to_owner(via, mock_user_teams):
     """
     A user who is an administrator in a document, should not be allowed to update
     the user access of another user to grant document ownership.
@@ -471,23 +457,16 @@ def test_api_document_accesses_update_administrator_to_owner(
 
     for field, value in new_values.items():
         new_data = {**old_values, field: value}
+        response = client.put(
+            f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
+            data=new_data,
+            format="json",
+        )
         # We are not allowed or not really updating the role
         if field == "role" or new_data["role"] == old_values["role"]:
-            response = client.put(
-                f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-                data=new_data,
-                format="json",
-            )
-
             assert response.status_code == 403
         else:
-            with mock_reset_connections(document.id, str(access.user_id)):
-                response = client.put(
-                    f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-                    data=new_data,
-                    format="json",
-                )
-                assert response.status_code == 200
+            assert response.status_code == 200
 
         access.refresh_from_db()
         updated_values = serializers.DocumentAccessSerializer(instance=access).data
@@ -495,11 +474,7 @@ def test_api_document_accesses_update_administrator_to_owner(
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_update_owner(
-    via,
-    mock_user_teams,
-    mock_reset_connections,  # pylint: disable=redefined-outer-name
-):
+def test_api_document_accesses_update_owner(via, mock_user_teams):
     """
     A user who is an owner in a document should be allowed to update
     a user access for this document whatever the role.
@@ -527,29 +502,23 @@ def test_api_document_accesses_update_owner(
     new_values = {
         "id": uuid4(),
         "user_id": factories.UserFactory().id,
-        "role": random.choice(models.RoleChoices.values),
+        "role": random.choice(models.RoleChoices.choices)[0],
     }
 
     for field, value in new_values.items():
         new_data = {**old_values, field: value}
+        response = client.put(
+            f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
+            data=new_data,
+            format="json",
+        )
+
         if (
             new_data["role"] == old_values["role"]
         ):  # we are not really updating the role
-            response = client.put(
-                f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-                data=new_data,
-                format="json",
-            )
             assert response.status_code == 403
         else:
-            with mock_reset_connections(document.id, str(access.user_id)):
-                response = client.put(
-                    f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-                    data=new_data,
-                    format="json",
-                )
-
-                assert response.status_code == 200
+            assert response.status_code == 200
 
         access.refresh_from_db()
         updated_values = serializers.DocumentAccessSerializer(instance=access).data
@@ -561,11 +530,7 @@ def test_api_document_accesses_update_owner(
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_update_owner_self(
-    via,
-    mock_user_teams,
-    mock_reset_connections,  # pylint: disable=redefined-outer-name
-):
+def test_api_document_accesses_update_owner_self(via, mock_user_teams):
     """
     A user who is owner of a document should be allowed to update
     their own user access provided there are other owners in the document.
@@ -603,23 +568,21 @@ def test_api_document_accesses_update_owner_self(
     # Add another owner and it should now work
     factories.UserDocumentAccessFactory(document=document, role="owner")
 
-    user_id = str(access.user_id) if via == USER else None
-    with mock_reset_connections(document.id, user_id):
-        response = client.put(
-            f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-            data={
-                **old_values,
-                "role": new_role,
-                "user_id": old_values.get("user", {}).get("id")
-                if old_values.get("user") is not None
-                else None,
-            },
-            format="json",
-        )
+    response = client.put(
+        f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
+        data={
+            **old_values,
+            "role": new_role,
+            "user_id": old_values.get("user", {}).get("id")
+            if old_values.get("user") is not None
+            else None,
+        },
+        format="json",
+    )
 
-        assert response.status_code == 200
-        access.refresh_from_db()
-        assert access.role == new_role
+    assert response.status_code == 200
+    access.refresh_from_db()
+    assert access.role == new_role
 
 
 # Delete
@@ -693,9 +656,7 @@ def test_api_document_accesses_delete_reader_or_editor(via, role, mock_user_team
 
 @pytest.mark.parametrize("via", VIA)
 def test_api_document_accesses_delete_administrators_except_owners(
-    via,
-    mock_user_teams,
-    mock_reset_connections,  # pylint: disable=redefined-outer-name
+    via, mock_user_teams
 ):
     """
     Users who are administrators in a document should be allowed to delete an access
@@ -724,13 +685,12 @@ def test_api_document_accesses_delete_administrators_except_owners(
     assert models.DocumentAccess.objects.count() == 2
     assert models.DocumentAccess.objects.filter(user=access.user).exists()
 
-    with mock_reset_connections(document.id, str(access.user_id)):
-        response = client.delete(
-            f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-        )
+    response = client.delete(
+        f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
+    )
 
-        assert response.status_code == 204
-        assert models.DocumentAccess.objects.count() == 1
+    assert response.status_code == 204
+    assert models.DocumentAccess.objects.count() == 1
 
 
 @pytest.mark.parametrize("via", VIA)
@@ -769,11 +729,7 @@ def test_api_document_accesses_delete_administrator_on_owners(via, mock_user_tea
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_document_accesses_delete_owners(
-    via,
-    mock_user_teams,
-    mock_reset_connections,  # pylint: disable=redefined-outer-name
-):
+def test_api_document_accesses_delete_owners(via, mock_user_teams):
     """
     Users should be able to delete the document access of another user
     for a document of which they are owner.
@@ -797,13 +753,12 @@ def test_api_document_accesses_delete_owners(
     assert models.DocumentAccess.objects.count() == 2
     assert models.DocumentAccess.objects.filter(user=access.user).exists()
 
-    with mock_reset_connections(document.id, str(access.user_id)):
-        response = client.delete(
-            f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
-        )
+    response = client.delete(
+        f"/api/v1.0/documents/{document.id!s}/accesses/{access.id!s}/",
+    )
 
-        assert response.status_code == 204
-        assert models.DocumentAccess.objects.count() == 1
+    assert response.status_code == 204
+    assert models.DocumentAccess.objects.count() == 1
 
 
 @pytest.mark.parametrize("via", VIA)

src/backend/core/tests/documents/test_api_document_accesses_create.py

@@ -26,7 +26,7 @@ def test_api_document_accesses_create_anonymous():
         {
             "user_id": str(other_user.id),
             "document": str(document.id),
-            "role": random.choice(models.RoleChoices.values),
+            "role": random.choice(models.RoleChoices.choices)[0],
         },
         format="json",
     )
@@ -171,11 +171,10 @@ def test_api_document_accesses_create_authenticated_administrator(via, mock_user
     email = mail.outbox[0]
     assert email.to == [other_user["email"]]
     email_content = " ".join(email.body.split())
-    assert f"{user.full_name} shared a document with you!" in email_content
     assert (
-        f"{user.full_name} ({user.email}) invited you with the role "{role}" "
-        f"on the following document: {document.title}"
-    ) in email_content
+        f"{user.full_name} shared a document with you: {document.title}"
+        in email_content
+    )
     assert "docs/" + str(document.id) + "/" in email_content
 
 
@@ -229,9 +228,8 @@ def test_api_document_accesses_create_authenticated_owner(via, mock_user_teams):
     email = mail.outbox[0]
     assert email.to == [other_user["email"]]
     email_content = " ".join(email.body.split())
-    assert f"{user.full_name} shared a document with you!" in email_content
     assert (
-        f"{user.full_name} ({user.email}) invited you with the role "{role}" "
-        f"on the following document: {document.title}"
-    ) in email_content
+        f"{user.full_name} shared a document with you: {document.title}"
+        in email_content
+    )
     assert "docs/" + str(document.id) + "/" in email_content

src/backend/core/tests/documents/test_api_document_invitations.py

@@ -7,7 +7,6 @@ from datetime import timedelta
 from unittest import mock
 
 from django.core import mail
-from django.test import override_settings
 from django.utils import timezone
 
 import pytest
@@ -304,7 +303,7 @@ def test_api_document_invitations_create_anonymous():
     document = factories.DocumentFactory()
     invitation_values = {
         "email": "guest@example.com",
-        "role": random.choice(models.RoleChoices.values),
+        "role": random.choice(models.RoleChoices.choices)[0],
     }
 
     response = APIClient().post(
@@ -325,7 +324,7 @@ def test_api_document_invitations_create_authenticated_outsider():
     document = factories.DocumentFactory()
     invitation_values = {
         "email": "guest@example.com",
-        "role": random.choice(models.RoleChoices.values),
+        "role": random.choice(models.RoleChoices.choices)[0],
     }
 
     client = APIClient()
@@ -340,7 +339,6 @@ def test_api_document_invitations_create_authenticated_outsider():
     assert response.status_code == 403
 
 
-@override_settings(EMAIL_BRAND_NAME="My brand name", EMAIL_LOGO_IMG="my-img.jpg")
 @pytest.mark.parametrize(
     "inviting,invited,response_code",
     (
@@ -404,13 +402,10 @@ def test_api_document_invitations_create_privileged_members(
         email = mail.outbox[0]
         assert email.to == ["guest@example.com"]
         email_content = " ".join(email.body.split())
-        assert f"{user.full_name} shared a document with you!" in email_content
         assert (
-            f"{user.full_name} ({user.email}) invited you with the role "{invited}" "
-            f"on the following document: {document.title}"
-        ) in email_content
-        assert "My brand name" in email_content
-        assert "my-img.jpg" in email_content
+            f"{user.full_name} shared a document with you: {document.title}"
+            in email_content
+        )
     else:
         assert models.Invitation.objects.exists() is False
 
@@ -457,7 +452,10 @@ def test_api_document_invitations_create_email_from_content_language():
     assert email.to == ["guest@example.com"]
 
     email_content = " ".join(email.body.split())
-    assert f"{user.full_name} a partagé un document avec vous!" in email_content
+    assert (
+        f"{user.full_name} a partagé un document avec vous: {document.title}"
+        in email_content
+    )
 
 
 def test_api_document_invitations_create_email_from_content_language_not_supported():
@@ -496,7 +494,10 @@ def test_api_document_invitations_create_email_from_content_language_not_support
     assert email.to == ["guest@example.com"]
 
     email_content = " ".join(email.body.split())
-    assert f"{user.full_name} shared a document with you!" in email_content
+    assert (
+        f"{user.full_name} shared a document with you: {document.title}"
+        in email_content
+    )
 
 
 def test_api_document_invitations_create_email_full_name_empty():
@@ -534,10 +535,10 @@ def test_api_document_invitations_create_email_full_name_empty():
     assert email.to == ["guest@example.com"]
 
     email_content = " ".join(email.body.split())
-    assert f"{user.email} shared a document with you!" in email_content
+    assert f"{user.email} shared a document with you: {document.title}" in email_content
     assert (
-        f"{user.email.capitalize()} invited you with the role "reader" on the "
-        f"following document: {document.title}" in email_content
+        f'{user.email} invited you with the role "reader" on the '
+        f"following document : {document.title}" in email_content
     )
 
 
@@ -550,7 +551,7 @@ def test_api_document_invitations_create_issuer_and_document_override():
         "document": str(other_document.id),
         "issuer": str(factories.UserFactory().id),
         "email": "guest@example.com",
-        "role": random.choice(models.RoleChoices.values),
+        "role": random.choice(models.RoleChoices.choices)[0],
     }
 
     client = APIClient()
@@ -611,7 +612,7 @@ def test_api_document_invitations_create_cannot_invite_existing_users():
     # Build an invitation to the email of an exising identity in the db
     invitation_values = {
         "email": existing_user.email,
-        "role": random.choice(models.RoleChoices.values),
+        "role": random.choice(models.RoleChoices.choices)[0],
     }
 
     client = APIClient()
@@ -624,9 +625,7 @@ def test_api_document_invitations_create_cannot_invite_existing_users():
     )
 
     assert response.status_code == 400
-    assert response.json() == {
-        "email": ["This email is already associated to a registered user."]
-    }
+    assert response.json() == ["This email is already associated to a registered user."]
 
 
 # Update

src/backend/core/tests/documents/test_api_document_versions.py

@@ -75,14 +75,14 @@ def test_api_document_versions_list_authenticated_related_success(via, mock_user
         models.DocumentAccess.objects.create(
             document=document,
             user=user,
-            role=random.choice(models.RoleChoices.values),
+            role=random.choice(models.RoleChoices.choices)[0],
         )
     elif via == TEAM:
         mock_user_teams.return_value = ["lasuite", "unknown"]
         models.DocumentAccess.objects.create(
             document=document,
             team="lasuite",
-            role=random.choice(models.RoleChoices.values),
+            role=random.choice(models.RoleChoices.choices)[0],
         )
 
     # Other versions of documents to which the user has access should not be listed
@@ -134,14 +134,14 @@ def test_api_document_versions_list_authenticated_related_pagination(
         models.DocumentAccess.objects.create(
             document=document,
             user=user,
-            role=random.choice(models.RoleChoices.values),
+            role=random.choice(models.RoleChoices.choices)[0],
         )
     elif via == TEAM:
         mock_user_teams.return_value = ["lasuite", "unknown"]
         models.DocumentAccess.objects.create(
             document=document,
             team="lasuite",
-            role=random.choice(models.RoleChoices.values),
+            role=random.choice(models.RoleChoices.choices)[0],
         )
 
     for i in range(4):
@@ -185,84 +185,6 @@ def test_api_document_versions_list_authenticated_related_pagination(
     assert content["versions"][0]["version_id"] == all_version_ids[2]
 
 
-@pytest.mark.parametrize("via", VIA)
-def test_api_document_versions_list_authenticated_related_pagination_parent(
-    via, mock_user_teams
-):
-    """
-    When a user gains access to a document's versions via an ancestor, the date of access
-    to the parent should be used to filter versions that were created prior to the
-    user gaining access to the document.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    grand_parent = factories.DocumentFactory()
-    parent = factories.DocumentFactory(parent=grand_parent)
-    document = factories.DocumentFactory(parent=parent)
-    for i in range(3):
-        document.content = f"before {i:d}"
-        document.save()
-
-    if via == USER:
-        models.DocumentAccess.objects.create(
-            document=grand_parent,
-            user=user,
-            role=random.choice(models.RoleChoices.values),
-        )
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        models.DocumentAccess.objects.create(
-            document=grand_parent,
-            team="lasuite",
-            role=random.choice(models.RoleChoices.values),
-        )
-
-    for i in range(4):
-        document.content = f"after {i:d}"
-        document.save()
-
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/versions/",
-    )
-
-    content = response.json()
-
-    assert response.status_code == 200
-    assert content["is_truncated"] is False
-    # The current version is not listed
-    assert content["count"] == 3
-    assert content["next_version_id_marker"] == ""
-    all_version_ids = [version["version_id"] for version in content["versions"]]
-
-    # - set page size
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/versions/?page_size=2",
-    )
-
-    content = response.json()
-    assert content["count"] == 2
-    assert content["is_truncated"] is True
-    marker = content["next_version_id_marker"]
-    assert marker == all_version_ids[1]
-    assert [
-        version["version_id"] for version in content["versions"]
-    ] == all_version_ids[:2]
-
-    # - get page 2
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/versions/?page_size=2&version_id={marker:s}",
-    )
-
-    content = response.json()
-    assert content["count"] == 1
-    assert content["is_truncated"] is False
-    assert content["next_version_id_marker"] == ""
-    assert content["versions"][0]["version_id"] == all_version_ids[2]
-
-
 def test_api_document_versions_list_exceeds_max_page_size():
     """Page size should not exceed the limit set on the serializer"""
     user = factories.UserFactory()
@@ -392,74 +314,6 @@ def test_api_document_versions_retrieve_authenticated_related(via, mock_user_tea
     assert response.json()["content"] == "new content 1"
 
 
-@pytest.mark.parametrize("via", VIA)
-def test_api_document_versions_retrieve_authenticated_related_parent(
-    via, mock_user_teams
-):
-    """
-    A user who gains access to a document's versions via one of its ancestors, should be able to
-    retrieve the document versions. The date of access to the parent should be used to filter
-    versions that were created prior to the user gaining access to the document.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    grand_parent = factories.DocumentFactory()
-    parent = factories.DocumentFactory(parent=grand_parent)
-    document = factories.DocumentFactory(parent=parent)
-    document.content = "new content"
-    document.save()
-
-    assert len(document.get_versions_slice()["versions"]) == 1
-    version_id = document.get_versions_slice()["versions"][0]["version_id"]
-
-    if via == USER:
-        factories.UserDocumentAccessFactory(document=grand_parent, user=user)
-    elif via == TEAM:
-        mock_user_teams.return_value = ["lasuite", "unknown"]
-        factories.TeamDocumentAccessFactory(document=grand_parent, team="lasuite")
-
-    time.sleep(1)  # minio stores datetimes with the precision of a second
-
-    # Versions created before the document was shared should not be seen by the user
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/versions/{version_id:s}/",
-    )
-
-    assert response.status_code == 404
-
-    # Create a new version should not make it available to the user because
-    # only the current version is available to the user but it is excluded
-    # from the list
-    document.content = "new content 1"
-    document.save()
-
-    assert len(document.get_versions_slice()["versions"]) == 2
-    version_id = document.get_versions_slice()["versions"][0]["version_id"]
-
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/versions/{version_id:s}/",
-    )
-
-    assert response.status_code == 404
-
-    # Adding one more version should make the previous version available to the user
-    document.content = "new content 2"
-    document.save()
-
-    assert len(document.get_versions_slice()["versions"]) == 3
-    version_id = document.get_versions_slice()["versions"][0]["version_id"]
-
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/versions/{version_id:s}/",
-    )
-
-    assert response.status_code == 200
-    assert response.json()["content"] == "new content 1"
-
-
 def test_api_document_versions_create_anonymous():
     """Anonymous users should not be allowed to create document versions."""
     document = factories.DocumentFactory()
@@ -604,19 +458,15 @@ def test_api_document_versions_update_authenticated_related(via, mock_user_teams
 # Delete
 
 
-@pytest.mark.parametrize("reach", models.LinkReachChoices.values)
-def test_api_document_versions_delete_anonymous(reach):
+def test_api_document_versions_delete_anonymous():
     """Anonymous users should not be allowed to destroy a document version."""
-    access = factories.UserDocumentAccessFactory(document__link_reach=reach)
+    access = factories.UserDocumentAccessFactory()
 
     response = APIClient().delete(
         f"/api/v1.0/documents/{access.document_id!s}/versions/{access.id!s}/",
     )
 
     assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
 
 
 @pytest.mark.parametrize("reach", models.LinkReachChoices.values)

src/backend/core/tests/documents/test_api_documents_attachment_upload.py

@@ -64,22 +64,12 @@ def test_api_documents_attachment_upload_anonymous_success():
     assert response.status_code == 201
 
     pattern = re.compile(rf"^/media/{document.id!s}/attachments/(.*)\.png")
-    file_path = response.json()["file"]
-    match = pattern.search(file_path)
+    match = pattern.search(response.json()["file"])
     file_id = match.group(1)
 
     # Validate that file_id is a valid UUID
     uuid.UUID(file_id)
 
-    # Now, check the metadata of the uploaded file
-    key = file_path.replace("/media", "")
-    file_head = default_storage.connection.meta.client.head_object(
-        Bucket=default_storage.bucket_name, Key=key
-    )
-
-    assert file_head["Metadata"] == {"owner": "None"}
-    assert file_head["ContentType"] == "image/png"
-
 
 @pytest.mark.parametrize(
     "reach, role",
@@ -216,7 +206,6 @@ def test_api_documents_attachment_upload_success(via, role, mock_user_teams):
         Bucket=default_storage.bucket_name, Key=key
     )
     assert file_head["Metadata"] == {"owner": str(user.id)}
-    assert file_head["ContentType"] == "image/png"
 
 
 def test_api_documents_attachment_upload_invalid(client):
@@ -258,18 +247,16 @@ def test_api_documents_attachment_upload_size_limit_exceeded(settings):
 
 
 @pytest.mark.parametrize(
-    "name,content,extension,content_type",
+    "name,content,extension",
     [
-        ("test.exe", b"text", "exe", "text/plain"),
-        ("test", b"text", "txt", "text/plain"),
-        ("test.aaaaaa", b"test", "txt", "text/plain"),
-        ("test.txt", PIXEL, "txt", "image/png"),
-        ("test.py", b"#!/usr/bin/python", "py", "text/plain"),
+        ("test.exe", b"text", "exe"),
+        ("test", b"text", "txt"),
+        ("test.aaaaaa", b"test", "txt"),
+        ("test.txt", PIXEL, "txt"),
+        ("test.py", b"#!/usr/bin/python", "py"),
     ],
 )
-def test_api_documents_attachment_upload_fix_extension(
-    name, content, extension, content_type
-):
+def test_api_documents_attachment_upload_fix_extension(name, content, extension):
     """
     A file with no extension or a wrong extension is accepted and the extension
     is corrected in storage.
@@ -300,7 +287,6 @@ def test_api_documents_attachment_upload_fix_extension(
         Bucket=default_storage.bucket_name, Key=key
     )
     assert file_head["Metadata"] == {"owner": str(user.id), "is_unsafe": "true"}
-    assert file_head["ContentType"] == content_type
 
 
 def test_api_documents_attachment_upload_empty_file():
@@ -349,4 +335,3 @@ def test_api_documents_attachment_upload_unsafe():
         Bucket=default_storage.bucket_name, Key=key
     )
     assert file_head["Metadata"] == {"owner": str(user.id), "is_unsafe": "true"}
-    assert file_head["ContentType"] == "application/octet-stream"

src/backend/core/tests/documents/test_api_documents_children_create.py

@@ -1,251 +0,0 @@
-"""
-Tests for Documents API endpoint in impress's core app: create
-"""
-
-from uuid import uuid4
-
-import pytest
-from rest_framework.test import APIClient
-
-from core import factories
-from core.models import Document, LinkReachChoices, LinkRoleChoices
-
-pytestmark = pytest.mark.django_db
-
-
-@pytest.mark.parametrize("depth", [1, 2, 3])
-@pytest.mark.parametrize("role", LinkRoleChoices.values)
-@pytest.mark.parametrize("reach", LinkReachChoices.values)
-def test_api_documents_children_create_anonymous(reach, role, depth):
-    """Anonymous users should not be allowed to create children documents."""
-    for i in range(depth):
-        if i == 0:
-            document = factories.DocumentFactory(link_reach=reach, link_role=role)
-        else:
-            document = factories.DocumentFactory(parent=document)
-
-    response = APIClient().post(
-        f"/api/v1.0/documents/{document.id!s}/children/",
-        {
-            "title": "my document",
-        },
-    )
-
-    assert Document.objects.count() == depth
-    assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
-
-
-@pytest.mark.parametrize("depth", [1, 2, 3])
-@pytest.mark.parametrize(
-    "reach,role",
-    [
-        ["restricted", "editor"],
-        ["restricted", "reader"],
-        ["public", "reader"],
-        ["authenticated", "reader"],
-    ],
-)
-def test_api_documents_children_create_authenticated_forbidden(reach, role, depth):
-    """
-    Authenticated users with no write access on a document should not be allowed
-    to create a nested document.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    for i in range(depth):
-        if i == 0:
-            document = factories.DocumentFactory(link_reach=reach, link_role=role)
-        else:
-            document = factories.DocumentFactory(parent=document, link_role="reader")
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/children/",
-        {
-            "title": "my document",
-        },
-    )
-
-    assert response.status_code == 403
-    assert Document.objects.count() == depth
-
-
-@pytest.mark.parametrize("depth", [1, 2, 3])
-@pytest.mark.parametrize(
-    "reach,role",
-    [
-        ["public", "editor"],
-        ["authenticated", "editor"],
-    ],
-)
-def test_api_documents_children_create_authenticated_success(reach, role, depth):
-    """
-    Authenticated users with write access on a document should be able
-    to create a nested document.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    for i in range(depth):
-        if i == 0:
-            document = factories.DocumentFactory(link_reach=reach, link_role=role)
-        else:
-            document = factories.DocumentFactory(parent=document, link_role="reader")
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/children/",
-        {
-            "title": "my child",
-        },
-    )
-
-    assert response.status_code == 201
-
-    child = Document.objects.get(id=response.json()["id"])
-    assert child.title == "my child"
-    assert child.link_reach == "restricted"
-    assert child.accesses.filter(role="owner", user=user).exists()
-
-
-@pytest.mark.parametrize("depth", [1, 2, 3])
-def test_api_documents_children_create_related_forbidden(depth):
-    """
-    Authenticated users with a specific read access on a document should not be allowed
-    to create a nested document.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    for i in range(depth):
-        if i == 0:
-            document = factories.DocumentFactory(link_reach="restricted")
-            factories.UserDocumentAccessFactory(
-                user=user, document=document, role="reader"
-            )
-        else:
-            document = factories.DocumentFactory(
-                parent=document, link_reach="restricted"
-            )
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/children/",
-        {
-            "title": "my document",
-        },
-    )
-
-    assert response.status_code == 403
-    assert Document.objects.count() == depth
-
-
-@pytest.mark.parametrize("depth", [1, 2, 3])
-@pytest.mark.parametrize("role", ["editor", "administrator", "owner"])
-def test_api_documents_children_create_related_success(role, depth):
-    """
-    Authenticated users with a specific write access on a document should be
-    able to create a nested document.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    for i in range(depth):
-        if i == 0:
-            document = factories.DocumentFactory(link_reach="restricted")
-            factories.UserDocumentAccessFactory(user=user, document=document, role=role)
-        else:
-            document = factories.DocumentFactory(
-                parent=document, link_reach="restricted"
-            )
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/children/",
-        {
-            "title": "my child",
-        },
-    )
-
-    assert response.status_code == 201
-    child = Document.objects.get(id=response.json()["id"])
-    assert child.title == "my child"
-    assert child.link_reach == "restricted"
-    assert child.accesses.filter(role="owner", user=user).exists()
-
-
-def test_api_documents_children_create_authenticated_title_null():
-    """It should be possible to create several nested documents with a null title."""
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    parent = factories.DocumentFactory(
-        title=None, link_reach="authenticated", link_role="editor"
-    )
-    factories.DocumentFactory(title=None, parent=parent)
-
-    response = client.post(
-        f"/api/v1.0/documents/{parent.id!s}/children/", {}, format="json"
-    )
-
-    assert response.status_code == 201
-    assert Document.objects.filter(title__isnull=True).count() == 3
-
-
-def test_api_documents_children_create_force_id_success():
-    """It should be possible to force the document ID when creating a nested document."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    access = factories.UserDocumentAccessFactory(user=user, role="editor")
-    forced_id = uuid4()
-
-    response = client.post(
-        f"/api/v1.0/documents/{access.document.id!s}/children/",
-        {
-            "id": str(forced_id),
-            "title": "my document",
-        },
-        format="json",
-    )
-
-    assert response.status_code == 201
-    assert Document.objects.count() == 2
-    assert response.json()["id"] == str(forced_id)
-
-
-def test_api_documents_children_create_force_id_existing():
-    """
-    It should not be possible to use the ID of an existing document when forcing ID on creation.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    access = factories.UserDocumentAccessFactory(user=user, role="editor")
-    document = factories.DocumentFactory()
-
-    response = client.post(
-        f"/api/v1.0/documents/{access.document.id!s}/children/",
-        {
-            "id": str(document.id),
-            "title": "my document",
-        },
-        format="json",
-    )
-
-    assert response.status_code == 400
-    assert response.json() == {
-        "id": ["A document with this ID already exists. You cannot override it."]
-    }

src/backend/core/tests/documents/test_api_documents_children_list.py

@@ -1,541 +0,0 @@
-"""
-Tests for Documents API endpoint in impress's core app: retrieve
-"""
-
-import random
-
-from django.contrib.auth.models import AnonymousUser
-
-import pytest
-from rest_framework.test import APIClient
-
-from core import factories
-
-pytestmark = pytest.mark.django_db
-
-
-def test_api_documents_children_list_anonymous_public_standalone():
-    """Anonymous users should be allowed to retrieve the children of a public documents."""
-    document = factories.DocumentFactory(link_reach="public")
-    child1, child2 = factories.DocumentFactory.create_batch(2, parent=document)
-    factories.UserDocumentAccessFactory(document=child1)
-
-    response = APIClient().get(f"/api/v1.0/documents/{document.id!s}/children/")
-
-    assert response.status_code == 200
-    assert response.json() == {
-        "count": 2,
-        "next": None,
-        "previous": None,
-        "results": [
-            {
-                "abilities": child1.get_abilities(AnonymousUser()),
-                "created_at": child1.created_at.isoformat().replace("+00:00", "Z"),
-                "creator": str(child1.creator.id),
-                "depth": 2,
-                "excerpt": child1.excerpt,
-                "id": str(child1.id),
-                "is_favorite": False,
-                "link_reach": child1.link_reach,
-                "link_role": child1.link_role,
-                "numchild": 0,
-                "nb_accesses": 1,
-                "path": child1.path,
-                "title": child1.title,
-                "updated_at": child1.updated_at.isoformat().replace("+00:00", "Z"),
-                "user_roles": [],
-            },
-            {
-                "abilities": child2.get_abilities(AnonymousUser()),
-                "created_at": child2.created_at.isoformat().replace("+00:00", "Z"),
-                "creator": str(child2.creator.id),
-                "depth": 2,
-                "excerpt": child2.excerpt,
-                "id": str(child2.id),
-                "is_favorite": False,
-                "link_reach": child2.link_reach,
-                "link_role": child2.link_role,
-                "numchild": 0,
-                "nb_accesses": 0,
-                "path": child2.path,
-                "title": child2.title,
-                "updated_at": child2.updated_at.isoformat().replace("+00:00", "Z"),
-                "user_roles": [],
-            },
-        ],
-    }
-
-
-def test_api_documents_children_list_anonymous_public_parent():
-    """
-    Anonymous users should be allowed to retrieve the children of a document who
-    has a public ancestor.
-    """
-    grand_parent = factories.DocumentFactory(link_reach="public")
-    parent = factories.DocumentFactory(
-        parent=grand_parent, link_reach=random.choice(["authenticated", "restricted"])
-    )
-    document = factories.DocumentFactory(
-        link_reach=random.choice(["authenticated", "restricted"]), parent=parent
-    )
-    child1, child2 = factories.DocumentFactory.create_batch(2, parent=document)
-    factories.UserDocumentAccessFactory(document=child1)
-
-    response = APIClient().get(f"/api/v1.0/documents/{document.id!s}/children/")
-
-    assert response.status_code == 200
-    assert response.json() == {
-        "count": 2,
-        "next": None,
-        "previous": None,
-        "results": [
-            {
-                "abilities": child1.get_abilities(AnonymousUser()),
-                "created_at": child1.created_at.isoformat().replace("+00:00", "Z"),
-                "creator": str(child1.creator.id),
-                "depth": 4,
-                "excerpt": child1.excerpt,
-                "id": str(child1.id),
-                "is_favorite": False,
-                "link_reach": child1.link_reach,
-                "link_role": child1.link_role,
-                "numchild": 0,
-                "nb_accesses": 1,
-                "path": child1.path,
-                "title": child1.title,
-                "updated_at": child1.updated_at.isoformat().replace("+00:00", "Z"),
-                "user_roles": [],
-            },
-            {
-                "abilities": child2.get_abilities(AnonymousUser()),
-                "created_at": child2.created_at.isoformat().replace("+00:00", "Z"),
-                "creator": str(child2.creator.id),
-                "depth": 4,
-                "excerpt": child2.excerpt,
-                "id": str(child2.id),
-                "is_favorite": False,
-                "link_reach": child2.link_reach,
-                "link_role": child2.link_role,
-                "numchild": 0,
-                "nb_accesses": 0,
-                "path": child2.path,
-                "title": child2.title,
-                "updated_at": child2.updated_at.isoformat().replace("+00:00", "Z"),
-                "user_roles": [],
-            },
-        ],
-    }
-
-
-@pytest.mark.parametrize("reach", ["restricted", "authenticated"])
-def test_api_documents_children_list_anonymous_restricted_or_authenticated(reach):
-    """
-    Anonymous users should not be able to retrieve children of a document that is not public.
-    """
-    document = factories.DocumentFactory(link_reach=reach)
-    factories.DocumentFactory.create_batch(2, parent=document)
-
-    response = APIClient().get(f"/api/v1.0/documents/{document.id!s}/children/")
-
-    assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
-
-
-@pytest.mark.parametrize("reach", ["public", "authenticated"])
-def test_api_documents_children_list_authenticated_unrelated_public_or_authenticated(
-    reach,
-):
-    """
-    Authenticated users should be able to retrieve the children of a public/authenticated
-    document to which they are not related.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach=reach)
-    child1, child2 = factories.DocumentFactory.create_batch(2, parent=document)
-    factories.UserDocumentAccessFactory(document=child1)
-
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/children/",
-    )
-    assert response.status_code == 200
-    assert response.json() == {
-        "count": 2,
-        "next": None,
-        "previous": None,
-        "results": [
-            {
-                "abilities": child1.get_abilities(user),
-                "created_at": child1.created_at.isoformat().replace("+00:00", "Z"),
-                "creator": str(child1.creator.id),
-                "depth": 2,
-                "excerpt": child1.excerpt,
-                "id": str(child1.id),
-                "is_favorite": False,
-                "link_reach": child1.link_reach,
-                "link_role": child1.link_role,
-                "numchild": 0,
-                "nb_accesses": 1,
-                "path": child1.path,
-                "title": child1.title,
-                "updated_at": child1.updated_at.isoformat().replace("+00:00", "Z"),
-                "user_roles": [],
-            },
-            {
-                "abilities": child2.get_abilities(user),
-                "created_at": child2.created_at.isoformat().replace("+00:00", "Z"),
-                "creator": str(child2.creator.id),
-                "depth": 2,
-                "excerpt": child2.excerpt,
-                "id": str(child2.id),
-                "is_favorite": False,
-                "link_reach": child2.link_reach,
-                "link_role": child2.link_role,
-                "numchild": 0,
-                "nb_accesses": 0,
-                "path": child2.path,
-                "title": child2.title,
-                "updated_at": child2.updated_at.isoformat().replace("+00:00", "Z"),
-                "user_roles": [],
-            },
-        ],
-    }
-
-
-@pytest.mark.parametrize("reach", ["public", "authenticated"])
-def test_api_documents_children_list_authenticated_public_or_authenticated_parent(
-    reach,
-):
-    """
-    Authenticated users should be allowed to retrieve the children of a document who
-    has a public or authenticated ancestor.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    grand_parent = factories.DocumentFactory(link_reach=reach)
-    parent = factories.DocumentFactory(parent=grand_parent, link_reach="restricted")
-    document = factories.DocumentFactory(link_reach="restricted", parent=parent)
-    child1, child2 = factories.DocumentFactory.create_batch(2, parent=document)
-    factories.UserDocumentAccessFactory(document=child1)
-
-    response = client.get(f"/api/v1.0/documents/{document.id!s}/children/")
-
-    assert response.status_code == 200
-    assert response.json() == {
-        "count": 2,
-        "next": None,
-        "previous": None,
-        "results": [
-            {
-                "abilities": child1.get_abilities(user),
-                "created_at": child1.created_at.isoformat().replace("+00:00", "Z"),
-                "creator": str(child1.creator.id),
-                "depth": 4,
-                "excerpt": child1.excerpt,
-                "id": str(child1.id),
-                "is_favorite": False,
-                "link_reach": child1.link_reach,
-                "link_role": child1.link_role,
-                "numchild": 0,
-                "nb_accesses": 1,
-                "path": child1.path,
-                "title": child1.title,
-                "updated_at": child1.updated_at.isoformat().replace("+00:00", "Z"),
-                "user_roles": [],
-            },
-            {
-                "abilities": child2.get_abilities(user),
-                "created_at": child2.created_at.isoformat().replace("+00:00", "Z"),
-                "creator": str(child2.creator.id),
-                "depth": 4,
-                "excerpt": child2.excerpt,
-                "id": str(child2.id),
-                "is_favorite": False,
-                "link_reach": child2.link_reach,
-                "link_role": child2.link_role,
-                "numchild": 0,
-                "nb_accesses": 0,
-                "path": child2.path,
-                "title": child2.title,
-                "updated_at": child2.updated_at.isoformat().replace("+00:00", "Z"),
-                "user_roles": [],
-            },
-        ],
-    }
-
-
-def test_api_documents_children_list_authenticated_unrelated_restricted():
-    """
-    Authenticated users should not be allowed to retrieve the children of a document that is
-    restricted and to which they are not related.
-    """
-    user = factories.UserFactory(with_owned_document=True)
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach="restricted")
-    child1, _child2 = factories.DocumentFactory.create_batch(2, parent=document)
-    factories.UserDocumentAccessFactory(document=child1)
-
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/children/",
-    )
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-
-def test_api_documents_children_list_authenticated_related_direct():
-    """
-    Authenticated users should be allowed to retrieve the children of a document
-    to which they are directly related whatever the role.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory()
-    access = factories.UserDocumentAccessFactory(document=document, user=user)
-    factories.UserDocumentAccessFactory(document=document)
-
-    child1, child2 = factories.DocumentFactory.create_batch(2, parent=document)
-    factories.UserDocumentAccessFactory(document=child1)
-
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/children/",
-    )
-    assert response.status_code == 200
-    assert response.json() == {
-        "count": 2,
-        "next": None,
-        "previous": None,
-        "results": [
-            {
-                "abilities": child1.get_abilities(user),
-                "created_at": child1.created_at.isoformat().replace("+00:00", "Z"),
-                "creator": str(child1.creator.id),
-                "depth": 2,
-                "excerpt": child1.excerpt,
-                "id": str(child1.id),
-                "is_favorite": False,
-                "link_reach": child1.link_reach,
-                "link_role": child1.link_role,
-                "numchild": 0,
-                "nb_accesses": 3,
-                "path": child1.path,
-                "title": child1.title,
-                "updated_at": child1.updated_at.isoformat().replace("+00:00", "Z"),
-                "user_roles": [access.role],
-            },
-            {
-                "abilities": child2.get_abilities(user),
-                "created_at": child2.created_at.isoformat().replace("+00:00", "Z"),
-                "creator": str(child2.creator.id),
-                "depth": 2,
-                "excerpt": child2.excerpt,
-                "id": str(child2.id),
-                "is_favorite": False,
-                "link_reach": child2.link_reach,
-                "link_role": child2.link_role,
-                "numchild": 0,
-                "nb_accesses": 2,
-                "path": child2.path,
-                "title": child2.title,
-                "updated_at": child2.updated_at.isoformat().replace("+00:00", "Z"),
-                "user_roles": [access.role],
-            },
-        ],
-    }
-
-
-def test_api_documents_children_list_authenticated_related_parent():
-    """
-    Authenticated users should be allowed to retrieve the children of a document if they
-    are related to one of its ancestors whatever the role.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    grand_parent = factories.DocumentFactory(link_reach="restricted")
-    parent = factories.DocumentFactory(parent=grand_parent, link_reach="restricted")
-    document = factories.DocumentFactory(parent=parent, link_reach="restricted")
-
-    child1, child2 = factories.DocumentFactory.create_batch(2, parent=document)
-    factories.UserDocumentAccessFactory(document=child1)
-
-    grand_parent_access = factories.UserDocumentAccessFactory(
-        document=grand_parent, user=user
-    )
-
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/children/",
-    )
-    assert response.status_code == 200
-    assert response.json() == {
-        "count": 2,
-        "next": None,
-        "previous": None,
-        "results": [
-            {
-                "abilities": child1.get_abilities(user),
-                "created_at": child1.created_at.isoformat().replace("+00:00", "Z"),
-                "creator": str(child1.creator.id),
-                "depth": 4,
-                "excerpt": child1.excerpt,
-                "id": str(child1.id),
-                "is_favorite": False,
-                "link_reach": child1.link_reach,
-                "link_role": child1.link_role,
-                "numchild": 0,
-                "nb_accesses": 2,
-                "path": child1.path,
-                "title": child1.title,
-                "updated_at": child1.updated_at.isoformat().replace("+00:00", "Z"),
-                "user_roles": [grand_parent_access.role],
-            },
-            {
-                "abilities": child2.get_abilities(user),
-                "created_at": child2.created_at.isoformat().replace("+00:00", "Z"),
-                "creator": str(child2.creator.id),
-                "depth": 4,
-                "excerpt": child2.excerpt,
-                "id": str(child2.id),
-                "is_favorite": False,
-                "link_reach": child2.link_reach,
-                "link_role": child2.link_role,
-                "numchild": 0,
-                "nb_accesses": 1,
-                "path": child2.path,
-                "title": child2.title,
-                "updated_at": child2.updated_at.isoformat().replace("+00:00", "Z"),
-                "user_roles": [grand_parent_access.role],
-            },
-        ],
-    }
-
-
-def test_api_documents_children_list_authenticated_related_child():
-    """
-    Authenticated users should not be allowed to retrieve all the children of a document
-    as a result of being related to one of its children.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach="restricted")
-    child1, _child2 = factories.DocumentFactory.create_batch(2, parent=document)
-
-    factories.UserDocumentAccessFactory(document=child1, user=user)
-    factories.UserDocumentAccessFactory(document=document)
-
-    response = client.get(
-        f"/api/v1.0/documents/{document.id!s}/children/",
-    )
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-
-def test_api_documents_children_list_authenticated_related_team_none(mock_user_teams):
-    """
-    Authenticated users should not be able to retrieve the children of a restricted document
-    related to teams in which the user is not.
-    """
-    mock_user_teams.return_value = []
-
-    user = factories.UserFactory(with_owned_document=True)
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach="restricted")
-    factories.DocumentFactory.create_batch(2, parent=document)
-
-    factories.TeamDocumentAccessFactory(document=document, team="myteam")
-
-    response = client.get(f"/api/v1.0/documents/{document.id!s}/children/")
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-
-def test_api_documents_children_list_authenticated_related_team_members(
-    mock_user_teams,
-):
-    """
-    Authenticated users should be allowed to retrieve the children of a document to which they
-    are related via a team whatever the role.
-    """
-    mock_user_teams.return_value = ["myteam"]
-
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(link_reach="restricted")
-    child1, child2 = factories.DocumentFactory.create_batch(2, parent=document)
-
-    access = factories.TeamDocumentAccessFactory(document=document, team="myteam")
-
-    response = client.get(f"/api/v1.0/documents/{document.id!s}/children/")
-
-    # pylint: disable=R0801
-    assert response.status_code == 200
-    assert response.json() == {
-        "count": 2,
-        "next": None,
-        "previous": None,
-        "results": [
-            {
-                "abilities": child1.get_abilities(user),
-                "created_at": child1.created_at.isoformat().replace("+00:00", "Z"),
-                "creator": str(child1.creator.id),
-                "depth": 2,
-                "excerpt": child1.excerpt,
-                "id": str(child1.id),
-                "is_favorite": False,
-                "link_reach": child1.link_reach,
-                "link_role": child1.link_role,
-                "numchild": 0,
-                "nb_accesses": 1,
-                "path": child1.path,
-                "title": child1.title,
-                "updated_at": child1.updated_at.isoformat().replace("+00:00", "Z"),
-                "user_roles": [access.role],
-            },
-            {
-                "abilities": child2.get_abilities(user),
-                "created_at": child2.created_at.isoformat().replace("+00:00", "Z"),
-                "creator": str(child2.creator.id),
-                "depth": 2,
-                "excerpt": child2.excerpt,
-                "id": str(child2.id),
-                "is_favorite": False,
-                "link_reach": child2.link_reach,
-                "link_role": child2.link_role,
-                "numchild": 0,
-                "nb_accesses": 1,
-                "path": child2.path,
-                "title": child2.title,
-                "updated_at": child2.updated_at.isoformat().replace("+00:00", "Z"),
-                "user_roles": [access.role],
-            },
-        ],
-    }

src/backend/core/tests/documents/test_api_documents_create.py

@@ -47,7 +47,6 @@ def test_api_documents_create_authenticated_success():
     assert response.status_code == 201
     document = Document.objects.get()
     assert document.title == "my document"
-    assert document.link_reach == "restricted"
     assert document.accesses.filter(role="owner", user=user).exists()
 
 

src/backend/core/tests/documents/test_api_documents_create_for_owner.py

@@ -1,575 +0,0 @@
-"""
-Tests for Documents API endpoint in impress's core app: create
-"""
-
-# pylint: disable=W0621
-
-from unittest.mock import patch
-
-from django.core import mail
-from django.test import override_settings
-
-import pytest
-from rest_framework.test import APIClient
-
-from core import factories
-from core.api.serializers import ServerCreateDocumentSerializer
-from core.models import Document, Invitation, User
-from core.services.converter_services import ConversionError, YdocConverter
-
-pytestmark = pytest.mark.django_db
-
-
-@pytest.fixture
-def mock_convert_md():
-    """Mock YdocConverter.convert_markdown to return a converted content."""
-    with patch.object(
-        YdocConverter,
-        "convert_markdown",
-        return_value="Converted document content",
-    ) as mock:
-        yield mock
-
-
-def test_api_documents_create_for_owner_missing_token():
-    """Requests with no token should not be allowed to create documents for owner."""
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": "john.doe@example.com",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/", data, format="json"
-    )
-
-    assert response.status_code == 401
-    assert not Document.objects.exists()
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_invalid_token():
-    """Requests with an invalid token should not be allowed to create documents for owner."""
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": "john.doe@example.com",
-        "language": "fr",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer InvalidToken",
-    )
-
-    assert response.status_code == 401
-    assert not Document.objects.exists()
-
-
-def test_api_documents_create_for_owner_authenticated_forbidden():
-    """
-    Authenticated users should not be allowed to call create documents on behalf of other users.
-    This API endpoint is reserved for server-to-server calls.
-    """
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": "john.doe@example.com",
-    }
-
-    response = client.post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-    )
-
-    assert response.status_code == 401
-    assert not Document.objects.exists()
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_missing_sub():
-    """Requests with no sub should not be allowed to create documents for owner."""
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "email": "john.doe@example.com",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 400
-    assert not Document.objects.exists()
-
-    assert response.json() == {"sub": ["This field is required."]}
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_missing_email():
-    """Requests with no email should not be allowed to create documents for owner."""
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 400
-    assert not Document.objects.exists()
-
-    assert response.json() == {"email": ["This field is required."]}
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_invalid_sub():
-    """Requests with an invalid sub should not be allowed to create documents for owner."""
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123!!",
-        "email": "john.doe@example.com",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 400
-    assert not Document.objects.exists()
-
-    assert response.json() == {
-        "sub": [
-            "Enter a valid sub. This value may contain only letters, "
-            "numbers, and @/./+/-/_/: characters."
-        ]
-    }
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_existing(mock_convert_md):
-    """
-    It should be possible to create a document on behalf of a pre-existing user
-    by passing their sub and email.
-    """
-    user = factories.UserFactory(language="en-us")
-
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": str(user.sub),
-        "email": "irrelevant@example.com",  # Should be ignored since the user already exists
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 201
-
-    mock_convert_md.assert_called_once_with("Document content")
-
-    document = Document.objects.get()
-    assert response.json() == {"id": str(document.id)}
-
-    assert document.title == "My Document"
-    assert document.content == "Converted document content"
-    assert document.creator == user
-    assert document.accesses.filter(user=user, role="owner").exists()
-
-    assert Invitation.objects.exists() is False
-
-    assert len(mail.outbox) == 1
-    email = mail.outbox[0]
-    assert email.to == [user.email]
-    assert email.subject == "A new document was created on your behalf!"
-    email_content = " ".join(email.body.split())
-    assert "A new document was created on your behalf!" in email_content
-    assert (
-        "You have been granted ownership of a new document: My Document"
-    ) in email_content
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_new_user(mock_convert_md):
-    """
-    It should be possible to create a document on behalf of new users by
-    passing their unknown sub and email address.
-    """
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": "john.doe@example.com",  # Should be used to create a new user
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 201
-
-    mock_convert_md.assert_called_once_with("Document content")
-
-    document = Document.objects.get()
-    assert response.json() == {"id": str(document.id)}
-
-    assert document.title == "My Document"
-    assert document.content == "Converted document content"
-    assert document.creator is None
-    assert document.accesses.exists() is False
-
-    invitation = Invitation.objects.get()
-    assert invitation.email == "john.doe@example.com"
-    assert invitation.role == "owner"
-
-    assert len(mail.outbox) == 1
-    email = mail.outbox[0]
-    assert email.to == ["john.doe@example.com"]
-    assert email.subject == "A new document was created on your behalf!"
-    email_content = " ".join(email.body.split())
-    assert "A new document was created on your behalf!" in email_content
-    assert (
-        "You have been granted ownership of a new document: My Document"
-    ) in email_content
-
-    # The creator field on the document should be set when the user is created
-    user = User.objects.create(email="john.doe@example.com", password="!")
-    document.refresh_from_db()
-    assert document.creator == user
-
-
-@override_settings(
-    SERVER_TO_SERVER_API_TOKENS=["DummyToken"],
-    OIDC_FALLBACK_TO_EMAIL_FOR_IDENTIFICATION=True,
-)
-def test_api_documents_create_for_owner_existing_user_email_no_sub_with_fallback(
-    mock_convert_md,
-):
-    """
-    It should be possible to create a document on behalf of a pre-existing user for
-    who the sub was not found if the settings allow it. This edge case should not
-    happen in a healthy OIDC federation but can be usefull if an OIDC provider modifies
-    users sub on each login for example...
-    """
-    user = factories.UserFactory(language="en-us")
-
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": user.email,
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 201
-
-    mock_convert_md.assert_called_once_with("Document content")
-
-    document = Document.objects.get()
-    assert response.json() == {"id": str(document.id)}
-
-    assert document.title == "My Document"
-    assert document.content == "Converted document content"
-    assert document.creator == user
-    assert document.accesses.filter(user=user, role="owner").exists()
-
-    assert Invitation.objects.exists() is False
-
-    assert len(mail.outbox) == 1
-    email = mail.outbox[0]
-    assert email.to == [user.email]
-    assert email.subject == "A new document was created on your behalf!"
-    email_content = " ".join(email.body.split())
-    assert "A new document was created on your behalf!" in email_content
-    assert (
-        "You have been granted ownership of a new document: My Document"
-    ) in email_content
-
-
-@override_settings(
-    SERVER_TO_SERVER_API_TOKENS=["DummyToken"],
-    OIDC_FALLBACK_TO_EMAIL_FOR_IDENTIFICATION=False,
-    OIDC_ALLOW_DUPLICATE_EMAILS=False,
-)
-def test_api_documents_create_for_owner_existing_user_email_no_sub_no_fallback(
-    mock_convert_md,
-):
-    """
-    When a user does not match an existing sub and fallback to matching on email is
-    not allowed in settings, it should raise an error if the email is already used by
-    a registered user and duplicate emails are not allowed.
-    """
-    user = factories.UserFactory()
-
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": user.email,
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-    assert response.status_code == 400
-    assert response.json() == {
-        "email": [
-            (
-                "We couldn't find a user with this sub but the email is already "
-                "associated with a registered user."
-            )
-        ]
-    }
-    assert mock_convert_md.called is False
-    assert Document.objects.exists() is False
-    assert Invitation.objects.exists() is False
-    assert len(mail.outbox) == 0
-
-
-@override_settings(
-    SERVER_TO_SERVER_API_TOKENS=["DummyToken"],
-    OIDC_FALLBACK_TO_EMAIL_FOR_IDENTIFICATION=False,
-    OIDC_ALLOW_DUPLICATE_EMAILS=True,
-)
-def test_api_documents_create_for_owner_new_user_no_sub_no_fallback_allow_duplicate(
-    mock_convert_md,
-):
-    """
-    When a user does not match an existing sub and fallback to matching on email is
-    not allowed in settings, it should be possible to create a new user with the same
-    email as an existing user if the settings allow it (identification is still done
-    via the sub in this case).
-    """
-    user = factories.UserFactory()
-
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": user.email,
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-    assert response.status_code == 201
-    mock_convert_md.assert_called_once_with("Document content")
-
-    document = Document.objects.get()
-    assert response.json() == {"id": str(document.id)}
-
-    assert document.title == "My Document"
-    assert document.content == "Converted document content"
-    assert document.creator is None
-    assert document.accesses.exists() is False
-
-    invitation = Invitation.objects.get()
-    assert invitation.email == user.email
-    assert invitation.role == "owner"
-
-    assert len(mail.outbox) == 1
-    email = mail.outbox[0]
-    assert email.to == [user.email]
-    assert email.subject == "A new document was created on your behalf!"
-    email_content = " ".join(email.body.split())
-    assert "A new document was created on your behalf!" in email_content
-    assert (
-        "You have been granted ownership of a new document: My Document"
-    ) in email_content
-
-    # The creator field on the document should be set when the user is created
-    user = User.objects.create(email=user.email, password="!")
-    document.refresh_from_db()
-    assert document.creator == user
-
-
-@patch.object(ServerCreateDocumentSerializer, "_send_email_notification")
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"], LANGUAGE_CODE="de-de")
-def test_api_documents_create_for_owner_with_default_language(
-    mock_send, mock_convert_md
-):
-    """The default language from settings should apply by default."""
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": "john.doe@example.com",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-    assert response.status_code == 201
-
-    mock_convert_md.assert_called_once_with("Document content")
-    assert mock_send.call_args[0][3] == "de-de"
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_with_custom_language(mock_convert_md):
-    """
-    Test creating a document with a specific language.
-    Useful if the remote server knows the user's language.
-    """
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": "john.doe@example.com",
-        "language": "fr-fr",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 201
-
-    mock_convert_md.assert_called_once_with("Document content")
-
-    assert len(mail.outbox) == 1
-    email = mail.outbox[0]
-    assert email.to == ["john.doe@example.com"]
-    assert email.subject == "Un nouveau document a été créé pour vous !"
-    email_content = " ".join(email.body.split())
-    assert "Un nouveau document a été créé pour vous !" in email_content
-    assert (
-        "Vous avez été déclaré propriétaire d'un nouveau document : My Document"
-    ) in email_content
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_with_custom_subject_and_message(
-    mock_convert_md,
-):
-    """It should be possible to customize the subject and message of the invitation email."""
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": "john.doe@example.com",
-        "message": "mon message spécial",
-        "subject": "mon sujet spécial !",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 201
-
-    mock_convert_md.assert_called_once_with("Document content")
-
-    assert len(mail.outbox) == 1
-    email = mail.outbox[0]
-    assert email.to == ["john.doe@example.com"]
-    assert email.subject == "Mon sujet spécial !"
-    email_content = " ".join(email.body.split())
-    assert "Mon sujet spécial !" in email_content
-    assert "Mon message spécial" in email_content
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_with_converter_exception(
-    mock_convert_md,
-):
-    """In case of converter error, a 400 error should be raised."""
-
-    mock_convert_md.side_effect = ConversionError("Conversion failed")
-
-    data = {
-        "title": "My Document",
-        "content": "Document content",
-        "sub": "123",
-        "email": "john.doe@example.com",
-        "message": "mon message spécial",
-        "subject": "mon sujet spécial !",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-    mock_convert_md.assert_called_once_with("Document content")
-
-    assert response.status_code == 400
-    assert response.json() == {"content": ["Could not convert content"]}
-
-
-@override_settings(SERVER_TO_SERVER_API_TOKENS=["DummyToken"])
-def test_api_documents_create_for_owner_with_empty_content():
-    """The content should not be empty or a 400 error should be raised."""
-
-    data = {
-        "title": "My Document",
-        "content": "  ",
-        "sub": "123",
-        "email": "john.doe@example.com",
-    }
-
-    response = APIClient().post(
-        "/api/v1.0/documents/create-for-owner/",
-        data,
-        format="json",
-        HTTP_AUTHORIZATION="Bearer DummyToken",
-    )
-
-    assert response.status_code == 400
-    assert response.json() == {
-        "content": [
-            "This field may not be blank.",
-        ],
-    }

src/backend/core/tests/documents/test_api_documents_delete.py

@@ -77,37 +77,6 @@ def test_api_documents_delete_authenticated_not_owner(via, role, mock_user_teams
     assert models.Document.objects.count() == 2
 
 
-@pytest.mark.parametrize("depth", [1, 2, 3])
-def test_api_documents_delete_authenticated_owner_of_ancestor(depth):
-    """
-    Authenticated users should not be able to delete a document for which
-    they are only owner of an ancestor.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    documents = []
-    for i in range(depth):
-        documents.append(
-            factories.UserDocumentAccessFactory(role="owner", user=user).document
-            if i == 0
-            else factories.DocumentFactory(parent=documents[-1])
-        )
-    assert models.Document.objects.count() == depth
-
-    response = client.delete(
-        f"/api/v1.0/documents/{documents[-1].id}/",
-    )
-
-    assert response.status_code == 204
-
-    # Make sure it is only a soft delete
-    assert models.Document.objects.count() == depth
-    assert models.Document.objects.filter(deleted_at__isnull=True).count() == depth - 1
-    assert models.Document.objects.filter(deleted_at__isnull=False).count() == 1
-
-
 @pytest.mark.parametrize("via", VIA)
 def test_api_documents_delete_authenticated_owner(via, mock_user_teams):
     """
@@ -132,8 +101,4 @@ def test_api_documents_delete_authenticated_owner(via, mock_user_teams):
     )
 
     assert response.status_code == 204
-
-    # Make sure it is only a soft delete
-    assert models.Document.objects.count() == 1
-    assert models.Document.objects.filter(deleted_at__isnull=True).exists() is False
-    assert models.Document.objects.filter(deleted_at__isnull=False).count() == 1
+    assert models.Document.objects.exists() is False

src/backend/core/tests/documents/test_api_documents_favorite.py

@@ -1,308 +0,0 @@
-"""Test favorite document API endpoint for users in impress's core app."""
-
-import pytest
-from rest_framework.test import APIClient
-
-from core import factories, models
-
-pytestmark = pytest.mark.django_db
-
-
-@pytest.mark.parametrize(
-    "reach",
-    [
-        "restricted",
-        "authenticated",
-        "public",
-    ],
-)
-@pytest.mark.parametrize("method", ["post", "delete"])
-def test_api_document_favorite_anonymous_user(method, reach):
-    """Anonymous users should not be able to mark/unmark documents as favorites."""
-    document = factories.DocumentFactory(link_reach=reach)
-
-    response = getattr(APIClient(), method)(
-        f"/api/v1.0/documents/{document.id!s}/favorite/"
-    )
-
-    assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
-
-    # Verify in database
-    assert models.DocumentFavorite.objects.exists() is False
-
-
-@pytest.mark.parametrize(
-    "reach, has_role",
-    [
-        ["restricted", True],
-        ["authenticated", False],
-        ["authenticated", True],
-        ["public", False],
-        ["public", True],
-    ],
-)
-def test_api_document_favorite_authenticated_post_allowed(reach, has_role):
-    """Authenticated users should be able to mark a document as favorite using POST."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach=reach)
-    client = APIClient()
-    client.force_login(user)
-
-    if has_role:
-        models.DocumentAccess.objects.create(document=document, user=user)
-
-    # Mark as favorite
-    response = client.post(f"/api/v1.0/documents/{document.id!s}/favorite/")
-
-    assert response.status_code == 201
-    assert response.json() == {"detail": "Document marked as favorite"}
-
-    # Verify in database
-    assert models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-
-    # Verify document format
-    response = client.get(f"/api/v1.0/documents/{document.id!s}/")
-    assert response.json()["is_favorite"] is True
-
-
-def test_api_document_favorite_authenticated_post_forbidden():
-    """Authenticated users should be able to mark a document as favorite using POST."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach="restricted")
-    client = APIClient()
-    client.force_login(user)
-
-    # Try marking as favorite
-    response = client.post(f"/api/v1.0/documents/{document.id!s}/favorite/")
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-    # Verify in database
-    assert (
-        models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-        is False
-    )
-
-
-@pytest.mark.parametrize(
-    "reach, has_role",
-    [
-        ["restricted", True],
-        ["authenticated", False],
-        ["authenticated", True],
-        ["public", False],
-        ["public", True],
-    ],
-)
-def test_api_document_favorite_authenticated_post_already_favorited_allowed(
-    reach, has_role
-):
-    """POST should not create duplicate favorites if already marked."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach=reach, favorited_by=[user])
-    client = APIClient()
-    client.force_login(user)
-
-    if has_role:
-        models.DocumentAccess.objects.create(document=document, user=user)
-
-    # Try to mark as favorite again
-    response = client.post(f"/api/v1.0/documents/{document.id!s}/favorite/")
-
-    assert response.status_code == 200
-    assert response.json() == {"detail": "Document already marked as favorite"}
-
-    # Verify in database
-    assert models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-
-    # Verify document format
-    response = client.get(f"/api/v1.0/documents/{document.id!s}/")
-    assert response.json()["is_favorite"] is True
-
-
-def test_api_document_favorite_authenticated_post_already_favorited_forbidden():
-    """POST should not create duplicate favorites if already marked."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach="restricted", favorited_by=[user])
-    client = APIClient()
-    client.force_login(user)
-
-    # Try to mark as favorite again
-    response = client.post(f"/api/v1.0/documents/{document.id!s}/favorite/")
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-    # Verify in database
-    assert models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-
-
-@pytest.mark.parametrize(
-    "reach, has_role",
-    [
-        ["restricted", True],
-        ["authenticated", False],
-        ["authenticated", True],
-        ["public", False],
-        ["public", True],
-    ],
-)
-def test_api_document_favorite_authenticated_delete_allowed(reach, has_role):
-    """Authenticated users should be able to unmark a document as favorite using DELETE."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach=reach, favorited_by=[user])
-    client = APIClient()
-    client.force_login(user)
-
-    if has_role:
-        models.DocumentAccess.objects.create(document=document, user=user)
-
-    # Unmark as favorite
-    response = client.delete(f"/api/v1.0/documents/{document.id!s}/favorite/")
-    assert response.status_code == 204
-
-    # Verify in database
-    assert (
-        models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-        is False
-    )
-
-    # Verify document format
-    response = client.get(f"/api/v1.0/documents/{document.id!s}/")
-    assert response.json()["is_favorite"] is False
-
-
-def test_api_document_favorite_authenticated_delete_forbidden():
-    """Authenticated users should be able to unmark a document as favorite using DELETE."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach="restricted", favorited_by=[user])
-    client = APIClient()
-    client.force_login(user)
-
-    # Unmark as favorite
-    response = client.delete(f"/api/v1.0/documents/{document.id!s}/favorite/")
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-    # Verify in database
-    assert (
-        models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-        is True
-    )
-
-
-@pytest.mark.parametrize(
-    "reach, has_role",
-    [
-        ["restricted", True],
-        ["authenticated", False],
-        ["authenticated", True],
-        ["public", False],
-        ["public", True],
-    ],
-)
-def test_api_document_favorite_authenticated_delete_not_favorited_allowed(
-    reach, has_role
-):
-    """DELETE should be idempotent if the document is not marked as favorite."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach=reach)
-    client = APIClient()
-    client.force_login(user)
-
-    if has_role:
-        models.DocumentAccess.objects.create(document=document, user=user)
-
-    # Try to unmark as favorite when no favorite entry exists
-    response = client.delete(f"/api/v1.0/documents/{document.id!s}/favorite/")
-
-    assert response.status_code == 200
-    assert response.json() == {"detail": "Document was already not marked as favorite"}
-
-    # Verify in database
-    assert (
-        models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-        is False
-    )
-
-    # Verify document format
-    response = client.get(f"/api/v1.0/documents/{document.id!s}/")
-    assert response.json()["is_favorite"] is False
-
-
-def test_api_document_favorite_authenticated_delete_not_favorited_forbidden():
-    """DELETE should be idempotent if the document is not marked as favorite."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach="restricted")
-    client = APIClient()
-    client.force_login(user)
-
-    # Try to unmark as favorite when no favorite entry exists
-    response = client.delete(f"/api/v1.0/documents/{document.id!s}/favorite/")
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-    # Verify in database
-    assert (
-        models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-        is False
-    )
-
-
-@pytest.mark.parametrize(
-    "reach, has_role",
-    [
-        ["restricted", True],
-        ["authenticated", False],
-        ["authenticated", True],
-        ["public", False],
-        ["public", True],
-    ],
-)
-def test_api_document_favorite_authenticated_post_unmark_then_mark_again_allowed(
-    reach, has_role
-):
-    """A user should be able to mark, unmark, and mark a document again as favorite."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(link_reach=reach)
-    client = APIClient()
-    client.force_login(user)
-
-    if has_role:
-        models.DocumentAccess.objects.create(document=document, user=user)
-
-    url = f"/api/v1.0/documents/{document.id!s}/favorite/"
-
-    # Mark as favorite
-    response = client.post(url)
-    assert response.status_code == 201
-
-    # Unmark as favorite
-    response = client.delete(url)
-    assert response.status_code == 204
-
-    # Mark as favorite again
-    response = client.post(url)
-    assert response.status_code == 201
-    assert response.json() == {"detail": "Document marked as favorite"}
-
-    # Verify in database
-    assert models.DocumentFavorite.objects.filter(document=document, user=user).exists()
-
-    # Verify document format
-    response = client.get(f"/api/v1.0/documents/{document.id!s}/")
-    assert response.json()["is_favorite"] is True

src/backend/core/tests/documents/test_api_documents_link_configuration.py

@@ -6,9 +6,6 @@ from rest_framework.test import APIClient
 from core import factories, models
 from core.api import serializers
 from core.tests.conftest import TEAM, USER, VIA
-from core.tests.test_services_collaboration_services import (  # pylint: disable=unused-import
-    mock_reset_connections,
-)
 
 pytestmark = pytest.mark.django_db
 
@@ -119,10 +116,7 @@ def test_api_documents_link_configuration_update_authenticated_related_forbidden
 @pytest.mark.parametrize("role", ["administrator", "owner"])
 @pytest.mark.parametrize("via", VIA)
 def test_api_documents_link_configuration_update_authenticated_related_success(
-    via,
-    role,
-    mock_user_teams,
-    mock_reset_connections,  # pylint: disable=redefined-outer-name
+    via, role, mock_user_teams
 ):
     """
     A user who is administrator or owner of a document should be allowed to update
@@ -145,16 +139,14 @@ def test_api_documents_link_configuration_update_authenticated_related_success(
     new_document_values = serializers.LinkDocumentSerializer(
         instance=factories.DocumentFactory()
     ).data
+    response = client.put(
+        f"/api/v1.0/documents/{document.id!s}/link-configuration/",
+        new_document_values,
+        format="json",
+    )
+    assert response.status_code == 200
 
-    with mock_reset_connections(document.id):
-        response = client.put(
-            f"/api/v1.0/documents/{document.id!s}/link-configuration/",
-            new_document_values,
-            format="json",
-        )
-        assert response.status_code == 200
-
-        document = models.Document.objects.get(pk=document.pk)
-        document_values = serializers.LinkDocumentSerializer(instance=document).data
-        for key, value in document_values.items():
-            assert value == new_document_values[key]
+    document = models.Document.objects.get(pk=document.pk)
+    document_values = serializers.LinkDocumentSerializer(instance=document).data
+    for key, value in document_values.items():
+        assert value == new_document_values[key]

src/backend/core/tests/documents/test_api_documents_list.py

@@ -2,12 +2,9 @@
 Tests for Documents API endpoint in impress's core app: list
 """
 
-import random
-from datetime import timedelta
+import operator
 from unittest import mock
 
-from django.utils import timezone
-
 import pytest
 from faker import Faker
 from rest_framework.pagination import PageNumberPagination
@@ -24,7 +21,7 @@ pytestmark = pytest.mark.django_db
 def test_api_documents_list_anonymous(reach, role):
     """
     Anonymous users should not be allowed to list documents whatever the
-    link reach and link role
+    link reach and the role
     """
     factories.DocumentFactory(link_reach=reach, link_role=role)
 
@@ -35,62 +32,18 @@ def test_api_documents_list_anonymous(reach, role):
     assert len(results) == 0
 
 
-def test_api_documents_list_format():
-    """Validate the format of documents as returned by the list view."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    other_users = factories.UserFactory.create_batch(3)
-    document = factories.DocumentFactory(
-        users=factories.UserFactory.create_batch(2),
-        favorited_by=[user, *other_users],
-        link_traces=other_users,
-    )
-    access = factories.UserDocumentAccessFactory(document=document, user=user)
-
-    response = client.get("/api/v1.0/documents/")
-
-    assert response.status_code == 200
-    content = response.json()
-    results = content.pop("results")
-    assert content == {
-        "count": 1,
-        "next": None,
-        "previous": None,
-    }
-    assert len(results) == 1
-    assert results[0] == {
-        "id": str(document.id),
-        "abilities": document.get_abilities(user),
-        "created_at": document.created_at.isoformat().replace("+00:00", "Z"),
-        "creator": str(document.creator.id),
-        "depth": 1,
-        "excerpt": document.excerpt,
-        "is_favorite": True,
-        "link_reach": document.link_reach,
-        "link_role": document.link_role,
-        "nb_accesses": 3,
-        "numchild": 0,
-        "path": document.path,
-        "title": document.title,
-        "updated_at": document.updated_at.isoformat().replace("+00:00", "Z"),
-        "user_roles": [access.role],
-    }
-
-
-# pylint: disable=too-many-locals
-def test_api_documents_list_authenticated_direct(django_assert_num_queries):
+def test_api_documents_list_authenticated_direct():
     """
     Authenticated users should be able to list documents they are a direct
     owner/administrator/member of or documents that have a link reach other
     than restricted.
     """
     user = factories.UserFactory()
+
     client = APIClient()
     client.force_login(user)
 
-    document1, document2 = [
+    documents = [
         access.document
         for access in factories.UserDocumentAccessFactory.create_batch(2, user=user)
     ]
@@ -100,69 +53,20 @@ def test_api_documents_list_authenticated_direct(django_assert_num_queries):
         for role in models.LinkRoleChoices:
             factories.DocumentFactory(link_reach=reach, link_role=role)
 
-    # Children of visible documents should not get listed even with a specific access
-    factories.DocumentFactory(parent=document1)
+    expected_ids = {str(document.id) for document in documents}
 
-    child1_with_access = factories.DocumentFactory(parent=document1)
-    factories.UserDocumentAccessFactory(user=user, document=child1_with_access)
-
-    middle_document = factories.DocumentFactory(parent=document2)
-    child2_with_access = factories.DocumentFactory(parent=middle_document)
-    factories.UserDocumentAccessFactory(user=user, document=child2_with_access)
-
-    # Children of hidden documents should get listed when visible by the logged-in user
-    hidden_root = factories.DocumentFactory()
-    child3_with_access = factories.DocumentFactory(parent=hidden_root)
-    factories.UserDocumentAccessFactory(user=user, document=child3_with_access)
-    child4_with_access = factories.DocumentFactory(parent=hidden_root)
-    factories.UserDocumentAccessFactory(user=user, document=child4_with_access)
-
-    # Documents that are soft deleted and children of a soft deleted document should not be listed
-    soft_deleted_document = factories.DocumentFactory(users=[user])
-    child_of_soft_deleted_document = factories.DocumentFactory(
-        users=[user],
-        parent=soft_deleted_document,
+    response = client.get(
+        "/api/v1.0/documents/",
     )
-    factories.DocumentFactory(users=[user], parent=child_of_soft_deleted_document)
-    soft_deleted_document.soft_delete()
-
-    # Documents that are permanently deleted and children of a permanently deleted
-    # document should not be listed
-    permanently_deleted_document = factories.DocumentFactory(users=[user])
-    child_of_permanently_deleted_document = factories.DocumentFactory(
-        users=[user], parent=permanently_deleted_document
-    )
-    factories.DocumentFactory(
-        users=[user], parent=child_of_permanently_deleted_document
-    )
-
-    fourty_days_ago = timezone.now() - timedelta(days=40)
-    with mock.patch("django.utils.timezone.now", return_value=fourty_days_ago):
-        permanently_deleted_document.soft_delete()
-
-    expected_ids = {
-        str(document1.id),
-        str(document2.id),
-        str(child3_with_access.id),
-        str(child4_with_access.id),
-    }
-
-    with django_assert_num_queries(8):
-        response = client.get("/api/v1.0/documents/")
-
-    # nb_accesses should now be cached
-    with django_assert_num_queries(4):
-        response = client.get("/api/v1.0/documents/")
 
     assert response.status_code == 200
     results = response.json()["results"]
-    results_ids = {result["id"] for result in results}
-    assert expected_ids == results_ids
+    assert len(results) == 2
+    results_id = {result["id"] for result in results}
+    assert expected_ids == results_id
 
 
-def test_api_documents_list_authenticated_via_team(
-    django_assert_num_queries, mock_user_teams
-):
+def test_api_documents_list_authenticated_via_team(mock_user_teams):
     """
     Authenticated users should be able to list documents they are a
     owner/administrator/member of via a team.
@@ -185,12 +89,7 @@ def test_api_documents_list_authenticated_via_team(
 
     expected_ids = {str(document.id) for document in documents_team1 + documents_team2}
 
-    with django_assert_num_queries(9):
-        response = client.get("/api/v1.0/documents/")
-
-    # nb_accesses should now be cached
-    with django_assert_num_queries(4):
-        response = client.get("/api/v1.0/documents/")
+    response = client.get("/api/v1.0/documents/")
 
     assert response.status_code == 200
     results = response.json()["results"]
@@ -199,9 +98,7 @@ def test_api_documents_list_authenticated_via_team(
     assert expected_ids == results_id
 
 
-def test_api_documents_list_authenticated_link_reach_restricted(
-    django_assert_num_queries,
-):
+def test_api_documents_list_authenticated_link_reach_restricted():
     """
     An authenticated user who has link traces to a document that is restricted should not
     see it on the list view
@@ -218,12 +115,9 @@ def test_api_documents_list_authenticated_link_reach_restricted(
     other_document = factories.DocumentFactory(link_reach="public")
     models.LinkTrace.objects.create(document=other_document, user=user)
 
-    with django_assert_num_queries(5):
-        response = client.get("/api/v1.0/documents/")
-
-    # nb_accesses should now be cached
-    with django_assert_num_queries(4):
-        response = client.get("/api/v1.0/documents/")
+    response = client.get(
+        "/api/v1.0/documents/",
+    )
 
     assert response.status_code == 200
     results = response.json()["results"]
@@ -233,9 +127,7 @@ def test_api_documents_list_authenticated_link_reach_restricted(
     assert results[0]["id"] == str(other_document.id)
 
 
-def test_api_documents_list_authenticated_link_reach_public_or_authenticated(
-    django_assert_num_queries,
-):
+def test_api_documents_list_authenticated_link_reach_public_or_authenticated():
     """
     An authenticated user who has link traces to a document with public or authenticated
     link reach should see it on the list view.
@@ -245,37 +137,20 @@ def test_api_documents_list_authenticated_link_reach_public_or_authenticated(
     client = APIClient()
     client.force_login(user)
 
-    document1, document2 = [
+    documents = [
         factories.DocumentFactory(link_traces=[user], link_reach=reach)
         for reach in models.LinkReachChoices
         if reach != "restricted"
     ]
-    factories.DocumentFactory(
-        link_reach=random.choice(["public", "authenticated"]),
-        link_traces=[user],
-        parent=document1,
+    expected_ids = {str(document.id) for document in documents}
+
+    response = client.get(
+        "/api/v1.0/documents/",
     )
 
-    hidden_document = factories.DocumentFactory(
-        link_reach=random.choice(["public", "authenticated"])
-    )
-    visible_child = factories.DocumentFactory(
-        link_traces=[user],
-        link_reach=random.choice(["public", "authenticated"]),
-        parent=hidden_document,
-    )
-
-    expected_ids = {str(document1.id), str(document2.id), str(visible_child.id)}
-
-    with django_assert_num_queries(7):
-        response = client.get("/api/v1.0/documents/")
-
-    # nb_accesses should now be cached
-    with django_assert_num_queries(4):
-        response = client.get("/api/v1.0/documents/")
-
     assert response.status_code == 200
     results = response.json()["results"]
+    assert len(results) == 2
     results_id = {result["id"] for result in results}
     assert expected_ids == results_id
 
@@ -349,47 +224,51 @@ def test_api_documents_list_authenticated_distinct():
     assert content["results"][0]["id"] == str(document.id)
 
 
-def test_api_documents_list_favorites_no_extra_queries(django_assert_num_queries):
-    """
-    Ensure that marking documents as favorite does not generate additional queries
-    when fetching the document list.
-    """
+def test_api_documents_list_ordering_default():
+    """Documents should be ordered by descending "updated_at" by default"""
     user = factories.UserFactory()
     client = APIClient()
     client.force_login(user)
 
-    special_documents = factories.DocumentFactory.create_batch(3, users=[user])
-    factories.DocumentFactory.create_batch(2, users=[user])
+    factories.DocumentFactory.create_batch(5, users=[user])
 
-    url = "/api/v1.0/documents/"
-    with django_assert_num_queries(9):
-        response = client.get(url)
-
-    # nb_accesses should now be cached
-    with django_assert_num_queries(4):
-        response = client.get(url)
+    response = client.get("/api/v1.0/documents/")
 
     assert response.status_code == 200
     results = response.json()["results"]
     assert len(results) == 5
 
-    assert all(result["is_favorite"] is False for result in results)
+    # Check that results are sorted by descending "updated_at" as expected
+    for i in range(4):
+        assert operator.ge(results[i]["updated_at"], results[i + 1]["updated_at"])
 
-    # Mark documents as favorite and check results again
-    for document in special_documents:
-        models.DocumentFavorite.objects.create(document=document, user=user)
 
-    with django_assert_num_queries(4):
-        response = client.get(url)
+def test_api_documents_list_ordering_by_fields():
+    """It should be possible to order by several fields"""
+    user = factories.UserFactory()
+    client = APIClient()
+    client.force_login(user)
 
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 5
+    factories.DocumentFactory.create_batch(5, users=[user])
 
-    # Check if the "is_favorite" annotation is correctly set for the favorited documents
-    favorited_ids = {str(doc.id) for doc in special_documents}
-    for result in results:
-        if result["id"] in favorited_ids:
-            assert result["is_favorite"] is True
-        else:
-            assert result["is_favorite"] is False
+    for parameter in [
+        "created_at",
+        "-created_at",
+        "updated_at",
+        "-updated_at",
+        "title",
+        "-title",
+    ]:
+        is_descending = parameter.startswith("-")
+        field = parameter.lstrip("-")
+        querystring = f"?ordering={parameter}"
+
+        response = client.get(f"/api/v1.0/documents/{querystring:s}")
+        assert response.status_code == 200
+        results = response.json()["results"]
+        assert len(results) == 5
+
+        # Check that results are sorted by the field in querystring as expected
+        compare = operator.ge if is_descending else operator.le
+        for i in range(4):
+            assert compare(results[i][field], results[i + 1][field])

src/backend/core/tests/documents/test_api_documents_list_filters.py

@@ -1,356 +0,0 @@
-"""
-Tests for Documents API endpoint in impress's core app: list
-"""
-
-import operator
-import random
-from urllib.parse import urlencode
-
-import pytest
-from faker import Faker
-from rest_framework.test import APIClient
-
-from core import factories, models
-
-fake = Faker()
-pytestmark = pytest.mark.django_db
-
-
-def test_api_documents_list_filter_and_access_rights():
-    """Filtering on querystring parameters should respect access rights."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    other_user = factories.UserFactory()
-
-    def random_favorited_by():
-        return random.choice([[], [user], [other_user]])
-
-    # Documents that should be listed to this user
-    listed_documents = [
-        factories.DocumentFactory(
-            link_reach="public",
-            link_traces=[user],
-            favorited_by=random_favorited_by(),
-            creator=random.choice([user, other_user]),
-        ),
-        factories.DocumentFactory(
-            link_reach="authenticated",
-            link_traces=[user],
-            favorited_by=random_favorited_by(),
-            creator=random.choice([user, other_user]),
-        ),
-        factories.DocumentFactory(
-            link_reach="restricted",
-            users=[user],
-            favorited_by=random_favorited_by(),
-            creator=random.choice([user, other_user]),
-        ),
-    ]
-    listed_ids = [str(doc.id) for doc in listed_documents]
-    word_list = [word for doc in listed_documents for word in doc.title.split(" ")]
-
-    # Documents that should not be listed to this user
-    factories.DocumentFactory(
-        link_reach="public",
-        favorited_by=random_favorited_by(),
-        creator=random.choice([user, other_user]),
-    )
-    factories.DocumentFactory(
-        link_reach="authenticated",
-        favorited_by=random_favorited_by(),
-        creator=random.choice([user, other_user]),
-    )
-    factories.DocumentFactory(
-        link_reach="restricted",
-        favorited_by=random_favorited_by(),
-        creator=random.choice([user, other_user]),
-    )
-    factories.DocumentFactory(
-        link_reach="restricted",
-        link_traces=[user],
-        favorited_by=random_favorited_by(),
-        creator=random.choice([user, other_user]),
-    )
-
-    filters = {
-        "link_reach": random.choice([None, *models.LinkReachChoices.values]),
-        "title": random.choice([None, *word_list]),
-        "favorite": random.choice([None, True, False]),
-        "creator": random.choice([None, user, other_user]),
-        "ordering": random.choice(
-            [
-                None,
-                "created_at",
-                "-created_at",
-                "is_favorite",
-                "-is_favorite",
-                "title",
-                "-title",
-                "updated_at",
-                "-updated_at",
-            ]
-        ),
-    }
-    query_params = {key: value for key, value in filters.items() if value is not None}
-    querystring = urlencode(query_params)
-
-    response = client.get(f"/api/v1.0/documents/?{querystring:s}")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-
-    # Ensure all documents in results respect expected access rights
-    for result in results:
-        assert result["id"] in listed_ids
-
-
-# Filters: ordering
-
-
-def test_api_documents_list_ordering_default():
-    """Documents should be ordered by descending "updated_at" by default"""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(5, users=[user])
-
-    response = client.get("/api/v1.0/documents/")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 5
-
-    # Check that results are sorted by descending "updated_at" as expected
-    for i in range(4):
-        assert operator.ge(results[i]["updated_at"], results[i + 1]["updated_at"])
-
-
-def test_api_documents_list_ordering_by_fields():
-    """It should be possible to order by several fields"""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(5, users=[user])
-
-    for parameter in [
-        "created_at",
-        "-created_at",
-        "is_favorite",
-        "-is_favorite",
-        "title",
-        "-title",
-        "updated_at",
-        "-updated_at",
-    ]:
-        is_descending = parameter.startswith("-")
-        field = parameter.lstrip("-")
-        querystring = f"?ordering={parameter}"
-
-        response = client.get(f"/api/v1.0/documents/{querystring:s}")
-        assert response.status_code == 200
-        results = response.json()["results"]
-        assert len(results) == 5
-
-        # Check that results are sorted by the field in querystring as expected
-        compare = operator.ge if is_descending else operator.le
-        for i in range(4):
-            assert compare(results[i][field], results[i + 1][field])
-
-
-# Filters: unknown field
-
-
-def test_api_documents_list_filter_unknown_field():
-    """
-    Trying to filter by an unknown field should raise a 400 error.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory()
-    expected_ids = {
-        str(document.id)
-        for document in factories.DocumentFactory.create_batch(2, users=[user])
-    }
-
-    response = client.get("/api/v1.0/documents/?unknown=true")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 2
-    assert {result["id"] for result in results} == expected_ids
-
-
-# Filters: is_creator_me
-
-
-def test_api_documents_list_filter_is_creator_me_true():
-    """
-    Authenticated users should be able to filter documents they created.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(3, users=[user], creator=user)
-    factories.DocumentFactory.create_batch(2, users=[user])
-
-    response = client.get("/api/v1.0/documents/?is_creator_me=true")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 3
-
-    # Ensure all results are created by the current user
-    for result in results:
-        assert result["creator"] == str(user.id)
-
-
-def test_api_documents_list_filter_is_creator_me_false():
-    """
-    Authenticated users should be able to filter documents created by others.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(3, users=[user], creator=user)
-    factories.DocumentFactory.create_batch(2, users=[user])
-
-    response = client.get("/api/v1.0/documents/?is_creator_me=false")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 2
-
-    # Ensure all results are created by other users
-    for result in results:
-        assert result["creator"] != str(user.id)
-
-
-def test_api_documents_list_filter_is_creator_me_invalid():
-    """Filtering with an invalid `is_creator_me` value should do nothing."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(3, users=[user], creator=user)
-    factories.DocumentFactory.create_batch(2, users=[user])
-
-    response = client.get("/api/v1.0/documents/?is_creator_me=invalid")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 5
-
-
-# Filters: is_favorite
-
-
-def test_api_documents_list_filter_is_favorite_true():
-    """
-    Authenticated users should be able to filter documents they marked as favorite.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(3, users=[user], favorited_by=[user])
-    factories.DocumentFactory.create_batch(2, users=[user])
-
-    response = client.get("/api/v1.0/documents/?is_favorite=true")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 3
-
-    # Ensure all results are marked as favorite by the current user
-    for result in results:
-        assert result["is_favorite"] is True
-
-
-def test_api_documents_list_filter_is_favorite_false():
-    """
-    Authenticated users should be able to filter documents they didn't mark as favorite.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(3, users=[user], favorited_by=[user])
-    factories.DocumentFactory.create_batch(2, users=[user])
-
-    response = client.get("/api/v1.0/documents/?is_favorite=false")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 2
-
-    # Ensure all results are not marked as favorite by the current user
-    for result in results:
-        assert result["is_favorite"] is False
-
-
-def test_api_documents_list_filter_is_favorite_invalid():
-    """Filtering with an invalid `is_favorite` value should do nothing."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    factories.DocumentFactory.create_batch(3, users=[user], favorited_by=[user])
-    factories.DocumentFactory.create_batch(2, users=[user])
-
-    response = client.get("/api/v1.0/documents/?is_favorite=invalid")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 5
-
-
-# Filters: title
-
-
-@pytest.mark.parametrize(
-    "query,nb_results",
-    [
-        ("Project Alpha", 1),  # Exact match
-        ("project", 2),  # Partial match (case-insensitive)
-        ("Guide", 1),  # Word match within a title
-        ("Special", 0),  # No match (nonexistent keyword)
-        ("2024", 2),  # Match by numeric keyword
-        ("", 5),  # Empty string
-    ],
-)
-def test_api_documents_list_filter_title(query, nb_results):
-    """Authenticated users should be able to search documents by their title."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    # Create documents with predefined titles
-    titles = [
-        "Project Alpha Documentation",
-        "Project Beta Overview",
-        "User Guide",
-        "Financial Report 2024",
-        "Annual Review 2024",
-    ]
-    for title in titles:
-        parent = factories.DocumentFactory() if random.choice([True, False]) else None
-        factories.DocumentFactory(title=title, users=[user], parent=parent)
-
-    # Perform the search query
-    response = client.get(f"/api/v1.0/documents/?title={query:s}")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == nb_results
-
-    # Ensure all results contain the query in their title
-    for result in results:
-        assert query.lower().strip() in result["title"].lower()

src/backend/core/tests/documents/test_api_documents_move.py

@@ -1,339 +0,0 @@
-"""
-Test moving documents within the document tree via an detail action API endpoint.
-"""
-
-import random
-from uuid import uuid4
-
-from django.utils import timezone
-
-import pytest
-from rest_framework.test import APIClient
-
-from core import enums, factories, models
-
-pytestmark = pytest.mark.django_db
-
-
-def test_api_documents_move_anonymous_user():
-    """Anonymous users should not be able to move documents."""
-    document = factories.DocumentFactory()
-    target = factories.DocumentFactory()
-
-    response = APIClient().post(
-        f"/api/v1.0/documents/{document.id!s}/move/",
-        data={"target_document_id": str(target.id)},
-    )
-
-    assert response.status_code == 401
-    assert response.json() == {
-        "detail": "Authentication credentials were not provided."
-    }
-
-
-@pytest.mark.parametrize("role", [None, "reader", "editor"])
-def test_api_documents_move_authenticated_document_no_permission(role):
-    """
-    Authenticated users should not be able to move documents with insufficient
-    permissions on the origin document.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory()
-    target = factories.UserDocumentAccessFactory(user=user, role="owner").document
-
-    if role:
-        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/move/",
-        data={"target_document_id": str(target.id)},
-    )
-
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-
-def test_api_documents_move_invalid_target_string():
-    """Test for moving a document to an invalid target as a random string."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.UserDocumentAccessFactory(user=user, role="owner").document
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/move/",
-        data={"target_document_id": "non-existent-id"},
-    )
-
-    assert response.status_code == 400
-    assert response.json() == {"target_document_id": ["Must be a valid UUID."]}
-
-
-def test_api_documents_move_invalid_target_uuid():
-    """Test for moving a document to an invalid target that looks like a UUID."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.UserDocumentAccessFactory(user=user, role="owner").document
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/move/",
-        data={"target_document_id": str(uuid4())},
-    )
-
-    assert response.status_code == 400
-    assert response.json() == {
-        "target_document_id": "Target parent document does not exist."
-    }
-
-
-def test_api_documents_move_invalid_position():
-    """Test moving a document to an invalid position."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.UserDocumentAccessFactory(user=user, role="owner").document
-    target = factories.UserDocumentAccessFactory(user=user, role="owner").document
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/move/",
-        data={
-            "target_document_id": str(target.id),
-            "position": "invalid-position",
-        },
-    )
-
-    assert response.status_code == 400
-    assert response.json() == {
-        "position": ['"invalid-position" is not a valid choice.']
-    }
-
-
-@pytest.mark.parametrize("position", enums.MoveNodePositionChoices.values)
-@pytest.mark.parametrize("target_parent_role", models.RoleChoices.values)
-@pytest.mark.parametrize("target_role", models.RoleChoices.values)
-def test_api_documents_move_authenticated_target_roles_mocked(
-    target_role, target_parent_role, position
-):
-    """
-    Authenticated users with insufficient permissions on the target document (or its
-    parent depending on the position chosen), should not be allowed to move documents.
-    """
-
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    power_roles = ["administrator", "owner"]
-
-    document = factories.DocumentFactory(users=[(user, random.choice(power_roles))])
-    children = factories.DocumentFactory.create_batch(3, parent=document)
-
-    target_parent = factories.DocumentFactory(users=[(user, target_parent_role)])
-    sibling1, target, sibling2 = factories.DocumentFactory.create_batch(
-        3, parent=target_parent
-    )
-    models.DocumentAccess.objects.create(document=target, user=user, role=target_role)
-    target_children = factories.DocumentFactory.create_batch(2, parent=target)
-
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/move/",
-        data={"target_document_id": str(target.id), "position": position},
-    )
-
-    document.refresh_from_db()
-
-    if (
-        position in ["first-child", "last-child"]
-        and (target_role in power_roles or target_parent_role in power_roles)
-    ) or (
-        position in ["first-sibling", "last-sibling", "left", "right"]
-        and target_parent_role in power_roles
-    ):
-        assert response.status_code == 200
-        assert response.json() == {"message": "Document moved successfully."}
-
-        match position:
-            case "first-child":
-                assert list(target.get_children()) == [document, *target_children]
-            case "last-child":
-                assert list(target.get_children()) == [*target_children, document]
-            case "first-sibling":
-                assert list(target.get_siblings()) == [
-                    document,
-                    sibling1,
-                    target,
-                    sibling2,
-                ]
-            case "last-sibling":
-                assert list(target.get_siblings()) == [
-                    sibling1,
-                    target,
-                    sibling2,
-                    document,
-                ]
-            case "left":
-                assert list(target.get_siblings()) == [
-                    sibling1,
-                    document,
-                    target,
-                    sibling2,
-                ]
-            case "right":
-                assert list(target.get_siblings()) == [
-                    sibling1,
-                    target,
-                    document,
-                    sibling2,
-                ]
-            case _:
-                raise ValueError(f"Invalid position: {position}")
-
-        # Verify that the document's children have also been moved
-        assert list(document.get_children()) == children
-    else:
-        assert response.status_code == 400
-        assert (
-            "You do not have permission to move documents"
-            in response.json()["target_document_id"]
-        )
-        assert document.is_root() is True
-
-
-def test_api_documents_move_authenticated_deleted_document():
-    """
-    It should not be possible to move a deleted document or its descendants, even
-    for an owner.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(
-        users=[(user, "owner")], deleted_at=timezone.now()
-    )
-    child = factories.DocumentFactory(parent=document, users=[(user, "owner")])
-
-    target = factories.DocumentFactory(users=[(user, "owner")])
-
-    # Try moving the deleted document
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/move/",
-        data={"target_document_id": str(target.id)},
-    )
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-    # Verify that the document has not moved
-    document.refresh_from_db()
-    assert document.is_root() is True
-
-    # Try moving the child of the deleted document
-    response = client.post(
-        f"/api/v1.0/documents/{child.id!s}/move/",
-        data={"target_document_id": str(target.id)},
-    )
-    assert response.status_code == 403
-    assert response.json() == {
-        "detail": "You do not have permission to perform this action."
-    }
-
-    # Verify that the child has not moved
-    child.refresh_from_db()
-    assert child.is_child_of(document) is True
-
-
-@pytest.mark.parametrize(
-    "position",
-    enums.MoveNodePositionChoices.values,
-)
-def test_api_documents_move_authenticated_deleted_target_as_child(position):
-    """
-    It should not be possible to move a document as a child of a deleted target
-    even for a owner.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(users=[(user, "owner")])
-
-    target = factories.DocumentFactory(
-        users=[(user, "owner")], deleted_at=timezone.now()
-    )
-    child = factories.DocumentFactory(parent=target, users=[(user, "owner")])
-
-    # Try moving the document to the deleted target
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/move/",
-        data={"target_document_id": str(target.id), "position": position},
-    )
-
-    assert response.status_code == 400
-    assert response.json() == {
-        "target_document_id": "Target parent document does not exist."
-    }
-
-    # Verify that the document has not moved
-    document.refresh_from_db()
-    assert document.is_root() is True
-
-    # Try moving the document to the child of the deleted target
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/move/",
-        data={"target_document_id": str(child.id), "position": position},
-    )
-    assert response.status_code == 400
-    assert response.json() == {
-        "target_document_id": "Target parent document does not exist."
-    }
-
-    # Verify that the document has not moved
-    document.refresh_from_db()
-    assert document.is_root() is True
-
-
-@pytest.mark.parametrize(
-    "position",
-    ["first-sibling", "last-sibling", "left", "right"],
-)
-def test_api_documents_move_authenticated_deleted_target_as_sibling(position):
-    """
-    It should not be possible to move a document as a sibling of a deleted target document
-    if the user has no rigths on its parent.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    document = factories.DocumentFactory(users=[(user, "owner")])
-
-    target_parent = factories.DocumentFactory(
-        users=[(user, "owner")], deleted_at=timezone.now()
-    )
-    target = factories.DocumentFactory(users=[(user, "owner")], parent=target_parent)
-
-    # Try moving the document as a sibling of the target
-    response = client.post(
-        f"/api/v1.0/documents/{document.id!s}/move/",
-        data={"target_document_id": str(target.id), "position": position},
-    )
-
-    assert response.status_code == 400
-    assert response.json() == {
-        "target_document_id": "Target parent document does not exist."
-    }
-
-    # Verify that the document has not moved
-    document.refresh_from_db()
-    assert document.is_root() is True

src/backend/core/tests/documents/test_api_documents_restore.py

@@ -1,126 +0,0 @@
-"""
-Test restoring documents after a soft delete via the detail action API endpoint.
-"""
-
-from datetime import timedelta
-
-from django.utils import timezone
-
-import pytest
-from rest_framework.test import APIClient
-
-from core import factories
-
-pytestmark = pytest.mark.django_db
-
-
-def test_api_documents_restore_anonymous_user():
-    """Anonymous users should not be able to restore deleted documents."""
-    now = timezone.now() - timedelta(days=15)
-    document = factories.DocumentFactory(deleted_at=now)
-
-    response = APIClient().post(f"/api/v1.0/documents/{document.id!s}/restore/")
-
-    assert response.status_code == 404
-    assert response.json() == {"detail": "Not found."}
-
-    document.refresh_from_db()
-    assert document.deleted_at == now
-    assert document.ancestors_deleted_at == now
-
-
-@pytest.mark.parametrize("role", [None, "reader", "editor", "administrator"])
-def test_api_documents_restore_authenticated_no_permission(role):
-    """
-    Authenticated users who are not owners of a deleted document should
-    not be allowed to restore it.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    now = timezone.now() - timedelta(days=15)
-    document = factories.DocumentFactory(
-        deleted_at=now, link_reach="public", link_role="editor"
-    )
-    if role:
-        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
-
-    response = client.post(f"/api/v1.0/documents/{document.id!s}/restore/")
-
-    assert response.status_code == 404
-    assert response.json() == {"detail": "Not found."}
-
-    document.refresh_from_db()
-    assert document.deleted_at == now
-    assert document.ancestors_deleted_at == now
-
-
-def test_api_documents_restore_authenticated_owner_success():
-    """The owner of a deleted document should be able to restore it."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    now = timezone.now() - timedelta(days=15)
-    document = factories.DocumentFactory(deleted_at=now)
-    factories.UserDocumentAccessFactory(document=document, user=user, role="owner")
-
-    response = client.post(f"/api/v1.0/documents/{document.id!s}/restore/")
-
-    assert response.status_code == 200
-    assert response.json() == {"detail": "Document has been successfully restored."}
-
-    document.refresh_from_db()
-    assert document.deleted_at is None
-    assert document.ancestors_deleted_at is None
-
-
-def test_api_documents_restore_authenticated_owner_ancestor_deleted():
-    """
-    The restored document should still be marked as deleted if one of its
-    ancestors is soft deleted as well.
-    """
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    grand_parent = factories.DocumentFactory()
-    parent = factories.DocumentFactory(parent=grand_parent)
-    document = factories.DocumentFactory(parent=parent)
-    factories.UserDocumentAccessFactory(document=document, user=user, role="owner")
-
-    document.soft_delete()
-    document_deleted_at = document.deleted_at
-    assert document_deleted_at is not None
-
-    grand_parent.soft_delete()
-    grand_parent_deleted_at = grand_parent.deleted_at
-    assert grand_parent_deleted_at is not None
-
-    response = client.post(f"/api/v1.0/documents/{document.id!s}/restore/")
-
-    assert response.status_code == 200
-    assert response.json() == {"detail": "Document has been successfully restored."}
-
-    document.refresh_from_db()
-    assert document.deleted_at is None
-    # document is still marked as deleted
-    assert document.ancestors_deleted_at == grand_parent_deleted_at
-    assert grand_parent_deleted_at > document_deleted_at
-
-
-def test_api_documents_restore_authenticated_owner_expired():
-    """It should not be possible to restore a document beyond the allowed time limit."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    now = timezone.now() - timedelta(days=40)
-    document = factories.DocumentFactory(deleted_at=now)
-    factories.UserDocumentAccessFactory(document=document, user=user, role="owner")
-
-    response = client.post(f"/api/v1.0/documents/{document.id!s}/restore/")
-
-    assert response.status_code == 404
-    assert response.json() == {"detail": "Not found."}

src/backend/core/tests/documents/test_api_documents_retrieve_auth.py

@@ -20,7 +20,7 @@ from core.tests.conftest import TEAM, USER, VIA
 pytestmark = pytest.mark.django_db
 
 
-def test_api_documents_media_auth_anonymous_public():
+def test_api_documents_retrieve_auth_anonymous_public():
     """Anonymous users should be able to retrieve attachments linked to a public document"""
     document = factories.DocumentFactory(link_reach="public")
 
@@ -36,7 +36,7 @@ def test_api_documents_media_auth_anonymous_public():
 
     original_url = f"http://localhost/media/{key:s}"
     response = APIClient().get(
-        "/api/v1.0/documents/media-auth/", HTTP_X_ORIGINAL_URL=original_url
+        "/api/v1.0/documents/retrieve-auth/", HTTP_X_ORIGINAL_URL=original_url
     )
 
     assert response.status_code == 200
@@ -65,7 +65,7 @@ def test_api_documents_media_auth_anonymous_public():
 
 
 @pytest.mark.parametrize("reach", ["authenticated", "restricted"])
-def test_api_documents_media_auth_anonymous_authenticated_or_restricted(reach):
+def test_api_documents_retrieve_auth_anonymous_authenticated_or_restricted(reach):
     """
     Anonymous users should not be allowed to retrieve attachments linked to a document
     with link reach set to authenticated or restricted.
@@ -76,7 +76,7 @@ def test_api_documents_media_auth_anonymous_authenticated_or_restricted(reach):
     media_url = f"http://localhost/media/{document.pk!s}/attachments/{filename:s}"
 
     response = APIClient().get(
-        "/api/v1.0/documents/media-auth/", HTTP_X_ORIGINAL_URL=media_url
+        "/api/v1.0/documents/retrieve-auth/", HTTP_X_ORIGINAL_URL=media_url
     )
 
     assert response.status_code == 403
@@ -84,7 +84,7 @@ def test_api_documents_media_auth_anonymous_authenticated_or_restricted(reach):
 
 
 @pytest.mark.parametrize("reach", ["public", "authenticated"])
-def test_api_documents_media_auth_authenticated_public_or_authenticated(reach):
+def test_api_documents_retrieve_auth_authenticated_public_or_authenticated(reach):
     """
     Authenticated users who are not related to a document should be able to retrieve
     attachments related to a document with public or authenticated link reach.
@@ -107,7 +107,7 @@ def test_api_documents_media_auth_authenticated_public_or_authenticated(reach):
 
     original_url = f"http://localhost/media/{key:s}"
     response = client.get(
-        "/api/v1.0/documents/media-auth/", HTTP_X_ORIGINAL_URL=original_url
+        "/api/v1.0/documents/retrieve-auth/", HTTP_X_ORIGINAL_URL=original_url
     )
 
     assert response.status_code == 200
@@ -135,7 +135,7 @@ def test_api_documents_media_auth_authenticated_public_or_authenticated(reach):
     assert response.content.decode("utf-8") == "my prose"
 
 
-def test_api_documents_media_auth_authenticated_restricted():
+def test_api_documents_retrieve_auth_authenticated_restricted():
     """
     Authenticated users who are not related to a document should not be allowed to
     retrieve attachments linked to a document that is restricted.
@@ -150,7 +150,7 @@ def test_api_documents_media_auth_authenticated_restricted():
     media_url = f"http://localhost/media/{document.pk!s}/attachments/{filename:s}"
 
     response = client.get(
-        "/api/v1.0/documents/media-auth/", HTTP_X_ORIGINAL_URL=media_url
+        "/api/v1.0/documents/retrieve-auth/", HTTP_X_ORIGINAL_URL=media_url
     )
 
     assert response.status_code == 403
@@ -158,7 +158,7 @@ def test_api_documents_media_auth_authenticated_restricted():
 
 
 @pytest.mark.parametrize("via", VIA)
-def test_api_documents_media_auth_related(via, mock_user_teams):
+def test_api_documents_retrieve_auth_related(via, mock_user_teams):
     """
     Users who have a specific access to a document, whatever the role, should be able to
     retrieve related attachments.
@@ -186,7 +186,7 @@ def test_api_documents_media_auth_related(via, mock_user_teams):
 
     original_url = f"http://localhost/media/{key:s}"
     response = client.get(
-        "/api/v1.0/documents/media-auth/", HTTP_X_ORIGINAL_URL=original_url
+        "/api/v1.0/documents/retrieve-auth/", HTTP_X_ORIGINAL_URL=original_url
     )
 
     assert response.status_code == 200

src/backend/core/tests/documents/test_api_documents_trashbin.py

@@ -1,276 +0,0 @@
-"""
-Tests for Documents API endpoint in impress's core app: list
-"""
-
-from datetime import timedelta
-from unittest import mock
-
-from django.utils import timezone
-
-import pytest
-from faker import Faker
-from rest_framework.pagination import PageNumberPagination
-from rest_framework.test import APIClient
-
-from core import factories, models
-
-fake = Faker()
-pytestmark = pytest.mark.django_db
-
-
-@pytest.mark.parametrize("role", models.LinkRoleChoices.values)
-@pytest.mark.parametrize("reach", models.LinkReachChoices.values)
-def test_api_documents_trashbin_anonymous(reach, role):
-    """
-    Anonymous users should not be allowed to list documents from the trashbin
-    whatever the link reach and link role
-    """
-    factories.DocumentFactory(
-        link_reach=reach, link_role=role, deleted_at=timezone.now()
-    )
-
-    response = APIClient().get("/api/v1.0/documents/trashbin/")
-
-    assert response.status_code == 200
-    assert response.json() == {
-        "count": 0,
-        "next": None,
-        "previous": None,
-        "results": [],
-    }
-
-
-def test_api_documents_trashbin_format():
-    """Validate the format of documents as returned by the trashbin view."""
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    other_users = factories.UserFactory.create_batch(3)
-    document = factories.DocumentFactory(
-        deleted_at=timezone.now(),
-        users=factories.UserFactory.create_batch(2),
-        favorited_by=[user, *other_users],
-        link_traces=other_users,
-    )
-    factories.UserDocumentAccessFactory(document=document, user=user, role="owner")
-
-    response = client.get("/api/v1.0/documents/trashbin/")
-
-    assert response.status_code == 200
-
-    content = response.json()
-    results = content.pop("results")
-    assert content == {
-        "count": 1,
-        "next": None,
-        "previous": None,
-    }
-    assert len(results) == 1
-    assert results[0] == {
-        "id": str(document.id),
-        "abilities": {
-            "accesses_manage": True,
-            "accesses_view": True,
-            "ai_transform": True,
-            "ai_translate": True,
-            "attachment_upload": True,
-            "children_create": True,
-            "children_list": True,
-            "collaboration_auth": True,
-            "destroy": True,
-            "favorite": True,
-            "invite_owner": True,
-            "link_configuration": True,
-            "media_auth": True,
-            "move": False,  # Can't move a deleted document
-            "partial_update": True,
-            "restore": True,
-            "retrieve": True,
-            "update": True,
-            "versions_destroy": True,
-            "versions_list": True,
-            "versions_retrieve": True,
-        },
-        "created_at": document.created_at.isoformat().replace("+00:00", "Z"),
-        "creator": str(document.creator.id),
-        "depth": 1,
-        "excerpt": document.excerpt,
-        "link_reach": document.link_reach,
-        "link_role": document.link_role,
-        "nb_accesses": 3,
-        "numchild": 0,
-        "path": document.path,
-        "title": document.title,
-        "updated_at": document.updated_at.isoformat().replace("+00:00", "Z"),
-        "user_roles": ["owner"],
-    }
-
-
-def test_api_documents_trashbin_authenticated_direct(django_assert_num_queries):
-    """
-    The trashbin should only list deleted documents for which the current user is owner.
-    """
-    now = timezone.now()
-    user = factories.UserFactory()
-    client = APIClient()
-    client.force_login(user)
-
-    document1, document2 = factories.DocumentFactory.create_batch(2, deleted_at=now)
-    models.DocumentAccess.objects.create(document=document1, user=user, role="owner")
-    models.DocumentAccess.objects.create(document=document2, user=user, role="owner")
-
-    # Unrelated documents
-    for reach in models.LinkReachChoices:
-        for role in models.LinkRoleChoices:
-            factories.DocumentFactory(link_reach=reach, link_role=role, deleted_at=now)
-
-    # Role other than "owner"
-    for role in models.RoleChoices.values:
-        if role == "owner":
-            continue
-        document_not_owner = factories.DocumentFactory(deleted_at=now)
-        models.DocumentAccess.objects.create(
-            document=document_not_owner, user=user, role=role
-        )
-
-    # Nested documents should also get listed
-    parent = factories.DocumentFactory(parent=document1)
-    document3 = factories.DocumentFactory(parent=parent, deleted_at=now)
-    models.DocumentAccess.objects.create(document=parent, user=user, role="owner")
-
-    # Permanently deleted documents should not be listed
-    fourty_days_ago = timezone.now() - timedelta(days=40)
-    permanently_deleted_document = factories.DocumentFactory(users=[(user, "owner")])
-    with mock.patch("django.utils.timezone.now", return_value=fourty_days_ago):
-        permanently_deleted_document.soft_delete()
-
-    expected_ids = {str(document1.id), str(document2.id), str(document3.id)}
-
-    with django_assert_num_queries(7):
-        response = client.get("/api/v1.0/documents/trashbin/")
-
-    with django_assert_num_queries(4):
-        response = client.get("/api/v1.0/documents/trashbin/")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    results_ids = {result["id"] for result in results}
-    assert len(results) == 3
-    assert expected_ids == results_ids
-
-
-def test_api_documents_trashbin_authenticated_via_team(
-    django_assert_num_queries, mock_user_teams
-):
-    """
-    Authenticated users should be able to list trashbin documents they own via a team.
-    """
-    now = timezone.now()
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    mock_user_teams.return_value = ["team1", "team2", "unknown"]
-
-    deleted_document_team1 = factories.DocumentFactory(
-        teams=[("team1", "owner")], deleted_at=now
-    )
-    factories.DocumentFactory(teams=[("team1", "owner")])
-    factories.DocumentFactory(teams=[("team1", "administrator")], deleted_at=now)
-    factories.DocumentFactory(teams=[("team1", "administrator")])
-    deleted_document_team2 = factories.DocumentFactory(
-        teams=[("team2", "owner")], deleted_at=now
-    )
-    factories.DocumentFactory(teams=[("team2", "owner")])
-    factories.DocumentFactory(teams=[("team2", "administrator")], deleted_at=now)
-    factories.DocumentFactory(teams=[("team2", "administrator")])
-
-    expected_ids = {str(deleted_document_team1.id), str(deleted_document_team2.id)}
-
-    with django_assert_num_queries(5):
-        response = client.get("/api/v1.0/documents/trashbin/")
-
-    with django_assert_num_queries(3):
-        response = client.get("/api/v1.0/documents/trashbin/")
-
-    assert response.status_code == 200
-    results = response.json()["results"]
-    assert len(results) == 2
-    results_id = {result["id"] for result in results}
-    assert expected_ids == results_id
-
-
-@mock.patch.object(PageNumberPagination, "get_page_size", return_value=2)
-def test_api_documents_trashbin_pagination(
-    _mock_page_size,
-):
-    """Pagination should work as expected."""
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    document_ids = [
-        str(document.id)
-        for document in factories.DocumentFactory.create_batch(
-            3, deleted_at=timezone.now()
-        )
-    ]
-    for document_id in document_ids:
-        models.DocumentAccess.objects.create(
-            document_id=document_id, user=user, role="owner"
-        )
-
-    # Get page 1
-    response = client.get("/api/v1.0/documents/trashbin/")
-
-    assert response.status_code == 200
-    content = response.json()
-
-    assert content["count"] == 3
-    assert content["next"] == "http://testserver/api/v1.0/documents/trashbin/?page=2"
-    assert content["previous"] is None
-
-    assert len(content["results"]) == 2
-    for item in content["results"]:
-        document_ids.remove(item["id"])
-
-    # Get page 2
-    response = client.get(
-        "/api/v1.0/documents/trashbin/?page=2",
-    )
-
-    assert response.status_code == 200
-    content = response.json()
-
-    assert content["count"] == 3
-    assert content["next"] is None
-    assert content["previous"] == "http://testserver/api/v1.0/documents/trashbin/"
-
-    assert len(content["results"]) == 1
-    document_ids.remove(content["results"][0]["id"])
-    assert document_ids == []
-
-
-def test_api_documents_trashbin_distinct():
-    """A document with several related users should only be listed once."""
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    other_user = factories.UserFactory()
-    document = factories.DocumentFactory(
-        users=[(user, "owner"), other_user], deleted_at=timezone.now()
-    )
-
-    response = client.get(
-        "/api/v1.0/documents/trashbin/",
-    )
-
-    assert response.status_code == 200
-    content = response.json()
-    assert len(content["results"]) == 1
-    assert content["results"][0]["id"] == str(document.id)

src/backend/core/tests/documents/test_api_documents_update.py

@@ -16,7 +16,6 @@ from core.tests.conftest import TEAM, USER, VIA
 pytestmark = pytest.mark.django_db
 
 
-@pytest.mark.parametrize("via_parent", [True, False])
 @pytest.mark.parametrize(
     "reach, role",
     [
@@ -27,18 +26,12 @@ pytestmark = pytest.mark.django_db
         ("public", "reader"),
     ],
 )
-def test_api_documents_update_anonymous_forbidden(reach, role, via_parent):
+def test_api_documents_update_anonymous_forbidden(reach, role):
     """
     Anonymous users should not be allowed to update a document when link
     configuration does not allow it.
     """
-    if via_parent:
-        grand_parent = factories.DocumentFactory(link_reach=reach, link_role=role)
-        parent = factories.DocumentFactory(parent=grand_parent, link_reach="restricted")
-        document = factories.DocumentFactory(parent=parent, link_reach="restricted")
-    else:
-        document = factories.DocumentFactory(link_reach=reach, link_role=role)
-
+    document = factories.DocumentFactory(link_reach=reach, link_role=role)
     old_document_values = serializers.DocumentSerializer(instance=document).data
 
     new_document_values = serializers.DocumentSerializer(
@@ -59,7 +52,6 @@ def test_api_documents_update_anonymous_forbidden(reach, role, via_parent):
     assert document_values == old_document_values
 
 
-@pytest.mark.parametrize("via_parent", [True, False])
 @pytest.mark.parametrize(
     "reach,role",
     [
@@ -69,9 +61,7 @@ def test_api_documents_update_anonymous_forbidden(reach, role, via_parent):
         ("restricted", "editor"),
     ],
 )
-def test_api_documents_update_authenticated_unrelated_forbidden(
-    reach, role, via_parent
-):
+def test_api_documents_update_authenticated_unrelated_forbidden(reach, role):
     """
     Authenticated users should not be allowed to update a document to which
     they are not related if the link configuration does not allow it.
@@ -81,12 +71,7 @@ def test_api_documents_update_authenticated_unrelated_forbidden(
     client = APIClient()
     client.force_login(user)
 
-    if via_parent:
-        grand_parent = factories.DocumentFactory(link_reach=reach, link_role=role)
-        parent = factories.DocumentFactory(parent=grand_parent, link_reach="restricted")
-        document = factories.DocumentFactory(parent=parent, link_reach="restricted")
-    else:
-        document = factories.DocumentFactory(link_reach=reach, link_role=role)
+    document = factories.DocumentFactory(link_reach=reach, link_role=role)
 
     old_document_values = serializers.DocumentSerializer(instance=document).data
     new_document_values = serializers.DocumentSerializer(
@@ -108,7 +93,6 @@ def test_api_documents_update_authenticated_unrelated_forbidden(
     assert document_values == old_document_values
 
 
-@pytest.mark.parametrize("via_parent", [True, False])
 @pytest.mark.parametrize(
     "is_authenticated,reach,role",
     [
@@ -118,10 +102,10 @@ def test_api_documents_update_authenticated_unrelated_forbidden(
     ],
 )
 def test_api_documents_update_anonymous_or_authenticated_unrelated(
-    is_authenticated, reach, role, via_parent
+    is_authenticated, reach, role
 ):
     """
-    Anonymous and authenticated users should be able to update a document to which
+    Authenticated users should be able to update a document to which
     they are not related if the link configuration allows it.
     """
     client = APIClient()
@@ -132,12 +116,7 @@ def test_api_documents_update_anonymous_or_authenticated_unrelated(
     else:
         user = AnonymousUser()
 
-    if via_parent:
-        grand_parent = factories.DocumentFactory(link_reach=reach, link_role=role)
-        parent = factories.DocumentFactory(parent=grand_parent, link_reach="restricted")
-        document = factories.DocumentFactory(parent=parent, link_reach="restricted")
-    else:
-        document = factories.DocumentFactory(link_reach=reach, link_role=role)
+    document = factories.DocumentFactory(link_reach=reach, link_role=role)
 
     old_document_values = serializers.DocumentSerializer(instance=document).data
     new_document_values = serializers.DocumentSerializer(
@@ -153,17 +132,7 @@ def test_api_documents_update_anonymous_or_authenticated_unrelated(
     document = models.Document.objects.get(pk=document.pk)
     document_values = serializers.DocumentSerializer(instance=document).data
     for key, value in document_values.items():
-        if key in [
-            "id",
-            "accesses",
-            "created_at",
-            "creator",
-            "depth",
-            "link_reach",
-            "link_role",
-            "numchild",
-            "path",
-        ]:
+        if key in ["id", "accesses", "created_at", "link_reach", "link_role"]:
             assert value == old_document_values[key]
         elif key == "updated_at":
             assert value > old_document_values[key]
@@ -171,34 +140,24 @@ def test_api_documents_update_anonymous_or_authenticated_unrelated(
             assert value == new_document_values[key]
 
 
-@pytest.mark.parametrize("via_parent", [True, False])
 @pytest.mark.parametrize("via", VIA)
-def test_api_documents_update_authenticated_reader(via, via_parent, mock_user_teams):
+def test_api_documents_update_authenticated_reader(via, mock_user_teams):
     """
-    Users who are reader of a document should not be allowed to update it.
+    Users who are reader of a document but not administrators should
+    not be allowed to update it.
     """
     user = factories.UserFactory(with_owned_document=True)
 
     client = APIClient()
     client.force_login(user)
 
-    if via_parent:
-        grand_parent = factories.DocumentFactory(link_reach="restricted")
-        parent = factories.DocumentFactory(parent=grand_parent, link_reach="restricted")
-        document = factories.DocumentFactory(parent=parent, link_reach="restricted")
-        access_document = grand_parent
-    else:
-        document = factories.DocumentFactory(link_reach="restricted")
-        access_document = document
-
+    document = factories.DocumentFactory(link_role="reader")
     if via == USER:
-        factories.UserDocumentAccessFactory(
-            document=access_document, user=user, role="reader"
-        )
+        factories.UserDocumentAccessFactory(document=document, user=user, role="reader")
     elif via == TEAM:
         mock_user_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
-            document=access_document, team="lasuite", role="reader"
+            document=document, team="lasuite", role="reader"
         )
 
     old_document_values = serializers.DocumentSerializer(instance=document).data
@@ -222,11 +181,10 @@ def test_api_documents_update_authenticated_reader(via, via_parent, mock_user_te
     assert document_values == old_document_values
 
 
-@pytest.mark.parametrize("via_parent", [True, False])
 @pytest.mark.parametrize("role", ["editor", "administrator", "owner"])
 @pytest.mark.parametrize("via", VIA)
 def test_api_documents_update_authenticated_editor_administrator_or_owner(
-    via, role, via_parent, mock_user_teams
+    via, role, mock_user_teams
 ):
     """A user who is editor, administrator or owner of a document should be allowed to update it."""
     user = factories.UserFactory(with_owned_document=True)
@@ -234,23 +192,13 @@ def test_api_documents_update_authenticated_editor_administrator_or_owner(
     client = APIClient()
     client.force_login(user)
 
-    if via_parent:
-        grand_parent = factories.DocumentFactory(link_reach="restricted")
-        parent = factories.DocumentFactory(parent=grand_parent, link_reach="restricted")
-        document = factories.DocumentFactory(parent=parent, link_reach="restricted")
-        access_document = grand_parent
-    else:
-        document = factories.DocumentFactory(link_reach="restricted")
-        access_document = document
-
+    document = factories.DocumentFactory()
     if via == USER:
-        factories.UserDocumentAccessFactory(
-            document=access_document, user=user, role=role
-        )
+        factories.UserDocumentAccessFactory(document=document, user=user, role=role)
     elif via == TEAM:
         mock_user_teams.return_value = ["lasuite", "unknown"]
         factories.TeamDocumentAccessFactory(
-            document=access_document, team="lasuite", role=role
+            document=document, team="lasuite", role=role
         )
 
     old_document_values = serializers.DocumentSerializer(instance=document).data
@@ -268,17 +216,46 @@ def test_api_documents_update_authenticated_editor_administrator_or_owner(
     document = models.Document.objects.get(pk=document.pk)
     document_values = serializers.DocumentSerializer(instance=document).data
     for key, value in document_values.items():
-        if key in [
-            "id",
-            "created_at",
-            "creator",
-            "depth",
-            "link_reach",
-            "link_role",
-            "nb_accesses",
-            "numchild",
-            "path",
-        ]:
+        if key in ["id", "accesses", "created_at", "link_reach", "link_role"]:
+            assert value == old_document_values[key]
+        elif key == "updated_at":
+            assert value > old_document_values[key]
+        else:
+            assert value == new_document_values[key]
+
+
+@pytest.mark.parametrize("via", VIA)
+def test_api_documents_update_authenticated_owners(via, mock_user_teams):
+    """Administrators of a document should be allowed to update it."""
+    user = factories.UserFactory(with_owned_document=True)
+
+    client = APIClient()
+    client.force_login(user)
+
+    document = factories.DocumentFactory()
+    if via == USER:
+        factories.UserDocumentAccessFactory(document=document, user=user, role="owner")
+    elif via == TEAM:
+        mock_user_teams.return_value = ["lasuite", "unknown"]
+        factories.TeamDocumentAccessFactory(
+            document=document, team="lasuite", role="owner"
+        )
+
+    old_document_values = serializers.DocumentSerializer(instance=document).data
+
+    new_document_values = serializers.DocumentSerializer(
+        instance=factories.DocumentFactory()
+    ).data
+
+    response = client.put(
+        f"/api/v1.0/documents/{document.id!s}/", new_document_values, format="json"
+    )
+
+    assert response.status_code == 200
+    document = models.Document.objects.get(pk=document.pk)
+    document_values = serializers.DocumentSerializer(instance=document).data
+    for key, value in document_values.items():
+        if key in ["id", "accesses", "created_at", "link_reach", "link_role"]:
             assert value == old_document_values[key]
         elif key == "updated_at":
             assert value > old_document_values[key]

src/backend/core/tests/templates/test_api_template_accesses.py

@@ -73,14 +73,14 @@ def test_api_template_accesses_list_authenticated_related(via, mock_user_teams):
         user_access = models.TemplateAccess.objects.create(
             template=template,
             user=user,
-            role=random.choice(models.RoleChoices.values),
+            role=random.choice(models.RoleChoices.choices)[0],
         )
     elif via == TEAM:
         mock_user_teams.return_value = ["lasuite", "unknown"]
         user_access = models.TemplateAccess.objects.create(
             template=template,
             team="lasuite",
-            role=random.choice(models.RoleChoices.values),
+            role=random.choice(models.RoleChoices.choices)[0],
         )
 
     access1 = factories.TeamTemplateAccessFactory(template=template)
@@ -219,7 +219,7 @@ def test_api_template_accesses_update_anonymous():
     new_values = {
         "id": uuid4(),
         "user": factories.UserFactory().id,
-        "role": random.choice(models.RoleChoices.values),
+        "role": random.choice(models.RoleChoices.choices)[0],
     }
 
     api_client = APIClient()
@@ -252,7 +252,7 @@ def test_api_template_accesses_update_authenticated_unrelated():
     new_values = {
         "id": uuid4(),
         "user": factories.UserFactory().id,
-        "role": random.choice(models.RoleChoices.values),
+        "role": random.choice(models.RoleChoices.choices)[0],
     }
 
     for field, value in new_values.items():
@@ -294,7 +294,7 @@ def test_api_template_accesses_update_authenticated_editor_or_reader(
     new_values = {
         "id": uuid4(),
         "user": factories.UserFactory().id,
-        "role": random.choice(models.RoleChoices.values),
+        "role": random.choice(models.RoleChoices.choices)[0],
     }
 
     for field, value in new_values.items():
@@ -398,7 +398,7 @@ def test_api_template_accesses_update_administrator_from_owner(via, mock_user_te
     new_values = {
         "id": uuid4(),
         "user_id": factories.UserFactory().id,
-        "role": random.choice(models.RoleChoices.values),
+        "role": random.choice(models.RoleChoices.choices)[0],
     }
 
     for field, value in new_values.items():
@@ -497,7 +497,7 @@ def test_api_template_accesses_update_owner(via, mock_user_teams):
     new_values = {
         "id": uuid4(),
         "user_id": factories.UserFactory().id,
-        "role": random.choice(models.RoleChoices.values),
+        "role": random.choice(models.RoleChoices.choices)[0],
     }
 
     for field, value in new_values.items():

src/backend/core/tests/templates/test_api_template_accesses_create.py

@@ -23,7 +23,7 @@ def test_api_template_accesses_create_anonymous():
         {
             "user": str(other_user.id),
             "template": str(template.id),
-            "role": random.choice(models.RoleChoices.values),
+            "role": random.choice(models.RoleChoices.choices)[0],
         },
         format="json",
     )

src/backend/core/tests/templates/test_api_templates_generate_document.py

@@ -0,0 +1,208 @@
+"""
+Test users API endpoints in the impress core app.
+"""
+
+import pytest
+from rest_framework.test import APIClient
+
+from core import factories
+from core.tests.conftest import TEAM, USER, VIA
+
+pytestmark = pytest.mark.django_db
+
+
+def test_api_templates_generate_document_anonymous_public():
+    """Anonymous users can generate pdf document with public templates."""
+    template = factories.TemplateFactory(is_public=True)
+    data = {
+        "body": "# Test markdown body",
+    }
+
+    response = APIClient().post(
+        f"/api/v1.0/templates/{template.id!s}/generate-document/",
+        data,
+        format="json",
+    )
+
+    assert response.status_code == 200
+    assert response.headers["content-type"] == "application/pdf"
+
+
+def test_api_templates_generate_document_anonymous_not_public():
+    """
+    Anonymous users should not be allowed to generate pdf document with templates
+    that are not marked as public.
+    """
+    template = factories.TemplateFactory(is_public=False)
+    data = {
+        "body": "# Test markdown body",
+    }
+
+    response = APIClient().post(
+        f"/api/v1.0/templates/{template.id!s}/generate-document/",
+        data,
+        format="json",
+    )
+
+    assert response.status_code == 401
+    assert response.json() == {
+        "detail": "Authentication credentials were not provided."
+    }
+
+
+def test_api_templates_generate_document_authenticated_public():
+    """Authenticated users can generate pdf document with public templates."""
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    template = factories.TemplateFactory(is_public=True)
+    data = {"body": "# Test markdown body"}
+
+    response = client.post(
+        f"/api/v1.0/templates/{template.id!s}/generate-document/",
+        data,
+        format="json",
+    )
+
+    assert response.status_code == 200
+    assert response.headers["content-type"] == "application/pdf"
+
+
+def test_api_templates_generate_document_authenticated_not_public():
+    """
+    Authenticated users should not be allowed to generate pdf document with templates
+    that are not marked as public.
+    """
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    template = factories.TemplateFactory(is_public=False)
+    data = {"body": "# Test markdown body"}
+
+    response = client.post(
+        f"/api/v1.0/templates/{template.id!s}/generate-document/",
+        data,
+        format="json",
+    )
+
+    assert response.status_code == 403
+    assert response.json() == {
+        "detail": "You do not have permission to perform this action."
+    }
+
+
+@pytest.mark.parametrize("via", VIA)
+def test_api_templates_generate_document_related(via, mock_user_teams):
+    """Users related to a template can generate pdf document."""
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+    access = None
+    if via == USER:
+        access = factories.UserTemplateAccessFactory(user=user)
+    elif via == TEAM:
+        mock_user_teams.return_value = ["lasuite", "unknown"]
+        access = factories.TeamTemplateAccessFactory(team="lasuite")
+
+    data = {"body": "# Test markdown body"}
+
+    response = client.post(
+        f"/api/v1.0/templates/{access.template_id!s}/generate-document/",
+        data,
+        format="json",
+    )
+
+    assert response.status_code == 200
+    assert response.headers["content-type"] == "application/pdf"
+
+
+def test_api_templates_generate_document_type_html():
+    """Generate pdf document with the body type html."""
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    template = factories.TemplateFactory(is_public=True)
+    data = {"body": "<p>Test body</p>", "body_type": "html"}
+
+    response = client.post(
+        f"/api/v1.0/templates/{template.id!s}/generate-document/",
+        data,
+        format="json",
+    )
+
+    assert response.status_code == 200
+    assert response.headers["content-type"] == "application/pdf"
+
+
+def test_api_templates_generate_document_type_markdown():
+    """Generate pdf document with the body type markdown."""
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    template = factories.TemplateFactory(is_public=True)
+    data = {"body": "# Test markdown body", "body_type": "markdown"}
+
+    response = client.post(
+        f"/api/v1.0/templates/{template.id!s}/generate-document/",
+        data,
+        format="json",
+    )
+
+    assert response.status_code == 200
+    assert response.headers["content-type"] == "application/pdf"
+
+
+def test_api_templates_generate_document_type_unknown():
+    """Generate pdf document with the body type unknown."""
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    template = factories.TemplateFactory(is_public=True)
+    data = {"body": "# Test markdown body", "body_type": "unknown"}
+
+    response = client.post(
+        f"/api/v1.0/templates/{template.id!s}/generate-document/",
+        data,
+        format="json",
+    )
+
+    assert response.status_code == 400
+    assert response.json() == {
+        "body_type": [
+            '"unknown" is not a valid choice.',
+        ]
+    }
+
+
+def test_api_templates_generate_document_export_docx():
+    """Generate pdf document with the body type html."""
+    user = factories.UserFactory()
+
+    client = APIClient()
+    client.force_login(user)
+
+    template = factories.TemplateFactory(is_public=True)
+    data = {"body": "<p>Test body</p>", "body_type": "html", "format": "docx"}
+
+    response = client.post(
+        f"/api/v1.0/templates/{template.id!s}/generate-document/",
+        data,
+        format="json",
+    )
+
+    assert response.status_code == 200
+    assert (
+        response.headers["content-type"]
+        == "application/vnd.openxmlformats-officedocument.wordprocessingml.document"
+    )

src/backend/core/tests/templates/test_api_templates_list.py

@@ -187,9 +187,9 @@ def test_api_templates_list_order_default():
     response_template_ids = [template["id"] for template in response_data["results"]]
 
     template_ids.reverse()
-    assert response_template_ids == template_ids, (
-        "created_at values are not sorted from newest to oldest"
-    )
+    assert (
+        response_template_ids == template_ids
+    ), "created_at values are not sorted from newest to oldest"
 
 
 def test_api_templates_list_order_param():
@@ -215,6 +215,6 @@ def test_api_templates_list_order_param():
 
     response_template_ids = [template["id"] for template in response_data["results"]]
 
-    assert response_template_ids == templates_ids, (
-        "created_at values are not sorted from oldest to newest"
-    )
+    assert (
+        response_template_ids == templates_ids
+    ), "created_at values are not sorted from oldest to newest"

src/backend/core/tests/templates/test_api_templates_retrieve.py

@@ -22,7 +22,7 @@ def test_api_templates_retrieve_anonymous_public():
         "abilities": {
             "destroy": False,
             "generate_document": True,
-            "accesses_manage": False,
+            "manage_accesses": False,
             "partial_update": False,
             "retrieve": True,
             "update": False,
@@ -68,7 +68,7 @@ def test_api_templates_retrieve_authenticated_unrelated_public():
         "abilities": {
             "destroy": False,
             "generate_document": True,
-            "accesses_manage": False,
+            "manage_accesses": False,
             "partial_update": False,
             "retrieve": True,
             "update": False,

src/backend/core/tests/test_api_config.py

@@ -1,47 +0,0 @@
-"""
-Test config API endpoints in the Impress core app.
-"""
-
-from django.test import override_settings
-
-import pytest
-from rest_framework.status import (
-    HTTP_200_OK,
-)
-from rest_framework.test import APIClient
-
-from core import factories
-
-pytestmark = pytest.mark.django_db
-
-
-@override_settings(
-    COLLABORATION_WS_URL="http://testcollab/",
-    CRISP_WEBSITE_ID="123",
-    FRONTEND_THEME="test-theme",
-    MEDIA_BASE_URL="http://testserver/",
-    POSTHOG_KEY={"id": "132456", "host": "https://eu.i.posthog-test.com"},
-    SENTRY_DSN="https://sentry.test/123",
-)
-@pytest.mark.parametrize("is_authenticated", [False, True])
-def test_api_config(is_authenticated):
-    """Anonymous users should be allowed to get the configuration."""
-    client = APIClient()
-
-    if is_authenticated:
-        user = factories.UserFactory()
-        client.force_login(user)
-
-    response = client.get("/api/v1.0/config/")
-    assert response.status_code == HTTP_200_OK
-    assert response.json() == {
-        "COLLABORATION_WS_URL": "http://testcollab/",
-        "CRISP_WEBSITE_ID": "123",
-        "ENVIRONMENT": "test",
-        "FRONTEND_THEME": "test-theme",
-        "LANGUAGES": [["en-us", "English"], ["fr-fr", "French"], ["de-de", "German"]],
-        "LANGUAGE_CODE": "en-us",
-        "MEDIA_BASE_URL": "http://testserver/",
-        "POSTHOG_KEY": {"id": "132456", "host": "https://eu.i.posthog-test.com"},
-        "SENTRY_DSN": "https://sentry.test/123",
-    }

src/backend/core/tests/test_api_users.py

@@ -42,9 +42,8 @@ def test_api_users_list_authenticated():
 
 def test_api_users_list_query_email():
     """
-    Authenticated users should be able to list users and filter by email.
-    Only results with a Levenstein distance less than 3 with the query should be returned.
-    We want to match by Levenstein distance because we want to prevent typing errors.
+    Authenticated users should be able to list users
+    and filter by email.
     """
     user = factories.UserFactory()
 
@@ -52,7 +51,9 @@ def test_api_users_list_query_email():
     client.force_login(user)
 
     dave = factories.UserFactory(email="david.bowman@work.com")
-    factories.UserFactory(email="nicole.bowman@work.com")
+    nicole = factories.UserFactory(email="nicole_foole@work.com")
+    frank = factories.UserFactory(email="frank_poole@work.com")
+    factories.UserFactory(email="heywood_floyd@work.com")
 
     response = client.get(
         "/api/v1.0/users/?q=david.bowman@work.com",
@@ -61,53 +62,17 @@ def test_api_users_list_query_email():
     user_ids = [user["id"] for user in response.json()["results"]]
     assert user_ids == [str(dave.id)]
 
-    response = client.get(
-        "/api/v1.0/users/?q=davig.bovman@worm.com",
-    )
-    assert response.status_code == 200
-    user_ids = [user["id"] for user in response.json()["results"]]
-    assert user_ids == [str(dave.id)]
-
-    response = client.get(
-        "/api/v1.0/users/?q=davig.bovman@worm.cop",
-    )
-    assert response.status_code == 200
-    user_ids = [user["id"] for user in response.json()["results"]]
-    assert user_ids == []
-
-
-def test_api_users_list_query_email_matching():
-    """While filtering by email, results should be filtered and sorted by Levenstein distance."""
-    user = factories.UserFactory()
-
-    client = APIClient()
-    client.force_login(user)
-
-    user1 = factories.UserFactory(email="alice.johnson@example.gouv.fr")
-    user2 = factories.UserFactory(email="alice.johnnson@example.gouv.fr")
-    user3 = factories.UserFactory(email="alice.kohlson@example.gouv.fr")
-    user4 = factories.UserFactory(email="alicia.johnnson@example.gouv.fr")
-    user5 = factories.UserFactory(email="alicia.johnnson@example.gov.uk")
-    factories.UserFactory(email="alice.thomson@example.gouv.fr")
-
-    response = client.get(
-        "/api/v1.0/users/?q=alice.johnson@example.gouv.fr",
-    )
-    assert response.status_code == 200
-    user_ids = [user["id"] for user in response.json()["results"]]
-    assert user_ids == [str(user1.id), str(user2.id), str(user3.id), str(user4.id)]
-
-    response = client.get("/api/v1.0/users/?q=alicia.johnnson@example.gouv.fr")
+    response = client.get("/api/v1.0/users/?q=oole")
 
     assert response.status_code == 200
     user_ids = [user["id"] for user in response.json()["results"]]
-    assert user_ids == [str(user4.id), str(user2.id), str(user1.id), str(user5.id)]
+    assert user_ids == [str(nicole.id), str(frank.id)]
 
 
 def test_api_users_list_query_email_exclude_doc_user():
     """
-    Authenticated users should be able to list users while filtering by email
-    and excluding users who have access to a document.
+    Authenticated users should be able to list users
+    and filter by email and exclude users who have access to a document.
     """
     user = factories.UserFactory()
     document = factories.DocumentFactory()
@@ -115,19 +80,17 @@ def test_api_users_list_query_email_exclude_doc_user():
     client = APIClient()
     client.force_login(user)
 
-    nicole_fool = factories.UserFactory(email="nicole_fool@work.com")
-    nicole_pool = factories.UserFactory(email="nicole_pool@work.com")
+    nicole = factories.UserFactory(email="nicole_foole@work.com")
+    frank = factories.UserFactory(email="frank_poole@work.com")
     factories.UserFactory(email="heywood_floyd@work.com")
 
-    factories.UserDocumentAccessFactory(document=document, user=nicole_pool)
+    factories.UserDocumentAccessFactory(document=document, user=frank)
 
-    response = client.get(
-        "/api/v1.0/users/?q=nicole_fool@work.com&document_id=" + str(document.id)
-    )
+    response = client.get("/api/v1.0/users/?q=oole&document_id=" + str(document.id))
 
     assert response.status_code == 200
     user_ids = [user["id"] for user in response.json()["results"]]
-    assert user_ids == [str(nicole_fool.id)]
+    assert user_ids == [str(nicole.id)]
 
 
 def test_api_users_retrieve_me_anonymous():

src/backend/core/tests/test_api_utils_filter_root_paths.py

@@ -1,94 +0,0 @@
-"""
-Unit tests for the filter_root_paths utility function.
-"""
-
-from core.api.utils import filter_root_paths
-
-
-def test_api_utils_filter_root_paths_success():
-    """
-    The `filter_root_paths` function should correctly identify root paths
-    from a given list of paths.
-
-    This test uses a list of paths with missing intermediate paths to ensure that
-    only the minimal set of root paths is returned.
-    """
-    paths = [
-        "0001",
-        "00010001",
-        "000100010001",
-        "000100010002",
-        # missing 00010002
-        "000100020001",
-        "000100020002",
-        "0002",
-        "00020001",
-        "00020002",
-        # missing 0003
-        "00030001",
-        "000300010001",
-        "00030002",
-        # missing 0004
-        # missing 00040001
-        # missing 000400010001
-        # missing 000400010002
-        "000400010003",
-        "0004000100030001",
-        "000400010004",
-    ]
-    filtered_paths = filter_root_paths(paths, skip_sorting=True)
-    assert filtered_paths == [
-        "0001",
-        "0002",
-        "00030001",
-        "00030002",
-        "000400010003",
-        "000400010004",
-    ]
-
-
-def test_api_utils_filter_root_paths_sorting():
-    """
-    The `filter_root_paths` function should fail is sorting is skipped and paths are not sorted.
-
-    This test verifies that when sorting is skipped, the function respects the input order, and
-    when sorting is enabled, the result is correctly ordered and minimal.
-    """
-    paths = [
-        "0001",
-        "00010001",
-        "000100010001",
-        "000100020002",
-        "000100010002",
-        "000100020001",
-        "00020001",
-        "0002",
-        "00020002",
-        "000300010001",
-        "00030001",
-        "00030002",
-        "0004000100030001",
-        "000400010003",
-        "000400010004",
-    ]
-    filtered_paths = filter_root_paths(paths, skip_sorting=True)
-    assert filtered_paths == [
-        "0001",
-        "00020001",
-        "0002",
-        "000300010001",
-        "00030001",
-        "00030002",
-        "0004000100030001",
-        "000400010003",
-        "000400010004",
-    ]
-    filtered_paths = filter_root_paths(paths)
-    assert filtered_paths == [
-        "0001",
-        "0002",
-        "00030001",
-        "00030002",
-        "000400010003",
-        "000400010004",
-    ]

src/backend/core/tests/test_models_documents.py

@@ -2,14 +2,12 @@
 Unit tests for the Document model
 """
 
-import random
 import smtplib
 from logging import Logger
 from unittest import mock
 
 from django.contrib.auth.models import AnonymousUser
 from django.core import mail
-from django.core.cache import cache
 from django.core.exceptions import ValidationError
 from django.core.files.storage import default_storage
 from django.utils import timezone
@@ -34,20 +32,15 @@ def test_models_documents_id_unique():
         factories.DocumentFactory(id=document.id)
 
 
-def test_models_documents_creator_required():
-    """No field should be required on the Document model."""
-    models.Document.add_root()
-
-
 def test_models_documents_title_null():
     """The "title" field can be null."""
-    document = models.Document.add_root(title=None, creator=factories.UserFactory())
+    document = models.Document.objects.create(title=None)
     assert document.title is None
 
 
 def test_models_documents_title_empty():
     """The "title" field can be empty."""
-    document = models.Document.add_root(title="", creator=factories.UserFactory())
+    document = models.Document.objects.create(title="")
     assert document.title == ""
 
 
@@ -67,60 +60,6 @@ def test_models_documents_file_key():
     assert document.file_key == "9531a5f1-42b1-496c-b3f4-1c09ed139b3c/file"
 
 
-def test_models_documents_tree_alphabet():
-    """Test the creation of documents with treebeard methods."""
-    models.Document.load_bulk(
-        [
-            {
-                "data": {
-                    "title": f"document-{i}",
-                }
-            }
-            for i in range(len(models.Document.alphabet) * 2)
-        ]
-    )
-
-    assert models.Document.objects.count() == 124
-
-
-@pytest.mark.parametrize("depth", range(5))
-def test_models_documents_soft_delete(depth):
-    """Trying to delete a document that is already deleted or is a descendant of
-    a deleted document should raise an error.
-    """
-    documents = []
-    for i in range(depth + 1):
-        documents.append(
-            factories.DocumentFactory()
-            if i == 0
-            else factories.DocumentFactory(parent=documents[-1])
-        )
-    assert models.Document.objects.count() == depth + 1
-
-    # Delete any one of the documents...
-    deleted_document = random.choice(documents)
-    deleted_document.soft_delete()
-
-    with pytest.raises(RuntimeError):
-        documents[-1].soft_delete()
-
-    assert deleted_document.deleted_at is not None
-    assert deleted_document.ancestors_deleted_at == deleted_document.deleted_at
-
-    descendants = deleted_document.get_descendants()
-    for child in descendants:
-        assert child.deleted_at is None
-        assert child.ancestors_deleted_at is not None
-        assert child.ancestors_deleted_at == deleted_document.deleted_at
-
-    ancestors = deleted_document.get_ancestors()
-    for parent in ancestors:
-        assert parent.deleted_at is None
-        assert parent.ancestors_deleted_at is None
-
-    assert len(ancestors) + len(descendants) == depth
-
-
 # get_abilities
 
 
@@ -135,44 +74,29 @@ def test_models_documents_soft_delete(depth):
         (False, "authenticated", "editor"),
     ],
 )
-def test_models_documents_get_abilities_forbidden(
-    is_authenticated, reach, role, django_assert_num_queries
-):
+def test_models_documents_get_abilities_forbidden(is_authenticated, reach, role):
     """
     Check abilities returned for a document giving insufficient roles to link holders
     i.e anonymous users or authenticated users who have no specific role on the document.
     """
     document = factories.DocumentFactory(link_reach=reach, link_role=role)
     user = factories.UserFactory() if is_authenticated else AnonymousUser()
-    expected_abilities = {
-        "accesses_manage": False,
-        "accesses_view": False,
+    abilities = document.get_abilities(user)
+    assert abilities == {
         "ai_transform": False,
         "ai_translate": False,
         "attachment_upload": False,
-        "children_create": False,
-        "children_list": False,
-        "collaboration_auth": False,
-        "destroy": False,
-        "favorite": False,
-        "invite_owner": False,
-        "media_auth": False,
-        "move": False,
         "link_configuration": False,
+        "destroy": False,
+        "invite_owner": False,
+        "manage_accesses": False,
         "partial_update": False,
-        "restore": False,
         "retrieve": False,
         "update": False,
         "versions_destroy": False,
         "versions_list": False,
         "versions_retrieve": False,
     }
-    nb_queries = 1 if is_authenticated else 0
-    with django_assert_num_queries(nb_queries):
-        assert document.get_abilities(user) == expected_abilities
-    document.soft_delete()
-    document.refresh_from_db()
-    assert document.get_abilities(user) == expected_abilities
 
 
 @pytest.mark.parametrize(
@@ -183,44 +107,29 @@ def test_models_documents_get_abilities_forbidden(
         (True, "authenticated"),
     ],
 )
-def test_models_documents_get_abilities_reader(
-    is_authenticated, reach, django_assert_num_queries
-):
+def test_models_documents_get_abilities_reader(is_authenticated, reach):
     """
     Check abilities returned for a document giving reader role to link holders
     i.e anonymous users or authenticated users who have no specific role on the document.
     """
     document = factories.DocumentFactory(link_reach=reach, link_role="reader")
     user = factories.UserFactory() if is_authenticated else AnonymousUser()
-    expected_abilities = {
-        "accesses_manage": False,
-        "accesses_view": False,
+    abilities = document.get_abilities(user)
+    assert abilities == {
         "ai_transform": False,
         "ai_translate": False,
         "attachment_upload": False,
-        "children_create": False,
-        "children_list": True,
-        "collaboration_auth": True,
         "destroy": False,
-        "favorite": is_authenticated,
-        "invite_owner": False,
         "link_configuration": False,
-        "media_auth": True,
-        "move": False,
+        "invite_owner": False,
+        "manage_accesses": False,
         "partial_update": False,
-        "restore": False,
         "retrieve": True,
         "update": False,
         "versions_destroy": False,
         "versions_list": False,
         "versions_retrieve": False,
     }
-    nb_queries = 1 if is_authenticated else 0
-    with django_assert_num_queries(nb_queries):
-        assert document.get_abilities(user) == expected_abilities
-    document.soft_delete()
-    document.refresh_from_db()
-    assert all(value is False for value in document.get_abilities(user).values())
 
 
 @pytest.mark.parametrize(
@@ -231,184 +140,122 @@ def test_models_documents_get_abilities_reader(
         (True, "authenticated"),
     ],
 )
-def test_models_documents_get_abilities_editor(
-    is_authenticated, reach, django_assert_num_queries
-):
+def test_models_documents_get_abilities_editor(is_authenticated, reach):
     """
     Check abilities returned for a document giving editor role to link holders
     i.e anonymous users or authenticated users who have no specific role on the document.
     """
     document = factories.DocumentFactory(link_reach=reach, link_role="editor")
     user = factories.UserFactory() if is_authenticated else AnonymousUser()
-    expected_abilities = {
-        "accesses_manage": False,
-        "accesses_view": False,
+    abilities = document.get_abilities(user)
+    assert abilities == {
         "ai_transform": True,
         "ai_translate": True,
         "attachment_upload": True,
-        "children_create": is_authenticated,
-        "children_list": True,
-        "collaboration_auth": True,
         "destroy": False,
-        "favorite": is_authenticated,
-        "invite_owner": False,
         "link_configuration": False,
-        "media_auth": True,
-        "move": False,
+        "invite_owner": False,
+        "manage_accesses": False,
         "partial_update": True,
-        "restore": False,
         "retrieve": True,
         "update": True,
         "versions_destroy": False,
         "versions_list": False,
         "versions_retrieve": False,
     }
-    nb_queries = 1 if is_authenticated else 0
-    with django_assert_num_queries(nb_queries):
-        assert document.get_abilities(user) == expected_abilities
-    document.soft_delete()
-    document.refresh_from_db()
-    assert all(value is False for value in document.get_abilities(user).values())
 
 
-def test_models_documents_get_abilities_owner(django_assert_num_queries):
+def test_models_documents_get_abilities_owner():
     """Check abilities returned for the owner of a document."""
     user = factories.UserFactory()
-    document = factories.DocumentFactory(users=[(user, "owner")])
-    expected_abilities = {
-        "accesses_manage": True,
-        "accesses_view": True,
+    access = factories.UserDocumentAccessFactory(role="owner", user=user)
+    abilities = access.document.get_abilities(access.user)
+    assert abilities == {
         "ai_transform": True,
         "ai_translate": True,
         "attachment_upload": True,
-        "children_create": True,
-        "children_list": True,
-        "collaboration_auth": True,
         "destroy": True,
-        "favorite": True,
-        "invite_owner": True,
         "link_configuration": True,
-        "media_auth": True,
-        "move": True,
+        "invite_owner": True,
+        "manage_accesses": True,
         "partial_update": True,
-        "restore": True,
         "retrieve": True,
         "update": True,
         "versions_destroy": True,
         "versions_list": True,
         "versions_retrieve": True,
     }
-    with django_assert_num_queries(1):
-        assert document.get_abilities(user) == expected_abilities
-    document.soft_delete()
-    document.refresh_from_db()
-    expected_abilities["move"] = False
-    assert document.get_abilities(user) == expected_abilities
 
 
-def test_models_documents_get_abilities_administrator(django_assert_num_queries):
+def test_models_documents_get_abilities_administrator():
     """Check abilities returned for the administrator of a document."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(users=[(user, "administrator")])
-    expected_abilities = {
-        "accesses_manage": True,
-        "accesses_view": True,
+    access = factories.UserDocumentAccessFactory(role="administrator")
+    abilities = access.document.get_abilities(access.user)
+    assert abilities == {
         "ai_transform": True,
         "ai_translate": True,
         "attachment_upload": True,
-        "children_create": True,
-        "children_list": True,
-        "collaboration_auth": True,
         "destroy": False,
-        "favorite": True,
-        "invite_owner": False,
         "link_configuration": True,
-        "media_auth": True,
-        "move": True,
+        "invite_owner": False,
+        "manage_accesses": True,
         "partial_update": True,
-        "restore": False,
         "retrieve": True,
         "update": True,
         "versions_destroy": True,
         "versions_list": True,
         "versions_retrieve": True,
     }
-    with django_assert_num_queries(1):
-        assert document.get_abilities(user) == expected_abilities
-    document.soft_delete()
-    document.refresh_from_db()
-    assert all(value is False for value in document.get_abilities(user).values())
 
 
 def test_models_documents_get_abilities_editor_user(django_assert_num_queries):
     """Check abilities returned for the editor of a document."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(users=[(user, "editor")])
-    expected_abilities = {
-        "accesses_manage": False,
-        "accesses_view": True,
+    access = factories.UserDocumentAccessFactory(role="editor")
+
+    with django_assert_num_queries(1):
+        abilities = access.document.get_abilities(access.user)
+
+    assert abilities == {
         "ai_transform": True,
         "ai_translate": True,
         "attachment_upload": True,
-        "children_create": True,
-        "children_list": True,
-        "collaboration_auth": True,
         "destroy": False,
-        "favorite": True,
-        "invite_owner": False,
         "link_configuration": False,
-        "media_auth": True,
-        "move": False,
+        "invite_owner": False,
+        "manage_accesses": False,
         "partial_update": True,
-        "restore": False,
         "retrieve": True,
         "update": True,
         "versions_destroy": False,
         "versions_list": True,
         "versions_retrieve": True,
     }
-    with django_assert_num_queries(1):
-        assert document.get_abilities(user) == expected_abilities
-    document.soft_delete()
-    document.refresh_from_db()
-    assert all(value is False for value in document.get_abilities(user).values())
 
 
 def test_models_documents_get_abilities_reader_user(django_assert_num_queries):
     """Check abilities returned for the reader of a document."""
-    user = factories.UserFactory()
-    document = factories.DocumentFactory(users=[(user, "reader")])
-    access_from_link = (
-        document.link_reach != "restricted" and document.link_role == "editor"
+    access = factories.UserDocumentAccessFactory(
+        role="reader", document__link_role="reader"
     )
-    expected_abilities = {
-        "accesses_manage": False,
-        "accesses_view": True,
-        "ai_transform": access_from_link,
-        "ai_translate": access_from_link,
-        "attachment_upload": access_from_link,
-        "children_create": access_from_link,
-        "children_list": True,
-        "collaboration_auth": True,
+
+    with django_assert_num_queries(1):
+        abilities = access.document.get_abilities(access.user)
+
+    assert abilities == {
+        "ai_transform": False,
+        "ai_translate": False,
+        "attachment_upload": False,
         "destroy": False,
-        "favorite": True,
-        "invite_owner": False,
         "link_configuration": False,
-        "media_auth": True,
-        "move": False,
-        "partial_update": access_from_link,
-        "restore": False,
+        "invite_owner": False,
+        "manage_accesses": False,
+        "partial_update": False,
         "retrieve": True,
-        "update": access_from_link,
+        "update": False,
         "versions_destroy": False,
         "versions_list": True,
         "versions_retrieve": True,
     }
-    with django_assert_num_queries(1):
-        assert document.get_abilities(user) == expected_abilities
-    document.soft_delete()
-    document.refresh_from_db()
-    assert all(value is False for value in document.get_abilities(user).values())
 
 
 def test_models_documents_get_abilities_preset_role(django_assert_num_queries):
@@ -422,22 +269,14 @@ def test_models_documents_get_abilities_preset_role(django_assert_num_queries):
         abilities = access.document.get_abilities(access.user)
 
     assert abilities == {
-        "accesses_manage": False,
-        "accesses_view": True,
         "ai_transform": False,
         "ai_translate": False,
         "attachment_upload": False,
-        "children_create": False,
-        "children_list": True,
-        "collaboration_auth": True,
         "destroy": False,
-        "favorite": True,
-        "invite_owner": False,
         "link_configuration": False,
-        "media_auth": True,
-        "move": False,
+        "invite_owner": False,
+        "manage_accesses": False,
         "partial_update": False,
-        "restore": False,
         "retrieve": True,
         "update": False,
         "versions_destroy": False,
@@ -549,8 +388,8 @@ def test_models_documents__email_invitation__success():
     assert len(mail.outbox) == 0
 
     sender = factories.UserFactory(full_name="Test Sender", email="sender@example.com")
-    document.send_invitation_email(
-        "guest@example.com", models.RoleChoices.EDITOR, sender, "en"
+    document.email_invitation(
+        "en", "guest@example.com", models.RoleChoices.EDITOR, sender
     )
 
     # pylint: disable-next=no-member
@@ -563,8 +402,8 @@ def test_models_documents__email_invitation__success():
     email_content = " ".join(email.body.split())
 
     assert (
-        f"Test Sender (sender@example.com) invited you with the role "editor" "
-        f"on the following document: {document.title}" in email_content
+        f'Test Sender (sender@example.com) invited you with the role "editor" '
+        f"on the following document : {document.title}" in email_content
     )
     assert f"docs/{document.id}/" in email_content
 
@@ -581,11 +420,11 @@ def test_models_documents__email_invitation__success_fr():
     sender = factories.UserFactory(
         full_name="Test Sender2", email="sender2@example.com"
     )
-    document.send_invitation_email(
+    document.email_invitation(
+        "fr-fr",
         "guest2@example.com",
         models.RoleChoices.OWNER,
         sender,
-        "fr-fr",
     )
 
     # pylint: disable-next=no-member
@@ -598,8 +437,8 @@ def test_models_documents__email_invitation__success_fr():
     email_content = " ".join(email.body.split())
 
     assert (
-        f"Test Sender2 (sender2@example.com) vous a invité avec le rôle "propriétaire" "
-        f"sur le document suivant: {document.title}" in email_content
+        f'Test Sender2 (sender2@example.com) vous a invité avec le rôle "propriétaire" '
+        f"sur le document suivant : {document.title}" in email_content
     )
     assert f"docs/{document.id}/" in email_content
 
@@ -617,11 +456,11 @@ def test_models_documents__email_invitation__failed(mock_logger, _mock_send_mail
     assert len(mail.outbox) == 0
 
     sender = factories.UserFactory()
-    document.send_invitation_email(
+    document.email_invitation(
+        "en",
         "guest3@example.com",
         models.RoleChoices.ADMIN,
         sender,
-        "en",
     )
 
     # No email has been sent
@@ -633,68 +472,9 @@ def test_models_documents__email_invitation__failed(mock_logger, _mock_send_mail
 
     (
         _,
-        emails,
+        email,
         exception,
     ) = mock_logger.call_args.args
 
-    assert emails == ["guest3@example.com"]
+    assert email == "guest3@example.com"
     assert isinstance(exception, smtplib.SMTPException)
-
-
-# Document number of accesses
-
-
-def test_models_documents_nb_accesses_cache_is_set_and_retrieved(
-    django_assert_num_queries,
-):
-    """Test that nb_accesses is cached after the first computation."""
-    document = factories.DocumentFactory()
-    key = f"document_{document.id!s}_nb_accesses"
-    nb_accesses = random.randint(1, 4)
-    factories.UserDocumentAccessFactory.create_batch(nb_accesses, document=document)
-    factories.UserDocumentAccessFactory()  # An unrelated access should not be counted
-
-    # Initially, the nb_accesses should not be cached
-    assert cache.get(key) is None
-
-    # Compute the nb_accesses for the first time (this should set the cache)
-    with django_assert_num_queries(1):
-        assert document.nb_accesses == nb_accesses
-
-    # Ensure that the nb_accesses is now cached
-    with django_assert_num_queries(0):
-        assert document.nb_accesses == nb_accesses
-    assert cache.get(key) == nb_accesses
-
-    # The cache value should be invalidated when a document access is created
-    models.DocumentAccess.objects.create(
-        document=document, user=factories.UserFactory(), role="reader"
-    )
-    assert cache.get(key) is None  # Cache should be invalidated
-    with django_assert_num_queries(1):
-        new_nb_accesses = document.nb_accesses
-    assert new_nb_accesses == nb_accesses + 1
-    assert cache.get(key) == new_nb_accesses  # Cache should now contain the new value
-
-
-def test_models_documents_nb_accesses_cache_is_invalidated_on_access_removal(
-    django_assert_num_queries,
-):
-    """Test that the cache is invalidated when a document access is deleted."""
-    document = factories.DocumentFactory()
-    key = f"document_{document.id!s}_nb_accesses"
-    access = factories.UserDocumentAccessFactory(document=document)
-
-    # Initially, the nb_accesses should be cached
-    assert document.nb_accesses == 1
-    assert cache.get(key) == 1
-
-    # Remove the access and check if cache is invalidated
-    access.delete()
-    assert cache.get(key) is None  # Cache should be invalidated
-
-    # Recompute the nb_accesses (this should trigger a cache set)
-    with django_assert_num_queries(1):
-        new_nb_accesses = document.nb_accesses
-    assert new_nb_accesses == 0
-    assert cache.get(key) == 0  # Cache should now contain the new value

src/backend/core/tests/test_models_invitations.py

@@ -144,7 +144,7 @@ def test_models_invitationd_new_user_filter_expired_invitations():
     ).exists()
 
 
-@pytest.mark.parametrize("num_invitations, num_queries", [(0, 3), (1, 7), (20, 7)])
+@pytest.mark.parametrize("num_invitations, num_queries", [(0, 3), (1, 6), (20, 6)])
 def test_models_invitationd_new_userd_user_creation_constant_num_queries(
     django_assert_num_queries, num_invitations, num_queries
 ):

src/backend/core/tests/test_models_templates.py

@@ -2,6 +2,10 @@
 Unit tests for the Template model
 """
 
+import os
+import time
+from unittest import mock
+
 from django.contrib.auth.models import AnonymousUser
 from django.core.exceptions import ValidationError
 
@@ -58,7 +62,7 @@ def test_models_templates_get_abilities_anonymous_public():
         "destroy": False,
         "retrieve": True,
         "update": False,
-        "accesses_manage": False,
+        "manage_accesses": False,
         "partial_update": False,
         "generate_document": True,
     }
@@ -72,7 +76,7 @@ def test_models_templates_get_abilities_anonymous_not_public():
         "destroy": False,
         "retrieve": False,
         "update": False,
-        "accesses_manage": False,
+        "manage_accesses": False,
         "partial_update": False,
         "generate_document": False,
     }
@@ -86,7 +90,7 @@ def test_models_templates_get_abilities_authenticated_public():
         "destroy": False,
         "retrieve": True,
         "update": False,
-        "accesses_manage": False,
+        "manage_accesses": False,
         "partial_update": False,
         "generate_document": True,
     }
@@ -100,7 +104,7 @@ def test_models_templates_get_abilities_authenticated_not_public():
         "destroy": False,
         "retrieve": False,
         "update": False,
-        "accesses_manage": False,
+        "manage_accesses": False,
         "partial_update": False,
         "generate_document": False,
     }
@@ -115,7 +119,7 @@ def test_models_templates_get_abilities_owner():
         "destroy": True,
         "retrieve": True,
         "update": True,
-        "accesses_manage": True,
+        "manage_accesses": True,
         "partial_update": True,
         "generate_document": True,
     }
@@ -129,7 +133,7 @@ def test_models_templates_get_abilities_administrator():
         "destroy": False,
         "retrieve": True,
         "update": True,
-        "accesses_manage": True,
+        "manage_accesses": True,
         "partial_update": True,
         "generate_document": True,
     }
@@ -146,7 +150,7 @@ def test_models_templates_get_abilities_editor_user(django_assert_num_queries):
         "destroy": False,
         "retrieve": True,
         "update": True,
-        "accesses_manage": False,
+        "manage_accesses": False,
         "partial_update": True,
         "generate_document": True,
     }
@@ -163,7 +167,7 @@ def test_models_templates_get_abilities_reader_user(django_assert_num_queries):
         "destroy": False,
         "retrieve": True,
         "update": False,
-        "accesses_manage": False,
+        "manage_accesses": False,
         "partial_update": False,
         "generate_document": True,
     }
@@ -181,7 +185,35 @@ def test_models_templates_get_abilities_preset_role(django_assert_num_queries):
         "destroy": False,
         "retrieve": True,
         "update": False,
-        "accesses_manage": False,
+        "manage_accesses": False,
         "partial_update": False,
         "generate_document": True,
     }
+
+
+def test_models_templates__generate_word():
+    """Generate word document and assert no tmp files are left in /tmp folder."""
+    template = factories.TemplateFactory()
+    response = template.generate_word("<p>Test body</p>", {})
+
+    assert response.status_code == 200
+    assert len([f for f in os.listdir("/tmp") if f.startswith("docx_")]) == 0
+
+
+@mock.patch(
+    "pypandoc.convert_text",
+    side_effect=RuntimeError("Conversion failed"),
+)
+def test_models_templates__generate_word__raise_error(_mock_pypandoc):
+    """
+    Generate word document and assert no tmp files are left in /tmp folder
+    even when the conversion fails.
+    """
+    template = factories.TemplateFactory()
+
+    try:
+        template.generate_word("<p>Test body</p>", {})
+    except RuntimeError as e:
+        assert str(e) == "Conversion failed"
+        time.sleep(0.5)
+        assert len([f for f in os.listdir("/tmp") if f.startswith("docx_")]) == 0

src/backend/core/tests/test_services_ai_services.py

@@ -102,24 +102,3 @@ def test_api_ai__success_sanitize(mock_create):
     response = AIService().transform("hello", "prompt")
 
     assert response == {"answer": "Salut\n \tle \nmonde"}
-
-
-@override_settings(
-    AI_BASE_URL="http://example.com", AI_API_KEY="test-key", AI_MODEL="test-model"
-)
-@patch("openai.resources.chat.completions.Completions.create")
-def test_api_ai__success_when_sanitize_fails(mock_create):
-    """The AI request should work as expected even with badly formatted response."""
-
-    # pylint: disable=C0303
-    answer = """{ 
-        "answer"        :       
-        "Salut le monde"
-    }"""
-    mock_create.return_value = MagicMock(
-        choices=[MagicMock(message=MagicMock(content=answer))]
-    )
-
-    response = AIService().transform("hello", "prompt")
-
-    assert response == {"answer": "Salut le monde"}

src/backend/core/tests/test_services_collaboration_services.py

@@ -1,185 +0,0 @@
-"""
-This module contains tests for the CollaborationService class in the
-core.services.collaboration_services module.
-"""
-
-import json
-import re
-from contextlib import contextmanager
-
-from django.core.exceptions import ImproperlyConfigured
-
-import pytest
-import requests
-import responses
-
-from core.services.collaboration_services import CollaborationService
-
-
-@pytest.fixture
-def mock_reset_connections(settings):
-    """
-    Creates a context manager to mock the reset-connections endpoint for collaboration services.
-    Args:
-        settings: A settings object that contains the configuration for the collaboration API.
-    Returns:
-        A context manager function that mocks the reset-connections endpoint.
-    The context manager function takes the following parameters:
-        document_id (str): The ID of the document for which connections are being reset.
-        user_id (str, optional): The ID of the user making the request. Defaults to None.
-    Usage:
-        with mock_reset_connections(settings)(document_id, user_id) as mock:
-            # Your test code here
-    The context manager performs the following actions:
-        - Mocks the reset-connections endpoint using responses.RequestsMock.
-        - Sets the COLLABORATION_API_URL and COLLABORATION_SERVER_SECRET in the settings.
-        - Verifies that the reset-connections endpoint is called exactly once.
-        - Checks that the request URL and headers are correct.
-        - If user_id is provided, checks that the X-User-Id header is correct.
-    """
-
-    @contextmanager
-    def _mock_reset_connections(document_id, user_id=None):
-        with responses.RequestsMock() as rsps:
-            # Mock the reset-connections endpoint
-            settings.COLLABORATION_API_URL = "http://example.com/"
-            settings.COLLABORATION_SERVER_SECRET = "secret-token"
-            endpoint_url = (
-                f"{settings.COLLABORATION_API_URL}reset-connections/?room={document_id}"
-            )
-            rsps.add(
-                responses.POST,
-                endpoint_url,
-                json={},
-                status=200,
-            )
-            yield
-
-            assert len(rsps.calls) == 1, (
-                "Expected one call to reset-connections endpoint"
-            )
-            request = rsps.calls[0].request
-            assert request.url == endpoint_url, f"Unexpected URL called: {request.url}"
-            assert (
-                request.headers.get("Authorization")
-                == settings.COLLABORATION_SERVER_SECRET
-            ), "Incorrect Authorization header"
-
-            if user_id:
-                assert request.headers.get("X-User-Id") == user_id, (
-                    "Incorrect X-User-Id header"
-                )
-
-    return _mock_reset_connections
-
-
-def test_init_without_api_url(settings):
-    """Test that ImproperlyConfigured is raised when COLLABORATION_API_URL is None."""
-    settings.COLLABORATION_API_URL = None
-    with pytest.raises(ImproperlyConfigured):
-        CollaborationService()
-
-
-def test_init_with_api_url(settings):
-    """Test that the service initializes correctly when COLLABORATION_API_URL is set."""
-    settings.COLLABORATION_API_URL = "http://example.com/"
-    service = CollaborationService()
-    assert isinstance(service, CollaborationService)
-
-
-@responses.activate
-def test_reset_connections_with_user_id(settings):
-    """Test reset_connections with a provided user_id."""
-    settings.COLLABORATION_API_URL = "http://example.com/"
-    settings.COLLABORATION_SERVER_SECRET = "secret-token"
-    service = CollaborationService()
-
-    room = "room1"
-    user_id = "user123"
-    endpoint_url = "http://example.com/reset-connections/?room=" + room
-
-    responses.add(responses.POST, endpoint_url, json={}, status=200)
-
-    service.reset_connections(room, user_id)
-
-    assert len(responses.calls) == 1
-    request = responses.calls[0].request
-
-    assert request.url == endpoint_url
-    assert request.headers.get("Authorization") == "secret-token"
-    assert request.headers.get("X-User-Id") == "user123"
-
-
-@responses.activate
-def test_reset_connections_without_user_id(settings):
-    """Test reset_connections without a user_id."""
-    settings.COLLABORATION_API_URL = "http://example.com/"
-    settings.COLLABORATION_SERVER_SECRET = "secret-token"
-    service = CollaborationService()
-
-    room = "room1"
-    user_id = None
-    endpoint_url = "http://example.com/reset-connections/?room=" + room
-
-    responses.add(
-        responses.POST,
-        endpoint_url,
-        json={},
-        status=200,
-    )
-
-    service.reset_connections(room, user_id)
-
-    assert len(responses.calls) == 1
-    request = responses.calls[0].request
-
-    assert request.url == endpoint_url
-    assert request.headers.get("Authorization") == "secret-token"
-    assert request.headers.get("X-User-Id") is None
-
-
-@responses.activate
-def test_reset_connections_non_200_response(settings):
-    """Test that an HTTPError is raised when the response status is not 200."""
-    settings.COLLABORATION_API_URL = "http://example.com/"
-    settings.COLLABORATION_SERVER_SECRET = "secret-token"
-    service = CollaborationService()
-
-    room = "room1"
-    user_id = "user123"
-    endpoint_url = "http://example.com/reset-connections/?room=" + room
-    response_body = {"error": "Internal Server Error"}
-
-    responses.add(responses.POST, endpoint_url, json=response_body, status=500)
-
-    expected_exception_message = re.escape(
-        "Failed to notify WebSocket server. Status code: 500, Response: "
-    ) + re.escape(json.dumps(response_body))
-
-    with pytest.raises(requests.HTTPError, match=expected_exception_message):
-        service.reset_connections(room, user_id)
-
-    assert len(responses.calls) == 1
-
-
-@responses.activate
-def test_reset_connections_request_exception(settings):
-    """Test that an HTTPError is raised when a RequestException occurs."""
-    settings.COLLABORATION_API_URL = "http://example.com/"
-    settings.COLLABORATION_SERVER_SECRET = "secret-token"
-    service = CollaborationService()
-
-    room = "room1"
-    user_id = "user123"
-    endpoint_url = "http://example.com/reset-connections?room=" + room
-
-    responses.add(
-        responses.POST,
-        endpoint_url,
-        body=requests.exceptions.ConnectionError("Network error"),
-    )
-
-    with pytest.raises(requests.HTTPError, match="Failed to notify WebSocket server."):
-        service.reset_connections(room, user_id)
-
-    assert len(responses.calls) == 1

src/backend/core/tests/test_services_converter_services.py

@@ -1,147 +0,0 @@
-"""Test converter services."""
-
-from unittest.mock import MagicMock, patch
-
-import pytest
-import requests
-
-from core.services.converter_services import (
-    InvalidResponseError,
-    MissingContentError,
-    ServiceUnavailableError,
-    ValidationError,
-    YdocConverter,
-)
-
-
-def test_auth_header(settings):
-    """Test authentication header generation."""
-    settings.Y_PROVIDER_API_KEY = "test-key"
-    converter = YdocConverter()
-    assert converter.auth_header == "test-key"
-
-
-def test_convert_markdown_empty_text():
-    """Should raise ValidationError when text is empty."""
-    converter = YdocConverter()
-    with pytest.raises(ValidationError, match="Input text cannot be empty"):
-        converter.convert_markdown("")
-
-
-@patch("requests.post")
-def test_convert_markdown_service_unavailable(mock_post):
-    """Should raise ServiceUnavailableError when service is unavailable."""
-    converter = YdocConverter()
-
-    mock_post.side_effect = requests.RequestException("Connection error")
-
-    with pytest.raises(
-        ServiceUnavailableError,
-        match="Failed to connect to conversion service",
-    ):
-        converter.convert_markdown("test text")
-
-
-@patch("requests.post")
-def test_convert_markdown_http_error(mock_post):
-    """Should raise ServiceUnavailableError when HTTP error occurs."""
-    converter = YdocConverter()
-
-    mock_response = MagicMock()
-    mock_response.raise_for_status.side_effect = requests.HTTPError("HTTP Error")
-    mock_post.return_value = mock_response
-
-    with pytest.raises(
-        ServiceUnavailableError,
-        match="Failed to connect to conversion service",
-    ):
-        converter.convert_markdown("test text")
-
-
-@patch("requests.post")
-def test_convert_markdown_invalid_json_response(mock_post):
-    """Should raise InvalidResponseError when response is not valid JSON."""
-    converter = YdocConverter()
-
-    mock_response = MagicMock()
-    mock_response.json.side_effect = ValueError("Invalid JSON")
-    mock_post.return_value = mock_response
-
-    with pytest.raises(
-        InvalidResponseError,
-        match="Could not parse conversion service response",
-    ):
-        converter.convert_markdown("test text")
-
-
-@patch("requests.post")
-def test_convert_markdown_missing_content_field(mock_post, settings):
-    """Should raise MissingContentError when response is missing required field."""
-
-    settings.CONVERSION_API_CONTENT_FIELD = "expected_field"
-
-    converter = YdocConverter()
-
-    mock_response = MagicMock()
-    mock_response.json.return_value = {"wrong_field": "content"}
-    mock_post.return_value = mock_response
-
-    with pytest.raises(
-        MissingContentError,
-        match="Response missing required field: expected_field",
-    ):
-        converter.convert_markdown("test text")
-
-
-@patch("requests.post")
-def test_convert_markdown_full_integration(mock_post, settings):
-    """Test full integration with all settings."""
-
-    settings.Y_PROVIDER_API_BASE_URL = "http://test.com/"
-    settings.Y_PROVIDER_API_KEY = "test-key"
-    settings.CONVERSION_API_ENDPOINT = "conversion-endpoint"
-    settings.CONVERSION_API_TIMEOUT = 5
-    settings.CONVERSION_API_CONTENT_FIELD = "content"
-
-    converter = YdocConverter()
-
-    expected_content = {"converted": "content"}
-    mock_response = MagicMock()
-    mock_response.json.return_value = {"content": expected_content}
-    mock_post.return_value = mock_response
-
-    result = converter.convert_markdown("test markdown")
-
-    assert result == expected_content
-    mock_post.assert_called_once_with(
-        "http://test.com/conversion-endpoint/",
-        json={"content": "test markdown"},
-        headers={
-            "Authorization": "test-key",
-            "Content-Type": "application/json",
-        },
-        timeout=5,
-        verify=False,
-    )
-
-
-@patch("requests.post")
-def test_convert_markdown_timeout(mock_post):
-    """Should raise ServiceUnavailableError when request times out."""
-    converter = YdocConverter()
-
-    mock_post.side_effect = requests.Timeout("Request timed out")
-
-    with pytest.raises(
-        ServiceUnavailableError,
-        match="Failed to connect to conversion service",
-    ):
-        converter.convert_markdown("test text")
-
-
-def test_convert_markdown_none_input():
-    """Should raise ValidationError when input is None."""
-    converter = YdocConverter()
-
-    with pytest.raises(ValidationError, match="Input text cannot be empty"):
-        converter.convert_markdown(None)