🔖(minor) release 1.6.0

Added: - ✨AI to doc editor - ✨(backend) allow uploading more types of attachments - ✨(frontend) add buttons to copy document to clipboard as HTML/Markdown Changed: - ♻️(frontend) More multi theme friendly - ♻️ Bootstrap frontend - ♻️ Add username in email Fixed: - 🛂(backend) do not duplicate user when disabled - 🐛(frontend) invalidate queries after removing user - 🐛(backend) Fix dysfunctional permissions on document create - 🐛(backend) fix nginx docker container - 🐛(frontend) fix copy paste firefox
⬆️(frontend) upgrade blocknote to 0.17.0
2026-05-07 23:52:04 +02:00 · 2024-10-17 17:50:57 +02:00 · 2024-10-17 17:15:22 +02:00 · 2024-10-17 16:54:40 +02:00
14 changed files with 104 additions and 35 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,9 @@ and this project adheres to

 ## [Unreleased]

+
+## [1.6.0] - 2024-10-17
+
 ## Added

 - ✨AI to doc editor #250
@@ -23,9 +26,12 @@ and this project adheres to

 ## Fixed

+- 🛂(backend) do not duplicate user when disabled
 - 🐛(frontend) invalidate queries after removing user #336
 - 🐛(backend) Fix dysfunctional permissions on document create #329
 - 🐛(backend) fix nginx docker container #340
+- 🐛(frontend) fix copy paste firefox #353
+

 ## [1.5.1] - 2024-10-10

@@ -205,7 +211,8 @@ and this project adheres to
 - 🚀 Impress, project to manage your documents easily and collaboratively.


-[unreleased]: https://github.com/numerique-gouv/impress/compare/v1.5.1...main
+[unreleased]: https://github.com/numerique-gouv/impress/compare/v1.6.0...main
+[v1.6.0]: https://github.com/numerique-gouv/impress/releases/v1.6.0
 [1.5.1]: https://github.com/numerique-gouv/impress/releases/v1.5.1
 [1.5.0]: https://github.com/numerique-gouv/impress/releases/v1.5.0
 [1.4.0]: https://github.com/numerique-gouv/impress/releases/v1.4.0
--- a/src/backend/core/authentication/backends.py
+++ b/src/backend/core/authentication/backends.py
@@ -84,6 +84,8 @@ class OIDCAuthenticationBackend(MozillaOIDCAuthenticationBackend):
        user = self.get_existing_user(sub, email)

        if user:
+            if not user.is_active:
+                raise SuspiciousOperation(_("User account is disabled"))
            self.update_user_if_needed(user, claims)
        elif self.get_settings("OIDC_CREATE_USER", True):
            user = User.objects.create(sub=sub, password="!", **claims)  # noqa: S106
@@ -101,11 +103,11 @@ class OIDCAuthenticationBackend(MozillaOIDCAuthenticationBackend):
    def get_existing_user(self, sub, email):
        """Fetch existing user by sub or email."""
        try:
-            return User.objects.get(sub=sub, is_active=True)
+            return User.objects.get(sub=sub)
        except User.DoesNotExist:
            if email and settings.OIDC_FALLBACK_TO_EMAIL_FOR_IDENTIFICATION:
                try:
-                    return User.objects.get(email=email, is_active=True)
+                    return User.objects.get(email=email)
                except User.DoesNotExist:
                    pass
        return None
--- a/src/backend/core/tests/authentication/test_backends.py
+++ b/src/backend/core/tests/authentication/test_backends.py
@@ -305,3 +305,63 @@ def test_authentication_get_userinfo_invalid_response():
        match="Invalid response format or token verification failed",
    ):
        oidc_backend.get_userinfo("fake_access_token", None, None)
+
+
+def test_authentication_getter_existing_disabled_user_via_sub(
+    django_assert_num_queries, monkeypatch
+):
+    """
+    If an existing user matches the sub but is disabled,
+    an error should be raised and a user should not be created.
+    """
+
+    klass = OIDCAuthenticationBackend()
+    db_user = UserFactory(is_active=False)
+
+    def get_userinfo_mocked(*args):
+        return {
+            "sub": db_user.sub,
+            "email": db_user.email,
+            "first_name": "John",
+            "last_name": "Doe",
+        }
+
+    monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
+
+    with (
+        django_assert_num_queries(1),
+        pytest.raises(SuspiciousOperation, match="User account is disabled"),
+    ):
+        klass.get_or_create_user(access_token="test-token", id_token=None, payload=None)
+
+    assert models.User.objects.count() == 1
+
+
+def test_authentication_getter_existing_disabled_user_via_email(
+    django_assert_num_queries, monkeypatch
+):
+    """
+    If an existing user does not matches the sub but matches the email and is disabled,
+    an error should be raised and a user should not be created.
+    """
+
+    klass = OIDCAuthenticationBackend()
+    db_user = UserFactory(is_active=False)
+
+    def get_userinfo_mocked(*args):
+        return {
+            "sub": "random",
+            "email": db_user.email,
+            "first_name": "John",
+            "last_name": "Doe",
+        }
+
+    monkeypatch.setattr(OIDCAuthenticationBackend, "get_userinfo", get_userinfo_mocked)
+
+    with (
+        django_assert_num_queries(2),
+        pytest.raises(SuspiciousOperation, match="User account is disabled"),
+    ):
+        klass.get_or_create_user(access_token="test-token", id_token=None, payload=None)
+
+    assert models.User.objects.count() == 1
--- a/src/backend/pyproject.toml
+++ b/src/backend/pyproject.toml
@@ -7,7 +7,7 @@ build-backend = "setuptools.build_meta"

 [project]
 name = "impress"
-version = "1.5.1"
+version = "1.6.0"
 authors = [{ "name" = "DINUM", "email" = "dev@mail.numerique.gouv.fr" }]
 classifiers = [
    "Development Status :: 5 - Production/Stable",
--- a/src/frontend/apps/e2e/package.json
+++ b/src/frontend/apps/e2e/package.json
@@ -1,6 +1,6 @@
 {
  "name": "app-e2e",
-  "version": "1.5.1",
+  "version": "1.6.0",
  "private": true,
  "scripts": {
    "lint": "eslint . --ext .ts",
--- a/src/frontend/apps/impress/package.json
+++ b/src/frontend/apps/impress/package.json
@@ -1,6 +1,6 @@
 {
  "name": "app-impress",
-  "version": "1.5.1",
+  "version": "1.6.0",
  "private": true,
  "scripts": {
    "dev": "next dev",
--- a/src/frontend/package.json
+++ b/src/frontend/package.json
@@ -1,6 +1,6 @@
 {
  "name": "impress",
-  "version": "1.5.1",
+  "version": "1.6.0",
  "private": true,
  "workspaces": {
    "packages": [
@@ -25,9 +25,9 @@
    "i18n:test": "yarn I18N run test"
  },
  "resolutions": {
-    "@blocknote/core": "0.16.0",
-    "@blocknote/mantine": "0.16.0",
-    "@blocknote/react": "0.16.0",
+    "@blocknote/core": "0.17.0",
+    "@blocknote/mantine": "0.17.0",
+    "@blocknote/react": "0.17.0",
    "@types/node": "20.16.12",
    "@types/react-dom": "18.3.1",
    "@typescript-eslint/eslint-plugin": "8.9.0",
--- a/src/frontend/packages/eslint-config-impress/package.json
+++ b/src/frontend/packages/eslint-config-impress/package.json
@@ -1,6 +1,6 @@
 {
  "name": "eslint-config-impress",
-  "version": "1.5.1",
+  "version": "1.6.0",
  "license": "MIT",
  "scripts": {
    "lint": "eslint --ext .js ."
--- a/src/frontend/packages/i18n/package.json
+++ b/src/frontend/packages/i18n/package.json
@@ -1,6 +1,6 @@
 {
  "name": "packages-i18n",
-  "version": "1.5.1",
+  "version": "1.6.0",
  "private": true,
  "scripts": {
    "extract-translation": "yarn extract-translation:impress",
--- a/src/frontend/servers/y-provider/package.json
+++ b/src/frontend/servers/y-provider/package.json
@@ -1,6 +1,6 @@
 {
  "name": "server-y-provider",
-  "version": "1.5.1",
+  "version": "1.6.0",
  "description": "Y.js provider for docs",
  "repository": "https://github.com/numerique-gouv/impress",
  "license": "MIT",
--- a/src/frontend/yarn.lock
+++ b/src/frontend/yarn.lock
@@ -1007,10 +1007,10 @@
  resolved "https://registry.yarnpkg.com/@bcoe/v8-coverage/-/v8-coverage-0.2.3.tgz#75a2e8b51cb758a7553d6804a5932d7aace75c39"
  integrity sha512-0hYQ8SB4Db5zvZB4axdMHGwEaQjkZzFjQiN9LVYvIFB2nSUHW9tYpxWriPrWDASIxiaXax83REcLxuSdnGPZtw==

-"@blocknote/core@*", "@blocknote/core@0.16.0", "@blocknote/core@^0.16.0":
-  version "0.16.0"
-  resolved "https://registry.yarnpkg.com/@blocknote/core/-/core-0.16.0.tgz#3904da086c4241d1bce41c3c1bdb910e68fe9eff"
-  integrity sha512-egX+GjlAB8r/zaox278zNTTUMNVRHVQ2qVlPHQZgGOXSDq2Z+Lm7i4xKYMz/UT/IdrL7iGxnHrAsbc0H/kqc9A==
+"@blocknote/core@*", "@blocknote/core@0.17.0", "@blocknote/core@^0.17.0":
+  version "0.17.0"
+  resolved "https://registry.yarnpkg.com/@blocknote/core/-/core-0.17.0.tgz#c87e84ee8bd5b5d4c41e646002732d414d9f67f7"
+  integrity sha512-hvqOTgmYJejWczNb9wLCBEjE0lgrkmEJgqi+wka8Z2CRkLaMV4wB1XEoncjpjtoKJeJjvhmmGuCBrfoEoYgTWw==
  dependencies:
    "@emoji-mart/data" "^1.2.1"
    "@tiptap/core" "^2.7.1"
@@ -1054,13 +1054,13 @@
    y-protocols "^1.0.6"
    yjs "^13.6.15"

-"@blocknote/mantine@*", "@blocknote/mantine@0.16.0":
-  version "0.16.0"
-  resolved "https://registry.yarnpkg.com/@blocknote/mantine/-/mantine-0.16.0.tgz#513dadfe0c2891319ee684e1084a91b7ea983699"
-  integrity sha512-5jLXuKWz6xoba8odYv8+SalLSSE5YdYEvtuQyEO605VTtm37VELyjI5Tswwv/mcTd3th2AR3g4GY0Zj/T07lZw==
+"@blocknote/mantine@*", "@blocknote/mantine@0.17.0":
+  version "0.17.0"
+  resolved "https://registry.yarnpkg.com/@blocknote/mantine/-/mantine-0.17.0.tgz#a7fd1c89a7dd2a28b8e7e547a8dbcde96d358f79"
+  integrity sha512-GPS7QH5UI543tQQMkyUd69Tf3nZ/r2VFbAJmllcgBni3bVgaIM3Cj7LJXbo4tOz60thUdzYt6qso5nmjhdn4aw==
  dependencies:
-    "@blocknote/core" "^0.16.0"
-    "@blocknote/react" "^0.16.0"
+    "@blocknote/core" "^0.17.0"
+    "@blocknote/react" "^0.17.0"
    "@mantine/core" "^7.10.1"
    "@mantine/hooks" "^7.10.1"
    "@mantine/utils" "^6.0.21"
@@ -1068,12 +1068,12 @@
    react-dom "^18"
    react-icons "^5.2.1"

-"@blocknote/react@*", "@blocknote/react@0.16.0", "@blocknote/react@^0.16.0":
-  version "0.16.0"
-  resolved "https://registry.yarnpkg.com/@blocknote/react/-/react-0.16.0.tgz#a5d7de21914aab467b2e849e34a4d00dc1732542"
-  integrity sha512-vEwAp4z1FBqcH75OEbEW/yd4nj8XcSKAzCElV7aL6nVhPiKgYzrzG/WVckTq1h9lMaGeAuYqLErww4IIsbiawg==
+"@blocknote/react@*", "@blocknote/react@0.17.0", "@blocknote/react@^0.17.0":
+  version "0.17.0"
+  resolved "https://registry.yarnpkg.com/@blocknote/react/-/react-0.17.0.tgz#fe1ce962b2fe402798b4c6e764f06ea6a97a058c"
+  integrity sha512-a/ViJKyuC029nrGgVPey/+nIkspWkceW/WwhSWUymem8GfZAI02PJoUWq2riwhgaDsEDJyw7ufiVg6ZA8FvdPw==
  dependencies:
-    "@blocknote/core" "^0.16.0"
+    "@blocknote/core" "^0.17.0"
    "@floating-ui/react" "^0.26.4"
    "@tiptap/core" "^2.7.1"
    "@tiptap/react" "^2.7.1"
--- a/src/helm/env.d/preprod/values.impress.yaml.gotmpl
+++ b/src/helm/env.d/preprod/values.impress.yaml.gotmpl
@@ -1,7 +1,7 @@
 image:
  repository: lasuite/impress-backend
  pullPolicy: Always
-  tag: "v1.5.1-preprod"
+  tag: "v1.6.0-preprod"

 backend:
  migrateJobAnnotations:
@@ -133,13 +133,13 @@ frontend:
  image:
    repository: lasuite/impress-frontend
    pullPolicy: Always
-    tag: "v1.5.1-preprod"
+    tag: "v1.6.0-preprod"

 yProvider:
  image:
    repository: lasuite/impress-y-provider
    pullPolicy: Always
-    tag: "v1.5.1-preprod"
+    tag: "v1.6.0-preprod"

 ingress:
  enabled: true
--- a/src/helm/env.d/production/values.impress.yaml.gotmpl
+++ b/src/helm/env.d/production/values.impress.yaml.gotmpl
@@ -1,7 +1,7 @@
 image:
  repository: lasuite/impress-backend
  pullPolicy: Always
-  tag: "v1.5.1"
+  tag: "v1.6.0"

 backend:
  migrateJobAnnotations:
@@ -133,13 +133,13 @@ frontend:
  image:
    repository: lasuite/impress-frontend
    pullPolicy: Always
-    tag: "v1.5.1"
+    tag: "v1.6.0"

 yProvider:
  image:
    repository: lasuite/impress-y-provider
    pullPolicy: Always
-    tag: "v1.5.1"
+    tag: "v1.6.0"

 ingress:
  enabled: true
--- a/src/mail/package.json
+++ b/src/mail/package.json
@@ -1,6 +1,6 @@
 {
  "name": "mail_mjml",
-  "version": "1.5.1",
+  "version": "1.6.0",
  "description": "An util to generate html and text django's templates from mjml templates",
  "type": "module",
  "dependencies": {