mirror of
https://github.com/glittercowboy/get-shit-done
synced 2026-04-25 17:25:23 +02:00
fix(ci): add Node 18 skip condition for c8 v11 coverage step
c8 v11 requires Node 20+ (engines: ^20.0.0 || >=22.0.0). Node 18 now runs plain npm test on PRs to avoid engine mismatch. Also removes redundant --exclude flag from test:coverage script. Also: fix ROADMAP.md progress table alignment (rows 7-12), mark Phase 7 complete, add requirements-completed to 09-01-SUMMARY.md.
This commit is contained in:
7
.github/workflows/test.yml
vendored
7
.github/workflows/test.yml
vendored
@@ -41,5 +41,10 @@ jobs:
|
||||
run: npm test
|
||||
|
||||
- name: Run tests with coverage
|
||||
if: github.event_name == 'pull_request'
|
||||
# c8 v11 requires Node 20+ (engines: ^20.0.0 || >=22.0.0). Node 18 EOL April 2025.
|
||||
if: github.event_name == 'pull_request' && matrix.node-version != 18
|
||||
run: npm run test:coverage
|
||||
|
||||
- name: Run tests (Node 18, coverage not supported)
|
||||
if: github.event_name == 'pull_request' && matrix.node-version == 18
|
||||
run: npm test
|
||||
|
||||
@@ -0,0 +1,37 @@
|
||||
---
|
||||
phase: 13-verification-milestone-cleanup
|
||||
plan: "03"
|
||||
subsystem: documentation
|
||||
tags: [verification, coverage, cov-tooling, retroactive]
|
||||
requirements-completed: [COV-01, COV-02, COV-03]
|
||||
duration: 2min
|
||||
completed: 2026-02-25
|
||||
---
|
||||
|
||||
# Phase 13 Plan 03: Create 12-VERIFICATION.md Summary
|
||||
|
||||
**12-VERIFICATION.md created for Phase 12, retroactively confirming COV-01, COV-02, COV-03 with live test run evidence**
|
||||
|
||||
## Performance
|
||||
|
||||
- **Duration:** 2 min
|
||||
- **Completed:** 2026-02-25
|
||||
- **Tasks:** 2
|
||||
- **Files modified:** 1
|
||||
|
||||
## Accomplishments
|
||||
|
||||
- Ran `npm run test:coverage` (433 pass, 0 fail; all 11 modules above 70%) to capture live evidence
|
||||
- Confirmed CI workflow has `Run tests with coverage` step with `if: github.event_name == 'pull_request'`
|
||||
- Created 12-VERIFICATION.md at .planning/phases/12-coverage-tooling/12-VERIFICATION.md
|
||||
- All 3 COV requirements (COV-01–03) confirmed PASS with specific evidence
|
||||
- Phase 12 Goal verified: c8 integrated, 70% threshold enforced, CI workflow operational
|
||||
|
||||
## Files Created/Modified
|
||||
|
||||
- `.planning/phases/12-coverage-tooling/12-VERIFICATION.md` — Phase 12 verification (72 lines)
|
||||
|
||||
## Self-Check: PASSED
|
||||
|
||||
- 12-VERIFICATION.md: created, verified COV-01–03 references present (grep count: 5)
|
||||
- Commit: bd9bdad (docs)
|
||||
@@ -46,6 +46,6 @@
|
||||
"build:hooks": "node scripts/build-hooks.js",
|
||||
"prepublishOnly": "npm run build:hooks",
|
||||
"test": "node --test tests/*.test.cjs",
|
||||
"test:coverage": "c8 --check-coverage --lines 70 --reporter text --include 'get-shit-done/bin/lib/*.cjs' --exclude 'get-shit-done/bin/gsd-tools.cjs' --exclude 'tests/**' --all node --test tests/*.test.cjs"
|
||||
"test:coverage": "c8 --check-coverage --lines 70 --reporter text --include 'get-shit-done/bin/lib/*.cjs' --exclude 'tests/**' --all node --test tests/*.test.cjs"
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user