mirror of
https://github.com/glittercowboy/get-shit-done
synced 2026-04-25 17:25:23 +02:00
84de0cc760
- Add chmod +x for .sh hooks during install (fixes #1755 permission denied) - Fix Codex hook: wrong path (get-shit-done/hooks/) and inverted filename (gsd-update-check.js → gsd-check-update.js) - Fix cache invalidation path from ~/cache/ to ~/.cache/gsd/ - Track .sh hooks in writeManifest so saveLocalPatches detects modifications - Add gsd-workflow-guard.js to uninstall file cleanup list - Add community hooks (session-state, validate-commit, phase-boundary) to uninstall settings.json cleanup - Remove phantom gsd-check-update.sh from uninstall list - Remove dead isCursor/isWindsurf branches in uninstall (already handled by combined branch) - Warn when expected .sh hooks are missing after verifyInstalled - Add 15 regression tests in install-hooks-copy.test.cjs - Update codex-config.test.cjs assertions for corrected hook filename Fixes #1755
47 lines
2.2 KiB
Markdown
47 lines
2.2 KiB
Markdown
# Plan: Fix Install Process Issues (#1755 + Full Audit)
|
|
|
|
## Overview
|
|
Full cleanup of install.js addressing all issues found during comprehensive audit.
|
|
All changes in `bin/install.js` unless noted.
|
|
|
|
## Changes
|
|
|
|
### Fix 1: Add chmod +x for .sh hooks during install (CRITICAL)
|
|
**Line 5391-5392** — After `fs.copyFileSync`, add `fs.chmodSync(destFile, 0o755)` for `.sh` files.
|
|
|
|
### Fix 2: Fix Codex hook path and filename (CRITICAL)
|
|
**Line 5485** — Change `gsd-update-check.js` to `gsd-check-update.js` and fix path from `get-shit-done/hooks/` to `hooks/`.
|
|
**Line 5492** — Update dedup check to use `gsd-check-update`.
|
|
|
|
### Fix 3: Fix stale cache invalidation path (CRITICAL)
|
|
**Line 5406** — Change from `path.join(path.dirname(targetDir), 'cache', ...)` to `path.join(os.homedir(), '.cache', 'gsd', 'gsd-update-check.json')`.
|
|
|
|
### Fix 4: Track .sh hooks in manifest (MEDIUM)
|
|
**Line 4972** — Change filter from `file.endsWith('.js')` to `(file.endsWith('.js') || file.endsWith('.sh'))`.
|
|
|
|
### Fix 5: Add gsd-workflow-guard.js to uninstall hook list (MEDIUM)
|
|
**Line 4404** — Add `'gsd-workflow-guard.js'` to the `gsdHooks` array.
|
|
|
|
### Fix 6: Add community hooks to uninstall settings.json cleanup (MEDIUM)
|
|
**Lines 4453-4520** — Add filters for `gsd-session-state`, `gsd-validate-commit`, `gsd-phase-boundary` in the appropriate event cleanup blocks (SessionStart, PreToolUse, PostToolUse).
|
|
|
|
### Fix 7: Remove phantom gsd-check-update.sh from uninstall list (LOW)
|
|
**Line 4404** — Remove `'gsd-check-update.sh'` from `gsdHooks` array.
|
|
|
|
### Fix 8: Remove dead isCursor/isWindsurf branches in uninstall (LOW)
|
|
Remove the unreachable duplicate `else if (isCursor)` and `else if (isWindsurf)` branches.
|
|
|
|
### Fix 9: Improve verifyInstalled() for hooks (LOW)
|
|
After the generic check, warn if expected `.sh` files are missing (non-fatal warning).
|
|
|
|
## New Test File
|
|
`tests/install-hooks-copy.test.cjs` — Regression tests covering:
|
|
- .sh files copied to target dir
|
|
- .sh files are executable after copy
|
|
- .sh files tracked in manifest
|
|
- settings.json hook paths match installed files
|
|
- uninstall removes community hooks from settings.json
|
|
- uninstall removes gsd-workflow-guard.js
|
|
- Codex hook uses correct filename
|
|
- Cache path resolves correctly
|