Tom Boucher
cd05725576
fix( #2661 ): unconditional plan-checkbox sync in execute-plan ( #2682 )
...
* fix(#2661 ): unconditional plan-checkbox sync in execute-plan
Checkpoint A in execute-plan.md was wrapped in a "Skip in parallel mode"
guard that also short-circuited the parallelization-without-worktrees
case. With `parallelization: true, use_worktrees: false`, only
Checkpoint C (phase.complete) then remained, and any interruption
between the final SUMMARY write and phase complete left ROADMAP.md
plan checkboxes stale.
Remove the guard: `roadmap update-plan-progress` is idempotent and
atomically serialized via readModifyWriteRoadmapMd's lockfile, so
concurrent invocations from parallel plans converge safely.
Checkpoint B (worktree-merge post-step) and Checkpoint C
(phase.complete) become redundant after A is unconditional; their
removal is deferred to a follow-up per the RCA.
Closes #2661
* fix(#2661 ): gate ROADMAP sync on use_worktrees=false to preserve single-writer contract
Adversarial review of PR #2682 found that unconditionally removing the
IS_WORKTREE guard violates the single-writer contract for shared
ROADMAP.md established by commit dcb50396 (PR #1486 ). The lockfile only
serializes within a single working tree; separate worktrees have
separate ROADMAP.md files that diverge.
Restore the worktree guard but document its intent explicitly: the
in-handler sync runs only when use_worktrees=false (the actual #2661
reproducer). Worktree mode relies on the orchestrator's post-merge
update at execute-phase.md lines 815-834, which is the documented
single-writer for shared tracking files.
Update tests to assert both branches of the gate:
- use_worktrees: false mode runs the sync (the #2661 case)
- use_worktrees: true mode does NOT run the in-handler sync
- handler-level idempotence and lockfile contention tests retained,
scope clarified to within-tree concurrency only
2026-04-24 20:27:59 -04:00
..
2026-04-22 21:57:24 -04:00
2026-04-04 14:29:03 -04:00
2026-04-12 17:56:19 -04:00
2026-04-17 10:47:08 -04:00
2026-04-12 09:40:20 -04:00
2026-04-11 03:39:29 -07:00
2026-04-20 09:31:34 -04:00
2026-04-10 10:49:00 -04:00
2026-04-04 14:29:03 -04:00
2026-04-04 14:29:03 -04:00
2026-04-04 14:29:03 -04:00
2026-04-10 12:30:46 -04:00
2026-04-11 03:30:05 -07:00
2026-04-07 17:27:20 -04:00
2026-04-05 23:07:52 -04:00
2026-04-04 14:29:03 -04:00
2026-04-15 22:46:31 -04:00
2026-04-15 14:59:18 -04:00
2026-04-04 14:29:03 -04:00
2026-04-04 07:58:27 -04:00
2026-04-04 07:24:31 -04:00
2026-04-11 08:50:44 -04:00
2026-04-07 08:13:52 -04:00
2026-04-05 17:49:20 -04:00
2026-04-05 17:32:18 -04:00
2026-04-05 18:05:32 -04:00
2026-04-05 18:20:11 -04:00
2026-04-19 16:35:32 -05:00
2026-04-07 17:36:47 -04:00
2026-04-22 12:04:06 -04:00
2026-04-07 17:19:10 -04:00
2026-04-19 16:35:32 -05:00
2026-04-10 10:48:00 -04:00
2026-04-11 03:35:00 -07:00
2026-04-11 03:37:34 -07:00
2026-04-10 10:50:17 -04:00
2026-04-10 11:19:32 -04:00
2026-04-10 11:25:55 -04:00
2026-04-10 11:15:59 -04:00
2026-04-10 12:07:13 -04:00
2026-04-10 21:37:08 -04:00
2026-04-19 16:35:32 -05:00
2026-04-15 14:58:41 -04:00
2026-04-23 11:58:06 -04:00
2026-04-17 09:20:26 -04:00
2026-04-17 09:29:59 -04:00
2026-04-22 10:41:58 -04:00
2026-04-17 09:26:49 -04:00
2026-04-17 09:20:42 -04:00
2026-04-20 10:10:16 -04:00
2026-04-20 18:37:42 -04:00
2026-04-20 10:10:16 -04:00
2026-04-20 10:10:16 -04:00
2026-04-20 10:09:33 -04:00
2026-04-23 11:54:11 -04:00
2026-04-20 10:09:33 -04:00
2026-04-20 10:09:33 -04:00
2026-04-20 10:09:33 -04:00
2026-04-20 10:11:00 -04:00
2026-04-20 10:10:16 -04:00
2026-04-20 10:11:00 -04:00
2026-04-19 15:40:50 -05:00
2026-04-23 08:36:03 -04:00
2026-04-20 10:08:46 -04:00
2026-04-20 18:37:32 -04:00
2026-04-24 18:05:16 -04:00
2026-04-21 09:46:01 -04:00
2026-04-21 10:10:45 -04:00
2026-04-21 21:20:27 -04:00
2026-04-21 10:10:10 -04:00
2026-04-21 21:35:22 -04:00
2026-04-22 12:09:12 -04:00
2026-04-22 10:41:58 -04:00
2026-04-21 20:33:43 -04:00
2026-04-21 20:33:24 -04:00
2026-04-21 21:18:58 -04:00
2026-04-22 11:28:25 -04:00
2026-04-22 12:04:25 -04:00
2026-04-22 12:04:17 -04:00
2026-04-22 21:57:24 -04:00
2026-04-22 12:03:56 -04:00
2026-04-22 12:04:06 -04:00
2026-04-22 12:04:13 -04:00
2026-04-24 18:05:10 -04:00
2026-04-24 18:10:45 -04:00
2026-04-24 18:05:33 -04:00
2026-04-24 18:05:40 -04:00
2026-04-24 18:05:18 -04:00
2026-04-24 18:05:04 -04:00
2026-04-24 20:22:17 -04:00
2026-04-24 20:22:29 -04:00
2026-04-24 20:27:59 -04:00
2026-04-07 08:13:58 -04:00
2026-04-23 08:36:03 -04:00
2026-04-22 21:57:24 -04:00
2026-04-06 15:14:02 -04:00
2026-04-11 09:15:36 -04:00
2026-04-22 12:04:25 -04:00
2026-04-24 18:05:40 -04:00
2026-04-20 09:31:34 -04:00
2026-04-10 13:58:16 -04:00
2026-04-04 14:29:03 -04:00
2026-04-11 09:19:32 -04:00
2026-04-12 08:10:30 -04:00
2026-04-20 09:54:35 -04:00
2026-04-10 10:46:21 -04:00
2026-04-24 18:09:01 -04:00
2026-04-20 09:31:34 -04:00
2026-04-15 14:59:35 -04:00
2026-04-05 17:02:20 -04:00
2026-04-10 10:56:09 -04:00
2026-04-04 14:29:03 -04:00
2026-04-20 09:31:34 -04:00
2026-04-07 17:25:11 -04:00
2026-04-22 11:28:25 -04:00
2026-04-24 18:05:16 -04:00
2026-04-15 16:46:10 -04:00
2026-04-04 14:29:03 -04:00
2026-04-20 10:08:49 -04:00
2026-04-24 18:05:33 -04:00
2026-04-11 09:20:27 -04:00
2026-04-04 14:29:03 -04:00
2026-04-11 09:18:49 -04:00
2026-04-19 23:12:23 -04:00
2026-04-05 09:15:41 -04:00
2026-04-15 16:23:09 -04:00
2026-04-22 21:57:24 -04:00
2026-04-04 14:29:03 -04:00
2026-04-22 21:57:24 -04:00
2026-04-04 14:29:03 -04:00
2026-04-01 08:47:31 -06:00
2026-04-22 21:21:44 -04:00
2026-04-21 08:40:39 -04:00
2026-04-20 18:21:43 -04:00
2026-04-20 18:27:55 -04:00
2026-04-20 18:20:08 -04:00
2026-04-20 18:21:35 -04:00
2026-04-20 18:25:24 -04:00
2026-04-20 18:19:14 -04:00
2026-04-20 18:19:21 -04:00
2026-04-20 18:21:23 -04:00
2026-04-22 12:04:21 -04:00
2026-04-04 14:29:03 -04:00
2026-04-22 12:04:25 -04:00
2026-04-04 14:29:03 -04:00
2026-04-05 18:33:27 -04:00
2026-04-11 09:28:16 -04:00
2026-04-22 20:49:52 -04:00
2026-04-05 18:33:17 -04:00
2026-04-15 22:46:31 -04:00
2026-04-04 14:29:03 -04:00
2026-04-11 23:47:50 -04:00
2026-04-15 22:46:31 -04:00
2026-04-16 17:08:44 -04:00
2026-04-10 21:30:13 -04:00
2026-04-19 15:55:37 -05:00
2026-04-22 20:50:15 -04:00
2026-04-20 10:08:46 -04:00
2026-04-15 22:46:31 -04:00
2026-04-04 14:37:54 -04:00
2026-04-04 14:29:03 -04:00
2026-04-04 14:15:30 -04:00
2026-04-04 14:29:03 -04:00
2026-04-20 09:31:34 -04:00
2026-04-04 14:29:03 -04:00
2026-04-22 12:04:25 -04:00
2026-04-17 17:12:34 -05:00
2026-04-15 14:59:07 -04:00
2026-04-17 09:20:26 -04:00
2026-04-20 10:08:40 -04:00
2026-04-20 09:54:35 -04:00
2026-04-18 08:42:36 -05:00
2026-04-23 11:53:51 -04:00
2026-04-15 14:59:24 -04:00
2026-04-20 09:31:34 -04:00
2026-04-20 09:39:05 -04:00
2026-04-20 09:39:05 -04:00
2026-04-10 12:30:24 -04:00
2026-04-22 23:00:37 -04:00
2026-04-24 18:06:13 -04:00
2026-04-10 11:47:22 -04:00
2026-04-05 19:09:14 -04:00
2026-04-07 17:39:29 -04:00
2026-04-14 17:57:38 -04:00
2026-04-04 14:29:03 -04:00
2026-04-04 14:29:03 -04:00
2026-04-15 14:59:12 -04:00
2026-04-07 17:26:31 -04:00
2026-04-15 22:46:31 -04:00
2026-04-06 08:54:18 -04:00
2026-04-04 15:52:13 -04:00
2026-04-05 17:03:17 -04:00
2026-04-10 21:55:44 -04:00
2026-04-05 18:05:32 -04:00
2026-04-07 08:13:46 -04:00
2026-04-11 09:02:30 -04:00
2026-04-04 14:29:03 -04:00
2026-04-03 12:47:24 +03:00
2026-04-12 17:56:39 -04:00
2026-04-14 17:57:38 -04:00
2026-04-06 15:13:23 -04:00
2026-04-04 14:29:03 -04:00
2026-04-04 14:29:03 -04:00
2026-04-16 17:15:29 -04:00
2026-04-04 14:29:03 -04:00
2026-04-11 15:02:55 -04:00
2026-04-11 09:16:11 -04:00
2026-04-12 15:56:20 -04:00
2026-04-20 10:08:52 -04:00
2026-04-04 14:29:03 -04:00
2026-04-20 09:54:35 -04:00
2026-04-10 12:41:59 -04:00
2026-04-20 09:31:34 -04:00
2026-04-20 18:09:02 -04:00
2026-04-11 10:26:27 -04:00
2026-04-04 14:29:03 -04:00
2026-04-22 23:03:59 -04:00
2026-04-05 12:41:17 -04:00
2026-04-15 07:39:48 -06:00
2026-04-04 14:29:03 -04:00
2026-04-15 16:23:18 -04:00
2026-04-16 17:22:31 -04:00
2026-04-11 09:34:29 -04:00
2026-04-17 10:11:08 -04:00
2026-04-05 10:23:41 -04:00
2026-04-04 14:29:03 -04:00
2026-04-05 10:23:41 -04:00
2026-04-15 22:46:31 -04:00
2026-04-11 11:19:47 -04:00
2026-04-24 18:05:40 -04:00
2026-04-04 14:29:03 -04:00
2026-04-22 10:41:58 -04:00
2026-04-16 17:22:31 -04:00
2026-04-10 12:29:25 -04:00
2026-04-06 15:20:06 -04:00
2026-04-10 10:44:15 -04:00
2026-04-23 11:53:20 -04:00
2026-04-04 14:29:03 -04:00
2026-04-15 14:59:56 -04:00
2026-04-05 17:04:33 -04:00
2026-04-01 16:53:20 -04:00
2026-04-20 10:08:49 -04:00
2026-04-04 14:29:03 -04:00
2026-03-24 13:33:58 -04:00
2026-04-20 10:08:18 -04:00
2026-04-12 17:56:00 -04:00
2026-04-04 07:10:21 -04:00
2026-04-22 21:41:00 -04:00
2026-04-04 14:29:03 -04:00
2026-04-10 13:55:27 -04:00
2026-04-15 10:35:29 -04:00
2026-04-11 15:02:55 -04:00
2026-04-20 10:08:43 -04:00
2026-04-04 14:29:03 -04:00
2026-04-11 15:39:50 -04:00
2026-04-11 09:15:00 -04:00
2026-04-04 14:29:03 -04:00
2026-04-05 17:49:20 -04:00
2026-04-22 21:57:24 -04:00
2026-04-15 22:46:31 -04:00
2026-04-04 14:29:03 -04:00
2026-04-20 10:08:18 -04:00
2026-04-22 12:04:25 -04:00
2026-04-21 10:10:10 -04:00
2026-04-12 17:56:19 -04:00
2026-04-15 22:46:31 -04:00
2026-04-11 03:24:49 -07:00
2026-04-02 18:55:17 -03:00
2026-04-22 12:04:25 -04:00
2026-04-04 14:29:03 -04:00
2026-04-04 14:29:03 -04:00
2026-04-04 14:29:03 -04:00
2026-04-06 08:40:37 -04:00
2026-04-05 22:54:12 -04:00
2026-04-05 12:30:24 -04:00
2026-04-22 21:57:24 -04:00
2026-04-15 22:46:31 -04:00
2026-04-02 21:36:36 -05:00
2026-04-04 14:29:03 -04:00
2026-04-05 11:11:38 -04:00
2026-04-10 12:30:08 -04:00
2026-04-04 14:29:03 -04:00