eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Remove files from .prettierignore

Browse Source 
.prettierignore had files listed for an issue with 'using' declarations,
this is no longer an issue for prettier (tested on 3.6.2).
This commit is contained in:
Adam Patterson
2025-10-02 09:52:42 -07:00
committed by Tim Flynn
parent 52009170da
commit 0eac4cc6ad
Notes: github-actions[bot] 2025-10-09 19:53:12 +00:00 
Author: https://github.com/adamrt
Commit: https://github.com/LadybirdBrowser/ladybird/commit/0eac4cc6ad5
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6383
Reviewed-by: https://github.com/gmta
Reviewed-by: https://github.com/trflynn89 ✅
3 changed files with 33 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.prettierignore
View File

@@ -3,10 +3,7 @@ Libraries/LibJS/Tests/unicode-identifier-escape.js
Libraries/LibJS/Tests/modules/failing.mjs
# FIXME: Remove once prettier is updated to support using declarations.
Libraries/LibJS/Tests/builtins/DisposableStack/DisposableStack.prototype.@@dispose.js
Libraries/LibJS/Tests/modules/top-level-dispose.mjs
Libraries/LibJS/Tests/using-declaration.js
Libraries/LibJS/Tests/using-for-loops.js
Tests/LibWeb/Crash/wpt-import/
Tests/LibWeb/Ref/input/wpt-import

22
Libraries/LibJS/Tests/modules/top-level-dispose.mjs
View File

@@ -1,14 +1,28 @@
export let passed = false;
let failed = false;
if (passed)
if (passed) {
failed = true;
}
using a = { [Symbol.dispose]() { if (!failed) passed = true; } }
using a = {
[Symbol.dispose]() {
if (!failed) {
passed = true;
}
},
};
if (passed)
if (passed) {
failed = true;
}
failed = true;
// Should trigger before
using b = { [Symbol.dispose]() { if (!passed) failed = false; } }
using b = {
[Symbol.dispose]() {
if (!passed) {
failed = false;
}
},
};

27
Libraries/LibJS/Tests/using-for-loops.js
View File

@@ -63,16 +63,16 @@ describe("basic usage", () => {
[Symbol.dispose]() {
expect(this.value).toBe(value);
disposable.push(value);
}
},
};
}
for (using a of [createDisposable('a'), createDisposable('b'), createDisposable('c')]) {
for (using a of [createDisposable("a"), createDisposable("b"), createDisposable("c")]) {
expect(disposable).toEqual(values);
values.push(a.value);
}
expect(disposable).toEqual(['a', 'b', 'c']);
expect(disposable).toEqual(["a", "b", "c"]);
});
test.xfail("using in for of loop with expression body", () => {
@@ -82,11 +82,12 @@ describe("basic usage", () => {
const obj = {
[Symbol.dispose]() {
disposableCalls++;
}
},
};
for (using a of [obj, obj, obj])
for (using a of [obj, obj, obj]) {
expect(disposableCalls).toBe(i++);
}
expect(disposableCalls).toBe(3);
});
@@ -96,12 +97,13 @@ describe("basic usage", () => {
const a = {
[Symbol.dispose]() {
disposed++;
}
}
},
};
expect(disposed).toBe(0);
for (using b = a, c = a; false;)
for (using b = a, c = a; false; ) {
expect().fail();
}
expect(disposed).toBe(2);
});
@@ -126,7 +128,7 @@ describe("basic usage", () => {
test.xfail("can have using in block in for-in loop", () => {
const disposed = [];
const values = [];
for (const i in ['a', 'b', 'c']) {
for (const i in ["a", "b", "c"]) {
using a = {
val: i,
[Symbol.dispose]() {
@@ -145,14 +147,15 @@ describe("basic usage", () => {
const obj = {
[Symbol.dispose]() {
expect()
expect();
disposableCalls++;
}
},
};
try {
for (using a of [obj])
for (using a of [obj]) {
throw new ExpectationError("Expected in for-of");
}
expect().fail("Should have thrown");
} catch (e) {