eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibIPC: Inline some generated if statements / function calls

Browse Source
This commit is contained in:
Timothy Flynn
2026-04-23 08:01:18 -04:00
committed by Tim Flynn
parent 90d53c0d12
commit 373db4e157
Notes: github-actions[bot] 2026-04-23 13:43:15 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/373db4e1570
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/9051
1 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
Meta/Generators/generate_ipc_definitions.py
View File

@@ -500,17 +500,10 @@ def write_proxy_method(
out.write(f"\n return move(*{sync_call});")
elif is_try:
out.write(f"""
auto result = m_connection.template send_sync_but_allow_failure<Messages::{endpoint.name}::{pascal_name}>({call_args});
if (!result) {{
m_connection.shutdown();
return IPC::ErrorCode::PeerDisconnected;
}}
""")
if inner_return_type != "void":
out.write(" return move(*result);")
else:
out.write(" return {};")
if (auto result = m_connection.template send_sync_but_allow_failure<Messages::{endpoint.name}::{pascal_name}>({call_args}))
return {"{}" if inner_return_type == "void" else "move(*result)"};
m_connection.shutdown();
return IPC::ErrorCode::PeerDisconnected;""")
else:
# Async messages silently ignore send failures (e.g. peer disconnected).
out.write(f"""
@@ -577,9 +570,8 @@ public:
FixedMemoryStream stream {{ buffer }};
auto message_endpoint_magic = TRY(stream.read_value<u32>());
if (message_endpoint_magic != {endpoint.magic}) {{
if (message_endpoint_magic != static_magic())
return Error::from_string_literal("Endpoint magic number mismatch, not my message!");
}}
auto message_id = TRY(stream.read_value<i32>());
@@ -594,7 +586,7 @@ public:
pascal_name = pascal_case(name)
out.write(f"""
case (int)Messages::{endpoint.name}::MessageID::{pascal_name}:
return TRY(Messages::{endpoint.name}::{pascal_name}::decode(stream, attachments));""")
return Messages::{endpoint.name}::{pascal_name}::decode(stream, attachments);""")
out.write(f"""
default: