eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Use the real globalThis value

Browse Source 
Previously it used `realm.[[GlobalObject]]` instead of
`realm.[[GlobalEnv]].[[GlobalThisValue]]`.

In LibWeb, that corresponds to Window and WindowProxy respectively.
This commit is contained in:
Luke Wilde
2026-04-23 19:19:01 +01:00
committed by Luke Wilde
parent 36e6323d1f
commit 3d3b02b9c0
Notes: github-actions[bot] 2026-04-23 19:44:08 +00:00 
Author: https://github.com/Lubrsi
Commit: https://github.com/LadybirdBrowser/ladybird/commit/3d3b02b9c09
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/9058
3 changed files with 32 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibJS/Runtime/GlobalObject.cpp
View File

@@ -114,7 +114,7 @@ void set_default_global_bindings(Realm& realm)
global.define_direct_property(vm.names.encodeURIComponent, realm.intrinsics().encode_uri_component_function(), attr);
// 19.1 Value Properties of the Global Object, https://tc39.es/ecma262/#sec-value-properties-of-the-global-object
global.define_direct_property(vm.names.globalThis, &global, attr);
global.define_direct_property(vm.names.globalThis, &realm.global_environment().global_this_value(), attr);
global.define_direct_property(vm.names.Infinity, js_infinity(), 0);
global.define_direct_property(vm.names.NaN, js_nan(), 0);
global.define_direct_property(vm.names.undefined, js_undefined(), 0);

9
Tests/LibWeb/Text/expected/HTML/globalThis-is-WindowProxy.txt Normal file
View File

@@ -0,0 +1,9 @@
globalThis === window: true
globalThis === self: true
globalThis === frames: true
globalThis === this: true
iframe contentWindow === iframe globalThis: true
iframe globalThis === iframe self: true
iframe realm globalThis === window: true
globalThis !== iframe globalThis: true
Object.getPrototypeOf(globalThis) === Object.getPrototypeOf(window): true

22
Tests/LibWeb/Text/input/HTML/globalThis-is-WindowProxy.html Normal file
View File

@@ -0,0 +1,22 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<iframe id="ifr" srcdoc=""></iframe>
<script>
test(() => {
println(`globalThis === window: ${globalThis === window}`);
println(`globalThis === self: ${globalThis === self}`);
println(`globalThis === frames: ${globalThis === frames}`);
println(`globalThis === this: ${globalThis === this}`);
const iframeWindow = ifr.contentWindow;
println(`iframe contentWindow === iframe globalThis: ${iframeWindow === iframeWindow.globalThis}`);
println(`iframe globalThis === iframe self: ${iframeWindow.globalThis === iframeWindow.self}`);
iframeWindow.eval("window.__check = globalThis === window;");
println(`iframe realm globalThis === window: ${iframeWindow.__check}`);
println(`globalThis !== iframe globalThis: ${globalThis !== iframeWindow.globalThis}`);
println(`Object.getPrototypeOf(globalThis) === Object.getPrototypeOf(window): ${Object.getPrototypeOf(globalThis) === Object.getPrototypeOf(window)}`);
});
</script>