eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWebView: Remove new tab page URL from sanitize_urls API

Browse Source 
This used to come from UI-specific settings (e.g. QSettings). But it's
stored in LibWebView now, so we don't need callers to provide it.
This commit is contained in:
Timothy Flynn
2026-04-24 07:47:57 -04:00
committed by Andreas Kling
parent cc6e048bd6
commit 83eda625d5
Notes: github-actions[bot] 2026-04-24 18:18:30 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/83eda625d59
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/9072
4 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWebView/Application.cpp
View File

@@ -293,7 +293,7 @@ ErrorOr<void> Application::initialize(Main::Arguments const& arguments)
disable_site_isolation = true;
m_browser_options = {
.urls = sanitize_urls(raw_urls, m_settings.new_tab_page_url()),
.urls = sanitize_urls(raw_urls),
.raw_urls = move(raw_urls),
.headless_mode = headless_mode,
.new_window = new_window ? NewWindow::Yes : NewWindow::No,

4
Libraries/LibWebView/BrowserProcess.cpp
View File

@@ -183,13 +183,13 @@ void UIProcessConnectionFromClient::die()
void UIProcessConnectionFromClient::create_new_tab(Vector<ByteString> urls)
{
if (on_new_tab)
on_new_tab(sanitize_urls(urls, Application::settings().new_tab_page_url()));
on_new_tab(sanitize_urls(urls));
}
void UIProcessConnectionFromClient::create_new_window(Vector<ByteString> urls)
{
if (on_new_window)
on_new_window(sanitize_urls(urls, Application::settings().new_tab_page_url()));
on_new_window(sanitize_urls(urls));
}
}

5
Libraries/LibWebView/URL.cpp
View File

@@ -11,6 +11,7 @@
#include <LibFileSystem/FileSystem.h>
#include <LibURL/Parser.h>
#include <LibURL/PublicSuffixData.h>
#include <LibWebView/Application.h>
#include <LibWebView/Autocomplete.h>
#include <LibWebView/URL.h>
@@ -158,7 +159,7 @@ bool autocomplete_url_can_complete(StringView query, StringView suggestion)
return normalized_suggestion.starts_with_bytes(normalized_query, CaseSensitivity::CaseInsensitive);
}
Vector<URL::URL> sanitize_urls(ReadonlySpan<ByteString> raw_urls, URL::URL const& new_tab_page_url)
Vector<URL::URL> sanitize_urls(ReadonlySpan<ByteString> raw_urls)
{
Vector<URL::URL> sanitized_urls;
sanitized_urls.ensure_capacity(raw_urls.size());
@@ -169,7 +170,7 @@ Vector<URL::URL> sanitize_urls(ReadonlySpan<ByteString> raw_urls, URL::URL const
}
if (sanitized_urls.is_empty())
sanitized_urls.append(new_tab_page_url);
sanitized_urls.append(Application::settings().new_tab_page_url());
return sanitized_urls;
}

2
Libraries/LibWebView/URL.h
View File

@@ -20,7 +20,7 @@ enum class AppendTLD {
};
WEBVIEW_API Optional<URL::URL> sanitize_url(StringView, Optional<SearchEngine> const& search_engine = {}, AppendTLD = AppendTLD::No);
WEBVIEW_API bool location_looks_like_url(StringView, AppendTLD = AppendTLD::No);
WEBVIEW_API Vector<URL::URL> sanitize_urls(ReadonlySpan<ByteString> raw_urls, URL::URL const& new_tab_page_url);
WEBVIEW_API Vector<URL::URL> sanitize_urls(ReadonlySpan<ByteString> raw_urls);
struct URLParts {
StringView scheme_and_subdomain;