eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

AK: Remove fast_u32_xxx apis from Memory.h

Browse Source 
This commit removes the fast_u32_fill and fast_u32_copy functions,
as they were only used in one place, and are not optimal.
This commit is contained in:
R-Goc
2025-02-22 23:57:34 +01:00
committed by Alexander Kalenik
parent fe2b752083
commit 94de31ff3b
Notes: github-actions[bot] 2025-03-03 14:59:27 +00:00 
Author: https://github.com/R-Goc
Commit: https://github.com/LadybirdBrowser/ladybird/commit/94de31ff3b4
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3673
Reviewed-by: https://github.com/gmta
2 changed files with 5 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
AK/Memory.h
View File

@@ -10,32 +10,6 @@
#include <AK/Types.h>
#include <string.h>
ALWAYS_INLINE void fast_u32_copy(u32* dest, u32 const* src, size_t count)
{
#if ARCH(X86_64)
asm volatile(
"rep movsl\n"
: "+S"(src), "+D"(dest), "+c"(count)::"memory");
#else
__builtin_memcpy(dest, src, count * 4);
#endif
}
ALWAYS_INLINE void fast_u32_fill(u32* dest, u32 value, size_t count)
{
#if ARCH(X86_64)
asm volatile(
"rep stosl\n"
: "=D"(dest), "=c"(count)
: "D"(dest), "c"(count), "a"(value)
: "memory");
#else
for (auto* p = dest; p < (dest + count); ++p) {
*p = value;
}
#endif
}
namespace AK {
inline void secure_zero(void* ptr, size_t size)

6
Libraries/LibGfx/ImageFormats/GIFLoader.cpp
View File

@@ -127,8 +127,12 @@ static void clear_rect(Bitmap& bitmap, IntRect const& rect, Color color)
ARGB32* dst = bitmap.scanline(intersection_rect.top()) + intersection_rect.left();
size_t const dst_skip = bitmap.pitch() / sizeof(ARGB32);
auto const value = color.value();
auto const width = intersection_rect.width();
for (int i = intersection_rect.height() - 1; i >= 0; --i) {
fast_u32_fill(dst, color.value(), intersection_rect.width());
for (ARGB32* p = dst; p < (dst + width); ++p) {
*p = value;
}
dst += dst_skip;
}
}