eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

Everywhere: Rename IncrementallyPopulatedStream::reached_end_of_body

Browse Source 
This needs to be called even if we haven't reached the end of the body,
so let's call it close() instead.
This commit is contained in:
Zaggy1024
2026-02-09 14:10:37 -06:00
committed by Gregory Bertilson
parent 15d0bc86fc
commit af45418fbf
Notes: github-actions[bot] 2026-02-18 19:15:27 +00:00 
Author: https://github.com/Zaggy1024
Commit: https://github.com/LadybirdBrowser/ladybird/commit/af45418fbfd
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7922
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibMedia/IncrementallyPopulatedStream.cpp
View File

@@ -23,7 +23,7 @@ NonnullRefPtr<IncrementallyPopulatedStream> IncrementallyPopulatedStream::create
{
auto stream = create_empty();
stream->add_chunk_at(0, data);
stream->reached_end_of_body();
stream->close();
VERIFY(stream->size() == data.size());
return stream;
}
@@ -94,7 +94,7 @@ void IncrementallyPopulatedStream::add_chunk_at(u64 offset, ReadonlyBytes data)
m_state_changed.broadcast();
}
void IncrementallyPopulatedStream::reached_end_of_body()
void IncrementallyPopulatedStream::close()
{
Threading::MutexLocker locker { m_mutex };
m_expected_size = m_last_chunk_end;

2
Libraries/LibMedia/IncrementallyPopulatedStream.h
View File

@@ -40,7 +40,7 @@ public:
void add_chunk_at(u64 offset, ReadonlyBytes);
void reached_end_of_body();
void close();
u64 size();
void set_expected_size(u64);

4
Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View File

@@ -989,7 +989,7 @@ void HTMLMediaElement::fetch_resource(URL::URL const& url_record, Function<void(
});
fetch_data->failure_callback = [&stream = *fetch_data->stream, failure_callback = move(failure_callback)](String error_message) {
// Ensure that we unblock any reads if we stop the fetch due to some failure.
stream.reached_end_of_body();
stream.close();
failure_callback(move(error_message));
};
@@ -1141,7 +1141,7 @@ void HTMLMediaElement::fetch_resource(NonnullRefPtr<FetchData> const& fetch_data
if (fetch_generation != weak_self->m_current_fetch_generation)
return;
fetch_data->stream->reached_end_of_body();
fetch_data->stream->close();
weak_self->queue_a_media_element_task([&self = *weak_self] {
self.process_media_data(FetchingStatus::Complete).release_value_but_fixme_should_propagate_errors();
});

2
Tests/LibMedia/TestIncrementallyPopulatedStream.cpp
View File

@@ -143,7 +143,7 @@ TEST_CASE(add_chunks_incrementally)
stream->add_chunk_at(0, data.bytes().trim(50));
stream->add_chunk_at(50, data.bytes().slice(50));
stream->reached_end_of_body();
stream->close();
EXPECT(stream->expected_size().has_value());
EXPECT_EQ(stream->expected_size().value(), data_size);