eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

WebContent: Remove unused get_window_handle() IPC method

Browse Source 
This is no longer used.
This commit is contained in:
Tim Ledbetter
2026-02-14 22:49:52 +00:00
committed by Tim Flynn
parent cb803899c2
commit e0cb38f544
Notes: github-actions[bot] 2026-02-15 13:22:46 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/e0cb38f5443
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7889
Reviewed-by: https://github.com/trflynn89
3 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Services/WebContent/WebDriverClient.ipc
View File

@@ -16,7 +16,6 @@ endpoint WebDriverClient {
forward() => (Web::WebDriver::Response response)
refresh() => (Web::WebDriver::Response response)
get_title() => (Web::WebDriver::Response response)
get_window_handle() => (Web::WebDriver::Response response)
close_window() => (Web::WebDriver::Response response)
switch_to_window(String handle) => (Web::WebDriver::Response response)
new_window(JsonValue payload) => (Web::WebDriver::Response response)

10
Services/WebContent/WebDriverConnection.cpp
View File

@@ -553,16 +553,6 @@ Messages::WebDriverClient::GetTitleResponse WebDriverConnection::get_title()
return JsonValue {};
}
// 11.1 Get Window Handle, https://w3c.github.io/webdriver/#get-window-handle
Messages::WebDriverClient::GetWindowHandleResponse WebDriverConnection::get_window_handle()
{
// 1. If session's current top-level browsing context is no longer open, return error with error code no such window.
TRY(ensure_current_top_level_browsing_context_is_open());
// 2. Return success with data being the window handle associated with session's current top-level browsing context.
return JsonValue { current_top_level_browsing_context()->top_level_traversable()->window_handle() };
}
// 11.2 Close Window, https://w3c.github.io/webdriver/#dfn-close-window
Messages::WebDriverClient::CloseWindowResponse WebDriverConnection::close_window()
{

1
Services/WebContent/WebDriverConnection.h
View File

@@ -59,7 +59,6 @@ private:
virtual Messages::WebDriverClient::ForwardResponse forward() override;
virtual Messages::WebDriverClient::RefreshResponse refresh() override;
virtual Messages::WebDriverClient::GetTitleResponse get_title() override;
virtual Messages::WebDriverClient::GetWindowHandleResponse get_window_handle() override;
virtual Messages::WebDriverClient::CloseWindowResponse close_window() override;
virtual Messages::WebDriverClient::SwitchToWindowResponse switch_to_window(String handle) override;
virtual Messages::WebDriverClient::NewWindowResponse new_window(JsonValue payload) override;