mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-05-11 17:37:33 +02:00
d1fc4b4234
Previously, presentational hints bypassed the regular cascade pipeline and wrote directly into `CascadedProperties` under `CascadeOrigin::Author`. That meant `var()` substitution and the invalid-at-computed-value-time fallback had to be duplicated in a separate per-element pass, which in practice missed the IACVT step and could leave a `GuaranteedInvalidStyleValue` in the cascaded properties. This caused a crash in downstream code that assumed the value had been resolved. This introduces an `AuthorPresentationalHint` cascade origin and feeds them through the cascade as normal declarations. This means that `var()` resolution now happens in only one place.
85 lines
3.5 KiB
C++
85 lines
3.5 KiB
C++
/*
|
|
* Copyright (c) 2020, the SerenityOS developers.
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWeb/Bindings/HTMLEmbedElement.h>
|
|
#include <LibWeb/Bindings/Intrinsics.h>
|
|
#include <LibWeb/CSS/ComputedProperties.h>
|
|
#include <LibWeb/CSS/StyleValues/DisplayStyleValue.h>
|
|
#include <LibWeb/CSS/StyleValues/KeywordStyleValue.h>
|
|
#include <LibWeb/HTML/HTMLEmbedElement.h>
|
|
#include <LibWeb/HTML/Parser/HTMLParser.h>
|
|
|
|
namespace Web::HTML {
|
|
|
|
GC_DEFINE_ALLOCATOR(HTMLEmbedElement);
|
|
|
|
HTMLEmbedElement::HTMLEmbedElement(DOM::Document& document, DOM::QualifiedName qualified_name)
|
|
: HTMLElement(document, move(qualified_name))
|
|
{
|
|
}
|
|
|
|
HTMLEmbedElement::~HTMLEmbedElement() = default;
|
|
|
|
void HTMLEmbedElement::initialize(JS::Realm& realm)
|
|
{
|
|
WEB_SET_PROTOTYPE_FOR_INTERFACE(HTMLEmbedElement);
|
|
Base::initialize(realm);
|
|
}
|
|
|
|
bool HTMLEmbedElement::is_presentational_hint(FlyString const& name) const
|
|
{
|
|
if (Base::is_presentational_hint(name))
|
|
return true;
|
|
|
|
return first_is_one_of(name,
|
|
HTML::AttributeNames::align,
|
|
HTML::AttributeNames::height,
|
|
HTML::AttributeNames::hspace,
|
|
HTML::AttributeNames::vspace,
|
|
HTML::AttributeNames::width);
|
|
}
|
|
|
|
void HTMLEmbedElement::apply_presentational_hints(Vector<CSS::StyleProperty>& properties) const
|
|
{
|
|
Base::apply_presentational_hints(properties);
|
|
for_each_attribute([&](auto& name, auto& value) {
|
|
if (name == HTML::AttributeNames::align) {
|
|
if (value.equals_ignoring_ascii_case("center"sv))
|
|
properties.append({ .property_id = CSS::PropertyID::TextAlign, .value = CSS::KeywordStyleValue::create(CSS::Keyword::Center) });
|
|
else if (value.equals_ignoring_ascii_case("middle"sv))
|
|
properties.append({ .property_id = CSS::PropertyID::TextAlign, .value = CSS::KeywordStyleValue::create(CSS::Keyword::Middle) });
|
|
} else if (name == HTML::AttributeNames::height) {
|
|
if (auto parsed_value = parse_dimension_value(value))
|
|
properties.append({ .property_id = CSS::PropertyID::Height, .value = *parsed_value });
|
|
}
|
|
// https://html.spec.whatwg.org/multipage/rendering.html#attributes-for-embedded-content-and-images:maps-to-the-dimension-property
|
|
else if (name == HTML::AttributeNames::hspace) {
|
|
if (auto parsed_value = parse_dimension_value(value)) {
|
|
properties.append({ .property_id = CSS::PropertyID::MarginLeft, .value = *parsed_value });
|
|
properties.append({ .property_id = CSS::PropertyID::MarginRight, .value = *parsed_value });
|
|
}
|
|
} else if (name == HTML::AttributeNames::vspace) {
|
|
if (auto parsed_value = parse_dimension_value(value)) {
|
|
properties.append({ .property_id = CSS::PropertyID::MarginTop, .value = *parsed_value });
|
|
properties.append({ .property_id = CSS::PropertyID::MarginBottom, .value = *parsed_value });
|
|
}
|
|
} else if (name == HTML::AttributeNames::width) {
|
|
if (auto parsed_value = parse_dimension_value(value)) {
|
|
properties.append({ .property_id = CSS::PropertyID::Width, .value = *parsed_value });
|
|
}
|
|
}
|
|
});
|
|
}
|
|
|
|
void HTMLEmbedElement::adjust_computed_style(CSS::ComputedProperties& style)
|
|
{
|
|
// https://drafts.csswg.org/css-display-3/#unbox
|
|
if (style.display().is_contents())
|
|
style.set_property(CSS::PropertyID::Display, CSS::DisplayStyleValue::create(CSS::Display::from_short(CSS::Display::Short::None)));
|
|
}
|
|
|
|
}
|